[{"id":3673382,"web_url":"http://patchwork.ozlabs.org/comment/3673382/","msgid":"","list_archive_url":null,"date":"2026-04-03T23:23:33","subject":"Re: [PATCH v3 4/6] board: nxp: imx9{4,5,52}_evk: Add qb save option\n in SPL","submitter":{"id":85664,"url":"http://patchwork.ozlabs.org/api/people/85664/","name":"Marek Vasut","email":"marek.vasut@mailbox.org"},"content":"On 4/2/26 11:40 AM, Simona Toaca (OSS) wrote:\n\n[...]\n\n> +++ b/arch/arm/mach-imx/Kconfig\n> @@ -71,6 +71,14 @@ config CSF_SIZE\n> \t Define the maximum size for Command Sequence File (CSF) binary\n> \t this information is used to define the image boot data.\n> \n> +config SPL_IMX_QB\n> +\tbool \"Run qb save during SPL\"\n> +\tdepends on SPL && (IMX94 || IMX95 || IMX952)\n> +\thelp\n> +\t Automatically save DDR training data (Quickboot data)\n> +\t to current boot device when needed (when OEI runs Training\n> +\t flow and saves qb data to volatile memory).\n> +\n> config CMD_IMX_QB\n> \tbool \"Support the 'qb' command\"\n> \tdefault y\n> diff --git a/arch/arm/mach-imx/imx9/Makefile b/arch/arm/mach-imx/imx9/Makefile\n> index 3e323a714c1..8b01897b928 100644\n> --- a/arch/arm/mach-imx/imx9/Makefile\n> +++ b/arch/arm/mach-imx/imx9/Makefile\n> @@ -14,6 +14,8 @@ ifneq ($(CONFIG_SPL_BUILD),y)\n> obj-y += imx_bootaux.o\n> endif\n> \n> -ifneq ($(CONFIG_XPL_BUILD),y)\n> +ifeq ($(CONFIG_XPL_BUILD),y)\n> +obj-$(CONFIG_SPL_IMX_QB) += qb.o\n> +else\n> obj-$(CONFIG_CMD_IMX_QB) += qb.o\n> endif\n\nThe qb.o should not be gated beyond CONFIG_CMD_IMX_QB , the \nCONFIG_CMD_IMX_QB is used to gate cmd_qb.o . Fix this and introduce \nCONFIG_IMX_QB to gate the core code, then do this to simplify the \nconditional:\n\nobj-$(CONFIG_$(PHASE_)IMX_QB += qb.o\n\n...\n\nAlso, changes to arch/ should be part of 1/6 .","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=mailbox.org header.i=@mailbox.org header.a=rsa-sha256\n header.s=mail20150812 header.b=h22NDijQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=mailbox.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n secure) header.d=mailbox.org header.i=@mailbox.org header.b=\"h22NDijQ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=mailbox.org","phobos.denx.de;\n spf=pass smtp.mailfrom=marek.vasut@mailbox.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnkDm4BZcz1xtJ\n\tfor ; Sat, 04 Apr 2026 16:10:16 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4131584150;\n\tSat, 4 Apr 2026 07:09:55 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 61D538407E; Sat, 4 Apr 2026 07:09:54 +0200 (CEST)","from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 83DFE8407E\n for ; Sat, 4 Apr 2026 07:09:52 +0200 (CEST)","from smtp102.mailbox.org (smtp102.mailbox.org\n [IPv6:2001:67c:2050:b231:465::102])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4fnkDG5Fhwz9tnJ;\n Sat, 4 Apr 2026 07:09:50 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.5 required=5.0 tests=BAYES_00, DATE_IN_PAST_03_06,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED,\n RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org;\n s=mail20150812; t=1775279390;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/Hu/TjDPf87o26yaiqfVLWUmVUSBzYBEye82XsQZhIo=;\n b=h22NDijQtXXCfKsjHNw1FUXEZw8n0Ed2mBjKKqcU/0pfI37nlpw7ttdL8reuKRAB4Vabcj\n /uHB7gO6q4yDbuwjRuaYW1N2NZN4NDwubutWeN3eDZ71cWkpWCDZSvDbv586U9/6Kom3b9\n U73m66eQruhOsijSsyQO2dBU7+8+IlLpgmD6c9TDb7quCBPw6nk7aFkbVqwV65cRyIidSQ\n gBMOP5Lvfjcc95tFXHxh00Xa4j1JLmiv3Jo5yqJKz1Rv3XB8G9xrIJJJ3xWWOfWFUqk+NW\n MpvsRXwnYXrMmGFMIjYmTbd+IbpBoWX+/AuEEl1t+WKSUq60nslSQLKxyG8G2w==","Message-ID":"","Date":"Sat, 4 Apr 2026 01:23:33 +0200","MIME-Version":"1.0","From":"Marek Vasut ","Subject":"Re: [PATCH v3 4/6] board: nxp: imx9{4,5,52}_evk: Add qb save option\n in SPL","To":"\"Simona Toaca (OSS)\" , uboot-imx@nxp.com,\n u-boot@lists.denx.de","Cc":"Stefano Babic , festevam@gmail.com,\n peng.fan@nxp.com, alice.guo@nxp.com, viorel.suman@nxp.com,\n simona.toaca@nxp.com, ye.li@nxp.com, ping.bai@nxp.com,\n sebastien.szymanski@armadeus.com, ravi@prevas.dk,\n joao.goncalves@toradex.com, ji.luo@nxp.com, semen.protsenko@linaro.org,\n tharvey@gateworks.com, qijian.guo@nxp.com","References":"\n ","Content-Language":"en-US","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-MBO-RS-META":"qexhsk97tzxcpkwqae5cn76c5ygrzf7j","X-MBO-RS-ID":"66976cd776ecac2056e","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]