[{"id":3673366,"web_url":"http://patchwork.ozlabs.org/comment/3673366/","msgid":"","list_archive_url":null,"date":"2026-04-04T02:28:21","subject":"Re: [PATCH] ksmbd: fix use-after-free in __ksmbd_close_fd() lock\n cleanup","submitter":{"id":79386,"url":"http://patchwork.ozlabs.org/api/people/79386/","name":"Namjae Jeon","email":"linkinjeon@kernel.org"},"content":"On Thu, Apr 2, 2026 at 5:39 PM munan Huang wrote:\n>\n> In __ksmbd_close_fd(), when cleaning up byte-range locks on a durable\n> file handle closed by the scavenger, the lock cleanup loop\n> unconditionally dereferences fp->conn->llist_lock to remove each lock\n> from the connection's list:\n>\n> list_for_each_entry_safe(smb_lock, tmp_lock, &fp->lock_list, flist) {\n> spin_lock(&fp->conn->llist_lock);\n> list_del(&smb_lock->clist);\n> spin_unlock(&fp->conn->llist_lock);\n> }\n>\n> However, when a client disconnects without SMB2 LOGOFF, ksmbd preserves\n> durable file handles via session_fd_check(), which sets fp->conn to\n> NULL and arms the durable scavenger timeout, but does not detach the\n> byte-range locks from the dying connection's lock list.\n>\n> When the scavenger timeout expires, ksmbd_durable_scavenger() calls\n> __ksmbd_close_fd(NULL, fp). At this point fp->conn is NULL and the\n> original connection object has already been freed by ksmbd_conn_free(),\n> so it would cause a use-after-free or NULL pointer dereference.\n>\n> Fix by checking fp->conn for NULL before accessing fp->conn->llist_lock\n> in the lock cleanup loop.\n>\n> Fixes: c8efcc786146 (\"ksmbd: add support for durable handles v1/v2\")\n> Cc: stable@vger.kernel.org\n> Signed-off-by: munan Huang \nI will apply the following patch instead of your patch. Let me know if\nI am missing something.\nhttps://github.com/smfrench/smb3-kernel/commit/319ca5432460b0749e420f7cff637dfbc7e16be3\nThanks.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=GgC4YiP/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10659-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"GgC4YiP/\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnffm1dmLz1xtJ\n\tfor ; Sat, 04 Apr 2026 13:29:04 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C422E300D321\n\tfor ; Sat, 4 Apr 2026 02:28:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 40B9F256C61;\n\tSat, 4 Apr 2026 02:28:35 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D9FA2628D\n\tfor ; Sat, 4 Apr 2026 02:28:35 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 03594C2BCB3\n\tfor ; Sat, 4 Apr 2026 02:28:35 +0000 (UTC)","by mail-ed1-f51.google.com with SMTP id\n 4fb4d7f45d1cf-66a33f61d80so4222044a12.0\n for ;\n Fri, 03 Apr 2026 19:28:34 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775269715; cv=none;\n b=O/yIhw/cGNiat+MqH49RzthS1IP8wOeJQAFYFwg67yzfvsNUDcEBon5gwDPmt8hiKwKC1y2D5m6dzMgLaALxIfatbv67vcK4mh1xW1md4VLm9qYKWx2UQCJgfdy8TrOAMnSNLO08pPWQAwZARy0o6OnLSloYAG9rt88VoUhtVjU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775269715; c=relaxed/simple;\n\tbh=u4CUB0iQJSw1BJ7hyMEtZYGmMQ3t+SQ2foySZre2HZw=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=ljSWjd/y51+rfjIOKktBlvX0T0U5KV3prPY5ci+btYM5IUHEKgvmSAb8bx/fbYgZFIo+CNkiUPIyZFG5zBas+/y1CyVLjRIXz7iE4ryF/uSwyKx7VZbL+yE80zdbxdA6vdfBUnA/BGKmxhq0ju3UGt5corXrRfuJJ9e7x/mAOEc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=GgC4YiP/; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775269715;\n\tbh=u4CUB0iQJSw1BJ7hyMEtZYGmMQ3t+SQ2foySZre2HZw=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=GgC4YiP/yQWr9dXnzXBMmQK2RhCKNaER9+hPUPLQgaEMLY/qPefqEgZ5mEfoSD0SR\n\t a819wLoxl+tBXs3iQ0hEsfXPHvskEiuBOQXtAeSI9XnXFvC2YuU8Ck5F2TS2GyLU5o\n\t 2fCmBgsdYe+IpD+firuy3RmAQ4+a5O7z+ufwzFIwrOHlAvik+pDUXQz2iFd73sWJJI\n\t dd9VbHcpDzfEaglgnBDFKEPrlh5FG21j7B9tI7RPlrJLow8x/K6zjE3mRIi9rDkgHz\n\t w9Aj7L1ivyZC2vjx3a1tNTfCGStYGMq5nVRegLOlpaJXtI4sHCI7zhRXaOrgFFmMGU\n\t dVZcc0ceJvHmw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWyoBAb0ksaPcSg10N8xOg9mpuZNf261B6ETERFxne1D7t9E2HTiOMaOJblHULuoQ+dmIofSyX2DHiZ@vger.kernel.org","X-Gm-Message-State":"AOJu0YxQrD4uv9nJGYRpg1vr55X9G+7nUiiHzPZTHLKwqxUZAzVI5a+F\n\tjk6k3Wavr2bhk/ekbUT4bpogeHrbAKnwowhbnsFqIwDj0NgWPhiSNu0bGeeJQqQoEMHxEfWqyFn\n\t8cL5cQ+dvic5xJehUkYwXA8+izRW1LpE=","X-Received":"by 2002:a05:6402:26d3:b0:66e:8ce7:5461 with SMTP id\n 4fb4d7f45d1cf-66e8ce7565fmr201222a12.16.1775269713325; Fri, 03 Apr 2026\n 19:28:33 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260402083912.457676-1-munanevil@gmail.com>","In-Reply-To":"<20260402083912.457676-1-munanevil@gmail.com>","From":"Namjae Jeon ","Date":"Sat, 4 Apr 2026 11:28:21 +0900","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzCSnlJK3jQXwHW0ZwawgQUy3hrfgEGqFuO6mYbofu7ZSWzZ9MVCsRM4g4g","Message-ID":"\n ","Subject":"Re: [PATCH] ksmbd: fix use-after-free in __ksmbd_close_fd() lock\n cleanup","To":"munan Huang ","Cc":"smfrench@gmail.com, senozhatsky@chromium.org, tom@talpey.com,\n\tlinux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tstable@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3673378,"web_url":"http://patchwork.ozlabs.org/comment/3673378/","msgid":"<904cb9a8-2ff5-4725-8ce2-f70c4f98791e@chenxiaosong.com>","list_archive_url":null,"date":"2026-04-04T05:02:07","subject":"Re: [PATCH] ksmbd: fix use-after-free in __ksmbd_close_fd() lock\n cleanup","submitter":{"id":88754,"url":"http://patchwork.ozlabs.org/api/people/88754/","name":"ChenXiaoSong","email":"chenxiaosong@chenxiaosong.com"},"content":"Hi Namjae and munan,\n\nIn `ksmbd_reopen_durable_fd()`, when -EBADF is returned, should \n`list_del(&smb_lock->clist)` be called?\n\nIf my understanding is incorrect, please let me know.\n\n> \n> int ksmbd_reopen_durable_fd(struct ksmbd_work *work, struct ksmbd_file *fp)\n> {\n> \t...\n> \tfp->conn = conn;\n> \t...\n> \n> \tlist_for_each_entry(smb_lock, &fp->lock_list, flist) {\n> \t\tspin_lock(&conn->llist_lock);\n> \t\tlist_add_tail(&smb_lock->clist, &conn->lock_list);\n> \t\tspin_unlock(&conn->llist_lock);\n> \t}\n> \t...\n> \t__open_id(&work->sess->file_table, fp, OPEN_ID_TYPE_VOLATILE_ID);\n> \tif (!has_file_id(fp->volatile_id)) {\n> \t\tfp->conn = NULL;\n> \t\tfp->tcon = NULL;\n> \t\treturn -EBADF;\n> \t}\n> \treturn 0;\n> }\n\nThanks,\nChenXiaoSong \n\nOn 4/4/26 10:28, Namjae Jeon wrote:\n> I will apply the following patch instead of your patch. Let me know if\n> I am missing something.\n> https://github.com/smfrench/smb3-kernel/ \n> commit/319ca5432460b0749e420f7cff637dfbc7e16be3\n> Thanks.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10660-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=chenxiaosong.com header.i=@chenxiaosong.com\n header.b=\"nCBdwPR3\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=91.218.175.177","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=chenxiaosong.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=chenxiaosong.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnk4r0Ry9z1yCs\n\tfor ; Sat, 04 Apr 2026 16:03:23 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E5D1D30329B9\n\tfor ; Sat, 4 Apr 2026 05:03:12 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C510B3246EF;\n\tSat, 4 Apr 2026 05:03:12 +0000 (UTC)","from out-177.mta0.migadu.com (out-177.mta0.migadu.com\n [91.218.175.177])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 083D5330B11\n\tfor ; Sat, 4 Apr 2026 05:03:08 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775278992; cv=none;\n b=FBb6au/0J29/lBdolLveAZnjv8u+jgS9CQ/9YF6mntzLy6Ql6hTxOuCUK3OWin5FkEVRP+7uO/uQmcWobjUUxetzzp19Yegc8Vt3TzgEQlDuYBhmmnK4ssVlEof7BiAd9w1J7FVneFME9QmqZgjtIoGQNq7fIcstbdz2tO9HxrA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775278992; c=relaxed/simple;\n\tbh=ljLqHN4/YU54zGex0W8bOwmzab78gDAvWCE9IC2QNmc=;\n\th=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=uPQ5smYeutK33A2hfpE4padBeIn4hciHsJEKVc/DRyp100GsYh0amFNbARlIYUEfpU3ItCgQRYvmqnbcLki093Sw615WDfAGF5diT2Snp3Iv8ZA+pEV3o10DwSz9GoDUzS+ilix3INW4AVG4hW+4Xrwd6p3F0wSEgha+h5Ku34E=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=chenxiaosong.com;\n spf=pass smtp.mailfrom=chenxiaosong.com;\n dkim=pass (2048-bit key) header.d=chenxiaosong.com header.i=@chenxiaosong.com\n header.b=nCBdwPR3; arc=none smtp.client-ip=91.218.175.177","Message-ID":"<904cb9a8-2ff5-4725-8ce2-f70c4f98791e@chenxiaosong.com>","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chenxiaosong.com;\n\ts=key1; t=1775278977;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=1U6dk8yrKlB+wf4qSWlG//ZdhnWAEAWP8rEKm7hKPZo=;\n\tb=nCBdwPR379jAGtjbyJXkAU75EJIIo5aFPgZMv4MModTb9rEN7HGKo5+c9qgZvSFEN0059b\n\t6X7VG63byGYf9Kmf6LEtZ9x76KeVT3frDZaTxcl/7t/b2923QqTTq/nFRHvTQgaPtxwdyQ\n\tK9pU2z81l/wwOR1opkyRmG4S+gQMUmJbrSMKPTERf4YG99rmjGlvPNnMUJZPwAkfZlF7jB\n\tnRdb1HjH7fmeQ4lpJFOnx8IxQ6l8FvKZnj7kBBBMPKYu51RGYRniX81jrUVriy2Bz26fN+\n\t5Qqqxc8qnzHSA1B6y69Ay+N0jHzUVv/UATYOPWGsXbDFmE3N4qu+c6cQNOxqBg==","Date":"Sat, 4 Apr 2026 13:02:07 +0800","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-Report-Abuse":"Please report any abuse attempt to abuse@migadu.com and\n include these headers.","From":"ChenXiaoSong ","Subject":"Re: [PATCH] ksmbd: fix use-after-free in __ksmbd_close_fd() lock\n cleanup","To":"Namjae Jeon , munan Huang ","Cc":"smfrench@gmail.com, senozhatsky@chromium.org, tom@talpey.com,\n linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,\n stable@vger.kernel.org","References":"<20260402083912.457676-1-munanevil@gmail.com>\n ","Content-Language":"en-US","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Migadu-Flow":"FLOW_OUT"}},{"id":3673448,"web_url":"http://patchwork.ozlabs.org/comment/3673448/","msgid":"","list_archive_url":null,"date":"2026-04-04T14:28:12","subject":"Re: [PATCH] ksmbd: fix use-after-free in __ksmbd_close_fd() lock\n cleanup","submitter":{"id":79386,"url":"http://patchwork.ozlabs.org/api/people/79386/","name":"Namjae Jeon","email":"linkinjeon@kernel.org"},"content":"On Sat, Apr 4, 2026 at 2:03 PM ChenXiaoSong\n wrote:\n>\n> Hi Namjae and munan,\n>\n> In `ksmbd_reopen_durable_fd()`, when -EBADF is returned, should\n> `list_del(&smb_lock->clist)` be called?\n>\n> If my understanding is incorrect, please let me know.\nI have updated the patch. Please check it.\nhttps://github.com/smfrench/smb3-kernel/commit/38bf2f4ac44b0848677fd4d539404b8c0de15b98\n\nThanks for the review!","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=lHn8yRTa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10661-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"lHn8yRTa\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnycv0NG6z1xtJ\n\tfor ; Sun, 05 Apr 2026 01:28:30 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 71596300BDAA\n\tfor ; Sat, 4 Apr 2026 14:28:27 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id AEA071BD9C9;\n\tSat, 4 Apr 2026 14:28:26 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 867F36F2F2\n\tfor ; Sat, 4 Apr 2026 14:28:26 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 3D564C4AF09\n\tfor ; Sat, 4 Apr 2026 14:28:26 +0000 (UTC)","by mail-ed1-f54.google.com with SMTP id\n 4fb4d7f45d1cf-66d65646c65so1925887a12.1\n for ;\n Sat, 04 Apr 2026 07:28:26 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775312906; cv=none;\n b=ZeW7TAfOL+6e3rv/GZaTJPLB9/HWB0UfSQXcri5HeJe4/N2kouRF6BIA6Nyq6MN2jvSetaHVx+Wsxwl2q+JsOEEiud1PrklxehJyQKeVQCwjz8EKQGL/QppnV1y/l6B2z6WIEB09HLIwAc8b5L50hYH1rBrxPKWcKtUbCsstCCA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775312906; c=relaxed/simple;\n\tbh=OUskXKzbth7ggJphATMPraSMFrxkBsGJGt1vZJpuYsE=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=I4ygi7174bGegobQBF+e/+eeqyke6lfYF6Dp4y80qADiPHRNM5luIFXoMfuEINvOMC5OMJpu4DHcDfq3Wye93GNOfHANpg0LVzMd8kprh+JgwhFEUNPW3eD2YlxhkatDcKGwgX4tP1usqnSV+rg8AWhw7H7GmkLuN+Qcp2RSLvY=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=lHn8yRTa; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775312906;\n\tbh=OUskXKzbth7ggJphATMPraSMFrxkBsGJGt1vZJpuYsE=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=lHn8yRTazkanj8XCubilvX701IGuS/ROzTEPPKSr/iU7yZl+OKaPpvj/hXPSOlDOk\n\t 1OQ27oQu8FtunopQ4ENg4S7gxcrjhhz3VPjbJxrLTRJ3poE9mGrIVJlWj0QDISF1wV\n\t VKVliYQbob8xd8zs0yJH94vQRyBCYjmhQbhjCEeeiBAjNJ/tyg5hug9QTYosy76nqE\n\t +xY2f1zED4Xd5B0wqhgak47GqkKU89EaumQ2VErHKXgQMuz+qRaqzd/cCK54rRN4Sy\n\t /vJMfJnATzVleh8c612OqpSYQrLcvof4w7AQWwVUXcjMrYjvCZT5J5r2URfZy8vrjm\n\t jpQZf3OrBBzcA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXRziowyCJX8dvMpnBXU6txc/0kDJeMY3PCIPBqKnSWv7ps1i4QdpK8sV3Q1rPK/uzKKYisT1URyX9B@vger.kernel.org","X-Gm-Message-State":"AOJu0YzLlg3t5kVka0EOD5R8lI6mHQy5df3l8zhgOfzTNY8408DKXkSm\n\tZO1aTV03+A5f3dIWnFIZdVG2sJgan1xvF8A5LA5jzaawF8r+ozswkDtfR+ecTM0w+9uwRtBJdWI\n\tSHFXKz40lJWbMSaiWyr2F/U7aO6Zxkq0=","X-Received":"by 2002:a05:6402:5254:b0:66e:192c:e5bf with SMTP id\n 4fb4d7f45d1cf-66e3e3f39ebmr3148063a12.7.1775312904616; Sat, 04 Apr 2026\n 07:28:24 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260402083912.457676-1-munanevil@gmail.com>\n \n <904cb9a8-2ff5-4725-8ce2-f70c4f98791e@chenxiaosong.com>","In-Reply-To":"<904cb9a8-2ff5-4725-8ce2-f70c4f98791e@chenxiaosong.com>","From":"Namjae Jeon ","Date":"Sat, 4 Apr 2026 23:28:12 +0900","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzBXu3I4dM9IGZndTZBC4_7GX2bYTtUDu3bcdXjsg9He7krPwsJZgvx-Q_Q","Message-ID":"\n ","Subject":"Re: [PATCH] ksmbd: fix use-after-free in __ksmbd_close_fd() lock\n cleanup","To":"ChenXiaoSong ","Cc":"munan Huang , smfrench@gmail.com,\n senozhatsky@chromium.org,\n\ttom@talpey.com, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tstable@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3673451,"web_url":"http://patchwork.ozlabs.org/comment/3673451/","msgid":"<0c6e5209-fd66-45d1-b018-a38b09f5ed80@chenxiaosong.com>","list_archive_url":null,"date":"2026-04-04T14:59:48","subject":"Re: [PATCH] ksmbd: fix use-after-free in __ksmbd_close_fd() lock\n cleanup","submitter":{"id":88754,"url":"http://patchwork.ozlabs.org/api/people/88754/","name":"ChenXiaoSong","email":"chenxiaosong@chenxiaosong.com"},"content":"Looks good to me. Feel free to add:\nReviewed-by: ChenXiaoSong \n\nOn 2026/4/4 22:28, Namjae Jeon wrote:\n> I have updated the patch. Please check it.\n> https://github.com/smfrench/smb3-kernel/commit/38bf2f4ac44b0848677fd4d539404b8c0de15b98\n> \n> Thanks for the review!","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=chenxiaosong.com header.i=@chenxiaosong.com\n header.a=rsa-sha256 header.s=key1 header.b=NE8NvrbW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10662-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=chenxiaosong.com header.i=@chenxiaosong.com\n header.b=\"NE8NvrbW\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=95.215.58.171","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=chenxiaosong.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=chenxiaosong.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnzLt5H1Fz1yG2\n\tfor ; Sun, 05 Apr 2026 02:01:26 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9E89B30107CC\n\tfor ; Sat, 4 Apr 2026 15:00:56 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7C7232765F8;\n\tSat, 4 Apr 2026 15:00:56 +0000 (UTC)","from out-171.mta1.migadu.com (out-171.mta1.migadu.com\n [95.215.58.171])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 769472BE7AC\n\tfor ; Sat, 4 Apr 2026 15:00:54 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775314856; cv=none;\n b=rggDpQ3kuAlKjiPz+u6WLhAmk2q+lkYPiDDvnT7cS0k0AbGGK0U7mMW+Bx34eEmdUkItYtUqO22jSD8xwJv5OO14ygDpL4GdvHFRWT9n3jfYcpFChPQsMfKVzfdy/CyWuZO/IOeXMtLL0nb6B+IrwZxNUy7h4shWb3RMvmykBQ0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775314856; c=relaxed/simple;\n\tbh=V4XnIePq7Gn9DlSSDTyJyCYOunjXqVD0zDyhcNI7n3w=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=ECjgz1sTFyfLKy2sDkbjKwpXvLvdWpV9mnCSXe9/Lcj6r4k0hrEvEN2PN1Sk4wriSbZNAapZHX21DSXeKnyS7V2adg94rt1jnoDT1+X2sVV2NgjX7uMEGCttyN6JCnT+MkQgerMR4pdu7SGmqVLcaviLnOlH6xuxtGnFfcGdzwA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=chenxiaosong.com;\n spf=pass smtp.mailfrom=chenxiaosong.com;\n dkim=pass (2048-bit key) header.d=chenxiaosong.com header.i=@chenxiaosong.com\n header.b=NE8NvrbW; arc=none smtp.client-ip=95.215.58.171","Message-ID":"<0c6e5209-fd66-45d1-b018-a38b09f5ed80@chenxiaosong.com>","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chenxiaosong.com;\n\ts=key1; t=1775314841;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=Wgl30kh7l87lJQQB+ZSLWWPZAIAZEq8WmNjcBcYCYB8=;\n\tb=NE8NvrbWAGJM/W/NVmMhMk9pGBlRXWSFkj4IEkKhbxVzhSdJtHiD+fwHJ7CRXJjnFYyocM\n\tyskZI4uqTvtiKdVI+y4EV0fFEneClDQnUdxyFBscOl9Fb+13It6sS4eSWZhgTL4O28jtEr\n\ts8D9sM7HsCXhKGZWgDNWC4zK5nF3tcIT12IsCfkt2zaClvBR2ZHcAyJ24HUJmFJo2hjIF6\n\tRU1rr3Hsdl7EoRq+V3S2PEMmQs2UcTXc2bM5+cP7Vk/a6+2k+woesYRP0mQh8f1mQ9y56e\n\tVJ5MHkLERzwnDXVAkVh8nOb2rpwFKocu097jd35Y/exBduj3i/kOoBWBvaPmLQ==","Date":"Sat, 4 Apr 2026 22:59:48 +0800","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Subject":"Re: [PATCH] ksmbd: fix use-after-free in __ksmbd_close_fd() lock\n cleanup","To":"Namjae Jeon ","Cc":"munan Huang , smfrench@gmail.com,\n senozhatsky@chromium.org, tom@talpey.com, linux-cifs@vger.kernel.org,\n linux-kernel@vger.kernel.org, stable@vger.kernel.org","References":"<20260402083912.457676-1-munanevil@gmail.com>\n \n <904cb9a8-2ff5-4725-8ce2-f70c4f98791e@chenxiaosong.com>\n ","Content-Language":"en-US","X-Report-Abuse":"Please report any abuse attempt to abuse@migadu.com and\n include these headers.","From":"ChenXiaoSong ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Migadu-Flow":"FLOW_OUT"}}]