[{"id":3672664,"web_url":"http://patchwork.ozlabs.org/comment/3672664/","msgid":"","date":"2026-04-02T10:57:51","subject":"Re: [PATCH v12 02/15] powerpc/crash: Fix possible memory leak in\n update_crash_elfcorehdr()","submitter":{"id":77202,"url":"http://patchwork.ozlabs.org/api/people/77202/","name":"Sourabh Jain","email":"sourabhjain@linux.ibm.com"},"content":"On 02/04/26 12:56, Jinjie Ruan wrote:\n> In get_crash_memory_ranges(), if crash_exclude_mem_range() failed\n> after realloc_mem_ranges() has successfully allocated the cmem\n> memory, it just returns an error but leaves cmem pointing to\n> the allocated memory, nor is it freed in the caller\n> update_crash_elfcorehdr(), which cause a memory leak, goto out\n> to free the cmem.\n>\n> Cc: Sourabh Jain \n> Cc: Hari Bathini \n> Cc: Michael Ellerman \n> Fixes: 849599b702ef (\"powerpc/crash: add crash memory hotplug support\")\n> Signed-off-by: Jinjie Ruan \n> ---\n> arch/powerpc/kexec/crash.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/arch/powerpc/kexec/crash.c b/arch/powerpc/kexec/crash.c\n> index a325c1c02f96..1d12cef8e1e0 100644\n> --- a/arch/powerpc/kexec/crash.c\n> +++ b/arch/powerpc/kexec/crash.c\n> @@ -440,7 +440,7 @@ static void update_crash_elfcorehdr(struct kimage *image, struct memory_notify *\n> \tret = get_crash_memory_ranges(&cmem);\n> \tif (ret) {\n> \t\tpr_err(\"Failed to get crash mem range\\n\");\n> -\t\treturn;\n> +\t\tgoto out;\n> \t}\n> \n> \t/*\nThanks for fixing this Jinjie.\n\nFeel free to add:\nReviewed-by: Sourabh Jain \n\n- Sourabh Jain","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=ojGOrxnC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19213-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.158.5","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=ojGOrxnC;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=sourabhjain@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmf3n0YFxz1yCs\n\tfor ; Thu, 02 Apr 2026 21:58:45 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fmf3m4BFhz2yYK;\n\tThu, 02 Apr 2026 21:58:44 +1100 (AEDT)","from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n [148.163.158.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fmf3l4hynz2xls\n\tfor ; Thu, 02 Apr 2026 21:58:43 +1100 (AEDT)","from pps.filterd (m0360072.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 632AtPbk3747399;\n\tThu, 2 Apr 2026 10:58:12 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d66msbg4c-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 02 Apr 2026 10:58:11 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n\tby ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 6325kFcn022227;\n\tThu, 2 Apr 2026 10:58:10 GMT","from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226])\n\tby ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d6tan9prq-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tThu, 02 Apr 2026 10:58:10 +0000","from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n\tby smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632Aw6Iw45023654\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tThu, 2 Apr 2026 10:58:06 GMT","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3140520043;\n\tThu, 2 Apr 2026 10:58:06 +0000 (GMT)","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D8D1220040;\n\tThu, 2 Apr 2026 10:57:52 +0000 (GMT)","from [9.123.14.142] (unknown [9.123.14.142])\n\tby smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP;\n\tThu, 2 Apr 2026 10:57:52 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775127524;\n\tcv=none;\n b=BLaZ22DtdqHYWktvumPr9rQhRCm4wNaIaOj+yam8lTFreMhNkeuRKxLRtTUEqq3BC8wzEyjAMH8LdreZI/sfVSWWWI0NphGl3iMw/u1nz7olMJDZpiuVFr2vF62fvHewOYa3tpiLN6FdpIvfLOa7uErHlKf6qyLqSumFKaWMy4tzQn7Wq/aVS6CEO7xk/BWxpa5hn8fcKI8HQhDWUdj9ystFzKkX5rPGSkewtdbFNCCpmGfX9YUFMkMn+w8hy873UBYH5icvV4/85QGkXGTolMDu3V2cw2jZr1uEJq8nG047LI1uHbzzHl8D7Zk7x0o5fZhjUi9gswd3/LPlSs1Cww==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775127524; c=relaxed/relaxed;\n\tbh=0gFINy0J7hWuSvPyF4Me4RwxZxrtep5gKamQFyCNyNA=;\n\th=Message-ID:Date:MIME-Version:Subject:To:References:From:\n\t In-Reply-To:Content-Type;\n b=QNm4fEsV/c3kvDUn6v818Cg26udtTqZRNqUNve+k9w2dXrqSWQwnZBIs5tyuNyCP+odvqoEKd5orwoVm7z/ZDxoFsK6L8ivtKJ4549q2ELF8zsoK9Sytxoe8cJKlgq5kxu2E5P5E9HJXPKu2BYZBLn8+O/q/FvkuuHOwK4vZVBihakh8oxg5e1f8T/Y4pB078nq8si/dE0L/hj1D6tVW5bNeLNRO5coVN9SCm/07jUordZ13DqWgwcgtBYiI4XK5Bm78kpdG43zOPblbQPQ2fyYvFIM2F9sLOQoRMDduBESS/reX7QJnyqABj07uvsc2cNL2ZOonyLP9eY/Q9cOlFw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=ojGOrxnC; dkim-atps=neutral;\n spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com;\n envelope-from=sourabhjain@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=\n\tcontent-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=pp1; bh=0gFINy\n\t0J7hWuSvPyF4Me4RwxZxrtep5gKamQFyCNyNA=; b=ojGOrxnCUvdzydYHvSVTnA\n\taCREMJ1+dHb6lGYgjcl+9JLNDbp6kXiIk3LVupebs8lBF9FbGRzard4JbrcKnIEa\n\tX8QYs6M6pLmM8eru24rmv3oIwoMOpfSwd4tTEYkis9zKhhWAx/PePPRgmx2HA3aQ\n\t0OkV3SKLULF74dQ0KXQ9phYk9MZX19fLFD6phVwN/dWFKH2RFT8y0ogAydf2Xqsj\n\tilWshU4BzEGaBjitQBz5UIOWHA7brAkhA0QBpx9cw7AXF63RHml6nNzqfuckqgKD\n\tI36vdi8CYXhm0j5wlLdjPb47elLDBuh2SB6F8M8Bbw8ZeZKQAeY0cWMWfGgcdoyQ\n\t==","Message-ID":"","Date":"Thu, 2 Apr 2026 16:27:51 +0530","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v12 02/15] powerpc/crash: Fix possible memory leak in\n update_crash_elfcorehdr()","To":"Jinjie Ruan , corbet@lwn.net,\n skhan@linuxfoundation.org, catalin.marinas@arm.com, will@kernel.org,\n chenhuacai@kernel.org, kernel@xen0n.name, maddy@linux.ibm.com,\n mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org,\n pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,\n alex@ghiti.fr, tglx@kernel.org, mingo@redhat.com, bp@alien8.de,\n dave.hansen@linux.intel.com, hpa@zytor.com, robh@kernel.org,\n saravanak@kernel.org, akpm@linux-foundation.org, bhe@redhat.com,\n vgoyal@redhat.com, dyoung@redhat.com, rdunlap@infradead.org,\n peterz@infradead.org, pawan.kumar.gupta@linux.intel.com,\n feng.tang@linux.alibaba.com, dapeng1.mi@linux.intel.com,\n kees@kernel.org, elver@google.com, paulmck@kernel.org,\n lirongqing@baidu.com, rppt@kernel.org, leitao@debian.org,\n ardb@kernel.org, jbohac@suse.cz, cfsworks@gmail.com,\n tangyouling@kylinos.cn, ritesh.list@gmail.com, hbathini@linux.ibm.com,\n eajames@linux.ibm.com, guoren@kernel.org, songshuaishuai@tinylab.org,\n kevin.brodsky@arm.com, vishal.moola@gmail.com,\n junhui.liu@pigmoral.tech, coxu@redhat.com, fuqiang.wang@easystack.cn,\n liaoyuanhong@vivo.com, takahiro.akashi@linaro.org,\n james.morse@arm.com,\n lizhengyu3@huawei.com, x86@kernel.org, linux-doc@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,\n linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,\n kexec@lists.infradead.org","References":"<20260402072701.628293-1-ruanjinjie@huawei.com>\n <20260402072701.628293-3-ruanjinjie@huawei.com>","Content-Language":"en-US","From":"Sourabh Jain ","In-Reply-To":"<20260402072701.628293-3-ruanjinjie@huawei.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Authority-Analysis":"v=2.4 cv=J6enLQnS c=1 sm=1 tr=0 ts=69ce4bc4 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8\n a=i0EeH86SAAAA:8 a=VlouDxB3MAwdfIDnmSwA:9 a=QEXdDO2ut3YA:10","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDA5NyBTYWx0ZWRfX7sTiPpQy79zU\n K27F0Aadqv20eVmWi70LMSBPyFOePevJ8HXyavRnK2TMzHBaqSwuLuxWghuZlrQko5p05QNG2B+\n 9Bgt6FzwoOQe968GS2CqUCWPF85d/PVlPRIHZxewHdS/5BZRUaIOvRMExp1EA0wnq/FfmfkRbml\n xUoUXHVAC39mqNXXBSfHbajz0Jy/x3ZUV/ETZpslbrsNw6IuxYsEP9fksyG6DmoBcTvr0vzUs7p\n +NMUSXiYvqxVsqVr2xYwpkjuI4M8zrAJ9QmTnvurotV7fIoCBsSulbmEh6HFEQfxV+LhGIu+pD3\n ZkhK78O/fbw0C/N0oaillpJX3t5VHm7NQrh0Rt1lDmpLs33W+LZxzNIlnrJzPTtWD6qTBPjbzCv\n THCMfLanh5h1/u6vlboXEIhI/aKd0Ic+FIzYIGcrqQgvJfN9B4u08rwVs/g8A7mVn8Dgt16cloJ\n 0Db6BgmrWybcSycnenw==","X-Proofpoint-GUID":"y-dDzylxSChSlhSY3DLcHWQcfmdGadgb","X-Proofpoint-ORIG-GUID":"qB0ckh-l6XGO78PdLdPfSeeapsEZWdAu","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_01,2026-04-02_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n suspectscore=0 clxscore=1011 adultscore=0 priorityscore=1501 bulkscore=0\n phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020097","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]