[{"id":3672693,"web_url":"http://patchwork.ozlabs.org/comment/3672693/","msgid":"<9a376d2d-1456-4283-8504-1a69c74cef62@linux.ibm.com>","list_archive_url":null,"date":"2026-04-02T12:03:58","subject":"Re: [PATCH 02/15] s390x/pci: Create function to contain translation\n status check","submitter":{"id":82902,"url":"http://patchwork.ozlabs.org/api/people/82902/","name":"Christian Borntraeger","email":"borntraeger@linux.ibm.com"},"content":"Am 02.04.26 um 04:29 schrieb Konstantin Shkolnyy:\n> Make it more clear what the bit means, and the new function will be called\n> from yet another place in the future.\n> \n> Signed-off-by: Konstantin Shkolnyy \n> ---\n> hw/s390x/s390-pci-inst.c | 7 ++++++-\n> include/hw/s390x/s390-pci-bus.h | 1 +\n> 2 files changed, 7 insertions(+), 1 deletion(-)\n> \n> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c\n> index 1834596076..7c784b31f3 100644\n> --- a/hw/s390x/s390-pci-inst.c\n> +++ b/hw/s390x/s390-pci-inst.c\n> @@ -993,6 +993,11 @@ int pci_dereg_irqs(S390PCIBusDevice *pbdev)\n> return 0;\n> }\n> \n> +bool s390_pci_is_translation_enabled(uint64_t g_iota)\n> +{\n> + return ((g_iota >> 11) & 0x1) != 0; /* \"T\" bit */\n\nI think from C perspective you can get rid of the != 0 part as\nintegers casts into bool with false=0 and true otherwise.\n\nApart from that\nReviewed-by: Christian Borntraeger \n\n\n\n> +}\n> +\n> static int reg_ioat(CPUS390XState *env, S390PCIBusDevice *pbdev, ZpciFib fib,\n> uintptr_t ra)\n> {\n> @@ -1001,7 +1006,7 @@ static int reg_ioat(CPUS390XState *env, S390PCIBusDevice *pbdev, ZpciFib fib,\n> uint64_t pal = ldq_be_p(&fib.pal);\n> uint64_t g_iota = ldq_be_p(&fib.iota);\n> uint8_t dt = (g_iota >> 2) & 0x7;\n> - uint8_t t = (g_iota >> 11) & 0x1;\n> + bool t = s390_pci_is_translation_enabled(g_iota);\n> \n> pba &= ~0xfff;\n> pal |= 0xfff;\n> diff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h\n> index 9228523ce8..eb15cb8b2d 100644\n> --- a/include/hw/s390x/s390-pci-bus.h\n> +++ b/include/hw/s390x/s390-pci-bus.h\n> @@ -390,6 +390,7 @@ int pci_chsc_sei_nt2_get_event(void *res);\n> int pci_chsc_sei_nt2_have_event(void);\n> void s390_pci_sclp_configure(SCCB *sccb);\n> void s390_pci_sclp_deconfigure(SCCB *sccb);\n> +bool s390_pci_is_translation_enabled(uint64_t g_iota);\n> void s390_pci_iommu_enable(S390PCIIOMMU *iommu);\n> void s390_pci_iommu_direct_map_enable(S390PCIIOMMU *iommu);\n> void s390_pci_iommu_disable(S390PCIIOMMU *iommu);","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=WplQ7VRg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmgXB5vTPz1yGH\n\tfor ; Thu, 02 Apr 2026 23:04:58 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8Gmk-0003Ci-Ab; Thu, 02 Apr 2026 08:04:30 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8Gmd-0003Bp-6w; Thu, 02 Apr 2026 08:04:23 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8Gma-0000rr-UU; Thu, 02 Apr 2026 08:04:22 -0400","from pps.filterd (m0353725.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 631KZKS23948870; Thu, 2 Apr 2026 12:04:04 GMT","from ppma11.dal12v.mail.ibm.com\n (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d65dckscj-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 12:04:04 +0000 (GMT)","from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1])\n by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 6327f4Od008698;\n Thu, 2 Apr 2026 12:04:03 GMT","from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230])\n by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d6v11spbf-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Thu, 02 Apr 2026 12:04:03 +0000","from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com\n [10.20.54.106])\n by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 632C3xlX27460088\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Thu, 2 Apr 2026 12:03:59 GMT","from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 8D4FA2004B;\n Thu, 2 Apr 2026 12:03:59 +0000 (GMT)","from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 2617220040;\n Thu, 2 Apr 2026 12:03:59 +0000 (GMT)","from [9.52.200.39] (unknown [9.52.200.39])\n by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Thu, 2 Apr 2026 12:03:59 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=pp1; bh=oc/x0d\n p7bcNQzXLGZ4aZmw2lGvTo1JdAPhI/5/gOlss=; b=WplQ7VRgn5xMz7r8mjYXzj\n QNcmlAwqQP34y4BpTobpz+Mva70P5NVY02xwTMpWCcsFa9YafMywRei2K6EGyUzW\n /ksoEjshLhvSjHUuygIuVbMZbB1e+yARBeeuo4/uBXgQI2w8lkgjbAaNcQlrsmWz\n Y4pxffDMn6v94QEhFXrecZt+o3cptYRPZ2GKp0Pva+RG7+8TT5Stl9P9357KA93Z\n DLcfOls5sQjB4XhdCTnEBhV8PXTu5yavAwBM/x72VZEY7SK7kuSjFkxzdbT84s8C\n mei+xbFITy/mam8AElEnTZGVY7VrvfMbSkSvaK+uAj6L/rk++8dli0H1J0qJKnpA\n ==","Message-ID":"<9a376d2d-1456-4283-8504-1a69c74cef62@linux.ibm.com>","Date":"Thu, 2 Apr 2026 14:03:58 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 02/15] s390x/pci: Create function to contain translation\n status check","To":"Konstantin Shkolnyy , mjrosato@linux.ibm.com","Cc":"alifm@linux.ibm.com, richard.henderson@linaro.org, iii@linux.ibm.com,\n david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,\n qemu-s390x@nongnu.org, qemu-devel@nongnu.org","References":"<20260402022921.298818-1-kshk@linux.ibm.com>\n <20260402022921.298818-3-kshk@linux.ibm.com>","Content-Language":"en-US","From":"Christian Borntraeger ","In-Reply-To":"<20260402022921.298818-3-kshk@linux.ibm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=RsjI7SmK c=1 sm=1 tr=0 ts=69ce5b34 cx=c_pps\n a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8\n a=B0G84NvrpuzEfJ7AWGAA:9 a=QEXdDO2ut3YA:10","X-Proofpoint-GUID":"G10C_5yCpVN1PgWYYbxxniWAAogvFHRP","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDAyMDEwNiBTYWx0ZWRfX9C5o+wKk2PU3\n jr29j7ZmCoUU7Z8bzsP8wd1QiUKGHRC3puQQ8th/nctc4shNFdLc2SC9xqajH3SCfOqAfvSnKRp\n +XsU3slsWIIMdIHsb2pbvaWWJcw1L6gzCqOFlGHRp/4OXZkfMidb+0YIjC4o6F6W80ljX8u0vIW\n nrpI5DQ5/2VojMtip8gfEEW9lezo6IHpoi2oHRsostwRZwG1xz9bhDz6e6Ohfz/3dZR3is41/ox\n OpIrA0fJc8n+IPZHgJXLnP0WYbhV33Mq6rpMgURMBq6c60LOG+hh47hYvhhwP9kAJr4M01k6vr3\n GbHU+Wyf4od9bZdn687/g3jeoS3hsGFAmpLxt06DNeFcWLGpnclJPVLpYGF6K1BrEPzRfqUNtwr\n l641BNjY7Fk6nCjkCl5i9XxiYUA9yNH/9mj7nStc/d4NiGQ916sNBQza5x1QyFYRF8vmNIJl9yZ\n xrak+s2nel8B2JCTo7A==","X-Proofpoint-ORIG-GUID":"G10C_5yCpVN1PgWYYbxxniWAAogvFHRP","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-02_01,2026-04-02_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n impostorscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0\n suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 phishscore=0\n adultscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2604020106","Received-SPF":"pass client-ip=148.163.158.5;\n envelope-from=borntraeger@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]