[{"id":3672619,"web_url":"http://patchwork.ozlabs.org/comment/3672619/","msgid":"","list_archive_url":null,"date":"2026-04-02T08:53:29","subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","submitter":{"id":74147,"url":"http://patchwork.ozlabs.org/api/people/74147/","name":"Ilias Apalodimas","email":"ilias.apalodimas@linaro.org"},"content":"Hi Randolph\n\nOn Thu, 2 Apr 2026 at 03:14, wrote:\n>\n> From: Randolph Sapp \n>\n> Backfill any fragmented EFI_CONVENTIONAL_MEMORY when LMB allocations\n> start to fail. This may be a low memory environment, or maybe LMB is\n> running up against a tricky reserved region.\n>\n> Signed-off-by: Randolph Sapp \n> ---\n> lib/efi_loader/efi_memory.c | 35 +++++++++++++++++++++++++++++++++--\n> 1 file changed, 33 insertions(+), 2 deletions(-)\n>\n> diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c\n> index 882366a9f8a..f07cc39b157 100644\n> --- a/lib/efi_loader/efi_memory.c\n> +++ b/lib/efi_loader/efi_memory.c\n> @@ -441,6 +441,27 @@ static efi_status_t efi_check_allocated(u64 addr, bool must_be_allocated)\n> return EFI_NOT_FOUND;\n> }\n>\n> +/**\n> + * efi_get_conventional_start - find the highest conventional region start\n> + * address with at least the specified number of\n> + * pages\n> + *\n> + * @pages: number of pages required to be in that carveout\n> + * Return: starting address of the give carveout\n> + */\n> +static u64 efi_get_conventional_start(u64 pages)\n> +{\n> + struct efi_mem_list *item;\n> +\n> + list_for_each_entry(item, &efi_mem, link) {\n> + if (item->desc.type != EFI_CONVENTIONAL_MEMORY)\n> + continue;\n> + if (item->desc.num_pages >= pages)\n> + return item->desc.physical_start;\n> + }\n> + return 0;\n\nWe've been bitten by this in the past and although unlikely 0 is a\nvalid address for some hardware. Can we return something different if\nwe don't find a match? UINT64_MAX perhaps?\n\n> +}\n> +\n> /**\n> * efi_allocate_pages - allocate memory pages\n> *\n> @@ -507,10 +528,20 @@ efi_status_t efi_allocate_pages(enum efi_allocate_type type,\n> /* Reserve that map in our memory maps */\n> ret = efi_update_memory_map(efi_addr, pages, memory_type, true, false);\n\nIn theory the lmb and the EFI maps are in sync. I haven't checked\nclose enough yet, but do you have cases where lmb_alloc worked and\nupdating the efi memory map failed?\n\n> if (ret != EFI_SUCCESS) {\n> - /* Map would overlap, bail out */\n> + /* Map would overlap, try something else */\n> lmb_free(addr, (u64)pages << EFI_PAGE_SHIFT, flags);\n> unmap_sysmem((void *)(uintptr_t)efi_addr);\n> - return EFI_OUT_OF_RESOURCES;\n> +\n> + /* See if there is any EFI_CONVENTIONAL_MEMORY allocations */\n> + if (type != EFI_ALLOCATE_ADDRESS) {\n\nCan you please inverse this. It's going to reduce the identation.\nif (type == EFI_ALLOCATE_ADDRESS)\n> + *memory = efi_get_conventional_start(pages);\n> + if (*memory != 0)\n\nSame here\n\n> + return efi_allocate_pages(EFI_ALLOCATE_ADDRESS,\n> + memory_type, pages,\n> + memory);\n> + }\n> +\n> + return EFI_OUT_OF_RESOURCES;\n> }\n>\n> *memory = efi_addr;\n> --\n> 2.53.0\n>\n\nThanks\n/Ilias","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sKwbVZLo;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"sKwbVZLo\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmbJC4rPbz1yGH\n\tfor ; Thu, 02 Apr 2026 19:54:19 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B9C37839DF;\n\tThu, 2 Apr 2026 10:54:11 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 1AC1B83CF5; Thu, 2 Apr 2026 10:54:10 +0200 (CEST)","from mail-yx1-xb135.google.com (mail-yx1-xb135.google.com\n [IPv6:2607:f8b0:4864:20::b135])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id ACB4280212\n for ; Thu, 2 Apr 2026 10:54:06 +0200 (CEST)","by mail-yx1-xb135.google.com with SMTP id\n 956f58d0204a3-650182d19e0so732501d50.1\n for ; Thu, 02 Apr 2026 01:54:06 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775120045; cv=none;\n d=google.com; s=arc-20240605;\n b=I5uNn3c7coftp/+HB7h8ucogkwiDg593ks/SCDSPj2cCdQkXvvDgkXgCrk0domHj6S\n L4cmHMMjFSyDLDAEt7zR0sPF8D9Oj6TRqZAHta/98wv8fWRaH3AxyOxHXWnDsjZ5IciT\n 6RyHhfdboYk3+Mo+4Z1TMsffPXsomwFqmXPFMOm+j08jMhO0XC60izcfrBUJ8HQGlMD6\n iKrENadBG5bH9uSo9qkhlObYhLB1ZKehiDVm4vvNzGdFGWSN3Ad+4UXsZtUf/33SioSn\n Vv+YcXSj0dkhSPkKZYGAtGkci0fYLXMoX+Vo9dC2G2sG8ff6q3jeJYv+85YyalBHTHuz\n vcNA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=CH/zdqpDm0wm+XK+T+ycCTaVLcwfcswyn65di7+LBhA=;\n fh=bF0/D4lI7iihEPBF+JxHOYqOKuhqjj3MWLIT9zEhIKc=;\n b=k2kQFu2G4LTH+EA6RkEcIlOmkIzwWCQjpbyim+6lItdBgr0R43C5iavr1m4HWUUXfM\n rLkPW7UWHMncY7YYB5p1jqVs4xgUb/srObgDk+oc0X8V/C4/H/ZoHF94/oWdvRsInirH\n 3tjs7MJu2ouJdhgvPME1uqdYIC7R41DLecFUunLXeAjoGpsWUg/X2gYtRx66SRFyJ/9A\n OyefpMcTHhbIecsb8BqakV7nnR8LS1zSUUJGz3aCjVUjMOpx/b8/9zHB10LAu/rK9Bfm\n 4XZYScERiKcCQASEQJ86YIhcMoI7GWahjuPebQb7BSB/FzjVdA11tZSiCcWJ4t3CjQnH\n IZeA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775120045; x=1775724845; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=CH/zdqpDm0wm+XK+T+ycCTaVLcwfcswyn65di7+LBhA=;\n b=sKwbVZLo6QrS+PnmptWMzsGRxQJ25boZQ7aTlRvzqVDlhDtiMLStDtyCyu3UR8h/of\n 8awJgSCqRaD/b85/V6q1ne5KGHT03CaAK+xaV8SkrpNjEIMUMzsareWYH4ju4FEHThH0\n vQDBaMX6Fgb8KeKmB3c+iQLg082d2LhwjhJpSJTLtrgCNZUZR+mdRuYdIdSIf5zXnmPj\n ayi4h45FmA+0xDIJCgd30DvtSzcj3BADZKFwbG6u3z1lWtkkahfqv+I+Cvxy0LRmmPLl\n Zww89Q70XNWh7LyNTbOd/RFeDDcXqwNYTqeE6iQHwMcThU+6C5EXS8sdpaQWR4hBdys+\n bL4g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775120045; x=1775724845;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=CH/zdqpDm0wm+XK+T+ycCTaVLcwfcswyn65di7+LBhA=;\n b=iF4ym98fC2v8ynJAlAIuvyxkoXHhM9VptNS7rWH5Nr8wI2AiAssU/R3QVUiokbbTdm\n oqU1vosmynB8caKP+yie6yEm9woZXQRwy+I7C5Po/DyBm8bPD2hRkh5HFZhoCg8K03XZ\n niULdwzKZdcNMeh2SS13lnkPXjmkH9Ih2/uHSC+pM/Qe87TMH6DFCnHJ1nhITDzhtOmc\n 7n8HuNCWzIIDlzq19EgZeKmYI8Q06csBZBuCnfDJutBDk0ePCf6O0nVo5f7EMWk4laGa\n 3RqcypmESKM/tt8FIjFlRT0elpVlOzuVN0t1Cb4DI1MX5IDXoISkyC2ZufQIvj0sHpTf\n N5Cg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVuQAaUh/GUaYgvHQ6lE1ibxFdcMcDfPXWx0s820weltSI5YsgqelozHAF2W1ZV/tB5PZO6ICs=@lists.denx.de","X-Gm-Message-State":"AOJu0YwYlpJm3Y5TwahNwCwDDW1JzmqT3zfz0Bi5drcX3+k2t+6JZdv9\n gKyeDQ8vrynkUGQza+6kuvYD1ZviTt0Ca5WbLr+0lD+hsRAgdiUgwgW2dZvFgnwAwdz9Y4ebVjy\n MnaCUiL66hSVdkRUoe9mN7vDeaVsllwkbMVHrv4Vokg==","X-Gm-Gg":"AeBDietaCmsosl1as9IHWOydf7tN4JmCzTmh1LCtRBHk7vIRAxoKK848igMb2zxNklE\n 5rGc3XMPmnqXw3A6uCSpsNyti+0ctVq1ABKX4DSeCLrF4N7+Bj14aQdIMDTJMpRAaOZNFNzWQqW\n pbbUTiVZkyPgXgSro+w2nGcUXvK2f5x/2wtLnIH5NwBySCMZnPapM6WYHffWQryursdIaLQMBUP\n LuP9Zi+Xxh+xa4+5T2bnkP52PxlmSL6UfsNyytj+bHDU1ek0grzybpFMnsvYCUuGvNEey8tyj01\n EfvenyWEhbUXAVbBAbQY3Gofrjje9lJ6ZR3FmDJFMoj7FxYErALPPAKOVUZLAZnf8qPZaf5lJdt\n uo32JDNEUmwKmm6bHOVIFNb+JeoykOlC0JK7T2LKdtv5EEUYsiM4gocyqBshf7QOd5ycDZDCROc\n DrbXUhB+DwsrmUvA8ikzel6lonyIpeK6+Uvx3OHgTmtkMzxO+yADRenBQrpndRafMFwu5OJJXfy\n WEj0bXu0m/5+t62vm6zUuYhPBxJO2GR88M1DhMOT0+4XMe/zmACzMTd0p1Nh8KpKqw8JYa0hBe6\n 3QPjZqUkblCLJ8P9lc+vGp1/fnPOmpeMcrDM+O+Pk5db","X-Received":"by 2002:a05:690e:4192:b0:650:36e6:2ace with SMTP id\n 956f58d0204a3-65036e62e0cmr5275716d50.31.1775120045394; Thu, 02 Apr 2026\n 01:54:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20260402001410.3736815-1-rs@ti.com>\n <20260402001410.3736815-6-rs@ti.com>","In-Reply-To":"<20260402001410.3736815-6-rs@ti.com>","From":"Ilias Apalodimas ","Date":"Thu, 2 Apr 2026 11:53:29 +0300","X-Gm-Features":"AQROBzAGYw3W20kdxLrta_gtoSmUXXJIm988S1GGEW0lgoYCGQQIMJdBbRAlb20","Message-ID":"\n ","Subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","To":"rs@ti.com","Cc":"robertcnelson@gmail.com, ayush@beagleboard.org,\n Erik.Welsh@octavosystems.com, anshuld@ti.com, bb@ti.com, trini@konsulko.com,\n afd@ti.com, xypron.glpk@gmx.de, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3672834,"web_url":"http://patchwork.ozlabs.org/comment/3672834/","msgid":"","list_archive_url":null,"date":"2026-04-02T17:32:25","subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","submitter":{"id":88727,"url":"http://patchwork.ozlabs.org/api/people/88727/","name":"Randolph Sapp","email":"rs@ti.com"},"content":"On Thu Apr 2, 2026 at 3:53 AM CDT, Ilias Apalodimas wrote:\n> Hi Randolph\n>\n> On Thu, 2 Apr 2026 at 03:14, wrote:\n>>\n>> From: Randolph Sapp \n>>\n>> Backfill any fragmented EFI_CONVENTIONAL_MEMORY when LMB allocations\n>> start to fail. This may be a low memory environment, or maybe LMB is\n>> running up against a tricky reserved region.\n>>\n>> Signed-off-by: Randolph Sapp \n>> ---\n>> lib/efi_loader/efi_memory.c | 35 +++++++++++++++++++++++++++++++++--\n>> 1 file changed, 33 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c\n>> index 882366a9f8a..f07cc39b157 100644\n>> --- a/lib/efi_loader/efi_memory.c\n>> +++ b/lib/efi_loader/efi_memory.c\n>> @@ -441,6 +441,27 @@ static efi_status_t efi_check_allocated(u64 addr, bool must_be_allocated)\n>> return EFI_NOT_FOUND;\n>> }\n>>\n>> +/**\n>> + * efi_get_conventional_start - find the highest conventional region start\n>> + * address with at least the specified number of\n>> + * pages\n>> + *\n>> + * @pages: number of pages required to be in that carveout\n>> + * Return: starting address of the give carveout\n>> + */\n>> +static u64 efi_get_conventional_start(u64 pages)\n>> +{\n>> + struct efi_mem_list *item;\n>> +\n>> + list_for_each_entry(item, &efi_mem, link) {\n>> + if (item->desc.type != EFI_CONVENTIONAL_MEMORY)\n>> + continue;\n>> + if (item->desc.num_pages >= pages)\n>> + return item->desc.physical_start;\n>> + }\n>> + return 0;\n>\n> We've been bitten by this in the past and although unlikely 0 is a\n> valid address for some hardware. Can we return something different if\n> we don't find a match? UINT64_MAX perhaps?\n>\n>> +}\n>> +\n>> /**\n>> * efi_allocate_pages - allocate memory pages\n>> *\n>> @@ -507,10 +528,20 @@ efi_status_t efi_allocate_pages(enum efi_allocate_type type,\n>> /* Reserve that map in our memory maps */\n>> ret = efi_update_memory_map(efi_addr, pages, memory_type, true, false);\n>\n> In theory the lmb and the EFI maps are in sync. I haven't checked\n> close enough yet, but do you have cases where lmb_alloc worked and\n> updating the efi memory map failed?\n\nFair point. Now that I've fixed the FDT warning I should probably check if I can\nactually reproduce the issue that actually required this.\n\n>> if (ret != EFI_SUCCESS) {\n>> - /* Map would overlap, bail out */\n>> + /* Map would overlap, try something else */\n>> lmb_free(addr, (u64)pages << EFI_PAGE_SHIFT, flags);\n>> unmap_sysmem((void *)(uintptr_t)efi_addr);\n>> - return EFI_OUT_OF_RESOURCES;\n>> +\n>> + /* See if there is any EFI_CONVENTIONAL_MEMORY allocations */\n>> + if (type != EFI_ALLOCATE_ADDRESS) {\n>\n> Can you please inverse this. It's going to reduce the identation.\n> if (type == EFI_ALLOCATE_ADDRESS)\n>> + *memory = efi_get_conventional_start(pages);\n>> + if (*memory != 0)\n>\n> Same here\n>\n>> + return efi_allocate_pages(EFI_ALLOCATE_ADDRESS,\n>> + memory_type, pages,\n>> + memory);\n>> + }\n>> +\n>> + return EFI_OUT_OF_RESOURCES;\n>> }\n>>\n>> *memory = efi_addr;\n>> --\n>> 2.53.0\n>>\n>\n> Thanks\n> /Ilias","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=selector1 header.b=jkVDk4Iv;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"jkVDk4Iv\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de; spf=pass smtp.mailfrom=rs@ti.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmppN0jjGz1yCs\n\tfor ; Fri, 03 Apr 2026 04:32:44 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7D1B784020;\n\tThu, 2 Apr 2026 19:32:35 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id E6ED384056; Thu, 2 Apr 2026 19:32:33 +0200 (CEST)","from CO1PR03CU002.outbound.protection.outlook.com\n (mail-westus2azlp170100005.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c005::5])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5865983F7D\n for ; Thu, 2 Apr 2026 19:32:31 +0200 (CEST)","from CY8PR10CA0006.namprd10.prod.outlook.com (2603:10b6:930:4f::29)\n by SJ2PR10MB7656.namprd10.prod.outlook.com (2603:10b6:a03:53e::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Thu, 2 Apr\n 2026 17:32:27 +0000","from DM2PEPF00003FC5.namprd04.prod.outlook.com\n (2603:10b6:930:4f:cafe::10) by CY8PR10CA0006.outlook.office365.com\n (2603:10b6:930:4f::29) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.20 via Frontend Transport; Thu,\n 2 Apr 2026 17:32:27 +0000","from flwvzet201.ext.ti.com (198.47.21.195) by\n DM2PEPF00003FC5.mail.protection.outlook.com (10.167.23.23) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17 via Frontend Transport; Thu, 2 Apr 2026 17:32:25 +0000","from DFLE214.ent.ti.com (10.64.6.72) by flwvzet201.ext.ti.com\n (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 2 Apr\n 2026 12:32:25 -0500","from DFLE205.ent.ti.com (10.64.6.63) by DFLE214.ent.ti.com\n (10.64.6.72) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 2 Apr\n 2026 12:32:25 -0500","from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE205.ent.ti.com\n (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Thu, 2 Apr 2026 12:32:25 -0500","from localhost (rs-desk.dhcp.ti.com [128.247.81.39])\n by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 632HWPmL2424703;\n Thu, 2 Apr 2026 12:32:25 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=cBMzN9mqxa8ZPqJBgnaLUmNPrzAjpzhmM9sSag8ov7p8QkOPBK3hsm234WDBwpPseVw6XO38Hte6KhbQYvtltFQs0I9bcHLlNRN8slh4S4e5BNeNkJzukmSViavS06vHTgaFWjrqwMPisj75gy3nt0maSeeAGMZmIp9R3JqNUA/kTskZBqeRR8vzJ3hVb8O4GW338P5ui4fISFNJU+UNjGEiK7lPZ2V7xmweKaSkUWZ7rtbgUwgyov+DRP5LL+McjmxNwtGJqb6n8Y5rtJjcac1aMcrprul/HOD8xdN3sTrLYrwrQ6HecdVCWhXS7Mla5u07RA/t29mmvgvIYNn5ew==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=AldNSiHT1xIauL47sHGbA4vBegvlXSPdM9aUfuE2lxg=;\n b=D6d5jPvc/Yjr2UhA3PeTX0r4u6RLUEadm21yBup8/fBSBUkEq5uq3FL84+NFQ1HmEk1f8/e3yAlaJuC/wxv3rfUex0b+Ao4rV/4hDtgPj++j7P52Pd5WwH1yLXF11Guch29fw2fHUQmH0161BWawyL/88sLzKYyf393l4jAbNUNaaP4bHn3csp/sS6gvnbhNgp5cUSeUJ1BgtewALUh+0Tf2W9p9utGAK+uRTJIHxDfvD/fsvlsYR1yU5disBw5iHJ3d29vWa70nOWU8/GWUs07RIG6MOs9LORLPTXbCj5eQCv0Xsp5ToWEF0SXxcUiQIpQ7xfJwd2Oq76Mq/hSNdQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 198.47.21.195) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=ti.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AldNSiHT1xIauL47sHGbA4vBegvlXSPdM9aUfuE2lxg=;\n b=jkVDk4IvO8u98RrWJeO4PvW/xcGoEiHP++MDyYpkSLl8iu7Nh+I3oKDBwQDxvqsbs20jx0OBvPEATbMMuTNscBteSeMiefEKdZxWLQpp+rzucyqya9YZxKGFjwmsxcx/DaBGFa0lHTUm36yq4LOAHWWfXoxgi39Nla0EPsd2SaI=","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 198.47.21.195)\n smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;\n dmarc=pass\n action=none header.from=ti.com;","Received-SPF":"Pass (protection.outlook.com: domain of ti.com designates\n 198.47.21.195 as permitted sender) receiver=protection.outlook.com;\n client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"UTF-8\"","Date":"Thu, 2 Apr 2026 12:32:25 -0500","Message-ID":"","From":"Randolph Sapp ","To":"Ilias Apalodimas , ","CC":", ,\n , , ,\n , , ,\n ","Subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","X-Mailer":"aerc 0.21.0-0-g5549850facc2","References":"<20260402001410.3736815-1-rs@ti.com>\n <20260402001410.3736815-6-rs@ti.com>\n ","In-Reply-To":"\n ","X-C2ProcessedOrg":"333ef613-75bf-4e12-a4b1-8e3623f5dcea","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DM2PEPF00003FC5:EE_|SJ2PR10MB7656:EE_","X-MS-Office365-Filtering-Correlation-Id":"4fc79e4f-c6a0-45f7-6189-08de90ddce7d","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|36860700016|82310400026|1800799024|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n 5gz9xjRIjEcQhl8pA3NbacjDZ0928iF3OG7FIlZ2dtByEAD264DhCC4wz0kd0ucXUHOy7UApgv+0unaknHWdfI3KAxzI1J+0Lyo6gmGTNiZEvip2AcXZpTLqywPVUcLLGW8U8kOQvxu7CqY2PR77rBavuadrsWLf8HDc+xcRMhjfVEHjRiknBBeWg+VYH92Gl0CmgHjfVVVR2dWIoGfZ/g9vSCRShcWMXU1KRc4o5ZdCxxXvA4kQlGa+bhcbxzu9gWQqJWSwXWyM4DUMAk2vOHfFVRnnlfogW8NYcThCenRREvUJ7sFWiv3Lv9bIuALP4eTv8wNCMHpSk67QOV9mG+dIR3rVTZnBv4Qv2162g7tXdf3WKEpd0yUznxj0dNVj6x4xztQIPeJESU1ElpdjNNCzXbTp6BwG9PeB94kOGkfs4UGpF+tZYi9QPVlW2rH+0ckSvdCMOxP0dBIL0eZ+f/xyDwwJSfgKl7jmM8M2BDQxCZesN/aSLu7WM0qYH4WYNTdP3U0Nylgl+G3iRFKSH38hwSNj8MTkThnzv9hkS/lt8P/IFudMTzYK7FzNg3e45XWbRkeTHYFFqgSVbOvJLufJVP+4rZmetJUWdL4AzLBKFn07EkhkmkYu2tSJztlDfqhyZaYPyHAoLWV+fXn/Mdb3cosfes8As6434PXyxZslIl/PHxRUwnjYpX/vT8NHL5C9fe/6cR+Hi1VQz1P0tKqCJFxSVc+FQs4KKwURdcnN0khaXAj7JxIjWLSHgzDK3TwVpEP9As+ziVmiOKa++g==","X-Forefront-Antispam-Report":"CIP:198.47.21.195; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:flwvzet201.ext.ti.com; PTR:ErrorRetry; CAT:NONE;\n SFS:(13230040)(376014)(36860700016)(82310400026)(1800799024)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n PjU+5RmEoEUQrBttmN58Vbrc4+oszj+zExzvcXU3NJOur+eOO43rlLmverF+Zk4mhrDLwLAZGOHmfMa9oZtyhSO/TmsaseTeAdlw+XujFtH8cTS1Ee1Fjg67uYwghj1Py5nrghMJxpXh/r9JuIEeaVuDUAu/4GAMnJkLXMmNorkALy86ROYaiHVCX3SZuaZ9IMM0cGEmhn24b75MuYxccxx/knYg8tQrsClqp0ukzO/8N0UVYdUorP9DOH+hJXKvTEQqJNQx2LzHL7zj8z3rTouCmjeMa1U8ao5mEQUFx+4TvChmZSMkm9kkHfUbLYj9y5U995fgTbdn90YGGnHsn7IdKB0BJnCVdy4+f8dGPPTiYF1Q/JT57HBSXubbjuNZG6R/86iv0KNAsmsmOUmFNiDFbXN77SVS7PtxIPekP9nAHGSMt8dkCzKG0BlkTOUK","X-OriginatorOrg":"ti.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"02 Apr 2026 17:32:25.8716 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 4fc79e4f-c6a0-45f7-6189-08de90ddce7d","X-MS-Exchange-CrossTenant-Id":"e5b49634-450b-4709-8abb-1e2b19b982b7","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7; Ip=[198.47.21.195];\n Helo=[flwvzet201.ext.ti.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n DM2PEPF00003FC5.namprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SJ2PR10MB7656","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3672887,"web_url":"http://patchwork.ozlabs.org/comment/3672887/","msgid":"","list_archive_url":null,"date":"2026-04-02T19:58:26","subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","submitter":{"id":88727,"url":"http://patchwork.ozlabs.org/api/people/88727/","name":"Randolph Sapp","email":"rs@ti.com"},"content":"On Thu Apr 2, 2026 at 12:32 PM CDT, Randolph Sapp wrote:\n> On Thu Apr 2, 2026 at 3:53 AM CDT, Ilias Apalodimas wrote:\n>> Hi Randolph\n>>\n>> On Thu, 2 Apr 2026 at 03:14, wrote:\n>>>\n>>> From: Randolph Sapp \n>>>\n>>> Backfill any fragmented EFI_CONVENTIONAL_MEMORY when LMB allocations\n>>> start to fail. This may be a low memory environment, or maybe LMB is\n>>> running up against a tricky reserved region.\n>>>\n>>> Signed-off-by: Randolph Sapp \n>>> ---\n>>> lib/efi_loader/efi_memory.c | 35 +++++++++++++++++++++++++++++++++--\n>>> 1 file changed, 33 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c\n>>> index 882366a9f8a..f07cc39b157 100644\n>>> --- a/lib/efi_loader/efi_memory.c\n>>> +++ b/lib/efi_loader/efi_memory.c\n>>> @@ -441,6 +441,27 @@ static efi_status_t efi_check_allocated(u64 addr, bool must_be_allocated)\n>>> return EFI_NOT_FOUND;\n>>> }\n>>>\n>>> +/**\n>>> + * efi_get_conventional_start - find the highest conventional region start\n>>> + * address with at least the specified number of\n>>> + * pages\n>>> + *\n>>> + * @pages: number of pages required to be in that carveout\n>>> + * Return: starting address of the give carveout\n>>> + */\n>>> +static u64 efi_get_conventional_start(u64 pages)\n>>> +{\n>>> + struct efi_mem_list *item;\n>>> +\n>>> + list_for_each_entry(item, &efi_mem, link) {\n>>> + if (item->desc.type != EFI_CONVENTIONAL_MEMORY)\n>>> + continue;\n>>> + if (item->desc.num_pages >= pages)\n>>> + return item->desc.physical_start;\n>>> + }\n>>> + return 0;\n>>\n>> We've been bitten by this in the past and although unlikely 0 is a\n>> valid address for some hardware. Can we return something different if\n>> we don't find a match? UINT64_MAX perhaps?\n>>\n>>> +}\n>>> +\n>>> /**\n>>> * efi_allocate_pages - allocate memory pages\n>>> *\n>>> @@ -507,10 +528,20 @@ efi_status_t efi_allocate_pages(enum efi_allocate_type type,\n>>> /* Reserve that map in our memory maps */\n>>> ret = efi_update_memory_map(efi_addr, pages, memory_type, true, false);\n>>\n>> In theory the lmb and the EFI maps are in sync. I haven't checked\n>> close enough yet, but do you have cases where lmb_alloc worked and\n>> updating the efi memory map failed?\n>\n> Fair point. Now that I've fixed the FDT warning I should probably check if I can\n> actually reproduce the issue that actually required this.\n\nYeah, this patch isn't necessary anymore. I suppose it should be dropped as it\nwould potentially mask any discrepancies between the two maps.\n\nOut of curiosity, is there any plan to merge the EFI and LMB allocators more in\nthe future, or is the current layering scheme the furthest we want to go?\n\n>>> if (ret != EFI_SUCCESS) {\n>>> - /* Map would overlap, bail out */\n>>> + /* Map would overlap, try something else */\n>>> lmb_free(addr, (u64)pages << EFI_PAGE_SHIFT, flags);\n>>> unmap_sysmem((void *)(uintptr_t)efi_addr);\n>>> - return EFI_OUT_OF_RESOURCES;\n>>> +\n>>> + /* See if there is any EFI_CONVENTIONAL_MEMORY allocations */\n>>> + if (type != EFI_ALLOCATE_ADDRESS) {\n>>\n>> Can you please inverse this. It's going to reduce the identation.\n>> if (type == EFI_ALLOCATE_ADDRESS)\n>>> + *memory = efi_get_conventional_start(pages);\n>>> + if (*memory != 0)\n>>\n>> Same here\n>>\n>>> + return efi_allocate_pages(EFI_ALLOCATE_ADDRESS,\n>>> + memory_type, pages,\n>>> + memory);\n>>> + }\n>>> +\n>>> + return EFI_OUT_OF_RESOURCES;\n>>> }\n>>>\n>>> *memory = efi_addr;\n>>> --\n>>> 2.53.0\n>>>\n>>\n>> Thanks\n>> /Ilias","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=selector1 header.b=YEE2xkxo;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"YEE2xkxo\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de; spf=pass smtp.mailfrom=rs@ti.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmt2q6XkSz1yCt\n\tfor ; Fri, 03 Apr 2026 06:58:43 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 2CC0983D8A;\n\tThu, 2 Apr 2026 21:58:39 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id B57AF83D8A; Thu, 2 Apr 2026 21:58:38 +0200 (CEST)","from CY3PR05CU001.outbound.protection.outlook.com\n (mail-westcentralusazlp170130007.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c112::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 439D780212\n for ; Thu, 2 Apr 2026 21:58:36 +0200 (CEST)","from PH8PR07CA0041.namprd07.prod.outlook.com (2603:10b6:510:2cf::29)\n by CH5PR10MB997695.namprd10.prod.outlook.com (2603:10b6:610:2ee::6)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Thu, 2 Apr\n 2026 19:58:32 +0000","from CY4PEPF0000E9CE.namprd03.prod.outlook.com\n (2603:10b6:510:2cf:cafe::22) by PH8PR07CA0041.outlook.office365.com\n (2603:10b6:510:2cf::29) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.18 via Frontend Transport; Thu,\n 2 Apr 2026 19:58:31 +0000","from flwvzet200.ext.ti.com (198.47.21.194) by\n CY4PEPF0000E9CE.mail.protection.outlook.com (10.167.241.133) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17 via Frontend Transport; Thu, 2 Apr 2026 19:58:29 +0000","from DFLE210.ent.ti.com (10.64.6.68) by flwvzet200.ext.ti.com\n (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 2 Apr\n 2026 14:58:26 -0500","from DFLE207.ent.ti.com (10.64.6.65) by DFLE210.ent.ti.com\n (10.64.6.68) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 2 Apr\n 2026 14:58:26 -0500","from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE207.ent.ti.com\n (10.64.6.65) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Thu, 2 Apr 2026 14:58:26 -0500","from localhost (rs-desk.dhcp.ti.com [128.247.81.39])\n by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 632JwQFr3089208;\n Thu, 2 Apr 2026 14:58:26 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=DhhHPUvJEl6WiVvxDcgv2WNOmHS7Qdi+noe2udOCfrPOnZ5vfyQHsW9WjWmzweRjOX2G9ejrjh/+E/+H6MT1RUcBVsXTf8tBrA5uHV5qwjb7f2+FH+jGWp+FPPtC+aGydcQGNxvwJ1q9hk/uOs1jDSYE+Nz0wZTM60g6PDCrASDU22HmWTq8yfj+5t3BYSsMX+Ydy6C1f1WMqk3BErTT5zOy8JtOxOV93jgIMuWuidbOyScWBl3WjkK4JjFIS7aJ+lGjHWaPyOMW3iNMtc7ApSX1dbjn8YuSlTHmdDZfp4jksiZMRcPaDck04rk695FSRBXV/srhO4J3GSHKe7iRAA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=u1+oReORULVU5IOCI0ijvE8qWWM29QFz6M34n94B0ps=;\n b=ag76FmvyLTtXLcfa/lAiRryvG3Zy7Y02paW4QUEWQM9tQML/lcRVNd3BimHSrs0meTZlA8lrD1jRYYTiSBOXzez5DpKsFcKvcDn7OjGTOTwZ6meUA7ha4w94Cj9jR8R0jfIEELbehzDKzA5Qh1KrS49eEgM3YRSpwr3xgRE5J2TuH+YjshSwYGLBFsLpX7kKwla2s8KqYWiooGIFqBcWHI/0FUilL8gplhc/Gz5Ax1a6PbCXypZeupE8tMob2SA1JFuU5NRI+dhqG2f9CPUd6biTZnUyfaJqMGOK9TzqeuuABaPM0UcHyPZqNsEmPLWKqbUgKrRBX3chTHQtd80UeA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 198.47.21.194) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=ti.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=u1+oReORULVU5IOCI0ijvE8qWWM29QFz6M34n94B0ps=;\n b=YEE2xkxosbACVVIqUTrpMaw7ISlvg+WDKqrOkcSIU4UqjariMHStnmAjK3FCNVa0ZXJEUqTprVbMB94D/70nIQn7HikvOXB5Fstk0nDItbsq4bhMo1TwaF9rXneUgbsWea5PAhMw98n1+2dea3XCB0YEH4rME96mpSoPVIffmZ8=","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 198.47.21.194)\n smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;\n dmarc=pass\n action=none header.from=ti.com;","Received-SPF":"Pass (protection.outlook.com: domain of ti.com designates\n 198.47.21.194 as permitted sender) receiver=protection.outlook.com;\n client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"UTF-8\"","Date":"Thu, 2 Apr 2026 14:58:26 -0500","Message-ID":"","CC":", ,\n , , ,\n , , ,\n ","Subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","From":"Randolph Sapp ","To":"Randolph Sapp , Ilias Apalodimas ","X-Mailer":"aerc 0.21.0-0-g5549850facc2","References":"<20260402001410.3736815-1-rs@ti.com>\n <20260402001410.3736815-6-rs@ti.com>\n \n ","In-Reply-To":"","X-C2ProcessedOrg":"333ef613-75bf-4e12-a4b1-8e3623f5dcea","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CY4PEPF0000E9CE:EE_|CH5PR10MB997695:EE_","X-MS-Office365-Filtering-Correlation-Id":"e6609dcd-daa7-4717-d4a5-08de90f235c8","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|36860700016|376014|82310400026|22082099003|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n Bx2vsVW7N5it6Kz9sqHusQLb/Xdxl9KhmLqzkHplNdm4aQoGdoqv+g3QicasQQHl1lfrbODrFKNxnmntUnmSA0Vc86u3NzkROBbw22vgXE/zAfjBi+5pC/KIgIiEGGly0T4jKZIMFyH9MpFUswTwqLihjL76BYzeSd8hFwA0e+jjBEYbhrt+Of0gvPqdXYfO89PMOvLagrJPwT8YAsblAEmufW7LsLXRS5QmDXYYOUGn+++aL2PR6wmtGoTKRTgISb9Gglukutebd4KDSSW1JgM52HPgxDW2srXhptg6m27IF5ro8pmMMZOwNFwVQr0I6Tz8bFixWHdtPeb+5YV3zdNXWmRPIi46w6KL2bOwCZAli0yV1Njjf5+YktmqSbWR7GqJrXk1nJspJqG7ol4wyJParChE4ppqsa8r9NnIwJF90wRZAOk8nfjz9biu3sttV2bOQgbsThg1+ftWgLnpUmnIl3GZWHXUpqoRQUjSbf0J+nmIHKFtYSULdKq0Snp3PT4ltWzYdmUr5GOVUL0gCM//C+yGaALAZHHwYlbTiNBY9nxwsWnXiWPKvpeIzzmnv5NiuQDAKwnsjqLWFjB/z+gZ2RjPYOOlJE0NgFmhqd5WOFgkF3DBVkpEsXyRT+wbwRNyzOvYrDuqh27lIaBOSSZEoQH0KqfK509eaKcSzA9L7y/NHG9OpH5dasGZ6VI1muvlenvBq7psxg7UwnTFXpdHtGZn6fwdtiyE+xzpElkXCJ/Z3+59RafvFUEgGInLdvVIrSxtA+aqlgGKmlXdqQ==","X-Forefront-Antispam-Report":"CIP:198.47.21.194; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:flwvzet200.ext.ti.com; PTR:ErrorRetry; CAT:NONE;\n SFS:(13230040)(1800799024)(36860700016)(376014)(82310400026)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n gsxKnxXxYGJ0XVCZO9PW4DAahiQSyKS6/QA7rvvXq4IQsvQrCdCKwazzUyY/WWm6BQUku4jx/810D+NylWxQ7bhtze9IN1G8W/XkJbzLGyuFGY9KlJ13Mz2APM+PPHC3omEfPJswqClL6amHU1OMjWggFJ56tb4yv1wBAbBsAKo0xWIFyBEONhYAisnAfRN1au9uANYKT1JHQEciNExoKP3tliT3fAx3l1A4BLsbE2p1T7IXvdK2m5DedSiJe4R3uTufWV8yfnKlNvpelmboD4FHP9/HYRGP4rFxfWv1oiduTfJXEoX0yBDg9QlxC9CWqlCmJic7eNT51c9JEdawv/CQVkzIT21LPgkrwR5mOaH3dAQ+gsaRcFlrvkKvAWXrSmPgX+NKVd3wn0wTziuiOmNMVZYksgFm2ivpm1eFlrom1TVxGoWtQBtuXIM/wo4y","X-OriginatorOrg":"ti.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"02 Apr 2026 19:58:29.1203 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n e6609dcd-daa7-4717-d4a5-08de90f235c8","X-MS-Exchange-CrossTenant-Id":"e5b49634-450b-4709-8abb-1e2b19b982b7","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7; Ip=[198.47.21.194];\n Helo=[flwvzet200.ext.ti.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n CY4PEPF0000E9CE.namprd03.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH5PR10MB997695","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3672989,"web_url":"http://patchwork.ozlabs.org/comment/3672989/","msgid":"","list_archive_url":null,"date":"2026-04-03T05:28:38","subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","submitter":{"id":74147,"url":"http://patchwork.ozlabs.org/api/people/74147/","name":"Ilias Apalodimas","email":"ilias.apalodimas@linaro.org"},"content":"[...]\n\n> >>\n> >>> +}\n> >>> +\n> >>> /**\n> >>> * efi_allocate_pages - allocate memory pages\n> >>> *\n> >>> @@ -507,10 +528,20 @@ efi_status_t efi_allocate_pages(enum efi_allocate_type type,\n> >>> /* Reserve that map in our memory maps */\n> >>> ret = efi_update_memory_map(efi_addr, pages, memory_type, true, false);\n> >>\n> >> In theory the lmb and the EFI maps are in sync. I haven't checked\n> >> close enough yet, but do you have cases where lmb_alloc worked and\n> >> updating the efi memory map failed?\n> >\n> > Fair point. Now that I've fixed the FDT warning I should probably check if I can\n> > actually reproduce the issue that actually required this.\n>\n> Yeah, this patch isn't necessary anymore. I suppose it should be dropped as it\n> would potentially mask any discrepancies between the two maps.\n\nYea and if we really need a similar fix in the future, it's best if we\nput in the lmb core code.\n\n>\n> Out of curiosity, is there any plan to merge the EFI and LMB allocators more in\n> the future, or is the current layering scheme the furthest we want to go?\n\nWe do, but havent due to lack of time. It's been a while since I\ndiscussed this with Heinrich but iirc the only thing missing is for\nlmb to be aware of the memory flags EFI expects.\n\n/Ilias\n>\n> >>> if (ret != EFI_SUCCESS) {\n> >>> - /* Map would overlap, bail out */\n> >>> + /* Map would overlap, try something else */\n> >>> lmb_free(addr, (u64)pages << EFI_PAGE_SHIFT, flags);\n> >>> unmap_sysmem((void *)(uintptr_t)efi_addr);\n> >>> - return EFI_OUT_OF_RESOURCES;\n> >>> +\n> >>> + /* See if there is any EFI_CONVENTIONAL_MEMORY allocations */\n> >>> + if (type != EFI_ALLOCATE_ADDRESS) {\n> >>\n> >> Can you please inverse this. It's going to reduce the identation.\n> >> if (type == EFI_ALLOCATE_ADDRESS)\n> >>> + *memory = efi_get_conventional_start(pages);\n> >>> + if (*memory != 0)\n> >>\n> >> Same here\n> >>\n> >>> + return efi_allocate_pages(EFI_ALLOCATE_ADDRESS,\n> >>> + memory_type, pages,\n> >>> + memory);\n> >>> + }\n> >>> +\n> >>> + return EFI_OUT_OF_RESOURCES;\n> >>> }\n> >>>\n> >>> *memory = efi_addr;\n> >>> --\n> >>> 2.53.0\n> >>>\n> >>\n> >> Thanks\n> >> /Ilias\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=zUPySWUw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"zUPySWUw\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fn6jH5Srgz1yCs\n\tfor ; Fri, 03 Apr 2026 16:29:23 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E500384020;\n\tFri, 3 Apr 2026 07:29:19 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 5A5428407E; Fri, 3 Apr 2026 07:29:19 +0200 (CEST)","from mail-yx1-xb135.google.com (mail-yx1-xb135.google.com\n [IPv6:2607:f8b0:4864:20::b135])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0C6D183DC9\n for ; Fri, 3 Apr 2026 07:29:16 +0200 (CEST)","by mail-yx1-xb135.google.com with SMTP id\n 956f58d0204a3-64e87a81639so1487914d50.0\n for ; Thu, 02 Apr 2026 22:29:15 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775194155; cv=none;\n d=google.com; s=arc-20240605;\n b=Lqhzsgu8uxtV7yCVAh8j57Erdme6/9vd/8yk3ZVw/TP/5rwD87f9nEgyYq+0bmtLhw\n zx8Vo204sEdwGGGMaSwAnAZTsnZzytd2n0F8CNGgU37y909qEHbE+FmRJRSHRP1qE39N\n mo056/0wJzv2TtwEKV5CbXuqTuOmyDKQ00RH+3cYTqwy6yfsAmOlyRw7frNndZ9ESjww\n jMPVNRwhTJ6CGVP65eaIfGIj6vPKlzaHtqoFWbr7Deg9oBO7g+2KE7vmdky+1kvO6eLT\n 1TlVWeJLDLa6S+sujvOY0njN1iR/dbtQV7SCxphxdtuj8eIjyLvL+FBcrtffFH4GSDR6\n t4FA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=WqGykn2gzJV7VsjK2igi0j6beAQhZTlyWpRkV+6c8n0=;\n fh=xQzR5o2A8M9wqiA8Fg5jB1ICrTFdmVPV658WtdmuFdI=;\n b=ZztXgI2k8ZUO2GlnUln8X3kWzzvdiNPV+c1eDdz1jNpVe4mlBbukoQfi/TrXvSYQiE\n ADCVkDFLk0EqR5PjvJvwW9urOX52BtHqikvkrKHRyepb97L0gsXVHNcnwTDA+puBp+yg\n cgmrkWqa3iezZj3ijCT5nMIUSUYM6pmieOTIIx97ALscMqt0q8Fvo4vIjl1KCiswG1Cm\n PRxpv7695I1mfQrEbNFCsLpzlKbeCdf+iPnC976lHTWGzU4Jv5lG57zVzWxuWq/KQFja\n MBU6hHA25TxZ87m21/71yHtKoHXsl2s027ih4U6W01BjNOAiT18ANToHWypsYlKKhkGF\n tRiw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775194155; x=1775798955; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=WqGykn2gzJV7VsjK2igi0j6beAQhZTlyWpRkV+6c8n0=;\n b=zUPySWUwhi/GqT61kSmbePeT71jwsP9B4etBxrWVb+qvVXM0FzhU/eXdZxe9odxEI4\n xN7Dual4mP8ONx3WhV3xkGbSrUCJZoVowqWaAcXnJZOiytGrdqAWp9PLwEPw0PrM3amD\n j6pr4XDEE7UowfU8KEbooUDKRhebRpmZuSLD9TNKrZ0Zun5XePcEFh4CVqB5XwAwuOOn\n 2Ne2R4pqVeucwfUBD9MvLLY+mfYlH3MnPSmL1CVb8ZLkXtau62+SwAUSumlQcZrYkCg4\n dmBT8JfhlBRka6CWtLR+jCf1GJeSltTIGmVXOCJhTSn3/zymlzvXEh4MkwYON9bjVLVv\n V/YQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775194155; x=1775798955;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WqGykn2gzJV7VsjK2igi0j6beAQhZTlyWpRkV+6c8n0=;\n b=OYzjqkoEyYfKLQjEKGXJD3FRofA1c0Z5Fc49PshZzIp3/HeTEqBe+ObV4rF43X6ET3\n LyPkFfB5vwA3ucLfENKhm6/4MGRGH3JUOgFGn5xoow8Ki2BTWXVSiNeZBfMRfZsUkfLM\n oEDFGuJ0lgRehYx6ZrcAR1GHURW7g/nRg7LWSLLQxTHCS1r+NHIM7S9M5bblX9t/w0MJ\n jmRT7aOhKNUEysZpLzwMv3dkih37lKtbDII3Q9FB+B31nYUSUK2mMVFV+48Sq6WWevNo\n 8YHQAXEEf55brvt7ANogS1XullpY65PadzPOk7lCeU0jXnNhCgn7ysZeqnvUsu9DR+Vt\n nMFg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWvsf396tNthTxvDF7lwtvs/am1T/ZV8Dn1hqAfb+qDZfYPyUpFQt18pss8IMQ3J8/e7zuFpjE=@lists.denx.de","X-Gm-Message-State":"AOJu0YzykGfuCn9MrbPRBrqHPLJ8z6pRlJ/XeoiGbL+2FhdPxRRU1RXd\n qbEw+KopDpKZO+YrEy+/fXTtw35M+LrCBlCGVmmz6DxClBeaclC3fnq4/SOdOVwpqxv7IpZPMaQ\n jU7UixP4aSEzbT03rL4jDNufPlpKranOfJglOpXoF2g==","X-Gm-Gg":"AeBDiesVv+v5vAGux8JcwM7HSRAiJ9KiSnxhC8kn+pcsAl9icEUqI2L9N30GZzoGAxT\n iqfjY6rt1nxpK1AutewXC2UOVlamKgCtktIC/sgIa208Mz7rYNmugp7gxYhfnDnke680rpikgka\n FxbbJo8mWsZpDmPd/VQUMB5WyZK0bcSwSfyCF1d0iW+RMIv9hF46vf9/yyq6ePt5+GBFcOiyQZf\n eEA1aI+IoD5URyqpyG2G1gPtBY5ADebu6Vn1cMYRR7QzI8xD7F1Bkrb60WBBMD/ZnjjZ+FahHS7\n fUjmh9IjHSLE8RQ6abj/2+KpMmV51f50wEUgmZ0BR1CzmvUU7pjUEClQibeB4tZgsnsmdWwvrlv\n +PtkOe9brK3XlXBPIkrSniZJCeZl/6ToHojJ0ZYlpVrjCM38Z8sD0T3MwsvmJUXYzXnCN6PfPHA\n RKGsLHGCqF17nrmivTQ0FTwT5MPcPl35sd+ehKY5D9koxRIrmXb34lzDobq7TXNUpl6EBRsNWZT\n B6gPByHBBEZRHb3NZ2+gy4vgA/tGvAWAzM1hSRyeKxS1g+88c04co3MHvtivgqtykrEdIe0TphA\n wfM7c3+LhIEZ1D9pHCKMvNLbl2wwNqq/HVhxLTSLaAD3","X-Received":"by 2002:a53:b702:0:b0:650:1d21:d6af with SMTP id\n 956f58d0204a3-6504880fe6dmr1139942d50.40.1775194154811; Thu, 02 Apr 2026\n 22:29:14 -0700 (PDT)","MIME-Version":"1.0","References":"<20260402001410.3736815-1-rs@ti.com>\n <20260402001410.3736815-6-rs@ti.com>\n \n ","In-Reply-To":"","From":"Ilias Apalodimas ","Date":"Fri, 3 Apr 2026 08:28:38 +0300","X-Gm-Features":"AQROBzBNedgA44ltInNrKP2PriFc14R5Q_MMmIOWYTogGGteQr1jNbi_b6KeoSk","Message-ID":"\n ","Subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","To":"Randolph Sapp ","Cc":"robertcnelson@gmail.com, ayush@beagleboard.org,\n Erik.Welsh@octavosystems.com, anshuld@ti.com, bb@ti.com, trini@konsulko.com,\n afd@ti.com, xypron.glpk@gmx.de, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3673353,"web_url":"http://patchwork.ozlabs.org/comment/3673353/","msgid":"","list_archive_url":null,"date":"2026-04-04T00:08:06","subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","submitter":{"id":88727,"url":"http://patchwork.ozlabs.org/api/people/88727/","name":"Randolph Sapp","email":"rs@ti.com"},"content":"On Fri Apr 3, 2026 at 12:28 AM CDT, Ilias Apalodimas wrote:\n> [...]\n>\n>> >>\n>> >>> +}\n>> >>> +\n>> >>> /**\n>> >>> * efi_allocate_pages - allocate memory pages\n>> >>> *\n>> >>> @@ -507,10 +528,20 @@ efi_status_t efi_allocate_pages(enum efi_allocate_type type,\n>> >>> /* Reserve that map in our memory maps */\n>> >>> ret = efi_update_memory_map(efi_addr, pages, memory_type, true, false);\n>> >>\n>> >> In theory the lmb and the EFI maps are in sync. I haven't checked\n>> >> close enough yet, but do you have cases where lmb_alloc worked and\n>> >> updating the efi memory map failed?\n>> >\n>> > Fair point. Now that I've fixed the FDT warning I should probably check if I can\n>> > actually reproduce the issue that actually required this.\n>>\n>> Yeah, this patch isn't necessary anymore. I suppose it should be dropped as it\n>> would potentially mask any discrepancies between the two maps.\n>\n> Yea and if we really need a similar fix in the future, it's best if we\n> put in the lmb core code.\n>\n>>\n>> Out of curiosity, is there any plan to merge the EFI and LMB allocators more in\n>> the future, or is the current layering scheme the furthest we want to go?\n>\n> We do, but havent due to lack of time. It's been a while since I\n> discussed this with Heinrich but iirc the only thing missing is for\n> lmb to be aware of the memory flags EFI expects.\n>\n> /Ilias\n\nI mean, trimming the last x bits off of the LMB allocation flag value to store\nthe current EFI enum is a little bit of a hack, but honestly it'll allow the\ncurrent allocation coalescence logic to continue to work as-is. It would just\nneed helpers to store and retrieve the enum type for the code that actually\ncares about the EFI memory types. I could look into doing that if you guys think\nthat's a valid approach, or if you've got other ideas.\n\n>>\n>> >>> if (ret != EFI_SUCCESS) {\n>> >>> - /* Map would overlap, bail out */\n>> >>> + /* Map would overlap, try something else */\n>> >>> lmb_free(addr, (u64)pages << EFI_PAGE_SHIFT, flags);\n>> >>> unmap_sysmem((void *)(uintptr_t)efi_addr);\n>> >>> - return EFI_OUT_OF_RESOURCES;\n>> >>> +\n>> >>> + /* See if there is any EFI_CONVENTIONAL_MEMORY allocations */\n>> >>> + if (type != EFI_ALLOCATE_ADDRESS) {\n>> >>\n>> >> Can you please inverse this. It's going to reduce the identation.\n>> >> if (type == EFI_ALLOCATE_ADDRESS)\n>> >>> + *memory = efi_get_conventional_start(pages);\n>> >>> + if (*memory != 0)\n>> >>\n>> >> Same here\n>> >>\n>> >>> + return efi_allocate_pages(EFI_ALLOCATE_ADDRESS,\n>> >>> + memory_type, pages,\n>> >>> + memory);\n>> >>> + }\n>> >>> +\n>> >>> + return EFI_OUT_OF_RESOURCES;\n>> >>> }\n>> >>>\n>> >>> *memory = efi_addr;\n>> >>> --\n>> >>> 2.53.0\n>> >>>\n>> >>\n>> >> Thanks\n>> >> /Ilias\n>>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=selector1 header.b=rLtbYo+H;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"rLtbYo+H\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de; spf=pass smtp.mailfrom=rs@ti.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnbXV6kskz1yD3\n\tfor ; Sat, 04 Apr 2026 11:08:26 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 02C9C839A8;\n\tSat, 4 Apr 2026 02:08:18 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 919E983B8F; Sat, 4 Apr 2026 02:08:16 +0200 (CEST)","from MW6PR02CU001.outbound.protection.outlook.com\n (mail-westus2azlp170120002.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c007::2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6D34280077\n for ; Sat, 4 Apr 2026 02:08:13 +0200 (CEST)","from CH2PR14CA0035.namprd14.prod.outlook.com (2603:10b6:610:56::15)\n by MN6PR10MB7520.namprd10.prod.outlook.com (2603:10b6:208:478::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Sat, 4 Apr\n 2026 00:08:09 +0000","from CH3PEPF0000000D.namprd04.prod.outlook.com\n (2603:10b6:610:56:cafe::55) by CH2PR14CA0035.outlook.office365.com\n (2603:10b6:610:56::15) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.29 via Frontend Transport; Sat,\n 4 Apr 2026 00:08:09 +0000","from flwvzet201.ext.ti.com (198.47.21.195) by\n CH3PEPF0000000D.mail.protection.outlook.com (10.167.244.43) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9745.21 via Frontend Transport; Sat, 4 Apr 2026 00:08:07 +0000","from DFLE211.ent.ti.com (10.64.6.69) by flwvzet201.ext.ti.com\n (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Fri, 3 Apr\n 2026 19:08:06 -0500","from DFLE208.ent.ti.com (10.64.6.66) by DFLE211.ent.ti.com\n (10.64.6.69) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Fri, 3 Apr\n 2026 19:08:06 -0500","from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE208.ent.ti.com\n (10.64.6.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Fri, 3 Apr 2026 19:08:06 -0500","from localhost ([10.249.32.65])\n by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 634086R9707898;\n Fri, 3 Apr 2026 19:08:06 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,T_SPF_PERMERROR autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=UL/WbUkTU/Oy1aIdSBQnQOGySkNL85GwW5gMtaqpBPCKt0iV2+L4bxnFMOfDqmhkp3ZIzAg9ScqT/O834S5wnVUG6Zepv+xH7TEQ+AAgwjN0vJWOkThgkxPicz08AcvWKSKz2JZtb/DDyon1n2S0Vn8d7hBw6WQR8XMH4DwPTTBjJ/44InvgcOgNaaMuIkPle7JmPDHqmCi21C/NrBbWwjaETXyARmh40M0S1YJ2b7OXR8xJ9gko25ZIStGeuoNXgQrEFRHCUMzt66KowA7JuWXwgMZ2yn0OumO69O70BZMKfgoRM7A7WWzs+mCHxGeBbmQGNfzKNivot1sFlxsDFQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=z6SGK2Zo1VDN3sVSZeP/X/iX2HvFv8rhqCRwbrX5AfQ=;\n b=R65kTpvq72lkkXAjBboIz8vbUuozDp/mhuWq+7h7WL0QK0fbB2b0bxCJTwrGMzFfp/FCampZ2ftYJ+W+JU6ei7B+aLqg2HB1ctcO9VZ0/KHsgyr1i8zQrhdlrj3xAI8J9Gxz/WqnXnxWW5G0uyP2SND9XjgxPLQcKcTTbvCa9mHI+GBA589sDxtNqYVF6zHGu2xEH2X05fjSLKsJ2fUW9yGaPH7263p15kbW+XugRbYLF76fwI9TbvudN3ZLGjx7tKjCysRJDGEEY9PFfVei5os4FKxISvy4KOJCLDRBqUmBNk8hQPg+TgvZS5inftiEp2iaiMI2OskyIXVthti5DQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 198.47.21.195) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=ti.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=z6SGK2Zo1VDN3sVSZeP/X/iX2HvFv8rhqCRwbrX5AfQ=;\n b=rLtbYo+HcW/XQiB/hjVPihCNmmnBR2IOF3OqnKE95FGXdSklnZW9orPCi5JQyDnUdzNKm7D78Z/CylaX6U5wBqcajk1A+rNLH0xsYsjNdtqC2KWq0OhL1OqdacqdY77xM66pl1p4CetI/xUyilwLK1bN5j3qMVZAlS7hC9nqPC0=","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 198.47.21.195)\n smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;\n dmarc=pass\n action=none header.from=ti.com;","Received-SPF":"Pass (protection.outlook.com: domain of ti.com designates\n 198.47.21.195 as permitted sender) receiver=protection.outlook.com;\n client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=\"UTF-8\"","Date":"Fri, 3 Apr 2026 19:08:06 -0500","Message-ID":"","To":"Ilias Apalodimas , Randolph Sapp ","CC":", ,\n , , ,\n , , ,\n ","Subject":"Re: [PATCH 5/6] efi_memory: backfill EFI_CONVENTIONAL_MEMORY","From":"Randolph Sapp ","X-Mailer":"aerc 0.21.0-0-g5549850facc2","References":"<20260402001410.3736815-1-rs@ti.com>\n <20260402001410.3736815-6-rs@ti.com>\n \n \n ","In-Reply-To":"\n ","X-C2ProcessedOrg":"333ef613-75bf-4e12-a4b1-8e3623f5dcea","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CH3PEPF0000000D:EE_|MN6PR10MB7520:EE_","X-MS-Office365-Filtering-Correlation-Id":"bc172765-10bd-4079-3342-08de91de4018","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700016|82310400026|1800799024|376014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n vKpZwTw2qQwcgrJEr8ArITQgXblHJpzEroIg4WPI2NKUH1SkYzbOGAShqSl+5DqENxkkBLWqBLiYgn4VieXUz6spv4EQniM/+BPGLrQtvm8DVwHkaxmpYiDFg4bar1tspgZ8v5EddCcd1AsUIc402+WihP+JRIK9m/Mnr1WraqL41nQ1EcTBokgad8iA+IMgPwIINIex2SWkLI+fwtmJ5/v0ohzotwWn+Ax7dRtmRfw6csdVEeBa0V2XMknMpvE/+CW/bcZYBZlIs5u2Q/cUQ5WDyOm1WAqAh9rznhlzYuOHeTPVpgMCpQV66WBq6dfspx3kTCktIkyY3LQfQ8MvN9w324blirMRP92f0cH9hTyFIFib5GLPvRw4qvYViTT7mqYEdsDJfg0m5dyadRa54jdpY4XVMMxue0taStR8wSXwmz3EH92MESdCLIJbkGI6XfM48vSHu++Ns4kE1OEZOcEGfNaNPoUa2v8u9ZeYl6e8yPGH6YbB0DPoaMKmrM+34+BYqhjp9L639lq/sIxDsIElLds9aElik5kaybeI+auH2dJCVtpScsKcSRJh+oKl3p2XY1HwW5IRJixQg2Q20LQZtnh7VotWNS1AN65SKnEBz/bzsURwOb3m7zyYrKShmk43ba/PP0WxT6iEMwmHgZ0MODU7/TgeNvsiiU4FjWr0ihzD6WLv+1nzOJsa+CZ8ZLDNpp2ZUiV5xr3AeRQZr3n7h5kSn9UpksI5A1dlOmIErBNd+5ix28tatrUPfVsbapF7U38DiEFUwy8g5xICDg==","X-Forefront-Antispam-Report":"CIP:198.47.21.195; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:flwvzet201.ext.ti.com; PTR:ErrorRetry; CAT:NONE;\n SFS:(13230040)(36860700016)(82310400026)(1800799024)(376014)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n +8XuXeHm5E8mmnl/+RUwW/OWETcO68JrQjrBfHowRrf4cVSOmX1qg5NMaxNiuD1csNMW2cY03vcGn2canUXW1E89IzNyGA1p9hU3m+1wInAIGj6DQ/6Fg3K1GA8YWE4b2d/xvJmDc9plXHGAaEt+Wblf29IfVyd1KMmCkXQhfTZhlA3yWJ0e8DT1/GQRphB00sqiAqxUVzJ+kJG/jeWDST51yBH5SmBr5dFtbFmt84KZ4IrrYPcq+HIWQElyeFUjYLcw/lteoDAa1VPUgQkjEb3ryY+2ixnICAL6+xfbpB2SUYv06rkG3FH3fc3ZVTql2b1hOIQHagPE6Glu588c4v6+yqJHZ+EYh3kEMtCZ0sdWBWmfCzZcaHjIUZxaknPZl8pQGx2pShCIWflbY4JBVzg7AtekxBTT/P4Fcd/FLkD7TaS5lsdoGMANHE/i6ji4","X-OriginatorOrg":"ti.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"04 Apr 2026 00:08:07.6235 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n bc172765-10bd-4079-3342-08de91de4018","X-MS-Exchange-CrossTenant-Id":"e5b49634-450b-4709-8abb-1e2b19b982b7","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7; Ip=[198.47.21.195];\n Helo=[flwvzet201.ext.ti.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n CH3PEPF0000000D.namprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MN6PR10MB7520","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]