[{"id":3672612,"web_url":"http://patchwork.ozlabs.org/comment/3672612/","msgid":"","list_archive_url":null,"date":"2026-04-02T08:38:13","subject":"Re: [PATCH 2/6] efi_dt_fixup: use fdtdec_get_bool","submitter":{"id":74147,"url":"http://patchwork.ozlabs.org/api/people/74147/","name":"Ilias Apalodimas","email":"ilias.apalodimas@linaro.org"},"content":"On Thu, 2 Apr 2026 at 03:14, wrote:\n>\n> From: Randolph Sapp \n>\n> Use the more straightforward fdtdec_get_bool instead of fdt_getprop and\n> a return code check.\n>\n> Signed-off-by: Randolph Sapp \n> ---\n\nReviewed-by: Ilias Apalodimas \n\n> lib/efi_loader/efi_dt_fixup.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/lib/efi_loader/efi_dt_fixup.c b/lib/efi_loader/efi_dt_fixup.c\n> index 544e1aa9808..333711b9957 100644\n> --- a/lib/efi_loader/efi_dt_fixup.c\n> +++ b/lib/efi_loader/efi_dt_fixup.c\n> @@ -123,8 +123,7 @@ void efi_carve_out_dt_rsv(void *fdt)\n> fdtdec_get_is_enabled(fdt, subnode)) {\n> bool nomap;\n>\n> - nomap = !!fdt_getprop(fdt, subnode, \"no-map\",\n> - NULL);\n> + nomap = fdtdec_get_bool(fdt, subnode, \"no-map\");\n> efi_reserve_memory(fdt_addr, fdt_size, nomap);\n> }\n> subnode = fdt_next_subnode(fdt, subnode);\n> --\n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=hWBae0T6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"hWBae0T6\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org","phobos.denx.de;\n spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmZyW1Jgvz1yGH\n\tfor ; Thu, 02 Apr 2026 19:38:59 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id A5229839DF;\n\tThu, 2 Apr 2026 10:38:54 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id A257883CF5; Thu, 2 Apr 2026 10:38:53 +0200 (CEST)","from mail-yx1-xb12e.google.com (mail-yx1-xb12e.google.com\n [IPv6:2607:f8b0:4864:20::b12e])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4477780212\n for ; Thu, 2 Apr 2026 10:38:50 +0200 (CEST)","by mail-yx1-xb12e.google.com with SMTP id\n 956f58d0204a3-64eb84d1e37so470187d50.2\n for ; Thu, 02 Apr 2026 01:38:50 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775119129; cv=none;\n d=google.com; s=arc-20240605;\n b=Rljam8Q6tt7fAcG2WX7NlDYz5+eWuii7OTLkMEHNQVsQRvYp0+svGdcap5KIawVrt2\n VMjshdRYv9sFnAwgNpKzjNlPkjcvd4eGhjLPlUbmEAfV3YpLbKUVynIq0uq5MFka6dEV\n ugGCPr0z09XFQ6QTYrrM5xnIPUreMbv5uKhAOZuODgwJ6k0RZrASTMza+SUzHlif+FlL\n dSFeDmM+Y54PUudaybR3hJWpzN2C9APewJOlNBWJwWRadTiPo07eoSqU9a8qXb/Hfvaz\n Wfu0uEI3kG9ncPXdzU8iPdnx7lGNz8Go50W5enQlaL0jnfFQ99lwlvHwy5Ahqfxfa0jW\n XkyQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=QXjYE15G67HUWRDylibfRXTN5ohY2vP4wDogCfDGsoQ=;\n fh=NlrFX6yt5HNDJhusTK15Yp9ahUaE3Ul9gOFLdN8Vv1U=;\n b=CGm49o9NGUQ1igURF/E41LEAGqGtJVusZCeF3w4iVsPabbrcUez/j95v78T6XndHIG\n Sm0nmYJuo4cbdKcA3ZQP2BcKDu1yIjwglVLrMAf5n1dja+5Ig75DjJpI6WpfnJXIfeuf\n LweHj6SpOIKvHhrfOD2BBQwrt3GSwYfGw5ai3riW1DKqEg7Seq9ZDpGv5+OTmxKh3MTV\n Pjvh4fq+ZL3XTzGaMCJH/appxqnifYXYIX12wxIBUgtheVJGJS2TauBYyD7Bogrvcu/7\n fJXf+ZW6Sb2m/zSHwAXyiVekS0fA+6THV3wXym4WqK7CnJA6CfFqCM8C4+J4AvUEHISM\n E5vg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775119129; x=1775723929; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=QXjYE15G67HUWRDylibfRXTN5ohY2vP4wDogCfDGsoQ=;\n b=hWBae0T6KKQZcFdHfgGMWxWtO/WEmhLU3FHnvN38aU2jRRMrD8T/x1GP+x5hWyIxKX\n LZYzRLiaBJfzHyhnle0iKmxKmE5rKrI5MAnaJzyTseHcJDwBQRKcp+WQ5GzR2qubmamK\n YwgiVkffHG73CWS+zroeCq6fseIj084SAkKXIdWg83uEcyDqFnvs5EJWy87fNyTyffPH\n KaeT2DVuu6XxQegbl0tEnjuNfxAc19I9O9vraOvaCioUuqpRktFhR7IbO43KWIlcYb6U\n lRBS9NAAMi5IHexSWeF/QA7puXP08u8fdZ07P8crGopmaaaqcgCitYELs8h5jAQ4WML8\n 1K4Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775119129; x=1775723929;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=QXjYE15G67HUWRDylibfRXTN5ohY2vP4wDogCfDGsoQ=;\n b=JbochPtmt6r+gM++NQNGwA9891BknyIl9LVf/AABoBGay2/h/ccRHrNFJ9fMhP+OOk\n 40T9gZIudMKqfUL4xJ2ZGW+I/WJ5DI9Bo8LFQRHjC+7KaQTf7M0PHTvHAI8BXR3dWfoA\n Ger8alaGFKbodGNoHMohQ3fAVB7AhMn9DzQik9HrdYIJq8k3i10rGqldv6mPsadjxT6n\n LI95wEQY9Cb+36BRGN3aRMSiuXrFQNs6sp945ZxFwwLsWq0ETs0Qx0PA+R17ZpUdqfS/\n R8J6vvpgrAIbYkeuZCOGj8QbCjvbLLXu87lRauQi03FeavpbS/k1i1iKP2dQoNNIAvCW\n dS/g==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWAIPByNM/PD2EuhrPgMcB/Zdvw1Pk9PbUOUlCCiUCQh63vTTLQwxwM+nfkpZJyPeLs4QVi6aM=@lists.denx.de","X-Gm-Message-State":"AOJu0YyTig11TsABC2SrxaohvLiW5yctgNr37TWFB7ZSvBfsRDb7trE1\n z78okY2iS1zBktawbRIU+X7sEO+w7SkE71J3dGE+xS0Ml6+sDGARA6lCB1ZzHCWj6thMxT2DKWR\n S/QvfLuDNGIRRitAaGdn4YXFk+LvPrigEYuCFUHjT9g==","X-Gm-Gg":"AeBDieudMU/rHHJnIplHr4szefPrGRe9uCsz0/U5jHzWrhtTfwcJzyRwuFfSv4xD4Md\n 8WJKrtDm58NwTTQFHLryxCzgLCG476Z87tR8jXcB2tJM1BYLDOIeuehPXyN53o/Qm5XMjZQ/AF9\n iHSNc5bMdZSJIC6Q1gA8fOfKr8Ymb/9m/R1FOvRk+U+mFMHfdGxsg7NBzsv0q09Ie5dBVzhmZZK\n QVEk1DXkwQYxB1emCULziKUIxUEOd9e9cTYPX6wGIZQiu22JoCvea1RVuUurKvW/dnlk9m8unWY\n evVsdrB++BM9wwESA4KkWe4zhUDQMGTIqZrXkUsRYuOTO4/dX/QFWfKwslEo6f0g6NNLtbmqi7y\n Uih4vdQbzWRm8bD74sw8SWhbNiYw7H/gyqHYWLZBv+zGisv3i6wgl1Oc665xyhP2LywzrWs37o4\n KM4kluZB4YUCA9sm9J4Qv7whwH0Dj+S8SnH0Q6XpJJWM+uAsbGO/SRHYom/O5ozUSLdd7qHT60+\n aacr6l1/mzwAN4Gc0F/l1zs8pbxhPb2swowIB1dFNsqQ0a/9nYfQGJNED3ojUWQjqPy9brmvNb/\n NomAVxbjdqXk1U0HllTBheoZAqYvtf2y+gglIJYeSM7t","X-Received":"by 2002:a05:690e:4842:b0:650:fae:9bce with SMTP id\n 956f58d0204a3-6503bc5f804mr1373746d50.69.1775119128925; Thu, 02 Apr 2026\n 01:38:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20260402001410.3736815-1-rs@ti.com>\n <20260402001410.3736815-3-rs@ti.com>","In-Reply-To":"<20260402001410.3736815-3-rs@ti.com>","From":"Ilias Apalodimas ","Date":"Thu, 2 Apr 2026 11:38:13 +0300","X-Gm-Features":"AQROBzBcZtXtL1UpPYfaOgVwzjvd3tjbT8UVAPnp3DeBK249p05c0SxA1OmtkuY","Message-ID":"\n ","Subject":"Re: [PATCH 2/6] efi_dt_fixup: use fdtdec_get_bool","To":"rs@ti.com","Cc":"robertcnelson@gmail.com, ayush@beagleboard.org,\n Erik.Welsh@octavosystems.com, anshuld@ti.com, bb@ti.com, trini@konsulko.com,\n afd@ti.com, xypron.glpk@gmx.de, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]