[{"id":3673325,"web_url":"http://patchwork.ozlabs.org/comment/3673325/","msgid":"<6d54c78d-0a65-4b89-8672-cc3c965d8763@linaro.org>","list_archive_url":null,"date":"2026-04-03T21:35:36","subject":"Re: [PATCH-for-11.1 8/8] target/arm: Compile KVM as common object","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 06:17, Philippe Mathieu-Daudé wrote:\n> Neither of kvm.c nor hyp_gdbstub.c use target-specific code.\n> Move them from arm_system_ss[] to arm_common_system_ss[] to\n> compile them once. The arm_system_ss[] source set ends up\n> unused, remove it.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/arm/meson.build | 10 ++++++----\n> 1 file changed, 6 insertions(+), 4 deletions(-)\n\nReviewed-by: Richard Henderson \n\n\nr~\n\n> \n> diff --git a/target/arm/meson.build b/target/arm/meson.build\n> index f14debc6a2f..1b5d346d474 100644\n> --- a/target/arm/meson.build\n> +++ b/target/arm/meson.build\n> @@ -1,7 +1,6 @@\n> arm_ss = ss.source_set()\n> arm_common_ss = ss.source_set()\n> arm_common_system_ss = ss.source_set()\n> -arm_system_ss = ss.source_set()\n> arm_user_ss = ss.source_set()\n> \n> arm_common_system_ss.add(files('gdbstub.c'))\n> @@ -19,7 +18,6 @@ arm_common_ss.add(files(\n> arm_common_system_ss.add(files(\n> 'arm-qmp-cmds.c',\n> ))\n> -arm_system_ss.add(when: 'CONFIG_KVM', if_true: files('hyp_gdbstub.c', 'kvm.c'))\n> \n> arm_user_ss.add(files('cpu.c'))\n> arm_user_ss.add(when: 'TARGET_AARCH64', if_false: files(\n> @@ -39,7 +37,12 @@ arm_user_ss.add(when: 'CONFIG_ARM_COMPATIBLE_SEMIHOSTING',\n> arm_common_system_ss.add(files('cpu.c'))\n> arm_common_system_ss.add(when: 'TARGET_AARCH64', if_false: files(\n> 'cpu32-stubs.c'))\n> -arm_common_system_ss.add(when: 'CONFIG_KVM', if_false: files('kvm-stub.c'))\n> +arm_common_system_ss.add(when: 'CONFIG_KVM', if_true: files(\n> + 'kvm.c',\n> + 'hyp_gdbstub.c',\n> +), if_false: files(\n> + 'kvm-stub.c',\n> +))\n> arm_common_system_ss.add(when: 'CONFIG_HVF', if_true: files('hyp_gdbstub.c'))\n> arm_common_system_ss.add(when: 'CONFIG_ARM_COMPATIBLE_SEMIHOSTING',\n> \t\t if_true: files('common-semi-target.c'))\n> @@ -67,7 +70,6 @@ else\n> endif\n> \n> target_arch += {'arm': arm_ss}\n> -target_system_arch += {'arm': arm_system_ss}\n> target_user_arch += {'arm': arm_user_ss}\n> target_common_arch += {'arm': arm_common_ss}\n> target_common_system_arch += {'arm': arm_common_system_ss}","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=o4nnbwTP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnX8f0B24z1yD3\n\tfor ; Sat, 04 Apr 2026 08:36:02 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8mB7-0006Tp-HT; Fri, 03 Apr 2026 17:35:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8mB6-0006Th-Fc\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:35:44 -0400","from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8mB4-0005F2-U1\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:35:44 -0400","by mail-pg1-x52d.google.com with SMTP id\n 41be03b00d2f7-c70f91776fcso866989a12.0\n for ; Fri, 03 Apr 2026 14:35:42 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c76c65935cbsm6064299a12.26.2026.04.03.14.35.39\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:35:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775252141; x=1775856941; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Ndx0up5CpcMwLnp/yDvyOMQs3vzA6ogm2gRKvfvFcrE=;\n b=o4nnbwTPpeekKt7wpgb5kupFaPdxYxbj6mme3ArD1J3dFBsN7gJAZIUr/M6SZ4+yOm\n 6uGjU++IwJenvSJ3Czp11PYneYV8PycX/XWYwoes4njWmLpXhEnUlEqqn83EMrcBRTh3\n Rp3RMl4cEhF/3uvnkkpoLnsBb3jy2tJxr6b58fe5bDWafVRJ4g17BqeKF8Apzg35PVOY\n 5Zg4usWaPxfBUMVqNc7O93rB5pKInCqdIRaIezEVczwfZX3YKdp1cuEado149Jzhil6F\n /oDrbCZBKQBYLoMAejSv1MjmD77/PEkQNmHtuadxlWpbKLR9z+GZLBDyWlsDTyBfLojg\n ZMwQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775252141; x=1775856941;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Ndx0up5CpcMwLnp/yDvyOMQs3vzA6ogm2gRKvfvFcrE=;\n b=Snc+ugfkNHFq8/Nxx1KEJc5xSZC1fwEyGv3bu9JyttT9FMQe45wobiL7dhtk1C+tEm\n V9gwgoG7GhMzkPFhC1Dis2YsstAaFacUVLsDeOZ+RnRciFCka7o1mUa2ZYImLONbQU0j\n z81wfj9JVa6d4dDF7kEli/xuCDKdHGdAlKJnAYhUkUxfS96phzb0+aUuEOn9RshI2zNk\n rC5SSfmGViVz7uCC9aDTLY+5yYMwZ6HVIH73s9iuYUpqG3oVU6AiLChwD8diFpPz8YfZ\n apqTjPIuUYo/u4dXlPCz0jHBxWBbx6KrRHaJBeIMb4DbK7pVTBsvWd8tLF1MssIuHhJ1\n iqzQ==","X-Gm-Message-State":"AOJu0Yy595odZEDih10POtVDFkUHInLjbiNfHo0ltY8+4DGUzLBaImLZ\n YcHVxyxrSerkI/soccV7wFNCfqqiIZn7YgNtC8UpU9VjLtGL6O9DwqqI+YzkNQcMR/YBXosRGOI\n DDZN2dAo=","X-Gm-Gg":"ATEYQzz/y2KtZjppwSSGCtmSPUWygamkV2NdwQitm6yTyKjaXel/5dAtJfcQMGktREg\n TPss1cqKAkkkx1Jgm0C1sZOR0z/4vrEHd+bHMeQdCLM9OPRSohSptUiaQj09SpvTJcpLEKXzjUQ\n 0vdNct4xJt6OjNnzQ5rWhtEF+boY8dBUyo5McAyZfRMcxbq4QLym5jfuj0YK343X+u44mi1MOrl\n tp/B8H02iu92BQ/BWxfiN9VkLxH2wk3YtVfvCkpwSBgPQetvWx06L+snOKtHQ+iFBsVHaxyI3rn\n dCkpOGvDsGC+r2szWEH37PcaLhJqdQ4OXxZBLxNWNUZJgFSzfvy0jV+hN6FVxDeNXkQHADxlvIU\n 9oU7K3Rj5kT965MYKsotXA3EZ5OWEITfiOcXu+hZrTRg77lTSh3lrcVTDAo5AUWqDMdAKOAcZzD\n jGZZdmbNozTRUm84GJ21A+UchdZigR+fUadmmOTtAr+FFXEdLGK9HarbcRIwo4ZjRugjU=","X-Received":"by 2002:a05:6a21:3283:b0:398:9662:10ff with SMTP id\n adf61e73a8af0-39f2eda28b2mr4396566637.4.1775252141293;\n Fri, 03 Apr 2026 14:35:41 -0700 (PDT)","Message-ID":"<6d54c78d-0a65-4b89-8672-cc3c965d8763@linaro.org>","Date":"Sat, 4 Apr 2026 07:35:36 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH-for-11.1 8/8] target/arm: Compile KVM as common object","To":"qemu-devel@nongnu.org","References":"<20260401201753.92290-1-philmd@linaro.org>\n <20260401201753.92290-9-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260401201753.92290-9-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::52d;\n envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]