[{"id":3673323,"web_url":"http://patchwork.ozlabs.org/comment/3673323/","msgid":"","list_archive_url":null,"date":"2026-04-03T21:33:10","subject":"Re: [PATCH-for-11.1 6/8] target/arm: Compile HVF as common object","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 06:17, Philippe Mathieu-Daudé wrote:\n> Neither of hvf.c nor hyp_gdbstub.c use target-specific code.\n> Move them from arm_system_ss[] to arm_common_system_ss[] to\n> compile them once.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/arm/hvf/meson.build | 2 +-\n> target/arm/meson.build | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~\n\n> \n> diff --git a/target/arm/hvf/meson.build b/target/arm/hvf/meson.build\n> index afc509a470e..ccb0d338af6 100644\n> --- a/target/arm/hvf/meson.build\n> +++ b/target/arm/hvf/meson.build\n> @@ -1,3 +1,3 @@\n> -arm_system_ss.add(when: [hvf, 'CONFIG_HVF'], if_true: files(\n> +arm_common_system_ss.add(when: [hvf, 'CONFIG_HVF'], if_true: files(\n> 'hvf.c',\n> ))\n> diff --git a/target/arm/meson.build b/target/arm/meson.build\n> index 6e0e504a403..f14debc6a2f 100644\n> --- a/target/arm/meson.build\n> +++ b/target/arm/meson.build\n> @@ -20,7 +20,6 @@ arm_common_system_ss.add(files(\n> 'arm-qmp-cmds.c',\n> ))\n> arm_system_ss.add(when: 'CONFIG_KVM', if_true: files('hyp_gdbstub.c', 'kvm.c'))\n> -arm_system_ss.add(when: 'CONFIG_HVF', if_true: files('hyp_gdbstub.c'))\n> \n> arm_user_ss.add(files('cpu.c'))\n> arm_user_ss.add(when: 'TARGET_AARCH64', if_false: files(\n> @@ -41,6 +40,7 @@ arm_common_system_ss.add(files('cpu.c'))\n> arm_common_system_ss.add(when: 'TARGET_AARCH64', if_false: files(\n> 'cpu32-stubs.c'))\n> arm_common_system_ss.add(when: 'CONFIG_KVM', if_false: files('kvm-stub.c'))\n> +arm_common_system_ss.add(when: 'CONFIG_HVF', if_true: files('hyp_gdbstub.c'))\n> arm_common_system_ss.add(when: 'CONFIG_ARM_COMPATIBLE_SEMIHOSTING',\n> \t\t if_true: files('common-semi-target.c'))\n> arm_common_system_ss.add(files(","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Fcp8o3zX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnX5r0532z1yCs\n\tfor ; Sat, 04 Apr 2026 08:33:36 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8m8m-0005Sw-KH; Fri, 03 Apr 2026 17:33:20 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8m8k-0005Sf-V8\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:33:18 -0400","from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8m8j-0004xA-Cm\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:33:18 -0400","by mail-pj1-x102d.google.com with SMTP id\n 98e67ed59e1d1-35d932cc948so1361530a91.2\n for ; Fri, 03 Apr 2026 14:33:16 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c76c6492097sm5948426a12.10.2026.04.03.14.33.13\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:33:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775251996; x=1775856796; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=xCfX4nMFfJpmH6h38T33fQotCzlDAApsW7fmoOhPgp0=;\n b=Fcp8o3zX1qDGogaqedvISsoshiOxjrJPpmHqnbPbGWVx4p0P29GLUnYdXNGd9/YpL4\n 0WAjva2kn5pBEdmsW2JjjBN2F7F/cBXzkPgbwB+/F6KfCDslIb1Tvxaprt0g6tzVtrmQ\n jxpqOH0bHPFXZw8veG2dzmycSYG4JkfaosvLd2oJE2r82wPTXbpnxtcQlggOfQZF1EvN\n 486RnVsdZolcU61yFAN2yWlel4pHWUTY/LXoWaKP5MoCzmjWeTYQJcRyB1zSe8IrsO/g\n q3mxYMclyMdtmBg5n8lKZhNzFyInRk9JmAA4r8+uwe3l/aP8EkZf4YMhLdr8ZBmNHr6r\n nu6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775251996; x=1775856796;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=xCfX4nMFfJpmH6h38T33fQotCzlDAApsW7fmoOhPgp0=;\n b=X+gw+p5bCSt0kYjmpBjWdNnqRtCOKu1l8RyKbb7JWe2if+9FLNjNDgMOWMJjpkB4kS\n zgtFaO25OZdGF3rOQIj1ge4pk8mBg60T1j4ScihiSn1WDF2VZ4VwBSxgVKoaMznsomyR\n aIrwQQhPza4wI/IASgP34Y/riihQ1Bm71mzOhAjoe+JOTJlwtHAdGo6kqAMPT069e6zK\n kTQyJ6dpRCpSplnPJi/fbkCzj9Fnep7gLFolvNkN0W0dVD7iEx7rTJyUZx8ra7XlHaWj\n 68k1P3cVSq/tWG5N0QuvVQelc8Smz8IE5pftCyuNYUq2swVSsgn0HB3v04DTfnlrFdgo\n ekCg==","X-Gm-Message-State":"AOJu0YzZY+L6u4wVN3lETU1tHyUgt6bpD899zVyoQWjqey/PjiO8oJuY\n G8lZf392u4XuCPXBvxSp1xVmSvXmh4KhOzn2pGdwITwsGigLDvK5kSwYfZajLDOtNg+aGrKKXsE\n VAj4KuOk=","X-Gm-Gg":"ATEYQzzmhJVRbNywkIc3J6qJJjkrYnsCaXmAQaOd//A1Ex0o4YeHBBexqVvtJ3XlSFz\n 2ZIKG9lP433Ax0brsTydsfG/b0ImrmYa3bzw/SzpB2Ul4SROOgnYYWBzTXgiMEXQs/6eTFNvM+A\n +mkQImlGW1vmXYb5nnkYV3/GKUwmig3iXuOdvLPgDxwR3Eb1HEKKlAsmoQpzNv0q04M7+V7jEwA\n 6B2SU31Z/O/65mOcmoH4uJXgog1ZJLUNad2IgkhhY8wGWPtUh9PUYBpUh/Zu1Z/5cgx66joj84d\n IsWv+FtH72l3sNaO8ARWBphIEpPYpbr3YOLDGS0JzkgFT7ATfIJRqeMbg7MUuH0IEY29mmsvvxV\n tkVU1vmiwdpnI9CMPClz6ZRNbryAmM5WFBlypc0IRILGOcbEXYbkTgLHRQazDhBQrIqKDKawx/b\n ZaBDAuJJT6L3rizoUq5H53wk1gYNm6M9gd196kO9z1F74Q3RNIq3lqEb3CpKMzxa5vJ3NbBsm/y\n T/a+Q==","X-Received":"by 2002:a05:6a20:3d05:b0:39b:f12e:d53 with SMTP id\n adf61e73a8af0-39f2ed8d756mr4174720637.18.1775251995752;\n Fri, 03 Apr 2026 14:33:15 -0700 (PDT)","Message-ID":"","Date":"Sat, 4 Apr 2026 07:33:10 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH-for-11.1 6/8] target/arm: Compile HVF as common object","To":"qemu-devel@nongnu.org","References":"<20260401201753.92290-1-philmd@linaro.org>\n <20260401201753.92290-7-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260401201753.92290-7-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102d;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]