[{"id":3673322,"web_url":"http://patchwork.ozlabs.org/comment/3673322/","msgid":"","list_archive_url":null,"date":"2026-04-03T21:31:52","subject":"Re: [PATCH-for-11.1 5/8] target/arm: Remove target_ulong use in\n hvf_handle_psci_call()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 06:17, Philippe Mathieu-Daudé wrote:\n> Similarly to commit 3580aa03547 (\"target/arm/tcg/psci.c: make\n> compilation unit common\") which replaced the target_ulong use in\n> arm_handle_psci_call(), replace the one in hvf_handle_psci_call.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> Reviewed-by: Pierrick Bouvier \n> ---\n> target/arm/hvf/hvf.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c\n> index 5fc8f6bbbd9..678afe5c8e1 100644\n> --- a/target/arm/hvf/hvf.c\n> +++ b/target/arm/hvf/hvf.c\n> @@ -1418,7 +1418,7 @@ static bool hvf_handle_psci_call(CPUState *cpu, int *excp_ret)\n> bool target_aarch64 = true;\n> CPUState *target_cpu_state;\n> ARMCPU *target_cpu;\n> - target_ulong entry;\n> + uint64_t entry;\n> int target_el = 1;\n> int32_t ret = 0;\n> \n\nThis could be vaddr, because entry is the start pc for the on-lining cpu.\nBut uint64_t does match arm_set_cpu_on declaration.\n\nAnyway,\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Id96kUcy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnX4M1p6cz1yCs\n\tfor ; Sat, 04 Apr 2026 08:32:19 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8m7V-0004GY-NQ; Fri, 03 Apr 2026 17:32:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8m7U-0004F8-A0\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:32:00 -0400","from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8m7S-0004sO-UA\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:32:00 -0400","by mail-pj1-x1032.google.com with SMTP id\n 98e67ed59e1d1-3591cc98871so993878a91.3\n for ; Fri, 03 Apr 2026 14:31:58 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35dbe95abc3sm12537387a91.15.2026.04.03.14.31.55\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:31:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775251917; x=1775856717; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=WmDyxPnfruQ2f/86WMPLM9VunxPOUc4NK0eBB5Qwglk=;\n b=Id96kUcyRnLty0EDWJ9wYftFAIZIrGj/MvoA/xTyHae4Ycj6RTnugHYKx4Uj62dOPT\n jbgNW4dM0TY2f2vxQzuL0Ve9FqB6XcesANBwSJcdl53U+w4punw2tphhXIS/Jol/J6eW\n U0ApXKBmCSJmoWq0PvMuslKUPy4BJatA1FVC13EZHVGe6Z3R7iANhG+tKUbusaisqAPP\n oUqSpHfI1tSgZ0VYSFKpWIZn8d6sjGg8F8e8VmxcG7kpoSpQCHm31zsKrQxdi5EVbrw6\n 7Hp1EVlSR8G0VsshM9nTucfRrr4JXThI/PH2asw4pmRLt7smZ96aaNmqR/ppwgPhjUny\n luBg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775251917; x=1775856717;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=WmDyxPnfruQ2f/86WMPLM9VunxPOUc4NK0eBB5Qwglk=;\n b=hsihnEk/Ow67JnvGyWpJvZp7t0FTACbvBf4+gCtDQi8mN7ve2qo/4JF3HRgZdQos2X\n DIALq2vd4w5Kn2BcJulUg3WDlA5PdGv//WXuQYicU8cerPYPNRZcuqNlkTKHbbZ8IapH\n pAJZavhhqP4zHXknuWEzoEZMHIqsgYVmqWITgQWIyLc2cFbfRlbdhX9+MLUfkL/5X6ob\n IJSd0UhnkkVNcKyz0U6mq56W7uCsOMIy0u6zYvh5MGnycesk/2kNXxFcsUHB/DwlKJ5o\n Wri0aM+JRxty1gXdiXoYAExY+YAjyLp+ut1cLnZEx1mouQzzJWa61pBylbceJXfpryaB\n onNg==","X-Gm-Message-State":"AOJu0Yx2lIknO0KU20xwiLgHUWXVzVqMPcuwQjtkJd/QFPalzqe9J9Pg\n cnbboHL0SRKVFHfqCOU1+5zSivTF++/L5m4EOWwhT23hf0aIf7nFjYhpZxC+6w4dv72Y/QuQLyP\n 7Iz0BuDk=","X-Gm-Gg":"AeBDievL6pcElyaWhqzaoQuX4CNRVHQiRfTpeN19IjOutp2ZzQnBiNycET5p67FqxcT\n Bd8CymlGYWNAzdpeQ5vx8mTQbsEcoYNNoBjMAZdaIthnGkRZ24RvUWFkMWoIw7GUYd3ZI8HBjmW\n SRFDa9ieCwQBIWo1cBM12DbFyGPYTlPDGg+XNvL8t/GFwdiH0AN+FNLDXwoFAaHAnKdGZhAtAqL\n U5pOCI7pKzo4JIJca7LDM2EZyEat0Dy2N5xiSBjD15H8NwkaEwgld/H7SUydOJ5Dw78YzPhU2ef\n vu3G6jtzqWHGc0Va1CBp1cxDmwUsNO3B7Dgwd+Ik+uurP5zRI6wvx3zjIG04j18D4b0O1vvW/QC\n DpteGC/7fkvviY2cMYxGYFr9zgCImKM2HU/t+vonbVtirZNG2zOKWy2r8ItrQBD4kNqWfcPgGu4\n a3AgFLBP/o5Jad+5wgIm3r2p5OywCO5Ta3g4SosSYXQSvJF+f43W1kVcgrZjgKjBj1yxo=","X-Received":"by 2002:a17:90b:4b89:b0:35d:a9bd:1ff6 with SMTP id\n 98e67ed59e1d1-35de695fa86mr3598786a91.23.1775251916924;\n Fri, 03 Apr 2026 14:31:56 -0700 (PDT)","Message-ID":"","Date":"Sat, 4 Apr 2026 07:31:52 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH-for-11.1 5/8] target/arm: Remove target_ulong use in\n hvf_handle_psci_call()","To":"qemu-devel@nongnu.org","References":"<20260401201753.92290-1-philmd@linaro.org>\n <20260401201753.92290-6-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260401201753.92290-6-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1032;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]