[{"id":3672433,"web_url":"http://patchwork.ozlabs.org/comment/3672433/","msgid":"","list_archive_url":null,"date":"2026-04-01T21:02:26","subject":"Re: [PATCH-for-11.1 3/8] accel/kvm: Expose all non-target specific\n declarations","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 1/4/26 22:17, Philippe Mathieu-Daudé wrote:\n> None of the declarations guarded within the COMPILING_PER_TARGET\n> checks use target-specific declaration. \"cpu.h\" is not required\n> since some time (maybe commit 4fb54de823e \"meson: build target\n> libraries with common dependencies\"). Remove the restrictions.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> include/system/kvm.h | 5 -----\n> 1 file changed, 5 deletions(-)\n> \n> diff --git a/include/system/kvm.h b/include/system/kvm.h\n> index a2463a3ac3f..8bf7a10deac 100644\n> --- a/include/system/kvm.h\n> +++ b/include/system/kvm.h\n> @@ -224,9 +224,6 @@ void kvm_irqchip_add_change_notifier(Notifier *n);\n> void kvm_irqchip_remove_change_notifier(Notifier *n);\n> void kvm_irqchip_change_notify(void);\n> \n> -#ifdef COMPILING_PER_TARGET\n> -#include \"cpu.h\"\n\nMissing:\n\n #include \"qemu/queue.h\"\n\n> /**\n> * kvm_update_guest_debug(): ensure KVM debug structures updated\n> * @cs: the CPUState for this cpu\n> @@ -449,8 +446,6 @@ void kvm_set_sigmask_len(KVMState *s, unsigned int sigmask_len);\n> int kvm_physical_memory_addr_from_host(KVMState *s, void *ram_addr,\n> hwaddr *phys_addr);\n> \n> -#endif /* COMPILING_PER_TARGET */\n> -\n> bool kvm_arch_supports_vmfd_change(void);\n> int kvm_arch_on_vmfd_change(MachineState *ms, KVMState *s);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=JRazDKsP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmHXS4BzQz1yHK\n\tfor ; Thu, 02 Apr 2026 08:03:52 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w82hv-0006OB-4V; Wed, 01 Apr 2026 17:02:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w82ht-0006M2-1j\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 17:02:33 -0400","from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w82hq-0008Bn-Nf\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 17:02:32 -0400","by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-486fe655187so1749235e9.2\n for ; Wed, 01 Apr 2026 14:02:30 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4888955d711sm41710665e9.9.2026.04.01.14.02.26\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 01 Apr 2026 14:02:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775077349; x=1775682149; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=wu484ARXgNjrCXY792DVUqnqI/7zasFvjnpp9c4Q+uo=;\n b=JRazDKsPyUBHzXaqf5Vz3q0xqJYCOPxZhRf6CSjVzmZ4dkbPD3mSvyJir4z5epl0Ve\n 4jVs0qr9AobW1/N1BqXI72yhyQiAl+KkHHExSELALJ5txJU7onTDSKm5ODEMpdyAgetL\n 2SfJ98XMbU2CEClahxCFQ0iSj58QUoZ4plk8an5oF71iejOpKDr+xNI/YTJOEDsFMHCs\n 9p0bgcTZTRXhOzmArLg4yLovDGTP6BWezBHdLb3t5M04nE7LgOy7IryhzHOp/716YP3J\n HpYH8SzXy8pUC9JBp4M4nkC2ZNh1cV6dR1Da758p2DgbyILvGIKc5lnK2skw+Dqv030H\n Gk7Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775077349; x=1775682149;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=wu484ARXgNjrCXY792DVUqnqI/7zasFvjnpp9c4Q+uo=;\n b=l4VvYwP4QgI/mU+aWcgPYaGy66ffnNq8S+WMM/czEkaRriOswiCfGBRy5WneyWVslJ\n wCV3i7cdThGBw4m2uLSJ/9n3JE9mhFdAzIdZ8DtwcwLCnfGNJXHoZ86CG7jZPt/L1G0J\n 16asnMAW3l4G8pE4M6UzKR45ev0mWXB5/wrvhQQDDGP4woG1vaAjNsTjTWFi9GLHW5sQ\n Kov+t8bn+PFAG0TyeH+nmTQEcr7+lOjqdBFR++Qhz26cT/hAPQLBeONFzrGWzPkwJ1yj\n W+4fkQiU/4XxlAxOUgCKzw+wvk+1bLYnDSv++QH93Sjj67ZNipIPW8z3mU8Vo+I8YRIb\n 84DQ==","X-Gm-Message-State":"AOJu0YwYUuRhxFJOUR5bbA2QYS0Xw+NJj4SOQ7hM3jYHYsZixdud92nB\n 8/2Rc4AItshQk8MSGkAdv7alRGQCv+SjUSummK4TVWP112gwCW9jP48pwSCM/ke6c1SpVhETbfn\n B+Sd3d8E=","X-Gm-Gg":"ATEYQzx6h20ANQp/Tf3Y+k8r6ah8y/KXkjTbOCyWpl+NXoLXhlQ+CJdrVCeg+Y2X35B\n pecH9P00to3recPEoYiPYSxORd0DW2dDzHf4FOYvCU1R9ukVh9thwVN5aPs7lg9lv1AcNZ+ip7k\n 5+UwMbRsxV3m91YSfZJVKxlM3TQs+XaZeiLwtcfzea4oltzkHsQhntnLq30g2T7HY+Wg+5q6cGM\n bVBUD10/6FxuQ+BpBtzedtcdfYOge70Pi9fi15bnLp5VF+4yDXEAIoqTuxgSQzBmZ6xeZvBeKAI\n DeOkR362AjD+TYv3+Ig11mlWq0klnQkcirSrDqgCOnhCrUpmuyf96N7FXxJ4apPWNn43Dg/U4qY\n znIM0yNsB6BWU0vNPzv9Ims2xtKgvSYeZbSezWScuAPyPkzB3GDL3rEWONluqloBa7gFAuz9S6G\n ua8kBm979Z8+CNkZextAjkWMsx3SYT2AZoKX4DrBE88zIc7/r4YZE29LfQr4YubsswYg==","X-Received":"by 2002:a05:600c:c165:b0:488:7ff6:1f75 with SMTP id\n 5b1f17b1804b1-4888b786676mr11650045e9.21.1775077348657;\n Wed, 01 Apr 2026 14:02:28 -0700 (PDT)","Message-ID":"","Date":"Wed, 1 Apr 2026 23:02:26 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH-for-11.1 3/8] accel/kvm: Expose all non-target specific\n declarations","Content-Language":"en-US","To":"qemu-devel@nongnu.org","Cc":"Eric Farman ,\n Alistair Francis ,\n Palmer Dabbelt , Paolo Bonzini ,\n Matthew Rosato ,\n Daniel Henrique Barboza ,\n Pierrick Bouvier , kvm@vger.kernel.org,\n Peter Maydell , Huacai Chen\n , qemu-riscv@nongnu.org,\n Alexander Graf , Pedro Barbuda ,\n Anton Johansson , Song Gao ,\n Weiwei Li , Aleksandar Rikalo ,\n Liu Zhiwei , Cornelia Huck\n , qemu-s390x@nongnu.org,\n Chao Liu , Bibo Mao ,\n qemu-arm@nongnu.org, Jiaxun Yang ,\n Mohamed Mediouni , Zhao Liu ","References":"<20260401201753.92290-1-philmd@linaro.org>\n <20260401201753.92290-4-philmd@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260401201753.92290-4-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3673319,"web_url":"http://patchwork.ozlabs.org/comment/3673319/","msgid":"","list_archive_url":null,"date":"2026-04-03T21:27:52","subject":"Re: [PATCH-for-11.1 3/8] accel/kvm: Expose all non-target specific\n declarations","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 06:17, Philippe Mathieu-Daudé wrote:\n> None of the declarations guarded within the COMPILING_PER_TARGET\n> checks use target-specific declaration. \"cpu.h\" is not required\n> since some time (maybe commit 4fb54de823e \"meson: build target\n> libraries with common dependencies\"). Remove the restrictions.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> include/system/kvm.h | 5 -----\n> 1 file changed, 5 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=KrD58CKk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnWzZ6XZrz1xtJ\n\tfor ; Sat, 04 Apr 2026 08:28:10 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8m3c-0002bj-Ue; Fri, 03 Apr 2026 17:28:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8m3b-0002bX-Rp\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:27:59 -0400","from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8m3a-0004QQ-Co\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:27:59 -0400","by mail-pj1-x1032.google.com with SMTP id\n 98e67ed59e1d1-35dac556bb2so1459650a91.1\n for ; Fri, 03 Apr 2026 14:27:57 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35dd367bfb1sm6646375a91.10.2026.04.03.14.27.54\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:27:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775251677; x=1775856477; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=6RGD2l8TvmqrGHVHFDU1cAEPa/nvWWAOXIZ0zVBc/BY=;\n b=KrD58CKk9pQayvAePFvUWWu0NggZtfUwYHp7DUybK05IqpAnCZPMxV9IcTq/ONB+zQ\n ltSb5STRSzzJr362eENUx9Lsj+ZrRzZ/A7920ISEbS2Mxb/6Cy0N32d6v7mybAtqa0Rk\n SnF95ZUXRI0nAWilUW47LEQyKPO9j6LROLY/DXq5FeNnERMWoyb/AtiJLQqFrP7L54F1\n nBYxtcdxkty0f1gKGxUx83fG1l47q1qYtwsz90TL04mjSjE7Qq3vVd8SyS6ymHqdBKVl\n 2It2G8PUJEXhbp4ttlng3jiDXmYiTYyNu/NmDCeXsPTHK23GUCXKCB9JtTDzOn+JScdc\n Uzqw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775251677; x=1775856477;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=6RGD2l8TvmqrGHVHFDU1cAEPa/nvWWAOXIZ0zVBc/BY=;\n b=VAXtINArzFDAmhvne2i9fF+8CJBnyTM0I9HbTloRr6LAGcTn72EZFrQ3d8fAsXnSY1\n xw0RhJ6mdm8pDKAvzQDgR7Q16g+MPcy578RJTMBtAbXSEILg0BMAboho9Jjb6brTOpaW\n 2mkQbx9F6S5kYLPLtEHHIOxgeSIB3g4ODC8UFwQ8fzc/FljD5FtXOkXnLK/wWLocL8Yz\n lDah0ea9G2FO34dCV7W4PZT9HX54fZX82/6geLbFs60nnlWIdjOzyxTMAaAth2S1u/sf\n tyeaXr85Dpzlb+Dy1d0T9mc6hkxCuXpkckrqVtrAeZeRol1+bxCttyflNiH29JSD4CY1\n x59w==","X-Gm-Message-State":"AOJu0YxH+DEpoAV56nWsWj08J1tBtOdZe4EU3Z41mWCwmB2QasyWiPgK\n xgbpCxt6D48C3uNWod958g0pIfQgX/eAGAAsFbzd8b/XEIu7oW6y9f7mxSqut2PtCNdAcyKyBOy\n +YsVEHNU=","X-Gm-Gg":"AeBDievPRcj9w4m0vAF8dKPNjQ/1gjMUj0MItcfblxXBgDmt/BZ5pQ9XqnfGDCC/Xzq\n mzfAHPfEKNWRlZLaYxc8/1b7UHY0eptKp6wdGLxa1VVkWk4cq7jWB4xIYV5fbLHbugIDCqqO9lb\n 5OoYhF6Vw7A7ICzUqRJk/hzOp9fHwxaw6fTBUVrcOtGEZgq7/OCizi4/zLasIrVO6S2lXNByab5\n Y8Za0hTagsL+s3KXZastceTUFUHWHzK8X+xnCsfxFx18lTHG9uGHILRncDV8LInwsimjZqsz2AK\n X1PVdNbWTJGMyOacJON3gOG4XtWWFkb+JqomVDCF5L31OS2CVDpmH69CnNxrhwAOB9enrr5Zl54\n hmubbCGaOrMeTDZWGKcAdKBSiWLYFs1aoA8SEowxnk+TCsDroXVuaZcydeyD+1H9cm7QH0P8jZ/\n e2hpt1JX6aRbrd52MDUfw6DFU5sV89dYWcsJrisPPQb207FTz1/haM+7mBSGBEapX3bss=","X-Received":"by 2002:a17:90a:d406:b0:35b:a656:a60e with SMTP id\n 98e67ed59e1d1-35de68952f4mr4167971a91.10.1775251676490;\n Fri, 03 Apr 2026 14:27:56 -0700 (PDT)","Message-ID":"","Date":"Sat, 4 Apr 2026 07:27:52 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH-for-11.1 3/8] accel/kvm: Expose all non-target specific\n declarations","To":"qemu-devel@nongnu.org","References":"<20260401201753.92290-1-philmd@linaro.org>\n <20260401201753.92290-4-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260401201753.92290-4-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1032;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]