[{"id":3673321,"web_url":"http://patchwork.ozlabs.org/comment/3673321/","msgid":"<2993b663-5a59-4992-9080-2591b9bc2059@linaro.org>","list_archive_url":null,"date":"2026-04-03T21:28:49","subject":"Re: [PATCH-for-11.1 4/8] target/arm: Compile WHPX as common object","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 06:17, Philippe Mathieu-Daudé wrote:\n> whpx-all.c doesn't use target-specific code, move it from\n> arm_system_ss[] to arm_common_system_ss[] to compile it once.\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> target/arm/whpx/meson.build | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/target/arm/whpx/meson.build b/target/arm/whpx/meson.build\n> index 3df632c9d30..db31e928012 100644\n> --- a/target/arm/whpx/meson.build\n> +++ b/target/arm/whpx/meson.build\n> @@ -1,5 +1,5 @@\n> -arm_system_ss.add(when: 'CONFIG_WHPX', if_true: files(\n> +arm_common_system_ss.add(when: 'CONFIG_WHPX', if_true: files(\n> 'whpx-all.c',\n> +), if_false: files(\n> + 'whpx-stub.c'\n> ))\n> -\n> -arm_common_system_ss.add(when: 'CONFIG_WHPX', if_false: files('whpx-stub.c'))\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=pUo4D4qO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnX0v0TFlz1xtJ\n\tfor ; Sat, 04 Apr 2026 08:29:19 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8m4c-00034h-5V; Fri, 03 Apr 2026 17:29:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8m4Z-00034J-AQ\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:29:00 -0400","from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8m4W-0004Su-DG\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:28:58 -0400","by mail-pl1-x62a.google.com with SMTP id\n d9443c01a7336-2b23f90f53aso20896045ad.0\n for ; Fri, 03 Apr 2026 14:28:55 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2747a7115sm62050885ad.36.2026.04.03.14.28.52\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:28:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775251734; x=1775856534; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=AF8jA/lSqOWkyNVDlVGbweulaMzbiMxC8f/mvsGIjBM=;\n b=pUo4D4qOc7ImSmy1XjU7A2MsAx5KlAbJWJZQGXxm3suoRc2TSiq6puDW+y54hdWm6r\n +l35nUOJHG1uAuOnENMRlYyf019mm64I2BB8bCfVre/LEgnkDK6BWEyY9ieBEeFFQou/\n PddHNW+JvESMKdzUhU3LCaMQbqDe5379v16IE3HRs3mQok09bFDJE6/DPpBmXI740rOc\n eaWmdQgu3Ssd1ZpAyziwoGno3osShW/uAY90C09MOHf/J7GtI14Xei0UIDyxXrzoaVKx\n 7clJlUdpyT+TVoKRuuLKUpaoSCK3DOY0kLTqha2EZCJX96wqxGYh5CXUvQwjZLBZv5FO\n Scng==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775251734; x=1775856534;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=AF8jA/lSqOWkyNVDlVGbweulaMzbiMxC8f/mvsGIjBM=;\n b=epEAZ6QcsedggwHkDsQIZDzOwsFOez9nLtwzoyFWcv3m2bh2us7XOfqmixJsYa1cho\n +MNRJ1Dq++IbxVOc3IxjMTZnPSdmcfi7zosuKOwA9voA716bY/vsbpGuJTr7WF9VRMUX\n on9XLkTNIVv6UTs2ETHwgsh7H1xWvQB+6GhbXqkHYFEOPjCTUW8/dR1t/hem6TFiTybA\n 5SZCkn6osUp3Hg2EvzJPdCOou2xsj0EiCtU57y5zBVHsrioAnHF2cUj+Q+OJzByHQYwq\n FGWAJUVHR/nR5wU7nSZ/OYi7/eZQ0nUbn/nxbcbTEn285BGS+TMaZpq5FPym/llYCGgs\n Qgeg==","X-Gm-Message-State":"AOJu0Yzgy4ZoKdxL+7Oxt7MuN1z8ificrlSkDi6dIFezLGjaKoPfYw4f\n 0elx0iUCNBbyfRsAgHI8ozLZzMNiHjYayLKuv/3ZRzI7MwMn6WQRLUQJ23dGdRtIYdc4EvWSiKg\n m+Vw2UhA=","X-Gm-Gg":"AeBDieuOUgnM8hDbzoFtU2uEUMVhx6vbsGdVZrenW/S5tOkbQ8qkY6heEng4zVSApe0\n cQ0Wx0zJXDQJWAJxdFw/SIgKMKi55HtIjYImzIF3Qjeb/u9v9HnGPP41Zq3QWVAYTJhBxt5PzQt\n VH9vaMjAe0J7y1kOmamTTR25cdTLkLBMDWdlQ29X+HGVFeGraPi/OMS5vg4wOOZejtGk+lTTyA1\n P/PdStl7II4BowaZ6xlLqQNYAZjhr49TqqFpEfyOaPbhILhTsMAifeBgL8Om/8djyk75lVoQxpy\n TYWkp4i832qFwdsgl9kqUBH4Fm/l/BDVMzaNrrEOYdFWQmiJZvBdDzoaRF2iAR7SAfXHX7VA6bW\n tCXPRFsOTZJPkdsVtRuhj5pBtsXG3NQD9mAla/UJIOnLSTIAS7InhLnpxH5NZ0n21B04wFLrzsc\n JhZK5zx4sGNzE45LiTULqHZW4BYxXcibXoXi3fL3yYulMibqx8A5l+andYvKokj1kYxD8=","X-Received":"by 2002:a17:903:38cd:b0:2b0:5cee:c421 with SMTP id\n d9443c01a7336-2b281672acfmr48920345ad.4.1775251734353;\n Fri, 03 Apr 2026 14:28:54 -0700 (PDT)","Message-ID":"<2993b663-5a59-4992-9080-2591b9bc2059@linaro.org>","Date":"Sat, 4 Apr 2026 07:28:49 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH-for-11.1 4/8] target/arm: Compile WHPX as common object","To":"qemu-devel@nongnu.org","References":"<20260401201753.92290-1-philmd@linaro.org>\n <20260401201753.92290-5-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260401201753.92290-5-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::62a;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62a.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]