[{"id":3672514,"web_url":"http://patchwork.ozlabs.org/comment/3672514/","msgid":"","list_archive_url":null,"date":"2026-04-02T00:45:59","subject":"Re: [PATCH-for-11.1 2/8] accel/kvm: Remove\n TARGET_KVM_HAVE_GUEST_DEBUG","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/people/64571/","name":"Alistair Francis","email":"alistair23@gmail.com"},"content":"On Thu, Apr 2, 2026 at 6:18 AM Philippe Mathieu-Daudé wrote:\n>\n> All targets except MIPS have TARGET_KVM_HAVE_GUEST_DEBUG=y.\n> Declare the kvm_update_guest_debug() stub to MIPS and have\n> TARGET_KVM_HAVE_GUEST_DEBUG be the default.\n>\n> Signed-off-by: Philippe Mathieu-Daudé \n\nReviewed-by: Alistair Francis \n\nAlistair\n\n> ---\n> configs/targets/aarch64-softmmu.mak | 1 -\n> configs/targets/i386-softmmu.mak | 1 -\n> configs/targets/loongarch64-softmmu.mak | 1 -\n> configs/targets/ppc-softmmu.mak | 1 -\n> configs/targets/ppc64-softmmu.mak | 1 -\n> configs/targets/riscv64-softmmu.mak | 1 -\n> configs/targets/s390x-softmmu.mak | 1 -\n> configs/targets/x86_64-softmmu.mak | 1 -\n> include/system/kvm.h | 7 -------\n> include/system/kvm_int.h | 2 --\n> accel/kvm/kvm-accel-ops.c | 4 ----\n> accel/kvm/kvm-all.c | 13 ++-----------\n> target/mips/kvm.c | 5 +++++\n> 13 files changed, 7 insertions(+), 32 deletions(-)\n>\n> diff --git a/configs/targets/aarch64-softmmu.mak b/configs/targets/aarch64-softmmu.mak\n> index d34aead41c4..6f60ca6505c 100644\n> --- a/configs/targets/aarch64-softmmu.mak\n> +++ b/configs/targets/aarch64-softmmu.mak\n> @@ -1,6 +1,5 @@\n> TARGET_ARCH=aarch64\n> TARGET_BASE_ARCH=arm\n> -TARGET_KVM_HAVE_GUEST_DEBUG=y\n> TARGET_XML_FILES= aarch64-core.xml aarch64-fpu.xml arm-core.xml arm-vfp.xml arm-vfp3.xml arm-vfp-sysregs.xml arm-neon.xml arm-m-profile.xml arm-m-profile-mve.xml aarch64-pauth.xml aarch64-sme2.xml\n> # needed by boot.c\n> TARGET_NEED_FDT=y\n> diff --git a/configs/targets/i386-softmmu.mak b/configs/targets/i386-softmmu.mak\n> index 38a8f85201f..2eef68dc55e 100644\n> --- a/configs/targets/i386-softmmu.mak\n> +++ b/configs/targets/i386-softmmu.mak\n> @@ -1,5 +1,4 @@\n> TARGET_ARCH=i386\n> -TARGET_KVM_HAVE_GUEST_DEBUG=y\n> TARGET_KVM_HAVE_RESET_PARKED_VCPU=y\n> TARGET_XML_FILES= i386-32bit.xml\n> TARGET_LONG_BITS=32\n> diff --git a/configs/targets/loongarch64-softmmu.mak b/configs/targets/loongarch64-softmmu.mak\n> index 476407f9413..7e0b1ab5d05 100644\n> --- a/configs/targets/loongarch64-softmmu.mak\n> +++ b/configs/targets/loongarch64-softmmu.mak\n> @@ -1,6 +1,5 @@\n> TARGET_ARCH=loongarch64\n> TARGET_BASE_ARCH=loongarch\n> -TARGET_KVM_HAVE_GUEST_DEBUG=y\n> TARGET_XML_FILES= loongarch-base32.xml loongarch-base64.xml loongarch-fpu.xml loongarch-lsx.xml loongarch-lasx.xml\n> # all boards require libfdt\n> TARGET_NEED_FDT=y\n> diff --git a/configs/targets/ppc-softmmu.mak b/configs/targets/ppc-softmmu.mak\n> index 867898bd47c..c47887f8992 100644\n> --- a/configs/targets/ppc-softmmu.mak\n> +++ b/configs/targets/ppc-softmmu.mak\n> @@ -1,5 +1,4 @@\n> TARGET_ARCH=ppc\n> TARGET_BIG_ENDIAN=y\n> -TARGET_KVM_HAVE_GUEST_DEBUG=y\n> TARGET_XML_FILES= power-core.xml power-fpu.xml power-altivec.xml power-spe.xml\n> TARGET_LONG_BITS=32\n> diff --git a/configs/targets/ppc64-softmmu.mak b/configs/targets/ppc64-softmmu.mak\n> index 10d7a2681e7..8c6dc84b821 100644\n> --- a/configs/targets/ppc64-softmmu.mak\n> +++ b/configs/targets/ppc64-softmmu.mak\n> @@ -1,7 +1,6 @@\n> TARGET_ARCH=ppc64\n> TARGET_BASE_ARCH=ppc\n> TARGET_BIG_ENDIAN=y\n> -TARGET_KVM_HAVE_GUEST_DEBUG=y\n> TARGET_XML_FILES= power64-core.xml power-fpu.xml power-altivec.xml power-spe.xml power-vsx.xml\n> # all boards require libfdt\n> TARGET_NEED_FDT=y\n> diff --git a/configs/targets/riscv64-softmmu.mak b/configs/targets/riscv64-softmmu.mak\n> index 5059c550480..e0d2c7032d6 100644\n> --- a/configs/targets/riscv64-softmmu.mak\n> +++ b/configs/targets/riscv64-softmmu.mak\n> @@ -1,6 +1,5 @@\n> TARGET_ARCH=riscv64\n> TARGET_BASE_ARCH=riscv\n> -TARGET_KVM_HAVE_GUEST_DEBUG=y\n> TARGET_XML_FILES= riscv-64bit-cpu.xml riscv-32bit-fpu.xml riscv-64bit-fpu.xml riscv-64bit-virtual.xml riscv-32bit-cpu.xml riscv-32bit-virtual.xml\n> # needed by boot.c\n> TARGET_NEED_FDT=y\n> diff --git a/configs/targets/s390x-softmmu.mak b/configs/targets/s390x-softmmu.mak\n> index e273075f1a9..699e5ced96f 100644\n> --- a/configs/targets/s390x-softmmu.mak\n> +++ b/configs/targets/s390x-softmmu.mak\n> @@ -1,6 +1,5 @@\n> TARGET_ARCH=s390x\n> TARGET_BIG_ENDIAN=y\n> -TARGET_KVM_HAVE_GUEST_DEBUG=y\n> TARGET_XML_FILES= s390x-core64.xml s390-acr.xml s390-fpr.xml s390-vx.xml s390-cr.xml s390-virt.xml s390-virt-kvm.xml s390-gs.xml\n> TARGET_LONG_BITS=64\n> TARGET_NOT_USING_LEGACY_NATIVE_ENDIAN_API=y\n> diff --git a/configs/targets/x86_64-softmmu.mak b/configs/targets/x86_64-softmmu.mak\n> index c7f8746b4f5..491173df466 100644\n> --- a/configs/targets/x86_64-softmmu.mak\n> +++ b/configs/targets/x86_64-softmmu.mak\n> @@ -1,6 +1,5 @@\n> TARGET_ARCH=x86_64\n> TARGET_BASE_ARCH=i386\n> -TARGET_KVM_HAVE_GUEST_DEBUG=y\n> TARGET_KVM_HAVE_RESET_PARKED_VCPU=y\n> TARGET_XML_FILES= i386-64bit.xml i386-64bit-apx.xml\n> TARGET_LONG_BITS=64\n> diff --git a/include/system/kvm.h b/include/system/kvm.h\n> index 12f7fc8fb58..a2463a3ac3f 100644\n> --- a/include/system/kvm.h\n> +++ b/include/system/kvm.h\n> @@ -236,14 +236,7 @@ void kvm_irqchip_change_notify(void);\n> * calling down to kvm_arch_update_guest_debug after the generic\n> * fields have been set.\n> */\n> -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG\n> int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap);\n> -#else\n> -static inline int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap)\n> -{\n> - return -EINVAL;\n> -}\n> -#endif\n>\n> /* internal API */\n>\n> diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h\n> index 0876aac938d..9d1d3fd3deb 100644\n> --- a/include/system/kvm_int.h\n> +++ b/include/system/kvm_int.h\n> @@ -113,9 +113,7 @@ struct KVMState\n> struct kvm_coalesced_mmio_ring *coalesced_mmio_ring;\n> bool coalesced_flush_in_progress;\n> int vcpu_events;\n> -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG\n> QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints;\n> -#endif\n> int max_nested_state_len;\n> int kvm_shadow_mem;\n> bool kernel_irqchip_allowed;\n> diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c\n> index 6d9140e549f..d4af6b416c3 100644\n> --- a/accel/kvm/kvm-accel-ops.c\n> +++ b/accel/kvm/kvm-accel-ops.c\n> @@ -85,12 +85,10 @@ static bool kvm_cpus_are_resettable(void)\n> return !kvm_enabled() || !kvm_state->guest_state_protected;\n> }\n>\n> -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG\n> static int kvm_update_guest_debug_ops(CPUState *cpu)\n> {\n> return kvm_update_guest_debug(cpu, 0);\n> }\n> -#endif\n>\n> static void kvm_accel_ops_class_init(ObjectClass *oc, const void *data)\n> {\n> @@ -105,13 +103,11 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, const void *data)\n> ops->synchronize_pre_loadvm = kvm_cpu_synchronize_pre_loadvm;\n> ops->handle_interrupt = generic_handle_interrupt;\n>\n> -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG\n> ops->update_guest_debug = kvm_update_guest_debug_ops;\n> ops->supports_guest_debug = kvm_supports_guest_debug;\n> ops->insert_breakpoint = kvm_insert_breakpoint;\n> ops->remove_breakpoint = kvm_remove_breakpoint;\n> ops->remove_all_breakpoints = kvm_remove_all_breakpoints;\n> -#endif\n> }\n>\n> static const TypeInfo kvm_accel_ops_type = {\n> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c\n> index 774499d34f8..9a46a61b7f5 100644\n> --- a/accel/kvm/kvm-all.c\n> +++ b/accel/kvm/kvm-all.c\n> @@ -2919,9 +2919,7 @@ static int kvm_init(AccelState *as, MachineState *ms)\n> s->sigmask_len = 8;\n> accel_blocker_init();\n>\n> -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG\n> QTAILQ_INIT(&s->kvm_sw_breakpoints);\n> -#endif\n> QLIST_INIT(&s->kvm_parked_vcpus);\n> s->fd = qemu_open_old(s->device ?: \"/dev/kvm\", O_RDWR);\n> if (s->fd == -1) {\n> @@ -3032,23 +3030,19 @@ static int kvm_init(AccelState *as, MachineState *ms)\n> kvm_vm_attributes_allowed =\n> (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0);\n>\n> -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG\n> kvm_has_guest_debug =\n> (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0);\n> -#endif\n>\n> kvm_sstep_flags = 0;\n> if (kvm_has_guest_debug) {\n> - kvm_sstep_flags = SSTEP_ENABLE;\n> -\n> -#if defined TARGET_KVM_HAVE_GUEST_DEBUG\n> int guest_debug_flags =\n> kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2);\n>\n> + kvm_sstep_flags = SSTEP_ENABLE;\n> +\n> if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) {\n> kvm_sstep_flags |= SSTEP_NOIRQ;\n> }\n> -#endif\n> }\n>\n> kvm_state = s;\n> @@ -3781,7 +3775,6 @@ bool kvm_arm_supports_user_irq(void)\n> return kvm_check_extension(kvm_state, KVM_CAP_ARM_USER_IRQ);\n> }\n>\n> -#ifdef TARGET_KVM_HAVE_GUEST_DEBUG\n> struct kvm_sw_breakpoint *kvm_find_sw_breakpoint(CPUState *cpu, vaddr pc)\n> {\n> struct kvm_sw_breakpoint *bp;\n> @@ -3941,8 +3934,6 @@ void kvm_remove_all_breakpoints(CPUState *cpu)\n> }\n> }\n>\n> -#endif /* !TARGET_KVM_HAVE_GUEST_DEBUG */\n> -\n> static int kvm_set_signal_mask(CPUState *cpu, const sigset_t *sigset)\n> {\n> KVMState *s = kvm_state;\n> diff --git a/target/mips/kvm.c b/target/mips/kvm.c\n> index a85e162409c..49bff68b137 100644\n> --- a/target/mips/kvm.c\n> +++ b/target/mips/kvm.c\n> @@ -1262,6 +1262,11 @@ int kvm_arch_msi_data_to_gsi(uint32_t data)\n> abort();\n> }\n>\n> +int kvm_update_guest_debug(CPUState *cpu, unsigned long reinject_trap)\n> +{\n> + return -EINVAL;\n> +}\n> +\n> int kvm_arch_get_default_type(MachineState *machine)\n> {\n> #if defined(KVM_CAP_MIPS_VZ)\n> --\n> 2.53.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=EaEhwuj7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmNVr2Wgxz1yGH\n\tfor ; Thu, 02 Apr 2026 11:47:48 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w86DE-0001wy-AD; Wed, 01 Apr 2026 20:47:08 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w86Cf-0001dZ-C4\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 20:46:40 -0400","from mail-ed1-x536.google.com ([2a00:1450:4864:20::536])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w86Ca-0002OT-AG\n for qemu-devel@nongnu.org; Wed, 01 Apr 2026 20:46:31 -0400","by mail-ed1-x536.google.com with SMTP id\n 4fb4d7f45d1cf-66dd27d4465so695588a12.3\n for ; Wed, 01 Apr 2026 17:46:27 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1775090787; cv=none;\n d=google.com; s=arc-20240605;\n b=UQb/A194Hz83ITi35da94skuZM5tW/xkYmrpB/mmgWwLdH5JqarHLEKw2ri4CZ9mou\n epsD7desd4HduhLaFeZMDpoStR2DXx0w+y7JBSOhdwnfcbpAdJ3+Ab25TACDSBfGLS4J\n SuItxvWeHM8m8hxukcymsP0uWmWAG5YkCFTZUjVTQvNq8du2Afexsx1OYbpfhlq6bmzq\n /oIM8aen8aSYdJVthXU1AssMWf0gw8VfyWJEq8I8oJMpXk1fSh/dOfzThiZl3Ha33Upo\n E+xADOXBTPLd8LsShPHupckw3npnl6H5yv3dB2LaxO086LkJ1111iiQ5APSsv2bHmnIC\n uHbw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=w7ZjIP4wxwkHbCGk+xqfZg9Y+KuPrsg39riRIKt2IvY=;\n fh=3pe5Mh1z3Fra4qA4Id4JnrrXRQUGebEqwUNjROC+Yjg=;\n b=AsVw0LS/WFUUwxoi9Gd3oAgNbNXjENioOYr6ZF2Ks9P0Ptx9rlCDsEmv9P0l97DuSW\n 0vW8dS4ZM2+SA3G88sKU2ybkVa96pfqufTuPB8b+ItiYfg5uDunX0ZqJr2IQyqLYcWUF\n Pqu+Qz5R4IdkjQdEDGtQiuFsB2OahSK2PJqggnabijV4NU+jzvW88KFjRLRZjmdNViXv\n 6pr1PCSDOs7naUM07DktDEvdniRIF0eyc6eGHxnxOxD5jv7+in/X50WpPMRdIbOLtE50\n lDgxeOLUBw+xG7VlkVj8R4nO8KwYNHMMmKazQdtpWrrS9ci4RbSGD2VGgJKHz0XxH6HX\n +54Q==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775090787; x=1775695587; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=w7ZjIP4wxwkHbCGk+xqfZg9Y+KuPrsg39riRIKt2IvY=;\n b=EaEhwuj7kaC7KQjPATkWD4EqJ5AT8tgziTQJO/aZnmnZ9iVOBLiRd78uHypfAJ6dnX\n JESvVwtDOn2EA5rdWE4PyhiOIoP5KyLhJMhRkq9H3myunvVAZp6e5nL9KFGKlERPme5R\n AfCOpcqa+IsIg4lW8mtRV+zhByEIiO6IKzI59VNn9ZHvei5Yy923EkKqRwNRvTppgDtd\n BmrZC+a+5Si/O+3JCbAfAaHWVHUkpMWbC3fPa44oDeXZbHopD9IIf3DHJ4NruUNM3yV+\n wPHCgLXeF2C0jOgJuZvO117v8ncpcqyJytlENRVzaeelmq5xnYxTybTYtLHMAjckOouI\n oZ+g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775090787; x=1775695587;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=w7ZjIP4wxwkHbCGk+xqfZg9Y+KuPrsg39riRIKt2IvY=;\n b=NRk29kHnrRTStt32OEbmglvFq8ADc3jy494iLF9ldw/I1ff3HOVJW1W41zxoqsCoIR\n RdjO4VGDrMIWIh9/nu0EplG/XCO6uwDuyWw+YYsri27hE3CFH0tZDFRJI20MpVOhACEm\n vlZyNsoAH9wDXqDy0XDp5SfS6fQnxkEu4ecsM+HUxA1IC60D14snfl+r6U7oUWCdDrCM\n xJ/11W2TYued2Gt7um+oYDrISgp8aWge/6TJ6b9X/AyDN+BSjo1qLF97+Qd8UWuxSUfC\n fd+raiK0iOjUBxnCuuOdD0UpTWDOlDnYLGhkeG86Ipd7ljwI0jbrNXvuDla6vZ1PA2G/\n VNZA==","X-Gm-Message-State":"AOJu0YyFUuwnOdwVSR1BuqPY4lfRpvYgas4pZTedQgTMOxvBeqrc76OC\n UuWJGQAD9OXxqUUjiWIrhpRzJ/b8vko+AAkLexbAm1KuD16ArPUWmFBPqW6cIGjVi+33flCVw0S\n iBR6mJaf5XamAq++cKLR7+W3BjHKvXCM=","X-Gm-Gg":"ATEYQzxMxmYvBZ+8kGCDaxGYL5xwDhq31zm3vJrMtRLpxB+zzoNtTV+r/kr24VtgkyH\n eQP9+eEYuxnnz+32f+7E09qdiTBzv5o6D05jHyGRwvo6PSVby05j+H4l4VuZwwDCfbxJ+VCKv84\n tk/DAGa3R3JYIv1qGqQs0vyM9rn9Hu0p4dY/t2X/DlR37xbTJN4dOg12jZZG25XoFYQgc0t+emk\n RbWlphRpCB2bOJxInja+tvn2n+34GDK7zNTSsz28OszO+OcYMKNEL6NiiD7qF8Q1folRrg55LBe\n sza5VLvELJ5EP9siFxrj1rjRkE3tgXK0Xd1bGQ==","X-Received":"by 2002:a17:907:a604:b0:b93:6ae4:aa83 with SMTP id\n a640c23a62f3a-b9c138e7d94mr384586866b.18.1775090786132; Wed, 01 Apr 2026\n 17:46:26 -0700 (PDT)","MIME-Version":"1.0","References":"<20260401201753.92290-1-philmd@linaro.org>\n <20260401201753.92290-3-philmd@linaro.org>","In-Reply-To":"<20260401201753.92290-3-philmd@linaro.org>","From":"Alistair Francis ","Date":"Thu, 2 Apr 2026 10:45:59 +1000","X-Gm-Features":"AQROBzCwwUU-hZsY0U89IfFUHeLh_to88ntKSLA14V2dIF2bIKjclWYrKDf2AmQ","Message-ID":"\n ","Subject":"Re: [PATCH-for-11.1 2/8] accel/kvm: Remove\n TARGET_KVM_HAVE_GUEST_DEBUG","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Cc":"qemu-devel@nongnu.org, Eric Farman ,\n Alistair Francis ,\n Palmer Dabbelt ,\n Paolo Bonzini , Matthew Rosato ,\n Daniel Henrique Barboza ,\n Pierrick Bouvier , kvm@vger.kernel.org,\n Peter Maydell ,\n Huacai Chen ,\n qemu-riscv@nongnu.org,\n Alexander Graf , Pedro Barbuda ,\n Anton Johansson ,\n Song Gao , Weiwei Li ,\n Aleksandar Rikalo ,\n Liu Zhiwei ,\n Cornelia Huck , qemu-s390x@nongnu.org,\n Chao Liu , Bibo Mao ,\n qemu-arm@nongnu.org, Jiaxun Yang ,\n Mohamed Mediouni ,\n Zhao Liu , Aurelien Jarno ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2a00:1450:4864:20::536;\n envelope-from=alistair23@gmail.com; helo=mail-ed1-x536.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3673318,"web_url":"http://patchwork.ozlabs.org/comment/3673318/","msgid":"","list_archive_url":null,"date":"2026-04-03T21:25:58","subject":"Re: [PATCH-for-11.1 2/8] accel/kvm: Remove\n TARGET_KVM_HAVE_GUEST_DEBUG","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 06:17, Philippe Mathieu-Daudé wrote:\n> All targets except MIPS have TARGET_KVM_HAVE_GUEST_DEBUG=y.\n> Declare the kvm_update_guest_debug() stub to MIPS and have\n> TARGET_KVM_HAVE_GUEST_DEBUG be the default.\n> \n> Signed-off-by: Philippe Mathieu-Daudé\n> ---\n> configs/targets/aarch64-softmmu.mak | 1 -\n> configs/targets/i386-softmmu.mak | 1 -\n> configs/targets/loongarch64-softmmu.mak | 1 -\n> configs/targets/ppc-softmmu.mak | 1 -\n> configs/targets/ppc64-softmmu.mak | 1 -\n> configs/targets/riscv64-softmmu.mak | 1 -\n> configs/targets/s390x-softmmu.mak | 1 -\n> configs/targets/x86_64-softmmu.mak | 1 -\n> include/system/kvm.h | 7 -------\n> include/system/kvm_int.h | 2 --\n> accel/kvm/kvm-accel-ops.c | 4 ----\n> accel/kvm/kvm-all.c | 13 ++-----------\n> target/mips/kvm.c | 5 +++++\n> 13 files changed, 7 insertions(+), 32 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=JSglxi4i;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnWxS19FPz1xtJ\n\tfor ; Sat, 04 Apr 2026 08:26:20 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8m1p-000106-FA; Fri, 03 Apr 2026 17:26:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8m1m-0000lq-EM\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:26:06 -0400","from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8m1k-0004Ls-VH\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:26:06 -0400","by mail-pl1-x631.google.com with SMTP id\n d9443c01a7336-2b24fdac394so22014725ad.3\n for ; Fri, 03 Apr 2026 14:26:04 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b27475ff56sm65084735ad.22.2026.04.03.14.26.00\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:26:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775251563; x=1775856363; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=kXVDAFigxpqAMaZ5AsV5mEiXkzVO5VRcIlBzElJ9mQs=;\n b=JSglxi4iQ+GPKAjctgOshkU6UzpXm1OVWjhm+YEc1YP5bCrmRtYaGEPWXUIUlHxtbm\n Ii0Vu9YjmVBE/DbPEpMaRf7NuMx5LufOBXldGAxokFVLxBm/a3sEsWmxStS0JU7Wy4OH\n Ukjvj6KuKfbEHaR817rF1SpiOTAk8DusuBBfBfK7aV2cCHS4ID2sK/qP3iGBr7n5wbtG\n iWKioW9rHcZ2r42+IAprGHPhmpmeEJnz1h13+nrPxo6E4iZ5H9EII17WpDEabKYalA/T\n sGVifiUTgu2Au/JmmpLhuI1smm8PAILXUg+dwbr3vbivWHfqNyBTu6DkRgwMsDCFSfZ4\n 4gyQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775251563; x=1775856363;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=kXVDAFigxpqAMaZ5AsV5mEiXkzVO5VRcIlBzElJ9mQs=;\n b=A+cfI9R/Z3TeGtZkO3oW3ZHwnKDyt7krJHd4hgn/Kx3VfmhjRL00GtyFaTSMukFn04\n PiKuc95DZaikbC/gwp6DHp10kjGtOYSTj2Qq/gEgtY6VLcReJQTh36AenBhqCC5EFSCR\n QAlNXAzmk4Wnvx6ZMJT/tVLHJhPCjmYDHIF/9sJVuvoownD1IU0NDmS+PYi1itQDATgf\n RD+jcwg71RcUbC7w+rVazwjwUk9jETGaa2ImwTiwwxIXCttwxrPeM4ZnJFAKU0xfAG8P\n hndvI30RV3vdXZHvCcTKfOSPt+hD1LgdkskBjKCncmWj5+/IbJj56g3YRN6HBBvTePis\n q1yQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXt5Qu4qyaIZ2ArVRLPVa7sfnWk1YMQv7BjxsiBrSDEfRkzev3HSt7gBirYwzh7VC0ZdxKJuDSa4R3E@nongnu.org","X-Gm-Message-State":"AOJu0Yx7iOQ00URk0KZ2mvTzdalZcv369X6/0Z2Pougi/oPFzajAzUG5\n WgGF+7yRNXh6jekwMknSiFClVkvAM+HXxuJRjUXL1U5QsmDtPGLKwkPVEor9wmI/QnU=","X-Gm-Gg":"AeBDievHveMHul9jK4t8BlczL5pyjKRqNLdukKegM+ncjLvGuBdIXfxCMAvR7uSStHY\n Hxpn9ZEHcr21y7NM0LHGEwdAlw13t6/LaPc+ZDjYt42Q2nkRALrUUl2lUm0Iu+f4BSy3nnkIy/X\n voYhDS3lDi3uH4C70HJqTovwhwJdWlG7NSxm/Gwkk3+V3/3aivUqqSDRtUoXL9AlW48Ddwqut/I\n NAxECT9TNFC4/+nfkQg/xgYfsF1FtSw2xtS1BjkAIGmH2yHnQRIS/rFP+VRDH6HEI1cCy1sYaKa\n rv3sViKHxcNWJddYOqwWTtTNJPgf/RrP1NJOsK5B8Dgdp5SFSCm1m1Eoe3ThbQXMxyVXv0Eu8Wv\n ukj6I5P7aaKPpYHL3DZDdXQ0vK3c6rHkUSCZ43CADcxVOg2QsRTcS42kxpngG4pnrFfSrZ5teH9\n oIDtqUro9qwml4e22M1NObVgUohlje3qbfCYV2K9N6xQgAuP2hNNBTQ8QIiHzw3JmH1wq4gdkJ2\n KTHZQ==","X-Received":"by 2002:a17:903:3586:b0:2b0:b325:748a with SMTP id\n d9443c01a7336-2b281705e9fmr46641625ad.22.1775251562960;\n Fri, 03 Apr 2026 14:26:02 -0700 (PDT)","Message-ID":"","Date":"Sat, 4 Apr 2026 07:25:58 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH-for-11.1 2/8] accel/kvm: Remove\n TARGET_KVM_HAVE_GUEST_DEBUG","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","References":"<20260401201753.92290-1-philmd@linaro.org>\n <20260401201753.92290-3-philmd@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260401201753.92290-3-philmd@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::631;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]