[{"id":3673316,"web_url":"http://patchwork.ozlabs.org/comment/3673316/","msgid":"<0f441ddb-d2b2-4095-b0ce-c35090133366@linaro.org>","list_archive_url":null,"date":"2026-04-03T21:20:53","subject":"Re: [PATCH v6 10/12] target/arm/tcg/gengvec.c: make compilation unit\n common","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 05:20, Pierrick Bouvier wrote:\n> Signed-off-by: Pierrick Bouvier \n> ---\n> target/arm/tcg/meson.build | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build\n> index 1fa26670587..0740de92c1a 100644\n> --- a/target/arm/tcg/meson.build\n> +++ b/target/arm/tcg/meson.build\n> @@ -33,7 +33,6 @@ arm_ss.add(when: 'TARGET_AARCH64', if_false: files('stubs32.c'))\n> \n> arm_ss.add(files(\n> 'cpu32.c',\n> - 'gengvec.c',\n> 'translate.c',\n> 'm_helper.c',\n> 'mve_helper.c',\n> @@ -72,6 +71,7 @@ arm_common_system_ss.add(\n> 'cpregs-at.c',\n> 'debug.c',\n> 'hflags.c',\n> + 'gengvec.c',\n> 'neon_helper.c',\n> 'op_helper.c',\n> 'psci.c',\n> @@ -91,6 +91,7 @@ arm_user_ss.add(\n> vfp_d,\n> files(\n> 'debug.c',\n> + 'gengvec.c',\n> 'hflags.c',\n> 'neon_helper.c',\n> 'op_helper.c',\n\nReviewed-by: Richard Henderson \n\nWith slightly more work, this one could really be compiled once, via arm_common_ss. We'd \nneed to split out the function declarations from translate.h though, because there are \nother CONFIG_USER_ONLY uses in there.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=war1I2ZF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnWqz22v4z1yD3\n\tfor ; Sat, 04 Apr 2026 08:21:35 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8lww-0006qm-Ot; Fri, 03 Apr 2026 17:21:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8lwu-0006j0-Dw\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:21:04 -0400","from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8lws-0003wr-Ty\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:21:04 -0400","by mail-pl1-x630.google.com with SMTP id\n d9443c01a7336-2b23fcf90b2so21205125ad.3\n for ; Fri, 03 Apr 2026 14:21:02 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2747530e4sm68066785ad.18.2026.04.03.14.20.57\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:21:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775251261; x=1775856061; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=FKQOiu8uzFuxHT2NoyVPUR27Zi5sXrhv/B5Geiv3d5M=;\n b=war1I2ZFEuR7Yz+z7XWHBGko+g+y6dFy2JXTgg0AGakKZGaqC6jjCKuWDJEJy9hj48\n RgUyRtgnnrRyM2DSaVKEplC3s6dU6lpwnQ0DI4O1YPfC8dewYSFVPbiUaPPgLrFd4SIL\n V3fBvII3JiJXgemjzyUdPKejw96QyvtXRg35sPPXJ/DKwbrojaA+Il2R9h0p9qJSqmzg\n SFaV2EEAhOX/01m0UmgEhbm38Rj8OX1m5pekP0YRCSpgMMHEPDbz1Z3nbHp66HFGHSug\n OO139NKWC/Ugc7Ruo54udxxCtUBlKCnNDKPTjJkdH3fH3vKW72cvS2Qiv/DEL7pd3wLW\n SwRg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775251261; x=1775856061;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=FKQOiu8uzFuxHT2NoyVPUR27Zi5sXrhv/B5Geiv3d5M=;\n b=aB2qDxQwn2pPzy+tb+nAwqwBb1HBljrC5yrS3lfH0Z8jhMsBJNN4pX9JLwfGQ+edqz\n uiM6Sf1feT323163VxSPE4eO7Yp9M5W2S8bZT3UyN6cq+jBYzgeKXRWuqHga4G+AorY+\n xhw24efrp6rEJRx8XausGcsuSgLKusUJRuoeO6Wa3uRrd4/Y2Y293eBqtgfqs3rcx3Vu\n QMbQvsMztmcJLrh7D5zGw+pRG7tABaDK8TYok591BbiIk5TJDerRpCG7wky/klWuKL7Q\n OIIlToffcYZnm+VBdp55VAsX6MIKJ7Zn0nLWHK8mzXU8owIqCXkpah7wKiiRyMmOHxrL\n UD1w==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXZYVLSyZvWHfobZABbmgVE4VzyTw1O6gtswgRLr+eTm7MYJKAxeoj9oT6QCQNDfBCDgi7JDYQYTy3/@nongnu.org","X-Gm-Message-State":"AOJu0Yy69S2QbSTEoX5YjvZx1ggCxj7O47nsZokZPxZVKfqDevO5wCzL\n RDS3hxerJU0XfxHgryVRQAmLjqdKAzChDclC8roCZThZf/oGTtZna2gCy9+OA5lM1oihYIF8wV5\n VLkxaHtw=","X-Gm-Gg":"AeBDieumQz4Fdg/qQ/v2bQEwncs7uRqvlmWwFh1Rt0VwfSX/LrSUDyrO7+XnD2owouK\n LppznvMEuVhe7iXf/oWDF132+wFPlzalzxxsWTgc5eg8cWSVABF2XXkoJiIvo1UOJqIICMIdbjj\n Gnsujo/sLdEvcuiVolvDp/NegeR4DcnVqiOxwWNXQ07k30msHZxZ4ok4+osVJobQRa+8OcMrkhR\n fmxdInpzLuk86WDmSbv2rwNULNveAcZIYEuAC+yvXr/2vAuOGQGmXDk4aIOzmXt7FlGROJWGWyM\n wdYm1jF1LFVr2mvN81tl9e60r6A6pvnOeY90N2YtHlsWpyyZNohmYxdZspD7gg2R4h4W2wgdTLg\n jWsxRL+vQFtlMaQZGW9uoDmfW+rhWyb7b8QSKhe2uC+K0TX8wjbG+iQAxXskpAbplMcT1iG+l5L\n G24kIK2Xk997Kadvrbuiqt9yU2FXn3JuFHxDGSWqarlGzlIHv/Lw7JojvXPYYWph8KbF0=","X-Received":"by 2002:a17:903:1a28:b0:2b0:c90f:44b2 with SMTP id\n d9443c01a7336-2b28173548amr46198715ad.12.1775251261115;\n Fri, 03 Apr 2026 14:21:01 -0700 (PDT)","Message-ID":"<0f441ddb-d2b2-4095-b0ce-c35090133366@linaro.org>","Date":"Sat, 4 Apr 2026 07:20:53 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v6 10/12] target/arm/tcg/gengvec.c: make compilation unit\n common","To":"Pierrick Bouvier , qemu-devel@nongnu.org","Cc":"Peter Maydell , qemu-arm@nongnu.org,\n jim.macarthur@linaro.org, philmd@linaro.org,\n Paolo Bonzini ","References":"<20260401192057.1182724-1-pierrick.bouvier@linaro.org>\n <20260401192057.1182724-11-pierrick.bouvier@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260401192057.1182724-11-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::630;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]