[{"id":3673309,"web_url":"http://patchwork.ozlabs.org/comment/3673309/","msgid":"<27c6d754-9139-4758-b92c-af3302a2d425@linaro.org>","list_archive_url":null,"date":"2026-04-03T21:08:18","subject":"Re: [PATCH v6 06/12] target/arm/tcg/translate-neon.c: make\n compilation unit common","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 05:20, Pierrick Bouvier wrote:\n> Signed-off-by: Pierrick Bouvier \n> ---\n> target/arm/tcg/meson.build | 10 ++++++++--\n> 1 file changed, 8 insertions(+), 2 deletions(-)\n\nReviewed-by: Richard Henderson \n\n\nr~\n\n> \n> diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build\n> index 5f33ecd76e0..8d9112f6da2 100644\n> --- a/target/arm/tcg/meson.build\n> +++ b/target/arm/tcg/meson.build\n> @@ -10,10 +10,13 @@ vfp_d = [\n> decodetree.process('vfp-uncond.decode', extra_args: '--decode=disas_vfp_uncond'),\n> ]\n> \n> -gen_a32 = [\n> +neon_d = [\n> decodetree.process('neon-shared.decode', extra_args: '--decode=disas_neon_shared'),\n> decodetree.process('neon-dp.decode', extra_args: '--decode=disas_neon_dp'),\n> decodetree.process('neon-ls.decode', extra_args: '--decode=disas_neon_ls'),\n> +]\n> +\n> +gen_a32 = [\n> decodetree.process('m-nocp.decode', extra_args: '--decode=disas_m_nocp'),\n> decodetree.process('mve.decode', extra_args: '--decode=disas_mve'),\n> decodetree.process('a32.decode', extra_args: '--static-decode=disas_a32'),\n> @@ -32,7 +35,6 @@ arm_ss.add(files(\n> 'translate.c',\n> 'translate-m-nocp.c',\n> 'translate-mve.c',\n> - 'translate-neon.c',\n> 'm_helper.c',\n> 'mve_helper.c',\n> 'op_helper.c',\n> @@ -63,6 +65,7 @@ arm_common_ss.add(files(\n> ))\n> \n> arm_common_system_ss.add(\n> + neon_d,\n> vfp_d,\n> files(\n> 'cpregs-at.c',\n> @@ -72,17 +75,20 @@ arm_common_system_ss.add(\n> 'psci.c',\n> 'tlb_helper.c',\n> 'tlb-insns.c',\n> + 'translate-neon.c',\n> 'translate-vfp.c',\n> 'vec_helper.c',\n> 'vfp_helper.c',\n> ))\n> arm_user_ss.add(\n> + neon_d,\n> vfp_d,\n> files(\n> 'debug.c',\n> 'hflags.c',\n> 'neon_helper.c',\n> 'tlb_helper.c',\n> + 'translate-neon.c',\n> 'translate-vfp.c',\n> 'vec_helper.c',\n> 'vfp_helper.c',","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=CGxtjsQZ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnWYg2FJSz1yD3\n\tfor ; Sat, 04 Apr 2026 08:09:11 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8lkp-0001nT-4f; Fri, 03 Apr 2026 17:08:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8lkm-0001mS-TD\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:08:32 -0400","from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8lki-0002fE-SD\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 17:08:30 -0400","by mail-pj1-x102e.google.com with SMTP id\n 98e67ed59e1d1-35d9c7bf9a1so1908701a91.3\n for ; Fri, 03 Apr 2026 14:08:27 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35dd367bfbcsm6285829a91.12.2026.04.03.14.08.21\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 14:08:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775250506; x=1775855306; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=jttZ3IIBfWqIL7L8dJ+GaVUkqKW41vKE1ZXRoz/4S9w=;\n b=CGxtjsQZrJhn/Cf2/lp61D5gao1RmnvzeSVZ5ni8Zp5ArfxwQWgkcVu7q/CsfYY13G\n eJYRkRAXvsVDJFp9KN2UrIYjz3eKJuTNst/xA3iiuwH8keYxskAOebrkOQJrCCpZIT1j\n 0tl89lCwYt909O6wWKV1RlMyMahEYUmlCzhg7uqkg+o7YeGXI1abMEAUYi4CLmSn+qGb\n XxXkssvJ0ves/Un0e/9c2X5NQU0GwnITbOXQQ2AUwaI2EG3mFdCQWzPRpFwGBjhZUMmL\n WnExqRIfK2Lai7G71u+Bai7VBtKluuf5g8OQD3zF4lawlRMwM17wDcFodzZ8E5GlI+wD\n L2pQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775250506; x=1775855306;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=jttZ3IIBfWqIL7L8dJ+GaVUkqKW41vKE1ZXRoz/4S9w=;\n b=O+bqGInFrq6j4V4DfdSQOfBXtOWmoqihx1sTwDpg2Mz4CPlv+UmNsbgSpdXO8RsVNn\n AQOcSfmxX3WMx8gF6tiZfDhPea+WvCo9DdNQntt+ymRana5/CT2K0JbtcslSA9Na4pNX\n 5BNDn5ajSDb/y71Uca+Luai5Y5WyWd9veg8fjJxVR7RSXi7QhJ1DtnM6ZoRT0XIcsiYB\n nFPH7yNGg6PJFHhgFTUo3h917oiio1kNYSYIogcrKiOH5oxeuA27XB+sb8Ss9LXB2VKT\n 7o4Fl4uQmdLjfZrp8x3xHtRtVsF0HHZqsdmWhXVAySJjPcIWGGTlLDNNXMF9wCYEUz7t\n D/Aw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVdJyl/DKlS8VMY3JdhO/Vf1xIPNzh2mW54vrE0iOZdXNmYZgqYEKdOIrVxU+vCzHMYKYAm5TRKMbGd@nongnu.org","X-Gm-Message-State":"AOJu0YygL9fK/6W9oSX1uCkJbgKkxp6P5qG3tnhZU6qkOz2Pi7fqWF0B\n vu/7LgD2GslshQF7ByP5mqwOIWtRC2+fG6gkuoPFGkcWOxfGl2TzNqRJJ4+5+ptHKa4=","X-Gm-Gg":"AeBDieuYQIfia9ebl1gL9mCfvDSIJD/7XCPYKYzfGaKmhjw+jRxVJy4H11z3QNIdtri\n SNG5J5ponXEeS3XdTIH5Qqs43PJIu7dMoMKnAxoRfF0cBM0IL/pg6nrVKV93iWvEg1/aJZ0DK5a\n eVOdzyOMpBKQC8C5a2cqgDgfFaFA0vdfti768gIx+GURvI/5/ylK8uRXpFmghv69w0IAGPimegS\n 5Fu7Yy2GMjpeQw7Hv+E/nCaM7R5RRihuXpV6XRpQMYjneskUGXcggqqAMfRWCChiNsRl7E5vv/R\n jntofPXYkgkPeCSEE+FXw9Cbbhds2j0qrdEDYyt3c7kVxobWet2T0z1r90EXh+aW4H28hwAjEcn\n 79I/K0AE73m5zxU6DceBl+xdsoqjEW6Rvqp1E3QcvMCqEzXF7a3B3NuSJG3NKLPWJeoQ+Oy/azO\n 6eQmDDlfWcDLlx7J8XyD0h70IZR+CEuF9r8mWfKT/foTDGeydDi2XG7ODMtXxeQ56F82w=","X-Received":"by 2002:a17:90b:314d:b0:359:f43d:4a6e with SMTP id\n 98e67ed59e1d1-35de662f67fmr4064794a91.0.1775250506065;\n Fri, 03 Apr 2026 14:08:26 -0700 (PDT)","Message-ID":"<27c6d754-9139-4758-b92c-af3302a2d425@linaro.org>","Date":"Sat, 4 Apr 2026 07:08:18 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v6 06/12] target/arm/tcg/translate-neon.c: make\n compilation unit common","To":"Pierrick Bouvier , qemu-devel@nongnu.org","Cc":"Peter Maydell , qemu-arm@nongnu.org,\n jim.macarthur@linaro.org, philmd@linaro.org,\n Paolo Bonzini ","References":"<20260401192057.1182724-1-pierrick.bouvier@linaro.org>\n <20260401192057.1182724-7-pierrick.bouvier@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260401192057.1182724-7-pierrick.bouvier@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102e;\n envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]