[{"id":3673354,"web_url":"http://patchwork.ozlabs.org/comment/3673354/","msgid":"<5a6f0a78-85aa-4d80-9dc2-4a58100bf6ba@linaro.org>","list_archive_url":null,"date":"2026-04-04T00:49:12","subject":"Re: [RFC PATCH 1/4] alpha: Define Typhoon instance_init","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 4/2/26 03:04, Yodel Eldar wrote:\n> From: Yodel Eldar \n> \n> Signed-off-by: Yodel Eldar \n> ---\n> hw/alpha/alpha_sys.h | 4 +++-\n> hw/alpha/dp264.c | 8 +++++++-\n> hw/alpha/typhoon.c | 24 ++++++++++++------------\n> 3 files changed, 22 insertions(+), 14 deletions(-)\n\nThis is doing more than one thing.\n\nThe subject says adding typhoon_pcihost_instance_init, but that would just be moving two \nlines out of typhoon_init.\n\nCreating the typhoon object in clipper_init is a different change, and I don't see how \nthat's even helpful at this stage, since typhoon_obj is not used in clipper_init.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=IClaUCcG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fncSv6BQCz1yD3\n\tfor ; Sat, 04 Apr 2026 11:50:22 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w8pCe-0005It-0b; Fri, 03 Apr 2026 20:49:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w8pCU-0005Ah-RL\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 20:49:24 -0400","from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w8pCS-0002NK-Hx\n for qemu-devel@nongnu.org; Fri, 03 Apr 2026 20:49:21 -0400","by mail-pl1-x630.google.com with SMTP id\n d9443c01a7336-2aaf43014d0so16332845ad.2\n for ; Fri, 03 Apr 2026 17:49:20 -0700 (PDT)","from [192.168.1.105] (124-150-69-109.tpgi.com.au. [124.150.69.109])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b27478b658sm73420175ad.31.2026.04.03.17.49.16\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 03 Apr 2026 17:49:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775263759; x=1775868559; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=EbJI6zW/sRL1mS2mAsDa4rvCIFEIK142ElrJa537/58=;\n b=IClaUCcGg17Ng6YLnyvtm04flxflELGcBTkB45VApT5njYvM8Is+T0/f4aTHEHHywA\n 2ICx19G1OdSfpjcaAz+ijslj7SAYsdRh69C7rnnv6PqYpdq38seLoM/VaCL3zuQI0wGu\n nO7PVn1ylztrltVSeYg+XQSpTZc7H9myWt8XPY+GTACpyEx1EjmRLlks1u5uRx88eAv5\n 1NzLLppBaLAUxt8qiW3Qo1dofjSzXKAliad2tOwz0WfAna0Uk5jgPYacxmw5NFm8w2sT\n BYmIH5H9JMJz06Z1YIr7dxW3iFEKok+Xg/C24LvkQnFEdA0iXIbuY9Kwu9yFelOPkZU5\n WQ7Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775263759; x=1775868559;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=EbJI6zW/sRL1mS2mAsDa4rvCIFEIK142ElrJa537/58=;\n b=a5vCI1MLn2Ck7DEu9gUHW14aw96GSY967gjvIwMnJ4zy1WsV7YmYjHOFgudwywv+c5\n cBhWzne9QZoDIW7ocdxx4zpdb0EyI7M70Il2X65/I5Jr7QNeaLNkTtpZG/ODzdnnANvR\n kS9ANwWpVsQ2SVvpkyZOJtUBWbb4tbXjLPuhsDP5LNKbRkt8/v3ia3ZEuf/e3AbhnLLv\n KnqwOvlDjzjZ9TUHCs3ICxUsGVhl08nibAMoQ8IzXvwNkpNab5Z3bwcWrxtjRQsrjs8W\n PA7Np+UQruPhbkwa6b/kiwlV3meETZR6fH58IPYGLAyaX3s/FhHZazAPgGbHSpDN9kM4\n 2H/A==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWbw/+HjPkynei60pd5EkvQt6MbDBbzSlwBaTaZSWqGkrCxGzNU98yZJs1S0KoG72fMeXUAybsedHU+@nongnu.org","X-Gm-Message-State":"AOJu0YwEwtDWQlwgE02ZmlrSo71Vuqm4lWW40p96PSHAQY4dnlLglXKP\n qBp4pIxD7HcTUN4YpDTrqk0vlaGxlrbp0xW0jg47RxWn5BZMU0Jl7N3QQiR8byvcEYSBMn3OU10\n 6NozxHQA=","X-Gm-Gg":"AeBDietLKzujsbxYHY3BxxKWc0ZWk9gvl9l7xUhFludKtkHnP0bh+nYfvkiUXqnbXnz\n nGFg9m7l64UvksM5sPPtioijRsThuyXkbMPcEK3rZojdYv93eEvIfA/xdmSkCRBAC5KEZhQzR+e\n 3Rm/XvZ1st8g/CVzhUhxBu4utA9GNjX4ChRWfouhIAQ/+CBfcKHgEGPeHcFDfhd+XwzOtkA25Kx\n DMsVWmYR4osQhlItq0VPIRBYiwZCNNf0LLw8p55zYGmTix7bI4FvSgDfeGdNMM7kdPL0ljyiEul\n pPMC5zetzgb72he2D4Cz9MXPtxcQ4upkAXE4Zn68g/LE3PYSxlBa/b+7eRkCcAJP3Bj3KReNCLO\n ItlsaJ3X1Uok/OE0aYp4wGykZvUX80/bnggCWJcUAKKyZ8grAWNOEbSfyHEHlRK/A4qVI+pTaE1\n XceaAsMyEdlVd16TZ8hdU/KHBx9RG8IT5Z4571ywf/Tjfl1GgZQKBXiuHWaF2xEQGPJ20=","X-Received":"by 2002:a17:903:287:b0:2b0:c2d9:270a with SMTP id\n d9443c01a7336-2b28198d6e9mr44702315ad.42.1775263758846;\n Fri, 03 Apr 2026 17:49:18 -0700 (PDT)","Message-ID":"<5a6f0a78-85aa-4d80-9dc2-4a58100bf6ba@linaro.org>","Date":"Sat, 4 Apr 2026 10:49:12 +1000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH 1/4] alpha: Define Typhoon instance_init","To":"Yodel Eldar , qemu-devel@nongnu.org","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","References":"<20260401170454.32045-1-yodel.eldar@yodel.dev>\n <20260401170454.32045-2-yodel.eldar@yodel.dev>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260401170454.32045-2-yodel.eldar@yodel.dev>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::630;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3673517,"web_url":"http://patchwork.ozlabs.org/comment/3673517/","msgid":"<35f17ce2-b272-4494-8c22-2449d4f4915a@yodel.dev>","list_archive_url":null,"date":"2026-04-04T23:39:59","subject":"Re: [RFC PATCH 1/4] alpha: Define Typhoon instance_init","submitter":{"id":92094,"url":"http://patchwork.ozlabs.org/api/people/92094/","name":"Yodel Eldar","email":"yodel.eldar@yodel.dev"},"content":"On 03/04/2026 19:49, Richard Henderson wrote:\n> On 4/2/26 03:04, Yodel Eldar wrote:\n>> From: Yodel Eldar \n>>\n>> Signed-off-by: Yodel Eldar \n>> ---\n>>   hw/alpha/alpha_sys.h |  4 +++-\n>>   hw/alpha/dp264.c     |  8 +++++++-\n>>   hw/alpha/typhoon.c   | 24 ++++++++++++------------\n>>   3 files changed, 22 insertions(+), 14 deletions(-)\n> \n> This is doing more than one thing.\n> \n> The subject says adding typhoon_pcihost_instance_init, but that would \n> just be moving two lines out of typhoon_init.\n> \n> Creating the typhoon object in clipper_init is a different change, and I \n> don't see how that's even helpful at this stage, since typhoon_obj is \n> not used in clipper_init.\n> \n\nLike Patch 3, I'll split this one, too. Thanks for being specific.\n\nYodel\n\n> \n> r~\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=yodel.dev header.i=@yodel.dev header.a=rsa-sha256\n header.s=rsa2048 header.b=dhGmCPw6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fpBsq2XFxz1yD3\n\tfor ; Sun, 05 Apr 2026 09:40:31 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w9AbC-0007vd-E7; Sat, 04 Apr 2026 19:40:22 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1)\n (envelope-from )\n id 1w9Aax-0007sq-HW\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 19:40:04 -0400","from v512.v5f06b487.use4.send.mailgun.net ([143.55.232.12])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1)\n (envelope-from )\n id 1w9Aav-0006rV-Ds\n for qemu-devel@nongnu.org; Sat, 04 Apr 2026 19:40:03 -0400","from mail.yodel.dev (mail.yodel.dev [35.209.39.246]) by\n bebc2439ec4f843644186b9355f35484e7904f3d978673e03be1b5b227237dd4 with SMTP id\n 69d1a150bf9bc69edef14cff; Sat, 04 Apr 2026 23:40:00 GMT"],"X-Mailgun-Sid":"WyI4ZDFlNiIsInFlbXUtZGV2ZWxAbm9uZ251Lm9yZyIsIjk3NjA3ZSJd","X-Mailgun-Sending-Ip":"143.55.232.12","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yodel.dev;\n s=rsa2048; t=1775346000;\n bh=zKmyzkDumFXb1FqaGxbqMN+gUzc97lAfvmhJPxhVVEo=;\n h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:\n X-Mailgun-Dkim:From:In-Reply-To:Content-Type:\n Content-Transfer-Encoding:From:Reply-to:Subject:Date:Message-id:To:\n Cc:Mime-version:Content-type:Content-transfer-encoding:In-reply-to:\n References;\n b=dhGmCPw6fS7AchXfaeIia0q7Bu7MC4JBZsGvp88aPaU2AfIqdEcuoPY8l+R3JQFgR\n /62b6mez95VbKbXt10PAI57goEbSbdGs7HgRvZIy4Sy6AbucBuRfOIRJJX/4ev3y6W\n vbF6oOZl/BsECY7B+5PQKzcvJEKI5XpD111kPZ83nRIsbUWTPQERBlxaST4EidMrtJ\n sQU4IgMXV4W3zTE/6lZiRIvlHKKrL7grHPiIgOg6mQjbIheFR43l1lHQ2NxDAyBtrt\n rZ1zgmnQz4bNnMBW+zwOKRgPFgVln2c4n46orjrEaNwWf/gIt/5h09G6gC+6MQtehL\n tiBhl+fXQSwXw==","Message-ID":"<35f17ce2-b272-4494-8c22-2449d4f4915a@yodel.dev>","Date":"Sat, 4 Apr 2026 18:39:59 -0500","MIME-Version":"1.0","Subject":"Re: [RFC PATCH 1/4] alpha: Define Typhoon instance_init","To":"Richard Henderson , qemu-devel@nongnu.org","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","References":"<20260401170454.32045-1-yodel.eldar@yodel.dev>\n <20260401170454.32045-2-yodel.eldar@yodel.dev>\n <5a6f0a78-85aa-4d80-9dc2-4a58100bf6ba@linaro.org>","Content-Language":"en-US","X-Mailgun-Dkim":["no","no"],"From":"Yodel Eldar ","Autocrypt":"addr=yodel.eldar@yodel.dev; keydata=\n xjMEZxqXdhYJKwYBBAHaRw8BAQdAkletQdG3CLyANZyuf2t7Z9PK4b6HiT+DdSPUB2mHzmPN\n I1lvZGVsIEVsZGFyIDx5b2RlbC5lbGRhckB5b2RlbC5kZXY+wpkEExYKAEECGwMFCQOcG00F\n CwkIBwIGFQoJCAsCBBYCAwECHgECF4AWIQTTzRjNQG27imap+N+V7k+3NmVNrAUCaNWASwIZ\n AQAKCRCV7k+3NmVNrNnSAPoDjQXa6v7ZzdQSaLdRfAQy/5SsUucv+zp3WAP4pXdgJQEAzMMC\n Ctx4l6b13Fs2hZdRXEnF/4BZ9t1K68nwzZOV3QnOOARnGpd2EgorBgEEAZdVAQUBAQdAKPIy\n 3W/DKFsm1e+31zoqmOY0pqz8vjIM846wM6lEY2QDAQgHwn4EGBYIACYCGwwWIQTTzRjNQG27\n imap+N+V7k+3NmVNrAUCaNWG7QUJA5wi9wAKCRCV7k+3NmVNrPusAQCQDQwETy7VT6UhHPho\n TkrQnsNqQfFU3tXqCTiViToktQD7B/U2/to97hQIJCWbK6yd3T+KPZJPMcHMg2XRyedUvgA=","In-Reply-To":"<5a6f0a78-85aa-4d80-9dc2-4a58100bf6ba@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=143.55.232.12;\n envelope-from=bounce+0e9322.97607e-qemu-devel=nongnu.org@yodel.dev;\n helo=v512.v5f06b487.use4.send.mailgun.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n HELO_STATIC_HOST=-0.001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]