[{"id":3669496,"web_url":"http://patchwork.ozlabs.org/comment/3669496/","msgid":"","list_archive_url":null,"date":"2026-03-26T06:51:03","subject":"Re: [PATCH] osm-s-mx93: Drop unnecessary BOARD_EARLY_INIT_F usage","submitter":{"id":75172,"url":"http://patchwork.ozlabs.org/api/people/75172/","name":"Frieder Schrempf","email":"frieder.schrempf@kontron.De"},"content":"On 25.03.26 20:00, Tom Rini wrote:\n> This platform enables CONFIG_BOARD_EARLY_INIT_F and then has a\n> do-nothing board_early_init_f function. Change to not enabling the\n> option and so not needing an empty function.\n> \n> Signed-off-by: Tom Rini \n\nThe description seems a bit off, as it looks like this board isn't even\nenabling CONFIG_BOARD_EARLY_INIT_F.\n\nBut anyway:\n\nReviewed-by: Frieder Schrempf \n\n> ---\n> Cc: Frieder Schrempf \n> ---\n> board/kontron/osm-s-mx93/osm-s-mx93.c | 5 -----\n> board/kontron/osm-s-mx93/spl.c | 2 --\n> 2 files changed, 7 deletions(-)\n> \n> diff --git a/board/kontron/osm-s-mx93/osm-s-mx93.c b/board/kontron/osm-s-mx93/osm-s-mx93.c\n> index b6feef549d16..02bee34ac663 100644\n> --- a/board/kontron/osm-s-mx93/osm-s-mx93.c\n> +++ b/board/kontron/osm-s-mx93/osm-s-mx93.c\n> @@ -22,11 +22,6 @@\n> \n> #include \"../common/hw-uid.h\"\n> \n> -int board_early_init_f(void)\n> -{\n> -\treturn 0;\n> -}\n> -\n> #if IS_ENABLED(CONFIG_KONTRON_HW_UID)\n> struct uid_otp_loc uid_otp_locations[] = {\n> \t{\n> diff --git a/board/kontron/osm-s-mx93/spl.c b/board/kontron/osm-s-mx93/spl.c\n> index 23a90e351fe9..a47fc43c6aa9 100644\n> --- a/board/kontron/osm-s-mx93/spl.c\n> +++ b/board/kontron/osm-s-mx93/spl.c\n> @@ -132,8 +132,6 @@ void board_init_f(ulong dummy)\n> \n> \tarch_cpu_init();\n> \n> -\tboard_early_init_f();\n> -\n> \tspl_early_init();\n> \n> \tpreloader_console_init();","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kontron.de header.i=@kontron.de header.a=rsa-sha256\n header.s=selector1 header.b=tDc2y14P;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=kontron.de","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kontron.de header.i=@kontron.de header.b=\"tDc2y14P\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=kontron.de","phobos.denx.de;\n spf=pass smtp.mailfrom=frieder.schrempf@kontron.de","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=kontron.de;"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhDvZ6LK3z1y1x\n\tfor ; Thu, 26 Mar 2026 17:51:22 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4E3A181E18;\n\tThu, 26 Mar 2026 07:51:14 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id C465B838BB; Thu, 26 Mar 2026 07:51:12 +0100 (CET)","from AS8PR04CU009.outbound.protection.outlook.com\n (mail-westeuropeazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c201::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id AB84480517\n for ; Thu, 26 Mar 2026 07:51:10 +0100 (CET)","from AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1fb::23)\n by VI1PR10MB3296.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:131::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.22; Thu, 26 Mar\n 2026 06:51:04 +0000","from AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::a276:4ad7:962:da22]) by AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::a276:4ad7:962:da22%3]) with mapi id 15.20.9745.019; Thu, 26 Mar 2026\n 06:51:04 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=uLkomSTbcDlnfiLHTHittvlFm8pcHQoNIwdhrWKW+hcQL9ccz0Oi3kuz3ThrLacv5L/29mFx3ZIjjPLWr2TeLNG3jueuNPs5I1rw3L/H/FwpRCBrP50duDOMG0LDenummO7rzv8PBFyhKz9hwFlJ01iTlqxFN4B2HDhZ5CeWLagXbai/sXD3XVuLXmxdZFD/+PejE29CJgOIycP14AtYWLvG9eumagi5hDKR+JMSm3Zx7V3cwG/h64WzOM8NDzgMJuRDUTChvvX8jpLkfG+hmx9oVnqPMjyLhjfnWnlIqOubUtVbAIpP0IjwzqR9CnQ76ySHzlM+S7T3BL7SqLevtA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=IDIaeX28ycYBy8xXupgu4f4nuwqvS1aZjbVN/fnZ2vE=;\n b=hsRUvDSjlEqRwUudftgXWx7ZAa4rFGYPzYN2MksoGIezRJ/pbdKQHplwi4OeIeAarZPpd204WPtgnHcicpDqsmoncFCn7RnLbHMDVx3gwEV0lLlwpJx8+D0kh7TNtOH98meZ+OzZsRccY/jM1JyY7y+Mpm97Ff4LuAoECBujGV1oo36miX6BTKCpSFVNh9SYaDmOrDaEJTS/shL3Kl91PeDc0lRwRaE9h19oqbXD9EUDF2GSzQ7dGtS6oLSiHs/4JIwERIDR7fn9sDg+cVmsKun+x3sQCyhI1Cn17wgA3Qv7aZCxbPWJV9O7QdrzMZ1GEl/NoDQqdjupzXzVEaerag==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de;\n dkim=pass header.d=kontron.de; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=kontron.de;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=IDIaeX28ycYBy8xXupgu4f4nuwqvS1aZjbVN/fnZ2vE=;\n b=tDc2y14PFiw4peZFQok8aG+YjnWuyuOXjo/8bAl1A5xcvsIqyz3VtSav3OZUpEV8xpoySuHTPmcNGdyz8au1IH7W/l84g5jTdWMmNAN3TroEwRDr+YZ2POQTvmO3LrkmtGkMBg6RMf8jrVt/0/JRYKzdjguRZCS9ePzUs/Z125jpyKJ/DQkugigSGzqz1iO4OIfPnO5o2EtvPAYUhZxtK260ZVtUjD8FCcg4+Dobusobzp0/+6wSLuPYR4aWOSsMhZLpsiln/VukRyHYuqL6Fe8Wyoobatpf2p2b6nginXgK9WDVBIJU1FHbMjmbW51gcjOI/DBASrZiickfDwXRXw==","Message-ID":"","Date":"Thu, 26 Mar 2026 07:51:03 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] osm-s-mx93: Drop unnecessary BOARD_EARLY_INIT_F usage","To":"Tom Rini , u-boot@lists.denx.de","References":"<20260325190034.3428684-1-trini@konsulko.com>","Content-Language":"en-US, de-DE","From":"Frieder Schrempf ","In-Reply-To":"<20260325190034.3428684-1-trini@konsulko.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"FR4P281CA0183.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:d10:ca::6) To AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:1fb::23)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AM9PR10MB4277:EE_|VI1PR10MB3296:EE_","X-MS-Office365-Filtering-Correlation-Id":"66886fdb-f92e-4bd1-061f-08de8b040cdf","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|366016|1800799024|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n 0BmputT06+/EGy7Vy0GztnHvHfnzYrubCpx1tN4BrdlK2vLBfyh1jfh+/9XYaRJWuLzcCMFRuMVBPccvC6Q2lHC1LMFXxQbJbVTOKIkogRFRAo5kfTeomDFR05yNJzyURPOLOU9pRUEWZ5muvefLaX/Qps4w1ePW1v06Kfj2/XermEjZNV/0a1WlYG/3TNfZns+mPilmjSGnSdrDiynH51tA6/+RBQLAoMz1ey+UcJJYi71SIg8Z5YKcAf/mN432qQtHiPqnIHCsCV903Fjy3sYiWXNN3zDFXixji/JHxzdmNoYncg3qn5tE3qu8zrqlrpv0NNomGHvxwz8pd+E/x3LNcSd/0prJ6xRiGEgQQXSIWfr9tW5vE+PoB+Wwx3Hx4LTsTPDnBtXd+2G8zmg2Y0av5x4M45oSYiKqGupyBL/sSaPKSnOy8Cxc5xw8/hyRwaPcy3D/W+ZqD7kP9RPw3cP8rvxLqrOqh6UQ3wgBcGd7BGEUuwKYlvnmc/phJvGfjZrQG9TOBQu56c0mWb6JPmqwgm0sNTltdnxn9NEyoFUib0uwfSQVSFGtymw7wfgzVck9taD9wdplPvfSypLoHPhzv+/v9ewRp2FMat+muPje23WolVIJS5tMV3bpCmGr26wC+q5YVA0ToC4Rr26PHiIXtNP0XYbVB96Lxz0bNg+MQsJia9LxHTM36GbzPbF9/quKOFHKPoPg2JSwS93QbiDG+CG/8Bf4E2frGcTY4AQ=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(366016)(1800799024)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1102;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?RhNOrpB9h5tw6xcaV6FrozBxfpnk?=\n\t=?utf-8?q?uGuUhin0fJQYctJtlIKb33p1theNvu2rtjiPII7bajRRMbPyNVouYtgfzAX8PtrVT?=\n\t=?utf-8?q?n/rUhbG3EuswuLkZbbIJtuEwYhs9I3xmPJgAwgk30KusrCCZ9ogWrUMQZCY14xZIQ?=\n\t=?utf-8?q?aHuUxJHQkSvKDZY7tefgMalwaZZBOlteNCGdg2IHHgWxBOBwuaumN+OqxciNr55+n?=\n\t=?utf-8?q?hKcnGirR9RW3TluoBKtWc6cnONNc9Vl5OMjZl8ijtEjY/ujGro0pYebzFz6EdAgWz?=\n\t=?utf-8?q?gHGzcm/Q+cQlC7ZhM3WcFYEaHE1rlB2eibVpSdrSJMpgLkaO6SF8Rk+t0nQxevrNB?=\n\t=?utf-8?q?ojjjWiO6AsIF+YHKMjMWCyebRGqhTOF/OgXFGT4PUT6EDm+xtnNBBHyp89l/PGd0j?=\n\t=?utf-8?q?Jv2oCY0gn/yLCt9I7tnV4Bp5YCWa8T7AseD1xEm5Shwd+lVXy/ElDswKWB/KnlJVb?=\n\t=?utf-8?q?vUzlTVOQ75Lg8yArI9U9YUhpWPa5dxUSwMHGv0cOZoIrp9sRuY7pCfxqXoruwzM+e?=\n\t=?utf-8?q?vRybaCsaTgx8vKJHzUl+oTSQA1F3dDOwTcctPUP8bUKvUBrHZOge6RUqK5V6MjZg2?=\n\t=?utf-8?q?8Lt8VgE0bJVaId0XqSFmyxh4PB2SiIhlKCB6gmrmEKZDVxz6Nd7SRLHTosfXTiIZA?=\n\t=?utf-8?q?EAZObwhqY0j1hkJwtWA7jY+FaAv3cyzf7biidAt83Zw/U2eViOH1zYrE5wmfjQcYK?=\n\t=?utf-8?q?u3IcEIzm7sLHAir5ahU4C3LZ4K6BelyZYZTBDfZC/E5hqQT3tRolT53au1uJvyMJC?=\n\t=?utf-8?q?7firszINlDR4D1E6Q10cmR0bP696TbXaxxEKqHVpkvCYPzyEq1Kpy/h2crJHw59dE?=\n\t=?utf-8?q?ow3Lhf43jwcpvgt+9YZhZdZRL78fNKZwirkmsDc5LLvm0IalDMxaOXdiNniJrvGpu?=\n\t=?utf-8?q?ZuUSOJmpzq+2YxDHKNnkr8rlsRwv21bFi16Tin9d9PB3AUBgbm/Xq4Y9sVSiUDRMh?=\n\t=?utf-8?q?EqU3+ZDgYV0Ziur57cLCSSxFQ/4IOGXmznyQORTsqszjB9CTaqcKffkosIC08DzAZ?=\n\t=?utf-8?q?LWs2Ai9+QGvlN1e6xB93zrzkqfcTS0PwvOvLl0SOKU3tId8LGyKq7FnA3sSu0Wn0j?=\n\t=?utf-8?q?Isw1QecVtuFBsJ1pIa0r1yfxK12Kn7ztpvJw19R2CPa+4EoBvCdwEV5jFuA4K751f?=\n\t=?utf-8?q?OZvJRoozpf+DpgAwdIAPtQt1Jq40IEq2fwqRmzh+EMQC4w19oxsuMGmGvfSTuN2AN?=\n\t=?utf-8?q?peQT8cXl8uCqs3pmpprC2ixOMoMsl8oiqbB0LfU7l+PmrFlRds8iZb1WDwLDfUP+3?=\n\t=?utf-8?q?1eBsRK32u5/VnHohIT6H22eJxQnmJoWLfRhMSf8MyPpr3xk1+hBMm/uDFyIKpDq2w?=\n\t=?utf-8?q?p80xzSou2+SFdgQG7mBeNq7RYZP4wvR3MLJfNi+gQoHrR9kc+qByc8NQoz9kVbL9g?=\n\t=?utf-8?q?FFSwSpOf6vbtYiHSsZcaEu9YxhxGc5oxNwc+fp4uM7v/l17PaxeD+2z0+Ea+e8LiX?=\n\t=?utf-8?q?0RDnmObZiDr5NEOOMesLMCmpS8v6/y+NnOjfz+D1oLS1z4eZn5uKHTo9gAmJa1Lg5?=\n\t=?utf-8?q?UC7xKC20PpihUjpV76gIL3D7sGKAZs+bo3i0Qp1xGbZUuAbyXfGHic7k21Cy0PGZu?=\n\t=?utf-8?q?um9N8vmvhcojsfsrf/ZsR8UH3oh+BL+ibJ8hU25eHOev+2VjYxm0cb+Ecefif+BOn?=\n\t=?utf-8?q?4oievGCw4Er6YQ7RuCCWtGg9pKsn8CNm0OmXG69VMyx+sebgn+EPg=3D?=","X-OriginatorOrg":"kontron.de","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 66886fdb-f92e-4bd1-061f-08de8b040cdf","X-MS-Exchange-CrossTenant-AuthSource":"AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"26 Mar 2026 06:51:04.6810 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"8c9d3c97-3fd9-41c8-a2b1-646f3942daf1","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n bjaeqa5MbnEeG17354DTJeMdJAAvjk7swSnng2Q+qMfZ4ruBZ1OdM8z+8nTH4o3qiogEBR7ZfaiMrPA/94GJzpVeJz9bueTE9lVv7XLYXg4=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR10MB3296","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]