[{"id":3669576,"web_url":"http://patchwork.ozlabs.org/comment/3669576/","msgid":"","list_archive_url":null,"date":"2026-03-26T09:42:13","subject":"Re: [PATCH] arm: stm32mp: Drop unnecessary BOARD_EARLY_INIT_F usage","submitter":{"id":80709,"url":"http://patchwork.ozlabs.org/api/people/80709/","name":"Patrice Chotard","email":"patrice.chotard@foss.st.com"},"content":"On 3/25/26 20:00, Tom Rini wrote:\n> All of these platforms enable CONFIG_BOARD_EARLY_INIT_F and then have a\n> do-nothing board_early_init_f function. Change to not enabling the\n> option and so not needing an empty function.\n> \n> Signed-off-by: Tom Rini \n> ---\n> Cc: Patrick Delaunay \n> Cc: Patrice Chotard \n> Cc: Jagan Teki \n> Cc: Matteo Lisi \n> Cc: Dillon Min \n> Cc: uboot-stm32@st-md-mailman.stormreply.com\n> ---\n> arch/arm/mach-stm32mp/stm32mp1/spl.c | 15 ++++++---------\n> board/engicam/stm32mp1/spl.c | 6 ------\n> board/st/stm32h750-art-pi/stm32h750-art-pi.c | 5 -----\n> configs/stm32h750-art-pi_defconfig | 1 -\n> 4 files changed, 6 insertions(+), 21 deletions(-)\n> \n> diff --git a/arch/arm/mach-stm32mp/stm32mp1/spl.c b/arch/arm/mach-stm32mp/stm32mp1/spl.c\n> index e63bdaaf42fd..d2e41b8e65ff 100644\n> --- a/arch/arm/mach-stm32mp/stm32mp1/spl.c\n> +++ b/arch/arm/mach-stm32mp/stm32mp1/spl.c\n> @@ -90,11 +90,6 @@ void spl_display_print(void)\n> }\n> #endif\n> \n> -__weak int board_early_init_f(void)\n> -{\n> -\treturn 0;\n> -}\n> -\n> uint32_t stm32mp_get_dram_size(void)\n> {\n> \tstruct ram_info ram;\n> @@ -204,10 +199,12 @@ void board_init_f(ulong dummy)\n> \t/* enable console uart printing */\n> \tpreloader_console_init();\n> \n> -\tret = board_early_init_f();\n> -\tif (ret) {\n> -\t\tlog_debug(\"board_early_init_f() failed: %d\\n\", ret);\n> -\t\thang();\n> +\tif (IS_ENABLED(CONFIG_BOARD_EARLY_INIT_F)) {\n> +\t\tret = board_early_init_f();\n> +\t\tif (ret) {\n> +\t\t\tlog_debug(\"board_early_init_f() failed: %d\\n\", ret);\n> +\t\t\thang();\n> +\t\t}\n> \t}\n> \n> \tret = uclass_get_device(UCLASS_RAM, 0, &dev);\n> diff --git a/board/engicam/stm32mp1/spl.c b/board/engicam/stm32mp1/spl.c\n> index bb2bd446aa8c..19e5ab0180f9 100644\n> --- a/board/engicam/stm32mp1/spl.c\n> +++ b/board/engicam/stm32mp1/spl.c\n> @@ -15,9 +15,3 @@ void board_vddcore_init(u32 voltage_mv)\n> \tif (IS_ENABLED(CONFIG_PMIC_STPMIC1) && CONFIG_IS_ENABLED(POWER))\n> \t\topp_voltage_mv = voltage_mv;\n> }\n> -\n> -int board_early_init_f(void)\n> -{\n> -\treturn 0;\n> -}\n> -\n> diff --git a/board/st/stm32h750-art-pi/stm32h750-art-pi.c b/board/st/stm32h750-art-pi/stm32h750-art-pi.c\n> index 244bb5eefb3a..8b1b23337790 100644\n> --- a/board/st/stm32h750-art-pi/stm32h750-art-pi.c\n> +++ b/board/st/stm32h750-art-pi/stm32h750-art-pi.c\n> @@ -32,11 +32,6 @@ int dram_init_banksize(void)\n> \treturn 0;\n> }\n> \n> -int board_early_init_f(void)\n> -{\n> -\treturn 0;\n> -}\n> -\n> int board_late_init(void)\n> {\n> \treturn 0;\n> diff --git a/configs/stm32h750-art-pi_defconfig b/configs/stm32h750-art-pi_defconfig\n> index 971d5c00d88f..0d0dca2511b7 100644\n> --- a/configs/stm32h750-art-pi_defconfig\n> +++ b/configs/stm32h750-art-pi_defconfig\n> @@ -24,7 +24,6 @@ CONFIG_DEFAULT_FDT_FILE=\"stm32h750i-art-pi\"\n> CONFIG_SYS_CBSIZE=256\n> CONFIG_SYS_PBSIZE=282\n> # CONFIG_DISPLAY_CPUINFO is not set\n> -CONFIG_BOARD_EARLY_INIT_F=y\n> # CONFIG_BOARD_INIT is not set\n> CONFIG_BOARD_LATE_INIT=y\n> CONFIG_SYS_PROMPT=\"U-Boot > \"\n\nHi Tom\n\nReviewed-by: Patrice Chotard \n\nThanks\nPatrice","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256\n header.s=selector2 header.b=n5YLEukz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=foss.st.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.b=\"n5YLEukz\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=foss.st.com","phobos.denx.de;\n spf=pass smtp.mailfrom=patrice.chotard@foss.st.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhJjS52qDz1y1G\n\tfor ; Thu, 26 Mar 2026 20:42:52 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 779D683FA3;\n\tThu, 26 Mar 2026 10:42:46 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 3443184082; Thu, 26 Mar 2026 10:42:45 +0100 (CET)","from DU2PR03CU002.outbound.protection.outlook.com\n (mail-northeuropeazlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c200::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 139EB83EB3\n for ; Thu, 26 Mar 2026 10:42:42 +0100 (CET)","from AS9PR01CA0004.eurprd01.prod.exchangelabs.com\n (2603:10a6:20b:540::13) by AS8PR10MB5927.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:529::7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Thu, 26 Mar\n 2026 09:42:40 +0000","from AMS1EPF00000046.eurprd04.prod.outlook.com\n (2603:10a6:20b:540:cafe::ec) by AS9PR01CA0004.outlook.office365.com\n (2603:10a6:20b:540::13) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.31 via Frontend Transport; Thu,\n 26 Mar 2026 09:42:37 +0000","from smtpO365.st.com (164.130.1.60) by\n AMS1EPF00000046.mail.protection.outlook.com (10.167.16.43) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9745.21 via Frontend Transport; Thu, 26 Mar 2026 09:42:40 +0000","from STKDAG1NODE1.st.com (10.75.128.132) by smtpO365.st.com\n (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 26 Mar\n 2026 10:45:09 +0100","from [10.48.87.93] (10.48.87.93) by STKDAG1NODE1.st.com\n (10.75.128.132) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 26 Mar\n 2026 10:42:30 +0100"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS\n autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=qbzDK9LUMyHWJ+9zH2dNNxdTJL41z/uZenGofPo7RHXv1Sxb1CPjuPFrSAmzgd11vN3kJgH2Q1WKr+n59XLj1PgUi0fxPSG4XxFTmC/NmTkkot+OQPNurO3Wqh9hLM+rdxBZ1ozlzHddVJ307GTSTXX9lJoeEzqGY6090IkPryGHClQ5xep6S6EPK5CD5DkxP+mucspIEyyGP97T+7pavybFPfyoTQW6Q4842YPqpBJ1L726bUJbiyQADMzXdIm+kxemG83yc8GIiJmZP9LP+49ZbM1jmfudSMvKVQoub879FBTAlLEXRxYwaDPQc0kLn3NaA484JEpk8up/TIbV4A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ygpwNYxtPxr2cyaJDzp2OhaJUK1W4EdFBzMzC8FsPGs=;\n b=O7qAzF/IZRPGO+O4S+9adHl1GnQxEiMvzNi44Lg2G10jxLlg3fEeY/n4NrfQOsaZTwc4+mkh3k+Kh/reu9C+98UpSf2tlTINHBea4KDrOmfqMpGnW4kAy4RPw8/zuCN8bphOEobuA81hUSn2W4XUaiW9J/z+2X2gKE1jdrBLjOLMFfB/7NiYnEXKW4sqPUAJYykEW8IAHgEmBllzZqY++yNuf/R2+lqfuT5pT/pJY/SkRClQ5n6A/jN5PFQJMRW2am05WlsKlMvhdH2TWMrsXyUwOPTs/ITnMsvZpUhh0VKhVmUgyMV+MG4LncBMSsmcRH5nfYFmQkO5dZL7nqwWqQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=fail (sender ip is\n 164.130.1.60) smtp.rcpttodomain=konsulko.com smtp.mailfrom=foss.st.com;\n dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ygpwNYxtPxr2cyaJDzp2OhaJUK1W4EdFBzMzC8FsPGs=;\n b=n5YLEukzQBz/MgEGuwq6TOEAKilcPf2QR+2bPA5oFlvx0gJHAA7ol6cYD4//I4hdqM0R4NzhVvEzuteVIdStIbQEJ1tQUr9Zy/qpyuXL6AJxQLd+KpG56DaRoszqTuhb8gbK2vFqpu4lTwUVAyqri4eiGpqMdDi1wVwLHmQF6AqWOgh+THSMOSNkXL1Epka+0vnuEOITQM+iJ6KsYGu50nbGHlOK2LsgWd3xPdZryJcxP3DCr8LGMLqOhoQzv6/nmIgYWf/OVNIW+COVhP0YqJZUwepRkiVAdGRZqsPr1SP8O+mG/SQ2pKGRVPv7fMTjLLmCd8TQ0QWa7d2jmQbx4g==","X-MS-Exchange-Authentication-Results":"spf=fail (sender IP is 164.130.1.60)\n smtp.mailfrom=foss.st.com; dkim=none (message not signed)\n header.d=none;dmarc=fail action=none header.from=foss.st.com;","Received-SPF":"Fail (protection.outlook.com: domain of foss.st.com does not\n designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com;\n client-ip=164.130.1.60; helo=smtpO365.st.com;","Message-ID":"","Date":"Thu, 26 Mar 2026 10:42:13 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] arm: stm32mp: Drop unnecessary BOARD_EARLY_INIT_F usage","To":"Tom Rini , ","CC":"Patrick Delaunay , Jagan Teki\n , Matteo Lisi , \"Dillon\n Min\" , ","References":"<20260325190027.3428596-1-trini@konsulko.com>","Content-Language":"en-US","From":"Patrice CHOTARD ","In-Reply-To":"<20260325190027.3428596-1-trini@konsulko.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.48.87.93]","X-ClientProxiedBy":"STKCAS1NODE1.st.com (10.75.128.134) To STKDAG1NODE1.st.com\n (10.75.128.132)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AMS1EPF00000046:EE_|AS8PR10MB5927:EE_","X-MS-Office365-Filtering-Correlation-Id":"63be5d94-39c2-45cf-a584-08de8b1c05da","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700016|376014|82310400026|1800799024|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n UxVrUfhj6jxeiGwnDXLBN155cKNTmsyPeXaRnWfvZLVqnWEbgd5jIG2NIlB6Tzbi0XBhMdzdEzalGqxfoWrIIqemw0fn3Avrc3iEQk3KaBy0TWa2t/0rSlU2VFeKRqQahdrG6r0YHeLKRDC1L4X5aL0/45Mzr1IbsSkWH9RM1Gzg4Bk8I7sXC+fCgHV+/WaFErLTT1mGDxVKTwbaFNhXc8DyDITWlnanOtR7BDErTH2j5oEoVllC91Vo+N31gS9QKmOc/UN/WaX9nl1usDaw9sHpZoBNjQD/lhavOzQ3/wv82qimY9aioHHwrk/4oSbcGkz35GPtrkCWFQzH0tddqsE3CkFCHJZbiGfkKeDVNv/RwCCWFT8YTNLs6wykHQBaTAPc8XAxs2pLZR9qyLxOi1p9bb+fVZ97U4ijhBpdI7BlmH+dRg8rfOECFEB3JUv/wVXUo1JpJyGNTQlvEUtHqQa8xs88b4ZammxiRIbsWu3qVn/9oPIfBNkicLUKlL2VmU3SF7uTn5MKkQQJGpAgnSb6sbaQ8CmQTSe99EIay/OovVQtPZQclDdCsrfVZ4W2jbHfOHI1ghG2e/CgF8zIcmMwCCdPkrhm9RaiDGlwah8sZPsUVM1KZRNgVtH0ZrNTOp/7L6Iw9G4cXDXZFgA8cHHslSpoIlXI/zOdWba9ALyZ1REvVP9RcMnhFIjdu1QX4k+4oqTELkIM+MN1OVatXMx7+HExvvrqWSBQfc4DKuAFjFvLdCMYvCfeRnJYSk9WHDjy0HKNqgNzEfOwBILGbg==","X-Forefront-Antispam-Report":"CIP:164.130.1.60; CTRY:IT; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:smtpO365.st.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(36860700016)(376014)(82310400026)(1800799024)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n BveLg3Y9mcP2xh0I1ogodF0Mw1kamYmAmFWNYUuw74taYxpL4NDOuQyHu8sRGGYi+nWYIZk0osDOYA6HYZf3K3/bnFzkCaYyQH8wNGcIr7UkmCagnUfQLqWenb0uuP39KJqgwxgvOEReEfJh5xMfV7RjIj6pNNkrYkqz6in61sjKYjMlj0bqNj3b4hD2BFbr3wCjIFYINPY74UM8YzhkezvZq8mJya2Gc7cFouKCD8R7e4Q2+NTrE2k+hsIreq49uX80TeTYMxAIWdz0qlfuZoTu451Pf0CVZ0yBv7xZHqTql6MVYlVqBHmLYMG9b08SjKaUbmFXNuXW+la/hZb3dRdTWhZ7KAzH1FCytsZeLS09ZtQn2OPFqcqRfk0nJ1D7Pm3bqgclTCJEn8YZUMQCC/RNWD7MmogWrSd2qqvsHN0HABAJ3BEPZgd/2ByFOc++","X-OriginatorOrg":"foss.st.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"26 Mar 2026 09:42:40.5853 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 63be5d94-39c2-45cf-a584-08de8b1c05da","X-MS-Exchange-CrossTenant-Id":"75e027c9-20d5-47d5-b82f-77d7cd041e8f","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; Ip=[164.130.1.60];\n Helo=[smtpO365.st.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n AMS1EPF00000046.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS8PR10MB5927","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]