[{"id":3669636,"web_url":"http://patchwork.ozlabs.org/comment/3669636/","msgid":"<CA+HBbNHqG_w1kxtp_B9otXSGf2nSac6FaeVBtE+6qT9sb_PpMQ@mail.gmail.com>","list_archive_url":null,"date":"2026-03-26T11:04:25","subject":"Re: [PATCH] arm: mvebu: Drop unnecessary BOARD_EARLY_INIT_F usage","submitter":{"id":78207,"url":"http://patchwork.ozlabs.org/api/people/78207/","name":"Robert Marko","email":"robert.marko@sartura.hr"},"content":"On Wed, Mar 25, 2026 at 8:00 PM Tom Rini <trini@konsulko.com> wrote:\n>\n> All of these platforms enable CONFIG_BOARD_EARLY_INIT_F and then have a\n> do-nothing board_early_init_f function. Change to not enabling the\n> option and so not needing an empty function.\n>\n> Signed-off-by: Tom Rini <trini@konsulko.com>\n\nReviewed-by: Robert Marko <robert.marko@sartura.hr>\n\n> ---\n> Cc: Stefan Roese <sr@denx.de>\n> Cc: Robert Marko <robert.marko@sartura.hr>\n> Cc: Konstantin Porotchkin <kostap@marvell.com>\n> Cc: Ben Schneider <ben@bens.haus>\n> ---\n>  board/Marvell/mvebu_armada-37xx/board.c           | 5 -----\n>  configs/eDPU_defconfig                            | 1 -\n>  configs/mvebu_db-88f3720_defconfig                | 1 -\n>  configs/mvebu_espressobin-88f3720_defconfig       | 1 -\n>  configs/mvebu_espressobin_ultra-88f3720_defconfig | 1 -\n>  configs/uDPU_defconfig                            | 1 -\n>  6 files changed, 10 deletions(-)\n>\n> diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c\n> index e44b713f96d7..c30fca6cffd8 100644\n> --- a/board/Marvell/mvebu_armada-37xx/board.c\n> +++ b/board/Marvell/mvebu_armada-37xx/board.c\n> @@ -102,11 +102,6 @@ static bool is_edpu_plus(void)\n>                 return false;\n>  }\n>\n> -int board_early_init_f(void)\n> -{\n> -       return 0;\n> -}\n> -\n>  int board_init(void)\n>  {\n>         /* adress of boot parameters */\n> diff --git a/configs/eDPU_defconfig b/configs/eDPU_defconfig\n> index 0b7815c78a30..98ba91aa568f 100644\n> --- a/configs/eDPU_defconfig\n> +++ b/configs/eDPU_defconfig\n> @@ -23,7 +23,6 @@ CONFIG_SYS_PBSIZE=1048\n>  # CONFIG_DISPLAY_CPUINFO is not set\n>  # CONFIG_DISPLAY_BOARDINFO is not set\n>  CONFIG_DISPLAY_BOARDINFO_LATE=y\n> -CONFIG_BOARD_EARLY_INIT_F=y\n>  CONFIG_SYS_PROMPT=\"eDPU>> \"\n>  CONFIG_SYS_MAXARGS=32\n>  # CONFIG_CMD_ELF is not set\n> diff --git a/configs/mvebu_db-88f3720_defconfig b/configs/mvebu_db-88f3720_defconfig\n> index 52ad18e4dd91..b7a2559997fe 100644\n> --- a/configs/mvebu_db-88f3720_defconfig\n> +++ b/configs/mvebu_db-88f3720_defconfig\n> @@ -23,7 +23,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y\n>  # CONFIG_DISPLAY_CPUINFO is not set\n>  # CONFIG_DISPLAY_BOARDINFO is not set\n>  CONFIG_DISPLAY_BOARDINFO_LATE=y\n> -CONFIG_BOARD_EARLY_INIT_F=y\n>  CONFIG_SYS_MAXARGS=32\n>  CONFIG_CMD_FUSE=y\n>  CONFIG_CMD_GPIO=y\n> diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig\n> index af3bf1a04fce..c101b342980c 100644\n> --- a/configs/mvebu_espressobin-88f3720_defconfig\n> +++ b/configs/mvebu_espressobin-88f3720_defconfig\n> @@ -25,7 +25,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y\n>  # CONFIG_DISPLAY_CPUINFO is not set\n>  # CONFIG_DISPLAY_BOARDINFO is not set\n>  CONFIG_DISPLAY_BOARDINFO_LATE=y\n> -CONFIG_BOARD_EARLY_INIT_F=y\n>  CONFIG_BOARD_LATE_INIT=y\n>  CONFIG_SYS_MAXARGS=32\n>  CONFIG_CMD_FUSE=y\n> diff --git a/configs/mvebu_espressobin_ultra-88f3720_defconfig b/configs/mvebu_espressobin_ultra-88f3720_defconfig\n> index 69d6f7e34c3b..157bd9696425 100644\n> --- a/configs/mvebu_espressobin_ultra-88f3720_defconfig\n> +++ b/configs/mvebu_espressobin_ultra-88f3720_defconfig\n> @@ -24,7 +24,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y\n>  # CONFIG_DISPLAY_CPUINFO is not set\n>  # CONFIG_DISPLAY_BOARDINFO is not set\n>  CONFIG_DISPLAY_BOARDINFO_LATE=y\n> -CONFIG_BOARD_EARLY_INIT_F=y\n>  CONFIG_BOARD_LATE_INIT=y\n>  CONFIG_SYS_MAXARGS=32\n>  CONFIG_CMD_FUSE=y\n> diff --git a/configs/uDPU_defconfig b/configs/uDPU_defconfig\n> index 851d7bb2cb99..b819e978c3a5 100644\n> --- a/configs/uDPU_defconfig\n> +++ b/configs/uDPU_defconfig\n> @@ -22,7 +22,6 @@ CONFIG_SYS_PBSIZE=1048\n>  # CONFIG_DISPLAY_CPUINFO is not set\n>  # CONFIG_DISPLAY_BOARDINFO is not set\n>  CONFIG_DISPLAY_BOARDINFO_LATE=y\n> -CONFIG_BOARD_EARLY_INIT_F=y\n>  CONFIG_SYS_PROMPT=\"uDPU>> \"\n>  CONFIG_SYS_MAXARGS=32\n>  # CONFIG_CMD_ELF is not set\n> --\n> 2.43.0\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=sartura.hr header.i=@sartura.hr header.a=rsa-sha256\n header.s=sartura header.b=q32R/s1b;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=sartura.hr","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=sartura.hr header.i=@sartura.hr header.b=\"q32R/s1b\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=sartura.hr","phobos.denx.de;\n spf=pass smtp.mailfrom=robert.marko@sartura.hr"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhLWw3RH0z1yGD\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 22:04:43 +1100 (AEDT)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7584083A1B;\n\tThu, 26 Mar 2026 12:04:40 +0100 (CET)","by phobos.denx.de (Postfix, from userid 109)\n id 0E88983CD3; Thu, 26 Mar 2026 12:04:40 +0100 (CET)","from mail-ed1-x533.google.com (mail-ed1-x533.google.com\n [IPv6:2a00:1450:4864:20::533])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E7AAC81E18\n for <u-boot@lists.denx.de>; Thu, 26 Mar 2026 12:04:37 +0100 (CET)","by mail-ed1-x533.google.com with SMTP id\n 4fb4d7f45d1cf-6674cba2c50so2977875a12.0\n for <u-boot@lists.denx.de>; Thu, 26 Mar 2026 04:04:37 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1774523077; cv=none;\n d=google.com; s=arc-20240605;\n b=Fb4uwFB6a7UYisZUqp2/4nZt+ZQvbVFoJCoohy4Z8LmVFh/0N2+03ijtqfv3T1b9k5\n FIfG/bcwq3Msk0YI0J3VbTX6ixprRoJ7Jh0HPUUF2TuFJnoefl08c96QxOJVv5E5ndq+\n i4ZszpFHE1opWeEBfWmSSz2JF34dDTMMNQkjQq4ilec6uEivkINRHrtpT/iPafUXWc0p\n yqn1QTjne5P5hxvYnB6kudcy2eVtfXya+JRmh3qejQkwJLGM5F2fthQyjv6I5wJ6FNTE\n DX8vtfurXqxECMumGSijnbMzXiXqJ09owiAKwPe4T9bn+WVlxVG9ql32m/O4VwMc5LAT\n KfnA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=ElcPPX/orCyBpBNalv+zzTQuclAepCTeILX63NlpZEQ=;\n fh=b/59rRfUTTMuKCQOd2M8mPkKtPAZ1mLPI+Y3K2VJOyo=;\n b=XyqKFYO1LcFI8m2dFlWfGVGdv40DX84vvR6gYyu0KAvcy/geoTxW07TabZ0oHGUB+s\n mQOiUWYMK8czTplOp8KMd8MjW1nf+LENE3u9tX1QriULCbxwUhitqE9e7AZUTbrFF+iV\n CrhXkkLzb5VSck6Br7R/GO5bJg/5yOJfbwngwOQN63yLlRqf1o6E9bJzVaeC3EK1hQq+\n CNj2EL89vyKzNUJIw0PEtNo9df65bVtHWW4MF7LWOmdEROchrGw+QXtGD1pS7tYrES8u\n fgZlvtZAlPXRO46qjOHTancx40x836z8qqNs4wzQG/uCE42wA4pQl9dek+RIHrP2XKcc\n 3H+g==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=sartura.hr; s=sartura; t=1774523077; x=1775127877; darn=lists.denx.de;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ElcPPX/orCyBpBNalv+zzTQuclAepCTeILX63NlpZEQ=;\n b=q32R/s1blIiG+r30hI/mvKLtFTIAPKZJb2AFa7djxhtkFZ4ZOVcSaY2anGK57oayNg\n 99/Jl+3vdDLeQaRXAn79p7vYeOcar9+Zo/JqCYKvy7hvC+55UnuZB/k2MgdeYVQXHAmj\n rFxeso/dB4I+jlArkgrVFk03A2FLhZBpAI53tPHDUjx7faESnggPSTbd2WJ7uFMDWVsy\n 6zzxFGJwUHefVClETpwnz9f+XkX3eUhdRTY7STn5PoZgf9O51bAA9FRciTLXS2jMnJNB\n KletqNORlyVTAqVYd7X+R+1j5QZKzQYZmAGby9PKPKTB//gFLcAJEk9aMhIyOF/AbAee\n EDSA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774523077; x=1775127877;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ElcPPX/orCyBpBNalv+zzTQuclAepCTeILX63NlpZEQ=;\n b=ER4ZAF8uM6TuCL27kwJdtl4otUVFUuJFU8/VWedSqsGwaqd6pK/vwMycMoquJNToJW\n f+2O4DDZL1cRCaI6paGjY1NNcal+F1i1qGugvkzv3wJ/c+Elab6v2CvzwHafZqOJM6QY\n uRoh8LtLLFIydW/lUMnhMNj7fgloC+a5ySB3vyfjiwf7NlJnQBhkdVnFRFe/+4Y2oUCS\n 8BMX+tPWXJL79KdtNeZQpi/DU80noQj7GOH9xJQOE8Bk/icZU9xpp6TtAVwjGqlnHPz1\n kT3Rm2BaMd7SRAs7uO+KUhhApqJmTsVNX09Gb5YMrHpzlzl2hSBfkQJ4y5rd1ncZUYl0\n 2uhA==","X-Gm-Message-State":"AOJu0Yxb11OzrvHCwu10ecfsolIiQDnyiFplv9llhjJpXJ13NOP8LsAk\n Rq+eDBlT+EUeSR/KATpof+ljRL8lsFlMnGpaZ1bDknEdAqixRyW8nVWAfUbncj8O/XMb6WfQUIc\n Bfq/b58GcAq4pDDcafd5x/6aE+7kzx/ERIS1MP8s0YA==","X-Gm-Gg":"ATEYQzzPfyO/hHMxAhvHIskt0OM4f5AAoPvilY3GG7fplT+eNLcIzlXVRrtQtgUQQ6/\n ARAas9pU2tstGWqM2TUdFwkRbjotlrJ/CfLxnJk4WItgf686xEbQ4pGfKgRt9Oa0TawDWLmwHyJ\n LDYqrV7c4GTUPH6knFRT+EUabLLoW6raVQjIeD2SLqH1QdcPuPodhPW5ciGm3+pISf8cuT2pvJy\n 8ZE/OyLI4sdmBS0Apg0hldJfcNTFZdIccHorcdsb27uhm4w5GRFLrwl5gQCp/hwBsG0+3zhC7La\n RQ4cYjgyeRGjHCG/kdnnNEuQer3K9JBEAnPmHHTQOvgW7dDK589AY3eSqjNxUg==","X-Received":"by 2002:a17:906:c155:b0:b97:9a7a:9d21 with SMTP id\n a640c23a62f3a-b9b2e5481abmr76673266b.4.1774523077336; Thu, 26 Mar 2026\n 04:04:37 -0700 (PDT)","MIME-Version":"1.0","References":"<20260325190022.3428531-1-trini@konsulko.com>","In-Reply-To":"<20260325190022.3428531-1-trini@konsulko.com>","From":"Robert Marko <robert.marko@sartura.hr>","Date":"Thu, 26 Mar 2026 12:04:25 +0100","X-Gm-Features":"AQROBzB6F-BsCgv0S5C3d7MTBPK6er0Z87VHwPiXW4tLRe7nOJIuAn41Xonq0qU","Message-ID":"\n <CA+HBbNHqG_w1kxtp_B9otXSGf2nSac6FaeVBtE+6qT9sb_PpMQ@mail.gmail.com>","Subject":"Re: [PATCH] arm: mvebu: Drop unnecessary BOARD_EARLY_INIT_F usage","To":"Tom Rini <trini@konsulko.com>","Cc":"u-boot@lists.denx.de, Stefan Roese <sr@denx.de>,\n Konstantin Porotchkin <kostap@marvell.com>, Ben Schneider <ben@bens.haus>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]