[{"id":3669660,"web_url":"http://patchwork.ozlabs.org/comment/3669660/","msgid":"<CAMuHMdW5jiR5CqV0xhxio4vtV_bPczO5u1Da86CWJO+=6WU4+Q@mail.gmail.com>","list_archive_url":null,"date":"2026-03-26T11:30:33","subject":"Re: [PATCH v2] pinctrl: renesas: rzg2l: Fix save/restore of\n {IOLH,IEN,PUPD,SMT} registers","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"Hi Biju,\n\nOn Wed, 25 Mar 2026 at 19:28, Biju <biju.das.au@gmail.com> wrote:\n> From: Biju Das <biju.das.jz@bp.renesas.com>\n>\n> The rzg2l_pinctrl_pm_setup_regs() handles save/restore of\n> {IOLH,IEN,PUPD,SMT} registers during s2ram, but only for ports where all\n> pins share the same pincfg. Extend the code to also support ports with\n> variable pincfg per pin, so that {IOLH,IEN,PUPD,SMT} registers are\n> correctly saved and restored for all pins.\n>\n> Fixes: 254203f9a94c (\"pinctrl: renesas: rzg2l: Add suspend/resume support\")\n> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>\n\nThanks for the update!\n\n> ---\n> v1->v2:\n>  * Updated commit description\n>  * Improved the logic.\n\nYou also fixed the double application of the pin_off index, right?\n\n> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c\n> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c\n> @@ -3001,9 +3001,12 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_pinctrl *pctrl, bool suspen\n>  {\n>         u32 nports = pctrl->data->n_port_pins / RZG2L_PINS_PER_PORT;\n>         struct rzg2l_pinctrl_reg_cache *cache = pctrl->cache;\n> +       u32 pin_off = 0;\n>\n> -       for (u32 port = 0; port < nports; port++) {\n> +       for (u32 port = 0; port < nports; port++, pin_off += RZG2L_PINS_PER_PORT) {\n> +               const struct pinctrl_pin_desc *pin_desc = &pctrl->desc.pins[pin_off];\n\nHere you index pctrl->desc.pins[]...\n\n>                 bool has_iolh, has_ien, has_pupd, has_smt;\n> +               u64 *pin_data = pin_desc->drv_data;\n\nHere you get pin_data, so below you will actually index\npctrl->desc.pins[pin_off].drv_data[].  That is not only confusing,\nbut also only works because pctrl->desc.pins[i].drv_data is initialized\nin rzg2l_pinctrl_register() like:\n\n    pins[i].drv_data = &pin_data[i];\n\nAll these new variables (incl. pin_off) are only used inside the new\nif () below, so please confine everything to that block.\n\n>                 u32 off, caps;\n>                 u8 pincnt;\n>                 u64 cfg;\n> @@ -3012,6 +3015,11 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_pinctrl *pctrl, bool suspen\n>                 off = RZG2L_PIN_CFG_TO_PORT_OFFSET(cfg);\n>                 pincnt = hweight8(FIELD_GET(PIN_CFG_PIN_MAP_MASK, cfg));\n>\n> +               if (cfg & RZG2L_VARIABLE_CFG) {\n> +                       for (unsigned int i = 1; i < RZG2L_PINS_PER_PORT; i++)\n\nShouldn't the loop start at zero? The PIN_CFG_MASK part of a variable\nconfig is always zero.\n\n> +                               cfg |= *pin_data++;\n\nPlease use pctrl->desc.pins[pin_off + i].drv_data here.\nAnd pin_off can be replaced by port * RZG2L_PINS_PER_PORT.\n\n> +               }\n> +\n>                 caps = FIELD_GET(PIN_CFG_MASK, cfg);\n>                 has_iolh = !!(caps & (PIN_CFG_IOLH_A | PIN_CFG_IOLH_B | PIN_CFG_IOLH_C));\n>                 has_ien = !!(caps & PIN_CFG_IEN);\n\nGr{oetje,eeting}s,\n\n                        Geert\n\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n                                -- Linus Torvalds","headers":{"Return-Path":"\n <linux-gpio+bounces-34205-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34205-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.180","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhMMR5slgz1y1G\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 22:42:27 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 9C6AD3056AAE\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 11:30:53 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 681C93E51C9;\n\tThu, 26 Mar 2026 11:30:52 +0000 (UTC)","from mail-vk1-f180.google.com (mail-vk1-f180.google.com\n [209.85.221.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 984693DD523\n\tfor <linux-gpio@vger.kernel.org>; Thu, 26 Mar 2026 11:30:49 +0000 (UTC)","by mail-vk1-f180.google.com with SMTP id\n 71dfb90a1353d-56b8804f37cso422745e0c.3\n        for <linux-gpio@vger.kernel.org>;\n Thu, 26 Mar 2026 04:30:49 -0700 (PDT)","from mail-vk1-f178.google.com (mail-vk1-f178.google.com.\n [209.85.221.178])\n        by smtp.gmail.com with ESMTPSA id\n 71dfb90a1353d-56d31da7eddsm4141020e0c.18.2026.03.26.04.30.46\n        for <linux-gpio@vger.kernel.org>\n        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n        Thu, 26 Mar 2026 04:30:46 -0700 (PDT)","by mail-vk1-f178.google.com with SMTP id\n 71dfb90a1353d-56b8804f37cso422734e0c.3\n        for <linux-gpio@vger.kernel.org>;\n Thu, 26 Mar 2026 04:30:46 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774524651; cv=none;\n b=F7LUAVDerkDTJApzQi/Zwpe+Knt7jFFIaGCU3hbYc9kOZ9GloCOALevdvn3SPFKdVCnE3ie/ElKF0GoG1lMnlWd+JkddVcDc6ewkMR/l5B9zEIwvwmPdQA05Zj+JXRnwiL44BS4gRvLpj1rCv2WpNqzXBhkqEd1JWfwR8oe12yg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774524651; c=relaxed/simple;\n\tbh=odmcbAvqK0vOqDQP/nWAmuzHOBKhpU4i+9caAtg5EmA=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=OXg6zMDtU+hpCJr6a4ssRM+vv8wtkObD4BuVYUsWbH41TTFx8w3B2+ayP3Xy7Rv3KqaZDKvF9ZCYoCx+TkhbvTmb4mV6Et9eixMHsmA66rFoJFTD5KYhrODdNvYn+DmWPQ2l0/TcDDSXtSKk8sgUFxmf+4Xe/t2lMv41nVIYieo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org;\n spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.180","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1774524648; x=1775129448;\n        h=cc:to:subject:message-id:date:from:in-reply-to:references\n         :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=NPXrf/dFqxXiTE7eESLhISzL+tSi36TOUFQjk/UIol8=;\n        b=XJsMWgS0acvoCYMYnfBhjZ5wgdxVvmwRVmxE7VQa8BJqgTv7ULnzEKLE67eqznABlr\n         aD0Tf0M54Jz/NfoiCWwYAJ53rwNbzGcbEIcMhP8eMW7vE6g35jryPpXqnM8rsWcPOzg+\n         2UsEea5tpjTtAFNLIoH/sLcIBRjLuAZ2No+1GMVnGRQgPvUWfzAANtySJh9zDCFdnoZD\n         8um9WqbOvuG1JsP1B2Rrtmf1cKQRpZl1v9W9r9f/rctDEJynz5qvTdlpwP2tLJUJ7Iog\n         APfVifPPQTvCkLd5zg4tR9g7/2zl5yaYILUOt9lK0gULobb/fCH+xGNtyf7+t9q3Q0I7\n         jYgA==","X-Forwarded-Encrypted":["i=1;\n AJvYcCXn2DAOm9emU49GBViTjYQajDIskSnfmJr7a2lVhGwpU/0MHIvbVBGJdF31eh4U2K55+dFrY3BVts11@vger.kernel.org","i=1;\n AJvYcCVkb5/XlgOamWttfHK1VmV37De/iuFerh4Z/c2yELB8PXCgefgkUxTBEQqphWNJ3kxUlUCwtPb6w0Yd@vger.kernel.org"],"X-Gm-Message-State":"AOJu0YxyYzqCmZ4dqZsjdDTXGrfH8WV1f6IFDdVYsQHUG80e1WSXQvEV\n\tjX17I8DnetFtUtQK14cbMb+o9eNn6MulR1MyZdt3QpxZ9O7D58ucc5Lk1bBkfFcPyUM=","X-Gm-Gg":"ATEYQzwd3S9RuE0jhJN1rDyVa2Hmx2lmm/cPJimjisi4y59b41qdaon+CzcvyLMBr3p\n\tF9J9yhBtJXQa41WpgJhQCi2oCmzoWmoJIABteSk1W4+TU22vF/xLnz/5/ck4/PKg8tgE5ArW7e5\n\tNM7/QIv81lUNVYe/WmiaMh52DcYISWVQfB6iUjsDwWjbxjQTpz1smft2wIBLJPjVQWVzB8YPFag\n\tibIf6/xx9x9Z2CcQSZOPMxXbZjm5/OONckENJvqS6XrPAVpqcTMtNLW2/HuP/7vSnxByiJrW0/o\n\tiE5QGUp7DgiuYCQXO0rIqkdwwH7hogTje8eeK5dZ4FWYsxTPK/lmjbDa8lfhRviqd+gk0qbm7jV\n\t7wPClrsl4bCbtMWHthfk9fekwyJ4DaesgttloNEM2jP6wY0uBQdcHzdAGsjVNKIjaOIhdmO+8QN\n\t+ZMdQJDjDQzhdopCtrzQ6kBCMOgaK1C/yhZ8Gkb5NKKDxWokogtilwhQ154Qn9y2gv5yyTufa/T\n\trs=","X-Received":["by 2002:a05:6122:8289:b0:56c:ca38:ebeb with SMTP id\n 71dfb90a1353d-56d21f2375dmr3421332e0c.2.1774524648142;\n        Thu, 26 Mar 2026 04:30:48 -0700 (PDT)","by 2002:a05:6123:4c:b0:56a:f542:78fb with SMTP id\n 71dfb90a1353d-56d21f80b13mr3497906e0c.7.1774524646190; Thu, 26 Mar 2026\n 04:30:46 -0700 (PDT)"],"Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","References":"<20260325182849.84660-1-biju.das.jz@bp.renesas.com>","In-Reply-To":"<20260325182849.84660-1-biju.das.jz@bp.renesas.com>","From":"Geert Uytterhoeven <geert@linux-m68k.org>","Date":"Thu, 26 Mar 2026 12:30:33 +0100","X-Gmail-Original-Message-ID":"\n <CAMuHMdW5jiR5CqV0xhxio4vtV_bPczO5u1Da86CWJO+=6WU4+Q@mail.gmail.com>","X-Gm-Features":"AQROBzCSesQ1Gk9HBRRwU2IRgiI5K96hhm2cR4dgKIMFaNKm8dS0uOXZPcMlwPo","Message-ID":"\n <CAMuHMdW5jiR5CqV0xhxio4vtV_bPczO5u1Da86CWJO+=6WU4+Q@mail.gmail.com>","Subject":"Re: [PATCH v2] pinctrl: renesas: rzg2l: Fix save/restore of\n {IOLH,IEN,PUPD,SMT} registers","To":"Biju <biju.das.au@gmail.com>","Cc":"Linus Walleij <linusw@kernel.org>, Biju Das <biju.das.jz@bp.renesas.com>,\n\tClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,\n linux-renesas-soc@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tPrabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":3669783,"web_url":"http://patchwork.ozlabs.org/comment/3669783/","msgid":"<TY3PR01MB11346A5A7DA755F372ECE3D968656A@TY3PR01MB11346.jpnprd01.prod.outlook.com>","list_archive_url":null,"date":"2026-03-26T15:06:37","subject":"RE: [PATCH v2] pinctrl: renesas: rzg2l: Fix save/restore of\n {IOLH,IEN,PUPD,SMT} registers","submitter":{"id":79631,"url":"http://patchwork.ozlabs.org/api/people/79631/","name":"Biju Das","email":"biju.das.jz@bp.renesas.com"},"content":"Hi Geert,\n\nThanks for the feedback\n\n> -----Original Message-----\n> From: Geert Uytterhoeven <geert@linux-m68k.org>\n> Sent: 26 March 2026 11:31\n> Subject: Re: [PATCH v2] pinctrl: renesas: rzg2l: Fix save/restore of {IOLH,IEN,PUPD,SMT} registers\n> \n> Hi Biju,\n> \n> On Wed, 25 Mar 2026 at 19:28, Biju <biju.das.au@gmail.com> wrote:\n> > From: Biju Das <biju.das.jz@bp.renesas.com>\n> >\n> > The rzg2l_pinctrl_pm_setup_regs() handles save/restore of\n> > {IOLH,IEN,PUPD,SMT} registers during s2ram, but only for ports where\n> > all pins share the same pincfg. Extend the code to also support ports\n> > with variable pincfg per pin, so that {IOLH,IEN,PUPD,SMT} registers\n> > are correctly saved and restored for all pins.\n> >\n> > Fixes: 254203f9a94c (\"pinctrl: renesas: rzg2l: Add suspend/resume\n> > support\")\n> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>\n> \n> Thanks for the update!\n> \n> > ---\n> > v1->v2:\n> >  * Updated commit description\n> >  * Improved the logic.\n> \n> You also fixed the double application of the pin_off index, right?\n\nYes, it is my mistake, I haven't looked the proposed code during\nour internal review as the testing showed the results are OK with ethernet OEN \nPins during suspend/resume cycle of s2ram.\n\n> \n> > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c\n> > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c\n> > @@ -3001,9 +3001,12 @@ static void rzg2l_pinctrl_pm_setup_regs(struct\n> > rzg2l_pinctrl *pctrl, bool suspen  {\n> >         u32 nports = pctrl->data->n_port_pins / RZG2L_PINS_PER_PORT;\n> >         struct rzg2l_pinctrl_reg_cache *cache = pctrl->cache;\n> > +       u32 pin_off = 0;\n> >\n> > -       for (u32 port = 0; port < nports; port++) {\n> > +       for (u32 port = 0; port < nports; port++, pin_off += RZG2L_PINS_PER_PORT) {\n> > +               const struct pinctrl_pin_desc *pin_desc =\n> > + &pctrl->desc.pins[pin_off];\n> \n> Here you index pctrl->desc.pins[]...\n\nOK.\n> \n> >                 bool has_iolh, has_ien, has_pupd, has_smt;\n> > +               u64 *pin_data = pin_desc->drv_data;\n> \n> Here you get pin_data, so below you will actually index\n> pctrl->desc.pins[pin_off].drv_data[].  That is not only confusing,\n> but also only works because pctrl->desc.pins[i].drv_data is initialized in rzg2l_pinctrl_register()\n> like:\n> \n>     pins[i].drv_data = &pin_data[i];\n> \n> All these new variables (incl. pin_off) are only used inside the new if () below, so please confine\n> everything to that block.\n\nOK.\n> \n> >                 u32 off, caps;\n> >                 u8 pincnt;\n> >                 u64 cfg;\n> > @@ -3012,6 +3015,11 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_pinctrl *pctrl, bool\n> suspen\n> >                 off = RZG2L_PIN_CFG_TO_PORT_OFFSET(cfg);\n> >                 pincnt = hweight8(FIELD_GET(PIN_CFG_PIN_MAP_MASK,\n> > cfg));\n> >\n> > +               if (cfg & RZG2L_VARIABLE_CFG) {\n> > +                       for (unsigned int i = 1; i <\n> > + RZG2L_PINS_PER_PORT; i++)\n> \n> Shouldn't the loop start at zero? The PIN_CFG_MASK part of a variable config is always zero.\n> \n> > +                               cfg |= *pin_data++;\n> \n> Please use pctrl->desc.pins[pin_off + i].drv_data here.\n> And pin_off can be replaced by port * RZG2L_PINS_PER_PORT.\n\n\nOK, will replace it as in the next version as below\n\n+\t\tif (cfg & RZG2L_VARIABLE_CFG) {\n+\t\t\tunsigned int pin = port * RZG2L_PINS_PER_PORT;\n+\n+\t\t\tfor (unsigned int i = 0; i < RZG2L_PINS_PER_PORT; i++)\n+\t\t\t\tcfg |= *(u64 *)pctrl->desc.pins[ pin + i ].drv_data;\n+\t\t}\n+\n\nCheers,\nBiju","headers":{"Return-Path":"\n <linux-gpio+bounces-34214-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.a=rsa-sha256 header.s=selector1 header.b=XfZIVBhx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34214-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=\"XfZIVBhx\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.229.71","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bp.renesas.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=bp.renesas.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhS5C3DGsz1yGD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 02:15:27 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D085930F12F9\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 15:06:54 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DF3D13FFAC1;\n\tThu, 26 Mar 2026 15:06:50 +0000 (UTC)","from TY3P286CU002.outbound.protection.outlook.com\n (mail-japaneastazon11010071.outbound.protection.outlook.com [52.101.229.71])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 49AB135CBC3;\n\tThu, 26 Mar 2026 15:06:46 +0000 (UTC)","from TY3PR01MB11346.jpnprd01.prod.outlook.com (2603:1096:400:3d0::7)\n by TYVPR01MB11229.jpnprd01.prod.outlook.com (2603:1096:400:36c::5) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.22; Thu, 26 Mar\n 2026 15:06:44 +0000","from TY3PR01MB11346.jpnprd01.prod.outlook.com\n ([fe80::87d1:4928:d55:97de]) by TY3PR01MB11346.jpnprd01.prod.outlook.com\n ([fe80::87d1:4928:d55:97de%4]) with mapi id 15.20.9745.023; Thu, 26 Mar 2026\n 15:06:37 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774537610; cv=fail;\n b=Oo2HAc5wjB8zFvZRyeUaYiwALbhLE9/D1wAgyQIwpuL5SqgrZToIWU49IhYFERvKJSL+Ky5o6U3+pEu34bvIivXLSBTY1KmyUdeHKuNxqrhhnFxvtdvfcIbvFkWCA3J4PzmkWqwrm1YQhpGpIZ5cEqZ8tHDDEl+76q5D2rHAiP8=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=o1sJCvscRQfGwsqcLcph/37zZnowCCWLoDQWe97koXWi5tyH4ivGhWNzaNykAG8k+MwbgMv+Gux+thxGJqXM1AKb7qoW7NFHRez6/3R7KAhhcaFqiSKV2L8ntHi7Q/Dw6tn8LWtnpTNhKjGR68wzDu5M7TNAaZPzFhZ2DdHmRKQPPHhze15bLkQ9jsCL4Awg0Ch0XhtE4aSOyreh4lW2GHilqk1EnCm29hA8bT83RwxU56ilIu4lSVdi8c1qd8gBnScFY7J0j60cs9UAb7rpRUaB7+2mwORUbkFYvYl1kbzUauZNfBqg+CrtdeXf0NAZoMvRoCwhuz4X2pFjv/hqyA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774537610; c=relaxed/simple;\n\tbh=FCZteffyqLGgXWgvwa7xpGE/q/tCXD5e93v12JXhxyY=;\n\th=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=mD7MEtDKu6NIIg+/E/fd6YwP40EBWw0T7Z37YKTit2VvV6g2Cy4OyTz3DljXHSxMzZVsLwEwq363e9Zmt6qmk7AyW1TOVmzDaK7qNNTguBi9nSpPSrUy+ekQ0TYVaABIXYWr40rQrSxoCKgmiRx8S4JYapmHhgW2pZuP0PwwWC4=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=FCZteffyqLGgXWgvwa7xpGE/q/tCXD5e93v12JXhxyY=;\n b=VHTyy4rIEOMWfI8MLAHJCyoI9EIdVIETEaLoEvtQop0tyWPEk1dqGPzhI/ZlMVmH97euHEQH2Ivhz1Pyq/oguF06RMJ4C6RAmB55mzyV1JJ8LuGkk7fvBc+QiyK3n4xt7N2dWdDRs0U5qcjRaLKksg59ulXpE+ZGRIn2URxRd93BbqRaUFCV3dCtwB6PQMamhahFdaBtTDS1IxeCtQ22GroYhKji5fKL31XS8ulN1ckL2iosWkAyHKyrItqCSeTmpXCsdRMZkRb91Y+3CefsM06Ol0d5WczsrQ7tXNyR6pb3HRJpsvKv7+XdViO9USrc+5fPOHGEOuiD7upHBbTguQ=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com;\n spf=pass smtp.mailfrom=bp.renesas.com;\n dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=XfZIVBhx; arc=fail smtp.client-ip=52.101.229.71","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=bp.renesas.com; dmarc=pass action=none\n header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=FCZteffyqLGgXWgvwa7xpGE/q/tCXD5e93v12JXhxyY=;\n b=XfZIVBhxu3PRxQjxgONmLpFdG6sZIHHHOoQB3M1x8a+StVeH+Z8/7LNcv/HFOIuvoU1mljho5DhOgqXtjBBKc6L9HHcJGoXHXIt+bjpKESjeG242iRTx3iR7mBZAY0sydqFLehTAmEqGVzf09A+osigVQDHJZdxgk3ouIuZvRgQ=","From":"Biju Das <biju.das.jz@bp.renesas.com>","To":"geert <geert@linux-m68k.org>, biju.das.au <biju.das.au@gmail.com>","CC":"Linus Walleij <linusw@kernel.org>, Claudiu Beznea\n\t<claudiu.beznea.uj@bp.renesas.com>, \"linux-renesas-soc@vger.kernel.org\"\n\t<linux-renesas-soc@vger.kernel.org>, \"linux-gpio@vger.kernel.org\"\n\t<linux-gpio@vger.kernel.org>, \"linux-kernel@vger.kernel.org\"\n\t<linux-kernel@vger.kernel.org>, Prabhakar Mahadev Lad\n\t<prabhakar.mahadev-lad.rj@bp.renesas.com>","Subject":"RE: [PATCH v2] pinctrl: renesas: rzg2l: Fix save/restore of\n {IOLH,IEN,PUPD,SMT} registers","Thread-Topic":"[PATCH v2] pinctrl: renesas: rzg2l: Fix save/restore of\n {IOLH,IEN,PUPD,SMT} registers","Thread-Index":"AQHcvIVATi6zgACS9k6a3PkefV2v/bXArt+AgAA6XRA=","Date":"Thu, 26 Mar 2026 15:06:37 +0000","Message-ID":"\n <TY3PR01MB11346A5A7DA755F372ECE3D968656A@TY3PR01MB11346.jpnprd01.prod.outlook.com>","References":"<20260325182849.84660-1-biju.das.jz@bp.renesas.com>\n <CAMuHMdW5jiR5CqV0xhxio4vtV_bPczO5u1Da86CWJO+=6WU4+Q@mail.gmail.com>","In-Reply-To":"\n <CAMuHMdW5jiR5CqV0xhxio4vtV_bPczO5u1Da86CWJO+=6WU4+Q@mail.gmail.com>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.a=rsa-sha256 header.s=selector1 header.b=XfZIVBhx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34214-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com\n header.b=\"XfZIVBhx\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.229.71","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=bp.renesas.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=bp.renesas.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=bp.renesas.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"TY3PR01MB11346:EE_|TYVPR01MB11229:EE_","x-ms-office365-filtering-correlation-id":"aabbc9ba-6c11-463c-872f-08de8b494742","x-ld-processed":"53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"\n BCL:0;ARA:13230040|1800799024|376014|366016|38070700021|56012099003|22082099003|18002099003;","x-microsoft-antispam-message-info":"\n QP97MTtVJvCCN+LHwVY5uCaUa4Tu4v61SMBvThOjGHQLoZ2vK2vkJdnehhaHvy9ir5WT0/rHZTul4Y/TB2KrKFNHlHxxryx3ULbOeZmLcdIJn9ECKnatDMBGeQ06K38vBwVCS8jXXo1aPqfc6yxMTT+rWDEyq17M0hjtTc/O/8ss5NlqMQG6mB8QsWN1BjO0C5kYWVdrWS96vKIVxas3HBsok2W5Qs3GBkEMPZAVtdCESdOabBJO0ot50hMfcX143abOjXWW+taR0ZFtNrJq8U9nHdytLYvST1e1K5FdFsYRy4S0unAOFSq3OeLvvnn3vAk44ehngPdkpM0J2iiaFKEaKXy8Z5/TpQONANDWz8g+rSKLi8x5Pm3qCDunjC3YVTU2+BgSZoMNS1QTJMNhyg9e325HWW26bTiuB5aqUxRXhYuMmOg0OUYCmFDALLpzzVc242KtQl01riy/Ywotpyb9SQAj/LMaTvlnWW/3IYhP3WyfoIHu+EGxpKSOGBHpKOnYjmN/tC44ephCGICv9i8zToSGAfbp6vKImE+Yl5W3SzlUDmhjjTpvXx+cSEhkeNUkyjiZNWob5zvzpmMLKJ9ASHH2hEuXGOrJOX/tCH9W2N2I64GTaHksRH2mlOdQj/jR3cL0kSxYpebkGaIQReWGNaS+1n3amQseTHm/Tf9NQu5F1YCsJpRlUV9x2cssJE7kqQhu3GKrchbEIHNhRr4tzynTgUOuvF9RsNBttiI8lJiFKrAzX3xfFtrMYbPgTBFY9YU6k6PJ3GERVEqP5TN4GDI2OoBHZWh+vuLx7P8=","x-forefront-antispam-report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY3PR01MB11346.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(38070700021)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?0/a0rTHvUJOBcdZnhkN8gP4pI/0x?=\n\t=?utf-8?q?4G2XrYvtyNlsu0uLJ1G4yMs2oJLgAw77RXJm/1jEJ2rw2oUStB/EDdrLugzBxDv87?=\n\t=?utf-8?q?eeNATwd7D4VO6mUkZOTIxWtsWeudGfMEH2OozVYHcc9WUqofd8Mxzvy1ypg4lXmer?=\n\t=?utf-8?q?s8zpOjrk8vInFVzRN6MUSLAPreH6iTHKB3VXGr3sBD1o0sd0iYD1vH5ft6b0153lH?=\n\t=?utf-8?q?VVnzi9TYK1KI/dtWVBp57PwxbUduw4jawNSF5TRB349LGo/p69hZkAkP5EySOhjqr?=\n\t=?utf-8?q?UwDJfkJCHoEiCZ/GYvwSo3OhJtJTvLBeow3ytyQgeWSIqlYRfunSKrTovgNuSDRCL?=\n\t=?utf-8?q?LosF32dzfl9heFBkmW9k4xaSOrHr83Jvk0g/aJ5dZA1Qq1N9aa+YakRoV6N0MEgPx?=\n\t=?utf-8?q?GE+Ya435UY4ah4VKdbW6SDyGLl8XjyjcttouoJMiVYPJU7R5WWUr4t+71NnxWnsRE?=\n\t=?utf-8?q?HQdb2LP5sd3JJFAdP1u9xa6fwTpALUwKV3l+z0tP+ItPxD8I0RWxZvuD4P5nDHank?=\n\t=?utf-8?q?gbsGeSS1vQZP/yiC0qxOx2bHskTgVre+4GoazTbm9xN2Qhcqbj9weQ+31HfBKzfea?=\n\t=?utf-8?q?G29HOQGN6Tca/N7acdF0QjkQhFjJY8d/sBRnQ0Ym3cFL86WwgprgVh6S32RdwMDcB?=\n\t=?utf-8?q?/tjfI2Sj2UMLMhuWKjH0sVv4+yoa9uEPy+UtCKxswgmFjfLfyhvypppIfnAIYiXED?=\n\t=?utf-8?q?NTemHeYB7g8zKx8Pyw8gy2YKX6C829HPrHHmffYjDHonPEnrwEFN9COo3A/TQljwS?=\n\t=?utf-8?q?JDmFarzTRPaP93dXIkUbM1vJnP/w/3Hkn3zuJGjKjUvyyNc891wWzlVhCxCvp12Jb?=\n\t=?utf-8?q?WPY+gJLGL3NRDKMV3Pd5zHIAPX56Y88o+NueK3a/EWuzImG9w09aNS0sIIAa3ats+?=\n\t=?utf-8?q?VoHxD9504LCOLMbITG4tZpYagRcM1zD99kNroU7IORBNlcERI42iYVhfnxZB2RE53?=\n\t=?utf-8?q?QLW154tweqXMAygQW4gjfZUhMXRt6JJqGIECgonDlrX/a7ij63bIPrA455LKANDSr?=\n\t=?utf-8?q?sKj+Ud8l6Ch3XJdw7O/08E1/ysv5kbq2rTP/jTRo+pnrLs3NOxdwxidEV/xVE9RCa?=\n\t=?utf-8?q?mVa2FIkB0IDH6BKDK4rk5nZH+gn2/b/nl+wLaB0LhZ/uVBgz1+cfOzpGLPfLOOLf2?=\n\t=?utf-8?q?u0yW7Q5msXn2b/ulQ6lgHWEmxjdJd+Bxghkv9soDZBPmcJdfuSQ7IevJFW87usBLp?=\n\t=?utf-8?q?2X1Dygn6y2mrli94dHSGrR1TLzsfXmun4LuSUYKfShOe6QA6RJUqmN+S/QiZnWlG6?=\n\t=?utf-8?q?QPE8pgSvWE/UoGP4CBuvTYYKI9Zu1M1xo3br8j7cUBD4MESvilF8bKpmXYeD8/1+g?=\n\t=?utf-8?q?4MZgE+nixxjKo5VnNWC5z+kaqlYqsaLq8Uxxhfn+ybqc60voFjMIUXpar7mxfjHNB?=\n\t=?utf-8?q?iRpNWwZya/BfdYSyrIvEFj923LIR84/5UogugNJeKUWO6wkV+tDJG/A/cPKvdsnhl?=\n\t=?utf-8?q?EdQrfElWUmKaf6UGZ5ZoYrJPptOB1GA45Hab4EThPIB2VBEc6a/iWPhFTvguPJBti?=\n\t=?utf-8?q?HA14fJ6tIugw1fcJT0F6QDG99KczVwBgQDjzD+/hkH8zf9hshdB+pTuBTq4t1Hpxn?=\n\t=?utf-8?q?F/fiI8Hv0VZx6DjJiACARl0EpIKT6iJ8PcxfqV1CSroqq/3f0xO+u41xx4x7ENxdk?=\n\t=?utf-8?q?+gA/0CLRP+yZUBFgrSlDXUaKk/XoD2JQ=3D=3D?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","X-OriginatorOrg":"bp.renesas.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"TY3PR01MB11346.jpnprd01.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n aabbc9ba-6c11-463c-872f-08de8b494742","X-MS-Exchange-CrossTenant-originalarrivaltime":"26 Mar 2026 15:06:37.7467\n (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"53d82571-da19-47e4-9cb4-625a166a4a2a","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n 0N3RT0VR1kRSyU0qrMPWvXA4z8F9Cp2xj6EOCpLNwBtpacjiiiGtXkZpY81GhDyT35q16YMnVTgtFYwgj+wwm1dzmACWERE4/vm8JBuy0jg=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"TYVPR01MB11229"}}]