[{"id":3669623,"web_url":"http://patchwork.ozlabs.org/comment/3669623/","msgid":"","list_archive_url":null,"date":"2026-03-26T10:33:19","subject":"Re: [PATCH v6 20/27] misc: lan966x_pci: Fix dtso nodes ordering","submitter":{"id":92050,"url":"http://patchwork.ozlabs.org/api/people/92050/","name":"Linus Walleij","email":"linusw@kernel.org"},"content":"Hi Herve,\n\nthis is nitpicking, but if you respin the series consider the following:\n\nOn Wed, Mar 25, 2026 at 3:42 PM Herve Codina wrote:\n>\n> Nodes available in the dtso are not ordered by their unit address.\n>\n> Fix that re-ordering them according to their unit address.\n>\n> Signed-off-by: Herve Codina \n(...)\n> + switch: switch@e0000000 {\n\nRecommended practice is:\n\nethernet-switch@...\n\n> + compatible = \"microchip,lan966x-switch\";\n> + reg = <0xe0000000 0x0100000>,\n> + <0xe2000000 0x0800000>;\n> + reg-names = \"cpu\", \"gcb\";\n> +\n> + interrupt-parent = <&oic>;\n> + interrupts = <12 IRQ_TYPE_LEVEL_HIGH>,\n> + <9 IRQ_TYPE_LEVEL_HIGH>;\n> + interrupt-names = \"xtr\", \"ana\";\n> +\n> + resets = <&reset 0>;\n> + reset-names = \"switch\";\n> +\n> + pinctrl-names = \"default\";\n> + pinctrl-0 = <&tod_pins>;\n> +\n> + ethernet-ports {\n> + #address-cells = <1>;\n> + #size-cells = <0>;\n> +\n> + port0: port@0 {\n\nRecommended practice is:\nethernet-port@...\n\nYours,\nLinus Walleij","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=kLAVn+yy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16797-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"kLAVn+yy\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhL2D1qt7z1y1G\n\tfor ; Thu, 26 Mar 2026 21:42:28 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 8CA6631CD35E\n\tfor ; Thu, 26 Mar 2026 10:33:48 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8F5233DA7E0;\n\tThu, 26 Mar 2026 10:33:32 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EE0173CB2FA\n\tfor ; Thu, 26 Mar 2026 10:33:31 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D0ECCC2BCC4\n\tfor ; Thu, 26 Mar 2026 10:33:31 +0000 (UTC)","by mail-yw1-f170.google.com with SMTP id\n 00721157ae682-7982c3b7dfcso8234347b3.0\n for ; Thu, 26 Mar 2026 03:33:31 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774521212; cv=none;\n b=Z945pAxM8kI7VKe+0dF6VOAIEM9ft+dtwHCEvcrhiQX466kCgnofsJOHSMbDydqrQycaA9Wx1z1GBb+7YdXbAFfqmFFS3tVlh2+YK8YTXuzZy80PA6lp8NEnTQEBtgze+98XE43S6IbaBS+Uz8b507/nuZD+OJ28Hp7WA1rqZKs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774521212; c=relaxed/simple;\n\tbh=ZudevnbvHxuJFNRVUgY0l6TTlPYj57cCXzQfq18RxyU=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=RGND5Tk6sZo1QNAWUHcn9RSbt38jLPeNhR8XF9Cb4S54x6BT6xA9q7QDA9xvhqmDWev3uMpDjXwCa77UJlEbsvthk0ZGFLHAYe1NwaTAsiQ3VuoY1knVUCkYkUrl2M+aZWVkgJABCKeMTovZrAfCWdTH7MmhMsnkuIF2oxKZJ8w=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=kLAVn+yy; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774521211;\n\tbh=ZudevnbvHxuJFNRVUgY0l6TTlPYj57cCXzQfq18RxyU=;\n\th=References:In-Reply-To:From:Date:Subject:To:Cc:From;\n\tb=kLAVn+yyTl/Q8z+UhqbNmfz2LrWrp36HL1Ae4tSkcqPbq1qp3GRw4UjT323vqOUua\n\t 8ahJjFB01lxdM/2KIMuWIT/npAo065XzkAEJITt09khnLhIl+eLEP4WHkDeGlGhT4f\n\t e0aeWHoRGhZBI4R40jiCJ1bYcjad052WCHxrFwLVGoii6XzPg7Pg1HGrPKXJuKh9dZ\n\t FixFToi4dvl3Fnnmk6MV3sIitDaktMkzrAFWZVUVpwagZgrFRx2FtV0UYZvB2u1NgG\n\t sqo55jxPVDBNxHLQcxm2vrGc3ZOgOvS+j+ZAYexlcyf+b06vLqMYU9z3zUlgUTwEUY\n\t w55U+UPZxDs9w==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXqC6e55xx9K1vtzTzEyvIvcDtfRaDB7fOQ104Hg6ysdZwUHTkJ+Ib6te56S/fb9g7h84IFT28uEYI=@vger.kernel.org","X-Gm-Message-State":"AOJu0Yw6EoDbArFoJid+gA2sIrRyK5nc5PCOZikhpRNO+MP0P5SB+HHZ\n\tP2ny/LMFIRpZ9neSQh8X/VG59qpob/Azwgx2TiJsYSOvQFGm1WgZpG79uxtA7UrbuKa3g6UgupZ\n\tOTRPIcmkjNx5CY3/+ViAuvTmVd3rAXQ8=","X-Received":"by 2002:a05:690c:6086:b0:79a:69bc:f20f with SMTP id\n 00721157ae682-79acf3a8b76mr76387137b3.21.1774521210579; Thu, 26 Mar 2026\n 03:33:30 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260325143555.451852-1-herve.codina@bootlin.com>\n <20260325143555.451852-21-herve.codina@bootlin.com>","In-Reply-To":"<20260325143555.451852-21-herve.codina@bootlin.com>","From":"Linus Walleij ","Date":"Thu, 26 Mar 2026 11:33:19 +0100","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzC4i_eE97sXtt89YSs_3fVQUuKW8eO9nnDvhVba5azUhozyRvIt7ceD-wY","Message-ID":"\n ","Subject":"Re: [PATCH v6 20/27] misc: lan966x_pci: Fix dtso nodes ordering","To":"Herve Codina ","Cc":"Andrew Lunn , Rob Herring ,\n\tKrzysztof Kozlowski , Conor Dooley ,\n\tGeert Uytterhoeven ,\n Kalle Niemi ,\n\tMatti Vaittinen ,\n Greg Kroah-Hartman ,\n\t\"Rafael J. Wysocki\" , Danilo Krummrich ,\n Frank Li ,\n\tSascha Hauer ,\n Pengutronix Kernel Team ,\n\tFabio Estevam ,\n Michael Turquette ,\n\tStephen Boyd , Andi Shyti ,\n\tWolfram Sang ,\n Peter Rosin ,\n\tArnd Bergmann , Saravana Kannan ,\n\tBjorn Helgaas ,\n Charles Keepax ,\n\tRichard Fitzgerald ,\n David Rhodes ,\n\tUlf Hansson , Mark Brown ,\n Len Brown ,\n\tAndy Shevchenko ,\n Daniel Scally ,\n\tHeikki Krogerus ,\n\tSakari Ailus ,\n Davidlohr Bueso ,\n\tJonathan Cameron ,\n Dave Jiang ,\n\tAlison Schofield ,\n Vishal Verma ,\n\tIra Weiny , Dan Williams ,\n\tShawn Guo , Wolfram Sang ,\n linux-kernel@vger.kernel.org,\n\tdriver-core@lists.linux.dev, imx@lists.linux.dev,\n\tlinux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,\n\tlinux-i2c@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-pci@vger.kernel.org, linux-sound@vger.kernel.org,\n\tpatches@opensource.cirrus.com, linux-gpio@vger.kernel.org,\n\tlinux-pm@vger.kernel.org, linux-spi@vger.kernel.org,\n\tlinux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org,\n\tAllan Nielsen ,\n Horatiu Vultur ,\n\tSteen Hegelund ,\n Luca Ceresoli ,\n\tThomas Petazzoni ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]