[{"id":3669308,"web_url":"http://patchwork.ozlabs.org/comment/3669308/","msgid":"<20260325201048.GA1291425@bhelgaas>","list_archive_url":null,"date":"2026-03-25T20:10:48","subject":"Re: [PATCH v6 11/27] PCI: of: Use fw_devlink_set_device()","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Wed, Mar 25, 2026 at 03:35:38PM +0100, Herve Codina wrote:\n> The code set directly fwnode.dev field.\n> \n> Use the dedicated fw_devlink_set_device() helper to perform this\n> operation.\n> \n> Signed-off-by: Herve Codina \n> Reviewed-by: Andy Shevchenko \n\nAcked-by: Bjorn Helgaas \n\n> ---\n> drivers/pci/of.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/pci/of.c b/drivers/pci/of.c\n> index 9f8eb5df279e..5fb7f501fd35 100644\n> --- a/drivers/pci/of.c\n> +++ b/drivers/pci/of.c\n> @@ -803,7 +803,7 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)\n> \t * bus. Avoid any new device creation.\n> \t */\n> \tof_node_set_flag(np, OF_POPULATED);\n> -\tnp->fwnode.dev = &bridge->dev;\n> +\tfw_devlink_set_device(&np->fwnode, &bridge->dev);\n> \tfwnode_dev_initialized(&np->fwnode, true);\n> \n> \tret = of_changeset_apply(cset);\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pFmztkEm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16780-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"pFmztkEm\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgyjq2TfZz1y1x\n\tfor ; Thu, 26 Mar 2026 07:11:59 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 19A1D3074A29\n\tfor ; Wed, 25 Mar 2026 20:10:54 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 14F22369235;\n\tWed, 25 Mar 2026 20:10:51 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A4244342CB0;\n\tWed, 25 Mar 2026 20:10:50 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 0804AC4CEF7;\n\tWed, 25 Mar 2026 20:10:50 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774469450; cv=none;\n b=mPxxdlgWuGmJ+rDC17OIowaPvXXIv/NLVLypEbhOQfVNrPTqZxvX0cH1aKp9EwJISlvW13QqxbvU4Lqhni+JTb7JWfiIY6ZSSnxtU7uwL4gEnKKPX88lnSqTi4FKxZgCdxGx1VgmNSxKZFxrkvaAVDAz/flIVwZ7ebphIX/VU4I=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774469450; c=relaxed/simple;\n\tbh=ujRd5LjK5mcsQ8mmgXBul5fE27uXDx8ALFuMg04ypL4=;\n\th=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:\n\t Content-Disposition:In-Reply-To;\n b=ZwC8aBsqWcMHGHiP5dgGjKMtEMkNPISEMpoZooVl4TiJ169aubEU/FndkIvuhr+cea5YrmPWUYultpbmn9VDzbRCT9/ql4zuLlY5tHMsT8ESrAfZL/PVI6G9aYEbS/7LdiN0+Sen3Ub25S8b0TwzYit+Ib+lbumbsCRr6se+knM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=pFmztkEm; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774469450;\n\tbh=ujRd5LjK5mcsQ8mmgXBul5fE27uXDx8ALFuMg04ypL4=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:From;\n\tb=pFmztkEmcFWpgL3kWBx9QwNbkpZBMlusvqoTnjSjBDNyrUVednVv9U0iCioGOuEMX\n\t ohHhvIxQdFYFtSfzQiNpjjyH6hlMHyxfnqAivGCkXB2s9xdf075XPyFm501ilrNH8B\n\t xihJ0JDUVVnu5B78Ln4s8O2PCl6USk7Wa+Tp1KrHj2/mBZZSoX029j56ss3nWDkKIB\n\t hpPNwkJrV8lkjf8pY4CyfKODg13UDaJCOOC8BTTyPcKqfdrH9dKOEPW/q3jeGRM2sX\n\t Ui34HaTivXjTnedeG17USNY6sfInAxwD/PAHKZOKDuLQbEwJgz5d6m6qvH68WFTKin\n\t J7Gx9gxuZ5DvQ==","Date":"Wed, 25 Mar 2026 15:10:48 -0500","From":"Bjorn Helgaas ","To":"Herve Codina ","Cc":"Andrew Lunn , Rob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley ,\n\tGeert Uytterhoeven ,\n\tKalle Niemi ,\n\tMatti Vaittinen ,\n\tGreg Kroah-Hartman ,\n\t\"Rafael J. Wysocki\" ,\n\tDanilo Krummrich , Frank Li ,\n\tSascha Hauer ,\n\tPengutronix Kernel Team ,\n\tFabio Estevam ,\n\tMichael Turquette ,\n\tStephen Boyd , Andi Shyti ,\n\tWolfram Sang ,\n\tPeter Rosin , Arnd Bergmann ,\n\tSaravana Kannan ,\n\tBjorn Helgaas ,\n\tCharles Keepax ,\n\tRichard Fitzgerald ,\n\tDavid Rhodes ,\n\tLinus Walleij ,\n\tUlf Hansson ,\n\tMark Brown , Len Brown ,\n\tAndy Shevchenko ,\n\tDaniel Scally ,\n\tHeikki Krogerus ,\n\tSakari Ailus ,\n\tDavidlohr Bueso ,\n\tJonathan Cameron ,\n\tDave Jiang ,\n\tAlison Schofield ,\n\tVishal Verma ,\n\tIra Weiny ,\n\tDan Williams ,\n\tShawn Guo , Wolfram Sang ,\n\tlinux-kernel@vger.kernel.org, driver-core@lists.linux.dev,\n\timx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,\n\tlinux-clk@vger.kernel.org, linux-i2c@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-sound@vger.kernel.org, patches@opensource.cirrus.com,\n\tlinux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,\n\tlinux-spi@vger.kernel.org, linux-acpi@vger.kernel.org,\n\tlinux-cxl@vger.kernel.org,\n\tAllan Nielsen ,\n\tHoratiu Vultur ,\n\tSteen Hegelund ,\n\tLuca Ceresoli ,\n\tThomas Petazzoni ","Subject":"Re: [PATCH v6 11/27] PCI: of: Use fw_devlink_set_device()","Message-ID":"<20260325201048.GA1291425@bhelgaas>","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260325143555.451852-12-herve.codina@bootlin.com>"}}]