[{"id":3669313,"web_url":"http://patchwork.ozlabs.org/comment/3669313/","msgid":"<20260325201321.GA1291474@bhelgaas>","list_archive_url":null,"date":"2026-03-25T20:13:21","subject":"Re: [PATCH v6 12/27] PCI: of: Set fwnode device of newly created PCI\n device nodes","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Wed, Mar 25, 2026 at 03:35:39PM +0100, Herve Codina wrote:\n> Device-tree node can be created when CONFIG_PCI_DYNAMIC_OF_NODES. Those\n> node are created and filled based on PCI core information but the\n> fwnode device field is not set.\n\ns/Those node are/Those nodes are/\n\n> When later an overlay is applied, this confuses fw_devlink. Indeed,\n> without any device attached to the node, fw_devlink considers that this\n> node will never become a device. When this node is pointed as a\n> supplier, devlink looks at its ancestors in order to find a node with a\n> device that could be used as the supplier.\n> \n> In the PCI use case, this leads to links that wrongly use the PCI root\n> bridge device as the supplier instead of the expected PCI device.\n> \n> Setting the fwnode device to the device of the PCI device allows devlink\n> to use this device as a supplier and so, correct links are created.\n> \n> Signed-off-by: Herve Codina \n\nAcked-by: Bjorn Helgaas \n\n> ---\n> drivers/pci/of.c | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/drivers/pci/of.c b/drivers/pci/of.c\n> index 5fb7f501fd35..b694fcda16b1 100644\n> --- a/drivers/pci/of.c\n> +++ b/drivers/pci/of.c\n> @@ -709,6 +709,13 @@ void of_pci_make_dev_node(struct pci_dev *pdev)\n> \tif (ret)\n> \t\tgoto out_free_node;\n> \n> +\t/*\n> +\t * Set the fwnode device in order to have fw_devlink creating links\n> +\t * pointing to this PCI device instead of walking up to the PCI host\n> +\t * bridge.\n> +\t */\n> +\tfw_devlink_set_device(&np->fwnode, &pdev->dev);\n> +\n> \tret = of_changeset_apply(cset);\n> \tif (ret)\n> \t\tgoto out_free_node;\n> -- \n> 2.53.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Tkz39/YI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16781-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Tkz39/YI\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgyqL1qsNz1yGD\n\tfor ; Thu, 26 Mar 2026 07:16:46 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id B6A04305C2A9\n\tfor ; Wed, 25 Mar 2026 20:13:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 59FC2372668;\n\tWed, 25 Mar 2026 20:13:23 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E682430AAB8;\n\tWed, 25 Mar 2026 20:13:22 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 4C2F0C4CEF7;\n\tWed, 25 Mar 2026 20:13:22 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774469603; cv=none;\n b=GjVhdeR2BeLqRRxTld0UwIHSFG42p4FdOZ2FtjkKYU6JwjUsRSHRd0OAurSTVQ4P9IUnUI5m+nt36qXdR2ppVEIPR70ekMyYI9skRylRsz3qAYnMrl/A85I0xKqCzJgPBbsBqnwziZpjOVlJk8/vmzEirdMClA0t+TW9g+z3968=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774469603; c=relaxed/simple;\n\tbh=jSl4cR/M8opltn/7URZzvWelml/MUa8MCbVkBC5H/7Q=;\n\th=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:\n\t Content-Disposition:In-Reply-To;\n b=qgevVwaaTobrMFsconOqqgZk00nddbSy7VzK3zCYLufblSAyGV1Bsrj78G1b9dZzU1y3Fno2Owu2TH4JtUxSBCUtfwN30GNWnTkP2BF7+ePrL/1d5ZBkrs7XnYyseNAEvjaBv1dKlS74INB0qNBH1NYro0WZV9KStro3EAzbfcU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Tkz39/YI; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774469602;\n\tbh=jSl4cR/M8opltn/7URZzvWelml/MUa8MCbVkBC5H/7Q=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:From;\n\tb=Tkz39/YIGOURtW2ow6h0sqScd2hCTpyVv9CGSZY9qtGWrSrjMUV5SL+I7z/kx260/\n\t 0+RE2w69mycl2mfgjzZeSRZQBe+mUZ/l9N951dkmLGzxXGu2Q+zr+qjLBYDIV894R5\n\t 2WaGAo+2zazNInal2SK6bs14ktm3stdXhU8IlYkwfgW/K5P8YQkf0skh5OzwK3roy5\n\t vRmlJoGDLRnR2uIJMFV7MxtEwL5cJ+oG7yYhXF5yvbEn1eKlvMOUZn0ScMRRHyyhmC\n\t dRG/71EX8DgaOGRpoya2j4xfZeZht+iT2MH99TCE6FYC/om6X7Ujq96H5hBTgb+7n+\n\t osAPLMTcZT91g==","Date":"Wed, 25 Mar 2026 15:13:21 -0500","From":"Bjorn Helgaas ","To":"Herve Codina ","Cc":"Andrew Lunn , Rob Herring ,\n\tKrzysztof Kozlowski ,\n\tConor Dooley ,\n\tGeert Uytterhoeven ,\n\tKalle Niemi ,\n\tMatti Vaittinen ,\n\tGreg Kroah-Hartman ,\n\t\"Rafael J. Wysocki\" ,\n\tDanilo Krummrich , Frank Li ,\n\tSascha Hauer ,\n\tPengutronix Kernel Team ,\n\tFabio Estevam ,\n\tMichael Turquette ,\n\tStephen Boyd , Andi Shyti ,\n\tWolfram Sang ,\n\tPeter Rosin , Arnd Bergmann ,\n\tSaravana Kannan ,\n\tBjorn Helgaas ,\n\tCharles Keepax ,\n\tRichard Fitzgerald ,\n\tDavid Rhodes ,\n\tLinus Walleij ,\n\tUlf Hansson ,\n\tMark Brown , Len Brown ,\n\tAndy Shevchenko ,\n\tDaniel Scally ,\n\tHeikki Krogerus ,\n\tSakari Ailus ,\n\tDavidlohr Bueso ,\n\tJonathan Cameron ,\n\tDave Jiang ,\n\tAlison Schofield ,\n\tVishal Verma ,\n\tIra Weiny ,\n\tDan Williams ,\n\tShawn Guo , Wolfram Sang ,\n\tlinux-kernel@vger.kernel.org, driver-core@lists.linux.dev,\n\timx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,\n\tlinux-clk@vger.kernel.org, linux-i2c@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-pci@vger.kernel.org,\n\tlinux-sound@vger.kernel.org, patches@opensource.cirrus.com,\n\tlinux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,\n\tlinux-spi@vger.kernel.org, linux-acpi@vger.kernel.org,\n\tlinux-cxl@vger.kernel.org,\n\tAllan Nielsen ,\n\tHoratiu Vultur ,\n\tSteen Hegelund ,\n\tLuca Ceresoli ,\n\tThomas Petazzoni ","Subject":"Re: [PATCH v6 12/27] PCI: of: Set fwnode device of newly created PCI\n device nodes","Message-ID":"<20260325201321.GA1291474@bhelgaas>","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260325143555.451852-13-herve.codina@bootlin.com>"}}]