[{"id":3669530,"web_url":"http://patchwork.ozlabs.org/comment/3669530/","msgid":"<20260326-gigantic-tentacled-hornet-cbdb8d@quoll>","list_archive_url":null,"date":"2026-03-26T08:32:51","subject":"Re: [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Wed, Mar 25, 2026 at 01:58:09PM +0000, Jon Hunter wrote:\n> Since commit 030ce919e114 (\"net: stmmac: make sure that ptp_rate is not\n> 0 before configuring timestamping\") was added the following error is\n> observed on Tegra234:\n> \n> ERR KERN tegra-mgbe 6800000.ethernet eth0: Invalid PTP clock rate\n> WARNING KERN tegra-mgbe 6800000.ethernet eth0: PTP init failed\n> \n> It turns out that the Tegra234 device-tree binding defines the PTP ref\n> clock name as 'ptp-ref' and not 'ptp_ref' and the above commit now\n> exposes this and that the PTP clock is not configured correctly.\n> \n> In order to update device-tree to use the correct 'ptp_ref' name, update\n> the Tegra MGBE driver to use 'ptp_ref' by default and fallback to using\n> 'ptp-ref' if 'ptp_ref' is not found.\n> \n> Fixes: d8ca113724e7 (\"net: stmmac: tegra: Add MGBE support\")\n> Signed-off-by: Jon Hunter \n> ---\n> .../net/ethernet/stmicro/stmmac/dwmac-tegra.c | 19 +++++++++++++++++--\n> 1 file changed, 17 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c\n> index b4b39e6a169e..ec18ee46889f 100644\n> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c\n> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c\n> @@ -9,7 +9,7 @@\n> #include \"stmmac_platform.h\"\n> \n> static const char *const mgbe_clks[] = {\n> -\t\"rx-pcs\", \"tx\", \"tx-pcs\", \"mac-divider\", \"mac\", \"mgbe\", \"ptp-ref\", \"mac\"\n> +\t\"rx-pcs\", \"tx\", \"tx-pcs\", \"mac-divider\", \"mac\", \"mgbe\", \"ptp_ref\", \"mac\"\n> };\n> \n> struct tegra_mgbe {\n> @@ -216,6 +216,7 @@ static int tegra_mgbe_probe(struct platform_device *pdev)\n> \tstruct plat_stmmacenet_data *plat;\n> \tstruct stmmac_resources res;\n> \tstruct tegra_mgbe *mgbe;\n> +\tbool use_legacy_ptp;\n> \tint irq, err, i;\n> \tu32 value;\n> \n> @@ -257,9 +258,23 @@ static int tegra_mgbe_probe(struct platform_device *pdev)\n> \tif (!mgbe->clks)\n> \t\treturn -ENOMEM;\n> \n> -\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++)\n> +\t/*\n> +\t * Older device-trees use 'ptp-ref' rather than 'ptp_ref'.\n> +\t * Fall back to the legacy name when 'ptp_ref' is absent.\n> +\t */\n> +\tuse_legacy_ptp = of_property_match_string(pdev->dev.of_node,\n> +\t\t\t\t\t\t \"clock-names\", \"ptp_ref\") < 0;\n> +\n> +\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++) {\n> \t\tmgbe->clks[i].id = mgbe_clks[i];\n> \n> +\t\tif (use_legacy_ptp && !strcmp(mgbe_clks[i], \"ptp_ref\")) {\n\nWhy index 0 is not valid? And why -EINVAL would be considered as legacy\nclock present?\n\n> +\t\t\tdev_warn(mgbe->dev,\n> +\t\t\t\t \"Device-tree update needed for PTP clock!\\n\");\n> +\t\t\tmgbe->clks[i].id = \"ptp-ref\";\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=j5RLwB4m;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13268-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"j5RLwB4m\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhHBH4DrNz1yGD\n\tfor ; Thu, 26 Mar 2026 19:34:15 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 9B38330013BF\n\tfor ; Thu, 26 Mar 2026 08:32:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D3E063AD532;\n\tThu, 26 Mar 2026 08:32:54 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9634128506A;\n\tThu, 26 Mar 2026 08:32:54 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id BADF8C19423;\n\tThu, 26 Mar 2026 08:32:53 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774513974; cv=none;\n b=JZN+kJsrx2euEZDdzzfkdRKObrIisZD6DVd60NQ75C51+Rb4w9VRBYuQGCK3YSKyP4Pvs6hpgcxaoLUF6dhaoIBEpNb0LTMFn0ZTDT58+wtfYXHJYCkKN3Y1rCLWBD+KIR2Cm7mhxAGubTN9mdiAbdtyrg7fUiU0YhzBNhdLTKw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774513974; c=relaxed/simple;\n\tbh=7N6DCs6w4lwaNrc8nplqZYAKIoynQ0BIoe3R98tHZo8=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=fHUOqRPNeFRt+rA04MggF6nQUCkYxNSJOwq8hRi8IvSn+zTg50HtYh4WgncN2u1oxMzOtxNRamBghqlZ6ngVmvGUHC2dfgtAN9uzvfs3j41QxSq+2jVCyjVAWeWw8cHMl1mZ8CNtgaP2TQyj8Iv7FWuNC8pJ3rsvrSZxXiB0W5k=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=j5RLwB4m; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774513974;\n\tbh=7N6DCs6w4lwaNrc8nplqZYAKIoynQ0BIoe3R98tHZo8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=j5RLwB4mhSjAIbIkojluWbsyoV5NJ8KnCXPIRLdGJowWFWZ6zi8iN0C2sWJ+/IENT\n\t 64ZGKgjnh3Q0D2BYQJ0gHui4P4WPjnPXb9I97NqAqsmF6/Gxjy/R6CABPzFucg6tZk\n\t ObGqjd1m9KFjITbk+Fuc1DcbKtGYTBBD/SE+DXiuD+7JrSs3b760mCaljM0lTOQqj4\n\t h8Way9dg8eOJohLIp4ss+wFBKvOeUrdXX7aUioOxzS0ND39ZHBjl+7O7Rur8psRVAG\n\t CpoDqH06ONCM565L+wa204itAZx3kYLOsitmc35115imWAuNGSiKDlzAWEIUZGg482\n\t co2W62RVQRMiw==","Date":"Thu, 26 Mar 2026 09:32:51 +0100","From":"Krzysztof Kozlowski ","To":"Jon Hunter ","Cc":"Andrew Lunn ,\n\t\"David S . Miller\" , Eric Dumazet ,\n\tJakub Kicinski , Paolo Abeni ,\n Rob Herring ,\n\tKrzysztof Kozlowski , Conor Dooley ,\n\tThierry Reding , netdev@vger.kernel.org,\n devicetree@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org","Subject":"Re: [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234","Message-ID":"<20260326-gigantic-tentacled-hornet-cbdb8d@quoll>","References":"<20260325135811.148480-1-jonathanh@nvidia.com>\n <20260325135811.148480-2-jonathanh@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260325135811.148480-2-jonathanh@nvidia.com>"}},{"id":3671593,"web_url":"http://patchwork.ozlabs.org/comment/3671593/","msgid":"<01f56e6f-5459-4a96-9042-8a003a340fab@nvidia.com>","list_archive_url":null,"date":"2026-03-31T10:14:18","subject":"Re: [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 26/03/2026 08:32, Krzysztof Kozlowski wrote:\n\n...\n\n>> @@ -257,9 +258,23 @@ static int tegra_mgbe_probe(struct platform_device *pdev)\n>> \tif (!mgbe->clks)\n>> \t\treturn -ENOMEM;\n>> \n>> -\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++)\n>> +\t/*\n>> +\t * Older device-trees use 'ptp-ref' rather than 'ptp_ref'.\n>> +\t * Fall back to the legacy name when 'ptp_ref' is absent.\n>> +\t */\n>> +\tuse_legacy_ptp = of_property_match_string(pdev->dev.of_node,\n>> +\t\t\t\t\t\t \"clock-names\", \"ptp_ref\") < 0;\n>> +\n>> +\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++) {\n>> \t\tmgbe->clks[i].id = mgbe_clks[i];\n>> \n>> +\t\tif (use_legacy_ptp && !strcmp(mgbe_clks[i], \"ptp_ref\")) {\n> \n> Why index 0 is not valid? And why -EINVAL would be considered as legacy\n> clock present?\n\nIndex 0 is valid. However, yes I guess that treating an -EINVAL from \nof_property_match_string() is not correct. I will switch the logic to be ...\n\n use_legacy_ptp = of_property_match_string(pdev->dev.of_node,\n \"clock-names\", \"ptp-ref\") >= 0;\n\nJon","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=mcMVOstl;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13469-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"mcMVOstl\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.93.201.58","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flPLJ5YyTz1xtJ\n\tfor ; Tue, 31 Mar 2026 21:22:00 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id D03EA306911A\n\tfor ; Tue, 31 Mar 2026 10:14:29 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7DA0F3E9293;\n\tTue, 31 Mar 2026 10:14:29 +0000 (UTC)","from CY3PR05CU001.outbound.protection.outlook.com\n (mail-westcentralusazon11013058.outbound.protection.outlook.com\n [40.93.201.58])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 083D83EDAD4;\n\tTue, 31 Mar 2026 10:14:27 +0000 (UTC)","from DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12)\n by CH3PR12MB8994.namprd12.prod.outlook.com (2603:10b6:610:171::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.15; Tue, 31 Mar\n 2026 10:14:23 +0000","from DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391]) by DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391%6]) with mapi id 15.20.9769.014; Tue, 31 Mar 2026\n 10:14:23 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774952069; cv=fail;\n b=B95wBim54rHT0tLcdbo5+jjsN++ce+q8l62Zb9Awe3opCahBQvyHcdZXJUrs9yHhBdi/ca3cWumT061aqjYPY84jFUhJwytFpLRAQ/tQoPrTnjES+wZiXw13x0mZxez/z3dIFt42TqQt7OwgPacDkoOzUz0iSNMPFq527DEi9As=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=KBtaj8dRI+10UcGZyVhRFgtZJU7Gm/cEYlpzwSoQbFO7K6OFaL5lWQOlI5coeBK4vYZQCH8ZZKuXjj/5xE0OcOmFHxArT+l97Upska6O5HjUYhw3F0SDGEReRx9A2sysjB9Lef3CdXLiHkTQU1dv7JlV9koKdwC5AIRHkpIlHOPpMM39afWfgrBteuy7yK6ZvjHtGOV9eKg6t2TUF6/72LZCZY53adYltZdgdT31Q6whQO5JTG6OiSPb3ty/uDMsTnCKBtwBFLSaWHm8JdUWWfR5iqRWLItAUtHG9YISE4edyw+1WaOG2KZNca+1s1kFg6wbQjbhMFXsdnXHe6lTmQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774952069; c=relaxed/simple;\n\tbh=xe9DZiRT3J1RncW+IFNUCewpaXpyMteS7xMOYXAX1o4=;\n\th=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=CV/8nVKgjQPbaWKXx8A9NRelNvdYIlPfy2FGG+lWAvE/WNGKpT2SPLSPRbEmvV1PnYpSytDa4Ix+bjVg3GcG3ncl/k61+D9ZCqXJYDSuLcdOxvSE/GBLINS6PsJ8F/l1svZBtALFSaTW/UAQwiywYz+r67/aq1PGF4ENSeB8zes=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=iED0JzlCmwdnBpBXlbxQSqeh2mJWHRAma4fnENG9DKM=;\n b=P6EYNHLZpdbgtQ0etfvjTMkxdhxkgoFbRWE6cygkDXA58RXPVBTYZw5iAsK5BuoXb7IXplUYgLwjJJJBs+0TM4wRPoeluMb2RnFh9yrPqv7zqvpP6ouhrSXm7gS1Zxw5g41wXhwkJ+Th5ykSe0rTKvLn8EX0sET1h6Ln0ujztULR/dZ7wdyM1OsAjTTdRz77tvcht2gcDhVb/1oAj28fp+NkJj1KsHK3IwFuh52obaAQHznDKc2guJOY857HHVYpzxooDpLWKGi8iZ293pL739DKCoI7aFDy87y/CJlBnSVD34Zh+tK7ew5x1IkKUq6KoJxPIbsK8R0tCerwYjYVQA=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=mcMVOstl; arc=fail smtp.client-ip=40.93.201.58","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=iED0JzlCmwdnBpBXlbxQSqeh2mJWHRAma4fnENG9DKM=;\n b=mcMVOstlV2Hf42aENQSGQ74nkDjVaHh96jIzM5Ts+6iYw8CIWSOcoaaWqwImfeofJS6HBcPwrU8DR5GXEqmadqrlB28ELRJiw69djdoqbUARrfteB6+PLR4no/9+XB4h0XgzEdJbaX8plwaUP01BCyZlFcp+JKH89fhgPh9BBvxLVV3l/TC5HXwzFEpa81AMDZobkJ8PSrtRqsdC2mFcFqfwsvaeR5/+mUCL/x9zJhX3xI5qQu2S8pc3RqzsDnH2be1AlxwjhfS15hTRWZpmydpJHV+Ibk6Jl2Up2u8Wqe+fPJC7uqq61I4SwBdzRFGa3Cp0ZKxD/to3z5XTm9i4Ww==","Message-ID":"<01f56e6f-5459-4a96-9042-8a003a340fab@nvidia.com>","Date":"Tue, 31 Mar 2026 11:14:18 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234","To":"Krzysztof Kozlowski ","Cc":"Andrew Lunn ,\n \"David S . Miller\" , Eric Dumazet\n , Jakub Kicinski ,\n Paolo Abeni , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley\n , Thierry Reding ,\n netdev@vger.kernel.org, devicetree@vger.kernel.org,\n linux-tegra@vger.kernel.org","References":"<20260325135811.148480-1-jonathanh@nvidia.com>\n <20260325135811.148480-2-jonathanh@nvidia.com>\n <20260326-gigantic-tentacled-hornet-cbdb8d@quoll>","From":"Jon Hunter ","Content-Language":"en-US","In-Reply-To":"<20260326-gigantic-tentacled-hornet-cbdb8d@quoll>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"LO4P123CA0606.GBRP123.PROD.OUTLOOK.COM\n (2603:10a6:600:314::14) To DS2PR12MB9750.namprd12.prod.outlook.com\n (2603:10b6:8:2b0::12)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS2PR12MB9750:EE_|CH3PR12MB8994:EE_","X-MS-Office365-Filtering-Correlation-Id":"fea1f55d-f4bd-418e-677e-08de8f0e4801","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|366016|7416014|376014|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n\tMJMqi5oOusXILGWhIeNV7pznos66GA+mcXeUQW2JDM8pjsTGA3VMFSRT+hshH1/TY8BnCC1XLV6LUvg4LKL/FLtWKNDxsfQRxnG2jaeGbUuynuv7zLcYP6QrDFqyrBqcxINImdYdTL5qwhbuFORqet0T4vWGgDnWi9Si8AD1alc3AwYF4w2xYLpMxbXwlequQ9r9OPvkXC82LyCGcobR5GIzOJcMSXECLRTR/bfcWqYxgfuwTK6blr128UtOzY76EuZif0FqkqC6Bg4rUUGYGB03nA5UHp/OrpX7IiQ0/8nDYWhYNUJflYIPZ/0QTExKQXMvg4HNR8TJdOO71k9+kXTdhyp3hubcgyCZeVbHppuYh2zAr5D4KfzW8ODteDdcRIBo9LJeiV35obvSAAlWDep/uxegnawCcwXeGKHxIACfOGEsaKeVNtxiR3tZ/mbhVddkD2S4KyII971AZgFXkp66Xr/gm/+pQcXBhFm4HQs+CysiUdSTNOgOX9GVa82D3Vn9z5zYsQzjUQHOSala2VMEGuvpJ918iUPGg8sKekMHaVfgoYEONLeSXtHu5YCxgAxmdZxxxefn9P/gAplU7u6/6efiB4UVo9Nfm+id3aicNG2M1RnLrU4YV1i08mXGCuWcA2+A5+7fnvoAfSB6vSjLhY+MvpKtoFwAlkWWECbFsNttPHcRr1mejLKCTGWz4N7PjG+1KSe+WJGWBhEEVQ3FQ4ybAqrzpIW+ZqSaRME=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9750.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?uYGv3gn+kl2aa36x/+D92P6dh8er?=\n\t=?utf-8?q?DvBrjmmgcG//i/yMdsK+ip/onzAnqTjP7uUuwFLfX/2Xsf5fhxMw0E8LlvRHKtFPj?=\n\t=?utf-8?q?hmIs78pfw5o7kJo/gynwwIs/Xw69h/zFqe2C05XHzOgz78iwbrUXL/W7MiAHzMBZJ?=\n\t=?utf-8?q?jOwBC/ZWYJzA3Aq9KwpMscI7r78X7bFG9fwbcBWVLOMcvsYfFecXv+N3NHpHc71ow?=\n\t=?utf-8?q?NdAVFYNgCJJ+dFUiNdauN+Ws7PtjtYmnvqMFBq9Btr49mmHcO1KqMpXwt1lOrHvC7?=\n\t=?utf-8?q?QpT5/PJplG+f0DNM80imYKMcln/3FuMjAQt8oh94hPJMgnqcplKBjIuKjyFTp5LCb?=\n\t=?utf-8?q?mhxS9h1W+SnLQ/nKda8G94x/giWOtVRvnJwwWf5iAnNNiTd1nzuoJQdvj0jaD9kvf?=\n\t=?utf-8?q?o1k5bUN6sH2nGZ5x5YDwGewdRzdhYXo8S7vKuCgGMVraZjKISL+3Ssh8j1DinFBUz?=\n\t=?utf-8?q?QuesGbmscz6DbgYCTPy4tFYjEObbb9G0K0aUnDZlGLdCRqSCxwDHlLpW8hysbg8aF?=\n\t=?utf-8?q?w43gmeIGKCSZLaUztqISwM2u1yONyb4t0vjwAl1qfptFK2PbXvyArMTACOJWETN1w?=\n\t=?utf-8?q?GJs2QIJfyAzQ59QsEsqYPP/0cQOMM/2RFj9TkeRuurl40/ukwySynTrtEA3+tzobM?=\n\t=?utf-8?q?BoVE2F8E24WE+efajDIBc3cMiNGnzji5GvS+ZoDfq1o1rLh009iwHkoKTHITK56SK?=\n\t=?utf-8?q?MDKA/Aoh3dpElshlg1vlZsS6rjAq9pwAvuVLYJ0SJxqJy7s+QM5Pe8DOKKF/4uFqC?=\n\t=?utf-8?q?dlRJ+PztJk1T1tw8dwGnMSOJ5sT/ISMryRLTXVWVJk8N+U1lBmQXvKRjZTNenSKF1?=\n\t=?utf-8?q?DXLlxWfTl1jX34CNxwKfIGxB30rxzKbbK3h7acU1zGhkuCJhHpP1GxOLbUU1A1m8j?=\n\t=?utf-8?q?aZlRXkGOCgQK852lSWfz1x82Ri9RE7ueEr2X5vQk4zkgUvi5msDNwYwnX/bizjSP6?=\n\t=?utf-8?q?16Vut6DzMWsEe1A5M4wyuQU05sEhHe+tC8OiGDBUE8YvxhZ+U/XC1kB+nv0L12m63?=\n\t=?utf-8?q?RwENm4Y7SN7kjq0lIlI/qYGORt2bYHB+XfXan2F42G9Ycolp2mtz3ND5Du4ljBcXO?=\n\t=?utf-8?q?FiE/cW4gvIcVDVVq0SkIcO1OIEIi0zJl1KmX7kUbzcbvnZtmtFIfQljSo+lNoiNXa?=\n\t=?utf-8?q?DcSw35lCi1xFmIDacvF9KIzzDnj24Lh9wgnBAcdZt76JhQvJvR9S3foNLdk0zCjTt?=\n\t=?utf-8?q?H8xW3OupA0mk+xDGo+eY9yNkasMIPhXXrt+dk1TRlWyGCtTy3qzjEU7i/8/o6Zmv8?=\n\t=?utf-8?q?9PTF+1ka1kt8Olz9c7g07UqA2sm8T/2LeJYk2DxgTrxyHb9ud1BdcaBC/4DIxO08+?=\n\t=?utf-8?q?sNBEJQrUn7EpZhFh+rndTc6NvFuIDUMwh9MeCd/ENSHXcgT1PjLz7ThY295jbGEF4?=\n\t=?utf-8?q?s/RoI0MNEy+nVnyBOaAMMPddG82CQ2DLhe3ui4w0PAE0egbDo8N03i1/r4HcNsXZw?=\n\t=?utf-8?q?bQd7xVpgteM8W+aLHZl0bcscbso3jhdAAJsMtxKD4sb72JsSzRy5tNuB8XKUB0uJ2?=\n\t=?utf-8?q?zmKwczYPCVL6MTMr5tX24pOZhGwxjJf4Hci8s9bOSq8smXh4CSDX65FBuhOP7CrIQ?=\n\t=?utf-8?q?OiOB8JmKAdl6bC/loMRrtYCr+7LXkGHTi4WmcTW6vl8t2f9l/hJyq+6BB1bvvJQXJ?=\n\t=?utf-8?q?U6w51crZaUnLcuAtTQVGZcdccfkPafFQ=3D=3D?=","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n fea1f55d-f4bd-418e-677e-08de8f0e4801","X-MS-Exchange-CrossTenant-AuthSource":"DS2PR12MB9750.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Mar 2026 10:14:23.4495\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n rCjX2fFcPEBis1YoKPWRTnFy6Qwn6Xc6c3bgDZEGA/qil9ZcDE1fJcA6p7rfV5V5QPRXfSTIC8/BPi1UMknrmw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH3PR12MB8994"}},{"id":3671595,"web_url":"http://patchwork.ozlabs.org/comment/3671595/","msgid":"<5b3eaba5-eba2-43f9-8ef5-d305ca50ddf0@kernel.org>","list_archive_url":null,"date":"2026-03-31T10:18:01","subject":"Re: [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On 31/03/2026 12:14, Jon Hunter wrote:\n> \n> On 26/03/2026 08:32, Krzysztof Kozlowski wrote:\n> \n> ...\n> \n>>> @@ -257,9 +258,23 @@ static int tegra_mgbe_probe(struct platform_device *pdev)\n>>> \tif (!mgbe->clks)\n>>> \t\treturn -ENOMEM;\n>>> \n>>> -\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++)\n>>> +\t/*\n>>> +\t * Older device-trees use 'ptp-ref' rather than 'ptp_ref'.\n>>> +\t * Fall back to the legacy name when 'ptp_ref' is absent.\n>>> +\t */\n>>> +\tuse_legacy_ptp = of_property_match_string(pdev->dev.of_node,\n>>> +\t\t\t\t\t\t \"clock-names\", \"ptp_ref\") < 0;\n>>> +\n>>> +\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++) {\n>>> \t\tmgbe->clks[i].id = mgbe_clks[i];\n>>> \n>>> +\t\tif (use_legacy_ptp && !strcmp(mgbe_clks[i], \"ptp_ref\")) {\n>>\n>> Why index 0 is not valid? And why -EINVAL would be considered as legacy\n>> clock present?\n> \n> Index 0 is valid. However, yes I guess that treating an -EINVAL from \n> of_property_match_string() is not correct. I will switch the logic to be ...\n> \n> use_legacy_ptp = of_property_match_string(pdev->dev.of_node,\n> \"clock-names\", \"ptp-ref\") >= 0;\n\nNo, apologies, I think my comment was not correct and your reply made me\nrethink. I missed final \"< 0\" in of_property_match_string().\n\nSo the code is good, you do not store index in 'use_legacy_ptp', but the\nerror return value.\n\nCan you however make it more obvious code, so something like:\n\nif (of_property_match_string...))\n\tuse_legacy_ptp = true;;\n\n\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pCO7wA3S;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13470-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"pCO7wA3S\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flPPq70crz1xtJ\n\tfor ; Tue, 31 Mar 2026 21:25:03 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 0602430036E8\n\tfor ; Tue, 31 Mar 2026 10:18:08 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2B89B3E95B2;\n\tTue, 31 Mar 2026 10:18:07 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E03F63A9DB5;\n\tTue, 31 Mar 2026 10:18:06 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id CBBB3C19423;\n\tTue, 31 Mar 2026 10:18:03 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774952287; cv=none;\n b=e0YIcL0w2ouuf90NGXWZG4ZzNNNfDzV3KTSsD1TQgGDXEGvNAv4DK6ci+xHHIdGZ1c2PKNtgQAuZSFaFuJp1PskPWsXvvwLFBFUOo5LP8DThLMmyBQouaJCn9cf54Mwjwx9Zj2BS9N4FA1exYCcBXUVFZo3EfZT87yCEFkZwxCc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774952287; c=relaxed/simple;\n\tbh=UfnCUS1B045T6Jje4Q/g4OmqqOXfLZGiks3Jd6gia+U=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=CsTQhXncggrXxbn6OqaFWp1v4FNamixvW6w1GYMyGeSfmogoxn/0vDk/rqmCTrzFlaCY7692rcF8D4DyJl55icKM32C9r9TwYHAaQ2OB3f65ddY6GB149ArY2A+vB3ZpD/pDf/EsMMQWYM3ntqEIocBgKuhLwuDXO7WNibnBdLE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=pCO7wA3S; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774952286;\n\tbh=UfnCUS1B045T6Jje4Q/g4OmqqOXfLZGiks3Jd6gia+U=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=pCO7wA3SruUGVcT08Q5ZzFKnXjBvTCLft3TIorP9G/1enn3KNqyd602skGtKV48v5\n\t 2tTH4IN1T5PMcWL0ZCeRIOyzLHFaU7St+bzVqjj4M3q1d8TmCasEDdjcR+M+gu/uI6\n\t f3CP2Tsj9U8RLja+8kX8COHidczSRgKn3ObDKANKTxS0af70t8G1EfTqHoszo9GQfq\n\t +vcURX/L04EhhmzJeazpp+0IPh1E1Q6RzYCtY4T11SEsAhOZj0SvFe8FZ21nedEHKu\n\t M+n3mIoN3TGOpz4sdZlMmhCCopgS0rVhOnBpkuRVRroc+AWyLlRSSRjL3pZrd5OYhs\n\t 9EcOgv6Wn4xiw==","Message-ID":"<5b3eaba5-eba2-43f9-8ef5-d305ca50ddf0@kernel.org>","Date":"Tue, 31 Mar 2026 12:18:01 +0200","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234","To":"Jon Hunter ","Cc":"Andrew Lunn ,\n \"David S . Miller\" , Eric Dumazet\n , Jakub Kicinski ,\n Paolo Abeni , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley\n , Thierry Reding ,\n netdev@vger.kernel.org, devicetree@vger.kernel.org,\n linux-tegra@vger.kernel.org","References":"<20260325135811.148480-1-jonathanh@nvidia.com>\n <20260325135811.148480-2-jonathanh@nvidia.com>\n <20260326-gigantic-tentacled-hornet-cbdb8d@quoll>\n <01f56e6f-5459-4a96-9042-8a003a340fab@nvidia.com>","From":"Krzysztof Kozlowski ","Content-Language":"en-US","Autocrypt":"addr=krzk@kernel.org; keydata=\n xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79\n cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu\n JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH\n gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE\n J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj\n NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS\n BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU\n vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM\n Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD\n TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg\n S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE\n FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307\n QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp\n +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl\n ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy\n 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN\n hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi\n tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL\n 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn\n naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd\n hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k\n whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3\n Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue\n MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei\n OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA\n GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA\n 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9\n YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt\n 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU\n BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/\n JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu\n 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB\n YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v\n qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5\n RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg\n Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2\n H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB\n dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT\n AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu\n jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2\n zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw\n XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A=","In-Reply-To":"<01f56e6f-5459-4a96-9042-8a003a340fab@nvidia.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}},{"id":3671606,"web_url":"http://patchwork.ozlabs.org/comment/3671606/","msgid":"<75e60c8f-ddb8-474c-961b-bc1d8faa48a3@nvidia.com>","list_archive_url":null,"date":"2026-03-31T10:48:04","subject":"Re: [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 31/03/2026 11:18, Krzysztof Kozlowski wrote:\n> On 31/03/2026 12:14, Jon Hunter wrote:\n>>\n>> On 26/03/2026 08:32, Krzysztof Kozlowski wrote:\n>>\n>> ...\n>>\n>>>> @@ -257,9 +258,23 @@ static int tegra_mgbe_probe(struct platform_device *pdev)\n>>>> \tif (!mgbe->clks)\n>>>> \t\treturn -ENOMEM;\n>>>> \n>>>> -\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++)\n>>>> +\t/*\n>>>> +\t * Older device-trees use 'ptp-ref' rather than 'ptp_ref'.\n>>>> +\t * Fall back to the legacy name when 'ptp_ref' is absent.\n>>>> +\t */\n>>>> +\tuse_legacy_ptp = of_property_match_string(pdev->dev.of_node,\n>>>> +\t\t\t\t\t\t \"clock-names\", \"ptp_ref\") < 0;\n>>>> +\n>>>> +\tfor (i = 0; i < ARRAY_SIZE(mgbe_clks); i++) {\n>>>> \t\tmgbe->clks[i].id = mgbe_clks[i];\n>>>> \n>>>> +\t\tif (use_legacy_ptp && !strcmp(mgbe_clks[i], \"ptp_ref\")) {\n>>>\n>>> Why index 0 is not valid? And why -EINVAL would be considered as legacy\n>>> clock present?\n>>\n>> Index 0 is valid. However, yes I guess that treating an -EINVAL from\n>> of_property_match_string() is not correct. I will switch the logic to be ...\n>>\n>> use_legacy_ptp = of_property_match_string(pdev->dev.of_node,\n>> \"clock-names\", \"ptp-ref\") >= 0;\n> \n> No, apologies, I think my comment was not correct and your reply made me\n> rethink. I missed final \"< 0\" in of_property_match_string().\n> \n> So the code is good, you do not store index in 'use_legacy_ptp', but the\n> error return value.\n> \n> Can you however make it more obvious code, so something like:\n> \n> if (of_property_match_string...))\n> \tuse_legacy_ptp = true;;\n\nYes I can do that. Before I was avoiding the need to pre-initialise the \nvariable, but I am happy either way to get this fixed!\n\nJon","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=BnVQ9Kl3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13482-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"BnVQ9Kl3\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.61.38","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flQ882X3bz1y1q\n\tfor ; Tue, 31 Mar 2026 21:58:16 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 0DD3930419BE\n\tfor ; Tue, 31 Mar 2026 10:48:17 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 44FFD3A9D96;\n\tTue, 31 Mar 2026 10:48:16 +0000 (UTC)","from DM1PR04CU001.outbound.protection.outlook.com\n (mail-centralusazon11010038.outbound.protection.outlook.com [52.101.61.38])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C88287259;\n\tTue, 31 Mar 2026 10:48:14 +0000 (UTC)","from DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12)\n by CH2PR12MB4245.namprd12.prod.outlook.com (2603:10b6:610:af::15) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.15; Tue, 31 Mar\n 2026 10:48:10 +0000","from DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391]) by DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391%6]) with mapi id 15.20.9769.014; Tue, 31 Mar 2026\n 10:48:10 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774954096; cv=fail;\n b=T5He0IEAp6QM8F9Q4IgCQ/KqKF7tpqZbuaqVjeiWuAm0E1YwRihE8US5KpVfiyFPQDTZpDukYXbKugocjvdFoxx+pBIInEYZ6T5NgbMmwEJTSBcbMYVlM/7IXXX9e+DvK/ZtOAfDel2REQ7q1GJI/6qKEJoKWmT7X0M/ioBEr8Q=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=UShBbnmPO0A1asBruAzhxj6qlGsbi6PLzAGEvd8JBBwFKYOzatpmgO9wErf3lMmjIU1sYblgUE9am/0DDxNra5aKqCR0av3LDUvWRDeJVC6hCFwV9XuQaz4SZF/60mP7nFOyduvXJv+8qi+zU/RLNDtf59TYNw8E2R/Hu616w9BRMg9bW803QcToYdXjuUCpVEPp2WOMbrx4kSnAa/CYa9s14LFoGsPYbXoAQtqwvbHK+dtTgTUcOIRPv3Io0mKTwR8zuNPwAK2TLuGQZbkX2psrENmBFq6fnjs1BqI0UiaEDDXEeybDnDEMM5TBx+FJk8Nj/oihtJRanY91NhdGbg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774954096; c=relaxed/simple;\n\tbh=v1+QLvUw8Gmsz02DYbFCo3gd8IRwKlReEsxgkY8o2wI=;\n\th=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=okifXhxVtdCcJz1kVIdvqlpihRI7PlShQ9ajSLzK39slhu2lNA8HvkaUb7eyiBIio+Uyo1jsEfM0hVUrecUui1Y2Sx6bSYcSpNrihO7oWa9tROwVqu4IcgRTTIkuPZlNHDSG0IfZ2WelP2P7qyP8UbkJhtTiEmrvoRZ4/CThwmU=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=p+WKKnF9ZMyK8yya3iQNB1dP36UmKlQ5DzQqoCYHv2E=;\n b=UhsojjMAWKPaUuoGefVWdSU/k6nZ2hc2m46JRCqLsxcpzgWQjZWbi/SXQtiFxBUYuFrfh3BA0RbwH46XXlkSPM9nS0gqfR2ss8Sv5cDULD7va7jJr8oXYBF+5WV4fZulX8Gg2FPz1iN68KWMNOfe5MsRaItVgrMS19CFFTYw29iUJOdIeYqJ7nbF5tvqeGa6rZztHCmoISCi365J4QiFzEROkHmsOgYn1FQsSeNaFkQtPWGP2LzqTc4kyTilNdrCFxl4/UMShdglvIl0YL8duAsUsVtFv/p3kIUsqdC4EVYiRjewBDabGNaM9K+bVBbbtDmT0uBu23tn36nn/oMf1w=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=BnVQ9Kl3; arc=fail smtp.client-ip=52.101.61.38","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=p+WKKnF9ZMyK8yya3iQNB1dP36UmKlQ5DzQqoCYHv2E=;\n b=BnVQ9Kl3iA45VX/opEAAsH9fyNZASh848HtcT9PEwujt5o49pw1B95PKyrS/itx4Z0FIRwMjIA0up+wQmUfb27j8wKnxqwAiWsQ6oFrBDMXr0L17xhZKafgUEGoM1SfTUtfWtu6jORG1UJja/iWWrgWK/8q+Pl+CX3+Q9kz9SgHJ3NC+q36yLiFdItvSv0fBfqOCeElWOB8VtmMJNuveP9EZ95YguZUorO+pLpRyp6THRqUWiddDnVqJ28bdwId4AbaCxBU/QABrk5zu9nZxsxauohNIs39P4g0q/YeyjVH+RJKiHUC7xmvTQphFPCjC4eCaqKFQx5/xdAw6CKn5Rw==","Message-ID":"<75e60c8f-ddb8-474c-961b-bc1d8faa48a3@nvidia.com>","Date":"Tue, 31 Mar 2026 11:48:04 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234","To":"Krzysztof Kozlowski ","Cc":"Andrew Lunn ,\n \"David S . Miller\" , Eric Dumazet\n , Jakub Kicinski ,\n Paolo Abeni , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley\n , Thierry Reding ,\n netdev@vger.kernel.org, devicetree@vger.kernel.org,\n linux-tegra@vger.kernel.org","References":"<20260325135811.148480-1-jonathanh@nvidia.com>\n <20260325135811.148480-2-jonathanh@nvidia.com>\n <20260326-gigantic-tentacled-hornet-cbdb8d@quoll>\n <01f56e6f-5459-4a96-9042-8a003a340fab@nvidia.com>\n <5b3eaba5-eba2-43f9-8ef5-d305ca50ddf0@kernel.org>","From":"Jon Hunter ","Content-Language":"en-US","In-Reply-To":"<5b3eaba5-eba2-43f9-8ef5-d305ca50ddf0@kernel.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"PA7P264CA0212.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:102:374::9) To DS2PR12MB9750.namprd12.prod.outlook.com\n (2603:10b6:8:2b0::12)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS2PR12MB9750:EE_|CH2PR12MB4245:EE_","X-MS-Office365-Filtering-Correlation-Id":"519b3028-1961-465d-d973-08de8f12fffd","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|366016|376014|7416014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\tz/P4vrzBv53TX7xWswIEOdhUWBBffSOjjF50h7W4mSPDqevM/vkzV0k3BToP1XI7xZ16JOjei/628dt+pk37mfaZW/E3clmvEIWDWNQVTPE4xdeQNSIAKxekLUtIzX2BcqQyrcSMT1FBuJ9OGWOwOnQRslvsoAZtrmhnLwGytpROk/oGpsHKH1EDizNBifusrbRppaezIrl6PglD7/I117wz8F1Ujehr2dRdVqo9J9gUvbe9O5t6DuPlfdnAniRw7LOJl/MZylFr4TjFUKlGlaIYzUeXCd7HRPZ5ynrSBS7g4uhsTP3KoW4/2ykNuZPt40yVoVf78rNsBnkTtozVd9BpNeA//U1AKEDBnyQVFO6FuvXvtyLm8WGiRL2xdjLms+JcuSSK2gU5dOhCI5Yp3+dOmDzgGpaMSK7h4Ihr3T6v2r8FQa2ofrmeK7i3vYrfSx+MFO92pxtBnoBQxApHXkRoEJsrtYS49ySUglYbF2bvJ8Ffbva0PcdlTYo0PRxlDvyI4uyx5vOquBd7lssnwmFVmTiSsTpLbRVL5hO58m85m35LP1YuH6R7z1854JOnb6v15u+ilQEtFtmx79WmA85nOjypVR1+AtDZekyoaQNrL+MJncLQ7Sp1/umlZRnpEOMYO4sScRE1kd9FwX+ztMSnEc04aq3V1GAf7xjBtZnnfkVdFXVKZM7MqNQox8CD9ocHOINuCYrCkaWIMkXk+8lrTDMO9g8vG4fRcQX7Sgo=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9750.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?qxnYgvD5/ShjXpAMgubLQUea9Dwj?=\n\t=?utf-8?q?T/WyznBsOx+jceZLM2q/Or08rkjPle3O5gFJboRpJlmI5VFhqAL9ewLugUDUlKehl?=\n\t=?utf-8?q?Ih4EW1lLI3Se/m5dJCyhR1PUViC+bHlp0olV9a3fsnQcORHAArKr/x5SN+FHCP0yc?=\n\t=?utf-8?q?AcIDcPXQLrcrKwyYjZ3F0aPc8QjuO8Q7XPjg+ltf2di43g555JEgGn2/UiKSi9+UW?=\n\t=?utf-8?q?Wk6HRHwDdNcOzU6HwKO/fBveZGDan8cUoLah7smbCqIwO83c0+qwC+lGS0e6aSzEJ?=\n\t=?utf-8?q?ddNcyaZaE/7OMJwi7kndRJGzGC8Kulskk9rbrJgBrYJuu40aa40oH3sO3hGDZonrM?=\n\t=?utf-8?q?DSOkgSYAH5gLiDbzmeoz5hYqLcaLCSR3CM/noOWTInKuujuN1e+ZFtMgxKzDdbFRr?=\n\t=?utf-8?q?9nCpACqOehFvW3koLEA/i/687ljhSmrkE0IOAZaeINl8kzPkjOZaKu6NFyXhtaLDK?=\n\t=?utf-8?q?V3ITkqr3irGyQfHY0CXUC5nxJaMea670QFCwQ3L032nbaqNwa9DFpIjqYOKYhETVd?=\n\t=?utf-8?q?O7sCdLlqOQiSpx6QcQz5s20gFwV36+2tDVqATDrk84iSWWEuYd6lMF/nsfZC2ni7U?=\n\t=?utf-8?q?KHQoL/dRrkVYEub8gw7Jis2hzoLZp4IP9ZE/hzLe0pEa0cbnPd7bnjAwwzg/L1aw1?=\n\t=?utf-8?q?H4zDx2rGl+IHfFieTrTsnITF5cXC34/8vFEcytpG6q1aG8fsg7weE1/PejGnZ8HRD?=\n\t=?utf-8?q?/ww4pxpiagWlZGiK1yNWtT6Z8g5nHG6PD1ISvkfYIOcxRjHfkcqJiQIibZ33hnu+/?=\n\t=?utf-8?q?jlsrvQZmC/6CJCLD57xjQiN/Wwjj1VufUq2kJzdHS2e4V57jnz8ADGd9qSUgeGpUn?=\n\t=?utf-8?q?J65tI3SbBnAVbQ+mKpOvnDxNTGFz0ehtlw77BFu9svFhymlKZzyQuAUQ1MafE1i8k?=\n\t=?utf-8?q?I3YeZfB2S4hVwlwJYYx/v92HKSZATRtK6uqSamAyLTpQ4sQce4xUdR7wbuWXTfO0b?=\n\t=?utf-8?q?V9LLi+a9MkLNiahSPU1n3TMK/EN2hpT8wQqqAKKr5eLRdi6P/mo+vDdr1oaScK8B8?=\n\t=?utf-8?q?vRRKvBBRICZN+diSHCASYCZA9C2ZtVh8hNE5z8sepFHEjIAOoYnN3WBlKaMvQ9UZr?=\n\t=?utf-8?q?Ni+fcqzAPx0/252cM66cIGZokgSf2X69wxsMQODuGNiWNL+lGp915Kog1CXWKaeuM?=\n\t=?utf-8?q?Px46EfsXdPpbzYH1bdEiZLEwPySi35NUEdfRrZ9RfvGJL3QaXE41it21JiKi/AWfc?=\n\t=?utf-8?q?5pKh4Pzg4ptbwnXd784kvGV5DEV0zaFFzZhRuR7qyjjGPhx4nxz4u7FXB3bqxuBHv?=\n\t=?utf-8?q?HmGbh8ldUrjDlV3ZF8F4ins5huvmkPfzKbfDDOMnWYkmGompyJcpBu+qN7hVUOnoT?=\n\t=?utf-8?q?2UGMWSe1Yaps7Mb8Omch7KBgQjHjExAqcgIQCyimLAfIo6NSfD+7n0/uNTsU68Z7a?=\n\t=?utf-8?q?0QOIU1gHruvpV/2wAU7NgZZGCFs6R31151jBgyinYp/d9B+PhtQe++QSokYrv9X9d?=\n\t=?utf-8?q?+8grzdoXtkPAP/SdCCHym4MUGIfYEgePj+9OPK/xukciCHgAIePnLdK6TyOGd/kkX?=\n\t=?utf-8?q?koJQjkI359+uDTYFFc7rZGZ1DU6fJwTR+UpLWGlicTTDOtSPahAPmySrN4XQbFAhy?=\n\t=?utf-8?q?eUDwmVNSTTIHy4unUbK3D635+GO4MGMEQD+T3ffyGnBi7xHuWShtvTHFQXMopghuR?=\n\t=?utf-8?q?cvae4N++kZkdtDhupHVgOokkpFwDRemQ=3D=3D?=","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 519b3028-1961-465d-d973-08de8f12fffd","X-MS-Exchange-CrossTenant-AuthSource":"DS2PR12MB9750.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"31 Mar 2026 10:48:10.1154\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n jHr+vk8JfZZ0GlWGYrn03UQEgwRNIKWRJWP7fKErJKGYpbye23UiqHMdoeW77HPIkD8l1/Rj3+jSuBAjv6l4kg==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH2PR12MB4245"}}]