[{"id":3669118,"web_url":"http://patchwork.ozlabs.org/comment/3669118/","msgid":"","list_archive_url":null,"date":"2026-03-25T14:07:40","subject":"Re: [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On 25/03/2026 14:58, Jon Hunter wrote:\n> The PTP clock for the Tegra234 MGBE device is incorrectly named\n> 'ptp-ref' and should be 'ptp_ref'. This is causing the following\n> warning to be observed on Tegra234 platforms that use this device:\n> \n> ERR KERN tegra-mgbe 6800000.ethernet eth0: Invalid PTP clock rate\n> WARNING KERN tegra-mgbe 6800000.ethernet eth0: PTP init failed\n> \n> Although this constitutes an ABI breakage in the binding for this\n> device, PTP support has clearly never worked and so fix this now\n> so we can correct the device-tree for this device. Note that the\n\nI don't understand that explanation.\n\nDriver dwmac-tegra.c: ptp-ref\nBinding: ptp-ref\nDTS: ptp-ref\n\nbut you say that nothing was working correctly?\n\nJudging by these three - driver+binding+dts - obvious fix is no fix\nbecause everything was fine, so please clarify the exact problem.\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=KhXwXFB5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13234-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"KhXwXFB5\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgpx34Q26z1xy1\n\tfor ; Thu, 26 Mar 2026 01:21:11 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 4C654306F790\n\tfor ; Wed, 25 Mar 2026 14:07:46 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1E8A03DD530;\n\tWed, 25 Mar 2026 14:07:46 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D2DC83D1CCF;\n\tWed, 25 Mar 2026 14:07:45 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id CF144C116C6;\n\tWed, 25 Mar 2026 14:07:42 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774447665; cv=none;\n b=XZBIUQ7utdeB2iZCR2/lHKAMYyZ0O0daHdhbSuV0ttzKwRuW5bIGjypAx1eNuyMnXMB3b4gFC/0gBixnVm53ldp3jbt21/GkX0DC0oGLQbrclP69dGz90DMAvgn7oyOhmVdY+JOReI+Ez/Tqgkh9+Cc+mDDUHcYdhT7Sh9rV1D0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774447665; c=relaxed/simple;\n\tbh=DpURZcXkBbkFBwlbeNEBfAP/4j2pXtXvGs65Z8r1tnU=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=Vqw8a2AFAAJLiBUw96M0J8CifZ01vle8CNN4X5uI1MzAt5aFWAQCDH6HXerjjzTNIlss2FRtfi5KLkK5HxBg0O4fa4f7YHB2bEYmjIgWPqZbeCUzzGIcXNn6yCf8PcfvuOrejC0hiBB1ev4J4d96E+YZUxbuJ4laEipe6bG4bzM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=KhXwXFB5; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774447665;\n\tbh=DpURZcXkBbkFBwlbeNEBfAP/4j2pXtXvGs65Z8r1tnU=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=KhXwXFB5LNz6aa+ELS2GXM9Q+eBg93c+8zFNhDXIBy3E2zp/GowL1RFP3H5NY4qDX\n\t 4o7UU8e1vDEEE5Xin1ORdcZTTSWsd0V+eeUbSGqmERUs9Ba0rtja0NN4QWLYdEhi0C\n\t PhJvKUcBEvPVdpIfaOUBett0aGKu9Atvr5/i0dY5xgyNwPG1h2pjDWEx429lRbiHxX\n\t pcF+D3uEWBFJhJ+LvsIfROwcz6766iv6AFDfzrGVBx7rRusH17U8Fau1GGHeNuGIfC\n\t YEhXy0z/+tkkZzlBba0lF7Lm4z9cPQFGm/bJ0DIcglSRAl5kZFLGtdeN9hieoc85YB\n\t r8oysMvYiBo4A==","Message-ID":"","Date":"Wed, 25 Mar 2026 15:07:40 +0100","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock","To":"Jon Hunter , Andrew Lunn ,\n \"David S . Miller\" , Eric Dumazet\n , Jakub Kicinski ,\n Paolo Abeni , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley\n , Thierry Reding ","Cc":"netdev@vger.kernel.org, devicetree@vger.kernel.org,\n linux-tegra@vger.kernel.org","References":"<20260325135811.148480-1-jonathanh@nvidia.com>\n <20260325135811.148480-3-jonathanh@nvidia.com>","From":"Krzysztof Kozlowski ","Content-Language":"en-US","Autocrypt":"addr=krzk@kernel.org; keydata=\n xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79\n cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu\n JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH\n gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE\n J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj\n NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS\n BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU\n vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM\n Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD\n TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg\n S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE\n FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307\n QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp\n +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl\n ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy\n 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN\n hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi\n tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL\n 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn\n naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd\n hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k\n whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3\n Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue\n MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei\n OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA\n GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA\n 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9\n YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt\n 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU\n BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/\n JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu\n 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB\n YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v\n qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5\n RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg\n Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2\n H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB\n dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT\n AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu\n jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2\n zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw\n XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A=","In-Reply-To":"<20260325135811.148480-3-jonathanh@nvidia.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}},{"id":3669121,"web_url":"http://patchwork.ozlabs.org/comment/3669121/","msgid":"<5a0d431e-785c-4aef-8282-2a921865bb9e@kernel.org>","list_archive_url":null,"date":"2026-03-25T14:09:34","subject":"Re: [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On 25/03/2026 15:07, Krzysztof Kozlowski wrote:\n> On 25/03/2026 14:58, Jon Hunter wrote:\n>> The PTP clock for the Tegra234 MGBE device is incorrectly named\n>> 'ptp-ref' and should be 'ptp_ref'. This is causing the following\n>> warning to be observed on Tegra234 platforms that use this device:\n\n ^^^^^^^^^^^^^ Tegra234 (see further)\n>>\n>> ERR KERN tegra-mgbe 6800000.ethernet eth0: Invalid PTP clock rate\n>> WARNING KERN tegra-mgbe 6800000.ethernet eth0: PTP init failed\n>>\n>> Although this constitutes an ABI breakage in the binding for this\n>> device, PTP support has clearly never worked and so fix this now\n>> so we can correct the device-tree for this device. Note that the\n> \n> I don't understand that explanation.\n> \n> Driver dwmac-tegra.c: ptp-ref\n> Binding: ptp-ref\n> DTS: ptp-ref\n> \n> but you say that nothing was working correctly?\n> \n> Judging by these three - driver+binding+dts - obvious fix is no fix\n> because everything was fine, so please clarify the exact problem.\n\nCorrection - I missed in grep - there are ptp_ref users: tegra186 and\ntegra194, but how tegra234 could not work if it has correctly in DTS\nptp-ref?\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ZLMYWVRx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13235-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ZLMYWVRx\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgq5V5rlWz1y1K\n\tfor ; Thu, 26 Mar 2026 01:28:30 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 7B53D301EBC4\n\tfor ; Wed, 25 Mar 2026 14:09:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 09CC73DDDA4;\n\tWed, 25 Mar 2026 14:09:40 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BF57D220F3E;\n\tWed, 25 Mar 2026 14:09:39 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A3704C4CEF7;\n\tWed, 25 Mar 2026 14:09:36 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774447779; cv=none;\n b=o0EYMt4R0AkbIHiHqGF1HQJKynYkN1Pkx6RWx57cLweAT1hi8kXkk2C2yY3nltqneLoy6LEamlSHihYd+e1ymcIWrLlmmfyQf6eYGtH7z/G/86lbYTDJ8ohqEs0sJ6ydCIsOQJWwyJuVKhOl95M8L51AjjPR73uV0nRDCaa0lOM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774447779; c=relaxed/simple;\n\tbh=vweFY0qaJkBrjCPIQC3zKFQOMIxEWi6jNryJYY8EsZ0=;\n\th=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:\n\t In-Reply-To:Content-Type;\n b=s+SuhWfwgheHxZPS4S1XpQ8pc/V+fhsJj3QNG6WoaJRHtps1mgkPUT4u8mEUu1gyqAq76kAPUYo2Oa5VMqQPrOyeulp6vKH8/Bgc9ehyq5ED9G2/yYkOPeom7lmciPdMLNcZdi9Tt9qf4axVTIH5AHc3/9YCc61GxSQzyn0bqtU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ZLMYWVRx; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774447779;\n\tbh=vweFY0qaJkBrjCPIQC3zKFQOMIxEWi6jNryJYY8EsZ0=;\n\th=Date:Subject:From:To:Cc:References:In-Reply-To:From;\n\tb=ZLMYWVRxhQiBoLJB8Qtnh3DzBw5sb391U0MoXKoTjtdQXHAt5b1cegmNj/E4/8wlM\n\t kNFH2IXehGbIq8tw0s4VT8ajegyJmCduwz8sG9nU1Pp0CBMBMa0yfFwmxmR32MoB/H\n\t SJHRYOV4yZtpQ8fHebbMT3MJ4D6SjflmfZuuvYjNlZJX9Vz+iVrjjGXJctWQarT5Vo\n\t DMCK379rg+1ufwOiFFHoaRt7HnGPuKm1n2alfF0RcsKc00FWhInURjiRXMBRbeRf/s\n\t t4KQnEAD+/5y9bi/xQAhWECPgMV5dVHVZIxscGssXFcMvCu44BQbSnPoSMew6Ysyhw\n\t 7CLa3kaEAR66Q==","Message-ID":"<5a0d431e-785c-4aef-8282-2a921865bb9e@kernel.org>","Date":"Wed, 25 Mar 2026 15:09:34 +0100","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock","From":"Krzysztof Kozlowski ","To":"Jon Hunter , Andrew Lunn ,\n \"David S . Miller\" , Eric Dumazet\n , Jakub Kicinski ,\n Paolo Abeni , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley\n , Thierry Reding ","Cc":"netdev@vger.kernel.org, devicetree@vger.kernel.org,\n linux-tegra@vger.kernel.org","References":"<20260325135811.148480-1-jonathanh@nvidia.com>\n <20260325135811.148480-3-jonathanh@nvidia.com>\n ","Content-Language":"en-US","Autocrypt":"addr=krzk@kernel.org; keydata=\n xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79\n cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu\n JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH\n gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE\n J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj\n NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS\n BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU\n vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM\n Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD\n TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg\n S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE\n FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307\n QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp\n +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl\n ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy\n 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN\n hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi\n tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL\n 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn\n naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd\n hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k\n whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3\n Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue\n MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei\n OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA\n GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA\n 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9\n YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt\n 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU\n BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/\n JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu\n 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB\n YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v\n qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5\n RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg\n Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2\n H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB\n dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT\n AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu\n jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2\n zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw\n XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A=","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}},{"id":3669128,"web_url":"http://patchwork.ozlabs.org/comment/3669128/","msgid":"<188ef2a5-cd3d-4fde-943a-17d805d79ac1@nvidia.com>","list_archive_url":null,"date":"2026-03-25T14:26:16","subject":"Re: [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 25/03/2026 14:09, Krzysztof Kozlowski wrote:\n> On 25/03/2026 15:07, Krzysztof Kozlowski wrote:\n>> On 25/03/2026 14:58, Jon Hunter wrote:\n>>> The PTP clock for the Tegra234 MGBE device is incorrectly named\n>>> 'ptp-ref' and should be 'ptp_ref'. This is causing the following\n>>> warning to be observed on Tegra234 platforms that use this device:\n> \n> ^^^^^^^^^^^^^ Tegra234 (see further)\n>>>\n>>> ERR KERN tegra-mgbe 6800000.ethernet eth0: Invalid PTP clock rate\n>>> WARNING KERN tegra-mgbe 6800000.ethernet eth0: PTP init failed\n>>>\n>>> Although this constitutes an ABI breakage in the binding for this\n>>> device, PTP support has clearly never worked and so fix this now\n>>> so we can correct the device-tree for this device. Note that the\n>>\n>> I don't understand that explanation.\n>>\n>> Driver dwmac-tegra.c: ptp-ref\n>> Binding: ptp-ref\n>> DTS: ptp-ref\n>>\n>> but you say that nothing was working correctly?\n>>\n>> Judging by these three - driver+binding+dts - obvious fix is no fix\n>> because everything was fine, so please clarify the exact problem.\n> \n> Correction - I missed in grep - there are ptp_ref users: tegra186 and\n> tegra194, but how tegra234 could not work if it has correctly in DTS\n> ptp-ref?\n\nThe problem lies in \ndrivers/net/ethernet/stmicro/stmmac/stmmac_platform.c which uses the \nname 'ptp_ref' which does not match 'ptp-ref'. This is where the warning \nis coming from. So basic ethernet does work, but stmmac_platform.c \ndriver is complaining that the PTP clock is not found.\n\nYes Tegra186 and Tegra194 are not impacted by this, only Tegra234.\n\nJon","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=JqCCjsKE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13237-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"JqCCjsKE\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.62.23","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgqFt0vL7z1xy1\n\tfor ; Thu, 26 Mar 2026 01:35:46 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CCCB93006940\n\tfor ; Wed, 25 Mar 2026 14:26:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 994573E0255;\n\tWed, 25 Mar 2026 14:26:28 +0000 (UTC)","from DM5PR21CU001.outbound.protection.outlook.com\n (mail-centralusazon11011023.outbound.protection.outlook.com [52.101.62.23])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C5E2C3DEFE4;\n\tWed, 25 Mar 2026 14:26:26 +0000 (UTC)","from DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12)\n by MN2PR12MB4285.namprd12.prod.outlook.com (2603:10b6:208:1d7::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Wed, 25 Mar\n 2026 14:26:22 +0000","from DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391]) by DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391%6]) with mapi id 15.20.9769.004; Wed, 25 Mar 2026\n 14:26:21 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774448788; cv=fail;\n b=jXntlTNCS2kzX21Jg1/VuQutKlbhjESiU8iaJaPKY8hGYmcCoDTxTINrkIGrjmiq5aBMfrSP/hEJRBYJEQleP1swh5uFLDc4NN4x0avEvfiZAdOcmAHyvBWfP8xljKfLg/qhqlQx5YsSO7gYCFWRFQq8rqwsle/lro4bj7ApK30=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=ITeIlhKT/DAHvOUN2HgMLfMuV0AJNR0K7hiZ0kH39O9rpkX99duo7rOfiO1BxwyeKK7XcEp/j6nPdEfsMXbVHgmLNOm1YL0ANQN5Tde2Ijo78WDZ3R1eVnusdS44kJP5NFLKUf/o8b/5yf8jqepnGMSptcxZIw6SBq9OfrcpFRWBVnhaqbzgTjFwqckvfbT4FzaIuFOFV2yfMhU2y6emCk6LSeehSeSm3+C+sM5DiK/iK8o+0wQ9oCp6sbH93KGG3+J2HHsEU48vNIa1/dPn7m0COErqLmhQcfewAKEaaJ5y6j5mDF30dwzwmAzMhZpdKADtNy7E4rMx5OUx+M81FQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774448788; c=relaxed/simple;\n\tbh=Jyl5eUFjP0dTwzaGEzB7KZ9zQQAUKP1LSZ9CTxXZroA=;\n\th=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=A+p5uBK5gCR4zmxdGIJ1EgsYLaR8ZCY0iqJ8P92be0CjY5DYbGT+IGaFGFRX1QWpAgv8DudOYjIGyoJv9VvPSChRp9OmYQgVlx2gy/XGCV6q0nbf5+CR8P8Ib1Y9MJvUvCtDZ2lotfsFhQyYx9gmkC7DVauDIzyFHSsn05konr4=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=OXmqqqaNn1hJW/lsrj8KsrDWEitfqDZ5TZ+LrnhmhAU=;\n b=oOhJ3Z6Heygda1+qbzyJ16KlHgJrwp2hxMNJ7AfqXq4qJvNlI3vqB0Y1gNq2XE/NJXC792QpR2kQYieJK4DmngaAE/RyhnXif+KeGzDlbDT1qh/JP/xDlczuHbuRqxZfhCCZGBEVPkdXb/wevCaNm9KdRJLeCq+qchg7LeOtTgulknnzF/a3ckvnEk0I6WCrfavId4fpsN9MI1MlOnVXU4lgyV417dqpaSMUtiEARKP0OgQ9ImV+/dIJdZGa3D4yj4gnkQ/QPdkP+gPteMAUonQeigWHR+CgbJp6BNrfP97qnbdLUCQZ2gNz04oluINpjwTwVS7cmo6H0VyNITmQog=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=JqCCjsKE; arc=fail smtp.client-ip=52.101.62.23","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=OXmqqqaNn1hJW/lsrj8KsrDWEitfqDZ5TZ+LrnhmhAU=;\n b=JqCCjsKEmMakQ+YnfPXAcy5eD/Lt7REND45C//KUfLwikjbGqXT/up3NHMNxIdOY93SXjqD8T+NwJQUzFJsLTdrOo4C9C97hA7/vQYCGos3IMkRY1lC3PdHUp5MDLSRDLtXBM5UV41Ok9M0fvXUrsuDCopg0F3+iQKIu3uBeIJiZxf1gLc41ZJ2bTfmV4AwXq3uWRWlvJSp9tYfZ8QSJDkaeaTIUyQUUsBRfhfW5rqvZZvuhcX7n4LxfELVf/zlOeYzRNSv9UlN6DM4f0sqPv80l/cYKjgJ/YqpmKweScrhVwh5X9mneJextVX3h5UjkBZ8BFAya4je6DtdP9OvU8w==","Message-ID":"<188ef2a5-cd3d-4fde-943a-17d805d79ac1@nvidia.com>","Date":"Wed, 25 Mar 2026 14:26:16 +0000","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock","To":"Krzysztof Kozlowski , Andrew Lunn\n , \"David S . Miller\" ,\n Eric Dumazet , Jakub Kicinski ,\n Paolo Abeni , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley\n , Thierry Reding ","Cc":"netdev@vger.kernel.org, devicetree@vger.kernel.org,\n linux-tegra@vger.kernel.org","References":"<20260325135811.148480-1-jonathanh@nvidia.com>\n <20260325135811.148480-3-jonathanh@nvidia.com>\n \n <5a0d431e-785c-4aef-8282-2a921865bb9e@kernel.org>","From":"Jon Hunter ","Content-Language":"en-US","In-Reply-To":"<5a0d431e-785c-4aef-8282-2a921865bb9e@kernel.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"LO2P265CA0456.GBRP265.PROD.OUTLOOK.COM\n (2603:10a6:600:e::36) To DS2PR12MB9750.namprd12.prod.outlook.com\n (2603:10b6:8:2b0::12)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS2PR12MB9750:EE_|MN2PR12MB4285:EE_","X-MS-Office365-Filtering-Correlation-Id":"961b91a2-2c94-41fe-41e9-08de8a7a7cc0","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|7416014|376014|10070799003|366016|921020|22082099003|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n\tsG+mlWnms3JScOJL4TO37L/oW0KqGe2Ttfp68rljTg4N2lGM5BU72ZQkzGZM/hKHfN+agcIdP2jhS5sB8ltH+QTharng3ahjwvz2FVvTKNUL6Kg19dXw6tc9KWEPeuK0ohXRceosq5M5e1OYkWeeTA/U69c0+Z/vHPIG6Lt/Hzrg+LnOtAKMKAJIz2euWnqmAhefw2w9sHkzjkzZAwpz8UkpBTmZb9OEbFlwWVhxKTI+ufrj1x9ESIsQlP2NCXkMF1t+VPwmnUdgc1nZDZgiiZ+2bC/MfqUAqbCkUvxuhgyeLFlosEfeiuY1XsMvawW15QlEKVaLEondNYMSV+RXa999WDfM5DYxxpDMP3Xd1LApA9x96x6YMM4fqzWlagP+BQwFg2jhkMy3Lw5SB2rgnB2+H5iwm8H2pWAgAtiIKuvVIHb2jxTkSiySO8/8ikvLfXl2kp9WSm4vTc8Tu4jpQzb4GzVG7DHk3R1UYUU2UYHSgkXrG5hLaoHSUyg0o6ZAH7RitymgZJWsJGaQuZ2h4Tkae6XGdhJTKnjhIjCGq7fENj7x5Y1GwNeV/evFJfmr3feB87CZW0JKFb8li0BFMmUUdcF/kSUtjF38Fcl4fH8DlFjddPpxwJaTsf1lKxJYHEwtgtMgFpirovMSGD+a/kCc+uMwE1zOaRUUJqRQ9FWwaQqT0GvAOZsDJUzYwlOfrodL9+hdswvqui9M/ksmmVoJOoU/7cy9lgoO3JpbZlzT9tjmmzdK8S4ive5rWqqwnAsTGEXnYZhQAGkd2WfuMg==","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9750.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(10070799003)(366016)(921020)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?eZi1GuOd4GjIP+zQtgccjbVgRKUT?=\n\t=?utf-8?q?kKOBaKpj3LkzKVBdQ7N/XtQ5ve8hcpFoIQnyM8LkBpNvsHrfoMbh63o1VkQJe3IV6?=\n\t=?utf-8?q?9b8tsQ/bPQOfDG6x2Vi28Y9v4snx+J51x0z/XfyW6o0ZP+z0LdV6CE8681eFROZm/?=\n\t=?utf-8?q?fgueyrhVcokwq6g81Oy8HKxnAgvfntujrXHV1J0YI9sIaSyyeFVBw7vvt9fSg4jif?=\n\t=?utf-8?q?Hd3GC8qQPvTwIqm9PjrpMjH4mC0UW97z3dCvUPzjWFWxCz+5czKguYLZ/aK2EuQSJ?=\n\t=?utf-8?q?y2xGgkQxGxH2rjdcUPhaD8eUaN2VQ8lOXgUwlJWr6dAZpjLdlASoXENaaKWX8rrms?=\n\t=?utf-8?q?7XGXY8QFRWSIJnL42WtvFh0E50pn3WXfUE+MBaETKdS3IGfervu8k3xbdOf9z6lY8?=\n\t=?utf-8?q?KlhHPKjtSre9sZBbiBYu31jrZTyt+fRbpx2RS0iUjQbTlRmdNNQBXj3v/+Roprihj?=\n\t=?utf-8?q?ONUo2bWBZxUQCHlefP0lMMM30S46u0riD2FQaLHpP9wGWSQ7uyH4mJt97fasq9TsO?=\n\t=?utf-8?q?wAAbuwulIC09VtL99dqFruR2aVtQmIPAx9mzzDVnFak+dHcfxMe/7qdzlx0GltVTE?=\n\t=?utf-8?q?vd79oyzcJ3JNi0yXICaHMMYso6WhDbEfeM9G8bdThfCQLLn6UaQSAJUR5QPs4oij9?=\n\t=?utf-8?q?HZQF24Og2dstuQBwtV6Mzv0MqSoyOVnCzlCuq3PpFyy1mp5N+AJ8NAulDHCVA9Kc0?=\n\t=?utf-8?q?7Jui16hvxOPoQ3pUvpBloa59DEEh0I1F964lZMlYnXe3D665LOtrC7L31X+J1L8qh?=\n\t=?utf-8?q?Ao9ra1faiZYHuGzMd537F32v7s6BaRQL3CC3qB1Wax1VQFyIAs0vMx6MMJFPiuSFK?=\n\t=?utf-8?q?5/bc300o2SPkwZH1eFlcRWzT49cTtBJ6mDkgj6YkD648LuGpLbQxNX12Q/0qhOLfK?=\n\t=?utf-8?q?nlLms3rw6aTfnaxVm9nSL/azCvWi9mx5BDWZVzbRm5wYwt4szUbgabI5y/UE1izas?=\n\t=?utf-8?q?VvTecyC87EMz3kSIFklMnKZOJttSOQwTVIUNo1mF4/ys0X28ckF09AMOrMuLMA+xj?=\n\t=?utf-8?q?Rdb2ZVjx7mWrnjEBzvjMhQGeK2bcn1fWKEZkPfOj95v/5VI8q9ZWWb6qkVFqVM7rv?=\n\t=?utf-8?q?GZq5XujZEXSw5aLin32XNF8ykkwz4a6pEDOzj8USCYpA0NbmgrOO6ziJioBHLo2FH?=\n\t=?utf-8?q?S8PyWVzGB7nmSWA7IYODYO58UM3ku+EFjuZRczNU4aAj9/Rq4Drsylru7lWeLkp/S?=\n\t=?utf-8?q?4H+lXmgo2R853fG2RnHF5g/GP5brYIGo446ivMerl8fiBTtMIldX/y7iVLT9dvAq9?=\n\t=?utf-8?q?ItlUCLVhYl/QE+EHNeUU/YOWAvDKwvZRP7p5D68FCiKHAxJkZe3tOgdOTGh3nRxfZ?=\n\t=?utf-8?q?QpEvViMytuQXXszNFp/0eDXCTFz97/d1Wb1zsMeJw2MyjBxM16tgiP9Hx1nShWr/D?=\n\t=?utf-8?q?aSH3n0t6my+oO2iwsxp2euIw9U6FE8eK1Iy6i+mBzFLxK/J74T0JXwIC54wS57rFj?=\n\t=?utf-8?q?+HoO551/oYfFDBmgpc9RDbsFMnavzE30RcMBtZxM9II38hIZhQxJWjwmLmgiLAMDM?=\n\t=?utf-8?q?n97nAWFjSNVa9/bkeYiwOqCX2VoejrBl9TlP8bxqZ/79g2E1N96gktzI4DrI8icIU?=\n\t=?utf-8?q?PD1ZfggA5VgkR/xxkhsSpi0rX8ZVRjUMyKn2UkQQLmwXkOrwCFs8L9RUhF4kk26dZ?=\n\t=?utf-8?q?ba+d5p5lbwgIGy4Qhg4CwB8b+1wEbi1/bMgwOeH09fPbIZUYN3YiDQiWNSS4jGJv1?=\n\t=?utf-8?q?GBZNN2EX2Bqkh9mZM?=","X-MS-Exchange-AntiSpam-MessageData-1":"CwsHXRltt8Cz6w==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 961b91a2-2c94-41fe-41e9-08de8a7a7cc0","X-MS-Exchange-CrossTenant-AuthSource":"DS2PR12MB9750.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"25 Mar 2026 14:26:21.7787\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n cRUlZjUxpT9ZqcCB6YJMmjXUnAu192sjtldY3hqyVyeSImdM7hIdqDepGl4pupW7MYjzYO2Q6dPoihxC5kzUng==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MN2PR12MB4285"}},{"id":3669532,"web_url":"http://patchwork.ozlabs.org/comment/3669532/","msgid":"<20260326-uncovered-manipulative-potoo-ec2445@quoll>","list_archive_url":null,"date":"2026-03-26T08:30:38","subject":"Re: [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Wed, Mar 25, 2026 at 01:58:10PM +0000, Jon Hunter wrote:\n> The PTP clock for the Tegra234 MGBE device is incorrectly named\n> 'ptp-ref' and should be 'ptp_ref'. This is causing the following\n> warning to be observed on Tegra234 platforms that use this device:\n> \n> ERR KERN tegra-mgbe 6800000.ethernet eth0: Invalid PTP clock rate\n> WARNING KERN tegra-mgbe 6800000.ethernet eth0: PTP init failed\n> \n> Although this constitutes an ABI breakage in the binding for this\n> device, PTP support has clearly never worked and so fix this now\n> so we can correct the device-tree for this device. Note that the\n> MGBE driver still supports the legacy 'ptp-ref' clock name and so\n> older/existing device-trees will still work, but given that this\n> is not the correct name, there is no point to advertise this in the\n> binding.\n> \n> Fixes: 189c2e5c7669 (\"dt-bindings: net: Add Tegra234 MGBE\")\n> Signed-off-by: Jon Hunter \n> ---\n> .../devicetree/bindings/net/nvidia,tegra234-mgbe.yaml | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Krzysztof Kozlowski \n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=U7qT1zK5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13266-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"U7qT1zK5\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhHF33MHMz1y1x\n\tfor ; Thu, 26 Mar 2026 19:36:39 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id A00B330387F2\n\tfor ; Thu, 26 Mar 2026 08:30:42 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9E3EB3AA4F1;\n\tThu, 26 Mar 2026 08:30:41 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AED4369229;\n\tThu, 26 Mar 2026 08:30:41 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 5447DC116C6;\n\tThu, 26 Mar 2026 08:30:40 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774513841; cv=none;\n b=H/Ly9faqWt/9PY2qNdx6tFhb6IA/l9NQ3IGPeFtYOi0XuWyv0XZgck1InNyf2FZ3xlzpEoARkrFFMsfSVz41zHazGSpJRtORo2kU0/1vxXs+gdORmtBce3uzm7vw+Z53d3jc2ZJVg4jFqqxYuBUJCBxyfpPrhI1RuqDriLfgfNQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774513841; c=relaxed/simple;\n\tbh=8z7YTqI6mW5Gbbs9U4qAreBJfPpw3dpSNiy+3D8LbPw=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=YVcDmVUkFpIcbzW6NGy1iJy36FZBXzImfUG7bTKy8e/Y+hIcZQo723Iu+Hxeqf+l+QOVYA1MmoVWeNTmMwtm+YoihhPWQSGo2AOJSW/nd2hzXAJSekY9zd3gixyQFlS7LZUtNxN8jwFnURjhcNgJnQ6PY+Crnhb5VDq0n3F6yLE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=U7qT1zK5; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774513840;\n\tbh=8z7YTqI6mW5Gbbs9U4qAreBJfPpw3dpSNiy+3D8LbPw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U7qT1zK5agOao8hgDPWVyNlfROU4BKh8X37YTBE7eAoNlApPt72yA2vqqdrBr+weg\n\t RuLqX9MQF2v7fi1M25vBDKLR1dVuvkNPXVOARpb0HxxVKuF//2pVu/IT4F2ydbTFV2\n\t WSH2/esQA3y9+EoRsCMSc5Dg9ycWpH2hkEzvQkd3ad8BdEOPYZWF8g6wmKR96EUduk\n\t B6Op9IlJZTuxVVtWGVkRhOB7xe0+JugGLL3tdrpkIwTprfZKV3lurLcL78A0jOJ5mv\n\t 7+hLLVN8X44u3EZt3pMmQzFa3icSkVVCtPQ8ep2bBeyEw7qLMphwitiPLvb5xIcARi\n\t DehcRfI4CHG1w==","Date":"Thu, 26 Mar 2026 09:30:38 +0100","From":"Krzysztof Kozlowski ","To":"Jon Hunter ","Cc":"Andrew Lunn ,\n\t\"David S . Miller\" , Eric Dumazet ,\n\tJakub Kicinski , Paolo Abeni ,\n Rob Herring ,\n\tKrzysztof Kozlowski , Conor Dooley ,\n\tThierry Reding , netdev@vger.kernel.org,\n devicetree@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org","Subject":"Re: [PATCH V3 2/3] dt-bindings: net: Fix Tegra234 MGBE PTP clock","Message-ID":"<20260326-uncovered-manipulative-potoo-ec2445@quoll>","References":"<20260325135811.148480-1-jonathanh@nvidia.com>\n <20260325135811.148480-3-jonathanh@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260325135811.148480-3-jonathanh@nvidia.com>"}}]