[{"id":3671976,"web_url":"http://patchwork.ozlabs.org/comment/3671976/","msgid":"","date":"2026-04-01T00:13:38","subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","submitter":{"id":92968,"url":"http://patchwork.ozlabs.org/api/people/92968/","name":"Fang, Peter","email":"peter.fang@intel.com"},"content":"On Tue, Mar 31, 2026 at 02:22:47AM +0000, Yosry Ahmed wrote:\n> \n> Most callers are converting a GPA to a GFN, I wonder if we should make\n> the function take in a GPA instead? But then we'll need to the GPA not\n> being aligned to a page boundary (either do gpa_to_gfn() in\n> __kvm_vcpu_map() or fail if it's not aligned).\n\nThanks for the feedback!\n\nMapping guest memory into the host feels more like a GFN-based operation\nto me. struct kvm_host_map is also designed around GFNs/PFNs so I think\nusing gfn_t in the function prototypes seems more natural. The caller\ncan handle the offset-in-page cases without creating a lot of complexity\nin the APIs. But I'm happy to rework this if there's a desire to make\nthem more GPA-friendly.\n\n> \n> Not sure if that's a net improvement, mostly thinking out loud here.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=AggVVp+h;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19116-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=fail smtp.remote-ip=198.175.65.21","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=AggVVp+h;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=intel.com\n (client-ip=198.175.65.21; helo=mgamail.intel.com;\n envelope-from=peter.fang@intel.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fllpL3FXqz1yCp\n\tfor ; Wed, 01 Apr 2026 11:14:01 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fllpJ4hgVz2yVv;\n\tWed, 01 Apr 2026 11:14:00 +1100 (AEDT)","from mgamail.intel.com (mgamail.intel.com [198.175.65.21])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fllpF0Hxrz2yVT\n\tfor ; Wed, 01 Apr 2026 11:13:54 +1100 (AEDT)","from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 31 Mar 2026 17:13:50 -0700","from fmsmsx902.amr.corp.intel.com ([10.18.126.91])\n by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 31 Mar 2026 17:13:49 -0700","from FMSMSX903.amr.corp.intel.com (10.18.126.92) by\n fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 31 Mar 2026 17:13:49 -0700","from fmsedg903.ED.cps.intel.com (10.1.192.145) by\n FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Tue, 31 Mar 2026 17:13:49 -0700","from PH7PR06CU001.outbound.protection.outlook.com (52.101.201.1) by\n edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Tue, 31 Mar 2026 17:13:48 -0700","from SJ0PR11MB5645.namprd11.prod.outlook.com (2603:10b6:a03:3b9::19)\n by PH0PR11MB7588.namprd11.prod.outlook.com (2603:10b6:510:28b::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.16; Wed, 1 Apr\n 2026 00:13:45 +0000","from SJ0PR11MB5645.namprd11.prod.outlook.com\n ([fe80::fb19:f933:8bb3:b42e]) by SJ0PR11MB5645.namprd11.prod.outlook.com\n ([fe80::fb19:f933:8bb3:b42e%4]) with mapi id 15.20.9769.015; Wed, 1 Apr 2026\n 00:13:45 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775002440;\n\tcv=fail;\n b=PXWH01gUQnYoRGWtoql2MuZfniSCTGhX0Q7CUHyyat3Y3omb0AfC+DqaorMMaR8y6bp8SxjTZYhKzmPILa/xQBhIOvVVDyxZ7xzkap4Hj/5uJ4ofIYfLcDrDRVT6sXYaz0H209Ijl/CXULf6fa1Hi72HTomJ7rZFOQ6swt6BFb7oHsidYdIb9AC22Lk0+OHCRaLbQDzjxNfvKcl5OYUFIQdLRhNcIdfgUbhBWhVS2sT2KlpgTd3lNU83ZmWCbOoSLUe9CxE2uGsmXuUeYQBtijZj7cHNmo8TpGYa6edL7FvSk5ssVtugumdzjsKjeLi9fdK2CIT6KWURL0gsMBMeBA==","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=iqghUBLWv99UZ9SYXbKI4NECvkmreUZXwn/Ty41kSvq1MYdawyomXodakO5rV/pMBIwXqe9NI8ORU6924D1D1qoe5ce8E1ag0xd/aNHQhr+dBt4406uzlvMzc/7pRfuqpLCz46kbdvOoGaUDPGjhDU2HKIf98c7WBtloGDsLDFS9uGayru51pdkeQaxNr4ffHB1C0yKfSQXZBQJ3rBid4QNgLJwuUmndsY4PwBD4RLFriToudg8JPGhVw1hUdM1AJa1UFbs+GQlVtvMSCbay5q0U+hMmayR32U1XdIml7ZqSbBPlSjW2gHP4D4BigDr94Ve9KHKJ0KaeGa8v+zZ2fA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775002440; c=relaxed/relaxed;\n\tbh=KM9nXQT6fNRxvcXLlVt1SxOl68Dbe2UZ8ZTEsMIg0aI=;\n\th=Date:From:To:CC:Subject:Message-ID:References:Content-Type:\n\t Content-Disposition:In-Reply-To:MIME-Version;\n b=Ppxg8TY7fIHfx3fwiInvg8S1K2+x/BrF+0ocb2//rIyuwwgBYsLqE7Pq1uF0flS+/fBWlBoqfub/7XYrt30wYhS4O+tM12FgIl2LMy9cP0pEcc5k6sbp7paPMmzFTc8q89KsCi4XhJq4ZIiLhup3hwNBTnt1ObkSjYdvdl3l7WDSX1Xi0+3uM2uD2SAXrnSWrwkxx9Jr6VE8x7m6/NWdA73fdN+7wtHgZ4EHulrifKYyOFQzHHdqmenEAFdur3WCodyr3TYRkYDmU2tusGRMHsw1cRUlUZlvG5TGhvekSFmZzyVv4zVxK3TMHal9j/JVAfpNoOfEPuoTDwR6ktboHw==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=KM9nXQT6fNRxvcXLlVt1SxOl68Dbe2UZ8ZTEsMIg0aI=;\n b=Pm/Ao6JaJ1a/F/uOcEHvjLERSxA4y2/Tt4PyaWX0WrpU/+hx8e+2H1LG8moaqzf1j//ik621a567sRVChjGfZMXiFh2sRLhqcVBagPv+U2ZP9YrbTFxMGtkyEGZ1bbKNoW2gy/HfMKflpEop5n/+oKY6CU4P5ZnTlf8r2IZ2iGzhpojZtQtnnFmKejtmn+B5+GZU4IIEv+Q0Cidyd/5lSLUwTcty7+1hYyou1sRPPl5wH/3b61ybGOcooegCOcEuTMGRBqeIDxr3f68IutRQ2yMvvqS/dZZmcL3LwvSF0JYfDgkW29pVvTDtmv0aNw9nhHKe2RASAAFYh/fc2rsbxQ=="],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=intel.com; dkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=AggVVp+h; dkim-atps=neutral;\n spf=pass (client-ip=198.175.65.21; helo=mgamail.intel.com;\n envelope-from=peter.fang@intel.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=intel.com","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775002438; x=1806538438;\n h=date:from:to:cc:subject:message-id:references:\n in-reply-to:mime-version;\n bh=L3dDAUFQnDa/KXvSrkvPCWCwQHbtM8U/kTmHYfx+eaw=;\n b=AggVVp+hdm1vFPG34+FUc2yjTPauiJb3FgFNzofS0xGt0VYFBqGyzUtE\n NpQx0y5rD0ITEbiQT6HIAJIiRUvumGY2VK9Ce/1Nok4q7hWSr9OuH2V2b\n D/5sww66AD9CPRKg8pFxDJn5kyBYEEJ06/bxCG5MG35JP9HM4nemcf1cW\n W0wbvd7eyZsWcJLA4S9mkmt5N9SZrzIRGtpmEt86AzSeizwlWpgU74v36\n uiRMFpjwieIdjiveNkTMxgGNhtOVOJv+iZdDDK4quLphfTCms9chkWNgK\n JinA9mmJmoyjChGYCzsFzyDf/0f/UBKcoEOVSbYdCzv+3LSHZPR6ZzeB+\n A==;","X-CSE-ConnectionGUID":["l31ArS+VSrWYygCPxz0uXA==","x1hBkVQ8RxO59yVe+CqGwg=="],"X-CSE-MsgGUID":["nRL1TxTGSxGansVs5ztdJw==","AOx8BuXYRNaebI/SLSOJ2w=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11745\"; a=\"75917926\"","E=Sophos;i=\"6.23,152,1770624000\";\n d=\"scan'208\";a=\"75917926\"","E=Sophos;i=\"6.23,152,1770624000\";\n d=\"scan'208\";a=\"223210938\""],"X-ExtLoop1":"1","Date":"Tue, 31 Mar 2026 17:13:38 -0700","From":"\"Fang, Peter\" ","To":"Yosry Ahmed ","CC":"Paolo Bonzini , Sean Christopherson\n\t, Madhavan Srinivasan , \"Nicholas\n Piggin\" , ,\n\t, , \"KarimAllah\n Ahmed\" , Konrad Rzeszutek Wilk ","Subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","Message-ID":"","References":"<20260325092001.613025-1-peter.fang@intel.com>\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Disposition":"inline","In-Reply-To":"","X-ClientProxiedBy":"BY5PR17CA0051.namprd17.prod.outlook.com\n (2603:10b6:a03:167::28) To SJ0PR11MB5645.namprd11.prod.outlook.com\n (2603:10b6:a03:3b9::19)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ0PR11MB5645:EE_|PH0PR11MB7588:EE_","X-MS-Office365-Filtering-Correlation-Id":"86f5f5a5-6486-47d2-08d3-08de8f8389b8","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n BCL:0;ARA:13230040|1800799024|376014|366016|7416014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n y4eE/oYSILb4vN/Nq385hZgmxuLwHgchrC976sa7WWiq3Beqngp1eVKw5dwbdRW9ZOjJpjgigrupIFsCsC6oFFtoHbBehBPCiK472pONzuvzxBFYiH8WTE2nowlf6PInZzgejzGzhacVOITKCbtC2Y8bv72t39EQClKciTb1mkIQOpooZ6/ozlWLgcYe1XFQvKePnLzsBCNKlUj2SqOYvZAHu+Oy0f2OoxWpEtt+E+q9aaxo6OpPO/NUNZ5utMhMY4/VK1K5r8EXLXjD6xoSNeHJVTn2/Y8swhePbpRdIyfGS3onl/JE3DtIA0fcQh5tzrBpFykTM6KrNIi8CY/+qKgqrN/QYKzqvN0Q40E6sSzYGAOU3gjETGc9HFgTrAjhouIqUJ+p0pcxQbyWwaOR0HgopR2/aJGfSws3QzweFP8TJfYrG9m0LU9vvqNstSuB1xNtxF6ZQ/Di5z/up4G16tWrHRefQPcI4dcXE+By9MZ5yXvUhOeLj1hFz337J6T++iwPJa8iv7+iapUIEhBgppLUjaSzVaekoEkGxq8ZdTGpHjepzZ/NrecD6tdhu2+1+EACZ31aKrN80cK0ejJg/izKiRkulb189R+63qmFhoWrl4MDsO6TFG6ciIFvG6mYlT6RqTkHUwRViJbayZc0eIHCiGXZAsgmuiGafAgd2Sb4leQa09XDIX895Ihen6Az3djaE6YI9yY+eIz8OiDCDTUtx1qdxDdBvnTJcnmW8Hc=","X-Forefront-Antispam-Report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5645.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7416014)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n JHrW4PSsX7qLdr+wwm1IbQLeRY+FmzPOC5HPMPIF10n+zJyYWC/ftoYL2RgVqUT4YA38wL74LJDPEzVtP+h+3rVLdwJOkBL6DhrKn02GBCV6FsygolKGY8agDRqI4Ea4iFVpaPFqUyKZ3dZah/ck8+9fUkr+Vk3Q8CKTlq4RkFjsw9M224XVfX5Z+cnt/iIoWGHruwBAst/Wvby1213zpuaFaAwX68wKgGwFBaSX0XEZSypzRsZAd3ZjcILrRiRPb8hfl7xSAaOjdO3Lsy0jqNMHC5toA0cIDAI8AYBHxymhSS2e55BDzPLrFL28bAsaDciDTg/BDnDkSdEq9HijVwOokTfs2qcxSWGz8xrmBEZ6f99qxdE0fUZHGuRGK2kxso8p1z67VMxwCv07/+ttsNYlJMAQdQ8EXXtt5gupLNZlrhURZhicdXa8bI4ZEaEG+YeLTa6rqkHxNz2cr9BzEcjiaXJ8GkkXZL/02NVzGBJo1F+/MdlQvu7R5FHLU0+usvKD5H2EYdmyx+ZJw2vo59nI+d+eTp9ZitnnZKAtrlnVS7fL78Mo88ghogu7fHtLPoe2kPm7GzCvik7OL/dXQ4n8rZwsV6B4nQr/wNrAN1Oenco+PvvIkjY5uOt0X+xr+vL51NdmvMK4FQs+jzrS9gHVxRzNiT0A2ROMCuSkU39ZTWeVJ1gIjCHf0gD2YRIK84hEVefadJPYBIC/9AQH3lx7eXKqwRgoH7oUcaX7BiNhzrMWtdrTjdnYRQRnpwxJhq7qnFN+PBiDYqYO51wMZG42EuL0exSOy5oOCaX0ntXyuq63T//lMMXRDQPvaFKk48qfH2my0jCpkNKIoU5fHe259eIeH6Z/pWWn4UrhQEemXnKrRLJGoD1YBVL1Ajv2AJ4CqvdkgoEjfjkMAqpiNMPXF6j4hb01D6c+CsIQ4PZFXfrgvGyXQ6tnCKmFb64o7RoV1pDe4ZZPFFjynpYv/HK2COR6Xvsn2/X0DoGSKSrOqGH00LDCHDASUYrfvVDssNmbV3KkoQo4u7kd7M48veXVeXB910e0Q7lJxDYi/pQxSxJCB4CjfIlqWZ3E57kxcJOT2uNHgura1mftkzW/J3RF32ZleFuX7JGMaq6+gAK/1JwYGsZVM8MKQPAS21S951wzy4mUHR5cdQuWOMm+VGkGaODKtNzld1yAvsJrvU/o9ztkPStS50mBS0NJX9yjUkkogelO0o2aFY6YzXxoMnyi23qhAskeEImHfWOb9ach6NXd295gErcQ5FUITXK9sgEEebOWIHkr+K1iePV8iyIuhRw1qH0jDW/kf+mA7pWami0CnjtrXkcUApDMi2ZHQ5BUEO86Dc37DD3zZeHlgrshcIfLU8oZFSVpsCMXzXT4bnZYwHRl//7PZuD+ACCz5Z180VN2D+fj54WSDLjmgCzzu6pWFmHqAVOhfsXdCCwRTz3Mbao2dWFklBGtImjXsiFxbALVJZh8tZyCrmKG1lrIlrhMXBh2US6hhFrbFjJDACNliilNS8ovr48GYFOtBd5mF35jnzN/D5jtTdQZCjF2/knNfnfL/mjbLLfp095CjXukfbVcsYn1/bx8iPUZWVJl03JnqJQ1S+zLnh5/Huky13v0x8jZChjuSxdDHlsXIcMaClpnCaNApInkkZh9ucPzRzX1z0O3OoHxhU0HXRt2WbE3ZpDChE76vAgohaXhijplPmO6b3stR+Sg9yMjRg9QryzOM8OYZDh+5KgTDA==","X-Exchange-RoutingPolicyChecked":"\n IhJGDfQpnIji9WSubcvCcKD8zzjI0/dD73bXPF7cjJ5dna/wtctJA2DSgiuLQSV8J3J7k+Z1LvnTlzZZqi4u9fNWQeUxyqD1RLmvM5/etWXhIHwA0RRG1z4TkSH/bZa38abN+xpn+uD/4PnANzExiTXnAU2lOOgVJeIDhQJhcHyEEZK6levt/JTGJtk4Lf1x/JT+TkjxvpiR5B2Wddgqg6xfKE8rgGxCNgTO34JLhONRROBnjGzD7VdTamtkSLGjjJR1Iwm074ty2wCxH58k5/c5JTgjPUVZmgtf/98quyP8XzWEHs5ZCGaHBedhmYyPrsM/MkqelA4pP9AAnEz/0w==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 86f5f5a5-6486-47d2-08d3-08de8f8389b8","X-MS-Exchange-CrossTenant-AuthSource":"SJ0PR11MB5645.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"01 Apr 2026 00:13:45.1098\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n /GxeZObPlW/DpFtR+fyAFf7o60/jaLyfQXb83sVz395JNCSfNHTuTOGueRCehgoNZ/iOxjxztXKUBHQISOClZA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH0PR11MB7588","X-OriginatorOrg":"intel.com","X-Spam-Status":"No, score=-2.4 required=3.0 tests=ARC_INVALID,ARC_SIGNED,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n\tRCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3671983,"web_url":"http://patchwork.ozlabs.org/comment/3671983/","msgid":"","date":"2026-03-31T02:22:47","subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","submitter":{"id":93023,"url":"http://patchwork.ozlabs.org/api/people/93023/","name":"Yosry Ahmed","email":"yosry@kernel.org"},"content":"On Wed, Mar 25, 2026 at 02:15:11AM -0700, Peter Fang wrote:\n> kvm_vcpu_map() and kvm_vcpu_map_readonly() should take a gfn instead of\n> a gpa. This appears to be a result of the original kvm_vcpu_map() being\n> declared with the wrong function prototype in kvm_host.h, even though\n> it was correct in the actual implementation in kvm_main.c.\n> \n> No actual harm has been done yet as all of the call sites are correctly\n> passing in a gfn. Plus, both gfn_t and gpa_t are typedef'd to u64 so\n> this change shouldn't have any functional impact.\n> \n> Compile-tested on x86 and ppc, which are the current users of these\n> interfaces.\n> \n> Fixes: e45adf665a53 (\"KVM: Introduce a new guest mapping API\")\n> Cc: KarimAllah Ahmed \n> Cc: Konrad Rzeszutek Wilk \n> Signed-off-by: Peter Fang \n\nMost callers are converting a GPA to a GFN, I wonder if we should make\nthe function take in a GPA instead? But then we'll need to the GPA not\nbeing aligned to a page boundary (either do gpa_to_gfn() in\n__kvm_vcpu_map() or fail if it's not aligned).\n\nNot sure if that's a net improvement, mostly thinking out loud here.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dKyITreC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19117-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dKyITreC;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=yosry@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4flp1q0hrdz1yGH\n\tfor ; Wed, 01 Apr 2026 12:54:06 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4flp1l42glz2yfs;\n\tWed, 01 Apr 2026 12:54:03 +1100 (AEDT)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4flBjS6FzYz2xSb\n\tfor ; Tue, 31 Mar 2026 13:22:52 +1100 (AEDT)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 6D95A6001A;\n\tTue, 31 Mar 2026 02:22:49 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id BD3C9C4CEF7;\n\tTue, 31 Mar 2026 02:22:48 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774923773;\n\tcv=none;\n b=NmFpen+tbY9O/0PDo4YP0alramyV6o6qQBTpDEsnZ/SSfPgBH5WfDRKcb6pN7m5UDz7ypEuUl/HQP2QTbGXULZf/DIa7yetHZowCPYcH37Lxu7nvVMy9nPHr50clp/SlMn6V7Ec8hU1F0c7JTGU9nBun2fLQ/NFjbmFo5gh2In7fcTyUI1ExFqW7i18B4yGXKhNF08aTC7F2aTYDSn3wqDwWte+76b2uOlD9ir6qzCIfq7bts2d0co9tNAMgNdLCl7aaGFNAb4NlaaCshvZt9q+dXJ+vscep6YM4DrA+Oxrybq66HrysgLzescsuIsEmMpQQ12CnyD1Lxv6s+rYv8g==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774923773; c=relaxed/relaxed;\n\tbh=QabMiw3X15wVYXIy7i5TdznxyWv79L5LHLcvahuNhGI=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=ET+5PWJTfaXPku/+JhYwOc6ixqztAW70QzfI/q1Mfle+4h/h3sKidbE+Twh5gDO+W22wQOTOqsMdmu1IgNhiVbyKSGYWFJ5qVhU13Y1RMHFOJl8LJBKcAPSQxyP/x0/LhKswHv2Li91n8wTFTPbbbaGZ5d2QBkUgMAu6GN4pF3NLcyLxGDJEG3LUipmLmWoqsbkDh7MUFU0BtP501MfheWbNXte+oCdmUE0jHVMNwM9aRxCZ2UNHsj3bRZ2VN0MXIzMlm4W73VFyFUl8EJoIy/LecZkCLSpv9P/uQl+dcLHdEW2tPklGXZsEGPxQboj/4WlREpJsIlKcTfO0cgvu4g==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dKyITreC; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=yosry@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774923769;\n\tbh=l7yJ68saVTwIij/720EHHZQ7SKACJi+dA14H4Iz/0NE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dKyITreCFvpgzleJDzSfojc1RUx0rh933wIM/DxrEJcU+2OMUZsSJeZEjJ5Zo7ccc\n\t Jv9xUS9s0iBiOl801QOPyyG/eWFZhYPkYbZIRoqnG9Bb4x9JtmCE38Uq5hzk4d1by+\n\t cPfDSMyTh2b8VZtaYu92AD4ejaU1OVCp9HoB7V9wOZJsbrsd/bu05xczdY4/8JVyCE\n\t zLi89KFGZKVjXNAPN5d4jQ1a+ife3KXkJbyrEJSdiLm1I11ZLaHwY716c8Ffng+FWr\n\t FNtFkKfbbOY6866B8SBRM+HuAYzBzP+rO607pNwTQIKnB/DKGGKG/LHN/odixoKzYh\n\t 7fc3cDep3FpAQ==","Date":"Tue, 31 Mar 2026 02:22:47 +0000","From":"Yosry Ahmed ","To":"Peter Fang ","Cc":"Paolo Bonzini ,\n\tSean Christopherson ,\n Madhavan Srinivasan ,\n\tNicholas Piggin , kvm@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org, KarimAllah Ahmed ,\n\tKonrad Rzeszutek Wilk ","Subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","Message-ID":"","References":"<20260325092001.613025-1-peter.fang@intel.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260325092001.613025-1-peter.fang@intel.com>","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3672935,"web_url":"http://patchwork.ozlabs.org/comment/3672935/","msgid":"","date":"2026-04-02T23:52:24","subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","submitter":{"id":81022,"url":"http://patchwork.ozlabs.org/api/people/81022/","name":"Sean Christopherson","email":"seanjc@google.com"},"content":"On Tue, Mar 31, 2026, Peter Fang wrote:\n> On Tue, Mar 31, 2026 at 02:22:47AM +0000, Yosry Ahmed wrote:\n> > \n> > Most callers are converting a GPA to a GFN, I wonder if we should make\n\nNot most, all. The two outliers just do \"gpa >> PAGE_SHIFT\" instead of\nusing gpa_to_gfn().\n\n> > the function take in a GPA instead? But then we'll need to the GPA not\n> > being aligned to a page boundary (either do gpa_to_gfn() in\n> > __kvm_vcpu_map() or fail if it's not aligned).\n\nJust do gpa_to_pfn(). If someone gets confused, we can add a comment explaining\nthat kvm_vcpu_map() maps the entire page containing the gpa, but that should really\ngo without saying...\n\n> Thanks for the feedback!\n> \n> Mapping guest memory into the host feels more like a GFN-based operation\n> to me. struct kvm_host_map is also designed around GFNs/PFNs so I think\n> using gfn_t in the function prototypes seems more natural. The caller\n> can handle the offset-in-page cases without creating a lot of complexity\n> in the APIs. But I'm happy to rework this if there's a desire to make\n> them more GPA-friendly.\n\nI vote to rework the APIs (after first fixing the prototypes) to take a GPA.\nI agree that mapping a page at a given gfn is conceptually more natural, but\nas Yosry points out, requiring literally every caller to convert to a gfn doesn't\nmake a whole lot of sense from a code maintenance perspective.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=rN2OtOA6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19242-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::449\"","lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=rN2OtOA6;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com\n (client-ip=2607:f8b0:4864:20::449; helo=mail-pf1-x449.google.com;\n envelope-from=3oqhpaqykdmwaws51uy66y3w.u64305cf77u-vwd30aba.6h3sta.69y@flex--seanjc.bounces.google.com;\n receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fmzDb7525z1yD3\n\tfor ; Fri, 03 Apr 2026 10:52:30 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fmzDZ1z8yz2yYK;\n\tFri, 03 Apr 2026 10:52:30 +1100 (AEDT)","from mail-pf1-x449.google.com (mail-pf1-x449.google.com\n [IPv6:2607:f8b0:4864:20::449])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fmzDY0n5Dz2yVv\n\tfor ; Fri, 03 Apr 2026 10:52:28 +1100 (AEDT)","by mail-pf1-x449.google.com with SMTP id\n d2e1a72fcca58-82c646e980bso751688b3a.0\n for ;\n Thu, 02 Apr 2026 16:52:28 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775173950;\n\tcv=none;\n b=ITdboY8LPbCNpLDKMQbBtj+0JFxGesYKeEcuqWWaqThjORIZ7PA6xUzapIVwD5WmHyEC/ELm30KCuvzkdGEQm9nk0ABH6lgrXYMGU3Xv34Wb6diy+k74RyTVO9KAntvpRmAIjMVYoO6ClvEiZf2X7TKlRL2ImffC50ZtgS6UWtXaXOTOdqN13vWv8Rf5PLxaOhJc05PVK24P5Q2mWd4ZTvZE5co4wLQz1M13xA55JkP9anKgujTMkNMceW4mDHuLc6vcZo9oj6zoPrQWA8iuKUjdkXcyhJFBAfQwnaCn0ylg+G19+xY8zZnI8Pl0D9pQ5+NGGg73KRcyqbuprEWFDA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775173950; c=relaxed/relaxed;\n\tbh=NRFfWyW5OJQnxYPyWhMs1ziwQUg0nXafSfiE/IeYP3E=;\n\th=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From:\n\t To:Cc:Content-Type;\n b=O8SAF/Ogdo+wMC9gERL3QCjML59BXmV3bJ0Pu0mebTUO0GAM0InX0nV4ATAbHFgy4ovP/b/Vej3zwcu9v0JsbIl6AkByRbipWgLFXv+xTkHOROuMhI7EHhqscSv4Q7t8NRre90egLiEw0VsPvIoQbIWiqh9VzDCxQxcE4gG9WruKicFvqjK7b/z0rSGiUIeN2nDWpdpylmXPn0wS4JP2qN0bErkSaUzu5oFgVr+u9sm+v51SRbDhykRP0LjuDk03Wn5CFz73eWn89C522S5pVL8umc1VgUQmFbG2gAfsPRnt2FnuxryYhAM3pGFdWdI+vVmmLQz757QNv8m0+qXcqQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=google.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=rN2OtOA6; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::449; helo=mail-pf1-x449.google.com;\n envelope-from=3oqhpaqykdmwaws51uy66y3w.u64305cf77u-vwd30aba.6h3sta.69y@flex--seanjc.bounces.google.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=flex--seanjc.bounces.google.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1775173945; x=1775778745;\n darn=lists.ozlabs.org;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:from:to:cc:subject:date:message-id:reply-to;\n bh=NRFfWyW5OJQnxYPyWhMs1ziwQUg0nXafSfiE/IeYP3E=;\n b=rN2OtOA6pBNYoNGzb8OXwq/5ZHlwLVAL/hxOdNUp1ErdcsSk6CZVMjqznGFDaRAHuf\n qMlp2w5Lqy87XMTVwlYm44KQK+G7tvx0t/Hj9m0ZoDvg02NxUaKJEJIp72TP3LyQ+KQc\n R9elZ3wMr17MyfvS+rgirER3FgZ8XzgvJ/1Oy4G779upgMOHyo5D9MK/MROf5CRsbaQA\n vne3/To20qeD/+9Qiq0R6VkKgBM1xOSMp1BD85yzPoc2jP6HKRMgemSEbUqLx6U9SIq0\n be3bSmLaDEN3oM0+SuXH2iYNQqFiYtHlnzlfoDp/ZEiDF5wa08UYAItNpStHncZyDn85\n CgdA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775173945; x=1775778745;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=NRFfWyW5OJQnxYPyWhMs1ziwQUg0nXafSfiE/IeYP3E=;\n b=gK9ywctnPuKGvkgUn6+DRkAUUZRE7FLszANJTpEjw+VeEmlbup9t3zSDTfE1NNd/Jf\n udigeCsZRbyzQq21YZkqnr/duHGYlHOpgUaWvJm6/JYmVpX0qIUSbRRZuf4AMwBsjBOj\n DTtUKkwkIzXFFdu6/RGxstKexrvru/bD9u3elE3CpAlhOlDVCXl1LZNYk6zMevjGT0aq\n /McLDZ204/LqCMa5otcSf6pfZRrkE02lk6o/qF2HQactCiSRc/sqDRNIKVSaRGw/DnwZ\n p9NeToRkLJC/nACBQOc43IuUng3yjsv2lC5fwidNWnectDrXkBw/9wQfIG2NxWTfuKe5\n uiWQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWEYlVlvIBwG3CtTRC2ea5A2qkLzJr+V6T3/OJVWwpTd4rG1lIPf1D2By0DZoEEMLJwC9noJch/l9obHow=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0Yy1CL3fX66jMCCCM8xcf9OtPNeZl7mbJOssjDkRhP7MHtkNKrfP\n\tFX3cm3B1GiOsYYHhKI/pz03kQNCyuVIS8U4DTTRBVZQ7tL3BMrcHBZ8peEC/GHLSIvRsPfFflp0\n\tkhqoIQg==","X-Received":"from pfqf9.prod.google.com ([2002:aa7:9d89:0:b0:829:700a:a1d2])\n (user=seanjc job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:6a00:1f0e:b0:82c:26a4:df02\n with SMTP id d2e1a72fcca58-82d0db8b083mr815883b3a.42.1775173945247; Thu, 02\n Apr 2026 16:52:25 -0700 (PDT)","Date":"Thu, 2 Apr 2026 16:52:24 -0700","In-Reply-To":"","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","Mime-Version":"1.0","References":"<20260325092001.613025-1-peter.fang@intel.com>\n \n ","Message-ID":"","Subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","From":"Sean Christopherson ","To":"Peter Fang ","Cc":"Yosry Ahmed , Paolo Bonzini ,\n\tMadhavan Srinivasan ,\n Nicholas Piggin , kvm@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tKarimAllah Ahmed ,\n Konrad Rzeszutek Wilk ","Content-Type":"text/plain; charset=\"us-ascii\"","X-Spam-Status":"No, score=-7.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,\n\tUSER_IN_DEF_DKIM_WL autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3673057,"web_url":"http://patchwork.ozlabs.org/comment/3673057/","msgid":"","date":"2026-04-03T10:18:23","subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","submitter":{"id":92968,"url":"http://patchwork.ozlabs.org/api/people/92968/","name":"Fang, Peter","email":"peter.fang@intel.com"},"content":"On Thu, Apr 02, 2026 at 04:52:24PM -0700, Sean Christopherson wrote:\n> On Tue, Mar 31, 2026, Peter Fang wrote:\n> > On Tue, Mar 31, 2026 at 02:22:47AM +0000, Yosry Ahmed wrote:\n> > > \n> > > Most callers are converting a GPA to a GFN, I wonder if we should make\n> \n> Not most, all. The two outliers just do \"gpa >> PAGE_SHIFT\" instead of\n> using gpa_to_gfn().\n> \n> > > the function take in a GPA instead? But then we'll need to the GPA not\n> > > being aligned to a page boundary (either do gpa_to_gfn() in\n> > > __kvm_vcpu_map() or fail if it's not aligned).\n> \n> Just do gpa_to_pfn(). If someone gets confused, we can add a comment explaining\n> that kvm_vcpu_map() maps the entire page containing the gpa, but that should really\n> go without saying...\n> \n> > Thanks for the feedback!\n> > \n> > Mapping guest memory into the host feels more like a GFN-based operation\n> > to me. struct kvm_host_map is also designed around GFNs/PFNs so I think\n> > using gfn_t in the function prototypes seems more natural. The caller\n> > can handle the offset-in-page cases without creating a lot of complexity\n> > in the APIs. But I'm happy to rework this if there's a desire to make\n> > them more GPA-friendly.\n> \n> I vote to rework the APIs (after first fixing the prototypes) to take a GPA.\n> I agree that mapping a page at a given gfn is conceptually more natural, but\n> as Yosry points out, requiring literally every caller to convert to a gfn doesn't\n> make a whole lot of sense from a code maintenance perspective.\n\nThanks! I'll prepare a v2 series to clean up the call sites as well.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=P0X5oWMb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19268-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=fail smtp.remote-ip=198.175.65.19","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=intel.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=P0X5oWMb;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=intel.com\n (client-ip=198.175.65.19; helo=mgamail.intel.com;\n envelope-from=peter.fang@intel.com; receiver=lists.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnF7834H2z1yCt\n\tfor ; Fri, 03 Apr 2026 21:18:43 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fnF7569DWz2xln;\n\tFri, 03 Apr 2026 21:18:41 +1100 (AEDT)","from mgamail.intel.com (mgamail.intel.com [198.175.65.19])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fnF723ng3z2xLt\n\tfor ; Fri, 03 Apr 2026 21:18:35 +1100 (AEDT)","from orviesa004.jf.intel.com ([10.64.159.144])\n by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Apr 2026 03:18:33 -0700","from fmsmsx903.amr.corp.intel.com ([10.18.126.92])\n by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Apr 2026 03:18:32 -0700","from FMSMSX903.amr.corp.intel.com (10.18.126.92) by\n fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 3 Apr 2026 03:18:31 -0700","from fmsedg902.ED.cps.intel.com (10.1.192.144) by\n FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Fri, 3 Apr 2026 03:18:31 -0700","from BYAPR05CU005.outbound.protection.outlook.com (52.101.85.37) by\n edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 3 Apr 2026 03:18:30 -0700","from SJ0PR11MB5645.namprd11.prod.outlook.com (2603:10b6:a03:3b9::19)\n by CO1PR11MB4916.namprd11.prod.outlook.com (2603:10b6:303:9c::5) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Fri, 3 Apr\n 2026 10:18:28 +0000","from SJ0PR11MB5645.namprd11.prod.outlook.com\n ([fe80::fb19:f933:8bb3:b42e]) by SJ0PR11MB5645.namprd11.prod.outlook.com\n ([fe80::fb19:f933:8bb3:b42e%4]) with mapi id 15.20.9769.018; Fri, 3 Apr 2026\n 10:18:27 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775211521;\n\tcv=fail;\n b=VCk5kUwSybJA7bDh/yVkLdQb6mecgcUzMAoYv1febjU8VcKc+01W1PEC31JAMjKYYLDOegUaDLZRiHzwdlZSJeuWTXysfRVYZq90lLc373YouLZ0Zqw+K9DetDoIaJvvMLQuGRhUqENDrGgXRBL75bXd2eqmk8gEr93PN9mzrj/pEb/HcZxFhPszrc3hZ946gzTXyK8364JDYieJKa5+8sjE01IxnOUsV839IaQwtHIjrjV39e6YDdBy9LgGZB5j1HB/XwQl1PcHv30LJbZJ1pSRHjqKXCpCBHo27clN8aTruVy0OEjwwVmUjUFvokW971UI85pysQ0aVGKpOrKEPg==","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=N9Kdr+/eD9oFCb4tAn54ZQ9Q4FfuPIPngT6pKnkoY0bG0eC/a4fui6pEPKrp+HpGsN+8zCHEP48HhCepdkOijf4e+RzbuF2eQyFOfEHY3NWo/ajMAiL2m/ctvXkjiplUMZJ0gQV9+fmaoWQIRrdzCEpvW0cU1uDekk2PEWO8o0FYUKB9AuoBCiXTq1qbinCOsWl5qdgwXyZE+t44gCxHrqYeF2/BxKJ4a4r2SMPls5PsBvluBTObpV3H0sO071HMiKdVTcfU4Y+aUzSeILrqBQA+vzyxDwR3Ec6KMRpeV1QsYWu7cRlPXGGukAOJ7wYzjZvbdNIe3iHCZILkK1R4WA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775211521; c=relaxed/relaxed;\n\tbh=XExWi4pOWGBbFeKE1cbrWgwBqFQC5brhDUaEI16h5I4=;\n\th=Date:From:To:CC:Subject:Message-ID:References:Content-Type:\n\t Content-Disposition:In-Reply-To:MIME-Version;\n b=oghy7vbJS/Q7MffKPd4Bvl9tLeFYVIlB4ynL4gHxgo5V2NKLC41PPQoCOmm51EdTsLw87vERWwxxtxOOOtaydKLfc7l/nQwJhQ3gFODlodGwk/KL5JVOrUxNummWX9qPRaJb2I5Up319pqGwByPdpoMtX4IyZcB5aJ5vxO/HRTnolX6pPJGQq6sl8DpGy+cNsW0MfKBXuAF61Pb/VzXyfvXVkp3uh28JEZltYkJRxNkNbKYAfeQmkqry8KjDTPxO9gES71+zbGlk1QUMOL1A988Nmu1JOVhhlPdvWxi8IraR75sxczj9u0BNIB6Q9rk7EBveKZa464A8odhCTaKeVQ==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=XExWi4pOWGBbFeKE1cbrWgwBqFQC5brhDUaEI16h5I4=;\n b=B8JYl6T+ARpQpJEBXUB1z91NeI/oe+wPNZPyp0iAPfAk5rwIjSQCtNuXQnlOVKE8DXq9DeW7xeDmX8h571j/5erTJkxbAqq/KjXIe4EfyRwLzmtB2M34QtrxYJDezIxW6bB5jT625W11AAxyHJx03HEqY5fGBhMPnwqIAGn5JKFc1vM3HEQdgqPw/pVEoKX6SSNrgh2pm2y0f3nNCk3oWeii1qcbR4TxZH42a38DAoA4in/z/mz22Nc6obIY6ufnsCcVXRky1eC6xWC0q7QkTd3mSibfIrsavy17zOY3bYeHvf6/WQUpUJjRGNNH0S881cFoKI6XvPN6iOz8hHmbUw=="],"ARC-Authentication-Results":["i=2; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=intel.com; dkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=P0X5oWMb; dkim-atps=neutral;\n spf=pass (client-ip=198.175.65.19; helo=mgamail.intel.com;\n envelope-from=peter.fang@intel.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=intel.com","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775211519; x=1806747519;\n h=date:from:to:cc:subject:message-id:references:\n in-reply-to:mime-version;\n bh=/bix4SwH+cVDBOv8T6wQFx2kY0jjpoCzzIbNi/8GEZ8=;\n b=P0X5oWMbn2plGJ15jxwT/SHQTomUFGP2qhtBnyEppvBJKEb8CZR1P8DJ\n /5OEJe/dflmCkNLyJMCXxzdlc/c8QqxUOXpzC8dMHLR3yrdufffZSc2aw\n YfAXn1Gd2kDmNfYkgZ9wDhNYIsMKBwRGq558H/a3gQiv6lvVnfOLEPl5Z\n ZXgz5pBBIJu57rK4+MMaQzZum1+kljozvj06h6ZWhFkQjj41p4hYbqXwR\n LMrzNag6PKP5gpB/9/u9+Npj8z3cs7HhdZ6NVrbKgCtZSTEWhHpmJlCa+\n oDk+qKnSflhgalgbgS59dxmcQ44aqISLnK37zLhjev24wULv3YPV7RJHv\n w==;","X-CSE-ConnectionGUID":["NsyC7kG5QDeuZTPVBrwWIg==","+3ukwKtnTyijl2PbkuhRXg=="],"X-CSE-MsgGUID":["578f7BnlS9eOv0cTuujTyQ==","6PUGrCL8QjWyVEoFlu+lyA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11747\"; a=\"76162426\"","E=Sophos;i=\"6.23,157,1770624000\";\n d=\"scan'208\";a=\"76162426\"","E=Sophos;i=\"6.23,157,1770624000\";\n d=\"scan'208\";a=\"231619249\""],"X-ExtLoop1":"1","Date":"Fri, 3 Apr 2026 03:18:23 -0700","From":"\"Fang, Peter\" ","To":"Sean Christopherson ","CC":"Yosry Ahmed , Paolo Bonzini ,\n\tMadhavan Srinivasan , Nicholas Piggin\n\t, , ,\n\t, KarimAllah Ahmed ,\n\t\"Konrad Rzeszutek Wilk\" ","Subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","Message-ID":"","References":"<20260325092001.613025-1-peter.fang@intel.com>\n \n \n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Disposition":"inline","In-Reply-To":"","X-ClientProxiedBy":"SJ0PR03CA0357.namprd03.prod.outlook.com\n (2603:10b6:a03:39c::32) To SJ0PR11MB5645.namprd11.prod.outlook.com\n (2603:10b6:a03:3b9::19)","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"SJ0PR11MB5645:EE_|CO1PR11MB4916:EE_","X-MS-Office365-Filtering-Correlation-Id":"19b3464a-cc84-4d77-99d3-08de916a58c6","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n BCL:0;ARA:13230040|1800799024|7416014|376014|366016|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n eihmQWhQ6LMkoxmWkbTr4RtqAIP3Nm6Ykn3U311KtwYXroQIvg6YHlxRblRsFQj27ZZCD20KMJR9rnv1qSzciQKOY5IAaZlerrtM6Kr4TgLGb9QM+GySvBD+Lm0CMb/+WxdjzIwFEGF8pDvs06ig4hJYx7cKB5ptmsBaWsHliiGFr+eTe58WiYNQxSmxvljEsJTkm2y1owVCIeDbmJG8VJFc8etzpt0Trt+rBKtn9Wr17mkXWvqxomd7YWLqxDchnkHBMukI/UCudNOYXWF5ntIKy+lKgpY8q1FPul6j+WaCTRy3Rt0+S5t0SQi5PMArxNSXR/mCxC1eDcxaXYsIfusoZWCYinfrsWpZGRl9oFL/W8WjYA5bd7a1S7aQhDpUcww4Lp2Xw026p0fWby0MG4EdX5lmAV09p7xvOEjQdgpnojnYWb5tMR3qeafjVeJ3O4SgAyL28OZiWHFEDEnxG8K8iGPe26f8X2EwXCHUD67GN3PY2MT7kLtu6t1TXRy+KMS1qqt1gKaYCiOUp0EYU4NXrJV8LN2NDg6sNKsbAFG+U94FKzZ+SRYQtFJwFeAbz4CEkoPUUbz9I4XvT/Qh+PzqJYI2BukwOnrcq/NaZY1BmGe2JHh+zo/7SQP68MYi9OtXRrFBXQMLWA68JbQZ04YomCA5uGRJsJfVKo3zFfzZUkBYfp43DrdD8/8BG6TOBXNv5rywX7vYD67vcfBd0YFhAAG6sU2bKQv5b3s1x8Q=","X-Forefront-Antispam-Report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB5645.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n l53uTvCFWuet+RenT0RzLs9CL/sJJDtD4k/xOUfa2NUTaVx6WRT8Vbl74bIvNBRtzm4bvVznRjuMnUde/7P4LusDu/e/htKz8pm/cZekYhH1dMGVnfc4nTjYjhzCBRu0ceZCBLhismX9bf/UGhjsO0YpxS1aDgt8lP6Pvdm8uIe09cUB1IwdeC5OF7cEQC9fcMyGqP0rL4B3eBI3dmhKNTxVQBKKUNswjlY0k+ITyBSFLW1y6ETEBmCznNo4BC0vaJqSLBsi3BiPG3EJMRRdUmih4X1XaMAXwOMwfVlVQg+SBoY9gjqjwWm3shzttle6BNkrW33o4H/H0ftrrYIhFUtbRg2pprLklLKjEYDUy9qMjEsvTSIGS7cD0dZm8/q4/LRdzFu4iCrND3XLeT9OgDmMgvRlQOHOCbKITqz1VSwjLZBYucQEoZjwGWO/4zHXHqAOD9ISfTLOzS0qHistopVO8vObsD1IYpLtjM+NMpguRkC5wf5/T8Z3J/mPLZ5vkVr7u9kahXIRJ+7CXqhknCaxvB7IEmoVfWskCBccjhD/TcWAf6kPvT0ZHf4t7vuEAsz2MH3UXBzTQukJzTsePlriKGcSNYHphtf6gQz+dt3h9pWjHgzT+ULBvAFEIOwYjrLhtw0P0DOJuqyzA0gfevA3u1GTcH53NtrqCqr1k53MiaeTfAWyzNSX1TZfXKlqHOwGsrH11uoeZlhYJBYhMNDQasx4cYTWwbhx4KrYDFFOtR4oVDYpVC/HIeEKca85y8/2sDFYLllh5Pm50jC6U4+5CLJrw87EwRO2x66guw+FiSoFQBwMhYrgun/+ppPhz3WS35agfwUwYZr+DEs5IflpO9WGeb1o1zuD8CdMErddvNrW0KyutaMOQFRlKqrw5eoK80/QwMrWHz+y3V7VX3D4+93Y7ASAPEUp/uWVaK4eN30YT4IgtF1UoWG9yBpcytoOLQMxiKz2U4qvVy+uz6gjI1CoheHhtZZN4k0cz+jvh3fUPz+DOYHg+wBYaMgvq7Vh42yFqxe0FXmF7KylaqUNXVWMtT79hgwMA7hB8lolzC6+xAnh68vFI3BAl5qsUVF/P+Y5Ba50baSQB+wkmKI2RXSsfcPEjfc3Z5J76ha6bJNAd05cWTf7RgsY7mb5VypddYzMCfnBhujSOQSXrY5RLXAuhtTpkPNdXcFGHKqzNA7Nk4vx/jzEbtpZ07QeheazA6BchwrdLXhgNWm4Cv7TMgUZIdabHN3CzpyVsVPupcVTTQT/bUU4bAs65aJ7CLdYvAquxaJD4/l1fuCIpVkP9RxIdbTIquqFdYQS43TeHks8usj6aFXeE6AQW3Sr8wNPUGNxjKDkzY3Z8/iVXARwRqF7r4X/czW0gGpFXFCG7ybh0Izjt1Utf8994uZUAXZpT3nwI1d7F5xE/U9Azi0wmmSnMKvrR/xvjDSagLb28Gmqef1EiHnXxsKuKI4wfJJqZAqhDDycyg4DrIP2pZTKo+lFsq/+jprWkHWCkjJUJ1e7gPT2q1GW0miT0m7Q94/s89lO+ZAlAt/EdUJYNCVH65DVafqLHLBgEyYc4BmOUTmMXdmXhwacBeGVWZuBVWzuVSuAVbHLO179ZA9jsSWa0dHeTH2ZqjY1WeGbCrPQn9EaxvfkTozfMmjzuJ3RHm8KQqoT62ia0R3RXGSN3BFKvWm/1tKn+tCuBPtauHdgYN8Ba7dBaC9HcmoFXq+JIxJkUcnbIoCKIzQeTj5DHw==","X-Exchange-RoutingPolicyChecked":"\n A/QZRgZdufznLWGHpXVvyRfjTtC9BoihWvWJ+dCX5hiBo/rh3wNmtZUoUvi7wlglQGVkym44CE/X9bf6wo8yyuc0T6y4C5E06M2lJC2hKbKj/bCAEk/6/gl1JZ24I/C3fb9uVAAhReXvw9UKRFnauCllZnqv/OWyf20cDnU+HpA9vVNyHcxPCnsiG9tZcIyar+DDGZDqUeh7plKuWWNSMIr6479l+2vRiOb/4D+AbTsQld3a6KojbhK9OJ21VDtb1U3g/YZgVpcaJletMsZZaZfdaCqEnMGEGiB/KhChfsjvFyb4HqA7wF39vbWXUMEPSS3pCMP0k61bNgIVQU+0Ww==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 19b3464a-cc84-4d77-99d3-08de916a58c6","X-MS-Exchange-CrossTenant-AuthSource":"SJ0PR11MB5645.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"03 Apr 2026 10:18:27.9157\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n CIWvlHcSShE7s22fJbiM4qZKjSFbAupqourbmTQz8u7+TLV3YmzDBl7HItbRsKBXtlXXvAT5Qu1TnBBK/sdecA==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CO1PR11MB4916","X-OriginatorOrg":"intel.com","X-Spam-Status":"No, score=-2.4 required=3.0 tests=ARC_INVALID,ARC_SIGNED,\n\tDKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n\tRCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3673413,"web_url":"http://patchwork.ozlabs.org/comment/3673413/","msgid":"<7bqnm5he.ritesh.list@gmail.com>","date":"2026-04-04T09:37:01","subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","submitter":{"id":79126,"url":"http://patchwork.ozlabs.org/api/people/79126/","name":"Ritesh Harjani (IBM)","email":"ritesh.list@gmail.com"},"content":"Yosry Ahmed writes:\n\n> On Wed, Mar 25, 2026 at 02:15:11AM -0700, Peter Fang wrote:\n>> kvm_vcpu_map() and kvm_vcpu_map_readonly() should take a gfn instead of\n>> a gpa. This appears to be a result of the original kvm_vcpu_map() being\n>> declared with the wrong function prototype in kvm_host.h, even though\n>> it was correct in the actual implementation in kvm_main.c.\n>> \n>> No actual harm has been done yet as all of the call sites are correctly\n>> passing in a gfn. Plus, both gfn_t and gpa_t are typedef'd to u64 so\n>> this change shouldn't have any functional impact.\n>> \n>> Compile-tested on x86 and ppc, which are the current users of these\n>> interfaces.\n\nMostly a mechanical change. I had looked at ppc call site and looks ok\nto me.\n\n>> \n>> Fixes: e45adf665a53 (\"KVM: Introduce a new guest mapping API\")\n>> Cc: KarimAllah Ahmed \n>> Cc: Konrad Rzeszutek Wilk \n>> Signed-off-by: Peter Fang \n>\n> Most callers are converting a GPA to a GFN, I wonder if we should make\n> the function take in a GPA instead? But then we'll need to the GPA not\n> being aligned to a page boundary (either do gpa_to_gfn() in\n> __kvm_vcpu_map() or fail if it's not aligned).\n>\n> Not sure if that's a net improvement, mostly thinking out loud here.\n\nThe suggestion from Yosry and Sean sounds good too. Instead of every\ncaller of kvm_vcpu_map() doing gpa_to_gfn(), we may as well make\nkvm_vcpu_map() accept gpa_t instead and do the gpa_to_gfn() inside\nkvm_vcpu_map() in the call to __kvm_vcpu_map(vcpu, gpa_to_gfn(gpa),...),\nor within __kvm_vcpu_map() which is fine too, however, the former is a\nbetter approach, IMO.\n\n-ritesh","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gO3lj+KM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19308-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2607:f8b0:4864:20::42a\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gO3lj+KM;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2607:f8b0:4864:20::42a; helo=mail-pf1-x42a.google.com;\n envelope-from=ritesh.list@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fnrDb2Klvz1xtJ\n\tfor ; Sat, 04 Apr 2026 20:40:30 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fnrDY41YJz2ygd;\n\tSat, 04 Apr 2026 20:40:29 +1100 (AEDT)","from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com\n [IPv6:2607:f8b0:4864:20::42a])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fnrDW72r1z2yC9\n\tfor ; Sat, 04 Apr 2026 20:40:26 +1100 (AEDT)","by mail-pf1-x42a.google.com with SMTP id\n d2e1a72fcca58-824c9da9928so1662015b3a.3\n for ;\n Sat, 04 Apr 2026 02:40:26 -0700 (PDT)","from pve-server ([49.205.216.49])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c76c647792bsm7698445a12.6.2026.04.04.02.40.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 04 Apr 2026 02:40:18 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775295629;\n\tcv=none;\n b=kwd4t+9pRDq418CU6bmYZG+zUqYlBfS8I4IleMTfAU7HplXxRyqt8JiePjjlJtH3gDdHsURtUut7gNWY/pFUju+Rwgy3wTNmdzBBVy4C3vLTZfsZc2LDQ++3huQpTNXQ/9OgeGbw/QgcYinhU8wl8qiycKdsYKCGXQ7wCTignsiUR/JZuOgGEPzMSobbsbFCTKt9BMKk36KXCd2tNIbBnG1gGhe/uDcS/UOGAHlTKK4JoTrAiRd5BXgbSgQWoplkxb/bND5+iQAOCW8wehH7/LV03DiexPNWt4jp+tgpxWcfFIGkzYcn0dSk3NiT5OjtwkvXNXF4kFXrs5tvA+RihA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775295629; c=relaxed/relaxed;\n\tbh=rOaxQXfX6SiiuBlcP8X1nQXWObPEsgiGGDciqZtKDLA=;\n\th=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References;\n b=dnITImGiCv9jmYdQ9FU6QLfR2uVByTZTIBZmnchzXXywujb+JTUkxZiJDOX6WAcH3OwqchmUpRJe8WtQP76gqgNi8D3SZwq68fNqrfZAZcAP+MnCvp8eN/SnRLX2R2PR/yMlh46z5I4Fjyzcw94WApmBeROnSz3r9k1fb/Ej/4JgSgFZqPSBizmgxQ/xPJWJpNdoXrzh9vxcyR9ht0NsIE0nYY3uHdAUIlGs8/dXJexHO5EYqi5PxH9PJewd16Ku5FkGR5EXNG/fkqyqW0rJQrgDwGVw+yCmL7B4RzLggagxcJnwwfNLo0AZYG1RZKNZFedB1wx+nW0Qt7fWnytDWA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=gO3lj+KM; dkim-atps=neutral;\n spf=pass (client-ip=2607:f8b0:4864:20::42a; helo=mail-pf1-x42a.google.com;\n envelope-from=ritesh.list@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775295619; x=1775900419;\n darn=lists.ozlabs.org;\n h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to\n :cc:subject:date:message-id:reply-to;\n bh=rOaxQXfX6SiiuBlcP8X1nQXWObPEsgiGGDciqZtKDLA=;\n b=gO3lj+KM4Z1mxkST0ABtrcw4/mV6kfAjtQEWZJEY/EavnKJJ7ffvKcf6g6O6VbHlIF\n UZ2ZuyHNuniR2FGiRBZRYO/dq8XgX2GFzIQ+JUhhA2QxrKaSBxMCu+TwKJ1/5TVyiOZO\n Qi27WLkP222sQu5uw7t1vLW3YuOvm1OpnIXIUgrK3mBz/gXHHmyxymyqRWADvowP5BvG\n fd5wKQKvILtmA4n8wGVRL2NyuaXen5TH2NW4VG7Q8i2PYsJ+MFnp+uy45+u42Cn0T/Q2\n 65ERJWaWIHBjW/+a6/KarC7kaiglgpNi2MUPVM6kycg/vMXLoqZrh2TREzGQ8g7cWZCm\n YsXg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775295619; x=1775900419;\n h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=rOaxQXfX6SiiuBlcP8X1nQXWObPEsgiGGDciqZtKDLA=;\n b=P56AZT+iAmHWEOJWv/C6KV5slomEfPrMr1uDbxBS/xLCe5znxAsHECPWVVWpT/eHEO\n iIvCUMWoeJQWnRDwPUzXDeUTc9DieEC17VyM4HQDz5QiQw1lxR5gWBGBfvUJJvz3YWKH\n CJnrec3VfeGoxnm3dd7LZfXpSIPaS7ZiODYxfvtcuqZ3XJ5e0fu5aWRbYp7BAWa7Qdlb\n hQIP1H38ZU/bFkcVQR78It3xXilodNMXm1vMW4SLsJJVzXxG2NKje12aEtgUMtUBnMsT\n LYFhkdTNhXmdT+tc+tobJBykqJPnh+ck4p5FXfpEkjY2PS7jblocGWBsP2FDFrbLlygG\n cJMw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXg0Qeb/xoim3AcpbzHL/2DeVunupwI9bv+AB72zB/Lh/wH5Tu1wR/5CTY1gsz71uGxT1gc/lWGUkI8uZM=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0Yxcf/PAxSbl+r7bkUcOuk7t0jvlUYItWWAjjIgI5pmO1POy/S2O\n\tuh4GVDa1ce6/qTw5If4UF8sAMETBmnrFLxTdizX3taAqdWpknlChP7bJ","X-Gm-Gg":"AeBDievj9OCkD20o9p7q0zqAXnDailMDE57SlQUs0v6cijlg6tMMqyPkEfrwmek7FxD\n\tKjRazy92m34raibnOdtxvUyTNAEflnFQmADFdJ+HkJeTnCeu+MfIBNDGKtxdmdXQQIJaPYhMpBU\n\t79v//fh/ZgZjadnabypQ/Ns1fn88WjfpGHpGpIKaIpJxKdqNYNBSepoeTCHQnmS0CiwX4WAykJ6\n\t1huQSXnKm8YBkR9fTeoSTzitm9pgx1niNPtl1ZsU5zNaz3oH2zewNF86HyHuYBLhR4CI4KQMtK4\n\t5yHfsR1yaI627zBb74aafX4GIxraUnb6S5DQa8wrn2OsvUzIYSksPfsOSSsGO3IDk+mnQk/l7dr\n\tZMEcDbHQdGXBvV5+8a3YgPR+BVl0XiVfY3ZncCxSp9yhqy5qQNhcBnOgd+wDeViP8fsST8hS8au\n\tTaeK+rtnRcH2+lDGUUV4gEWA==","X-Received":"by 2002:a05:6a20:430b:b0:398:6ea8:21d2 with SMTP id\n adf61e73a8af0-39f2ed8d9e7mr6111236637.19.1775295619301;\n Sat, 04 Apr 2026 02:40:19 -0700 (PDT)","From":"Ritesh Harjani (IBM) ","To":"Yosry Ahmed , Peter Fang ","Cc":"Paolo Bonzini ,\n Sean Christopherson ,\n Madhavan Srinivasan ,\n Nicholas Piggin , kvm@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n KarimAllah Ahmed ,\n Konrad Rzeszutek Wilk ","Subject":"Re: [PATCH] KVM: Fix kvm_vcpu_map[_readonly]() function prototypes","In-Reply-To":"","Date":"Sat, 04 Apr 2026 15:07:01 +0530","Message-ID":"<7bqnm5he.ritesh.list@gmail.com>","References":"<20260325092001.613025-1-peter.fang@intel.com>\n ","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list"}}]