[{"id":3669819,"web_url":"http://patchwork.ozlabs.org/comment/3669819/","msgid":"<20260326161957.GA1324845@bhelgaas>","list_archive_url":null,"date":"2026-03-26T16:19:57","subject":"Re: [PATCH v11 2/3] of: Factor arguments passed to of_map_id() into\n a struct","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"[cc->to: Richard, Lucas for pci-imx6.c question]\n\nOn Wed, Mar 25, 2026 at 04:38:23PM +0530, Vijayanand Jitta wrote:\n> From: Charan Teja Kalla \n> \n> Change of_map_id() to take a pointer to struct of_phandle_args\n> instead of passing target device node and translated IDs separately.\n> Update all callers accordingly.\n> \n> Add an explicit filter_np parameter to of_map_id() and of_map_msi_id()\n> to separate the filter input from the output. Previously, the target\n> parameter served dual purpose: as an input filter (if non-NULL, only\n> match entries targeting that node) and as an output (receiving the\n> matched node with a reference held). Now filter_np is the explicit\n> input filter and arg->np is the pure output.\n> \n> Previously, of_map_id() would call of_node_put() on the matched node\n> when a filter was provided, making reference ownership inconsistent.\n> Remove this internal of_node_put() call so that of_map_id() now always\n> transfers ownership of the matched node reference to the caller via\n> arg->np. Callers are now consistently responsible for releasing this\n> reference with of_node_put(arg->np) when done.\n> ...\n\nNot actually part of *this* patch, and AFAICS this patch is correct\nas-is, but is it necessary to have different logic around\nof_node_put() for imx_pcie_add_lut_by_rid() and\napple_pcie_enable_device()?\n\n> +++ b/drivers/pci/controller/dwc/pci-imx6.c\n> @@ -1137,6 +1137,8 @@ static void imx_pcie_remove_lut(struct imx_pcie *imx_pcie, u16 rid)\n> \n> static int imx_pcie_add_lut_by_rid(struct imx_pcie *imx_pcie, u32 rid)\n> {\n> +\tstruct of_phandle_args iommu_spec = {};\n> +\tstruct of_phandle_args msi_spec = {};\n> \tstruct device *dev = imx_pcie->pci->dev;\n> \tstruct device_node *target;\n> \tu32 sid_i, sid_m;\n> @@ -1144,7 +1146,12 @@ static int imx_pcie_add_lut_by_rid(struct imx_pcie *imx_pcie, u32 rid)\n> \tu32 sid = 0;\n> \n> \ttarget = NULL;\n> -\terr_i = of_map_iommu_id(dev->of_node, rid, &target, &sid_i);\n> +\terr_i = of_map_iommu_id(dev->of_node, rid, &iommu_spec);\n> +\tif (!err_i) {\n> +\t\ttarget = iommu_spec.np;\n> +\t\tsid_i = iommu_spec.args[0];\n> +\t}\n> +\n> \tif (target) {\n> \t\tof_node_put(target);\n\nHere it's conditional on \"target\" even though of_node_put() checks\ninternally for non-NULL, so it would be safe without the conditional\nhere.\n\n> \t} else {\n> @@ -1156,8 +1163,11 @@ static int imx_pcie_add_lut_by_rid(struct imx_pcie *imx_pcie, u32 rid)\n> \t\terr_i = -EINVAL;\n> \t}\n> \n> -\ttarget = NULL;\n> -\terr_m = of_map_msi_id(dev->of_node, rid, &target, &sid_m);\n> +\terr_m = of_map_msi_id(dev->of_node, rid, NULL, &msi_spec);\n> +\tif (!err_m) {\n> +\t\ttarget = msi_spec.np;\n> +\t\tsid_m = msi_spec.args[0];\n> +\t}\n> \n> \t/*\n> \t * err_m target\n\nAnd here (outside the diff context) we also call of_node_put()\nconditionally:\n\n ...\n else if (target)\n of_node_put(target);\n\n> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c\n> index a0937b7b3c4d..c2cffc0659f4 100644\n> --- a/drivers/pci/controller/pcie-apple.c\n> +++ b/drivers/pci/controller/pcie-apple.c\n> @@ -755,6 +755,7 @@ static int apple_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_d\n> {\n> \tu32 sid, rid = pci_dev_id(pdev);\n> \tstruct apple_pcie_port *port;\n> +\tstruct of_phandle_args iommu_spec = {};\n> \tint idx, err;\n> \n> \tport = apple_pcie_get_port(pdev);\n> @@ -764,10 +765,12 @@ static int apple_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_d\n> \tdev_dbg(&pdev->dev, \"added to bus %s, index %d\\n\",\n> \t\tpci_name(pdev->bus->self), port->idx);\n> \n> -\terr = of_map_iommu_id(port->pcie->dev->of_node, rid, NULL, &sid);\n> +\terr = of_map_iommu_id(port->pcie->dev->of_node, rid, &iommu_spec);\n> \tif (err)\n> \t\treturn err;\n> \n> +\tof_node_put(iommu_spec.np);\n\nHere we call of_node_put() unconditionally.\n\nI think it would be much nicer if imx_pcie_add_lut_by_rid() used the\nsame style as apple_pcie_enable_device() and did the of_node_put()\nunconditionally. That would untangle the function a bit and make it\neasier to analyze.\n\n> +\tsid = iommu_spec.args[0];\n> \tmutex_lock(&port->pcie->lock);\n> \n> \tidx = bitmap_find_free_region(port->sid_map, port->sid_map_sz, 0);","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=F8mHPbZM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-51203-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"F8mHPbZM\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhTYh6bbQz1y1x\n\tfor ; Fri, 27 Mar 2026 03:21:44 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id E7B273016AE4\n\tfor ; Thu, 26 Mar 2026 16:20:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2EDDB3BFE24;\n\tThu, 26 Mar 2026 16:19:59 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AF67394799;\n\tThu, 26 Mar 2026 16:19:58 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 58181C116C6;\n\tThu, 26 Mar 2026 16:19:58 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774541999; cv=none;\n b=Pt17Ym0TTJg0WF63ESf6hP0F6aRLugnspj4p4VT2WXGNPGmifrCozeaPpNbjzh+K5/3bAeUXjR+E4MZ8+QPM51cFx2jA0zzg7dcDM26KFXne1a/cRXzo3NGFEGh8FH9eUYvgY8emqG4TLkXGxohLFC+wZpbVhlSomfnTSIl9jEk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774541999; c=relaxed/simple;\n\tbh=HUtRwEpymq8y1tHT5IuCcbjZ8WgelRutIBJgFxgBfwY=;\n\th=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:\n\t Content-Disposition:In-Reply-To;\n b=Nh3GDQ1K/Dlmns3pEiP7iu5pALHQQQhqqwlq4K48jB7ip6yfWThZYwov4EesUDfSL4MEqNqEBP5B/CYHZeoMUnTbWR//heA28XYyZndZi2OYNfN/TsVFu9kqqFYrq4AxmByJIiuSRGk+NOrdcNICw+FFIHK9xIFJuOBkVd/v0x4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=F8mHPbZM; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774541998;\n\tbh=HUtRwEpymq8y1tHT5IuCcbjZ8WgelRutIBJgFxgBfwY=;\n\th=Date:From:To:Cc:Subject:In-Reply-To:From;\n\tb=F8mHPbZMLywhR2KPKiO47GUlQve1aWTvrP9jUY2zHBn/GgXJAJ8kIosO6KRmT2xPy\n\t 0IOXnbxBuiHeZMvRl+TjIGCZL+xLIklcHleCk7JhPz7DuyprdCRvXeIavUjsvsJn3u\n\t 2Q1RhEo14xk900QBnukOrxjvVlgBCi/2LncSYTzSdhsFA5hJ9IBKJY83E/k7nfnIj+\n\t 5lTlIF6wm86KROEBrkkqhHauUmxF3ByqGulkPiq2SUiGMalg+b2lo7okZjYoEqA7SE\n\t DQIUYImcIBQS+JZCWgUDtLEZ0SBKAUGmugBagt425A+Pxg6+wxIOHa2m/AYEY0slHj\n\t ZzEGDAJHfpMMw==","Date":"Thu, 26 Mar 2026 11:19:57 -0500","From":"Bjorn Helgaas ","To":"Vijayanand Jitta ,\n\tRichard Zhu ,\n\tLucas Stach ","Cc":"Nipun Gupta ,\n Nikhil Agarwal , Joerg Roedel ,\n Will Deacon , Robin Murphy ,\n Marc Zyngier , Lorenzo Pieralisi ,\n Thomas Gleixner , Saravana Kannan ,\n Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ,\n Manivannan Sadhasivam , Bjorn Helgaas ,\n Frank Li , Sascha Hauer ,\n Pengutronix Kernel Team ,\n Fabio Estevam , Juergen Gross ,\n Stefano Stabellini ,\n Oleksandr Tyshchenko ,\n Dmitry Baryshkov ,\n Konrad Dybcio ,\n Bjorn Andersson ,\n Rob Herring , Conor Dooley ,\n Krzysztof Kozlowski ,\n Prakash Gupta ,\n Vikash Garodia ,\n linux-kernel@vger.kernel.org, iommu@lists.linux.dev,\n linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,\n linux-pci@vger.kernel.org, imx@lists.linux.dev,\n xen-devel@lists.xenproject.org, linux-arm-msm@vger.kernel.org,\n Charan Teja Kalla ","Subject":"Re: [PATCH v11 2/3] of: Factor arguments passed to of_map_id() into\n a struct","Message-ID":"<20260326161957.GA1324845@bhelgaas>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260325-parse_iommu_cells-v11-2-1fefa5c0e82c@oss.qualcomm.com>"}},{"id":3670162,"web_url":"http://patchwork.ozlabs.org/comment/3670162/","msgid":"<2c21c307-99bd-4051-8c09-06d370ad9b24@oss.qualcomm.com>","list_archive_url":null,"date":"2026-03-27T09:35:02","subject":"Re: [PATCH v11 2/3] of: Factor arguments passed to of_map_id() into a\n struct","submitter":{"id":92739,"url":"http://patchwork.ozlabs.org/api/people/92739/","name":"Vijayanand Jitta","email":"vijayanand.jitta@oss.qualcomm.com"},"content":"On 3/26/2026 9:49 PM, Bjorn Helgaas wrote:\n> [cc->to: Richard, Lucas for pci-imx6.c question]\n> \n> On Wed, Mar 25, 2026 at 04:38:23PM +0530, Vijayanand Jitta wrote:\n>> From: Charan Teja Kalla \n>>\n>> Change of_map_id() to take a pointer to struct of_phandle_args\n>> instead of passing target device node and translated IDs separately.\n>> Update all callers accordingly.\n>>\n>> Add an explicit filter_np parameter to of_map_id() and of_map_msi_id()\n>> to separate the filter input from the output. Previously, the target\n>> parameter served dual purpose: as an input filter (if non-NULL, only\n>> match entries targeting that node) and as an output (receiving the\n>> matched node with a reference held). Now filter_np is the explicit\n>> input filter and arg->np is the pure output.\n>>\n>> Previously, of_map_id() would call of_node_put() on the matched node\n>> when a filter was provided, making reference ownership inconsistent.\n>> Remove this internal of_node_put() call so that of_map_id() now always\n>> transfers ownership of the matched node reference to the caller via\n>> arg->np. Callers are now consistently responsible for releasing this\n>> reference with of_node_put(arg->np) when done.\n>> ...\n> \n> Not actually part of *this* patch, and AFAICS this patch is correct\n> as-is, but is it necessary to have different logic around\n> of_node_put() for imx_pcie_add_lut_by_rid() and\n> apple_pcie_enable_device()?\n> \n\nThanks for the review comments. Right, there is no need to have different\nlogic, I will update imx_pcie_add_lut_by_rid() in v12 so that of_node_put()\nwould be called unconditionally.\n\n>> +++ b/drivers/pci/controller/dwc/pci-imx6.c\n>> @@ -1137,6 +1137,8 @@ static void imx_pcie_remove_lut(struct imx_pcie *imx_pcie, u16 rid)\n>> \n>> static int imx_pcie_add_lut_by_rid(struct imx_pcie *imx_pcie, u32 rid)\n>> {\n>> +\tstruct of_phandle_args iommu_spec = {};\n>> +\tstruct of_phandle_args msi_spec = {};\n>> \tstruct device *dev = imx_pcie->pci->dev;\n>> \tstruct device_node *target;\n>> \tu32 sid_i, sid_m;\n>> @@ -1144,7 +1146,12 @@ static int imx_pcie_add_lut_by_rid(struct imx_pcie *imx_pcie, u32 rid)\n>> \tu32 sid = 0;\n>> \n>> \ttarget = NULL;\n>> -\terr_i = of_map_iommu_id(dev->of_node, rid, &target, &sid_i);\n>> +\terr_i = of_map_iommu_id(dev->of_node, rid, &iommu_spec);\n>> +\tif (!err_i) {\n>> +\t\ttarget = iommu_spec.np;\n>> +\t\tsid_i = iommu_spec.args[0];\n>> +\t}\n>> +\n>> \tif (target) {\n>> \t\tof_node_put(target);\n> \n> Here it's conditional on \"target\" even though of_node_put() checks\n> internally for non-NULL, so it would be safe without the conditional\n> here.\n> \n\nAgreed, here of_node_put can be called unconditionally , will fix it in v12. \n\n>> \t} else {\n>> @@ -1156,8 +1163,11 @@ static int imx_pcie_add_lut_by_rid(struct imx_pcie *imx_pcie, u32 rid)\n>> \t\terr_i = -EINVAL;\n>> \t}\n>> \n>> -\ttarget = NULL;\n>> -\terr_m = of_map_msi_id(dev->of_node, rid, &target, &sid_m);\n>> +\terr_m = of_map_msi_id(dev->of_node, rid, NULL, &msi_spec);\n>> +\tif (!err_m) {\n>> +\t\ttarget = msi_spec.np;\n>> +\t\tsid_m = msi_spec.args[0];\n>> +\t}\n>> \n>> \t/*\n>> \t * err_m target\n> \n> And here (outside the diff context) we also call of_node_put()\n> conditionally:\n> \n> ...\n> else if (target)\n> of_node_put(target);\n> \n\nAgreed, same as above.\n\n>> diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c\n>> index a0937b7b3c4d..c2cffc0659f4 100644\n>> --- a/drivers/pci/controller/pcie-apple.c\n>> +++ b/drivers/pci/controller/pcie-apple.c\n>> @@ -755,6 +755,7 @@ static int apple_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_d\n>> {\n>> \tu32 sid, rid = pci_dev_id(pdev);\n>> \tstruct apple_pcie_port *port;\n>> +\tstruct of_phandle_args iommu_spec = {};\n>> \tint idx, err;\n>> \n>> \tport = apple_pcie_get_port(pdev);\n>> @@ -764,10 +765,12 @@ static int apple_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_d\n>> \tdev_dbg(&pdev->dev, \"added to bus %s, index %d\\n\",\n>> \t\tpci_name(pdev->bus->self), port->idx);\n>> \n>> -\terr = of_map_iommu_id(port->pcie->dev->of_node, rid, NULL, &sid);\n>> +\terr = of_map_iommu_id(port->pcie->dev->of_node, rid, &iommu_spec);\n>> \tif (err)\n>> \t\treturn err;\n>> \n>> +\tof_node_put(iommu_spec.np);\n> \n> Here we call of_node_put() unconditionally.\n> \n> I think it would be much nicer if imx_pcie_add_lut_by_rid() used the\n> same style as apple_pcie_enable_device() and did the of_node_put()\n> unconditionally. That would untangle the function a bit and make it\n> easier to analyze.\n> \n\nSure, as mentioned above will align imx_pcie_add_lut_by_rid() and\napple_pcie_enable_device().\n\nThanks,\nVijay\n>> +\tsid = iommu_spec.args[0];\n>> \tmutex_lock(&port->pcie->lock);\n>> \n>> \tidx = bitmap_find_free_region(port->sid_map, port->sid_map_sz, 0);","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=dfqtedcK;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=NhDIfWBq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-51266-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"dfqtedcK\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"NhDIfWBq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhwVP2lJrz1xy1\n\tfor ; Fri, 27 Mar 2026 20:35:25 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 77F32303972D\n\tfor ; Fri, 27 Mar 2026 09:35:22 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 64A7F3A6EE5;\n\tFri, 27 Mar 2026 09:35:21 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F5978F4A\n\tfor ; Fri, 27 Mar 2026 09:35:20 +0000 (UTC)","from pps.filterd (m0279864.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62R6wusM2846199\n\tfor ; Fri, 27 Mar 2026 09:35:19 GMT","from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d53eqmeay-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Fri, 27 Mar 2026 09:35:19 +0000 (GMT)","by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2b064884a7cso63019445ad.3\n for ; Fri, 27 Mar 2026 02:35:19 -0700 (PDT)","from [10.219.57.109] ([202.46.23.19])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b0bc7a7e3bsm72543195ad.27.2026.03.27.02.35.07\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 27 Mar 2026 02:35:17 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774604121; cv=none;\n b=brBgUHz9CVguJoLUKTktTb7JRTGjiuYcFIKBr6/OzdPS4o9j87KKsA0ksvqkdo7T7zpzALfInw33miVBXZhdUiFtfUeA4gtZDWGk7QoRXV6p2pcUxMjKbZUzpt/uF4RFxZQAyJd9gtLP3mMGAsRghAd3WYwwslPp4QMxAK5/Zf8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774604121; c=relaxed/simple;\n\tbh=iJOHN8dmGPbQD80ivaf5mntVO+SR076qCtKMvmHaQFU=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=VYr7mdHPSpkSWu8l9KVsdEWH1WDPJDmjFN8BciQ2Nu61B/dT6aDhz9/NKu5ysBS9nNrcrmcFB/kxhqNS8Xq9kx0FMDQJSoMi0jvwFCRpZdliaf8lvoMqmi7s2Qanor/+vE8agGiqV36MM68QHIMh4WEutXMaKX/D6v/bDBO3/aM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=dfqtedcK;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=NhDIfWBq; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tiimVuL7Si0EC2QW/qRbXnzLK0ktDtNjpoesWqPPB7kk=; b=dfqtedcKdd+VWg1M\n\t7rr8jESz/4pyob5K2fouLMEhfpda0yOt9fk6Il6m7RWjeliiACai4e+ZB2hlrx1I\n\t9MgYxRv0KQ/ku0BWB2gtqXXvKiBRNyf12jRfiUQuuolYntBskTlFgAufv+olHd4U\n\t9+pYzSrzGS/nBGGzKPqngAx3//YA4A3M7kaA4l965KaJ1iChtAww5Rf4BioiNEed\n\tzzoIYSIj9ktfWv7IMm3l/NGkcKvqOL4pYOu59I2WfsLqBIG6r82rTb5Ka8Nq3b8H\n\tykkyk8hGHoSagfqLpuEBqOyCW+kifxN5Cw9NttYhmJ8EX02pYG8IZakCzrf4EwZ0\n\t7Q/RGw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1774604119; x=1775208919;\n darn=vger.kernel.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=iimVuL7Si0EC2QW/qRbXnzLK0ktDtNjpoesWqPPB7kk=;\n b=NhDIfWBqzUrCww5WIo2cyAnSL4SWqKA6N5CPZOG5KYeb6xM8jh9t2pP4ZQbmFouj08\n pfTOdX5stEWoAUlmdUq2zTD3XBcer3r4RgIZ6VGX3VSROQTxfNvsFtH12ospxs5ouuKl\n A2efCeHRmUv+zO0v6AdUThWFaHj6TrfekhE3OgX0Qb8B+YhFTu81jb6Vp0SZung72P65\n vFS2TYnPWYvlER8lo2MwbwGViTF3RCnleS5ZQH+taG9oxGjHE9uOUWmqvwGjcLMzlKaK\n owMIoVdD+ryk895hsaY4ArKEDpE18C8EtNOgs0KnnYcNpn49T9qHV2Ac4J7FyfBgiIL8\n XB0g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774604119; x=1775208919;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=iimVuL7Si0EC2QW/qRbXnzLK0ktDtNjpoesWqPPB7kk=;\n b=bAMASw4yIjRE3ml1D366V+sdfxiSVMSIWcHv2HLqLGU5MTkeM+j8RpjcowfXhpiWeZ\n aGYVAmEBVBM4sxxUsVAYRHLeC7Ni3xqHOXtJEX5TVUp5kHzZQHXvYMtd671vBJEUNxEw\n 3eDa+6SgO+MHZElt0R/Nx8XvBsy/O8fAXvrDf6e+zu/vGGzU/5QvRQDoaQRGsbpDLA6i\n fZ2PWS8H+KefVCH55zFmGW5CSOlg4QilGJLr0r4wIO96v3K9nswlMFvDoZTBJRuWgpEb\n GcPuvd54OTvHzvyva4khhQNOoW1stOQX0+UFyI0o2wT9zd8cBzQxGiDWbGasPxiiKy0A\n LVVA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXESA5UAdHVop0VNCUf6De6SNpe+HacAlEctPNnb9Tq2iduQCuckeJvR3je90dGJrqRVQ2L70oC/bk=@vger.kernel.org","X-Gm-Message-State":"AOJu0YzxS48rwOdsLedd+RPEb7EMdkCZyLmxBvpfS6DPx0go9ESBC69D\n\tI9s0itLVZjpzxw/HePq6ex5prCqK9BjT3hgxCCf0qQ0XT/Ekal9nN8KUmobbxoe6omZ1edNqTE4\n\tgkX51bDLgXytZDLRi2FqGtRBVTIWRWzvoIT2nwWCkigWPMgOqZvZmCMNRtKbmHCU=","X-Gm-Gg":"ATEYQzwhLH8+sqoRDTSSxf/scqxe401GZYust6pOCEDRRgqpeGLGKnU6negLyWcuhYg\n\tqX697ICUPb+4IPMqaB0zX+UgEWA+7EeYEQVkbrUAWPVgklPM+w7WR1vGPoGu79VuCnv8gwAWPmm\n\tC6yylCPdPpSm7gPiLBaGia42nh6JGoOxP/5XVt3u8PXkC471ziFGMXRGAckXYm6XYNbeC9E10sU\n\t2AxpMvbQomKvV7DGW8H/DRuish4MlLd0GvxqDu+mK5rnMDvCnkdaxsrYtULwtc+I5424ICD9f6f\n\tyUwacaGKz3defLgbwPkH1VIgn9WwYbmn/1alsw/ZBB6pI5dlUTTA9842UbJ71GgTViwWBUl/C7z\n\tbcZ8VT4HI614ZD3H5Oq9talEcTkbahIGI6pynINqaXyFSTlUQ4Gy69Dp0","X-Received":["by 2002:a17:902:d502:b0:2b0:6d8b:6a07 with SMTP id\n d9443c01a7336-2b0cdcaa738mr20284305ad.25.1774604118635;\n Fri, 27 Mar 2026 02:35:18 -0700 (PDT)","by 2002:a17:902:d502:b0:2b0:6d8b:6a07 with SMTP id\n d9443c01a7336-2b0cdcaa738mr20283585ad.25.1774604117910;\n Fri, 27 Mar 2026 02:35:17 -0700 (PDT)"],"Message-ID":"<2c21c307-99bd-4051-8c09-06d370ad9b24@oss.qualcomm.com>","Date":"Fri, 27 Mar 2026 15:05:02 +0530","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v11 2/3] of: Factor arguments passed to of_map_id() into a\n struct","To":"Bjorn Helgaas , Richard Zhu ,\n Lucas Stach ","Cc":"Nipun Gupta ,\n Nikhil Agarwal , Joerg Roedel ,\n Will Deacon , Robin Murphy ,\n Marc Zyngier , Lorenzo Pieralisi ,\n Thomas Gleixner , Saravana Kannan ,\n\t=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ,\n Manivannan Sadhasivam , Bjorn Helgaas ,\n Frank Li , Sascha Hauer ,\n Pengutronix Kernel Team ,\n Fabio Estevam , Juergen Gross ,\n Stefano Stabellini ,\n Oleksandr Tyshchenko ,\n Dmitry Baryshkov ,\n Konrad Dybcio ,\n Bjorn Andersson ,\n Rob Herring , Conor Dooley ,\n Krzysztof Kozlowski ,\n Prakash Gupta ,\n Vikash Garodia ,\n linux-kernel@vger.kernel.org, iommu@lists.linux.dev,\n linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,\n linux-pci@vger.kernel.org, imx@lists.linux.dev,\n xen-devel@lists.xenproject.org, linux-arm-msm@vger.kernel.org,\n Charan Teja Kalla ","References":"<20260326161957.GA1324845@bhelgaas>","Content-Language":"en-US","From":"Vijayanand Jitta ","In-Reply-To":"<20260326161957.GA1324845@bhelgaas>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMzI3MDA3MCBTYWx0ZWRfX+VUwilrYoizq\n S056tefeOenLx+V2P0dsvfXxoUq5+CVns1owWrlqdBw3GHkRpzB77bFsbdJHaJrgbTTTbQFCdYv\n yrTnw3o3MX4cjUwQ30ye7kQNESE+KbmVSsAv7Ty0Blelnt2p30Y6sKIz0fkVDfruKiB5WyCvoG4\n s2TNXRpKVj/x3Ouk2cL9hpLbMSiTtTEBc5qZBHguEr4gbBZlrM5zimho6SltbiWdMel8bza/Xmi\n dJs9YRVHsv48eAX0B3TQyPCt7ceSdOTFGPJVOaOd0OODb05knYfquFywLrazFqp7mhU9bkkCQ+u\n iA/1PRZa8fx3jcsuDS1Pzphe0RR1PECZd6cvTfpVr/FCrXUqJDpf/1lbqPuqCMEt9N3bL8MgYPp\n X9hhAiCTc7ltU9AXYfJKUiEmuXYS3oR8JV2xL9uHDXsH2bZZdn+1TOtqqMqAXM5XhQ7Fu4H3INU\n RqsRXoGJHNQdvxe0PLg==","X-Proofpoint-GUID":"O8SLTpyGQ_c8y9INvKERewlZnSsyeJXd","X-Authority-Analysis":"v=2.4 cv=S4bUAYsP c=1 sm=1 tr=0 ts=69c64f57 cx=c_pps\n a=JL+w9abYAAE89/QcEU+0QA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17\n a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22\n a=EUspDBNiAAAA:8 a=vU6kfqNVzfA0ps7fDeEA:9 a=QEXdDO2ut3YA:10\n a=324X-CrmTo6CU4MGRt3R:22","X-Proofpoint-ORIG-GUID":"O8SLTpyGQ_c8y9INvKERewlZnSsyeJXd","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0\n spamscore=0 impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270070"}}]