[{"id":3670900,"web_url":"http://patchwork.ozlabs.org/comment/3670900/","msgid":"<177485708802.5892.11250894850372032857.b4-ty@oss.qualcomm.com>","list_archive_url":null,"date":"2026-03-30T07:51:31","subject":"Re: [PATCH] gpio: shared: shorten the critical section in\n gpiochip_setup_shared()","submitter":{"id":92196,"url":"http://patchwork.ozlabs.org/api/people/92196/","name":"Bartosz Golaszewski","email":"bartosz.golaszewski@oss.qualcomm.com"},"content":"On Wed, 25 Mar 2026 12:06:38 +0100, Bartosz Golaszewski wrote:\n> Commit 710abda58055 (\"gpio: shared: call gpio_chip::of_xlate() if set\")\n> introduced a critical section around the adjustmenet of entry->offset.\n> However this may cause a deadlock if we create the auxiliary shared\n> proxy devices with this lock taken. We only need to protect\n> entry->offset while it's read/written so shorten the critical section\n> and release the lock before creating the proxy device as the field in\n> question is no longer accessed at this point.\n> \n> [...]\n\nApplied, thanks!\n\n[1/1] gpio: shared: shorten the critical section in gpiochip_setup_shared()\n https://git.kernel.org/brgl/c/310a4a9cbb17037668ea440f6a3964d00705b400\n\nBest regards,","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=f/X3cQoJ;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=aTJJgPJb;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34384-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"f/X3cQoJ\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"aTJJgPJb\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkk3K6Pxxz1yG8\n\tfor ; Mon, 30 Mar 2026 18:51:41 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id CBCA13003838\n\tfor ; Mon, 30 Mar 2026 07:51:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6452C23183B;\n\tMon, 30 Mar 2026 07:51:37 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E48E3A7F4C\n\tfor ; Mon, 30 Mar 2026 07:51:35 +0000 (UTC)","from pps.filterd (m0279864.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62U7BI3e2224414\n\tfor ; Mon, 30 Mar 2026 07:51:35 GMT","from mail-qt1-f198.google.com (mail-qt1-f198.google.com\n [209.85.160.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d685hcyp2-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Mon, 30 Mar 2026 07:51:35 +0000 (GMT)","by mail-qt1-f198.google.com with SMTP id\n d75a77b69052e-50b52a2d70cso125586581cf.3\n for ;\n Mon, 30 Mar 2026 00:51:35 -0700 (PDT)","from brgl-qcom.home ([2a01:cb1d:dc:7e00:1143:869f:e06c:4587])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43cf247472csm14706938f8f.28.2026.03.30.00.51.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 30 Mar 2026 00:51:32 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774857097; cv=none;\n b=QyfQcSnIC6XTIQZbRNdHJZo9YzLF7btVYVb2lzBU1wGHli6QBV0ZHZmLWwGqCQ2btzeLUDmZOu+smPTTRMwl/4pNX5ku27dX8ehOG/zVVAIAHJrPq64Z2B3kT7OnQVBB7uvVgH4CMD5MaXA6Vx6wMF1vSukA9L51ghrm2lBgV+Q=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774857097; c=relaxed/simple;\n\tbh=Wtwyx+rHoNn/JRfhHP9pjHO4uK9/lBUP/VYjCAIasLQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=O0CS+E6YLojWA8GCfM7+2hV8k8wO7JJLoFyAUs61dkHzzn+QkpE8aox+AXx+3UATMwxeR+JKlTYe769BGiOjzhCGuBPHyhkwVJA7P3rUhUgglA+H84xXaj0PPi4hFYesUk6YodGpMAYAgfCuZ0JRh3DT8OcxjIyqnm9lz2TccZ8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=f/X3cQoJ;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=aTJJgPJb; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tyqoFzHrqxv2RFgrza41YChO6hXH6iktD/zgGiClPpPI=; b=f/X3cQoJzfSxaNNJ\n\tSslrptOyEa6kU/3sYL37JXfPf4H5sWE2gUK5ZdQmU66p8CP3ejEqYsAudbVz529Z\n\tOMMSvYzPf3GfpaYDprJSd+T7w5E8caRtrXX8Dg49H3k9VmDjer9OI/5ZLVZPtwk8\n\tGqCVoStoethN1LcFwZShhFD0xHpSyhn+erawUAUBGUekzI/9Sg0F2ARJyNjGHZ8M\n\tuRCN7l6oVg98EUhQa0EWG1XlotJqKP5HNxoeW9xfZhzKui0pMSKG3a6KKKMxJcoT\n\tmifY0nmRti5xNYebm2qXbUVEIx8nzBQlJG2pCKn2jGleXPl7Qd97lC7388mAMFmO\n\tSoJoFw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1774857094; x=1775461894;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=yqoFzHrqxv2RFgrza41YChO6hXH6iktD/zgGiClPpPI=;\n b=aTJJgPJb2J7GAiDSkgufneruy8iM6oglLDBQjDBOKvIF5lWbVN4DfPd8UmUA0sSqIW\n 5lzXnExwUfsuE9LSGDkHOgyRsqs/eH4a9SA9B7hQ2p7Cwzsi6pcSbx+eoOXS2wwuSu66\n +tF6kqKjux13Z/0TePl1bfp75EoFD555syK44oawM57aiWmyl6P7wG/znGFJU/ZAG7z/\n ogRYPPDTq8VzvLYVJHkWNLOMDQ3Pjh0G2d4dsIpSxV7i4HVBaLYefmWRAm6wovb6LzPH\n OxLBVQVOkbk8ZfQTJTh4+LGvRHEcVk+fMr5P7wQVj7lWA6ITHJH80s2YzoOA9muyfIGR\n 9/DQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774857094; x=1775461894;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=yqoFzHrqxv2RFgrza41YChO6hXH6iktD/zgGiClPpPI=;\n b=WPaqoI++v1LIHy6cK5CbIGSWJdJ/WAYFdFhIcr5wNoOb2RVl9PTpyhrfK56D07zeEs\n yg1jjAGH0we1WsbWX3LQcHhW2NDzeADOayqByTeU00su1aAJFi9JJzdFScEfc1cB3GnE\n JAzM1Uj6C1jK58/Z+M93xUz/eE5QqDaLcLyloc+FdZMXSH9cxNQahAvTzAJXhsRy9ScH\n 397ATZZtEJgAxGc3jU3CTdNNrWLpQm2EzuQrdT10JVQy2fxV2oEWflA2Qcsa4mjKNFU2\n /rpb3IaPZ2LuC+mqQ78mh+qtpxwckDwEFI30MRm45Kt02sHOVvhxiBtNUFFx9G5MWahT\n sk0g==","X-Gm-Message-State":"AOJu0YyXnAp9pr92iuoD8QYM9VPdvS624+pe4V77inpacEZmmyj+SxgO\n\tMxpl2HMs+UGP6cFlFvlyoK0Qiz7a2fGD1laXze+f5ms6ojudDQdXFsaOTpfiYE+oLGhaaUGDQHV\n\ti/G56fY1SLTkgn1jiBOizSQvUlaypaInv6WYDZpTQdjztGBXD8oF56L/ojIIlPWY8","X-Gm-Gg":"ATEYQzwxfa0KgeinhjUw2cM2yB+2ITdZqO1ApFaV3YkCnDStviy2Mx7qOUDOI+7EI7N\n\tdmm4TSzdWFp307dqE7oMTQoMmAxMWqD64bHewRCMeIfzyOFKgtrU/u4WpXOkAkUrUZdGqRNN3KN\n\tS+++7P5OthfvqQhJr8pHXeUde7yh4OR9u6eX0rsAsePaxlwRRMRuLVUQsKO+x0KHdI6rBCvV/ee\n\t9gyxbYB3/iEoel1MFjhsBj9wfjZPoC7llxbIJjDhfuDRD9u1ehxo9Sz7zjPGiQD8duIf9if9I2H\n\tKAX+2b4q9TNQdcGig9MjdXIR+e9q/2ll5sz7yrx4SDOaI2WPRNxsOyszA+pEN5YahHkfe+hx21O\n\ttm9yK5CuXIyimX5+56QUb+8NnQyyqIfgbX/Yj8Wmow+iB9fTNq1M=","X-Received":["by 2002:ac8:7d8f:0:b0:509:1ee2:69e4 with SMTP id\n d75a77b69052e-50ba380a5e9mr165178601cf.11.1774857093972;\n Mon, 30 Mar 2026 00:51:33 -0700 (PDT)","by 2002:ac8:7d8f:0:b0:509:1ee2:69e4 with SMTP id\n d75a77b69052e-50ba380a5e9mr165178441cf.11.1774857093552;\n Mon, 30 Mar 2026 00:51:33 -0700 (PDT)"],"From":"Bartosz Golaszewski ","To":"Linus Walleij , Bartosz Golaszewski ,\n Jon Hunter ,\n Bartosz Golaszewski ","Cc":"linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,\n Dmitry Baryshkov ","Subject":"Re: [PATCH] gpio: shared: shorten the critical section in\n gpiochip_setup_shared()","Date":"Mon, 30 Mar 2026 09:51:31 +0200","Message-ID":"<177485708802.5892.11250894850372032857.b4-ty@oss.qualcomm.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"\n <20260325-gpio-shared-deadlock-v1-1-e4e7a5319e95@oss.qualcomm.com>","References":"<20260325-gpio-shared-deadlock-v1-1-e4e7a5319e95@oss.qualcomm.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"8bit","X-Authority-Analysis":"v=2.4 cv=csKWUl4i c=1 sm=1 tr=0 ts=69ca2b87 cx=c_pps\n a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8\n a=EUspDBNiAAAA:8 a=rx2hHsDi30GigQfg1aAA:9 a=QEXdDO2ut3YA:10\n a=dawVfQjAaf238kedN5IG:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMzMwMDA2MCBTYWx0ZWRfX7EPeaImYaBAK\n HUjoWxevmYf3IoXPqix2csiHdQTtsFUji2LzK5KUNdApw4rvkI0P4y3ysATQTyGyJxbNUISSe9x\n jQ/m/ej8KFUZNGcZ0JwDJAMNk7jADUGCwXUJU+3ELJUOj1WQlY+LxCsON5AMcwk4/Rs7ZT0V+t1\n sLsatZHuoPHnmkGZWOemIJGAkeKhhTUfm3rRggQtHpmjXZU9QCJf3Dq/3mAvRuHeIHCjqJq9Yoz\n OU/FF7NJh4MlxJtDK4uH8J9SDKgFAaAXE9A2NZecJ/Iq5kWbLrLnIYoKkEGyunNt0LooHlgNo4d\n pYy7cWfFQwfW36pF0zvSNSxMM4ZEaFLW+dtcgYWkdDixjnG8YxnRtJPU7F+gENyL88omZAyuQl1\n WB6l/sy/FIJdAHgQaMZr8aHLevl6TT9fH2nDA95oEn33QJcXZCLVwCR4Tin+kKfWgOZmR+YJCbF\n SKqIWIjXJsDnMMOwLJA==","X-Proofpoint-ORIG-GUID":"nGusgWZaoeRSXquemrOry6K1-Uf-Y3uc","X-Proofpoint-GUID":"nGusgWZaoeRSXquemrOry6K1-Uf-Y3uc","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n phishscore=0 malwarescore=0 clxscore=1015 adultscore=0 impostorscore=0\n priorityscore=1501 bulkscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300060"}}]