[{"id":3669021,"web_url":"http://patchwork.ozlabs.org/comment/3669021/","msgid":"","list_archive_url":null,"date":"2026-03-25T11:31:57","subject":"Re: [PATCH] docs/vhost-user: clarify the semantics of\n VHOST_USER_SET_VRING_ENABLE","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/people/84116/","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"content":"On 25.03.26 13:43, Daniil Tatianin wrote:\n> Documentation didn't really make it clear that the payload contains any\n> sort of desired state field, you could only derive that by looking at\n> the QEMU implementation of this request. Add an extra note to make that\n> clear.\n> \n> Signed-off-by: Daniil Tatianin \n> ---\n> docs/interop/vhost-user.rst | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst\n> index 137c9f3669d..79690c73b25 100644\n> --- a/docs/interop/vhost-user.rst\n> +++ b/docs/interop/vhost-user.rst\n> @@ -1346,6 +1346,8 @@ Front-end message types\n> :reply payload: N/A\n> \n> Signal the back-end to enable or disable corresponding vring.\n> + Note that the ``num`` field contains the target vring state where 0 means\n\nI'd remove \"Note that\", as it's actually significant part of the protocol)\n\n> + disabled, and any other value means enabled.\n> \n> This request should be sent only when\n> ``VHOST_USER_F_PROTOCOL_FEATURES`` has been negotiated.\n\nAnyway:\n\nReviewed-by: Vladimir Sementsov-Ogievskiy ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=rOp4LGeK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fglBk0Cd8z1yG1\n\tfor ; Wed, 25 Mar 2026 22:32:45 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5MTG-0000zg-Pj; Wed, 25 Mar 2026 07:32:22 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5MT9-0000zJ-A3\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 07:32:16 -0400","from forwardcorp1a.mail.yandex.net\n ([2a02:6b8:c0e:500:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w5MT5-0002cn-LC\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 07:32:14 -0400","from mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net\n [IPv6:2a02:6b8:c0c:bf1f:0:640:c739:0])\n by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 737DCC0217;\n Wed, 25 Mar 2026 14:32:04 +0300 (MSK)","from [IPV6:2a02:6bf:8080:749::1:0] (unknown\n [2a02:6bf:8080:749::1:0])\n by mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net (smtpcorp/Yandex) with\n ESMTPSA id 2WSkFa0AZqM0-V8Uyvy28; Wed, 25 Mar 2026 14:32:03 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1774438323;\n bh=Okq246JV3M4hqUSizER619YBfGBz/2/gJ/v4TxBf1WQ=;\n h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID;\n b=rOp4LGeKw9t4VmeeF3qXKhDH0/AHJt6ByL8K+YZfGzajkh5hHo6jcEDwkpc8IBcoK\n thquSGCgpnxVoUoSDFt3hGeG8l+laryi9hdg0JUxmUIowRRvREcnnxj3luyCM0p5Ku\n lWUcWIVB0bAWI0/v0yXbrgPQoJRNCisFSPrNu/oI=","Message-ID":"","Date":"Wed, 25 Mar 2026 14:31:57 +0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] docs/vhost-user: clarify the semantics of\n VHOST_USER_SET_VRING_ENABLE","To":"Daniil Tatianin ,\n \"Michael S. Tsirkin\" ","Cc":"Stefano Garzarella ,\n Pierrick Bouvier , qemu-devel@nongnu.org,\n yc-core@yandex-team.ru","References":"<20260325104329.154875-1-d-tatianin@yandex-team.ru>","Content-Language":"en-US","From":"Vladimir Sementsov-Ogievskiy ","In-Reply-To":"<20260325104329.154875-1-d-tatianin@yandex-team.ru>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]