[{"id":3669095,"web_url":"http://patchwork.ozlabs.org/comment/3669095/","msgid":"","list_archive_url":null,"date":"2026-03-25T13:10:49","subject":"Re: [PATCH v3 09/14] ASoC: tegra: Use dev_err_probe() in OPE, PEQ\n and MBDRC drivers","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Wed, Mar 25, 2026 at 10:14:32AM +0000, Sheetal wrote:\n> Log errors in the Tegra210 OPE, PEQ and MBDRC probe paths using\n> dev_err_probe().\n\n> \terr = tegra210_peq_regmap_init(pdev);\n> -\tif (err < 0) {\n> -\t\tdev_err(dev, \"PEQ init failed\\n\");\n> -\t\treturn err;\n> -\t}\n> +\tif (err < 0)\n> +\t\treturn dev_err_probe(dev, err, \"PEQ init failed\\n\");\n\nThere's dev_err_probe() logging in the called function, the\ndev_err_probe() here is redundant and overwrites the failure reason.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=LvSCQumH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13226-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"LvSCQumH\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgnkY3Drsz1y1K\n\tfor ; Thu, 26 Mar 2026 00:27:01 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 98BBE30AA7D5\n\tfor ; Wed, 25 Mar 2026 13:10:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2D5243D8115;\n\tWed, 25 Mar 2026 13:10:55 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E1BDF3D6467;\n\tWed, 25 Mar 2026 13:10:54 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 56AF9C4CEF7;\n\tWed, 25 Mar 2026 13:10:52 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774444255; cv=none;\n b=ZJaivu4Q11mQuCKGfj8CrE5Vh0zb6PGwLaI0uAEICQjPE+QT4UD4TnjcWMfiCY3+gWj6/j1Qlk888tidL/NsQCeOWELfGxlKKuPkna+OpUkQFAfpEuuMNEbtZVgl+Ea93rEJBpeYAj0aIq84LHwNCv4a+bjThaFypg45ehPUu00=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774444255; c=relaxed/simple;\n\tbh=rjJ4cQkDvxgiTEnxyqLIt99wjIMAiOY6Y7cAplv5vWE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=QaB7K7O/PzWunM8GSnDAHTDRF7M6gaum/auJFGzJ4kz8Wz8V0pKBPZ4TOoWYfOLz5eWaoDog+p5QncCNAPQANnW5ZC68OvxprcTGOH5vcj8yEyNLF1cc+Z5XFc+cVQhRJZ7jMQ/hkb4b1jZ5OjlosJdUGTQgLGxRevw+1R4GJAQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=LvSCQumH; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774444254;\n\tbh=rjJ4cQkDvxgiTEnxyqLIt99wjIMAiOY6Y7cAplv5vWE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LvSCQumHJxmxxXRCOOZ0OsXdELdXjgYDdKUuzUCHNIfoOeXjHLW/JekMzj2OI0Vqd\n\t VAR0/ZRMNYp07yIaS1E33WXyQzlWgRmvnNXxa1OEoLkx4+Lq4+wDUP0emQdoAK9RS1\n\t l1jEVdTFNaaGmTZ9n4xu7QM2NbTnIhIuLr6PtKIdagxNMtCQo8EoDQuBlYvpP5OE2/\n\t SYbfv6E7/5CvPYbv7OR2L7SZjVpp4hZoPuvBD4kSiBxS7MLVUTDYYHyeYYELqpYMWx\n\t Phc0i5MzJFb2LQj5zi7LvccfvA/eOSzi1L6htJhcym1V9VDgQJjeJk18TlhAZT61B7\n\t G6YqAMMXXOCjw==","Date":"Wed, 25 Mar 2026 13:10:49 +0000","From":"Mark Brown ","To":"Sheetal ","Cc":"Liam Girdwood ,\n\tThierry Reding ,\n\tJonathan Hunter ,\n\tJaroslav Kysela , Takashi Iwai ,\n\tMohan Kumar ,\n\tKuninori Morimoto ,\n\tlinux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v3 09/14] ASoC: tegra: Use dev_err_probe() in OPE, PEQ\n and MBDRC drivers","Message-ID":"","References":"<20260325101437.3059693-1-sheetal@nvidia.com>\n <20260325101437.3059693-10-sheetal@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"hwSwQNi+0STaGx3e\"","Content-Disposition":"inline","In-Reply-To":"<20260325101437.3059693-10-sheetal@nvidia.com>","X-Cookie":"Those who can't write, write manuals."}}]