[{"id":3669096,"web_url":"http://patchwork.ozlabs.org/comment/3669096/","msgid":"<6fd4ecb9-73e8-4555-855b-28350aaae44f@sirena.org.uk>","list_archive_url":null,"date":"2026-03-25T13:05:55","subject":"Re: [PATCH v3 03/14] ASoC: tegra: Add error logging in\n tegra210_admaif driver","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Wed, Mar 25, 2026 at 10:14:26AM +0000, Sheetal wrote:\n\n> Log errors in the Tegra210 ADMAIF probe and runtime callback paths.\n\n> @@ -966,10 +969,9 @@ static int tegra_admaif_probe(struct platform_device *pdev)\n> \tregcache_cache_only(admaif->regmap, true);\n> \n> \terr = tegra_isomgr_adma_register(&pdev->dev);\n> -\tif (err) {\n> -\t\tdev_err(&pdev->dev, \"Failed to add interconnect path\\n\");\n> -\t\treturn err;\n> -\t}\n> +\tif (err)\n> +\t\treturn dev_err_probe(&pdev->dev, err,\n> +\t\t\t\t \"failed to add interconnect path\\n\");\n\ntegra_isomgr_adma_register() already logs failures.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=BO63G6ox;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13222-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"BO63G6ox\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgnvL4qL1z1xy3\n\tfor ; Thu, 26 Mar 2026 00:34:38 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id A18603001CCC\n\tfor ; Wed, 25 Mar 2026 13:06:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0B0D63D6467;\n\tWed, 25 Mar 2026 13:06:01 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C2245309DDF;\n\tWed, 25 Mar 2026 13:06:00 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E818FC4CEF7;\n\tWed, 25 Mar 2026 13:05:57 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774443960; cv=none;\n b=cT4QcwLiZvnvnt94S96gL8Ucqlr5iVoqnjPF6NlUclHLtMQozmoEIk3GUKVK7YElWixOsDS7FLRZOhnm+PK+KBFE4gyJ19iErQpJW7r65dAPPjeEUembjEeMzw2k6oHlhRUBOg8Qdi633jLBdkQ4ibDtJ5DLh/dmEzJ20nAGbm0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774443960; c=relaxed/simple;\n\tbh=rzV9KEWajsJ8B7/mrSMUykQ+PshUl0DaCZOiK0wU4K8=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=m5wi6fnOMzcd+h/o62xWl6whfnFNzl6FeroOcnG9FVHkdPh+8nrsYCMBYCX7kBeZ+9J5sLcf9XdtVek4BaU2zb6eg18uJVajCRvE6wpskcr7n9QiTuRbsxAwPiORRtQYVxyi7fG1qeVjDzGH3EIbarX6HCnKwy+I5k/pYbDDs8k=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=BO63G6ox; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774443960;\n\tbh=rzV9KEWajsJ8B7/mrSMUykQ+PshUl0DaCZOiK0wU4K8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BO63G6oxa07lS0t1c1T081SSWJuyslzBluzpbDYnR47f2TygxiAvm8Z72IBgnZS4H\n\t /aIFvi2DgMpVPHGkZXPH09X+w6wU/CY3jZL5q8jfwJzaIzat1Oqumvhnakp0evsxCI\n\t no5P4mpmQjY78OFjnqJV+GDpi9Ezf5fVECsYl8SinoFCaNyCxfrTodb7DhGCQMCb5h\n\t NTO60xNZpR/ja1g6LfhsJKGyLtXm4AHqPDa/LgeGntpzycapgO97gtKfgMEbLAG+uA\n\t fqzUumjwan4EzloD1MOapENaYLDmCWwHcnIQLiUrw1MEux6L621cKASzZvRYujUJM0\n\t M7teEAu3sTZnA==","Date":"Wed, 25 Mar 2026 13:05:55 +0000","From":"Mark Brown ","To":"Sheetal ","Cc":"Liam Girdwood ,\n\tThierry Reding ,\n\tJonathan Hunter ,\n\tJaroslav Kysela , Takashi Iwai ,\n\tMohan Kumar ,\n\tKuninori Morimoto ,\n\tlinux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v3 03/14] ASoC: tegra: Add error logging in\n tegra210_admaif driver","Message-ID":"<6fd4ecb9-73e8-4555-855b-28350aaae44f@sirena.org.uk>","References":"<20260325101437.3059693-1-sheetal@nvidia.com>\n <20260325101437.3059693-4-sheetal@nvidia.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"OnDLxHD9zFb8vgxW\"","Content-Disposition":"inline","In-Reply-To":"<20260325101437.3059693-4-sheetal@nvidia.com>","X-Cookie":"Those who can't write, write manuals."}}]