[{"id":3668980,"web_url":"http://patchwork.ozlabs.org/comment/3668980/","msgid":"<DHBSTI0A3SOW.PCIP544HUYP4@linux.spacemit.com>","list_archive_url":null,"date":"2026-03-25T10:41:45","subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","submitter":{"id":91240,"url":"http://patchwork.ozlabs.org/api/people/91240/","name":"Troy Mitchell","email":"troy.mitchell@linux.spacemit.com"},"content":"On Wed Mar 25, 2026 at 5:49 PM CST, Yixun Lan wrote:\n> Populate all I2C devicetree nodes for SpacemiT K3 SoC.\n>\n> Signed-off-by: Yixun Lan <dlan@kernel.org>\n> ---\n>  arch/riscv/boot/dts/spacemit/k3.dtsi | 98 ++++++++++++++++++++++++++++++++++++\n>  1 file changed, 98 insertions(+)\n>\n> diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi\n> index a3a8ceddabec..cab72591b7f1 100644\n> --- a/arch/riscv/boot/dts/spacemit/k3.dtsi\n> +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi\n> @@ -438,6 +438,76 @@ soc: soc {\n>  \t\tdma-noncoherent;\n>  \t\tranges;\n>  \n> +\t\ti2c0: i2c@d4010800 {\n> +\t\t\tcompatible = \"spacemit,k3-i2c\", \"spacemit,k1-i2c\";\n> +\t\t\treg = <0x0 0xd4010800 0x0 0x38>;\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <0>;\n> +\t\t\tinterrupts = <36 IRQ_TYPE_LEVEL_HIGH>;\n> +\t\t\tclocks = <&syscon_apbc CLK_APBC_TWSI0>,\n> +\t\t\t\t <&syscon_apbc CLK_APBC_TWSI0_BUS>;\n> +\t\t\tclock-names = \"func\", \"bus\";\n> +\t\t\tclock-frequency = <400000>;\n> +\t\t\tresets = <&syscon_apbc RESET_APBC_TWSI0>;\n> +\t\t\tstatus = \"disabled\";\n> +\t\t};\n> +\n> +\t\ti2c1: i2c@d4011000 {\n> +\t\t\tcompatible = \"spacemit,k3-i2c\", \"spacemit,k1-i2c\";\n> +\t\t\treg = <0x0 0xd4011000 0x0 0x38>;\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <0>;\n> +\t\t\tinterrupts = <37 IRQ_TYPE_LEVEL_HIGH>;\n> +\t\t\tclocks = <&syscon_apbc CLK_APBC_TWSI1>,\n> +\t\t\t\t <&syscon_apbc CLK_APBC_TWSI1_BUS>;\n> +\t\t\tclock-names = \"func\", \"bus\";\n> +\t\t\tclock-frequency = <400000>;\n> +\t\t\tresets = <&syscon_apbc RESET_APBC_TWSI1>;\n> +\t\t\tstatus = \"disabled\";\n> +\t\t};\n> +\n> +\t\ti2c2: i2c@d4012000 {\n> +\t\t\tcompatible = \"spacemit,k3-i2c\", \"spacemit,k1-i2c\";\n> +\t\t\treg = <0x0 0xd4012000 0x0 0x38>;\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <0>;\n> +\t\t\tinterrupts = <38 IRQ_TYPE_LEVEL_HIGH>;\n> +\t\t\tclocks = <&syscon_apbc CLK_APBC_TWSI2>,\n> +\t\t\t\t <&syscon_apbc CLK_APBC_TWSI2_BUS>;\n> +\t\t\tclock-names = \"func\", \"bus\";\n> +\t\t\tclock-frequency = <400000>;\n> +\t\t\tresets = <&syscon_apbc RESET_APBC_TWSI2>;\n> +\t\t\tstatus = \"disabled\";\n> +\t\t};\nI think we should add a comment here to explain why there isn't i2c3.\nOtherwise, LGTM.\n\nReviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>","headers":{"Return-Path":"\n <linux-i2c+bounces-16732-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.spacemit.com header.i=@linux.spacemit.com\n header.a=rsa-sha256 header.s=mxsw2412 header.b=KQoizdSS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16732-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=linux.spacemit.com\n header.i=@linux.spacemit.com header.b=\"KQoizdSS\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=54.206.34.216","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux.spacemit.com","smtp.subspace.kernel.org;\n spf=none smtp.mailfrom=linux.spacemit.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgkGm5SBMz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 21:51:12 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 77922308D9DD\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 10:42:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0849F3BC670;\n\tWed, 25 Mar 2026 10:42:14 +0000 (UTC)","from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 167E13A3808;\n\tWed, 25 Mar 2026 10:42:09 +0000 (UTC)","from = ( [120.237.158.181])\n\tby bizesmtp.qq.com (ESMTP) with\n\tid ; Wed, 25 Mar 2026 18:41:45 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774435333; cv=none;\n b=ckO91o09q6/Ww4G07BqjvKwFLP0118wkI/QUaX7CZqGWUolZC5U559F2OZCJY9Z4R7kdN58VEVE5hS509p778lvmIAkNZdox5gUBCg6UaP7EXCn0hp0N/Y2tL858jtq0kkRQr1erwjnicBm7GpvcmVYM5iJzvY1Ej3XjbZOJ5PE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774435333; c=relaxed/simple;\n\tbh=6ThVK/rJaviO7Jrd2Rhoa38vC9ZXpd/LSGiKWL+Dqdo=;\n\th=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To:\n\t References:In-Reply-To;\n b=ds7C0PtXsDdn78oF2rdPoYwL3nefgNdfrMOl3wiT214o7wk6WCjUPIBjxwK2zGYBL9fiyrZk2PDQDEhg4ijUIoAKFRZ9GqM7xyNx2zVqYxrEu+6UcyO1PoZhyatac5TVZSC7uqfSpY4LKwR05OPSUjL8vcRsxBBU2KZfa0PYH80=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux.spacemit.com;\n spf=none smtp.mailfrom=linux.spacemit.com;\n dkim=pass (1024-bit key) header.d=linux.spacemit.com\n header.i=@linux.spacemit.com header.b=KQoizdSS;\n arc=none smtp.client-ip=54.206.34.216","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com;\n\ts=mxsw2412; t=1774435313;\n\tbh=5h9Gm4hE034FUJ+tLsF/4KbhVSlEW2L6viFtWACnUaA=;\n\th=Mime-Version:Date:Message-Id:Subject:From:To;\n\tb=KQoizdSSmPzU811q9F358BCaQfYExREBkPK5k6mX3fQi9HFRTwPK6P3rTb/88EiKp\n\t Cikx+3Lnyg/u4x+LPB9j2KHzNiuDHEW3QtQOm3xeAVHaXmUOgxVrYc6qN9NnW9BYbF\n\t AyLoKItsONGgOalvErq7RsFpaNE2iV+KC83S+7wc=","X-QQ-mid":"zesmtpgz5t1774435308te51a1058","X-QQ-Originating-IP":"5V2fvYPK8sKaEEHdU11yJxTASq+yaMttfYnhxI/4Q00=","X-QQ-SSF":"0000000000000000000000000000000","X-QQ-GoodBg":"0","X-BIZMAIL-ID":"2505999498786661497","EX-QQ-RecipientCnt":"15","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","Mime-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","Content-Type":"text/plain; charset=UTF-8","Date":"Wed, 25 Mar 2026 18:41:45 +0800","Message-Id":"<DHBSTI0A3SOW.PCIP544HUYP4@linux.spacemit.com>","Cc":"<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,\n <linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,\n <linux-kernel@vger.kernel.org>","Subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","From":"\"Troy Mitchell\" <troy.mitchell@linux.spacemit.com>","To":"\"Yixun Lan\" <dlan@kernel.org>, \"Andi Shyti\" <andi.shyti@kernel.org>,\n \"Rob Herring\" <robh@kernel.org>, \"Krzysztof Kozlowski\"\n <krzk+dt@kernel.org>, \"Conor Dooley\" <conor+dt@kernel.org>, \"Paul Walmsley\"\n <pjw@kernel.org>, \"Palmer Dabbelt\" <palmer@dabbelt.com>, \"Albert Ou\"\n <aou@eecs.berkeley.edu>, \"Alexandre Ghiti\" <alex@ghiti.fr>, \"Troy Mitchell\"\n <troy.mitchell@linux.spacemit.com>","X-Mailer":"aerc 0.21.0-0-g5549850facc2","References":"<20260325-02-k3-i2c-v1-0-78f29c83d9ac@kernel.org>\n <20260325-02-k3-i2c-v1-2-78f29c83d9ac@kernel.org>","In-Reply-To":"<20260325-02-k3-i2c-v1-2-78f29c83d9ac@kernel.org>","X-QQ-SENDSIZE":"520","Feedback-ID":"zesmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0","X-QQ-XMAILINFO":"M/AyZGld0ICWZJOKLI3GDPQX/bB1AO8EkYCDTjotDUGbS+sd4RQIxmYN\n\taMQdXYqa3mWV+S5uW5jLgU3+peTJIXubpnlxQgj2EylTCYsjyh3eFsEOCexS8rgXoVvOjoS\n\tkvu8+CxafXG7HT4ob6tMtFvuIKw/VyIat4PxbDTXFLGOUz5PzLAjH+BcqyKxTfVNoYUrXZY\n\t1YRZjgtVL9ydzZ3LcOAswpnzLZPxxw1QCkf05CmFcdIpc48WsqRg4K39pfCQeZ5u8YJD6ym\n\tMurFo0sXpQX9MsvIQxj02dGk1vQ9iCILj2uxj5uU81NuNActuTKYKK5GolEz1ievBq+zwlY\n\tk0wU1DFm8wjtY4ZSBl9z0XI14s80Sre8ebg5NDmLBVD7NOvzm1CDQdAzyd4FN0tXToLXcke\n\t152yNX3AbtIvbPV5hbA83tQF+WqWl7VHwKb2E28vHEXjwyIXf8X9Zdhj0CFmdbFnib1bMOr\n\t7szhNkW0y9FfuZbG6bVWDHBO6KHb3TAagXf/hIxtePXSwkvKsyRkHfW6IcVyMhzZS0O8ct/\n\tKHS+q9zoy8ehk/ctSoeRzeTESwVGpiFGwevUC1Oki+FVqVc9qMbiQbhxcgDnJMm6FPQxoi9\n\tXirWoIIiE4kal82a5VCWheB2UyJBn0xoggaQT/iJehMfNTll7sM1m7Qbi1JUK+5UYWsxbHn\n\txVrOflxpV7Kg/tGYEbxbvo/BSbbqjKqgWrCla0SEv/4QOc6zKW5LbEQY1y7IUk3gvskMx3v\n\ttoOtpfIP7rt9eqjFn/DS8fbVf2mBJfJ9vQqjQdrt/t4k9zmmB3pUWPSPhd79Wjft3b2mukc\n\t2vti3JR5e6z0qFES0bgCkVMlz3fNNUsG1pJTUU5/OxvSwEwoeKbNPWqd113rfI2e3AyD+hH\n\tkl3TYUmuLdOPgy8lj1aR4XRQRQjhEq/v0tVxy4/G1uhe5Yd+gMUDQ2EY02L6STcf97IXKmm\n\tUcZROWpAYXiOshNoajF5qYLG7dE1DCsnWQN4ujtx8DnnpLzfJfHhRfCj7gywpcvoIUxs5nV\n\toPllE68dMJxPn0gJQbNbx0r/EQr2D8KAVrabNr21oOI94hkHlelwlzVM+VovE=","X-QQ-XMRINFO":"M/715EihBoGS47X28/vv4NpnfpeBLnr4Qg==","X-QQ-RECHKSPAM":"0"}},{"id":3669983,"web_url":"http://patchwork.ozlabs.org/comment/3669983/","msgid":"<acWxJNK_vZca_xCZ@zenone.zhora.eu>","list_archive_url":null,"date":"2026-03-26T22:22:26","subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","submitter":{"id":85956,"url":"http://patchwork.ozlabs.org/api/people/85956/","name":"Andi Shyti","email":"andi.shyti@kernel.org"},"content":"Hi Yixun,\n\nOn Wed, Mar 25, 2026 at 09:49:25AM +0000, Yixun Lan wrote:\n> Populate all I2C devicetree nodes for SpacemiT K3 SoC.\n> \n> Signed-off-by: Yixun Lan <dlan@kernel.org>\n\nthis second patch does not apply on my i2c branch. I'm missing\nsome other patches on k3.\n\nCan you please rebase it on top of my i2c/i2c-host branch,\notherwise I will need to wait for the merge window to open in\norder to take this.\n\nAndi","headers":{"Return-Path":"\n <linux-i2c+bounces-16817-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=YQBepmYf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16817-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"YQBepmYf\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhdZ70YDkz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 09:22:38 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C9508305B5DB\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 22:22:34 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CC22F332604;\n\tThu, 26 Mar 2026 22:22:31 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FB983016EB;\n\tThu, 26 Mar 2026 22:22:31 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 81441C2BC87;\n\tThu, 26 Mar 2026 22:22:29 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774563751; cv=none;\n b=sHQOFO8Q21Yrsu/6uiU9S4E11A/qvoXcleWSVCHbOPmZEOsBvbXTwHjZQsDeD4diDd9Gm6fMtUUAUptweeLWfON19TucoQ7qyQiAXr2JVz8WTCnA/I17LiS8s3FvF1UPlNrQmSQ0+8PO6Ma2kWT56KEyYo+Yu23W42g/w3TsJgk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774563751; c=relaxed/simple;\n\tbh=QFvbS0GhFnRlo+56h6KYVqI4hNKBx9LjI/HgLWKtYxc=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=tLxcTAjnoaxhWRXGWcpPv9La0t3XO9EVmyurWEG+piyt1wvkxyu5KOj6xjYdIbZLUIBVFHl8m42ewayu9LUqJTMOdLo5nST4UpPV5jT0EpumKNnV7wpbMyTHe6L13Ng7KEEI/Ux8ts9qzviLZXsBBbn+MSRWtCegOO25gJxCvnI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=YQBepmYf; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774563751;\n\tbh=QFvbS0GhFnRlo+56h6KYVqI4hNKBx9LjI/HgLWKtYxc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YQBepmYfZMV5yL7Sh4QV7gumKup40c8mFrfl+1n6NpvgQvcctZVNa5Ntt6lk5EbvF\n\t bvGmDlsWBHCQM1xndpWifoWWcQ0gIMYn+C4jNeythO3zJEpGS3G7Tt/G3EfrMA1ZsO\n\t afuwMqKvlhxMNNUzw4WkV72eMNtLyK6ux3LFsmKQ6y1zs1U/Z+S2UtLCie1ryn9FIU\n\t ZPUTlq8AaTqPufMsL2wXPVWE0ekM17D3yDOy1syUlRqxXSQou5ZNLBi7Wsa9SgsTfT\n\t JOteDq9En2aG/C6XTUwMPJm9iNEtOWjKKfHhJ8zzDpeCs92z0pqsRK3hRNky6qRiLU\n\t J12HHeapLDoAQ==","Date":"Thu, 26 Mar 2026 23:22:26 +0100","From":"Andi Shyti <andi.shyti@kernel.org>","To":"Yixun Lan <dlan@kernel.org>","Cc":"Rob Herring <robh@kernel.org>,\n\tKrzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>, Alexandre Ghiti <alex@ghiti.fr>,\n\tTroy Mitchell <troy.mitchell@linux.spacemit.com>, linux-i2c@vger.kernel.org,\n devicetree@vger.kernel.org,\n\tlinux-riscv@lists.infradead.org, spacemit@lists.linux.dev,\n linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","Message-ID":"<acWxJNK_vZca_xCZ@zenone.zhora.eu>","References":"<20260325-02-k3-i2c-v1-0-78f29c83d9ac@kernel.org>\n <20260325-02-k3-i2c-v1-2-78f29c83d9ac@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260325-02-k3-i2c-v1-2-78f29c83d9ac@kernel.org>"}},{"id":3669984,"web_url":"http://patchwork.ozlabs.org/comment/3669984/","msgid":"<acWxqkR8Z0rwe4hI@zenone.zhora.eu>","list_archive_url":null,"date":"2026-03-26T22:23:03","subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","submitter":{"id":85956,"url":"http://patchwork.ozlabs.org/api/people/85956/","name":"Andi Shyti","email":"andi.shyti@kernel.org"},"content":"Hi Yixun,\n\n> > +\t\ti2c2: i2c@d4012000 {\n> > +\t\t\tcompatible = \"spacemit,k3-i2c\", \"spacemit,k1-i2c\";\n> > +\t\t\treg = <0x0 0xd4012000 0x0 0x38>;\n> > +\t\t\t#address-cells = <1>;\n> > +\t\t\t#size-cells = <0>;\n> > +\t\t\tinterrupts = <38 IRQ_TYPE_LEVEL_HIGH>;\n> > +\t\t\tclocks = <&syscon_apbc CLK_APBC_TWSI2>,\n> > +\t\t\t\t <&syscon_apbc CLK_APBC_TWSI2_BUS>;\n> > +\t\t\tclock-names = \"func\", \"bus\";\n> > +\t\t\tclock-frequency = <400000>;\n> > +\t\t\tresets = <&syscon_apbc RESET_APBC_TWSI2>;\n> > +\t\t\tstatus = \"disabled\";\n> > +\t\t};\n> I think we should add a comment here to explain why there isn't i2c3.\n> Otherwise, LGTM.\n\nare you going to add a comment here?\n\n> Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>","headers":{"Return-Path":"\n <linux-i2c+bounces-16818-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=DIWyTSD0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16818-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"DIWyTSD0\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhdZk5Ybpz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 09:23:10 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 099DB305ACBC\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 22:23:09 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9CF2632E728;\n\tThu, 26 Mar 2026 22:23:07 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 439DF3246E8;\n\tThu, 26 Mar 2026 22:23:07 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 69B46C116C6;\n\tThu, 26 Mar 2026 22:23:06 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774563787; cv=none;\n b=RbXPizQBO/ro2Krk5xsx72uPNGRdcI9wtht3fB5d2n56MttJWxEQp89oYrIWAT6KMkmVGD8+lEL1StMmj5gb+A9p8OTI+35a5n/Aua3c3wb5abpZr08+E1mRcrUPW/FPjB5MWXeArljib0BYaJmLvkZXLpJZHWkQRUgNjXLo6Ww=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774563787; c=relaxed/simple;\n\tbh=ROCHNfrbiVNl5Zqs4yioqi28PWLJ543gNykCvWuEADI=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=m3f48SGQpnxFcy82YhyMfpY6ui8QjCd5lp195iPPutj3J95IvrTN3DQS42I/4wZp7Z9qDNWcr66j3+1fWR17LI6tMrxC2KfA8Ls5d/QXV1YbdVo9HRsla2OZvMW6o8rtO6amTqfvDmi2TIVez+BYA0cM0Th//wJuwdaL+miWgl4=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=DIWyTSD0; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774563786;\n\tbh=ROCHNfrbiVNl5Zqs4yioqi28PWLJ543gNykCvWuEADI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DIWyTSD0T/3wABk4ooxkzUF574ktOvykn2aryCP3u7klsq9jEusnhLa6oukJffs0/\n\t ILiyudB+C3dg9zvHm/DyzoqIdXN1TZbGXXnjFgWkNRa1Ekk88VeKZzNmpma+0mg2eZ\n\t 9UEF9QoUqsHNsCHi6V6MC2mQqGEKwhE64xAuIi9ZlcRGOvbg8mgS+SFxINzzxFOCMo\n\t g72Rpt3Q9Zb5jb+Xeyotj65zN5W7RfKr0Mp4j52VOc0uVYzZV3pic6IWRrF0ntsLrQ\n\t /1XHnnHfudzKwLr3MSK2LgOF0vWSqe/Qh3UDoOXNQTJmGBZjwqxpub8TFkHLheCtEC\n\t A3d5LMj2AeKgQ==","Date":"Thu, 26 Mar 2026 23:23:03 +0100","From":"Andi Shyti <andi.shyti@kernel.org>","To":"Troy Mitchell <troy.mitchell@linux.spacemit.com>","Cc":"Yixun Lan <dlan@kernel.org>, Rob Herring <robh@kernel.org>,\n\tKrzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>, Alexandre Ghiti <alex@ghiti.fr>,\n linux-i2c@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-riscv@lists.infradead.org,\n spacemit@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","Message-ID":"<acWxqkR8Z0rwe4hI@zenone.zhora.eu>","References":"<20260325-02-k3-i2c-v1-0-78f29c83d9ac@kernel.org>\n <20260325-02-k3-i2c-v1-2-78f29c83d9ac@kernel.org>\n <DHBSTI0A3SOW.PCIP544HUYP4@linux.spacemit.com>","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<DHBSTI0A3SOW.PCIP544HUYP4@linux.spacemit.com>"}},{"id":3669986,"web_url":"http://patchwork.ozlabs.org/comment/3669986/","msgid":"<acWx_31uT2ffcaSN@zenone.zhora.eu>","list_archive_url":null,"date":"2026-03-26T22:24:45","subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","submitter":{"id":85956,"url":"http://patchwork.ozlabs.org/api/people/85956/","name":"Andi Shyti","email":"andi.shyti@kernel.org"},"content":"Hi agagin,\n\nOn Thu, Mar 26, 2026 at 11:22:31PM +0100, Andi Shyti wrote:\n> On Wed, Mar 25, 2026 at 09:49:25AM +0000, Yixun Lan wrote:\n> > Populate all I2C devicetree nodes for SpacemiT K3 SoC.\n> > \n> > Signed-off-by: Yixun Lan <dlan@kernel.org>\n> \n> this second patch does not apply on my i2c branch. I'm missing\n> some other patches on k3.\n> \n> Can you please rebase it on top of my i2c/i2c-host branch,\n> otherwise I will need to wait for the merge window to open in\n> order to take this.\n\nsorry, this has to go through some other path, I'm going to take\npatch 1.\n\nAndi","headers":{"Return-Path":"\n <linux-i2c+bounces-16819-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=X2iLVf4T;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16819-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"X2iLVf4T\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhdrY3v4lz1yFp\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 09:35:09 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D394730F9E3A\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 22:26:22 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id EFAFA37B03E;\n\tThu, 26 Mar 2026 22:24:50 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C345379987;\n\tThu, 26 Mar 2026 22:24:50 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 5274FC4AF11;\n\tThu, 26 Mar 2026 22:24:48 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774563890; cv=none;\n b=nIWDhEw7nEntkyvSo5qGAMzUsPulOIv80g8g4bg7J4IagEbuYLpRQ64mOomBAs5hhqzmTlw2BD2Q22b4kt7NoX0SWfGJTMTnrLiqyulTE7ZC2ZOqA1/gNU2hvIjYPtW9GkuIdMM3PQIkjnjB+jzXmGxlwwMndfoQ5S4WRkRUmos=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774563890; c=relaxed/simple;\n\tbh=vXuZILi71R68LcfYH5ZVtFEJI1fOBMAeL2azpItnV38=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=JRE1fkR1UMAhZowqxOQxOyFHnWuSZjywpD7SGh/QecSW9+vFkiFVk3qYE1C+do0op3wXwPpV5ew5XxrnpKsRMktZQTQ0S7U8GlE6sizBq+yLS2QyaU9cBUS6fV4YUW0jTBgYlGRdvRq4V0ZTzPDn+mBQ9udzlgzxnQ4Kkh/NLc0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=X2iLVf4T; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774563890;\n\tbh=vXuZILi71R68LcfYH5ZVtFEJI1fOBMAeL2azpItnV38=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=X2iLVf4Tpjd7p1ZSPkG5AUk1EyB0jDrUVuaqqZhpeym2Eh5ODVnN46NA2Iw0BGcwq\n\t /Y9KXrhYIqTwBGYWpEbhoMkaa8B0HY1VEOxGn8cvMDn5vNlLNO1N0z4O8bp3Uo0MZo\n\t rh/1YukX9BqVYG7qDCW9qm9ng0XIikbZxtzhdddm8sW8emc6ELg4jYegR9mXG9bPz6\n\t qjESwrjhBkXCG7yV+0YucrABtn4kJLKLP6krPJCXofasuixxaqRI4RN4evTnuOhnp2\n\t lF+c87aVcSaBq2w/8z1sgPTSBDuBKl9tOCtC+2ljFevbkUUMJOCHkSg3nVVpghgpuT\n\t lO7vu3LtSX4qg==","Date":"Thu, 26 Mar 2026 23:24:45 +0100","From":"Andi Shyti <andi.shyti@kernel.org>","To":"Yixun Lan <dlan@kernel.org>","Cc":"Rob Herring <robh@kernel.org>,\n\tKrzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,\n\tPaul Walmsley <pjw@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>, Alexandre Ghiti <alex@ghiti.fr>,\n\tTroy Mitchell <troy.mitchell@linux.spacemit.com>, linux-i2c@vger.kernel.org,\n devicetree@vger.kernel.org,\n\tlinux-riscv@lists.infradead.org, spacemit@lists.linux.dev,\n linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","Message-ID":"<acWx_31uT2ffcaSN@zenone.zhora.eu>","References":"<20260325-02-k3-i2c-v1-0-78f29c83d9ac@kernel.org>\n <20260325-02-k3-i2c-v1-2-78f29c83d9ac@kernel.org>\n <acWxJNK_vZca_xCZ@zenone.zhora.eu>","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<acWxJNK_vZca_xCZ@zenone.zhora.eu>"}},{"id":3670019,"web_url":"http://patchwork.ozlabs.org/comment/3670019/","msgid":"<20260327020543-GKA847041@kernel.org>","list_archive_url":null,"date":"2026-03-27T02:05:43","subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","submitter":{"id":91543,"url":"http://patchwork.ozlabs.org/api/people/91543/","name":"Yixun Lan","email":"dlan@kernel.org"},"content":"Hi Andi,\n\nOn 23:24 Thu 26 Mar     , Andi Shyti wrote:\n> Hi agagin,\n> \n> On Thu, Mar 26, 2026 at 11:22:31PM +0100, Andi Shyti wrote:\n> > On Wed, Mar 25, 2026 at 09:49:25AM +0000, Yixun Lan wrote:\n> > > Populate all I2C devicetree nodes for SpacemiT K3 SoC.\n> > > \n> > > Signed-off-by: Yixun Lan <dlan@kernel.org>\n> > \n> > this second patch does not apply on my i2c branch. I'm missing\n> > some other patches on k3.\n> > \n> > Can you please rebase it on top of my i2c/i2c-host branch,\n> > otherwise I will need to wait for the merge window to open in\n> > order to take this.\n> \n> sorry, this has to go through some other path, I'm going to take\n> patch 1.\nRight, I will take care of it, DT patch should go via SpacemiT SoC tree.","headers":{"Return-Path":"\n <linux-i2c+bounces-16824-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fTwid/KS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16824-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"fTwid/KS\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhkWv5XV9z1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 13:06:03 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id B192E30136AC\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 02:05:47 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 3BBEE3264C0;\n\tFri, 27 Mar 2026 02:05:46 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D43962BE65B;\n\tFri, 27 Mar 2026 02:05:45 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 05C77C116C6;\n\tFri, 27 Mar 2026 02:05:44 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774577145; cv=none;\n b=oJOhbAKRlalEz+MDFyLQrdZFXsPcTxndNvo6QvTUeT1t1Fc4kgvsPN/BoTEGmLzCWnwuhEPDW/AKsJa9MjaIqgM6ZNptX3bhak/uY+NGIgIRQ+U97gJiR/I8GPJFOp+3u0+85TPixNAMSxxwF0LwDzZ5tsklD3DyIEAHEM3H768=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774577145; c=relaxed/simple;\n\tbh=I3+vM76RROlsr5DE3W8ojD/qPlnILtB5bMHYIL9PoPQ=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=L+xUPnquCZ+cEzL6A7eSVic2EoJladc5fRWGHfYqyfV0UbAv/bf3h8bvDTWpmM0i4bM5WB2h8iDhHNmqZoH9mzkGAAFNFAU9sV1HMArDR0u0auSJXU+w0pjrgDuwQdZlHOEUe12Cf6eJj2vr5r+7c89ZJsHf8TmDZwhF31RCOjo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=fTwid/KS; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774577145;\n\tbh=I3+vM76RROlsr5DE3W8ojD/qPlnILtB5bMHYIL9PoPQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fTwid/KSiNHM4qXkkQl/gCuBOZeRmvMSv38BMxA3i2PvATL2v4Y5RTZ/4rcSRzluu\n\t YUXJqDp/INBj1YNOskVBKEvdw/f8fUr5OyKdrnqdFMzS6Yt8dfqwiuF0y5c/rUsiny\n\t qnrV/GwY0+M9xNlw38WFPuSVp0mMRyEaN5PLJ1Ksrk8aK5l7BlprDLvNPwibICKJIV\n\t ADszaELnHkRhgaf887LQCsokOwoJYwR19t0JyjtQ0Ql1A8viLIfRFAW3ghuTRz0SjJ\n\t rSx6MajniJ6CeN6+6T84p5FdZRSugiDW9K4jvP2kRsGQ42DTpOuSLyEtPztUeT7qKe\n\t knNLwxccB16nw==","Date":"Fri, 27 Mar 2026 10:05:43 +0800","From":"Yixun Lan <dlan@kernel.org>","To":"Andi Shyti <andi.shyti@kernel.org>","Cc":"Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,\n\tConor Dooley <conor+dt@kernel.org>, Paul Walmsley <pjw@kernel.org>,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>, Alexandre Ghiti <alex@ghiti.fr>,\n\tTroy Mitchell <troy.mitchell@linux.spacemit.com>,\n\tlinux-i2c@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-riscv@lists.infradead.org, spacemit@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","Message-ID":"<20260327020543-GKA847041@kernel.org>","References":"<20260325-02-k3-i2c-v1-0-78f29c83d9ac@kernel.org>\n <20260325-02-k3-i2c-v1-2-78f29c83d9ac@kernel.org>\n <acWxJNK_vZca_xCZ@zenone.zhora.eu>\n <acWx_31uT2ffcaSN@zenone.zhora.eu>","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<acWx_31uT2ffcaSN@zenone.zhora.eu>"}},{"id":3670035,"web_url":"http://patchwork.ozlabs.org/comment/3670035/","msgid":"<20260327023932-GKB847041@kernel.org>","list_archive_url":null,"date":"2026-03-27T02:39:32","subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","submitter":{"id":91543,"url":"http://patchwork.ozlabs.org/api/people/91543/","name":"Yixun Lan","email":"dlan@kernel.org"},"content":"Hi Andi,\n\nOn 23:23 Thu 26 Mar     , Andi Shyti wrote:\n> Hi Yixun,\n> \n> > > +\t\ti2c2: i2c@d4012000 {\n> > > +\t\t\tcompatible = \"spacemit,k3-i2c\", \"spacemit,k1-i2c\";\n> > > +\t\t\treg = <0x0 0xd4012000 0x0 0x38>;\n> > > +\t\t\t#address-cells = <1>;\n> > > +\t\t\t#size-cells = <0>;\n> > > +\t\t\tinterrupts = <38 IRQ_TYPE_LEVEL_HIGH>;\n> > > +\t\t\tclocks = <&syscon_apbc CLK_APBC_TWSI2>,\n> > > +\t\t\t\t <&syscon_apbc CLK_APBC_TWSI2_BUS>;\n> > > +\t\t\tclock-names = \"func\", \"bus\";\n> > > +\t\t\tclock-frequency = <400000>;\n> > > +\t\t\tresets = <&syscon_apbc RESET_APBC_TWSI2>;\n> > > +\t\t\tstatus = \"disabled\";\n> > > +\t\t};\n> > I think we should add a comment here to explain why there isn't i2c3.\n> > Otherwise, LGTM.\n> \n> are you going to add a comment here?\n> \nI will explain and re-spin a v2, and add a short comment for this:\n- i2c3 is reserved for secure domain which not available from linux\n- i2c7 simply does not exist from hardware perspective, K3 SoC want to\nkeep align with K1 to use same index of I2C controller for the pmic\n\n> > Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>\n>","headers":{"Return-Path":"\n <linux-i2c+bounces-16827-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ev26ueLC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16827-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ev26ueLC\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhlYn5s89z1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 13:52:45 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 827C5304EDFF\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 02:39:37 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 91667295DBD;\n\tFri, 27 Mar 2026 02:39:35 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 35F1812B93;\n\tFri, 27 Mar 2026 02:39:34 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 52472C116C6;\n\tFri, 27 Mar 2026 02:39:34 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774579175; cv=none;\n b=lhiwBkrflskc0VDLFxiYP+FmH9fr9t2dqJoQjCLA8oNbeSuZx9EBRiTm0D8BQslHmbLGaM4wWr8siZadEDmsoSrFWkbqwfVVAzeH6s0P3vgWv6QUCw0hq+5Wk5e/+IjD6rjAXjF6xK9UyKsitFkrc4Q1fNCRrzvStQvKKtw6Ow0=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774579175; c=relaxed/simple;\n\tbh=nPT7x6y5OId4DsW14tOEiyeCCaLNclGNjCQE6YiTrPg=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=mMKDo+iGsRsTc1lbHTVhPM8CKop5/qLKHCKfSG3DA20OQ2Im1q7xf4PfGF7peLYGz7D3eLVMIITISxEzHe5ZNBWY2lalOiHKP1Gix46leQaT1VTzeafEBawAGY2YasS36wX4e6AMng1q5hDYuMQ9qFcIQYG+HOI2dg+0uP2ctp8=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ev26ueLC; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774579174;\n\tbh=nPT7x6y5OId4DsW14tOEiyeCCaLNclGNjCQE6YiTrPg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ev26ueLCManETECjx1/dcSq1/69edXtwNfKl/zr0ktQbMoiAivqI624JX9x5Wokiy\n\t YW/nt/DrkJqKxJBwvV+1aIHjqLbnli/kNOB4ZM/haGyWfUZH5gVnlgf6DOLwxPJ9p8\n\t U3J/HQvmH1cjbTsAn7xAM8zdTGPXuJvi0bV+Egds1cniXdE2zw0wm8NhvSvSPeGrWU\n\t wmzS8vLDiP+/K9BN0iAQe80ydDQzAdEq4WPDSrN5OwU20D2ss3laTJbSNAGUIDGB79\n\t s3UkD3COFqQ69QDx1fkfPWBOfu8XL/tX0DpIFs2GrHim7Yj4I5W2X5rwqcF+ZlhG/5\n\t 0UtCqmOsZ2ZHw==","Date":"Fri, 27 Mar 2026 10:39:32 +0800","From":"Yixun Lan <dlan@kernel.org>","To":"Andi Shyti <andi.shyti@kernel.org>","Cc":"Troy Mitchell <troy.mitchell@linux.spacemit.com>,\n\tRob Herring <robh@kernel.org>,\n\tKrzysztof Kozlowski <krzk+dt@kernel.org>,\n\tConor Dooley <conor+dt@kernel.org>, Paul Walmsley <pjw@kernel.org>,\n\tPalmer Dabbelt <palmer@dabbelt.com>,\n\tAlbert Ou <aou@eecs.berkeley.edu>, Alexandre Ghiti <alex@ghiti.fr>,\n\tlinux-i2c@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-riscv@lists.infradead.org, spacemit@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 2/2] dts: riscv: spacemit: k3: Add i2c nodes","Message-ID":"<20260327023932-GKB847041@kernel.org>","References":"<20260325-02-k3-i2c-v1-0-78f29c83d9ac@kernel.org>\n <20260325-02-k3-i2c-v1-2-78f29c83d9ac@kernel.org>\n <DHBSTI0A3SOW.PCIP544HUYP4@linux.spacemit.com>\n <acWxqkR8Z0rwe4hI@zenone.zhora.eu>","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"<linux-i2c.vger.kernel.org>","List-Subscribe":"<mailto:linux-i2c+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-i2c+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<acWxqkR8Z0rwe4hI@zenone.zhora.eu>"}}]