[{"id":3673480,"web_url":"http://patchwork.ozlabs.org/comment/3673480/","msgid":"<177532201484.28194.6879238704665681982.b4-ty@b4>","list_archive_url":null,"date":"2026-04-04T17:00:14","subject":"Re: [PATCH v1] PCI: imx6: Fix reference clock source selection","submitter":{"id":91273,"url":"http://patchwork.ozlabs.org/api/people/91273/","name":"Manivannan Sadhasivam","email":"manivannan.sadhasivam@oss.qualcomm.com"},"content":"On Wed, 25 Mar 2026 10:31:16 +0100, Franz Schnyder wrote:\n> In the PCIe PHY init for the iMX95, the reference clock source selection\n> uses a conditional instead of always passing the mask. This currently\n> breaks functionality if the internal refclk is used.\n> \n> Pass always IMX95_PCIE_REF_USE_PAD as the mask and clear the bit if\n> external refclk is not used.\n> \n> [...]\n\nApplied, thanks!\n\n[1/1] PCI: imx6: Fix reference clock source selection\n      commit: 575d7268ca07fcb1d1a50399e1399ba60df3cb27\n\nBest regards,","headers":{"Return-Path":"\n <linux-pci+bounces-51890-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=pH6exHM4;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=CwSvSlTm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-51890-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"pH6exHM4\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"CwSvSlTm\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fp20H6DgPz1yG2\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 05 Apr 2026 03:00:31 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 8A98830054CD\n\tfor <incoming@patchwork.ozlabs.org>; Sat,  4 Apr 2026 17:00:28 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 32073208D0;\n\tSat,  4 Apr 2026 17:00:28 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 09CE12741A0\n\tfor <linux-pci@vger.kernel.org>; Sat,  4 Apr 2026 17:00:26 +0000 (UTC)","from pps.filterd (m0279864.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6344dn8f2971843\n\tfor <linux-pci@vger.kernel.org>; Sat, 4 Apr 2026 17:00:26 GMT","from mail-pg1-f199.google.com (mail-pg1-f199.google.com\n [209.85.215.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dauth937b-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <linux-pci@vger.kernel.org>; Sat, 04 Apr 2026 17:00:25 +0000 (GMT)","by mail-pg1-f199.google.com with SMTP id\n 41be03b00d2f7-c7651644975so1664711a12.1\n        for <linux-pci@vger.kernel.org>; Sat, 04 Apr 2026 10:00:25 -0700 (PDT)","from [192.168.31.133] ([2409:4091:a0f4:6806:b530:cb:a537:434d])\n        by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-82cf9c41bc6sm9368133b3a.29.2026.04.04.10.00.14\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Sat, 04 Apr 2026 10:00:20 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775322028; cv=none;\n b=oIobDMMg95H3cYnHaiXldbH0riI7o+8QwanDel+wU24p2gCNF05yZnhwzu6o4OlToTfO3Y0amPrAS1AT5z2mhV4nQsOKCwmKD+mA8rWQBh1aaF3rE2zueY5OAlAJ9oFjQoanEo8XYsw2ar9oWK3BDtjtfx7YVJK4cDmFWY9XrWc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775322028; c=relaxed/simple;\n\tbh=gjCBGAGP81EOH2oljnu2NmddwK9MeX+IixvluhZ/qRk=;\n\th=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date:\n\t MIME-Version:Content-Type;\n b=e0gX0PZ4yKd/RehhZFQJ74gIV8BjaJwYSCYS72TFb0bJqU+XN+HbZIuc6FIjoiUtDsfIOCPQpumvGmMP7psD7sZjpIJNTcCHkNDYITa9SVzvZNqETB0hWDSRpNkcBu5SiTOkBSX0vqG0MCXcjPRg3PIkLVh/SGmmgDo7cD5+SVU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=pH6exHM4;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=CwSvSlTm; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tBHYoMiuT+hFy3l8CYUd8tWmBQMWoLPghXx653KocS/A=; b=pH6exHM40Mb/jWHv\n\tEoF7X2tC/uk6AA9v7E9Q/VuVuKiLEkYBvoRmtkc1E+RiedArGBAhQ9IbgkB5fT1N\n\trOnUeRcbJSgBNTRFneYmWNKzG0iykmLfa1NqQxZcC19ab+1ZzhkX8kTpOu2Vbbc+\n\tzf0FSZ+UOlAbmmEI4KtUQ4ZHbIaWMn8rl9EDflmN1FQV77v0iJCkokF2KcPO3UCe\n\tHM/JmqM4gEMyWre32+vTQVWNA82Dkjngur1J+STLBCllNnPIpXOBDFvNwOOwfxJp\n\tY5IXnWteBbyUqmwvuFWeOo0epAbyzj5unJqzRoNWxYgKY52trakJgqP3bTDjSdUc\n\tvOVEEA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=oss.qualcomm.com; s=google; t=1775322025; x=1775926825;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:date:message-id:subject\n         :references:in-reply-to:cc:to:from:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=BHYoMiuT+hFy3l8CYUd8tWmBQMWoLPghXx653KocS/A=;\n        b=CwSvSlTmGIwLtwNnzKQjIPfhOj2aA1NLIPrOKRc3kxqGpa8LLF+DmlyJwo3wyLAkFI\n         YW7236IFYOZc1XDMYIxjFvvIyn+4NMr8n43nTqNfJXfU0ThO/e4TFR2l1iIn1w/jp9+a\n         MXWi22GjUKo55gAfGNmikPp4zQBHczsd7jJlXJ3r6qabmuiTM72/ZFougyCdMgkNpEKE\n         28YoV9KLSgrRBeA4vdk2qfdilKu59DcA19OUjd3oCIxeErWTR6wPtimDOLMGx02rwEUS\n         dm4krNKfAUOv9tfYjQz8MtVsZNxZfyGgQHqFQcqU+8qTZBFNKz59/1PoP9dMFWBOplO5\n         +7ZQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1775322025; x=1775926825;\n        h=content-transfer-encoding:mime-version:date:message-id:subject\n         :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=BHYoMiuT+hFy3l8CYUd8tWmBQMWoLPghXx653KocS/A=;\n        b=JkAwKy7ZN+Nf6ASrGo5k63ujJoGolm9+fYUU93f8Za82qYZrGx2VwGzDXH3Ev8XhDf\n         0JlWBNdXsuVjZ9cZyQ0l7KeaESvP82D8V1LgMTu7t+wclIbTLlBwwtVEZmrK5M5X8L1D\n         S7tMaSnUx/SVz8WMy7a24tLfKbokyXbGSJo6vpxSVYc1T+XNsP1DD4Uhll6tgKT2fIrp\n         Jh0EAFCOva2dm0ZsuH4y+D6vbhxRRq3xPLgSVsbWK3UrkuSDdIlmXAdyoFgHHmp6d+4n\n         u7eR2s8yQLYpAv2ithEPiVeJokB8d8mxvUqc0rMKUp0wzPeaSpD2wpCDHhjE2oRKHwAT\n         NhRg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCX9lXI2NKbfANdHgPeKcedmK4E/45XExzCZGpLO3tFfe6z5uY6tCRW5BUHXJEJpBwYSN0er+GEz908=@vger.kernel.org","X-Gm-Message-State":"AOJu0YwB1KhGG8gU3IjSUM1B23l1Sy/1DtwEn6r80kapLWSe5MOb937w\n\ttwPefO0qZ+8oAAxNyN3vo0Vj6mXZDwFkThpzJ8cxyJjprw9AG3HPwBWNm3uiBSFmL6BUI1eXiZj\n\tevchitdbkh7OWRkuVsPQrwUk4Tb+S+75QExbAlqTiNVuprPF5bWPG+ga7fOAEACs=","X-Gm-Gg":"AeBDiesou5vo9gxr+yeNCy0a+tFQ5pG3oMQKIrxfF5yDw2BQEnsl6okqhIoq3UpFamJ\n\tAVt1tO7/c1yS6dtPsotpFtY+gP9W+jdVZPOk2SKRQ0iYf0vS1F0Hn7UaMPtIpm5vc5EyzGJtMDc\n\t04IWm04iDyOcw7QWkoOJXTs9qPynEG8GGW5azyn8L+WCEOvgg9C33zCEzQhgmqA74KB78krVNbH\n\t6QC9EMh7WMQYqXAYMIkmAiuimHO9o/JJiXuPuuCGiuNcPmXPzvbq/S5IqNpC8nBxXGnm/zsuZrs\n\ta8FYAEg7jsRO7P7+R4kkv6R8ZCtMB81N6C2xJhQnSq2YaxUCiMSgPfcRtEtcSsU3yOSi8ND4Dj4\n\toy8zuyU4TkgX4KI3aZnBANDTX","X-Received":["by 2002:a05:6a00:a0b:b0:827:2c79:fa84 with SMTP id\n d2e1a72fcca58-82d0da45d27mr6277596b3a.12.1775322021788;\n        Sat, 04 Apr 2026 10:00:21 -0700 (PDT)","by 2002:a05:6a00:a0b:b0:827:2c79:fa84 with SMTP id\n d2e1a72fcca58-82d0da45d27mr6277559b3a.12.1775322021206;\n        Sat, 04 Apr 2026 10:00:21 -0700 (PDT)"],"From":"Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>","X-Google-Original-From":"Manivannan Sadhasivam <mani@kernel.org>","To":"Richard Zhu <hongxing.zhu@nxp.com>, Lucas Stach <l.stach@pengutronix.de>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= <kwilczynski@kernel.org>, Rob Herring <robh@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>, Frank Li <Frank.Li@nxp.com>,\n Sascha Hauer <s.hauer@pengutronix.de>,\n Pengutronix Kernel Team <kernel@pengutronix.de>,\n Fabio Estevam <festevam@gmail.com>, Franz Schnyder <fra.schnyder@gmail.com>","Cc":"Franz Schnyder <franz.schnyder@toradex.com>, linux-pci@vger.kernel.org,\n        linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,\n        linux-kernel@vger.kernel.org,\n        Francesco Dolcini <francesco.dolcini@toradex.com>,\n        stable@vger.kernel.org","In-Reply-To":"<20260325093118.684142-1-fra.schnyder@gmail.com>","References":"<20260325093118.684142-1-fra.schnyder@gmail.com>","Subject":"Re: [PATCH v1] PCI: imx6: Fix reference clock source selection","Message-Id":"<177532201484.28194.6879238704665681982.b4-ty@b4>","Date":"Sat, 04 Apr 2026 22:30:14 +0530","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Mailer":"b4 0.15.0","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA0MDE2MSBTYWx0ZWRfX8GdpQzp/gUMF\n JTrA/D6VA6IXBuQ3iJXS4++hjUCOOxkl0+eK80HKUxjjkDUkK4DxjDrEibLy6i6vupnHC4/FDt/\n J7IbhZ6G19SvAPLObP3JIJAZZGIVmnP/gN5MlkX1PM1vayF/oiZW8ptlgdMly7IdXPYEA2S7OUC\n OEXiq+BD/tBtFVMu4LnF+c6EpTv/sWNyrRw2e5dqj1cnfpAalq7DmVMO/xzCuYenuwHmT17GRSK\n cgXdR7ZNOQ/bS9QRyOu9SEddmvoIEomWjHUTXHf6t4mHxEfcbNAQ3rQWWAi3UMTuDaHeRNvQBl7\n py5OpJqadCdrMNe2vNDerQ7iEIAmfNOjZJ4aesXTsTJd+1kPqbPNQ+CKihpTqRphLsdfs391xha\n yMXt4nLw4SVpHBdfyMlrCjM1Usd591Ku+BiKb1y8wSJbLL3S8tuF+RQAi1ea1N0wgIb0UkT1TTL\n n5jALRaomP5sSMOOjkQ==","X-Proofpoint-GUID":"4l52FHJE77cLNKRBZy0Ds80wSDKfPA4C","X-Authority-Analysis":"v=2.4 cv=MIptWcZl c=1 sm=1 tr=0 ts=69d143a9 cx=c_pps\n a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8\n a=d2OGGJ5TCE6yqAnRVzwA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22","X-Proofpoint-ORIG-GUID":"4l52FHJE77cLNKRBZy0Ds80wSDKfPA4C","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-04_02,2026-04-03_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 malwarescore=0 suspectscore=0 lowpriorityscore=0\n priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0 bulkscore=0\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2604040161"}}]