[{"id":3668984,"web_url":"http://patchwork.ozlabs.org/comment/3668984/","msgid":"<cbc2f8e2-82d6-426e-b269-4921fa95b219@kaod.org>","list_archive_url":null,"date":"2026-03-25T10:54:57","subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"+Jithu\n\nOn 3/25/26 09:54, GuoHan Zhao wrote:\n> Commit 7e82393ed058 (\"hw/i2c/aspeed: fix lost interrupts on\n> back-to-back commands\") introduced pending_intr_sts to preserve\n> interrupt bits that collide with already pending status bits.\n> \n> That deferred interrupt state is consumed later when the guest clears\n> INTR_STS, but it is not reset in aspeed_i2c_bus_reset() and it is not\n> part of the bus migration state. A reset can therefore leave stale\n> deferred bits behind, and migration can silently drop them.\n> \n> Clear pending_intr_sts on reset and include it in VMState while keeping\n> compatibility with older migration streams.\n> \n> Fixes: 7e82393ed058 (\"hw/i2c/aspeed: fix lost interrupts on back-to-back commands\")\n> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>\n\n\nReviewed-by: Cédric Le Goater <clg@redhat.com>\n\nThanks,\n\nC.\n\n\n> ---\n>   hw/i2c/aspeed_i2c.c | 4 +++-\n>   1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c\n> index 5d18f8d49ea4..90f83a03fd4f 100644\n> --- a/hw/i2c/aspeed_i2c.c\n> +++ b/hw/i2c/aspeed_i2c.c\n> @@ -1134,10 +1134,11 @@ static const MemoryRegionOps aspeed_i2c_bus_pool_ops = {\n>   \n>   static const VMStateDescription aspeed_i2c_bus_vmstate = {\n>       .name = TYPE_ASPEED_I2C,\n> -    .version_id = 6,\n> +    .version_id = 7,\n>       .minimum_version_id = 6,\n>       .fields = (const VMStateField[]) {\n>           VMSTATE_UINT32_ARRAY(regs, AspeedI2CBus, ASPEED_I2C_NEW_NUM_REG),\n> +        VMSTATE_UINT32_V(pending_intr_sts, AspeedI2CBus, 7),\n>           VMSTATE_UINT8_ARRAY(pool, AspeedI2CBus, ASPEED_I2C_BUS_POOL_SIZE),\n>           VMSTATE_UINT64(dma_dram_offset, AspeedI2CBus),\n>           VMSTATE_END_OF_LIST()\n> @@ -1510,6 +1511,7 @@ static void aspeed_i2c_bus_reset(DeviceState *dev)\n>       AspeedI2CBus *s = ASPEED_I2C_BUS(dev);\n>   \n>       memset(s->regs, 0, sizeof(s->regs));\n> +    s->pending_intr_sts = 0;\n>       i2c_end_transfer(s->bus);\n>   }\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kaod.org header.i=@kaod.org header.a=rsa-sha256\n header.s=ovhmo393970-selector1 header.b=d+2GWjNF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","garm.ovh; auth=pass\n (GARM-105G006b58b77fd-c109-4057-a78f-e0603fae2a86,\n 796938FF8373C45809F81B5903BEE6B4DB9E2182) smtp.auth=clg@kaod.org"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgkN73PVbz1xy3\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 21:55:51 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5LtT-0005rI-Tn; Wed, 25 Mar 2026 06:55:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <clg@kaod.org>)\n id 1w5LtN-0005qm-KB; Wed, 25 Mar 2026 06:55:17 -0400","from smtpout9.mo534.mail-out.ovh.net ([178.33.251.187])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <clg@kaod.org>)\n id 1w5LtK-00009x-SV; Wed, 25 Mar 2026 06:55:17 -0400","from director4.derp.mail-out.ovh.net\n (director4.derp.mail-out.ovh.net [79.137.60.37])\n by mo534.mail-out.ovh.net (Postfix) with ESMTPS id 4fgkM84735z60Ks;\n Wed, 25 Mar 2026 10:55:00 +0000 (UTC)","from director4.derp.mail-out.ovh.net\n (director4.derp.mail-out.ovh.net. [127.0.0.1])\n by director4.derp.mail-out.ovh.net (inspect_sender_mail_agent) with SMTP\n for <jamin_lin@aspeedtech.com>; Wed, 25 Mar 2026 10:54:59 +0000 (UTC)","from mta11.priv.ovhmail-u2.ea.mail.ovh.net (unknown [10.110.43.51])\n by director4.derp.mail-out.ovh.net (Postfix) with ESMTPS id\n 4fgkM76C41z1xvG; Wed, 25 Mar 2026 10:54:59 +0000 (UTC)","from kaod.org (unknown [10.1.6.7])\n (Authenticated sender: clg@kaod.org)\n by mta11.priv.ovhmail-u2.ea.mail.ovh.net (Postfix) with ESMTPSA id\n 7D94F240397C; Wed, 25 Mar 2026 10:54:58 +0000 (UTC)"],"X-OVh-ClientIp":"82.64.250.170","Message-ID":"<cbc2f8e2-82d6-426e-b269-4921fa95b219@kaod.org>","Date":"Wed, 25 Mar 2026 11:54:57 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","To":"GuoHan Zhao <zhaoguohan@kylinos.cn>,\n Peter Maydell <peter.maydell@linaro.org>","Cc":"Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Jamin Lin <jamin_lin@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n qemu-arm@nongnu.org, qemu-devel@nongnu.org,\n Jithu Joseph <jithu.joseph@oss.qualcomm.com>","References":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>","Content-Language":"en-US, fr","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>","Autocrypt":"addr=clg@kaod.org; keydata=\n xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo\n 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t\n yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj\n 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0\n ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV\n RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+\n gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia\n 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS\n Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS\n tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl\n IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL\n BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd\n M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m\n 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/\n jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl\n TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj\n neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ\n VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ\n QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J\n ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w\n WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O\n wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL\n SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU\n cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+\n S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc\n 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6\n hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d\n tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/\n t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c\n OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475\n KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8\n o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX\n ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0\n IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta\n d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it\n +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n\n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS\n l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY\n 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls\n ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt\n KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4=","In-Reply-To":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","x-ovh-tracer-id":"13763844889324596246","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"\n dmFkZTE/kBvEMuP/lvNh4aza2QNNOwAz5RGsYOdPdOo8LzV3CNr9yZe+SZHmwM0XBPKJJAYheLIDZJ6sP/9eSAveXokL02fJOhONrcAsDm9ynk0pUtYWoD+hX7SWLYyzh/ooEN6/lAZtGK3jJI+2mtG/hYPr09qOw6ALkJ05qZxyWNbzOv/LYu8+Ev0bdRFPzenH1C4BM3Kgk/JhDMTW+OUvxon/hmusGIhszamipt+w8TpaBekZo/xTWnjF8g6pKx1jjnc1bS1FJPZ9lWlz5GgrwpZ7m/HIRGydEvjPPy9cTe5epgFni12bTVhCWWQmf0WtTH6/jbWqr/vgvfvL9fDhq1N6Womp6hdZydSWOC2Y7x7tZWhXVoO6ZEogZfKqpKqxgy13tt7OMuh0OgnWyjn4ENpogV5Tmt9mnalNHnGc0U2ioS0ITikLoYvk3AlKfOU82sxQYS2HmS27aeAO08BX+TrXWAvzs00I64+hZX3gdIcfigkHJ3OJFXURejyai9AwTYdZt6dXeRixJ1t2gDMX49PFC+ekkc0ULfCiARixGsGTk15VPrU7p67mNK1YAYk0cuRKRWj/FDfzvHH5OcB+Bj2nRSdGwO4LIrPK93RMTCvhFpXnxWV20kTFYtCB5xyCPBkDe3PEBtn76Ch0JesMYO6epTMa1F/4evAzcvJ1lPtxLw","DKIM-Signature":"a=rsa-sha256; bh=z3ruGhnxssl+qyLC5+ftx1nRQlkiV4Gj7AZ22MaILF4=;\n c=relaxed/relaxed; d=kaod.org; h=From; s=ovhmo393970-selector1;\n t=1774436103; v=1;\n b=d+2GWjNFhBiTU+TJdQrvT7Re/J3KjLQlqujCNzkls2Pul99ZuXuRfQYcEq/dQFX41N8E913A\n mIUysdKXwmN0mEyhlg15QRoQHF8dm4MftRWreldHyBAH6OWTIW0cwuV6T4B/0GOD5eXrmx25b+i\n f9qFp5RDCSaTHysSwP24OId9bUAmXU6J+jk1bY5B/k3zUXR3oaJin+205fS+lYIbE7pUchhaL28\n 9MCGch/Ji4vps9hX7hnx65TgXNZai05JrUI5yefnUXdwMBeLhcGLePH6W2v3IOl2HrN4sbX2Kgx\n hshOv66RFs7lp2b6xg+EzI7ACA1CqwER+jbaM/TtWz4Zw==","Received-SPF":"pass client-ip=178.33.251.187; envelope-from=clg@kaod.org;\n helo=smtpout9.mo534.mail-out.ovh.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3669993,"web_url":"http://patchwork.ozlabs.org/comment/3669993/","msgid":"<7927329d-68a5-48ff-9a90-3c010637c643@oss.qualcomm.com>","list_archive_url":null,"date":"2026-03-26T22:54:19","subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","submitter":{"id":92727,"url":"http://patchwork.ozlabs.org/api/people/92727/","name":"Jithu Joseph","email":"jithu.joseph@oss.qualcomm.com"},"content":"On 3/25/2026 1:54 AM, GuoHan Zhao wrote:\n> Commit 7e82393ed058 (\"hw/i2c/aspeed: fix lost interrupts on\n> back-to-back commands\") introduced pending_intr_sts to preserve\n> interrupt bits that collide with already pending status bits.\n> \n> That deferred interrupt state is consumed later when the guest clears\n> INTR_STS, but it is not reset in aspeed_i2c_bus_reset() and it is not\n> part of the bus migration state. A reset can therefore leave stale\n> deferred bits behind, and migration can silently drop them.\n\nThanks for identifying and fixing the aforementioned omissions\n\n> \n> Clear pending_intr_sts on reset and include it in VMState while keeping\n> compatibility with older migration streams.\n> \n> Fixes: 7e82393ed058 (\"hw/i2c/aspeed: fix lost interrupts on back-to-back commands\")\n> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>\n\n\nReviewed-by: Jithu Joseph <jithu.joseph@oss.qualcomm.com>\n\n\n\n\n\nThanks\nJithu","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=cAjg7otc;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=a90Lg6FT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhfHb1gZCz1yFp\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 09:55:07 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5tb1-0000bw-8S; Thu, 26 Mar 2026 18:54:35 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jithu.joseph@oss.qualcomm.com>)\n id 1w5taw-0000bA-Qn\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 18:54:32 -0400","from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jithu.joseph@oss.qualcomm.com>)\n id 1w5tau-0000W7-6E\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 18:54:29 -0400","from pps.filterd (m0279870.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62QI58OO1476152\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 22:54:24 GMT","from mail-dy1-f197.google.com (mail-dy1-f197.google.com\n [74.125.82.197])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d59s40t1e-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 22:54:23 +0000 (GMT)","by mail-dy1-f197.google.com with SMTP id\n 5a478bee46e88-2c0ba59a830so1602386eec.0\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 15:54:23 -0700 (PDT)","from [10.110.108.41] (i-global254.qualcomm.com. [199.106.103.254])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2c16ee39627sm3608032eec.30.2026.03.26.15.54.20\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 26 Mar 2026 15:54:21 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n GAJeOIQCFcqcDe0X77W4oTwnmC/GvUDN9WOkXNBwQWo=; b=cAjg7otcfSf4d4IO\n 8pTfxIJdj86oMHOhH3LopNYVb2Ovp/nPr5XCo4sAQlzPTqWHW0xYiNIRCMrpm4hD\n Id9zMLw+sELFhfu6n7r50q4ONDaOhzuqi5Hp4lLctj5/7FZaYIvt/+JqBjjB73T4\n ZaI2ZlXb+OIIYps7/V/tpQNjv6SeUGI4pf4OUexfGqfIY64m4P33N4mZZQpZYbrk\n gMjUVPAaJxUER5PuDoWD2WOhtihUxKHBYRN24M4uxpLFTaYvEeC36MwLEihBMa1h\n NmaiHAjzvaCrFTgMKF8YbqYnNM81cAp4EVOFpzPGuDDIG6ybpmw/cNjkQRu6gSe6\n WkLtSA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1774565663; x=1775170463; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=GAJeOIQCFcqcDe0X77W4oTwnmC/GvUDN9WOkXNBwQWo=;\n b=a90Lg6FT74Bof6QcimzGwC5gz6Qnj2gYVnI5sai00TyRlULMYkwbMmOSTl54geL7/7\n 7zZz8ctrwwBC1wZXM808v4hloPCnBolkgaEsWvuQi0yt2JPlN/aR0zK5A5pMw1MaGMkp\n +cZ+SiOqRSyDPaLYIz7/X7aqOQwvZCYy6i31QiJ1G4bNEFX8fZMsHExmoAR+p3NObTII\n Q0YvkyZLPbHOpWv/ETPRZP1zyFQRI3UmceIs9HoVe79lsQuiCLM6YbcV0tynjRElWtUo\n MrCmzbVi+5+FzrzX0oa6WldiDnE0nXyTLyTvwqfJxrjJdRHbBgKrgD5HFJCYA8dUgIuN\n WXCQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774565663; x=1775170463;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=GAJeOIQCFcqcDe0X77W4oTwnmC/GvUDN9WOkXNBwQWo=;\n b=Af/KADd2OUd0C0MKjEIlfi9mi5Sp8xbfPU2MvIsRdgqzX7mhkzuYMGtBCVu+o/u9vC\n +rUZv/2CgI41DMqAopmBgxH2IirB1j/8uELEjpzvAUdHQ8NRs1uoRl9nx24r89cCcDta\n 52Oa0O2rDcNHk/w7dBnsfrUFhmqx8QLs9de0HE10BtebvcQCstp/4rd2uYj2xU+GnXWS\n MuinIGLNZ/qCEDMHHX7A8Uzvur390EkWEfuLLetqXAMGU0ib0+Z1Kf4Vj13tCy6m0Jk3\n pjXX9nVoMxYlKUR6KIpbpEYCsGtWxxXNEgJG0C4nx683j9lL/EgwK9/06ngPQAhR/lzO\n /Nhg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVnTazhsJhTbr8KcaE5s9QSEVMMYwkpUOiZQpCgxTxMgcTNqCdmEahnSf0Zv9VsbFbMcYTeZIlJnvce@nongnu.org","X-Gm-Message-State":"AOJu0Ywfug3x5ex6yrH526e5gRvdStH8Zrrp9DGxWsNzKl8PBA2gFIuf\n rHVO4J7k251qgX+ePDi/XJ2XE6BjX69Z6nDZX8PutdKnH4K4Fd2gOpS0eQ5HOgeI87jA4rFVjm2\n 0PtoncJ85ge46lkLF9p04MZTF3vbzW6H+HKfEO71a3AwIDw6e5Nx0Vj6KZg==","X-Gm-Gg":"ATEYQzzfhm/Z/5kr+z7JFdZ9iqlQNjEabm2Wg7ss38ByxwtnX/8zK94QQrdZYVOCLsW\n o456D7XHOQJH8MOkfHx4411T+/eq4olLcQJta7mHRWrTowEUrxEJVRyiO8y8pZFMfmQHBzUQkT1\n qtCtaxsJNBT8lykBc0TKXoXWBFnu7RtdewMU9U2bRTzDnXvkr83h+aTeb2CPsUJrFNYRneJi035\n rvEbTM1yZPBF5fJbOAqu7UgFb6DGpsKRs6x376jw5qS5UdBKlvh1+u4MnZTuP5GAFag8FQsotzK\n gRKenOOyAxLLKv+UzdNETCvco72oviAZVFvt2uBFYjItvQWJNYGsjccR0jTByli28+W8UNjglgE\n C5gjEHR8O1RfMINOZ7mEtAGswxcWFGBukEfbid90S7rhCMpVwmYpA8zisZHCT22k6gUjhkeW8jt\n pdr3k=","X-Received":["by 2002:a05:7022:4398:b0:127:9e95:a2f with SMTP id\n a92af1059eb24-12ab2838ba5mr218915c88.2.1774565662827;\n Thu, 26 Mar 2026 15:54:22 -0700 (PDT)","by 2002:a05:7022:4398:b0:127:9e95:a2f with SMTP id\n a92af1059eb24-12ab2838ba5mr218897c88.2.1774565662265;\n Thu, 26 Mar 2026 15:54:22 -0700 (PDT)"],"Message-ID":"<7927329d-68a5-48ff-9a90-3c010637c643@oss.qualcomm.com>","Date":"Thu, 26 Mar 2026 15:54:19 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","To":"GuoHan Zhao <zhaoguohan@kylinos.cn>,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>,\n Peter Maydell <peter.maydell@linaro.org>","Cc":"Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Jamin Lin <jamin_lin@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>,\n Joel Stanley <joel@jms.id.au>, qemu-arm@nongnu.org, qemu-devel@nongnu.org","References":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>","Content-Language":"en-US","From":"Jithu Joseph <jithu.joseph@oss.qualcomm.com>","In-Reply-To":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-ORIG-GUID":"wFTKMpYQHvA8_ArR3eY8Kgmh4VuBZWTA","X-Proofpoint-GUID":"wFTKMpYQHvA8_ArR3eY8Kgmh4VuBZWTA","X-Authority-Analysis":"v=2.4 cv=CoGys34D c=1 sm=1 tr=0 ts=69c5b91f cx=c_pps\n a=Uww141gWH0fZj/3QKPojxA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17\n a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22\n a=EUspDBNiAAAA:8 a=54KzJIt8zcjPWxL9LpEA:9 a=QEXdDO2ut3YA:10\n a=PxkB5W3o20Ba91AHUih5:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMzI2MDE2MyBTYWx0ZWRfX+nh3/teEy5IN\n 0ktNErhVdxg+Xp/kXM8We3+y80DouPHp4BZOouvI1e/V2HuRi0ukQbnUcYz2aRaArSIjJ48KmTi\n evCB/F68YEJq5xclpTA9xcrR8L2BbBwaUvDcu8p1w1EaS914N7Bec+A/a3bzVBBcomR/p/Wkee4\n HlXPOhO0kXI9vziCRnKsAqck+sikuw8bcjPlu/8TPY4GJh+UaWiTITfXN2nexFIjeHoT/bHyh5w\n X0rQBLJy30DmQ7d0+CuEfysJcIE/dk2BdOioD3yDTDOJgGg0XqTBCRwEG/8j7BFXUazLXMOnGmk\n OLTae/ZhpHaivgQ9CERmAqCyk9MjNIwf80MFiD2J+KpJfJCSKOo886ZmOK0w2XXftoCzLyoe9cn\n hNA94DhiFSdvT9XpUoFt98tAig2aom5cyrgPyhGFpdJZAsSl9HNtlZAbR99+vmYU9q6d8jNIcAy\n Z1YnoaDKQsMDAoK8ozQ==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-26_03,2026-03-26_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 clxscore=1015\n lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0\n phishscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2603260163","Received-SPF":"pass client-ip=205.220.180.131;\n envelope-from=jithu.joseph@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3669994,"web_url":"http://patchwork.ozlabs.org/comment/3669994/","msgid":"<fd4b0bdd-fb93-48c6-b0f4-228a7abfc8da@oss.qualcomm.com>","list_archive_url":null,"date":"2026-03-26T22:57:19","subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","submitter":{"id":92727,"url":"http://patchwork.ozlabs.org/api/people/92727/","name":"Jithu Joseph","email":"jithu.joseph@oss.qualcomm.com"},"content":"On 3/25/2026 3:54 AM, Cédric Le Goater wrote:\n> +Jithu\n> \n\nThanks for looping me in Cédric. Will be mindful of these next-time\n\n\nThanks\nJithu","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=lGa6JG1P;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=PYWWn92s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhfLn25rbz1yFp\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 09:57:51 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w5tdn-0001ki-M0; Thu, 26 Mar 2026 18:57:27 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jithu.joseph@oss.qualcomm.com>)\n id 1w5tdm-0001kK-DL\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 18:57:26 -0400","from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jithu.joseph@oss.qualcomm.com>)\n id 1w5tdk-0001He-3F\n for qemu-devel@nongnu.org; Thu, 26 Mar 2026 18:57:26 -0400","from pps.filterd (m0279871.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62QF9f7E3898185\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 22:57:23 GMT","from mail-dy1-f197.google.com (mail-dy1-f197.google.com\n [74.125.82.197])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d50kgb279-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 22:57:22 +0000 (GMT)","by mail-dy1-f197.google.com with SMTP id\n 5a478bee46e88-2c1030ca85eso1048841eec.0\n for <qemu-devel@nongnu.org>; Thu, 26 Mar 2026 15:57:22 -0700 (PDT)","from [10.110.108.41] (i-global254.qualcomm.com. [199.106.103.254])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2c16ee2a41fsm3584018eec.28.2026.03.26.15.57.20\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 26 Mar 2026 15:57:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n ny/HhoUNm/tnHHrTn0jtbaIZMUa51jEYM0HTK49ptHs=; b=lGa6JG1PpDMNpPYx\n 5ijEg4vMqve50vttUbNL2i03Cg9EAq0TjzN7xi9sNlxs3UcEjECVgMXqCaBZJEOa\n UH6JNdsmlIAuDwDoVmoF/EgcZ0RtPmKsw+miE5JUuu3Wb+IYrgdk8dT0ht9/TjxH\n CRQHOKOQI2T7V3Yyfel9GhiS36o/B2/qU5K+J1mVqsDBGAynvDBCH4SIt/L/rtps\n IW24FY+eTv4z41okwvjo71DsHo0JQ9iFrhCQ3gDjwFrbqViKcnXMx2tmwIUWbBvH\n zFZykxPhCacGzowfY06MQaRsvdbHmAfYvSveiCKJ8RwoZloHe/CMJQ9Bp295/z3K\n dgkmXA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1774565842; x=1775170642; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=ny/HhoUNm/tnHHrTn0jtbaIZMUa51jEYM0HTK49ptHs=;\n b=PYWWn92sWZ7l+b/MCjNJ+N09VNZ81RsXWFb65Jx4lE2Bv2LKdRCRUNE3t95IrurlDy\n mm5KSZ++GUuWxda4jXakPEMjGTVJThqXXHScvGZDdLJeezqHlCtKWizdh+VakL4+7brh\n LqGaqN3+hcY6WY+0/RwrBDxcCvG0Y+iGlGOA7iiWnefhR7/gvqyxzc2jRMx5kJweEe/a\n obFefZ4fhbw11WpoL5gylRI/Q0yEBnemBcugUJZEH3OpqBI2IbZB/cyok4fqMNsIOG7K\n BD+c2/C5ZE8QlUCyPT+0ohNnYTCYsISMZOKoQia9jmdx/fAUoTejtQ1p8b8myjORibby\n HumA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774565842; x=1775170642;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=ny/HhoUNm/tnHHrTn0jtbaIZMUa51jEYM0HTK49ptHs=;\n b=G/30ylHzZhX9IOe4shNlUw/vqu62xlUh0hGRI7ugxeOTk8yJ60S9Q2CbZqS7rpEgxM\n jjzMimi0yNd7EcfonrRUXf9CTYYSkdm/T+Mga/1PvIRvLoTyZxkoe/+TCRBGjrzAgv/t\n Av1Fb4FDx9hi4IV0GgQQInvxkZtjTgn27JyVTeqI1PCRpO8zrH7BBREcnENsinI6MiYa\n bRfmNejDjS8i8D7E6KjUn7MRFdGZL6AUH4dWMFNNLZZLW0cXxlv+G2U9qZ9laLznmO9f\n rrJ2ucuRHEzHDEWF2009nTLKOHUVZr8dm1apxRzUKBkprtQOrZHqeoqx8BwBCsfMh0W2\n RPmg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXkGTc8101vd2SDyfwZMLD4iVv18b1GIW9D8IlDOsMlXg98DC6+HzZqc3ueWSxJ2Sn4rzQu/5OyEUEg@nongnu.org","X-Gm-Message-State":"AOJu0Yw2UvU/0PiZM1XbJpGRMY0SJHxAabIf7aw/XupoY65OY9opPiSV\n NUkzoOL43Tp7F09xbGM/kVcWk5+c8MYnTZH+AnVnVW0mlzfOFtyqrmZNWDQTWi0Uo1qHn1tr+IU\n Vwx5rzX7bJGXcDj9NlJIr/oYpzFBg7zYhCA9H+qGvk3f3bNXHCLZ0onaaOA==","X-Gm-Gg":"ATEYQzywUMGXrgJPHBiP3UzK6OW0SvQWgRquRN+DePkAzDUI3AC1KY0KcYAt+wwmz1g\n rMXjtC2dx2CR+AgTRtCkhqCzM0HQpJ05kkwZoIJkWkw9QlnEqegrdQFydjX+OG3qoPs/16pmFDW\n fl3az2AhehnLeCPuxp+/zOb4udCl9WkbbRkbth8JzIBzMB0BzBpAoBmV6xisNJGcJkcuKlOX+fO\n edOvcGe3I2irZ7NPfH4swVrLAxFNtMHD7WzDlv+J300KR6Aspo5u7rkMJ5yYwvdLsNL24j+ZsW4\n gMxxhnH0RbZokEqTTKbdwL5FtJP59jFntbH88+WDw3D3iIgMDLv7RVswIURvWgjmymZG9b6gLEY\n 4MQcxI6lLBhjkphSKkp9eDqPWvHp1eRp2pyXU7+HA0jhVU7nap8JbAdwnrgd/NvR+ccuq96h+IG\n 2NATg=","X-Received":["by 2002:a05:7301:d0b:b0:2be:837d:cc4d with SMTP id\n 5a478bee46e88-2c185ca3a98mr256475eec.5.1774565841929;\n Thu, 26 Mar 2026 15:57:21 -0700 (PDT)","by 2002:a05:7301:d0b:b0:2be:837d:cc4d with SMTP id\n 5a478bee46e88-2c185ca3a98mr256467eec.5.1774565841343;\n Thu, 26 Mar 2026 15:57:21 -0700 (PDT)"],"Message-ID":"<fd4b0bdd-fb93-48c6-b0f4-228a7abfc8da@oss.qualcomm.com>","Date":"Thu, 26 Mar 2026 15:57:19 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>,\n GuoHan Zhao <zhaoguohan@kylinos.cn>, Peter Maydell <peter.maydell@linaro.org>","Cc":"Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Jamin Lin <jamin_lin@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>,\n Joel Stanley <joel@jms.id.au>, qemu-arm@nongnu.org, qemu-devel@nongnu.org","References":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>\n <cbc2f8e2-82d6-426e-b269-4921fa95b219@kaod.org>","Content-Language":"en-US","From":"Jithu Joseph <jithu.joseph@oss.qualcomm.com>","In-Reply-To":"<cbc2f8e2-82d6-426e-b269-4921fa95b219@kaod.org>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Authority-Analysis":"v=2.4 cv=SMZPlevH c=1 sm=1 tr=0 ts=69c5b9d2 cx=c_pps\n a=Uww141gWH0fZj/3QKPojxA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17\n a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22\n a=mNGNAPgbdfsAtg9pDooA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=PxkB5W3o20Ba91AHUih5:22","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMzI2MDE2NCBTYWx0ZWRfX0Vrc0lxroIAv\n +797jYJY5I16BDSAEbm9x/LLq6gSHaizeOdhFxiTV6q5ANRDvu0xiYEabCgFs88RuwPpzDpERVf\n DY3bTrm846aBbkAKbkxZj+XyOcm5C2XrjojJxi3JtakbeGei/a2zzap9qarrd1Q1vAOwUhXlInC\n LF7E1LIlplRwAtoL0lM69RZGZ4sEHMgdpVSurY1JcK6lWezCmQIXa2N3EFcoQ/B5kkk5agRKH2v\n 6NcdyrmYQQiUQmRUc7iopNHouYQ/p/0DApLZuAryi2SvLGV8jmMEZogcx7NwCHx2DX/FZUOwlTv\n qsJud6Dx5pdXW3ExBVL0yc18bkVafHc56VVQ6g2AbZ3VpZHHGIamd0dKM3d4UlmTu5HTH3Rj8Rv\n XF9LULyTJd5/Mx+ENwSL46AZ3/Jki3m6ZhEXFnhqgRWBaXkTwgFqsAk4Q6wkRuLY5zYeqCtgkuS\n so89kMBn6sUUwl1e9JA==","X-Proofpoint-GUID":"mZCvZCkZwL83uIJV4m2ulwgK3P-_qNAp","X-Proofpoint-ORIG-GUID":"mZCvZCkZwL83uIJV4m2ulwgK3P-_qNAp","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-26_03,2026-03-26_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 lowpriorityscore=0 suspectscore=0 bulkscore=0\n impostorscore=0 spamscore=0 clxscore=1015 adultscore=0 phishscore=0\n malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2603260164","Received-SPF":"pass client-ip=205.220.180.131;\n envelope-from=jithu.joseph@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3670119,"web_url":"http://patchwork.ozlabs.org/comment/3670119/","msgid":"<5a9a3f1f-6811-4f1c-954a-f5aeff64fb8f@kaod.org>","list_archive_url":null,"date":"2026-03-27T07:34:48","subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 3/26/26 23:57, Jithu Joseph wrote:\n> On 3/25/2026 3:54 AM, Cédric Le Goater wrote:\n>> +Jithu\n>>\n> \n> Thanks for looping me in Cédric. Will be mindful of these next-time\n\nMigration support of the Aspeed machines used to work. Maintaining\ncompatibility with older QEMU versions is best effort since it is\nnot a critical feature. But, who knows, may be, we will virtualise\nthe BMCs one day.\n\nThanks,\n\nC.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kaod.org header.i=@kaod.org header.a=rsa-sha256\n header.s=ovhmo393970-selector1 header.b=Uw0mH41Y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","garm.ovh; auth=pass\n (GARM-107S0016f9a3581-68b5-4bb5-a196-ab15fb86ad8c,\n 4AD7B9C179601A6B587B1B6029592EA05C058FDA) smtp.auth=clg@kaod.org"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhsr84Qzfz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 18:35:36 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w61ii-0006xm-Bk; Fri, 27 Mar 2026 03:35:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <clg@kaod.org>) id 1w61ig-0006xM-3N\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 03:35:02 -0400","from smtpout8.mo534.mail-out.ovh.net ([54.36.140.179])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <clg@kaod.org>) id 1w61id-0005wy-DB\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 03:35:01 -0400","from director3.derp.mail-out.ovh.net\n (director3.derp.mail-out.ovh.net [152.228.215.222])\n by mo534.mail-out.ovh.net (Postfix) with ESMTPS id 4fhsqJ2Vknz68mn;\n Fri, 27 Mar 2026 07:34:51 +0000 (UTC)","from director3.derp.mail-out.ovh.net\n (director3.derp.mail-out.ovh.net. [127.0.0.1])\n by director3.derp.mail-out.ovh.net (inspect_sender_mail_agent) with SMTP\n for <jamin_lin@aspeedtech.com>; Fri, 27 Mar 2026 07:34:51 +0000 (UTC)","from mta11.priv.ovhmail-u2.ea.mail.ovh.net (unknown [10.110.58.137])\n by director3.derp.mail-out.ovh.net (Postfix) with ESMTPS id\n 4fhsqH4CgRz5vZr; Fri, 27 Mar 2026 07:34:51 +0000 (UTC)","from kaod.org (unknown [10.1.6.7])\n (Authenticated sender: clg@kaod.org)\n by mta11.priv.ovhmail-u2.ea.mail.ovh.net (Postfix) with ESMTPSA id\n 51581240398F; Fri, 27 Mar 2026 07:34:50 +0000 (UTC)"],"X-OVh-ClientIp":"82.64.250.170","Message-ID":"<5a9a3f1f-6811-4f1c-954a-f5aeff64fb8f@kaod.org>","Date":"Fri, 27 Mar 2026 08:34:48 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","To":"Jithu Joseph <jithu.joseph@oss.qualcomm.com>,\n GuoHan Zhao <zhaoguohan@kylinos.cn>, Peter Maydell <peter.maydell@linaro.org>","Cc":"Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Jamin Lin <jamin_lin@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n qemu-arm@nongnu.org, qemu-devel@nongnu.org","References":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>\n <cbc2f8e2-82d6-426e-b269-4921fa95b219@kaod.org>\n <fd4b0bdd-fb93-48c6-b0f4-228a7abfc8da@oss.qualcomm.com>","Content-Language":"en-US, fr","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>","Autocrypt":"addr=clg@kaod.org; keydata=\n xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo\n 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t\n yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj\n 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0\n ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV\n RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+\n gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia\n 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS\n Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS\n tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl\n IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL\n BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd\n M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m\n 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/\n jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl\n TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj\n neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ\n VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ\n QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J\n ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w\n WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O\n wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL\n SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU\n cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+\n S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc\n 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6\n hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d\n tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/\n t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c\n OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475\n KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8\n o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX\n ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0\n IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta\n d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it\n +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n\n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS\n l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY\n 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls\n ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt\n KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4=","In-Reply-To":"<fd4b0bdd-fb93-48c6-b0f4-228a7abfc8da@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","x-ovh-tracer-id":"3682537121528458262","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"\n dmFkZTFs/yR9kAvj3BylXnODJd9SC5OheT1nKO+nA4OZKiMaj5WoScYi8wzwsWu8JiLgNxvQqg9yk7d0WZurqdPmIV11XPfHgqFDs6kHU/06EiuvgNGnSJtaKPVNNfdujFcukBr34dMBZFYZPg+gv/WHTytMXT5sAVrIRjTurJTt+XH0e02xv2Ix9X7hWdi+yBscEDYmTDNIwq7fShJrKZJ+p6Pcy+sG940wHWUuaQh+HlsamdtTzb8XBuwP/4lEo3IO1bgLGsGpwAFD3w9I9ajvHub4DfgT7Jzf/wZ7jRiUyDYXsQmKHF9f4Q2Md8tuzsnxlTp7c6KNRBp0OOinSV0HpKVzRRhw6+vFgwPbb9Nmvdtqc0I0G/CX+ouU5FJuBfA2/UZbdtfEw2fiPsMamDppXsTRMUznQPnmF3Fo65iDvo2I3tRHnkpcHcD28qoNTD7baxcPFtATymtvyKlpSfMXCPwimcDxenxR/s/S4dPuMKKqcy3Lq3T/v5/SKQNF5Kx1AqhPgEzMFEmgysTBDBlNVLyhOF813Y60gccBCNQTllIA4fIkcBU/Q2eh2SEFOiECCSMS3oTRFZfjaV2TLu3vxTS9oobLlyF5wuTo5NObU0GUKKwmEFnOXzkF4FfHEYSAaeYLSO8Fi2AC+twMN+McRTffc7Qu/5HBXCPnxBGPAWN2jA","DKIM-Signature":"a=rsa-sha256; bh=7kL4UjaNloK5PRXwxVDs5zIlIRJI02LKMlm/H/CV1Jc=;\n c=relaxed/relaxed; d=kaod.org; h=From; s=ovhmo393970-selector1;\n t=1774596894; v=1;\n b=Uw0mH41YK42QqrvNrSFOHY/lIMBvwqDqhbDNBxQjEUF4I6nUv97y819TPLMlWVnY6CzH2SAm\n D5FSoRVpzijWuEfOE1nZ31eNiZwc5Ds7ZCwueBBOK/fnXYeJ3ushaGigE9rG0SAj7wlwTk/Yrfd\n pKUFPmVEVhQrbv4EYicCyA4I4zRSOeKgwBZCLtuTVuap90b68n/vtgYW8gKrHhOqm/MIkm6SMUh\n DVTbieXNwGF2oQBImx3IKJhvro6viTuMx1Hq7kU4MUGrIKWTf3Fd/VWIefERCXq7PBUDEYd+k2N\n zxSGi5U/O63ZmlqVL+ZBE857CPGMPIT5eRL7d9mFQL8GQ==","Received-SPF":"pass client-ip=54.36.140.179; envelope-from=clg@kaod.org;\n helo=smtpout8.mo534.mail-out.ovh.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3670851,"web_url":"http://patchwork.ozlabs.org/comment/3670851/","msgid":"<5483de6e-6bc9-4267-8371-15fc3f748ee6@kaod.org>","list_archive_url":null,"date":"2026-03-30T05:41:55","subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 3/25/26 09:54, GuoHan Zhao wrote:\n> Commit 7e82393ed058 (\"hw/i2c/aspeed: fix lost interrupts on\n> back-to-back commands\") introduced pending_intr_sts to preserve\n> interrupt bits that collide with already pending status bits.\n> \n> That deferred interrupt state is consumed later when the guest clears\n> INTR_STS, but it is not reset in aspeed_i2c_bus_reset() and it is not\n> part of the bus migration state. A reset can therefore leave stale\n> deferred bits behind, and migration can silently drop them.\n> \n> Clear pending_intr_sts on reset and include it in VMState while keeping\n> compatibility with older migration streams.\n> \n> Fixes: 7e82393ed058 (\"hw/i2c/aspeed: fix lost interrupts on back-to-back commands\")\n> Signed-off-by: GuoHan Zhao <zhaoguohan@kylinos.cn>\n> ---\n>   hw/i2c/aspeed_i2c.c | 4 +++-\n>   1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c\n> index 5d18f8d49ea4..90f83a03fd4f 100644\n> --- a/hw/i2c/aspeed_i2c.c\n> +++ b/hw/i2c/aspeed_i2c.c\n> @@ -1134,10 +1134,11 @@ static const MemoryRegionOps aspeed_i2c_bus_pool_ops = {\n>   \n>   static const VMStateDescription aspeed_i2c_bus_vmstate = {\n>       .name = TYPE_ASPEED_I2C,\n> -    .version_id = 6,\n> +    .version_id = 7,\n>       .minimum_version_id = 6,\n>       .fields = (const VMStateField[]) {\n>           VMSTATE_UINT32_ARRAY(regs, AspeedI2CBus, ASPEED_I2C_NEW_NUM_REG),\n> +        VMSTATE_UINT32_V(pending_intr_sts, AspeedI2CBus, 7),\n>           VMSTATE_UINT8_ARRAY(pool, AspeedI2CBus, ASPEED_I2C_BUS_POOL_SIZE),\n>           VMSTATE_UINT64(dma_dram_offset, AspeedI2CBus),\n>           VMSTATE_END_OF_LIST()\n> @@ -1510,6 +1511,7 @@ static void aspeed_i2c_bus_reset(DeviceState *dev)\n>       AspeedI2CBus *s = ASPEED_I2C_BUS(dev);\n>   \n>       memset(s->regs, 0, sizeof(s->regs));\n> +    s->pending_intr_sts = 0;\n>       i2c_end_transfer(s->bus);\n>   }\n>   \n\nApplied to aspeed-next.\n\nThanks,\n\nC.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kaod.org header.i=@kaod.org header.a=rsa-sha256\n header.s=ovhmo393970-selector1 header.b=I5DOddVY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","garm.ovh; auth=pass\n (GARM-97G00230b7952a-f3f7-4917-8935-328f9af28683,\n 7D556D2DDFF67F75045F04EBDED03CA4E39E484C) smtp.auth=clg@kaod.org"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkgBd1kGxz1yGH\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 16:42:47 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1w75O5-0006EC-HY; Mon, 30 Mar 2026 01:42:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <clg@kaod.org>) id 1w75O1-0006Ds-VB\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 01:42:07 -0400","from smtpout1.mo533.mail-out.ovh.net ([51.210.94.138])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <clg@kaod.org>) id 1w75Nx-0000St-SX\n for qemu-devel@nongnu.org; Mon, 30 Mar 2026 01:42:05 -0400","from director3.derp.mail-out.ovh.net\n (director3.derp.mail-out.ovh.net [152.228.215.222])\n by mo533.mail-out.ovh.net (Postfix) with ESMTPS id 4fkg9d68vRz5w1w;\n Mon, 30 Mar 2026 05:41:57 +0000 (UTC)","from director3.derp.mail-out.ovh.net\n (director3.derp.mail-out.ovh.net. [127.0.0.1])\n by director3.derp.mail-out.ovh.net (inspect_sender_mail_agent) with SMTP\n for <jamin_lin@aspeedtech.com>; Mon, 30 Mar 2026 05:41:57 +0000 (UTC)","from mta2.priv.ovhmail-u2.ea.mail.ovh.net (unknown [10.110.188.121])\n by director3.derp.mail-out.ovh.net (Postfix) with ESMTPS id\n 4fkg9d17JCz5vcx; Mon, 30 Mar 2026 05:41:57 +0000 (UTC)","from kaod.org (unknown [10.1.6.1])\n (Authenticated sender: clg@kaod.org)\n by mta2.priv.ovhmail-u2.ea.mail.ovh.net (Postfix) with ESMTPSA id\n 0CF65941574;\n Mon, 30 Mar 2026 05:41:56 +0000 (UTC)"],"X-OVh-ClientIp":"82.64.250.170","Message-ID":"<5483de6e-6bc9-4267-8371-15fc3f748ee6@kaod.org>","Date":"Mon, 30 Mar 2026 07:41:55 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw/i2c/aspeed_i2c: reset and migrate pending_intr_sts","To":"GuoHan Zhao <zhaoguohan@kylinos.cn>,\n Peter Maydell <peter.maydell@linaro.org>","Cc":"Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Jamin Lin <jamin_lin@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n qemu-arm@nongnu.org, qemu-devel@nongnu.org","References":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>","Content-Language":"en-US, fr","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>","Autocrypt":"addr=clg@kaod.org; keydata=\n xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo\n 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t\n yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj\n 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0\n ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV\n RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+\n gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia\n 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS\n Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS\n tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSBDw6lkcmljIExl\n IEdvYXRlciA8Y2xnQGthb2Qub3JnPsLBeAQTAQIAIgUCW7yjdQIbAwYLCQgHAwIGFQgCCQoL\n BBYCAwECHgECF4AACgkQUaNDx8/77KGRSxAAuMJJMhJdj7acTcFtwof7CDSfoVX0owE2FJdd\n M43hNeTwPWlV5oLCj1BOQo0MVilIpSd9Qu5wqRD8KnN2Bv/rllKPqK2+i8CXymi9hsuzF56m\n 76wiPwbsX54jhv/VYY9Al7NBknh6iLYJiC/pgacRCHtSj/wofemSCM48s61s1OleSPSSvJE/\n jYRa0jMXP98N5IEn8rEbkPua/yrm9ynHqi4dKEBCq/F7WDQ+FfUaFQb4ey47A/aSHstzpgsl\n TSDTJDD+Ms8y9x2X5EPKXnI3GRLaCKXVNNtrvbUd9LsKymK3WSbADaX7i0gvMFq7j51P/8yj\n neaUSKSkktHauJAtBNXHMghWm/xJXIVAW8xX5aEiSK7DNp5AM478rDXn9NZFUdLTAScVf7LZ\n VzMFKR0jAVG786b/O5vbxklsww+YXJGvCUvHuysEsz5EEzThTJ6AC5JM2iBn9/63PKiS3ptJ\n QAqzasT6KkZ9fKLdK3qtc6yPaSm22C5ROM3GS+yLy6iWBkJ/nEYh/L/du+TLw7YNbKejBr/J\n ml+V3qZLfuhDjW0GbeJVPzsENuxiNiBbyzlSnAvKlzda/sBDvxmvWhC+nMRQCf47mFr8Xx3w\n WtDSQavnz3zTa0XuEucpwfBuVdk4RlPzNPri6p2KTBhPEvRBdC9wNOdRBtsP9rAPjd52d73O\n wU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhWpOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNL\n SoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZKXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVU\n cP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwpbV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+\n S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc\n 9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFUCSLB2AE4wXQkJbApye48qnZ09zc929df5gU6\n hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iSYBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616d\n tb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6gLxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/\n t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1c\n OY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0SdujWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475\n KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/JxIqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8\n o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoX\n ywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjKyKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0\n IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9jhQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Ta\n d2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yops302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it\n +OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/pLHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1n\n HzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBUwYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVIS\n l73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lUXOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY\n 3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfAHQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4Pls\n ZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQizDiU6iOrUzBThaMhZO3i927SG2DwWDVzZlt\n KrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gDuVKe8BVz4atMOoktmt0GWTOC8P4=","In-Reply-To":"<20260325085450.126595-1-zhaoguohan@kylinos.cn>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","x-ovh-tracer-id":"947163299149229067","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"\n dmFkZTGLFD9Zh5VsOcL9uqYoQ4sZ750kGI1mZJbQY/UR6SUQfcAV93EzPxzb9paIP6+C1lHhNuwGuttx04zrsQWo012a4PuPa5yFuDkT+2J0fKg1ekWq9W7mmdFV+q9vqYSdAH2KKfnIBJq4Okl+h0RhNpVhujnFGRfSWEFDbvQnIKID/ZVLMizg9Ylwm0QfWGkjBLJsX4bG+SEy2axo/Qy6pb+y68Z/A0uGRXFDKCiabNfB90V9QvFW7kkUvPjy5nHUqJrGQYNXnfscqfpQrzZsc6Msw9787XfG9ETd8LDbZnOD7oL/G+WXqDFeop0rnP+L8Q3C5m5nj50NyWF97OFMPU6hgTTajXuMXzrJS0Ce+IqYhBpc2+OX5F3P7kvUi8xZkc6fGITV1GyVDF2r1buEfwHR97pWM0xVbKrUdtSRZRxb4yAqZr7e0yVMcp83jju+L3Sx4B67uEbztbmSqc1vO4XYQ0++dfq/+7LoYiHCcVMjQG4Ezo11+us4WYN7XNXYx4c50UxivG93/uLkq2+akGjlq9nHdB7CNrxPwoyA1Z949PeRkng6PG1cAlaseB9sGSphYbB+4EonvmOQliOxRV+TVdcbJcaz+pQGg+MeDrVv3JQEaRw9De8Tag+4lpTUS4YP+aWexIHaCOutFslXClx0k/dhpmi8z4lOzouBtxyWzA","DKIM-Signature":"a=rsa-sha256; bh=s4IHBSo4pLjvZNu50zRkqteOFW6eot0lc4BEU48dW1o=;\n c=relaxed/relaxed; d=kaod.org; h=From; s=ovhmo393970-selector1;\n t=1774849319; v=1;\n b=I5DOddVYlj1mOEp+9I8Ad1M1kmUMx+op+U4NygZjAav67QSVgNf97OmtYTaPNBdnrh0c7Fsi\n oWqx2by2cZRFAYWzo51rx2QhYb4wEPpxH/C2i2MPOIJp2D7r4WnlA4nCs1f9AoZDqjWKyviea2f\n f9dEN6UvgtMO0ymdtq1Twto33UZGKHHppZaMXVX1mDteX1Q8wamku80i12aYiYtNK9lewTnG0kX\n P8BrNMMAPnyLNe21nJVFyv57zdWuivRxRHaSKq/3HZa65mfKf/RgPwB653d1gC68L/Vda5m0BAR\n g27SJf63Es37XyndnTWkbC01tUoIzrPu2XyDTjlxFLkZw==","Received-SPF":"pass client-ip=51.210.94.138; envelope-from=clg@kaod.org;\n helo=smtpout1.mo533.mail-out.ovh.net","X-Spam_score_int":"0","X-Spam_score":"-0.1","X-Spam_bar":"/","X-Spam_report":"(-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\n RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=1, RCVD_IN_VALIDITY_RPBL_BLOCKED=1,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]