[{"id":3669531,"web_url":"http://patchwork.ozlabs.org/comment/3669531/","msgid":"<20260326-marvellous-premium-grouse-d1d1ad@quoll>","list_archive_url":null,"date":"2026-03-26T08:25:05","subject":"Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: add IPQ5210 pinctrl","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Wed, Mar 25, 2026 at 01:05:15PM +0530, Kathiravan Thirumoorthy wrote:\n> Add device tree bindings for IPQ5210 TLMM block.\n> \n> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>\n\nI don't see any differences here and cover letter does not explain that.\n\n<form letter>\nThis is a friendly reminder during the review process.\n\nIt looks like you received a tag and forgot to add it.\n\nIf you do not know the process, here is a short explanation:\nPlease add Acked-by/Reviewed-by/Tested-by tags when posting new\nversions of patchset, under or above your Signed-off-by tag, unless\npatch changed significantly (e.g. new properties added to the DT\nbindings). Tag is \"received\", when provided in a message replied to you\non the mailing list. Tools like b4 can help here. However, there's no\nneed to repost patches *only* to add the tags. The upstream maintainer\nwill do that for tags received on the version they apply.\n\nPlease read:\nhttps://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577\n\nIf a tag was not added on purpose, please state in the patch changelog\nor cover letter why and what changed.\n</form letter>\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n <linux-gpio+bounces-34189-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Ppjz8b3O;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34189-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"Ppjz8b3O\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhHC111Pyz1yGD\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 19:34:53 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D70A531606AD\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 08:25:33 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A64ED3B8BA8;\n\tThu, 26 Mar 2026 08:25:09 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D233C3B7B76;\n\tThu, 26 Mar 2026 08:25:08 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EA5C6C19423;\n\tThu, 26 Mar 2026 08:25:07 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774513508; cv=none;\n b=YOzMovPhB/w1EMUFonH6hyLVD+YUB6tnxpiwSke3Al3rwLiflQJiF790JwQdCf8/g6Stp+RnV8lmwPKynHjyNADEQ4gYdqkKCiIGcAgIjxWTA3pEAhQBt4yVZBo2VtfL9FxJXHBX/RhZ24W2L30jUEYMzY+RVUzmg0M+FPwf8xE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774513508; c=relaxed/simple;\n\tbh=DtkcM00qstt9ezFR2/CqK/oJyo6OuKnFPtu2O07XpqY=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=W/zje0TWRb2YMsnyiO9b8EzAOEX49oAcgY5e7HF1xQngxeBi3jldnDsw/AFe1wrdU3Opy76KZYBjtBdu9xLy9NmqRV2CxAi0jJ2d61Ftjebh7tCv6RY/aCxZ3RFk8oayGhgGwZKccRhYo7TwB1qfKC27oWuY4vSToosPHhZ4cWc=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=Ppjz8b3O; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774513508;\n\tbh=DtkcM00qstt9ezFR2/CqK/oJyo6OuKnFPtu2O07XpqY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ppjz8b3O39w7dT29hoR3sKCmgkIf+DqOlifxQMqapBhNE28naqdxi/3+DnIhOk4d8\n\t 5DZzvwonEiLvkSxieACdn0c2xcxziCT2Jtf2Qv0QQFWU5ma5CA2MelUdSFDtETAu4A\n\t W1Jy+c2g6UaqoG5+BhBlLk+K1/6GdVlXLt8JhzfJT9MKc/p8eVcBJnaKE/t/NbmZsS\n\t hl2sj0XzGFnorRruh5aKuVjn2gwY3QdmxmK6hmCNfUgE2TvRt4WGAQ/hfAmQL6zbue\n\t tzU4yBFNrR4ah5vscigRvs6A47aj840CE0S+q4hMaVrEHKArnMkDSgXzjuv1ZlspO6\n\t JNgfWPBIcA64w==","Date":"Thu, 26 Mar 2026 09:25:05 +0100","From":"Krzysztof Kozlowski <krzk@kernel.org>","To":"Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>","Cc":"Bjorn Andersson <andersson@kernel.org>,\n\tLinus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,\n\tKrzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,\n\tlinux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,\n devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: add IPQ5210 pinctrl","Message-ID":"<20260326-marvellous-premium-grouse-d1d1ad@quoll>","References":"<20260325-ipq5210_tlmm-v3-0-3a4b9bb6b1fc@oss.qualcomm.com>\n <20260325-ipq5210_tlmm-v3-1-3a4b9bb6b1fc@oss.qualcomm.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260325-ipq5210_tlmm-v3-1-3a4b9bb6b1fc@oss.qualcomm.com>"}},{"id":3670847,"web_url":"http://patchwork.ozlabs.org/comment/3670847/","msgid":"<095ba19f-90c9-4410-9b65-607d29413bb1@oss.qualcomm.com>","list_archive_url":null,"date":"2026-03-30T04:56:09","subject":"Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: add IPQ5210 pinctrl","submitter":{"id":90386,"url":"http://patchwork.ozlabs.org/api/people/90386/","name":"Kathiravan Thirumoorthy","email":"kathiravan.thirumoorthy@oss.qualcomm.com"},"content":"On 3/26/2026 1:55 PM, Krzysztof Kozlowski wrote:\n> On Wed, Mar 25, 2026 at 01:05:15PM +0530, Kathiravan Thirumoorthy wrote:\n>> Add device tree bindings for IPQ5210 TLMM block.\n>>\n>> Signed-off-by: Kathiravan Thirumoorthy<kathiravan.thirumoorthy@oss.qualcomm.com>\n> I don't see any differences here and cover letter does not explain that.\n\nPin control function names are made generic for some of the functions, \nso I thought I should drop it and mentioned it in the cover letter as below.\n\nChanges in v3:\n- Grouped the QUP SE pins instead of mentioning by function wise\n- Splitted the PWM functions which I messed up in V2\n- Audio primary and secondary mclk function names are expanded to avoid the\n   confusion\n- Dropped the R-b tags due to the above changes\n\nBased on your comment, I understand that since there is no schematic \nchanges to the binding, there is no need to drop the tag. So I have \npicked up the tags in V4.\n\nThanks,\n\nKathiravan T.","headers":{"Return-Path":"\n <linux-gpio+bounces-34379-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=inO+f772;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=NzK767XX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34379-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"inO+f772\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"NzK767XX\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkf931g9Sz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 15:56:23 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id BB77C300851E\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 04:56:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 01D293803F0;\n\tMon, 30 Mar 2026 04:56:19 +0000 (UTC)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B67C623D7CF\n\tfor <linux-gpio@vger.kernel.org>; Mon, 30 Mar 2026 04:56:16 +0000 (UTC)","from pps.filterd (m0279867.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 62U40RB63931741\n\tfor <linux-gpio@vger.kernel.org>; Mon, 30 Mar 2026 04:56:16 GMT","from mail-pj1-f71.google.com (mail-pj1-f71.google.com\n [209.85.216.71])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d64pdcsap-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <linux-gpio@vger.kernel.org>; Mon, 30 Mar 2026 04:56:16 +0000 (GMT)","by mail-pj1-f71.google.com with SMTP id\n 98e67ed59e1d1-3594620fe97so14345490a91.1\n        for <linux-gpio@vger.kernel.org>;\n Sun, 29 Mar 2026 21:56:16 -0700 (PDT)","from [10.151.37.217] ([202.46.23.19])\n        by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35d9507dc3bsm5755629a91.9.2026.03.29.21.56.11\n        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n        Sun, 29 Mar 2026 21:56:14 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774846578; cv=none;\n b=Of1F9S2fmdl/Q2bt3Rv3CTfOhlzXpjId01qwaiOurv3H4X4UUWKEQQttMsWZrCCMhnLm9ok41GvCdMGs3z7p2tMvD8YGr7T8xfx1C8JEEZlDnroBj0cAKEsoVfThvN+DnpNdGg2E3Dbfbeq/jTxxnJNo37hWNsYsILKce7aL3Cc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774846578; c=relaxed/simple;\n\tbh=xt4nL01wX2KqbENJVRpe6EAYvo9duFVqMqTp61xxKmg=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=jiDtUJXr3no9WYATJydpLD/SMsTF6o4XIBDjf9wbJrxlVvYJIRLNRN94Q2JgpjgYFNNZ7YVXbRr+qliiJWXM7YPEPTCMIN5WeuY4pmI0dFK8IK4u+EPRWXAZZdQvlkquur2Vtg58+Sg6/dU4ewDCSaXtm6WvMh2xfLdXJKixc8Q=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=inO+f772;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=NzK767XX; arc=none smtp.client-ip=205.220.168.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tH9t3pLpkMMGLYxzJ3ezf64g/HI5nzm3mmWJG7tU2bnc=; b=inO+f7722dcimJsd\n\twbC+BXnBzjfufYRq+3NGwh2+tckSBOQM7q3UlUMKR315VmequwC+Y9T34pu+HFyj\n\tdH4XxYO0046yCRmgQyPv9Cbdk1WsFz1wR64TwVI3oFZeho2+F0uY+3rrSvmV8/hP\n\tc74PBp/5QU/lf1+Q4K5qW++p2hqusq7WMi++2k+PlCWhw/4jcQUe9OWhz66cxgEr\n\tF6F2JDmq/Kx7s/ZrpzV9ScRyeuzffKeWoYB9RzJOTKi18chDiaQPPiuqAn5V6TqL\n\t6JbX574PfLBk061KDQzRrMzI4zArTuSb7lbhzMYyh/deeoZSKB3YkukMeGG/G9oD\n\t4Z+0wQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=oss.qualcomm.com; s=google; t=1774846575; x=1775451375;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:in-reply-to:from:content-language\n         :references:cc:to:subject:user-agent:mime-version:date:message-id\n         :from:to:cc:subject:date:message-id:reply-to;\n        bh=H9t3pLpkMMGLYxzJ3ezf64g/HI5nzm3mmWJG7tU2bnc=;\n        b=NzK767XXpaj34lUgfFP1ZfXQQE76XRuAjNUF/AoxtkayHHwfSzIabNdinqXEidHVVn\n         kA+TW7lcCUVPplhSrS9mPJvNrOwUGExofjIGn3ILsxMIJTMVffHuHOMTch3Is4xfj2pL\n         SX0UnhodjQe9bbyUO1Tx1gqVeSQw4Cy11rP6aLc1wIGzWjxibD313LG9oz4Hp5B2djW5\n         iPccqKlFuTuU3/8KYeCTul88aI5bVP5raX+vstKg+VeBXVL6cqYOEHYEExdE3aJMGa9x\n         1rcPB/bn5aAsq0Ifu18yt647+OxzFgowaDwm0UiMOwJFovMF2ZJg+qGKLUYckquINFSR\n         ujPQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1774846575; x=1775451375;\n        h=content-transfer-encoding:in-reply-to:from:content-language\n         :references:cc:to:subject:user-agent:mime-version:date:message-id\n         :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n         :reply-to;\n        bh=H9t3pLpkMMGLYxzJ3ezf64g/HI5nzm3mmWJG7tU2bnc=;\n        b=ooudj7E71RYV8FMWqf8PVI8+5t70/RRQbK+SDEzIG4Tm2RFzqCNVDumlRWzdmktw43\n         ehXUWy5L6JOYbBdOhY7EqHeMyx66khD4qKG2Xc9NUAKD5W2rVN1/TmBEaEvbXVzeXxtC\n         dxNzovdqDGxN826s3nlAu4r+YPX6tSDRTIeEKMhF4RuJJ6Sq5Se0M8UU6z5JwfMachLv\n         o2yuA+/xEy46kZogOIsuIDeQsJxYjJhA4aeEhwMSHbqDOmdjzWh/E9iMY4eB2dA1Idln\n         w7XUmdmOPFtvl8LaRLvCrs4q2eXxJtJ6OyXDTKSrmuDY/e656hIZVfYCIEFYQGCov7YG\n         p4Dg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXPgrUZ+FJel+dC2Q+V0wDmt4sKdQUgfJNlzgbiY3oa9FH5blsk1SuZdI5th9zmjszArAM1vwID01+j@vger.kernel.org","X-Gm-Message-State":"AOJu0Yw17KBhX3DsJU92YrS8VqdZ1FqqIEmDds2gwMSkqZXo7uLlh5Y7\n\tOwGaM5DKyL2PTIz9JikyKaU9sTNNIfW6SY1SUZXI+qRKvm9CpQVwO8xPekCJzIdhcL8uMFo6krg\n\teJh6O2xB+eIlHnk53xb19zywPgDYb/BaxoP8k4nUMJfGxc5RXWwp5pDnASVO0Rpoq","X-Gm-Gg":"ATEYQzwJ7/qGsqCllC7Lj99v6sERCUWt+y1PZu0Ls+gV/iDkol+WntXRJTESkX8IKtD\n\tHgut/55D254HSr62CH5v08A6tCayzXTt3894dUfAoASXRJQqZhmMgZkvGfAU6+pyoJ9BHq3CmJz\n\t2InvmR57rtPq+jyRVEki/ogTrMT/LekSmqtR2lh7CyoKQ9mBYr7a6ZjZG2p4kIEeUGVBtaZQG9a\n\t6PgllBuZC02wdFKEuJ3bxooV+pv6UnKlgacOcp2msXFohkWKigWNe9UYYagd4VuAT/HSKSVIUtN\n\tCMLXdRf9JyfZq6XYd2ruQMLr8t9LwciUPdexBqpbdozq/eWZu4T116Ubv8TFTmvy8agcDXFpZ66\n\tEYr4b1ZqQ8wz58JlZ7nKE4d9c1U9GmaL2aUbkusrc6+Oi6xc41O3OTeWDKWO52TjtaA==","X-Received":["by 2002:a17:90b:558d:b0:35a:329:73d8 with SMTP id\n 98e67ed59e1d1-35c2ffb03bcmr10608119a91.4.1774846575410;\n        Sun, 29 Mar 2026 21:56:15 -0700 (PDT)","by 2002:a17:90b:558d:b0:35a:329:73d8 with SMTP id\n 98e67ed59e1d1-35c2ffb03bcmr10608102a91.4.1774846574965;\n        Sun, 29 Mar 2026 21:56:14 -0700 (PDT)"],"Message-ID":"<095ba19f-90c9-4410-9b65-607d29413bb1@oss.qualcomm.com>","Date":"Mon, 30 Mar 2026 10:26:09 +0530","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: add IPQ5210 pinctrl","To":"Krzysztof Kozlowski <krzk@kernel.org>","Cc":"Bjorn Andersson <andersson@kernel.org>, Linus Walleij\n <linusw@kernel.org>,\n        Rob Herring <robh@kernel.org>,\n        Krzysztof Kozlowski <krzk+dt@kernel.org>,\n        Conor Dooley\n <conor+dt@kernel.org>, linux-arm-msm@vger.kernel.org,\n        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n        linux-kernel@vger.kernel.org","References":"<20260325-ipq5210_tlmm-v3-0-3a4b9bb6b1fc@oss.qualcomm.com>\n <20260325-ipq5210_tlmm-v3-1-3a4b9bb6b1fc@oss.qualcomm.com>\n <20260326-marvellous-premium-grouse-d1d1ad@quoll>","Content-Language":"en-US","From":"Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>","In-Reply-To":"<20260326-marvellous-premium-grouse-d1d1ad@quoll>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Proofpoint-ORIG-GUID":"Y_GmHWHv0FqARQkwr8dML8Dhg2Li-gwe","X-Authority-Analysis":"v=2.4 cv=UZpciaSN c=1 sm=1 tr=0 ts=69ca0270 cx=c_pps\n a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17\n a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22\n a=EUspDBNiAAAA:8 a=sbCXkxCAo7F0d2wfUiUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=zZCYzV9kfG8A:10 a=uKXjsCUrEbL0IQVhDsJ9:22","X-Proofpoint-GUID":"Y_GmHWHv0FqARQkwr8dML8Dhg2Li-gwe","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwMzMwMDAzNSBTYWx0ZWRfX8ys1141SnO5M\n ftVq/LLBqD3HUnIxpQyp79HhUecUQdisCs2wlkqdWcnpFkupHiolzXlngrUyZ9a8QGWZc/XuiTp\n 6PKVrYvUmCWObeTx01krBgbZO9+iLhROqwV8yqj5yicZtu9KWCpqVO9Int4hjz2YihzxDR03lr7\n UcRmKqYj9MJOV18MG+yfwoudk6A8GOv7LhUmya6Ov6XzwCUYpj2383WwAwQX2GgKCVY48BxZqrW\n 5b/ywDkw85DPpZ/lHSPLCJGPsQhypWT5EK6SoA1DIXCNkfyAhLwsL22B7OoNiqpvTUn7f4U4DP7\n v1eURieRTT0Lg655q/DghDEZrgU89jAkCsQVcSAWVjwXIt6Y6/kNuo+0QjgZbdsgkGrd4cOGFDE\n yKgrQrX78/B54sal26t2SZdRQP+aZ8Py138eeJ2YLA7IT85DimshXeoXvVRWyQ5LUMBOA8UfE2X\n MzXVb1gHMHiL/W/9zgg==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n phishscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 priorityscore=1501\n adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 clxscore=1015\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300035"}},{"id":3670872,"web_url":"http://patchwork.ozlabs.org/comment/3670872/","msgid":"<85415166-4d3e-4905-8122-de8ae66b8da1@kernel.org>","list_archive_url":null,"date":"2026-03-30T06:38:18","subject":"Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: add IPQ5210 pinctrl","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On 30/03/2026 06:56, Kathiravan Thirumoorthy wrote:\n> \n> On 3/26/2026 1:55 PM, Krzysztof Kozlowski wrote:\n>> On Wed, Mar 25, 2026 at 01:05:15PM +0530, Kathiravan Thirumoorthy wrote:\n>>> Add device tree bindings for IPQ5210 TLMM block.\n>>>\n>>> Signed-off-by: Kathiravan Thirumoorthy<kathiravan.thirumoorthy@oss.qualcomm.com>\n>> I don't see any differences here and cover letter does not explain that.\n> \n> Pin control function names are made generic for some of the functions, \n> so I thought I should drop it and mentioned it in the cover letter as below.\n> \n> Changes in v3:\n> - Grouped the QUP SE pins instead of mentioning by function wise\n> - Splitted the PWM functions which I messed up in V2\n> - Audio primary and secondary mclk function names are expanded to avoid the\n>    confusion\n> - Dropped the R-b tags due to the above changes\n> \n> Based on your comment, I understand that since there is no schematic \n> changes to the binding, there is no need to drop the tag. So I have \n> picked up the tags in V4.\n\nSo you dropped the tags because something changed in the \"function\"\nproperty? Why would that matter for review?\n\nI am not looking at this again.\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n <linux-gpio+bounces-34381-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=LP9rn1D/;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34381-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"LP9rn1D/\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fkhXn6ZpZz1xrn\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 17:43:37 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C7302300D167\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 30 Mar 2026 06:38:25 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A3D7D394496;\n\tMon, 30 Mar 2026 06:38:23 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 441E6394477;\n\tMon, 30 Mar 2026 06:38:22 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 84DBCC4CEF7;\n\tMon, 30 Mar 2026 06:38:20 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774852703; cv=none;\n b=hGIkghdEOJNrcAszZOBSw9V9AZWgmRk4066TIuj+h/sGjDB9W1jG8RMRMhBsivVMdFYRbPfu8DhBUfl+/I/Bac8Wczp++PQ8S7ZYcHofoxePi85/WiX8TWc3cMGN+OjfQmhwJi+sdI2kzLnCuGi7eIvSS07+ntFfLCSXTCR/u1U=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774852703; c=relaxed/simple;\n\tbh=9wwEgOO947YoL6NmDNh8zySgqO8VzbsFyNHuMG5Rc/A=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=iMbFcnIvXIhwlFBQ3nWC9UqvNjPAOIvGoN/b3jDWKZvsLcCuDSxGTHOwoFl1+KDEUwmhpjtMOZoaunt1Dvb2rP5+k4e+8Z2asdZCh/r+TaI40b5Whqh/5pw+mFzcoOzHOODDTRm+nvsgwfnmRs+14Ehtom5u/9lhoyIp2+ENMQM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=LP9rn1D/; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774852702;\n\tbh=9wwEgOO947YoL6NmDNh8zySgqO8VzbsFyNHuMG5Rc/A=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=LP9rn1D/lhx/7/4NKnxiFFzJ+t9VxqWFdEFO12Drajz6iDCXCGBwrDed+ugdaS6vg\n\t JaiDaaReraE3A6gaO2PKQADiup/1bn1h9IKYgadhUFSjXiyuF1PQFwE3sWre7jF2qx\n\t STRJ4kjyE+rOOpLiUkgw7dan2KUCuDm9i6yT7siPUnUZXdBE7V7BR4Ow8/TZ6yNkQp\n\t jaaCwR3EwERMUxyU/r/WZ9BUURrEeSXn/0OstKYA9fgzh0HGxq7d5EBE0PYVeEnorE\n\t JODN+pNUHvUjZHIzw3Sz1PTK2IXGikU6v1OiZOzCDVMcoSEWeX/ritqQaG/lCSlK+j\n\t qyeEKSIDBySVA==","Message-ID":"<85415166-4d3e-4905-8122-de8ae66b8da1@kernel.org>","Date":"Mon, 30 Mar 2026 08:38:18 +0200","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: add IPQ5210 pinctrl","To":"Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>","Cc":"Bjorn Andersson <andersson@kernel.org>, Linus Walleij\n <linusw@kernel.org>, Rob Herring <robh@kernel.org>,\n Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley\n <conor+dt@kernel.org>, linux-arm-msm@vger.kernel.org,\n linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org","References":"<20260325-ipq5210_tlmm-v3-0-3a4b9bb6b1fc@oss.qualcomm.com>\n <20260325-ipq5210_tlmm-v3-1-3a4b9bb6b1fc@oss.qualcomm.com>\n <20260326-marvellous-premium-grouse-d1d1ad@quoll>\n <095ba19f-90c9-4410-9b65-607d29413bb1@oss.qualcomm.com>","From":"Krzysztof Kozlowski <krzk@kernel.org>","Content-Language":"en-US","Autocrypt":"addr=krzk@kernel.org; keydata=\n xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79\n cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu\n JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH\n gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE\n J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj\n NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS\n BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU\n vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM\n Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD\n TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg\n S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE\n FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307\n QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp\n +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl\n ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy\n 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN\n hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi\n tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL\n 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn\n naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd\n hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k\n whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3\n Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue\n MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei\n OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA\n GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA\n 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9\n YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt\n 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU\n BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/\n JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu\n 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB\n YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v\n qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5\n RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg\n Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2\n H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB\n dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT\n AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu\n jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2\n zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw\n XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A=","In-Reply-To":"<095ba19f-90c9-4410-9b65-607d29413bb1@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"}}]