[{"id":3668862,"web_url":"http://patchwork.ozlabs.org/comment/3668862/","msgid":"","list_archive_url":null,"date":"2026-03-25T07:46:28","subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Kitszel, Przemyslaw \n> Sent: Wednesday, March 25, 2026 7:27 AM\n> To: Jiri Pirko ; netdev@vger.kernel.org; Jakub\n> Kicinski \n> Cc: Nguyen, Anthony L ; intel-wired-\n> lan@lists.osuosl.org; Loktionov, Aleksandr\n> ; edumazet@google.com;\n> horms@kernel.org; pabeni@redhat.com; davem@davemloft.net; Schmidt,\n> Michal ; Kitszel, Przemyslaw\n> \n> Subject: [PATCH net-next 1/2] devlink: unify devlink_shd_get_priv()\n> into devlink_priv()\n> \n> Unify access API to shared devlink priv data with normal devlink.\n> \n> Thanks to Jiri Pirko, we now have ability to create shared devlink\n> instances [1]. Introduction series have added usage of those for mlx,\n> but without priv data attached to the shared devlink.\n> \n> Current API makes it possible to access shared devlink instance's priv\n> data:\n> \n> \tvoid *devlink_shd_get_priv(struct devlink *devlink);\n> \n> but it is easy to forget (especially during rebase from \"before shared\n> devlinks\" era) and call:\n> \n> \tvoid *devlink_priv(struct devlink *devlink);\n> \n> which even has the same signature, so it's hard to catch the error.\n> \n> New proposed API unifies both calls into one, without any increase in\n> the observed struct size. (Alternative could be to store additional\n> pointer, set during devlink_alloc).\n> \n> Unexport the less convenient API call.\n> \n> [1] commit 411ad0605875 (\"Merge branch 'devlink-introduce-shared-\n> devlink-instance-for-pfs-on-same-chip'\")\n> [1] https://lore.kernel.org/all/20260312100407.551173-1-\n> jiri@resnulli.us\n> \n> Signed-off-by: Przemek Kitszel \n> ---\n> v1:\n> https://lore.kernel.org/netdev/20260323132136.13191-1-\n> przemyslaw.kitszel@intel.com\n> \n> v2:\n> - fix typos (Alex, Jiri)\n> - fix infinite recurrence (Alex)\n> - add __devlink_priv(), which is more general than v1's\n> devlink_to_shd()\n> (Jiri)\n> ---\n> net/devlink/devl_internal.h | 7 +++++++\n> net/devlink/core.c | 10 +++++++++-\n> net/devlink/sh_dev.c | 8 ++++----\n> 3 files changed, 20 insertions(+), 5 deletions(-)\n> \n> diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h\n> index 7dfb7cdd2d23..0a57318d92f8 100644\n> --- a/net/devlink/devl_internal.h\n> +++ b/net/devlink/devl_internal.h\n> @@ -58,6 +58,7 @@ struct devlink {\n> \tstruct mutex lock;\n> \tstruct lock_class_key lock_key;\n> \tu8 reload_failed:1;\n> +\tu8 is_shd:1;\n> \trefcount_t refcount;\n> \tstruct rcu_work rwork;\n> \tstruct devlink_rel *rel;\n> @@ -72,6 +73,12 @@ struct devlink *__devlink_alloc(const struct\n> devlink_ops *ops, size_t priv_size,\n> \t\t\t\tstruct net *net, struct device *dev,\n> \t\t\t\tconst struct device_driver *dev_driver);\n> \n> +/* Get priv allocated for struct devlink */ void\n> *__devlink_priv(struct\n> +devlink *devlink);\n> +\n> +/* Get private data from shared devlink instance */ void\n> +*devlink_shd_get_priv(struct devlink *devlink);\n> +\n> #define devl_warn(devlink, format, args...)\t\t\t\t\\\n> \tdo {\t\t\t\t\t\t\t\t\\\n> \t\tif ((devlink)->dev)\t\t\t\t\t\\\n> diff --git a/net/devlink/core.c b/net/devlink/core.c index\n> eeb6a71f5f56..a242be203fe8 100644\n> --- a/net/devlink/core.c\n> +++ b/net/devlink/core.c\n> @@ -230,10 +230,18 @@ int devlink_rel_devlink_handle_put(struct\n> sk_buff *msg, struct devlink *devlink,\n> \treturn err;\n> }\n> \n> -void *devlink_priv(struct devlink *devlink)\n> +void *__devlink_priv(struct devlink *devlink)\n> {\n> \treturn &devlink->priv;\n> }\n> +\n> +void *devlink_priv(struct devlink *devlink) {\n> +\tif (devlink->is_shd)\n> +\t\treturn devlink_shd_get_priv(devlink);\n> +\n> +\treturn __devlink_priv(devlink);\n> +}\n> EXPORT_SYMBOL_GPL(devlink_priv);\n> \n> struct devlink *priv_to_devlink(void *priv) diff --git\nI'm worried about priv_to_devlink(), if someone passes the result of devlink_priv(shared_dl) as priv,\ncontainer_of computes garbage - because the pointer came from shd->priv, NOT from &devlink->priv.\n\n\n...\n\n\n> \n> \treturn shd->priv;\n> }\n> -EXPORT_SYMBOL_GPL(devlink_shd_get_priv);\n> --\n> 2.51.1","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=R5qo0LLk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgf9z6kNzz1xy1\n\tfor ; Wed, 25 Mar 2026 18:46:47 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 3F1BC40AE7;\n\tWed, 25 Mar 2026 07:46:45 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fhohNLpTjQTH; Wed, 25 Mar 2026 07:46:44 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 6634340AF2;\n\tWed, 25 Mar 2026 07:46:44 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 917ED1D3\n for ; Wed, 25 Mar 2026 07:46:43 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 6BF5240AF2\n for ; Wed, 25 Mar 2026 07:46:43 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id YAF0xOGOWZ_d for ;\n Wed, 25 Mar 2026 07:46:42 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.10])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 6BA2840AE7\n for ; Wed, 25 Mar 2026 07:46:42 +0000 (UTC)","from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Mar 2026 00:46:32 -0700","from fmsmsx901.amr.corp.intel.com ([10.18.126.90])\n by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Mar 2026 00:46:32 -0700","from FMSMSX902.amr.corp.intel.com (10.18.126.91) by\n fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 25 Mar 2026 00:46:31 -0700","from fmsedg901.ED.cps.intel.com (10.1.192.143) by\n FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Wed, 25 Mar 2026 00:46:31 -0700","from CY3PR05CU001.outbound.protection.outlook.com (40.93.201.21) by\n edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 25 Mar 2026 00:46:31 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by MN2PR11MB4648.namprd11.prod.outlook.com (2603:10b6:208:26f::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.6; Wed, 25 Mar\n 2026 07:46:28 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9745.012; Wed, 25 Mar 2026\n 07:46:28 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6634340AF2","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6BA2840AE7"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774424804;\n\tbh=IoLVsdlTHFpXkwSjtQgOem9JtgKg707LHD9jcr9zN3I=;\n\th=From:To:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=R5qo0LLkXNcg7TosbIhHxQsXqt/1NPdEiUNheS0LmGjRAA6m/XRRFH52C/oa9U5iC\n\t +Wp4xTUvyo7MmvnUdjhm5BzMTHKiq6nWjmZcV9/ejXF5LZNu89+vhNWZr9r6I64JYn\n\t CzUZrJHKDMlSNH5NmTFs+VgWcDM8ZO//p8MP78PpsAKqHT+g7nVAMEC3Db4q3fVQfu\n\t FxJ+mrl0cxxHRm8IkC2LRTOQUYCPCDMc+DLqusfl7D7VJCQSwB9GATAkqNzDIZsrmj\n\t 01vJxwuF8Qoa7FKsAqrmspegCD7c8BePhk4b8Y0OAaid1VlZ8cn7OeotGgxuwfQOjL\n\t FZO+ZLrvU/weA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.10;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 6BA2840AE7","X-CSE-ConnectionGUID":["vVhZ00DdRH+IqPE3spzd7A==","K/mLK1euTpayJ1TcgPt3mw=="],"X-CSE-MsgGUID":["kZpThbZQQay7k/AbMo3TVA==","ISnwdHZ+ScmJFiXyDneDoA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11739\"; a=\"92837047\"","E=Sophos;i=\"6.23,139,1770624000\"; d=\"scan'208\";a=\"92837047\"","E=Sophos;i=\"6.23,139,1770624000\"; d=\"scan'208\";a=\"221273018\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=QiJBPW2KzmtcqSaZIaOGx52Wi/8/J13+nHCiUWcHg7LTRAN8/hJ0he3DPXbqB/bNrNOPghFTWTBuot39tajnlTHgKEZz7A5IPcauKJkjiGW/52ZX2iUz7f4woRFqFk/9F6M/HdCps1rLpQrAhyvLtvYgBZRGoMJpIwbiSdF1sglB99362IsoCj89xbkTkRba1SI/ITOW9psModShiL6JPFgerSgleibRduDTaY0npxmZ/knPk3dwNs4xSaD1BtqjUW7rKaWzIRsyooyX63mPbKOJBFH6bXTaLMDmj/EmfA2yqAMFalTPuxsaOd+JjVPfHs3X2AhiMoGmGCe5fel2Fg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=IoLVsdlTHFpXkwSjtQgOem9JtgKg707LHD9jcr9zN3I=;\n b=MG1ziuWdm+z2eMkX7uZ6whxjEt6YcwMkRgSuZCSCFtduG2gajcWI95YPPLA3ZgtHxNHaMo5CkcRLUROKrhgGPorYymdg/10K+4i/zcF/u0wtSxDokDjgQ15MbAbLt29w5dwY3QgtVTq2rMDmlgH3xFe3AbhvkspcKJjEsX+Aw3rasLiEkLWZfoqyBdg+w4zCSBjgWi/EUT4EU9tDO3wUw3+0bzHg8efko6zjUp9H4RlFabxvRPLcoA7YtzmiCfoPasF9aeXTwaUm3aWfTXzjrIeiHs+b5kPzxMy22xY+ehVEwrDfFzQIYZak14Pr3acd6Y7hkd2aoug2l/HsLv73eg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"\"Kitszel, Przemyslaw\" , Jiri Pirko\n , \"netdev@vger.kernel.org\" , \"Jakub\n Kicinski\" ","Thread-Topic":"[PATCH net-next 1/2] devlink: unify devlink_shd_get_priv() into\n devlink_priv()","Thread-Index":"AQHcvCEaCWUEh9ebtUqidtbjkX0KX7W+3djg","Date":"Wed, 25 Mar 2026 07:46:28 +0000","Message-ID":"\n ","References":"<20260325063143.261806-1-przemyslaw.kitszel@intel.com>\n <20260325063143.261806-2-przemyslaw.kitszel@intel.com>","In-Reply-To":"<20260325063143.261806-2-przemyslaw.kitszel@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|MN2PR11MB4648:EE_","x-ms-office365-filtering-correlation-id":"123c0140-4b49-4337-f2fa-08de8a429f82","x-ld-processed":"46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|376014|1800799024|366016|38070700021|7053199007|18002099003|22082099003|56012099003;","x-microsoft-antispam-message-info":"\n q4fw4i6EsLqHvMtJWO8NfnNrEqniyDjTTEl0WWMUn1yXy05mIDvx5ybzJwg+JCdopScljGPneYsuuIO0gYV3Y3nBAGtQJIBODVGlR1OFLYw9TwX1wFm4HxrV5NJubwuNheoKm3fLP0EHQOKJBw51DEIUkl1WfaOo9yUFat2R/XVA3sNozTQeU8zY8Zfzbp4RVV4XSlb55yjtywLc0MnKSYdf8sPkWIJCZZqkZpcBP0hd+dbyjZRGQ0yz25Jv5jCzyj0xjskrNa3bCbnsW5x8rqd348Tqoo7B2Z+CtD1PL1tOUDqxnZKw3x01D3QnJH5YpBryTgU7PWFcNPFNBL10eQ78dVC0rN5OoHQydmzkStwOtckjkRRQwRPDX4uSihtY8xKt5cxWAhuqGgLRb2pzRxT29CFkH0c9kK9jHH0PqY6SzIBSxqiyHEojwtvRWEFmfpKOGcn37OJ1zMeD/8IkzF+nevCYAvZrwfSi2lR+0BJL/UZURT6xsggYVSMMzrRs/kWCronoZOQzKBw0ey9l9Mps1l0Jx4VR/QxpqvYbuZjkjyE2QmyTZ7qStbdcILLGnYNe0EMZYpcBCR6NsfBlRQkW/8dH29R/eKa7jn8ZUjPJM+e3vFBt8uImvemENItojf19Ck/WlGsOQ5wUFRDYKx/c9kEpLTZnoREXrRQKv7+JgyfzKxzr5kKIrB0R/aVN51Tlk0tTmXDFbYmoo/QAmGwYOg6zOCe/WxbXMkVwPI9PzpJvR9VMf81p21gCFFBIvF2t08kvVdeNuDbfKV7Fb9EiBPrdUceZOOWM8KERGmzDrW5IUL/sljdgDWbOWuiA","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(1800799024)(366016)(38070700021)(7053199007)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n lGd4EBZbmxTO6N2LqfaSdllnj5h1/UsG/udH3ybiwgOOc/M5Pj+vxIlHp9wL+EgOMi2Zzeao6veZjCBiCOCB00UMXaU7eklfMNmCNHFGaZMXMDaYExHWFEoqL8okOHmEnUkKKnVe5QTdXpPW7Dh+7UiYfgABm+iQiFeDgFKndq26hJRHRP/apUPKJo7f0S6lIAdwld+yTKdHilElXWIp0mzt3b8p1ZeunLVxYuE1JIYgNOTePx3g+E69Yr3wAdbGZgBB0dGeaU3HQ/e2x54i7sH8xnU0iffjq0Bl3/ayMZgw05sFEcAwfC0hv4CIuIFQZzjaG+llvFitPBeKJY8byLeWHG+rsEdVSmU7KFyRgN0wp+6Xobq63zz40DN7xR7t0xCYWf+UYUkgR+QdbYX6xi0v3xthR2k4jeSEwElk/ycnTq6CA3fFuPSQ5Ceu1h7J0r7lq1DzLiuSqgS+SK0fcQnA8I02bTYL/VVbHCowRx9C1JkrE6foyLZyGVuVgyLdcbfQbTfVvKVlaoo5V8pjBhyHhVaimr/M2MloqPtKIgwEMqXi9GlTAHwv0sjJa2JqB8DFH1ViG14Sowc4TpYiNaShrroPebCni+AGjIzhD+5IjSzse03hFzTT/n+/EqM1sJdeP1ftf9XmPtz6Zh0U7wTCwjqlAP0XbdCZrJirpv36ojlxN1+Qj+TfSNDNsf5kNDH0rGOHAs3K9yTM3mIbbinE/e0q9F9eMvE7hF0T54r4VUOU6Zw8oB5wx4KB7m5g8BOtQAMByXn8leANKgEW8b3EDQ1sTm/qCmke4lwnDk/6DauzoDgDtkeH+wGoC0SLTU5Y3Qlds5pjqkYl/w+AsCKlBVaznd+EID2orYeFnAEgjihgkfRuM26FHqZiVZaloD3i/hX9Py/htugPFyrucfLI3ery7JA6orPNghFPGnoCXgB0tO3wMwF8s3qzffmqHSbirWQe6hqU32p5TdJeBHqH5DnEpTwDUFzITq5emPNHHVyj7UmOTEX7LJhbqoXPgLWnLzmpskT1Quxg0UOPndq6mP1hKAQeGgqyolIT+n7i+EDi7mXW5Oxkykx+A1dsM6vjrjs0ER/hebfvBccqIOOVmUBtgEPt00brg/e0zRusnMQ5grs9fcpWa1r7HzmKB27Z5XWNXymvtewa8JQXuqXtG9McWXmhqZjtbxSNCDGPKLlzOeIVVJo1Pm89oMjlwQzo2Teg//q3mDvxOYKHDAhZwpZgg9f8y7yMUfT5HnzG0hhC9pnTbuM4peMcu6i6bpoduEd8+pGMBFpPxtcpJqzC8c78oO+aTXy+SF4HJR1DzSVXFwKanYI6Wn9X+hB3aGC2/Hk6yaNVMVa8HC2GJHB/ZbOAPLitb8baPJwJn2drlvkqpubiawQFIN2Kd6nKb3I3HE/lmKrZujdHvS3Tduwe4z7cmdUDjfm5ynq0hAgUWPVoHq11brlF62lq+1iW9UYnTkakLsj0aKqNvTN7KYyBtG62ooHn+KP5agZr6QNZee0YSbfpEDaTP4WNWaqBYxxoaL70HDDgwiMgSX00ZbBbGvgBsrExmgry9jGewjgIHmNcn2hVmgHn3nJRZMGeuAirANyj3lNv5eXG3RW1OkC+0RmRnmXNaecnU34A2I9QcFZMl2f0Z65WaL1jg/LpohpzR74T2MVjwmSTAj83C8F0pWe7yDjdfQrM8UuVoDLDDhxlfyr6hYuV9a3gbFkjMsAGjWWtvQm4u1o2kYoKHK02uDpbpXgvhGU67eD6Yuo=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n ofua6vxMEdpuisWPR3D88wHcyo7vy50CyVgdnlQyEfkmMhgZTj94bUhm4Fw68LuPJX6wQfJStO1alq/Bxy6oyyCIpnWEwmKq9fxxPFxyCBxuU0NcillXdZPUwgfOPuqnBYUyLLFwnl6pSp2VvZyimrQ8szilirRB4qLC52dlGnjYZJmwmZTFltMtLDvq/XLWblGSTtdxDxW+cUvfKb86wLqi0AMBaj7XPpVn1t7EZsobXPa7vB4ThKwtwqQ9lAEyktP0kaGS+J0nAPeXGrHnwdksjxuA3naQVdLZkO1EFvstBhhn6fdpPtO5ZpG3Qc1ww8J1ATanZfprPKGWCZSvxw==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 123c0140-4b49-4337-f2fa-08de8a429f82","X-MS-Exchange-CrossTenant-originalarrivaltime":"25 Mar 2026 07:46:28.1508 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n 1iSB4qMzjIxIJ+XQcE7mXD54N/nMByG+cpw2O6SENNvV/DUcDCSAYA4RzqTLNEw3GQmwm+yi7WXtrHtZqCFx3XWJ7HFv2Q1AgFj/v+Jq2ug=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MN2PR11MB4648","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774424802; x=1805960802;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=JRtVlqrpt2OCbTGlME+kW3daAgHhRqWFQwJ8sO42VIU=;\n b=Ei8NxYf/NHL/fo16fzvvB/2F+nL1226TDa40TyypxKkI3d33jzNsKhWR\n FSFwVtCuycWuKbvrwHX8Jc9D9kvpW8SMyBINkf26khiXFTbLs12IMJIKZ\n rrM/6z8UKMV6rq60mfkTHnQUEEDb9gG5PD66vSJAMMJurYfYRwOwpTQ3S\n xqZkXMEOfAJzXK0mga0+joofptSo2hjQ3VX2YUKqjv8/2i6GHvlq27ai9\n Ep/h9mMTb5Bxt492PskkmnwpvBjJ8k5yg5UV3gfF3JvGWSPvs55vkXwlH\n vZmx3d0O9eCzkl5lnytWiZJp6XsoH+wnfvlROLTBL8KaBBubuRSX7MPDH\n w==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Ei8NxYf/","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"\"edumazet@google.com\" ,\n \"intel-wired-lan@lists.osuosl.org\" ,\n \"horms@kernel.org\" , \"Nguyen,\n Anthony L\" ,\n \"pabeni@redhat.com\" ,\n \"davem@davemloft.net\" ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3669395,"web_url":"http://patchwork.ozlabs.org/comment/3669395/","msgid":"","list_archive_url":null,"date":"2026-03-25T23:36:21","subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 3/25/2026 12:46 AM, Loktionov, Aleksandr wrote:\n> \n> \n>> -----Original Message-----\n>> From: Kitszel, Przemyslaw \n>> Sent: Wednesday, March 25, 2026 7:27 AM\n>> To: Jiri Pirko ; netdev@vger.kernel.org; Jakub\n>> Kicinski \n>> Cc: Nguyen, Anthony L ; intel-wired-\n>> lan@lists.osuosl.org; Loktionov, Aleksandr\n>> ; edumazet@google.com;\n>> horms@kernel.org; pabeni@redhat.com; davem@davemloft.net; Schmidt,\n>> Michal ; Kitszel, Przemyslaw\n>> \n>> Subject: [PATCH net-next 1/2] devlink: unify devlink_shd_get_priv()\n>> into devlink_priv()\n>>\n>> Unify access API to shared devlink priv data with normal devlink.\n>>\n>> Thanks to Jiri Pirko, we now have ability to create shared devlink\n>> instances [1]. Introduction series have added usage of those for mlx,\n>> but without priv data attached to the shared devlink.\n>>\n>> Current API makes it possible to access shared devlink instance's priv\n>> data:\n>>\n>> \tvoid *devlink_shd_get_priv(struct devlink *devlink);\n>>\n>> but it is easy to forget (especially during rebase from \"before shared\n>> devlinks\" era) and call:\n>>\n>> \tvoid *devlink_priv(struct devlink *devlink);\n>>\n>> which even has the same signature, so it's hard to catch the error.\n>>\n>> New proposed API unifies both calls into one, without any increase in\n>> the observed struct size. (Alternative could be to store additional\n>> pointer, set during devlink_alloc).\n>>\n>> Unexport the less convenient API call.\n>>\n>> [1] commit 411ad0605875 (\"Merge branch 'devlink-introduce-shared-\n>> devlink-instance-for-pfs-on-same-chip'\")\n>> [1] https://lore.kernel.org/all/20260312100407.551173-1-\n>> jiri@resnulli.us\n>>\n>> Signed-off-by: Przemek Kitszel \n>> ---\n>> v1:\n>> https://lore.kernel.org/netdev/20260323132136.13191-1-\n>> przemyslaw.kitszel@intel.com\n>>\n>> v2:\n>> - fix typos (Alex, Jiri)\n>> - fix infinite recurrence (Alex)\n>> - add __devlink_priv(), which is more general than v1's\n>> devlink_to_shd()\n>> (Jiri)\n>> ---\n>> net/devlink/devl_internal.h | 7 +++++++\n>> net/devlink/core.c | 10 +++++++++-\n>> net/devlink/sh_dev.c | 8 ++++----\n>> 3 files changed, 20 insertions(+), 5 deletions(-)\n>>\n>> diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h\n>> index 7dfb7cdd2d23..0a57318d92f8 100644\n>> --- a/net/devlink/devl_internal.h\n>> +++ b/net/devlink/devl_internal.h\n>> @@ -58,6 +58,7 @@ struct devlink {\n>> \tstruct mutex lock;\n>> \tstruct lock_class_key lock_key;\n>> \tu8 reload_failed:1;\n>> +\tu8 is_shd:1;\n>> \trefcount_t refcount;\n>> \tstruct rcu_work rwork;\n>> \tstruct devlink_rel *rel;\n>> @@ -72,6 +73,12 @@ struct devlink *__devlink_alloc(const struct\n>> devlink_ops *ops, size_t priv_size,\n>> \t\t\t\tstruct net *net, struct device *dev,\n>> \t\t\t\tconst struct device_driver *dev_driver);\n>>\n>> +/* Get priv allocated for struct devlink */ void\n>> *__devlink_priv(struct\n>> +devlink *devlink);\n>> +\n>> +/* Get private data from shared devlink instance */ void\n>> +*devlink_shd_get_priv(struct devlink *devlink);\n>> +\n>> #define devl_warn(devlink, format, args...)\t\t\t\t\\\n>> \tdo {\t\t\t\t\t\t\t\t\\\n>> \t\tif ((devlink)->dev)\t\t\t\t\t\\\n>> diff --git a/net/devlink/core.c b/net/devlink/core.c index\n>> eeb6a71f5f56..a242be203fe8 100644\n>> --- a/net/devlink/core.c\n>> +++ b/net/devlink/core.c\n>> @@ -230,10 +230,18 @@ int devlink_rel_devlink_handle_put(struct\n>> sk_buff *msg, struct devlink *devlink,\n>> \treturn err;\n>> }\n>>\n>> -void *devlink_priv(struct devlink *devlink)\n>> +void *__devlink_priv(struct devlink *devlink)\n>> {\n>> \treturn &devlink->priv;\n>> }\n>> +\n>> +void *devlink_priv(struct devlink *devlink) {\n>> +\tif (devlink->is_shd)\n>> +\t\treturn devlink_shd_get_priv(devlink);\n>> +\n>> +\treturn __devlink_priv(devlink);\n>> +}\n>> EXPORT_SYMBOL_GPL(devlink_priv);\n>>\n>> struct devlink *priv_to_devlink(void *priv) diff --git\n> I'm worried about priv_to_devlink(), if someone passes the result of devlink_priv(shared_dl) as priv,\n> container_of computes garbage - because the pointer came from shd->priv, NOT from &devlink->priv.\n> \n\nThere's no good way to detect that inside the priv_to_devlink either,\nsince it can't know which private pointer it is looking at. Hmm.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=cSC3tb6v;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fh3Fv4FL6z1xy1\n\tfor ; Thu, 26 Mar 2026 10:36:35 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 638676081D;\n\tWed, 25 Mar 2026 23:36:33 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id eU78SLllnXpJ; Wed, 25 Mar 2026 23:36:32 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 79A6F60837;\n\tWed, 25 Mar 2026 23:36:32 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 4B571353\n for ; Wed, 25 Mar 2026 23:36:30 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 30B3C40A9D\n for ; Wed, 25 Mar 2026 23:36:30 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9Fut50wkWg-f for ;\n Wed, 25 Mar 2026 23:36:29 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.11])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 3C80140A8F\n for ; Wed, 25 Mar 2026 23:36:28 +0000 (UTC)","from fmviesa005.fm.intel.com ([10.60.135.145])\n by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Mar 2026 16:36:28 -0700","from fmsmsx902.amr.corp.intel.com ([10.18.126.91])\n by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Mar 2026 16:36:28 -0700","from FMSMSX902.amr.corp.intel.com (10.18.126.91) by\n fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 25 Mar 2026 16:36:27 -0700","from fmsedg903.ED.cps.intel.com (10.1.192.145) by\n FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Wed, 25 Mar 2026 16:36:27 -0700","from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.2) by\n edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 25 Mar 2026 16:36:27 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n BL3PR11MB6433.namprd11.prod.outlook.com (2603:10b6:208:3b9::11) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.14; Wed, 25 Mar\n 2026 23:36:23 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9769.004; Wed, 25 Mar 2026\n 23:36:23 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 79A6F60837","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3C80140A8F"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774481792;\n\tbh=Zg4b6JwAecei+8gXk0oPD47xRW4pcgo21r+kheCuXy0=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=cSC3tb6vg62YBU+iEkr9c1/55Xxb9ivJXTyF9HU+bYQ8shstF8H7bbAK3vPd32S+q\n\t zhDzqHQ7WBNfaEyyQIEV3gKuz+FNCxpbOtI4kjMgXE3Dxrk5qKZ2z0xqH5RzwzwAOH\n\t AmyHJ/8uFrOIAHZb2fjbYUBKxROLHMw3aGQdxIq35LmyE84vpciiz7Leq87fZ7OYdr\n\t hMZRMiXP/hfH2/TPs4jnRcyqFfvbX6bn+wtiKLkK7mmSU7Ns2oMrpjhWYaTiHUhBKE\n\t mYv6f1dfipYX9pjKVYSH53L/DiJg1sDLnsDUtb3HaSW4akzbehG2LmklbjduyRsWN7\n\t ZdV7D9W0Pb1Cg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.11;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 3C80140A8F","X-CSE-ConnectionGUID":["BoPVb7aBR+qqWm1/jwBrNw==","2/gxjuHjTrWWsPQkVGn0DA=="],"X-CSE-MsgGUID":["W2f5CA3uTcaGJyrKWh83sA==","FlhR2kNkQ1m0QBj4T4O+dQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11740\"; a=\"86150317\"","E=Sophos;i=\"6.23,141,1770624000\"; d=\"scan'208\";a=\"86150317\"","E=Sophos;i=\"6.23,141,1770624000\"; d=\"scan'208\";a=\"229604021\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=ARu+Srb5K/47wNTLJwnoVMuWWsGoSHF4C4+aWPPWogDp7EIhlJErPdIWy2wR6C22U/07QEK/YqyTVsjGWPhwJoAliUnla2keRXWiVkvQJ7MuenhrOZuEgl0XNS+ChPZR8BZ9AKr0ryAjqEJYciSCcpll3hynEoTtGn/KtuPbaIqtzjyhrAyLOxiJ48524MXxhpjabN8sXKARk9j+jWllJF4XpTHYQQJ/rjAfcF58dGyQOJjkW5dwduQshOJdFErDML3GMcrstkw8XhJAUzIL4cLOnrJxQ7bKysZQx84XtBLBuoD4WnVs2C5PIlrXlnzLPKSj3r6edWgLlilWweN8Bw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Zg4b6JwAecei+8gXk0oPD47xRW4pcgo21r+kheCuXy0=;\n b=SCviMpG3Iz3kqjFWl89YJBkWeYSEkW48yQhrEHB9J6XL+isGcPsnIBAAuiClxbV3Bn4OPZ4e8O8eSQCWJTs428ScdfyMzL/cdpeidF8eNbi0ZB0v+nO4C6f9ELnrU+/16QhTbIxFBMfOhp6aPfEMCDGuOcRiPHoEEGqZekqHp78sDFmZY0R6Eh5eRS+0woyAwSb6lC8eX+yjsKagRCL+3kDE/F55ODQ1nAwpIxEdOx0vMBC0jEdAxCY7n4OForGIJK3s07+9aGKxHip+5zWL15l5iz796wN/M+su9QHwddWUZ/f52FAVVt2j5fdpji9XtPZvTM8UNEi0rUoZaY9Tag==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"","Date":"Wed, 25 Mar 2026 16:36:21 -0700","User-Agent":"Mozilla Thunderbird","To":"\"Loktionov, Aleksandr\" , \"Kitszel,\n Przemyslaw\" , Jiri Pirko ,\n \"netdev@vger.kernel.org\" , Jakub Kicinski\n ","CC":"\"edumazet@google.com\" ,\n \"intel-wired-lan@lists.osuosl.org\" ,\n \"horms@kernel.org\" , \"Nguyen, Anthony L\"\n , \"pabeni@redhat.com\" ,\n \"davem@davemloft.net\" ","References":"<20260325063143.261806-1-przemyslaw.kitszel@intel.com>\n <20260325063143.261806-2-przemyslaw.kitszel@intel.com>\n ","Content-Language":"en-US","From":"Jacob Keller ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR04CA0257.namprd04.prod.outlook.com\n (2603:10b6:303:88::22) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|BL3PR11MB6433:EE_","X-MS-Office365-Filtering-Correlation-Id":"e9c79077-5e60-4446-3a27-08de8ac75369","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|376014|366016|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n SXIWP41kxU1dXnJN0xAb0SyIXZUq8cdIct8cQrv0tSZ+1sp4A3xZlWockFMNbLKg3WnODVeg6qDjnd1JyCuyrKPXPWhZKrSe8hBluTiRBwTGZ2fvSZQV7c7t9OZl454q8z3007OqoerByyvLue3fJ/6wHxtj+bVD0E13gbpV/XwtS/dMNGqpZVr0DcOingPQxJXgEmGu5p8ElJHqaLo6E1y0ngisM80sMTyAwq2DiMYa6K+9TtoeaHufeo0pf28p4DewJ91RawiQPL1J6ly8YWcmmcmgSg4Vk6hDz8qA6yLXhph6Gcgua+NtKfh+hrCG4f2Ot5iKIr6p8EMmr2GXZvc91+vFvSrG7k7Fp1O/zkI5Hq7xgtChBN0iJgZhD2A2dARNw2cxtnYBliyPtVXrqk/DdVn2cii4LJW76tgFSiWxS1neEVIMzys9wkgwM7hfKb/z6iPcQEzK93Qgy9qd0WUVL63XQx/5Dy3R/If4ZP6nIgtDtasXRf9tKlPl0bml+sa07rCYHyf5fvZEGCar3v0jchvLOqbnYBr/OyCcVTXfk9C/esMv7ifbD2sfPCMXgDlGzy1hw6FreNlZxnZ/4+pY/3F38evNyRXoiWKdMlds/ua04KBsrSJ7QQnu1IQM9zvbx2h931e1J2mKJU8oKcSzP6HaFwYrpydbYbbtpupnOOmoNqUp+ogmL6uXXV0WyC2sJFSBzbXKnmP3c8Y27GyP7bXoxe/WXcfubnEVjZoA9W6UZXCnruMXwTISf0Mi","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(376014)(366016)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?Do0QohDajt0UmCP+AIMpOl4SXarc?=\n\t=?utf-8?q?WRrIpOopUhHxc8qhLR/1HHW3UEefUWCn1OHOIqgw7xEK5ku5pGGvD6qLSJfbv+IiN?=\n\t=?utf-8?q?QToUDgQkyCU+R3kfWKdRlUSm/oL8jMcg1ROFXricZv7eo4secehSTMxCbqwf6WMVH?=\n\t=?utf-8?q?nHbUE1LjOAKuV79046gUvgJSwHhYsJo+D3s1DXCicZKaaVLGPntpdYtCkKt0MI/mR?=\n\t=?utf-8?q?6I7rl720kDORZGj56i09MW4WwmKuks7YTB0VCa7XN2CMmDIuPJrHzHyPycKC19xDl?=\n\t=?utf-8?q?byeLPja44uM7tx9dOMU2qmeNEa3iNeaTVZsQW41nxhoI4OkxReIw2awAU7BKMYgGK?=\n\t=?utf-8?q?Urdre44K1QWgSewAjuAW1Yxja7EsBF/mBaDPbRearVYGFg2xzsde2h4vtxvB4IULm?=\n\t=?utf-8?q?yVzzzOgF2ghFG0ViHKDcsA3IlojfkTf3ZZmT4AyxW3AOgkF4uEElumFvOnuHZEUYB?=\n\t=?utf-8?q?B/1dRIPDqp3qLm7ttVEutKeFXkWCpHfmrT4tqGVicippBm28mQYWuVH/OqKzH2rdE?=\n\t=?utf-8?q?dbeVQL2flNHU4bBG6y8wRPODgOYc2HBVi8O2Da8+h3qrgswbcRd8Img0jaUlaCVhm?=\n\t=?utf-8?q?9zh60K0ZrVfR0AxYdPj8ceQM3z2Q7yMkNRISa02799ERTKiPa/rvKEZhEu6Nr4/j6?=\n\t=?utf-8?q?eVtkQnvP/CkDe8q1DQ5/5pJLDyf0ANP5J0hpM3OcoXqmlmeeDATyRad0yNOnZVGv9?=\n\t=?utf-8?q?gz0RCIc9KWhuEy80KDuBF366q8YuYgjG+6b7vnBIIlQBgeIynUXbi7LtqfLF/WoR8?=\n\t=?utf-8?q?mraywmX8NDotxKpOgTfsrnYmp5ubv+A9NN5b/FWJko6WaG4LPchKPpuv7EtCJhXHn?=\n\t=?utf-8?q?MD+FTplCx2tTS0SfASH2Ad6Giw+E+h4wTPpOgf1Z0cs4r2E96BOKFdMluY3kxAzG7?=\n\t=?utf-8?q?BgcWFlLk22K0gN6ivejEdyZhg/5t+44Z2gzqp/sbVsw70+SDFG/sV6s8Iwt5tTD8d?=\n\t=?utf-8?q?R2JeKVPNh4rTRJB7O1ZDMZsKCoZ0G53HRq2Gzk6TC03oVtGESGkP/CCuPDsMPMJhM?=\n\t=?utf-8?q?Lb16hsk2bW4lDRc2rJgRRm60e62XBWq+wsOAngQrEwWN1IY3OG5rkAH/foT6Z+Wyu?=\n\t=?utf-8?q?Rrvj2e78oO8SU2MhyM7N7lun4pyn3VoWQ/DqYkWjN6SU9MK4+dP9sEtR7NjjQ2Ol/?=\n\t=?utf-8?q?sxin8LAaeeBUNeJhTc7I8D6Onu7m+x2JDw13NkNFUxMEMrwOotsPgMtE83TbEizDe?=\n\t=?utf-8?q?cA18U9whfpE048UYOTMyScLWCjo2QxkEDiiWR4bdBXqoY4tbPwcioJrDds5g2dxFg?=\n\t=?utf-8?q?GXgToQWuiju0rlp56yerP79eaSEaDvD3VM3wYs3Y7ZC9VXVIDJDRV/noBkaHMUk7Q?=\n\t=?utf-8?q?N7du4ZFLr3SzgnDzvyo+RKaQnr+yP6N8hegmZ6gOZcVXOcl9/DoeSFdyMUxVEGyVr?=\n\t=?utf-8?q?A1CrHIAOXpWT9a3431HdhV1wRpZFNJ/QG3LARzP1Zm/YE1ijS9MlRa/N7nQeiNZNR?=\n\t=?utf-8?q?msQlMRFCS2Vhsc9hLVWPn7rqQa1In9kqsuM6hE1oNrzp5vwCljIiBo9qDYvTCqfzE?=\n\t=?utf-8?q?LyBp7yU29X9Y2B3FRuhlL1qSBJhKXFqNU8WIcapc98D/mXUOg6rAIvrTRDYgIRVKm?=\n\t=?utf-8?q?Ce+onFGM14ANLUSGMQdbmDsc66jagWnVtivyFlck0+9PYNf0Nvs+RLDjDZgvnA/iB?=\n\t=?utf-8?q?Uu87WMm3oL/grd1Ad/kINe/qKj44p2QKBpe8q2+7cQT8ORYBWshEg=3D?=","X-Exchange-RoutingPolicyChecked":"\n QDuX7yIWPLJYTvw1ZPpQTWdDXvpy4t0XJ4AvANTRZIkjUZ/VeiQtkWxLLU5BSYh5Fo1ge3piEtE+j5AmYgdkzfYs02xF59e/ceqzdBKAMyHVECq+r2algHnuFZZWEE2Rx+aMPAJRzA/RNr2efx9KRKNHr/Qq3nmBeBNqVhB0ebz1lrOTmEe23Lo+12Kjr3aRVGX8Qa3OtxnJ+rIvJd3fCJNGd1gMJNkK6+HKgK9F6nFztAzNh4uoC/PQFwCSFDDH9rOirE7qrm6CwLhqFf81NkpLG/W5/xcjUeaB1+4ezNxecITWGTinqoJDIuJQufZbhAA8fhEZfex+BPLIDNSE8A==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n e9c79077-5e60-4446-3a27-08de8ac75369","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"25 Mar 2026 23:36:23.7136 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n GnKYhv3frRWjYDO4ST2snTvxqTRX33EyR+vUPRbZQo6V8pxwc5u2Rw9bHIGvFnxAzv4c2upcHONf5cxYrtlz5ARi41k/VP01yOGbvpHUjKs=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BL3PR11MB6433","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774481789; x=1806017789;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=m5Z/iDnahWvrhkoaQD99edVtLnpNzy+o7aj69RRh1rM=;\n b=SP3UPnsmlOLH/1uHV6e5xAGwwZ4Hnzm7LQySpMRt4EAgg96gg3SPKFUz\n QMtvmCbod7bGPabYXQ9BwDHoysBh5sQFea8drQkl1qRk8pSfvIysHfYx4\n 1GZLk+NHP6+ZdmTkM0uPPyZcniUXLdvebTDA1jHr4yD/vkWCQqEIKB9mx\n in3WdjE54MroHjH3Ge7Ko4d7ffljKUnUHCzl3L1Pag9fIa4zENiNujobb\n /C+9MrnOOdGFMM2JsmNzdZlKyMCQDG6UwxNfS3XF2k0AQrvLGRnzFjolN\n 4eoX/ipXEp37xnQAfo18ETOryAD74joC0SSix0WEYTTsUnJRQU8dLqjXa\n w==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=SP3UPnsm","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3669465,"web_url":"http://patchwork.ozlabs.org/comment/3669465/","msgid":"","list_archive_url":null,"date":"2026-03-26T05:21:32","subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","submitter":{"id":15321,"url":"http://patchwork.ozlabs.org/api/people/15321/","name":"Jiri Pirko","email":"jiri@resnulli.us"},"content":"Wed, Mar 25, 2026 at 07:26:52AM +0100, przemyslaw.kitszel@intel.com wrote:\n>Unify access API to shared devlink priv data with normal devlink.\n>\n>Thanks to Jiri Pirko, we now have ability to create shared devlink\n>instances [1]. Introduction series have added usage of those for mlx, but\n>without priv data attached to the shared devlink.\n>\n>Current API makes it possible to access shared devlink instance's priv\n>data:\n>\n>\tvoid *devlink_shd_get_priv(struct devlink *devlink);\n>\n>but it is easy to forget (especially during rebase from \"before shared\n>devlinks\" era) and call:\n>\n>\tvoid *devlink_priv(struct devlink *devlink);\n>\n>which even has the same signature, so it's hard to catch the error.\n>\n>New proposed API unifies both calls into one, without any increase in the\n>observed struct size. (Alternative could be to store additional pointer,\n>set during devlink_alloc).\n>\n>Unexport the less convenient API call.\n>\n>[1] commit 411ad0605875 (\"Merge branch 'devlink-introduce-shared-devlink-instance-for-pfs-on-same-chip'\")\n>[1] https://lore.kernel.org/all/20260312100407.551173-1-jiri@resnulli.us\n>\n>Signed-off-by: Przemek Kitszel \n\nReviewed-by: Jiri Pirko ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ezx8uDnI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhBwB0tswz1xy1\n\tfor ; Thu, 26 Mar 2026 16:21:45 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 4E75380E5D;\n\tThu, 26 Mar 2026 05:21:44 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4X2gv-Lkk0Oz; Thu, 26 Mar 2026 05:21:42 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2B18C80DB8;\n\tThu, 26 Mar 2026 05:21:42 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 3B646F5\n for ; Thu, 26 Mar 2026 05:21:40 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 215C740B13\n for ; Thu, 26 Mar 2026 05:21:40 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pM9t5jesLhMa for ;\n Thu, 26 Mar 2026 05:21:39 +0000 (UTC)","from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n [IPv6:2a00:1450:4864:20::32c])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 8408340AA0\n for ; Thu, 26 Mar 2026 05:21:38 +0000 (UTC)","by mail-wm1-x32c.google.com with SMTP id\n 5b1f17b1804b1-486507134e4so6734095e9.0\n for ; Wed, 25 Mar 2026 22:21:38 -0700 (PDT)","from FV6GYCPJ69 ([140.209.217.211]) by smtp.gmail.com with ESMTPSA\n id\n ffacd0b85a97d-43b919e7372sm6396013f8f.34.2026.03.25.22.21.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 22:21:34 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2B18C80DB8","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8408340AA0"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774502502;\n\tbh=h6xob+88D6E9GEQn7yU1Wmh2IpOqPRfLWkOOX/qRlp0=;\n\th=Date:From:To:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=ezx8uDnIXfY031b3SPISKByCi/dJQdy5QdH3duMNjTbnkRVz+sCtAvPJ6/mANDhFO\n\t 3c3IREm1Rv7jYiK/Rdfe2JDPgkad/tWzMpaKFVs/t3Lshqcy1BfWTR45vrmx8dOAH6\n\t U9YVudBPaIrXQra+2aJnGhAoRD+3sXk+MTWMmHurY+8q/n5oD6BeEdNZmC46J/2iAA\n\t OI5GuVXgBoCzPnakJzuyyh93Uu9rGNpN4d3L8xMnOZkKyxNo5p0n9b2/dn/FZt9IXY\n\t dxqmetnhZuw89+DOE+ClLF6ljj5nnOTbjRQC6jEBj8F5uhhUHDy7XOWHlYiUqNQbVg\n\t VZd51s4Hg+Zpw==","Received-SPF":"None (mailfrom) identity=mailfrom;\n client-ip=2a00:1450:4864:20::32c; helo=mail-wm1-x32c.google.com;\n envelope-from=jiri@resnulli.us; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 8408340AA0","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774502496; x=1775107296;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=h6xob+88D6E9GEQn7yU1Wmh2IpOqPRfLWkOOX/qRlp0=;\n b=eKFnczKGW1tIzDECIfetMT9KwnpyaqWAdcNWlYNYi/gOqxm5OcAOk4ne26bBEZCHN6\n m4TvrV40Q9xF7RvDglDdYOjfO8fTV6kKnE0DfWxCBOm7R/pVwkxUFy9Os9I8u2cZRfTz\n wKHBeQXOdnyCst44gnmhguN+WvbiSeFOYpgpDQVDC6G370kfckTFQGUfyTZKCY1ctD/R\n GWrEK5+b2e1f09qD806tsBH88dtkRcxwGVoO0MlXC6LOnc0mncNL4yTcOSsLo6/WQanZ\n yQFIj4M+gCGCcWc3U052kgsPBot5dAhjVbhkF71Z72QGHsHWuxFpgc0KAWzFPhPISn8x\n hmBw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUA19USjdrLd42uRxht5eqEj284Z9Hz4ECr58h1Y6GeRPMN8B/xeLLMPnY2e4eWrCreosDCzifaYq2hQ0w9W7s=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YxB9CFcxprYLWBXgwZ21NUtHA2hB72E7iM6lQ2+X8X1yOKvAmN6\n FOCOPmUV3NSud97fPaUhdrdJo2PSnx3Vady0lNC4kd0g+fCpLqmLVLP7gyp5zzfn8jc=","X-Gm-Gg":"ATEYQzwJ1OStB2AFtAQfGRTbO0b3t1h3KdC+U3su3ELnHxa3wFOd3jvE6vucfUEZ2rq\n xaCiLKRTePIVmf3zS5ILuhVOUDCJZwPVoS4Rf/0v/ZpdzI/FTCEu0Qkoi4PrD631jM/CYrKjJpv\n imo+yfrmcY+lM1UcWZmSdFZLB5XRn5LDw0NS5EcJAiElsLtmpO+V19TWMbNOZp5EKz23BUGTE4L\n PflQDxra+1EaLS81b4hptzmDMmXuMnG02Ra+O6jfQX5dtl9n/5D9aV4Qzbi7fxCv4/HNxpSQwVg\n JKA3uR9aJvQ1e9MCQJOjVd0oAhiawnanEteKpxKl08L22IUnXUFaTEQZSLpkImvevfSU5ed3ev4\n MPnWFuA0XJkalSRa1nLXyWrTN321ra3BvwXlj73JhrNkgPWwiCd5dR01oqmj0LSYiF7qhELPQx3\n ThEEn9LGIOQT8BPZcFQLP7gAVRQ3W+v7iUW5c=","X-Received":"by 2002:a5d:64e6:0:b0:43b:45d1:f438 with SMTP id\n ffacd0b85a97d-43b88994ef9mr8986926f8f.3.1774502496388;\n Wed, 25 Mar 2026 22:21:36 -0700 (PDT)","Date":"Thu, 26 Mar 2026 06:21:32 +0100","From":"Jiri Pirko ","To":"Przemek Kitszel ","Message-ID":"","References":"<20260325063143.261806-1-przemyslaw.kitszel@intel.com>\n <20260325063143.261806-2-przemyslaw.kitszel@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260325063143.261806-2-przemyslaw.kitszel@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1774502496; x=1775107296;\n darn=lists.osuosl.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=h6xob+88D6E9GEQn7yU1Wmh2IpOqPRfLWkOOX/qRlp0=;\n b=ilGF+haE+wunFgeK1h2vsDisad/DXhucbF90NjHjlX/Zuam1/EHJKp7JMhv9Hn2B7z\n v/sEpsH/mh254OqEeuMuqDT3gkUPYmp2qSm2NGmEDcykLPqU/KnldGoFx78NrEwT5cCF\n SyaWFaKaMScr2NGBWCMBaljg5SmXaIPSmwBvlOIOcM4qkwopPeu+6zPNr0TduE45k2Km\n D8/z30nRx63mMQCJHFatambGplG/AX/ezbW1FJpK/zNGC4OSRh7Q93kU9p0skM+ANPHS\n HTawUdIiNa/bBPddZ0ht5O0tbunqF3/vyd4+dykNCYtJuWZFPnM4j9bJKFn8wJKFbPOt\n k6Zg==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=resnulli.us","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=resnulli-us.20230601.gappssmtp.com\n header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256\n header.s=20230601 header.b=ilGF+haE"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"netdev@vger.kernel.org,\n Aleksandr Loktionov ,\n edumazet@google.com, intel-wired-lan@lists.osuosl.org, horms@kernel.org,\n Jakub Kicinski , Tony Nguyen ,\n pabeni@redhat.com, davem@davemloft.net","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3669472,"web_url":"http://patchwork.ozlabs.org/comment/3669472/","msgid":"<4972e037-5465-4ecf-8894-e8b77f964bd2@intel.com>","list_archive_url":null,"date":"2026-03-26T05:47:52","subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","submitter":{"id":85252,"url":"http://patchwork.ozlabs.org/api/people/85252/","name":"Przemek Kitszel","email":"przemyslaw.kitszel@intel.com"},"content":">>>\n>>> struct devlink *priv_to_devlink(void *priv) diff --git\n>> I'm worried about priv_to_devlink(), if someone passes the result of devlink_priv(shared_dl) as priv,\n>> container_of computes garbage - because the pointer came from shd->priv, NOT from &devlink->priv.\n>>\n> \n> There's no good way to detect that inside the priv_to_devlink either,\n> since it can't know which private pointer it is looking at. Hmm.\n\nWe could achieve that by adding a marker prior to priv data, in the same\nlayout for both structs. I have code handy, will post v3 later to don't\nspam too much (and hopefully resolve discussion on the other patch)\n\n@Jiri, I will not add your RB, as this would be significant change\n\nthanks a lot for reviewing so far to all of you","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=QD02ePci;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhCVj20vSz1xy1\n\tfor ; Thu, 26 Mar 2026 16:48:13 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 42BD440910;\n\tThu, 26 Mar 2026 05:48:11 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ahHhxKG6D2-P; Thu, 26 Mar 2026 05:48:10 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id F19234089A;\n\tThu, 26 Mar 2026 05:48:09 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 3D371F5\n for ; Thu, 26 Mar 2026 05:48:08 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 2F2DA4089A\n for ; Thu, 26 Mar 2026 05:48:08 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id B5Ihm1i0nl5K for ;\n Thu, 26 Mar 2026 05:48:07 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.8])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 328AA40895\n for ; Thu, 26 Mar 2026 05:48:07 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Mar 2026 22:48:06 -0700","from fmsmsx901.amr.corp.intel.com ([10.18.126.90])\n by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Mar 2026 22:48:06 -0700","from FMSMSX901.amr.corp.intel.com (10.18.126.90) by\n fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 25 Mar 2026 22:48:05 -0700","from fmsedg903.ED.cps.intel.com (10.1.192.145) by\n FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Wed, 25 Mar 2026 22:48:05 -0700","from MW6PR02CU001.outbound.protection.outlook.com (52.101.48.59) by\n edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 25 Mar 2026 22:48:04 -0700","from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9)\n by PH7PR11MB8551.namprd11.prod.outlook.com (2603:10b6:510:30d::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Thu, 26 Mar\n 2026 05:47:57 +0000","from MN6PR11MB8102.namprd11.prod.outlook.com\n ([fe80::8d98:e538:8d7:6311]) by MN6PR11MB8102.namprd11.prod.outlook.com\n ([fe80::8d98:e538:8d7:6311%5]) with mapi id 15.20.9745.019; Thu, 26 Mar 2026\n 05:47:57 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org F19234089A","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 328AA40895"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774504090;\n\tbh=iT1gKWgABM+JOF8jOqVHcUZYbTAA1ZJlbpNeN4Mnkcw=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=QD02ePciqorsehn3tXOQgi7T4d9wXJzgaLG3vDfVqOfh9vhjr4iRfGbG8qODLChoM\n\t gbZwf+UgekJKDAzFPUOjnsURcnoMYiNgg0/s7iM7LiM+a/M3QQ6bHxZbG9rSXzmvBI\n\t ZNn7PxbsKMZgNRH87zYj/JAGNFrowmVH6nLUJ2sEHukcirbCpi6CMx+fbF8etbV5n/\n\t 1tX1D/MuOWR8ngxjqoCqSQz07e8lCdOJ0mAmR5AeKirtqNODki/4t0KH2L2qpXoqwo\n\t U+1bmSEzpBwtwEo/ZlSj5LMU1I59CNiEGhHItP/UbzTLFi8v/X6+Q/qDn6OAbh9NF4\n\t rlrPbyuJ6stgQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.8;\n helo=mgamail.intel.com; envelope-from=przemyslaw.kitszel@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 328AA40895","X-CSE-ConnectionGUID":["L9BSgz3/TDmY26wOFW2SCQ==","DJ9q3WoDRfah4kyYzGlz0g=="],"X-CSE-MsgGUID":["pYbSPU+9S2qmPI7qYZz1UQ==","7NOVffPOSxig6dwakmDA8A=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11740\"; a=\"93132747\"","E=Sophos;i=\"6.23,141,1770624000\"; d=\"scan'208\";a=\"93132747\"","E=Sophos;i=\"6.23,141,1770624000\"; d=\"scan'208\";a=\"225154755\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=BMBgc1w9NfB/JkarTtbqdxQ46+lvLa8Us6srWEc8gE8+E3TfsYZ+KTpKSmbtMUK56jHUNffBGxPeHkA/M+BrsAWpeG6/dig5wCyrJ/y7iViPBSiUt2IcggmRbpBoNVhrveHM/e7WZMOrZVDPzJU7l69nlU0qGx3gIcHuyFW/feSUL3YZbGAQj4huQ3JMwsngrjGll21nUar/WL6IBCgVmJPmVkn/EGZDGz8Jm8YglvKIOrs/d64chyebxe8jqv8wVPg0Q0lWRX06mXbnqEV9IsT6jJ0wpsgEsDCf6uTv89bIXjAg0cWUSImO4rTmmjqEaElvaOYUw1cx77hV2Y62oQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=iT1gKWgABM+JOF8jOqVHcUZYbTAA1ZJlbpNeN4Mnkcw=;\n b=ILAzUOxfRstzJhYuj90QwbLXTMJ8w08jp7mttMVL7XuxWpnzJ6HWptFP/pLBjuJ+RZhPD/HytOCbwMujmxs1xLuRHiih/2eIq2n0Jpbe/hlVq5hc9/eXjTCJsSnC/7PJuECfX+O2SMhAUBpwrIJQnFFWhVWkDeMlpLyLxbIcmFtU5ftaY9xVm7FidED4SaSIAogOW7U9lxOW2BWW2mgoJo7/FHXEEoi91wjMxp3czG30aqQbMAhTm9K32SQR8fNdQ1EnzaHu+065/LkPga0DY95CntVp0k8HSU9RcRWtiuRJI4wjYy7hVC31+yOqhGuxOkT9FEafVz33LAa+XF3DRA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<4972e037-5465-4ecf-8894-e8b77f964bd2@intel.com>","Date":"Thu, 26 Mar 2026 06:47:52 +0100","User-Agent":"Mozilla Thunderbird","To":"Jacob Keller , \"Loktionov, Aleksandr\"\n , Jiri Pirko ","CC":"Jakub Kicinski , \"netdev@vger.kernel.org\"\n , \"edumazet@google.com\" ,\n \"intel-wired-lan@lists.osuosl.org\" ,\n \"horms@kernel.org\" , \"Nguyen, Anthony L\"\n , \"pabeni@redhat.com\" ,\n \"davem@davemloft.net\" ","References":"<20260325063143.261806-1-przemyslaw.kitszel@intel.com>\n <20260325063143.261806-2-przemyslaw.kitszel@intel.com>\n \n ","From":"Przemek Kitszel ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"DUZPR01CA0294.eurprd01.prod.exchangelabs.com\n (2603:10a6:10:4b7::13) To MN6PR11MB8102.namprd11.prod.outlook.com\n (2603:10b6:208:46d::9)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"MN6PR11MB8102:EE_|PH7PR11MB8551:EE_","X-MS-Office365-Filtering-Correlation-Id":"2be4396b-8cae-4069-74be-08de8afb3b64","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|376014|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n MPqAct1nInAi4kQypwvl6XN7xIb7t2yQdFpvGp0+gMpbxUo3LBrqrth1y9KPB7o3Sxxj2fc0M7Eiofmq8kXjSVQMm0uiZ/4kbvXm18la8ILWy9GFAUajzUvFTT/ff24t3sTGZKV3DlvGUWBSbCgz1j7e8rLQnnc4wNbiZ27824RL+tdPPSvLbja3eui6sYynMvrIHWWQGUgIgjpK3SGZFt4dKT7Tmv1XUooAiHnup4T3YByRvv1DoaQ7t3G0e9zhYWlJWCmx1YcmPIp1UJoqRCeXVTzNlgkP42VNuY05FRind/4SJ7qBljT9Mb6e9OspArklbmmYz33pL0oSGijA+MkBmQhcjydcC0XJyMZnNuCfUrxx/sLzcyehr/oUs2sFADfIQ3S7ecm6w61G/BLbgSpo4QjSd04RnsPV2D8xoMiMxexs9ffrpE7mdr4pxKDKZOyvZbndEC/soxxzjlxsBO1bLASAX7k/RKoGvCom9SbDMY5zlvCytBNWieckUMjtGflBYCopQhP6zZoW3XkDdht1/gj2rhNJd/SdcjbjZRBFNGjGza2KQCbI8hIjot/DL/nRh+Z1C7aJLU3I97QzzxsPG7Qm3yFTZCBzsBhRQrqTMIRaWOG/I93msQyiGvuMYKFaHSxD/1PV2mOITHbUIre2xJc4y0gR1Znd+Ll21cSvOpIQmj7yFcAhiW/25vc56Kd+ICvFpQStX3nW7wPXHEj8OEi87F07DWFiNzksqRM=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MN6PR11MB8102.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(376014)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?NKslHyB2GR/hNVaOiixf6kFaiTx1?=\n\t=?utf-8?q?n/BTBLLbCEnM9d2k4pS78d0tfNxdTrvYAyN3Hp8IFpm4WQF7XrJZnbE4/VgNa4Aui?=\n\t=?utf-8?q?T3aQe8EVJLyCISkxFURY0B1MUkfV/AqAspeI+TlQiGUCZU/eP+aJZPF3ccmZZIDoe?=\n\t=?utf-8?q?2YewzqCaW8UrVyoWdfDdrKBkwBOhbHUFNIRAQe+pkkfT5iBRFPiwldCmfqKbtVV8A?=\n\t=?utf-8?q?yT6AwXJBYV2gVleAq8gsCaQxkVHQa3zXvtudbg3aFXAVnTRkdKAN01xu9OjcfTsSR?=\n\t=?utf-8?q?PIOF6pfkIYuzpb4EZJrtSzaEEucH0PHWG7mwQfa0r6pEMmVFix690iQ73BHCeGbjD?=\n\t=?utf-8?q?Qj6M2mTVy5av2Ra+xaWwcTQSC8MQe3bHVSkt9aSGkDj3KHQig5d1jwiCkMXenuwGu?=\n\t=?utf-8?q?NtQJYNNZRfrZyAy2yxpmKvHyNEabCI1WWlA/70sgCZZm+wvFvShIvab5PWafA80XQ?=\n\t=?utf-8?q?AWGOvFvCOcwmLJda0RjNsId02QVXl0Sb2/lxjokNqeP6db2Iw3WvQAfqnUyKzB9St?=\n\t=?utf-8?q?PMc4wHrKgHg7rAzI39lSHe8S1wwbQmsD9Jjc3EeQq6UYG3Jv1hVaojntVck2yTTWw?=\n\t=?utf-8?q?7NnO3fYcpva6Zxxe9T0ZmVD3xaT/0AP/MW2bg0zbH553kxMYusER96KiFk2S2T0Zc?=\n\t=?utf-8?q?sPOSEF6ZNRczdcogMo5MMFzLhqNSZPMROaVJbDLlRB93AAIsw3iI9V32Zt4lApHWF?=\n\t=?utf-8?q?DWGbg+YzPSfRS2G4uC7e1q/ArcaJA0iXX1x6ye275qvxpmzSGfYX80QlPQ7I+wkOu?=\n\t=?utf-8?q?TbGY4bbRxfZ2BMV/cAcaTYbadY1p3FMEyUeGQyfWp6ZlB2cwEtScq6rxReG/TMGsY?=\n\t=?utf-8?q?wkt6U4scrlDfDlEt3ZGcXwQzOzZWCPJNg0ZU8+doi3esLmpsZf5e3cLZFpA+O2VQz?=\n\t=?utf-8?q?dxRMR8VIhm00XTigBvOD/C/90XLxCmjTDFxD7Z7Iv74ZMkzWKw6UnR8KQ0g3EYEe+?=\n\t=?utf-8?q?XGkNGLVJsZz8HoMZD5AJW2VtYp5NptL4hLJpJZnUa+L5PgxXXlVKANY0PLz8hXgDt?=\n\t=?utf-8?q?vQU1HRdfT2SSGUuV5vqbeTc9BM1r+0JcUm3nZNuzM5igZ8xbGv+62xBKlr59qfBAm?=\n\t=?utf-8?q?FoXj1Xw8adkMzoHmRCa+ikR5VHwoa6dyJmNgsOBgT4Ebt8a7GZBdRNJFK41qQ0J9g?=\n\t=?utf-8?q?yFBYfuXWHZ+n2LU8tqwYaSJkcjgOwjU+2jSbeFgwoNSobqa29fESRJEpy729lt8t1?=\n\t=?utf-8?q?7NWOvcs7LcVKHERhsGuGkUvsVk2sLdSboZpa6CqusBl9bKIYgQuAHj/jEoiQ6wDXk?=\n\t=?utf-8?q?YnzgqLijLboUV7cUjwoLI82jB6u3vppsDpsCjlrSaeeQISSBIBz2z4igjJtUBOohv?=\n\t=?utf-8?q?iruRnEtC0Nxx02VHnARX+/GKpmnH/QiE4usuvuezBZc/fgp6M5QQyaUuxGHEJVKfN?=\n\t=?utf-8?q?AKPSVg9E4w7tWm8GOgsU3WFyMAVt6u9O51EiMVvIQhT7/6Q2I7bemPm6B8qoy42ZX?=\n\t=?utf-8?q?B+7DkPbifxPEbnSLHmRg6kcj2g+e6RCY62/2gVDZZ75U/VoCkFE2w+oS6ceVtETCw?=\n\t=?utf-8?q?zZzg+hK5NJduMpR5ojXm6MYIRCn8LnbDf+EqWzcZCpcuQUX7OnRwXsX5FwB8qMtDC?=\n\t=?utf-8?q?LEmSa6qCh/sMzmhXha7OvVEkzKx+6JCG8Qm32xI2YZEIFAyLuE8IQYVrdpucnqfta?=\n\t=?utf-8?q?Z+R52/ce9iv7aht9JMnkdpTRvLyJo7i8mWbpJSSZQ+wmp4xsOL8Nw=3D?=","X-Exchange-RoutingPolicyChecked":"\n N97LQWHiMbJKVYNHpZJDg8M9H0oX3DkbGMSNwBv00XIKo4n3QRd8Z7DfL5clR9ZbqCjpll3oMRME6eMaamYiLv0tYFWVQtPQGW1SvDYxqfXnDzy+7jfsmtzxz2VyfkJj7ttQIyUmtGHlEKOrfkoQD7Lt/SAuJed571WomrIg52E2ok5BZqoFTa537NL6931Zvqq86i26T6OfazOJ5r6ba12wds6RItIZqECJzblbW4n9ysDsgxpuhaoQfUAb/9ZCYeVcceuhZYwvSlhva4TDp3sGtypjiQoARx9Bh0c7iojzsF8+9iMtapfu2jvJVbb3O6CXF0aRA1UtPzTo+dBY4w==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 2be4396b-8cae-4069-74be-08de8afb3b64","X-MS-Exchange-CrossTenant-AuthSource":"MN6PR11MB8102.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"26 Mar 2026 05:47:57.3411 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n 3ox8wHJnBmT9N1jehZdNKapNJewXtTd//7KVDk8PUd0y+j3UJqEVfiiE/P++WHjIFUP3x2rHmgB0lClTF3ee9gQXTSDoObtbkYrzKA5HJVg=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH7PR11MB8551","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774504087; x=1806040087;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=tD8kuXWf2YHcFxJROqC8pKxYoD/n2QwiWoeSKOSyz64=;\n b=g9i0Gzzxd2eEM2EXoHNWmKljARKB2dib4u0tbcW8Ic76dvb9yQtJKcNQ\n tFyKZPdgEZTFatIlUunzHxxz2suK8BRwdEUvwmh1pw2mfJt5z2r1mT5fC\n wQExR99Hydz429rc+bnCOSXh2ufLT2/zeySC5VtY/fUKhRedXnq83u8Yd\n y6QeJP0tVqI3YImBN0zsNnAAxfHO8Sgz/kJ0Unk62B8SwgCb7lx01XJjU\n EtQ+RSv3GhSoO21nh8kpf5mK1CSbEsvhEC0W33raICD5SQ+AExY4WmUmb\n 8i3383NGYeaSpDezDSSAEwQR0xaY4+3rISjNlDhNRhdQieRUSReFEBNr7\n w==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=g9i0Gzzx","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3669968,"web_url":"http://patchwork.ozlabs.org/comment/3669968/","msgid":"<20260326143808.1fd69825@kernel.org>","list_archive_url":null,"date":"2026-03-26T21:38:08","subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","submitter":{"id":77159,"url":"http://patchwork.ozlabs.org/api/people/77159/","name":"Jakub Kicinski","email":"kuba@kernel.org"},"content":"On Wed, 25 Mar 2026 07:26:52 +0100 Przemek Kitszel wrote:\n> Current API makes it possible to access shared devlink instance's priv\n> data:\n> \n> \tvoid *devlink_shd_get_priv(struct devlink *devlink);\n> \n> but it is easy to forget (especially during rebase from \"before shared\n> devlinks\" era) and call:\n> \n> \tvoid *devlink_priv(struct devlink *devlink);\n> \n> which even has the same signature, so it's hard to catch the error.\n\nThe implicit conversion may make things hard to reason about.\nAre you sure you actually mean that it's \"easy to forget\" or\nit's easier for OOT transition?\n\nIf we are worried about misuse we should instead add an accessor\nfor \"individual\" (better name welcome) instance and WARN_ON()\nwhen devlink_priv() is used in the shared setup.\n\nOr add a third argument to devlink_priv() which will pass the size \nof the LHS ptr, and warn on attempts to access priv of the wrong\nsize?","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=CrqZLOJh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhcZv2D6mz1y1j\n\tfor ; Fri, 27 Mar 2026 08:38:14 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 6CE8140FCF;\n\tThu, 26 Mar 2026 21:38:13 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Z9_yHnVpjlAv; Thu, 26 Mar 2026 21:38:12 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id A9DEF40E95;\n\tThu, 26 Mar 2026 21:38:12 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 38C42249\n for ; Thu, 26 Mar 2026 21:38:11 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 2B0C740E95\n for ; Thu, 26 Mar 2026 21:38:11 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id bvOEhY1hX9L2 for ;\n Thu, 26 Mar 2026 21:38:10 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 850FF40FAB\n for ; Thu, 26 Mar 2026 21:38:10 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id EAA8840C33;\n Thu, 26 Mar 2026 21:38:09 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 4F649C116C6;\n Thu, 26 Mar 2026 21:38:09 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org A9DEF40E95","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 850FF40FAB"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774561092;\n\tbh=+Zvg/ouTTX5hfkCZKmKPm0sfVNDHyK4iYrrSKx2SXCg=;\n\th=Date:From:To:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=CrqZLOJh9X8t5E4dvG+L+6YISm6IDwq9aXgS3aduCE5USZ2ev5dpwIViMdbrSc87h\n\t KRjMJcvhLXvIaf9cRC2bHxENbtowpLM+m6XYRlDuszBBAGldlc+iCUaeGwLkDSpWQB\n\t FGoBQFWfkYlxwAKo+1KAhneZB4kdAL/SBvC+wxYIYYPu1wmo5M0vwjhMl+aCHFjeBQ\n\t 9a1BbEFTzPnbw3W9BG7qImyOz8y+IuLaM9wvYOMQHDfOgCYMVdG8wT7Sz7WX/PQ2xh\n\t f31H56omrs3GWEqr/hlRjJAeQXSqAtpD3K5z8GV9ugMIZTXxflqmvOKoJ/omjq95nS\n\t yzovXMn7SAjwQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=kuba@kernel.org; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 850FF40FAB","Date":"Thu, 26 Mar 2026 14:38:08 -0700","From":"Jakub Kicinski ","To":"Przemek Kitszel ","Message-ID":"<20260326143808.1fd69825@kernel.org>","In-Reply-To":"<20260325063143.261806-2-przemyslaw.kitszel@intel.com>","References":"<20260325063143.261806-1-przemyslaw.kitszel@intel.com>\n <20260325063143.261806-2-przemyslaw.kitszel@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1774561089;\n bh=AKkd3ppFc84ObBdwBC0HhQtk41jJEhFN8N8H316ksdk=;\n h=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n b=SxUuXfQ76qYfBkJJ9Y9lfUH3N5eSzipqbgOJ7ENaF5deO8NoA2r68B/lPWt3deX21\n O7ioay7Qs6A5Yk63Rhzx/y2BOJd6NcmTyPP4jzENgsu9cl7eqGfQP2X8kvee7fui2l\n EMZrXlQXqPKhY8/sDRe1sFfpW03SNrPj39lMQkNlqxevn6REFYh4ihHLQwoB8mGrIU\n X7RLR60SPriBcXfdU6QZCYoG8lBlN3rGYECTRqnlqlJJZBarq0iLe7fbI4gB2h/SUU\n m+68KmCwcmeZ7bfhG40d1qcS1OrqG5zynoLRubvHTpyYv6ILSa+nASkZV63Wt275ZA\n nxZznDuKHL5Pg==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=SxUuXfQ7"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Jiri Pirko , netdev@vger.kernel.org,\n Aleksandr Loktionov , edumazet@google.com,\n Tony Nguyen , horms@kernel.org,\n intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, davem@davemloft.net","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3670121,"web_url":"http://patchwork.ozlabs.org/comment/3670121/","msgid":"","list_archive_url":null,"date":"2026-03-27T07:42:47","subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","submitter":{"id":85252,"url":"http://patchwork.ozlabs.org/api/people/85252/","name":"Przemek Kitszel","email":"przemyslaw.kitszel@intel.com"},"content":"On 3/26/26 22:38, Jakub Kicinski wrote:\n> On Wed, 25 Mar 2026 07:26:52 +0100 Przemek Kitszel wrote:\n>> Current API makes it possible to access shared devlink instance's priv\n>> data:\n>>\n>> \tvoid *devlink_shd_get_priv(struct devlink *devlink);\n>>\n>> but it is easy to forget (especially during rebase from \"before shared\n>> devlinks\" era) and call:\n>>\n>> \tvoid *devlink_priv(struct devlink *devlink);\n>>\n>> which even has the same signature, so it's hard to catch the error.\n> \n> The implicit conversion may make things hard to reason about.\n\nhmm...\nnow we have simple devlink code with a possibility of hard to detect bug\nin drivers, plus hypothetical drivers code that we will need to reason\nabout. I would replace that for:\n\"complex devlink code\", which will be harder to review, but then without\nbugs and with hypothetical drivers code that would not require reasoning\nat all (one API call == no decision, and no checking for correctness\nlater, when someone will be hunting an unrelated bug)\n\nAnyway, I have used \"hypothetical drivers code\" twice, so maybe it will\nbe best to forgo this patch. I will just call correct functions in ice,\nand we will wait for other users with priv data on shd devlink to see\nif they struggle.\n\nThe priv_to_devlink issue that Alex pointed out will remain unresolved,\nalthough it's easy to just keep the devlink pointer in priv (as I will\ndo in ice).\n\nThank you.\n\n> Are you sure you actually mean that it's \"easy to forget\" or\n> it's easier for OOT transition?\n\nI have literally forgot to change (written from scratch for upstream)\ncode, in the part that was rebased conflict-free. I guess, I was the\nonly person that were in need of devlink-shared, with code ready to\nrebase over Jiri's work. And I'm done, so there is not much relevance\nnow for this point.\n\n> \n> If we are worried about misuse we should instead add an accessor\n> for \"individual\" (better name welcome) instance and WARN_ON()\n> when devlink_priv() is used in the shared setup.\n\nthat would require the same amount of code as this patch (curr ver)\nhas, only with WARN_ON() instead proper value (IOW: we detect what\ndeveloper wanted, and give them big warning instead)\nI'm not interested :)\n\n> \n> Or add a third argument to devlink_priv() which will pass the size\n> of the LHS ptr, and warn on attempts to access priv of the wrong\n> size?\n\nthis could incidentally match sizeof(devlink_shd) :P","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=qkzoiQYa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fht0s6qf4z1y1j\n\tfor ; Fri, 27 Mar 2026 18:43:07 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id CE75561211;\n\tFri, 27 Mar 2026 07:43:05 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id KK3WitGsW0II; Fri, 27 Mar 2026 07:43:04 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5FC3961275;\n\tFri, 27 Mar 2026 07:43:04 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 348662D5\n for ; Fri, 27 Mar 2026 07:43:03 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 25EAC40BA7\n for ; Fri, 27 Mar 2026 07:43:03 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id IxK1AzBcf3qX for ;\n Fri, 27 Mar 2026 07:43:02 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.13])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 52E5D40B9E\n for ; Fri, 27 Mar 2026 07:43:01 +0000 (UTC)","from fmviesa003.fm.intel.com ([10.60.135.143])\n by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:43:01 -0700","from fmsmsx902.amr.corp.intel.com ([10.18.126.91])\n by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Mar 2026 00:43:01 -0700","from FMSMSX901.amr.corp.intel.com (10.18.126.90) by\n fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 27 Mar 2026 00:43:00 -0700","from fmsedg903.ED.cps.intel.com (10.1.192.145) by\n FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Fri, 27 Mar 2026 00:43:00 -0700","from DM5PR21CU001.outbound.protection.outlook.com (52.101.62.52) by\n edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Fri, 27 Mar 2026 00:42:58 -0700","from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9)\n by MW4PR11MB5799.namprd11.prod.outlook.com (2603:10b6:303:181::17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.8; Fri, 27 Mar\n 2026 07:42:52 +0000","from MN6PR11MB8102.namprd11.prod.outlook.com\n ([fe80::8d98:e538:8d7:6311]) by MN6PR11MB8102.namprd11.prod.outlook.com\n ([fe80::8d98:e538:8d7:6311%5]) with mapi id 15.20.9769.006; Fri, 27 Mar 2026\n 07:42:52 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5FC3961275","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 52E5D40B9E"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774597384;\n\tbh=bfShXbwTpZH24UxYagTFOkyHTAjdwxCRLB0KtykuLGI=;\n\th=Date:To:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=qkzoiQYavwjr9ajw1SC96S+PSulh62Cem/jPpwb2oV4c8m5cVZ9eUvnIp9k2n4ITp\n\t 4kwwd6CLOnyD9t69+BCAUz4NszXNXx0cxdmtZxSS7cjGEbN+YaDRpE0ymwuizCNWTd\n\t STX3+RuxrmuYsbDiDfav+ttIcFcokUaOiUgtZhWk/v+ynFfyYDKwO5icRSi+DHR664\n\t glyfWpYCGEus0iJP5/Bobsm/ZAoblSY2FTeKN9z8d1/bI3kGtkqiLHnH15BQ/mfGM8\n\t XS9JX7NK0WUOXbWNwCiMXcg4Mg//kz3L2dWNfihlJ9PosTxTZrBidm7J4MoFkeXMn3\n\t c4PCyEXdnJgYw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.13;\n helo=mgamail.intel.com; envelope-from=przemyslaw.kitszel@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 52E5D40B9E","X-CSE-ConnectionGUID":["24I3bbdFQSuqDlTPweValw==","T+RFb/0GTLeTPqpKAxPumw=="],"X-CSE-MsgGUID":["HFqW1qk8QayICqlcCKz5EA==","QkfB8WzpRnCPOzRVphTsnQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11741\"; a=\"78263040\"","E=Sophos;i=\"6.23,143,1770624000\"; d=\"scan'208\";a=\"78263040\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=CR8gXdpMWvAfBVBkuV3tOSIzCBlBAH9Iec5eWoxPDgXyMONkHpIVxFTUhAUnlq76Gve2qKXLt1B0zWRLRxthyuGRnc8vswmljOydyJdYHfUBHoXiNpcV6ot+atQBkiRj0V9Wkr+Ok9ISvXq8bwNe/8orqfMNtE/6/ilBltHzFjVnikmd/5zmO9BVAad2npLUKT7TiUeHyHfdlUra1QD5vuKT2AIM6O21DQdvv8nM7K+ZE8f6Ejo6eYzPsfzTKqrLZmXIv+1wjcYi7IUf9rP4omxz7mvN8wdwNG38sg4qEvplXc0YR+porvTVXgAoX4E+tI5LZZXxaQgXqDu3wKdUKg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=bfShXbwTpZH24UxYagTFOkyHTAjdwxCRLB0KtykuLGI=;\n b=axBG2v6sytb8csVBbbeL6DbDafV6N1xtsC0BPMsQNjqBjoBuKYNBmP9MgJs3befBAHH47bvybwvzvlamDIJbFv9Z+j6XlMfWnDiCGN95kZEHamassrGm5qgqmLxrdtu0ccplay7WSn9NO1w91JpX7SsldlsByzvkCnoWIIZhyZv1Gs73VIEjOOUsNKLVDVWa/9/bFfrThu63K5xE7CSqaSdH1KopvdFBuh3PJYBV5XQdEUpBYhrw0buHXhPt7R65jx4wjU34j+JBu4IRDb0MEex+v8zflR0IGSeM56KAAcs1AWfwF1GzHTFBFnHvbML13v7t0m3zHDfQ41O1vnAHzw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"","Date":"Fri, 27 Mar 2026 08:42:47 +0100","User-Agent":"Mozilla Thunderbird","To":"Jakub Kicinski ","References":"<20260325063143.261806-1-przemyslaw.kitszel@intel.com>\n <20260325063143.261806-2-przemyslaw.kitszel@intel.com>\n <20260326143808.1fd69825@kernel.org>","From":"Przemek Kitszel ","Content-Language":"en-US","In-Reply-To":"<20260326143808.1fd69825@kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"DUZPR01CA0243.eurprd01.prod.exchangelabs.com\n (2603:10a6:10:4b5::11) To MN6PR11MB8102.namprd11.prod.outlook.com\n (2603:10b6:208:46d::9)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"MN6PR11MB8102:EE_|MW4PR11MB5799:EE_","X-MS-Office365-Filtering-Correlation-Id":"4bef2057-b279-4eb5-37a1-08de8bd47356","X-LD-Processed":"46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|376014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n cDIOugWgpOeC/wbfNZdE3R/wqHuTKWF+jjz4uwDrLQjNnM8WdSoSLUOCMoDtw5zWseDjx5E4Gov0zco7wfkOeqKg+vpgT81ZVMohvWauyw2dlwwJAPLRarKDZzAMthk+GsJejKTsGLR3JxH3G2vu4BT24I/f+/AzhVx/UUtL9tg9bVUCTeYWcTeOBJN4b8ORRPKu7wdly2YkMebex5okkwDg3AROJtc6/oiRtpb8RAgypVOkaFl/iPmprdUBwU8/V5YObvz/epf6Oczl7qLEFbFlIiDCKsdL4xq9YtqafI+2vlnfK53KL0BUT8SF7X0x/jyh59I3drpvOKlP/VDco914GjzeRigM+qQ5Nv2V9kq1Rdj3Es97i9HFrgkVOJYKwyarV98CR3Ir2PLTbxdOjjtmI9kdpU5X90Z4yv2nk99dptjWo2oWIV3AmtQ0ga+RO5vKxVxUnoaKLybWZJuKK/2OQVLk11/tMS70BM2x7kXoeVZDEHIXTk5PZXoNfVpH+NfwnOT1Kj6QGux5SygBz2nydq6m6q5x3N+2N9WYrR5bNExsHCE8MDbNkpektwi/W507Id7AgkRQowwrOEzaVTZHC7e1kLRkUGTWQRd1ytWYErmZM8yK6SJOWsotUN1lgtCvqvVkLlQB2YkqPugafNF+3BYCC2V5mlj9N8eGXlxDN1QK/M42MrukgBxL7rCPUVJU8pK8J9yrb+hYFl5wD/hSuSQiLwq8Zh1nFVsKHD8=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MN6PR11MB8102.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(376014)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?V6KBwDDSh6bG5QjdRZZVRuj+g4Md?=\n\t=?utf-8?q?cEOJrUF3h9YRFAW7yqsPPErl6QJL45Og8SqnxTjdWfz9cS1l8gxo/YWuGZSIrjNnc?=\n\t=?utf-8?q?2+BDyEDZPtTuZonLIRYr8/4YgyyCZup5ZnH48fpSN9IXNaYGdQkd3RgCDS5WwFamP?=\n\t=?utf-8?q?P6wuzYmtYQ3lck0BF5q9q7WPgRlec0omzlFzHCC9AQcroUqLUK2Tl9HMHeob2uD/b?=\n\t=?utf-8?q?DlQM6Rg4VjFdiIFIYUC2C2QR85gKkSl5F/Bu00jvmMeiKCSnyXfUlX2bef5K94VLE?=\n\t=?utf-8?q?opcA2iT1ZRgWypAiIxNhGXRF/975FM4eMxhqMifSRED7gg796GKlHDrmeZuOAyz8G?=\n\t=?utf-8?q?X/BfQsgQc1YF2H+Rzfy92k1YwUlxInNmfgn9Bilwa2d/p+G6DXO56CjL40g/R7Oxv?=\n\t=?utf-8?q?TRTuCuwz1t603tjp4WwMpCqd/g1SylM80pviydZyvxi2FAfddVGK70dPbwfvpQwmg?=\n\t=?utf-8?q?Q2/UzW6nNmLgS9yokxeVPg5O12R4anBe0yOBWdIZMf/3j+Gq5FyUbloC8ALV62se/?=\n\t=?utf-8?q?oraeGtYCsj+BliUh4Kjdvlow6sFpvzCaTJaGvSBjAzDEJAwA8MmyCYQt37fXK6Kvn?=\n\t=?utf-8?q?3oFK87YCZ1Q2WOr/qTndm8N3/gCpIQi2b1E41/fedqBsMYIpChlcDhaxidGYqdQ+H?=\n\t=?utf-8?q?Dj5uYJXu8oW6FPpLuX5RF7KHIL3ekiqqCnovpqqKnt2d8TYlh67ORZOMcG88GTbeM?=\n\t=?utf-8?q?AOCtNUHe94y2bCGuzktaUWbpoo0ZvfTmVfwOqBpCnHn3obCxI6YvvPTRU3pHwsM4F?=\n\t=?utf-8?q?0QJM8MdqliCvNF40NkLudFLCZr2zEBR6cnErG6ivOsRaHqv+w0F/IZ3T4F6uoCCIF?=\n\t=?utf-8?q?T2hoMkco1BmG1kuZvSuEeDIIss4qDjlrrpA6gKJ7p9iUSCy0GH4mvLRW5MjCRcRuC?=\n\t=?utf-8?q?vGxumhGoklhAD/rKEHqG9K0yDx9JRInJKqjD2QzbnvOOoZ0xh5p7bNIUftaHBX1RD?=\n\t=?utf-8?q?Wh0s0wzKEgxRjZeqiHo5OPJeIkqrZQi3BAM6MUEhrYwTalaR+vm+jop/dWgAWm0vO?=\n\t=?utf-8?q?wMiMrIU0yuem5xma2zJQ7lu1cr+btemCRv8QqzomFpL3Df3j9rZXLojoKPV1K2GBE?=\n\t=?utf-8?q?FOejVrabnHrOurJmiwn0oxWx9F15x0TearylcZQ2obn8YkGRq8emkmpI5fKYDDnYa?=\n\t=?utf-8?q?NMhWjW9pp+5RjN/IX2FHkmZluybXFqAWVcJ+EPuD0mx+zn/x8+jMtdmqnknHah4Ru?=\n\t=?utf-8?q?b8nms1mKapY95FacDuc147uJJtuMoYVYpE9BBP2EZaBgH8oH8741DRYta5IaVSikQ?=\n\t=?utf-8?q?/y3W02GYD0ZvaVnc8PULOK/MoL2agd87PfFqNTu5yCmk8lOXtjbmCxya64qPuXAYL?=\n\t=?utf-8?q?iJdYtLTm5vOp6VYNuawQj3BTebS2JXV7NIfxF1MNfNcp8aWGJd49pN8BGftvGrFdT?=\n\t=?utf-8?q?hoBn4j3dYRa5HEzJEmDVOU/SUlMMqCS+Yf4i72gIq22mc3+ERj1OYP0P4/8g21XuP?=\n\t=?utf-8?q?mAgTXDTLNCwJp8A11VrrXucPMFLRu60C+EmkUpCH85qlSorYYskWzJ23qp7ytoBgR?=\n\t=?utf-8?q?KRDQUjUQAc+XlSGjCNu+YZbpqCi5Ghya73LSo+/rovuqCkJoLaHdWn+hYkrEkm7iP?=\n\t=?utf-8?q?LmtFbs+BkPnvK12q2By+khnzl99NGCfTWZZdT+6B4PY5GUBlIlp4DNgao/0rephm5?=\n\t=?utf-8?q?90Zkt1g1O+IS5ZBHSzIylmhJ749+iXJr/OSH7dMgmdL5JqI8xpIZ0=3D?=","X-Exchange-RoutingPolicyChecked":"\n U7LYw415EgWn3uKz0kdqCE8UX80VkAbXVsX0qQNuYP13K1FTe75BoI5V2yTNxt3kvLkoDuJfIFRln+5VKTYRLEkxBX+0fwzWyjIEyzPseEnuIilWRd8qitNIuZ1y+iH0oPzK0GfEZ/pDEMRitHM/lL/L1z97KDWFdrt0vxIayx3YwYNIH/Sf4Ewd7U8juvXUm40i7rns3iAOmVodaYhpt8zXDvtboiAXqcm5dTd1VaKzz0wnj333M/Jnlz/H2Hf2DFWhsvQMwvSrLEobtWTWx8tFMW39PYmwvULAIirIGQY5rpaHS3TYHkiRwBxuTPpFkw/M0pfi7S06jwuXP2OXAQ==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 4bef2057-b279-4eb5-37a1-08de8bd47356","X-MS-Exchange-CrossTenant-AuthSource":"MN6PR11MB8102.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"27 Mar 2026 07:42:51.9817 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n bsDo/Enwzb2uu2rjhaBoKlhq00ZBGy6r8IcBvkQJ7CJS3tOoilyOaAqNBGwRo3kZMlAZVTMUHKbMBVnVhMeA6PMO0wZF8duxOTktMLglMYI=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MW4PR11MB5799","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774597382; x=1806133382;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=ikBUy7C719IVGCkGNYVpVDsCoVR+9DpOFIx8YmJVSww=;\n b=W1sqYWez6y5FENEwWFWGDyX4yY5uIhP8ZT+P5XrEj/3Zn4ZMgGUrniqF\n 0b8W7wAQFMISkqh24t7cfa+Htca/Q2RuJIETplHMgHfePJaY86vJqmFWv\n WiiWO+e0ASx40TueEW7EUwvTanYJcxeNXwUWQpUNJPao7/wj73gBnDT5h\n Z8K1joccWsBt9db0SKgH6cLElvgS2jgJTj958MFT2CA1gU8v5joqgthwG\n H4xJ0Wl51TekhcCAJcYWXdLfqewXEpHUKEbyvZymp7fpZMet8cOgTjqaa\n LEcAoNtjm78JahJKAJIHnkzYCK3zOUE00wrMQXWelt8v3EpcaI90MhUe/\n A==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=W1sqYWez","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Jiri Pirko , netdev@vger.kernel.org, Aleksandr\n Loktionov , edumazet@google.com,\n Tony Nguyen , horms@kernel.org,\n intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, davem@davemloft.net","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3670608,"web_url":"http://patchwork.ozlabs.org/comment/3670608/","msgid":"<20260327164718.72bf4b65@kernel.org>","list_archive_url":null,"date":"2026-03-27T23:47:18","subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","submitter":{"id":77159,"url":"http://patchwork.ozlabs.org/api/people/77159/","name":"Jakub Kicinski","email":"kuba@kernel.org"},"content":"On Fri, 27 Mar 2026 08:42:47 +0100 Przemek Kitszel wrote:\n> > If we are worried about misuse we should instead add an accessor\n> > for \"individual\" (better name welcome) instance and WARN_ON()\n> > when devlink_priv() is used in the shared setup. \n> \n> that would require the same amount of code as this patch (curr ver)\n> has, only with WARN_ON() instead proper value (IOW: we detect what\n> developer wanted, and give them big warning instead)\n\nI guess I don't understand why you're so certain that you know what\nthe developer wanted. I'm of the opinion that the \"individual\" devlink\ninstances should not exist at all. Y'all want them, and claim to have\nuse cases for them. And yet, it is somehow not valid to get their priv.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=S21qA1Cr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fjHPY1bJqz1y1P\n\tfor ; Sat, 28 Mar 2026 10:47:27 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 17FBD411B1;\n\tFri, 27 Mar 2026 23:47:25 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id xxBZOq1xbfdw; Fri, 27 Mar 2026 23:47:22 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D0F64411B6;\n\tFri, 27 Mar 2026 23:47:22 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id BDF1510F\n for ; Fri, 27 Mar 2026 23:47:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 9AB5540752\n for ; Fri, 27 Mar 2026 23:47:21 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 8VtxPUTekPhD for ;\n Fri, 27 Mar 2026 23:47:21 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n by smtp2.osuosl.org (Postfix) with ESMTPS id CFFD0400C7\n for ; Fri, 27 Mar 2026 23:47:20 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 196D6405D2;\n Fri, 27 Mar 2026 23:47:20 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7F5A4C19423;\n Fri, 27 Mar 2026 23:47:19 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org D0F64411B6","OpenDKIM Filter v2.11.0 smtp2.osuosl.org CFFD0400C7"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1774655242;\n\tbh=zxFh21zA0f1E32WvYWkeJsNVFM+NjTzu0tGKpTPaBHM=;\n\th=Date:From:To:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=S21qA1Cr2rz1MDnAOm2KiArapJaeVol11XjzozNXVC6hcPTx/bL/Ke3KkpoVu5gx7\n\t NoDfJWOFuKLpQnbJr6px9V5J4snbF1wIrpElAgxIuaqjVRIqx6eX2k1rZJh2xn/jrt\n\t 0BIK7XAD9sj++3loLnYQizqaxhHsEFz8e2ULBswk1kb+/ThqW0v8OFnxVjofDv7SMA\n\t H+LHWrujMLQxUzZVyi6+vdJEEQf5GuBCQTT1MjPtuXcKkFZff1AqLzv4vAUsQ8EpM3\n\t o/TIMWtlbUmIUnuaPngu/nl52iUN4Z2KEfzxP5/oeRv9W2aqiWnCF2UeBuK5T46ieH\n\t Zr07ZZsQUeEGg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=kuba@kernel.org; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org CFFD0400C7","Date":"Fri, 27 Mar 2026 16:47:18 -0700","From":"Jakub Kicinski ","To":"Przemek Kitszel ","Message-ID":"<20260327164718.72bf4b65@kernel.org>","In-Reply-To":"","References":"<20260325063143.261806-1-przemyslaw.kitszel@intel.com>\n <20260325063143.261806-2-przemyslaw.kitszel@intel.com>\n <20260326143808.1fd69825@kernel.org>\n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1774655240;\n bh=LJC6boXcVhCOgdtGYeqxWCvOrumqAszQh6+n3gXpp+A=;\n h=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n b=km2qaZOBKVgNrSzyi1afKAHfByPv2flHHCdCWRdIpAQYPxYvE2C+GMSKp5spf+21s\n 6NVoLUMYoVLr9HU9okRXyJoZW1qzcWnQGKy0CcV/YsyjRKtFAdzGEC3K7Qnn/HEiI9\n wfhf20Rr5klNZmdq8/X5BwVXTayxGCVeWGF0oyjk9lW3QkfVb0tVHDSMgzhNLwoqQ3\n WWRNU9yNyiLRVZA63p+1ChWhOyvWmturIlJJxB3iMdfuOMv/ZBydBg5Dk1SodZQEFv\n RDdIYZ93jtZq8qHj9tzybuzIkVr++WgjrPpOAo15epn1mA4fbtJ7tFSf/A6BNauO0F\n h31Z3ot0FVk1Q==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=km2qaZOB"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next 1/2] devlink: unify\n devlink_shd_get_priv() into devlink_priv()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Jiri Pirko , netdev@vger.kernel.org,\n Aleksandr Loktionov , edumazet@google.com,\n Tony Nguyen , horms@kernel.org,\n intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, davem@davemloft.net","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]