[{"id":3669780,"web_url":"http://patchwork.ozlabs.org/comment/3669780/","msgid":"","list_archive_url":null,"date":"2026-03-26T15:10:25","subject":"Re: [PATCH net-next v11 12/15] quic: add crypto packet encryption and\n decryption","submitter":{"id":61073,"url":"http://patchwork.ozlabs.org/api/people/61073/","name":"Xin Long","email":"lucien.xin@gmail.com"},"content":"On Tue, Mar 24, 2026 at 11:49 PM Xin Long wrote:\n>\n> This patch adds core support for packet-level encryption and decryption\n> using AEAD, including both payload protection and QUIC header protection.\n> It introduces helpers to encrypt packets before transmission and to\n> remove header protection and decrypt payloads upon reception, in line\n> with QUIC's cryptographic requirements.\n>\n> - quic_crypto_encrypt(): Perform header protection and payload\n> encryption (TX).\n>\n> - quic_crypto_decrypt(): Perform header protection removal and\n> payload decryption (RX).\n>\n> The patch also includes support for Retry token handling. It provides\n> helpers to compute the Retry integrity tag, generate tokens for address\n> validation, and verify tokens received from clients during the\n> handshake phase.\n>\n> - quic_crypto_get_retry_tag(): Compute tag for Retry packets.\n>\n> - quic_crypto_generate_token(): Generate retry token.\n>\n> - quic_crypto_verify_token(): Verify retry token.\n>\n> These additions establish the cryptographic primitives necessary for\n> secure QUIC packet exchange and address validation.\n>\n> Signed-off-by: Xin Long \n> ---\n> v3:\n> - quic_crypto_decrypt(): return -EKEYREVOKED to defer key updates to\n> the workqueue when the packet is not marked backlog, since\n> quic_crypto_key_update()/crypto_aead_setkey() must run in process\n> context.\n> - Only perform header decryption if !cb->number_len to avoid double\n> decryption when a key-update packet (with flipped key_phase)\n> re-enters quic_crypto_decrypt() from the workqueue.\n> v4:\n> - skb_dst_force() is already called in in quic_udp_rcv() on recv path,\n> so remove its call from quic_crypto_payload_decrypt(), which may be\n> called without RCU protection.\n> - Remove the incorrect (void *) cast to quic_crypto_done.\n> v5:\n> - Use skb_cb->crypto_ctx for async crypto context freeing, which is\n> safer than using skb_shinfo(skb)->destructor_arg.\n> - skb_cb->number_max is removed and number is reused as the largest\n> previously seen and update quic_crypto_get_header() accordingly.\n> - Change timestamp variables from u32 to u64 and use quic_ktime_get_us()\n> for current timestamps, as jiffies_to_usecs() is not accurate enough.\n> v6:\n> - Rename quic_crypto_get_header() to quic_crypto_get_number(), move\n> key_phase parsing out of it, check cb->length when parsing packet\n> number, and update all callers.\n> - Use hdr->pnl + 1 instead of (*p & QUIC_PN_LEN_BITS_MASK) + 1 to get\n> packet number length, and remove the unnecessary the len variable\n> and QUIC_PN_LEN_BITS_MASK macro from quic_crypto_header_decrypt().\n> v8:\n> - Move skb_cow_data() from quic_crypto_payload_decrypt() to\n> quic_crypto_header_decrypt(), as header decryption also writes to\n> the skb and is invoked earlier than payload decryption on RX path.\n> v10:\n> - Fix double period at end of the comment for quic_crypto_encrypt().\n> v11:\n> - Note for AI review: call quic_crypto_aead_mem_alloc() after\n> skb_cow_data() as it uses the return value for nsg. If the allocation\n> fails, skb is dropped, so no rollback of prior skb modifications is\n> needed.\nThe AI report on\n\n https://netdev-ai.bots.linux.dev/ai-review.html?id=1624d906-c0b6-4e12-a63f-5cbfc51b660e#patch-11\n\nis already explained by this \"Note for AI review\", not an issue.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=jg1jV09J;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10553-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"jg1jV09J\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.210.175","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhS174qYCz1y1G\n\tfor ; Fri, 27 Mar 2026 02:11:55 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id BDCA03029A86\n\tfor ; Thu, 26 Mar 2026 15:10:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7A1E4401A02;\n\tThu, 26 Mar 2026 15:10:38 +0000 (UTC)","from mail-pf1-f175.google.com (mail-pf1-f175.google.com\n [209.85.210.175])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B32E3FE374\n\tfor ; Thu, 26 Mar 2026 15:10:36 +0000 (UTC)","by mail-pf1-f175.google.com with SMTP id\n d2e1a72fcca58-82a646c96bdso895436b3a.2\n for ;\n Thu, 26 Mar 2026 08:10:36 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774537838; cv=pass;\n b=ci45TNltaewRd9idEtWvtFvbziNf92DwPI1fepTWADlxDpfAx0Nv1+VhH/wQ7VXDJAxGCilreqc/Tmkh2UzG7PlBhi9p6XHYCsNW/WOw1fNwk9PL4qquMXO7gVYQB8uE/8dpqpwRSWR9pXQmEz14LuluazKzXu1biCHJhre9mYs=","i=1; a=rsa-sha256; t=1774537836; cv=none;\n d=google.com; s=arc-20240605;\n b=SngrF1x1thf09rh2IUocWtor6qlyhv08pmZ+lbB+6v3qHgErbbBohMKVZXmvR2EaFl\n bxV8l31H4J/4QOoqLFqO88yiK1gbCM63YEOz2Bv5rfk8AZj1lbTNna4wRGPtTGyGieob\n aWujo7ot8kt78i1PTe1su9WTAgNjbyBkuDi/qBcI8aZgZkpNkYCVrN5YT0fbtW0rMIHt\n 433CQ11bHEUihbvlHdoyCHzl/Nne0n62L3yylekbVB0FTEjlYIOVP+F0Kap298e2i3Kb\n lCA1BTvKqQxKxYglabDYT/riddrwykhahFI2ceDia1BeGWcQacFpDJkKY7V2ISfkLtLk\n TGSQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774537838; c=relaxed/simple;\n\tbh=qKz7GeQxZ8sggDV0R8PRl9sGjFfikJ4/Tqa/hBGF7AQ=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=JC0M7XFZjdLb6bRhPTvhPqsDaeIUz0YSC16YxmStWIUG52pUOesRf9PzmHwqPPZVR2PHC+rKkCVZRrWUO/a1r4cTp7SFlYqqWoiB83d9H8OQGE6jxT4La5a+16jHNUd2bUK2hexYg42eCkOuGNzkellzIQBkINzWvO+gxSOxlC0=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=mSefNftQWki8QitGf1y0R01W7kHkanHSPeWJVPTl48E=;\n fh=zp468FR0Y0e27gnln3uM+1EVME+XXuY9QY+Qbu4qqNc=;\n b=XtbC9zQwSn8yKcCSrad1WaK4m7RNVeWWMh1OcqiLunn7GWv/yafV5YpvxSpYH4+s0f\n c4oFPSFc3lQidduIYBy+pI1VVda/IuXUfqxTuYZPHwaeHGbH0mqbI417LUJXjgTH3jvu\n CUUBJxkh47MAHGRxPzjNWExNFHwHSg0BOaFMpIHLGlLqJPQprj34gxMFXZvKP5Elnyc+\n kPD0VSV0FswqhxSQOjYQhtTWxgehSXsz3t35QSi+6e9J6KFd8UM9ic5WR9E5ttSC8zwk\n JJRf3Jko6jKac0qKw1yFFrGUOplrS5hdErR4vTqwVqYlYZzb3hRgFpuppwDg6+9AFt3F\n jo0Q==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=jg1jV09J; arc=pass smtp.client-ip=209.85.210.175","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774537836; x=1775142636;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=mSefNftQWki8QitGf1y0R01W7kHkanHSPeWJVPTl48E=;\n b=jg1jV09Jlyvu9VJnn0BkZbueVt/NGyBB2FghscoHIp9UF8ZyGTghcW+rdnPobuhmc/\n FuJOmhCkQcpHBFZnZWTrkQxfDPvFq2/LldKLRP9HsQy7tD0ax5c+bPwL0C1Kpz3Z33ZX\n UJlY1CoK7KgHaNuhqYMdjdVuXdDj2LqzxvBhHNDvVsUO7jD+lESTXVoIOVCUJDtmB1Nx\n spQbUGPxZKTIxF355hZ+KhihLf9boPKhj1mHoDYnWzrV6Rrrm38oyM/tWfKJRPA4600o\n owycm/4gvYNEOXyWUyUIoi5n0R7FPn6L385IbnBt4B8nYWFUSpJCAeUbapJxOPJ9QO2P\n qTfg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774537836; x=1775142636;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=mSefNftQWki8QitGf1y0R01W7kHkanHSPeWJVPTl48E=;\n b=Elu8tDxNQvY5xScUaBmaKdriCL9E8fXQTa5yuK+jpw43z1kbxhsINcxlpEhcyUdQ6+\n 3CSHDZY7jI4pJHX4iVLF4pl9ThehYicvZpGR7gexpqs0U/I8PiOPfKIXQZM1VGfN5JNL\n 5r0LrkCDrgVD9Mh0/K+pTmXbLc4hlcQvIGKz3t+qbDMpD9PTm8stGi+j9OsS5jingECw\n TMY4ng4L9rc61stTy6LMTKsHyiTFeIsa8f09CbBXwTuulApA7xjzECFoA1JEWh/G1AbO\n GZvGWfuIenf3DgZ+qdmKuJkSj3RhxZ7eYeBTUvOrWT+XGIpXL8v9aIjl/A0bjPQycPOn\n enyA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWsaESoQmgptca2Vs4GrqsC3YUwm1rciWlUFk4CF+ivUIanSIsAISn7ty5+Jcb37FXnhi+LN1iO3bYF@vger.kernel.org","X-Gm-Message-State":"AOJu0YyyuiffKLH2+0NDFiKB0kC7nyV3yfBGbEebejSg+D5R0SU7/xET\n\t5FCeUgcCJyWcmXLbNss/MeSt2eyxk7rCUKBA0Krlmo2/YchCmBNKF/Aq5I81Oy0LQcMiGcpcLCe\n\tzXmVmS9BYwRDvIYF0NGH6+mGCxw8+g/c=","X-Gm-Gg":"ATEYQzx6dSuNp+9FDeZhDFaSqifX03ks9ttbKBptlLBmp82EJQXcwyjpgFmKwabJLca\n\tcxdckmJnQmo8HlUIEnm6FM2LW6AyzjSUxhkbgDqxZ95YgCvOBaQzsDwOomHvFjk/2g11OFryJwO\n\t8cfutN8zBH9eqP+jwQp8gPSMnb03E1sXmGAXE7kHhqYx+Rh54otE1hv1WOqAV1K0p5No5o+v3Wd\n\t4XRNP8FszSsHdCDaSD/H3y2pkfIM475QEIlx9FPOlCFw/uu/CJlVQgAcnIDfqQmr3T1uBn+ZeTc\n\tcGahlSGvxPt3kU8F0CGTZnM1j3keMxqHfwf+bTBs2sENd2fuf827zvczdgg2dxvDgOstrzmwWA/\n\tAA/hx5T8jTYEQEodJfJQCJAZ0ctkXKhTKh+1dJIAe","X-Received":"by 2002:a05:6a00:2da7:b0:824:374a:13f7 with SMTP id\n d2e1a72fcca58-82c6e15f706mr8408159b3a.55.1774537836342; Thu, 26 Mar 2026\n 08:10:36 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"\n ","In-Reply-To":"\n ","From":"Xin Long ","Date":"Thu, 26 Mar 2026 11:10:25 -0400","X-Gm-Features":"AQROBzCHlIqDJYnoa1tW3FE7PgOFSLHI1Wh5jc_7MECEmTiUBtm70S0dHNsViq8","Message-ID":"\n ","Subject":"Re: [PATCH net-next v11 12/15] quic: add crypto packet encryption and\n decryption","To":"network dev , quic@lists.linux.dev","Cc":"davem@davemloft.net, kuba@kernel.org, Eric Dumazet ,\n\tPaolo Abeni , Simon Horman ,\n\tStefan Metzmacher , Moritz Buhl ,\n Tyler Fanelli ,\n\tPengtao He , Thomas Dreibholz ,\n linux-cifs@vger.kernel.org,\n\tSteve French , Namjae Jeon ,\n\tPaulo Alcantara , Tom Talpey ,\n kernel-tls-handshake@lists.linux.dev,\n\tChuck Lever , Jeff Layton ,\n\tSteve Dickson , Hannes Reinecke ,\n Alexander Aring ,\n\tDavid Howells , Matthieu Baerts ,\n\tJohn Ericson , Cong Wang ,\n\t\"D . Wythe\" , Jason Baron ,\n\tilliliti , Sabrina Dubroca ,\n\tMarcelo Ricardo Leitner ,\n Daniel Stenberg ,\n\tAndy Gospodarek ,\n\t\"Marc E . Fiuczynski\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]