[{"id":3669631,"web_url":"http://patchwork.ozlabs.org/comment/3669631/","msgid":"<acUQHCETMXaEtdK5@arm.com>","date":"2026-03-26T10:53:16","subject":"Re: [PATCH v10 4/8] crash: Exclude crash kernel memory in crash core","submitter":{"id":938,"url":"http://patchwork.ozlabs.org/api/people/938/","name":"Catalin Marinas","email":"catalin.marinas@arm.com"},"content":"On Wed, Mar 25, 2026 at 10:59:00AM +0800, Jinjie Ruan wrote:\n> The crash memory alloc, and the exclude of crashk_res, crashk_low_res\n> and crashk_cma memory are almost identical across different architectures,\n> handling them in the crash core would eliminate a lot of duplication, so\n> do them in the common code.\n> \n> To achieve the above goal, three architecture-specific functions are\n> introduced:\n> \n> - arch_get_system_nr_ranges(). Pre-counts the max number of memory ranges.\n> \n> - arch_crash_populate_cmem(). Collects the memory ranges and fills them\n>   into cmem.\n> \n> - arch_crash_exclude_ranges(). Architecture's additional crash memory\n>   ranges exclusion, defaulting to empty.\n> \n> Reviewed-by: Sourabh Jain <sourabhjain@linux.ibm.com>\n> Acked-by: Baoquan He <bhe@redhat.com>\n> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>\n> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>\n\nFor arm64:\n\nAcked-by: Catalin Marinas <catalin.marinas@arm.com>","headers":{"Return-Path":"\n <linuxppc-dev+bounces-18821-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256\n header.s=foss header.b=b4O8r4Jq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18821-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=217.140.110.172","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=arm.com","lists.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256\n header.s=foss header.b=b4O8r4Jq;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=arm.com\n (client-ip=217.140.110.172; helo=foss.arm.com;\n envelope-from=catalin.marinas@arm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhLHc44zfz1y1x\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 26 Mar 2026 21:54:04 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fhLHb6DZnz2ydN;\n\tThu, 26 Mar 2026 21:54:03 +1100 (AEDT)","from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fhLHY70wmz2yS4\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 26 Mar 2026 21:54:00 +1100 (AEDT)","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC4611AED;\n\tThu, 26 Mar 2026 03:53:20 -0700 (PDT)","from arm.com (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5BEE03FB90;\n\tThu, 26 Mar 2026 03:53:19 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774522443;\n\tcv=none;\n b=TqLlAg7NfSvMTT6G+q5ENHnhXCSGVoubvj5wcEmRMSi8HPdW//73LgkHAhFf1/tQgqwg+8HkYIa+yAE4UQcBYhhgwbch1qJMyqoHyLmrIMNmaia24vQZ3utXZpec3WkJkxLH2z1ew39roUREOR6OTEF8b2336NA++NE6igWFxPaWIkwTujh+BAiZsn++bVPh/5NTXV+IQJZH6STuZu7KSYWoywi4h8/qnVHQC2zAbZAYqWQZdGaMz3usph9qVJDG7kJlC1DeCAXZ1bYltK3FT5jS8GK8CW+dLjkkfYvoYrs1YB+t1yCW6yciS41ZHXhLOeKQbeSM09msvswhFRqt9A==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774522443; c=relaxed/relaxed;\n\tbh=DV/gCCOMldyoDdt4HqPHllB/Qo2XxEjw7eaoKAE9NtA=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=KKmgs7piFfBuV1u/pGT3/k20R8Bn9wkknyddtlEry3mja+A8P9nK0og45YJneAWg4NC1fcPo0c0+Ir5UO3k7vZbUuvkhZMvYxK1H8NPYToXDAwU1RVlg7IWt4HXu/guDsAPdc+Tten56iHer/mBIek30hUXCpDCv79hEBzAbji3ScLgeIJ+X690ZJtRr6xP4+eEoIrFPehdoyetpTJgZdqBtAANPx43cIP9TKOdg95ZHqSw5ePxRQBDtmSMdz9zNcTLfPYNswl7+PuAT/8o7m+LIpYZcLZEpnFT7NK/KeWeG0WaHnCGJKIH30QPvIlBOBFse1Vez/zyKvU7xXmtcJA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=arm.com; dkim=pass (1024-bit key;\n unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256\n header.s=foss header.b=b4O8r4Jq; dkim-atps=neutral;\n spf=pass (client-ip=217.140.110.172; helo=foss.arm.com;\n envelope-from=catalin.marinas@arm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=arm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss;\n\tt=1774522406; bh=TbxaIif3p8WQ6+e44Bzl22FNO5C/zwaxFLGv4rhnrAI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=b4O8r4Jq2CFcar+ykaYubGzY5y5qXmjwpctKmzjtCbYrCy7ZWRYDuVV6rw/K5YRYE\n\t cFU8FIDuxcRiwzgg6ypdQsF6ZJHHAtZPQCtyFE9nn5+FJpKL3uUn2slYkKqObCNZpl\n\t vTALvEOciub+LB3zvVDl3q8MoMa8BSfaYZ27RjFc=","Date":"Thu, 26 Mar 2026 10:53:16 +0000","From":"Catalin Marinas <catalin.marinas@arm.com>","To":"Jinjie Ruan <ruanjinjie@huawei.com>","Cc":"corbet@lwn.net, skhan@linuxfoundation.org, will@kernel.org,\n\tchenhuacai@kernel.org, kernel@xen0n.name, maddy@linux.ibm.com,\n\tmpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org,\n\tpjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,\n\talex@ghiti.fr, tglx@kernel.org, mingo@redhat.com, bp@alien8.de,\n\tdave.hansen@linux.intel.com, hpa@zytor.com, robh@kernel.org,\n\tsaravanak@kernel.org, akpm@linux-foundation.org, bhe@redhat.com,\n\tvgoyal@redhat.com, dyoung@redhat.com, rdunlap@infradead.org,\n\tpeterz@infradead.org, pawan.kumar.gupta@linux.intel.com,\n\tfeng.tang@linux.alibaba.com, dapeng1.mi@linux.intel.com,\n\tkees@kernel.org, elver@google.com, paulmck@kernel.org,\n\tlirongqing@baidu.com, rppt@kernel.org, ardb@kernel.org,\n\tleitao@debian.org, osandov@fb.com, cfsworks@gmail.com,\n\ttangyouling@kylinos.cn, sourabhjain@linux.ibm.com,\n\tritesh.list@gmail.com, eajames@linux.ibm.com,\n\tsongshuaishuai@tinylab.org, kevin.brodsky@arm.com,\n\tsamuel.holland@sifive.com, vishal.moola@gmail.com,\n\tjunhui.liu@pigmoral.tech, coxu@redhat.com, liaoyuanhong@vivo.com,\n\tjbohac@suse.cz, fuqiang.wang@easystack.cn, guoren@kernel.org,\n\tchenjiahao16@huawei.com, hbathini@linux.ibm.com,\n\tjames.morse@arm.com, takahiro.akashi@linaro.org,\n\tlizhengyu3@huawei.com, x86@kernel.org, linux-doc@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tloongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org, devicetree@vger.kernel.org,\n\tkexec@lists.infradead.org","Subject":"Re: [PATCH v10 4/8] crash: Exclude crash kernel memory in crash core","Message-ID":"<acUQHCETMXaEtdK5@arm.com>","References":"<20260325025904.2811960-1-ruanjinjie@huawei.com>\n <20260325025904.2811960-5-ruanjinjie@huawei.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260325025904.2811960-5-ruanjinjie@huawei.com>","X-Spam-Status":"No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]