[{"id":3669593,"web_url":"http://patchwork.ozlabs.org/comment/3669593/","msgid":"<69c503eb.050a0220.3d57e6.08fc@mx.google.com>","list_archive_url":null,"date":"2026-03-26T10:01:14","subject":"Re: [LTP] [PATCH v5] mremap07.c: New case check mremap with\n MREMAP_DONTUNMAP","submitter":{"id":82886,"url":"http://patchwork.ozlabs.org/api/people/82886/","name":"Andrea Cervesato","email":"andrea.cervesato@suse.com"},"content":"Hi Wei,\n\nwe are almost there to merge. A few comments below..\n\n> This case test mremap() with MREMAP_DONTUNMAP and use userfaultfd\n> verifies fault which triggered by accessing old memory region.\n\nEnglish can be improved a bit here:\n\nTest mremap() with MREMAP_DONTUNMAP and verify that accessing the old\nmemory region triggers a page fault, which is then correctly handled\nby a userfaultfd handler.\n\n> +static void *fault_handler_thread(void *arg LTP_ATTRIBUTE_UNUSED)\n> +{\n\nMissing return NULL; in this function.\n\n> +\tif (strcmp(fault_addr, test_string) != 0)\n> +\t\ttst_res(TFAIL, \"Verification failed: Content of the old \"\n> +\t\t\t\"address is '%s', expected '%s'\", fault_addr, test_string);\n> +\telse\n> +\t\ttst_res(TPASS, \"Verification passed: Content of the old \"\n> +\t\t\t\"address is correct after fault handling\");\n> +\n\nWe have TST_EXP_EQ_STR(fault_addr, test_string).\n\nThe rest is ok.\n\nRegards,\n--\nAndrea Cervesato\nSUSE QE Automation Engineer Linux\nandrea.cervesato@suse.com","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=lists.linux.it header.i=@lists.linux.it\n header.a=rsa-sha256 header.s=picard header.b=LTCmRBP3;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256\n header.s=google header.b=DuUR7I48;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhK732l9lz1yGD\n\tfor ; Thu, 26 Mar 2026 21:01:35 +1100 (AEDT)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 0C6F83E2FD3\n\tfor ; Thu, 26 Mar 2026 11:01:33 +0100 (CET)","from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 7CF3B3E2735\n for ; Thu, 26 Mar 2026 11:01:27 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n [IPv6:2a00:1450:4864:20::329])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id EBFAD1A008B2\n for ; Thu, 26 Mar 2026 11:01:16 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-486b9675d36so7092865e9.0\n for ; Thu, 26 Mar 2026 03:01:16 -0700 (PDT)","from localhost.localdomain\n (p200300ef2f4fc9009ff26ae1d4042002.dip0.t-ipconnect.de.\n [2003:ef:2f4f:c900:9ff2:6ae1:d404:2002])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4872438891asm2694975e9.6.2026.03.26.03.01.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 03:01:15 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it;\n i=@lists.linux.it; q=dns/txt; s=picard; t=1774519293; h=message-id :\n to : in-reply-to : date : subject : list-id : list-unsubscribe :\n list-archive : list-post : list-help : list-subscribe : from :\n reply-to : cc : mime-version : content-type :\n content-transfer-encoding : sender : from;\n bh=VhCA8cw/3vhUsd0X/eBhV779OECwUcgvOanqwB4FKWI=;\n b=LTCmRBP3hEK6IzQym3uKwgP4lWiqz711kxyf0xvhn8GODOd342VjighjQfwR+1mN7EtMP\n Mba3VGXByvRh7uR3+YIa8+k+Jdmk89rUDVO49165cgvWgT5kifQfHJvTQ78I57MnW+52wm3\n X8n73tAbpdRJqRKBHt+e/kLcp7ebHCk=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=suse.com; s=google; t=1774519276; x=1775124076; darn=lists.linux.it;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:from:to:cc:subject:date:message-id:reply-to;\n bh=Yl079hKQcShQ6h7tcWkYBwOl/EUgRVwTpAW2t1xWIKE=;\n b=DuUR7I48xaUZNidU6BgitzbxOBzKMojACZrZ0M1T+3Dawknjv2+hIQeSAhGOIzVvBq\n rCnmxZ5lw7iMBti7jUwVarOF8PHPhoDj7dW+2ZMUjS0GrL5OrtvZfGjqgLBoqpFZXITb\n muoc7p2VluYdI55K0sqmRtN2w77Gyw1Z9Ry8sKl0qR/jwN0M9W2623E4tZkHoKuZy2V0\n +zwrR31NpS0wn/l0scdP/Hf6FCnBtGdlG/HT5Trt9FoiTRudHZ4fkzi9nUFTkTsaynVM\n 0dP1D5Y0Nq+uFqaD1Qkt7FHZQGhscTZuOmIFo2Gh89zDquE4aTOlC7rtYYcV3cxlcGWF\n vieQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774519276; x=1775124076;\n h=date:content-transfer-encoding:subject:in-reply-to:cc:to:from\n :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Yl079hKQcShQ6h7tcWkYBwOl/EUgRVwTpAW2t1xWIKE=;\n b=o/kaW9BFJByh69fKMGQP9Yo17hVU2vcy8ynZNC5wrF0eywX2JIDrN4iLHAgIcF+fbu\n Tzvtu0sMbq1Z8X7WtWk1qbyqZ7SW/xe8/M0p0jeGwp8IklfrtBBKkeQimRvhWDRFZXJV\n fD6ozq0bWlldoV20tneLhu5QwTTKQzDJwuKw4VECcEJdesK+NuoBeOmH2PzDzFJMGHlb\n 3KUFUa8d7U0+fghqJApQWhl/CsRknYVbr4kDb9mrXSkQTSB4+UDSKILPe6tKXER3H87x\n k6HPgPK6+6Gt9CZMiIYyG93bmgay7xi31hCgTJXyEEZAU1OlCUFH5UexE7hyF4RJRmnl\n yGww==","X-Gm-Message-State":"AOJu0YwYzl9s5pFpC5n8RW9JaTVJosayg1NPWdVKETDyHN64QBKbdwDt\n 3lTxiX/fbuFJ6aBod7dVHrxtL7v0XekdBB31s+qzpKV+3xHdtav8+2OZpbAMKVtfU3k=","X-Gm-Gg":"ATEYQzywKvEcfXpI9ajjkVVPohq8XF2vC133JoyQr9Rrw702UhsfY20rgANchQbDBwW\n dCCOenKd+dmI1wgAzXPlnKMhNkRmcsvUIVPKjW1T2TFHZlMsVH+aliliPv0GDDEXVeR7YYv5GQG\n QGnXRPoyjKJJyipR6DU8bQ7tmD7fRDfsXf84qoN1L4yf2HdwIYjvjBEd5n4frtEJ2U7T8yTxol5\n s7ToTCR/oA6GJ4YWJOGHn3/7UcqNhOPIfNoUJLfsFYdfqM7IzH3j0RMJAcMw7NFCC7KNoFtNBCt\n v6VQOtKiiUm70/9qKbQFqVTVEOUa+LQQagbLz7o59zey+/LKFowA7UMc0F4/43hYZBaygFVLAjd\n KCiWax2EMOIlup2W8vdeJDV43VuCR/T/0ipyXJ72PFVZ88UY+XI/hs8vzvUROtIH2jmWtNM6bgb\n TJq7ayh+NcUe+GBidTBocoRxkm6qxiOUv+Gw5O0nvZpeyk9fNlxhoqmjTcoy9MRs9C8DazwqUNa\n IaEwAr/2hfGx1OzpyRt4z+CHLKRQRPV7D4=","X-Received":"by 2002:a05:600c:4b89:b0:487:219e:42d with SMTP id\n 5b1f17b1804b1-487219e05a4mr11428035e9.11.1774519276006;\n Thu, 26 Mar 2026 03:01:16 -0700 (PDT)","Message-ID":"<69c503eb.050a0220.3d57e6.08fc@mx.google.com>","To":"\"Wei Gao\" ","In-Reply-To":"<20260325011605.5957-1-wegao@suse.com>","Date":"Thu, 26 Mar 2026 10:01:14 +0000","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-3.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"Re: [LTP] [PATCH v5] mremap07.c: New case check mremap with\n MREMAP_DONTUNMAP","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Andrea Cervesato via ltp ","Reply-To":"Andrea Cervesato ","Cc":"ltp@lists.linux.it","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "}}]