[{"id":3673901,"web_url":"http://patchwork.ozlabs.org/comment/3673901/","msgid":"<177529894081.11406.7307362893690177391.b4-ty@b4>","list_archive_url":null,"date":"2026-04-04T10:35:40","subject":"Re: [PATCH] PCI: aspeed: Fix IRQ domain leak on platform_get_irq()\n failure","submitter":{"id":91273,"url":"http://patchwork.ozlabs.org/api/people/91273/","name":"Manivannan Sadhasivam","email":"manivannan.sadhasivam@oss.qualcomm.com"},"content":"On Tue, 24 Mar 2026 01:57:59 +0800, Felix Gu wrote:\n> The aspeed_pcie_probe() function calls aspeed_pcie_init_irq_domain()\n> which allocates pcie->intx_domain and initializes MSI. However, if\n> platform_get_irq() fails afterwards, the cleanup action was not yet\n> registered via devm_add_action_or_reset(), causing the IRQ domain\n> resources to leak.\n> \n> Fix this by registering the devm cleanup action immediately after\n> aspeed_pcie_init_irq_domain() succeeds, before calling\n> platform_get_irq(). This ensures proper cleanup on any subsequent\n> failure.\n> \n> [...]\n\nApplied, thanks!\n\n[1/1] PCI: aspeed: Fix IRQ domain leak on platform_get_irq() failure\n commit: c54d5f5b33990f2649c20f35407f340bcadb8a53\n\nBest regards,","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-aspeed@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=Zwtf+2JI;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=HTiJw5ZL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linux-aspeed+bounces-3844-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=205.220.168.131","lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=Zwtf+2JI;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=HTiJw5ZL;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=oss.qualcomm.com\n (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com;\n envelope-from=manivannan.sadhasivam@oss.qualcomm.com;\n receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fqRG70T17z1yGM\n\tfor ; Tue, 07 Apr 2026 10:02:23 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fqRFk4CFvz2ykf;\n\tTue, 07 Apr 2026 10:02:02 +1000 (AEST)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fnsSR6pYMz2yVL\n\tfor ; Sat, 04 Apr 2026 21:35:50 +1100 (AEDT)","from pps.filterd (m0279864.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6344deRw2971715\n\tfor ; Sat, 4 Apr 2026 10:35:47 GMT","from mail-pj1-f72.google.com (mail-pj1-f72.google.com\n [209.85.216.72])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dauth8hv1-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor ; Sat, 04 Apr 2026 10:35:46 +0000 (GMT)","by mail-pj1-f72.google.com with SMTP id\n 98e67ed59e1d1-35d9278587bso2533222a91.2\n for ;\n Sat, 04 Apr 2026 03:35:46 -0700 (PDT)","from work.lan ([2409:4091:a0f4:6806:d6bf:182:1f3d:df20])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35de680b5c4sm2154469a91.5.2026.04.04.03.35.40\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 04 Apr 2026 03:35:44 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775298953;\n\tcv=none;\n b=G2J6jCa/g5tJJpzSsgl9nVjjhDy069P48XKnIcioTzEpAlfZL4KntZH6C3UchizR0aQ1BCxRYV0e9hDAJ2In9EgZM9ajZym2KKmwQCdGDG2x4obsBKMEMoLuB186HHVHrRKeknwKH9os5ZazzWE9bfwwO37isASMUjtiCBZmWeWVAiocUuniDjcyppSlHoKP/eCzODh3NQUjh7vZnQ6dbFMKgQLLIAKPrzj+g21a2jg1oQkE0i1qkh6IgXQClFjNCq3MvD8sgR7MATaqE5QXEGNKIbo0dzor4z5WIBYU5pkwl1zHYuuZiXw0yFOYOcB/2e10nLuQtIn39priBTGdUA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775298953; c=relaxed/relaxed;\n\tbh=1bO120ElN5GMnWdl/iLo9s25UFJEb0/bZvzF/MWV+gs=;\n\th=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date:\n\t MIME-Version:Content-Type;\n b=B4QAkDSTcApAX91KttGEphS8DPC8nQXUCQuipYc255o57lrjaYsGyGUlF3r/rKDZDVktbtpErwBuG4V3Ucf7Iwru8O4gf0nJbDFgPjXA9j9x89c2BOuhNdADXhW6u7TH688L3fMZk+nx6pLv6k4LKgM0Fh6eOTzevk3Yeq5M4w/qDZ2eXr2BkBS4cV+49V2vqbrMbL2aj+6Jd9Gs7KEc+O9bZpgcqHST7cjBny8+EJltZcPwA5tIn9pqFTxwctmOcjXhLlCxJ5xmmJUMkThseGXSiLwORqAz+8K43XlhWwh2EcR3/hPN+qsdz8pmhwXtL8wuIcCEhsICPSSRlSVrFQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=Zwtf+2JI; dkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=HTiJw5ZL; dkim-atps=neutral;\n spf=pass (client-ip=205.220.168.131; helo=mx0a-0031df01.pphosted.com;\n envelope-from=manivannan.sadhasivam@oss.qualcomm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=oss.qualcomm.com","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\t1bO120ElN5GMnWdl/iLo9s25UFJEb0/bZvzF/MWV+gs=; b=Zwtf+2JIvBHyCEHt\n\tTOCl2X0UthuJLuf6IMMf3PRzMt4tFGc5sxt2xDq0clX9P0WkI89LsO4cSpawImjJ\n\tDtH0x/i3SR7npq8BOynIfD9dae6rHb31NrfmAIDoKrxdePIc/FlEDK5XWclpLiy8\n\tMzFamo6PfeaoM3DQH9Kkn8K4SEdf/E3WYRqnZVsDdd9yus0hB37s2i6i9hcoS/Fv\n\tMWZRyh0JYTrgmoyH/5H+z9d6jhwCPjWs/DgoNqxm+Ev9HR3NuDpm5J/oNYQ79U88\n\txpRGQOx7ZCSbVQxhLm+MvZtHrmbHARVaQ3Gg0jJZAK8DAON99V3YROyQlz4ubtF3\n\t8pHOSg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775298946; x=1775903746;\n darn=lists.ozlabs.org;\n h=content-transfer-encoding:mime-version:date:message-id:subject\n :references:in-reply-to:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1bO120ElN5GMnWdl/iLo9s25UFJEb0/bZvzF/MWV+gs=;\n b=HTiJw5ZLLYe8RURmqh7VMN8nr5mH6bGQb0em2zaYtY8vZGXWBZFnomh5NFAlQ5oTCb\n XVCoQilJEL6dsDoY65JmjioCrA9JaynbUVzX6HUx7ErAR+suLzXJBAJJlwon7PgPLDBy\n ADhZ586Pg8fNae1HRsAPgJKPI0oxIdq6tUw5jFPDtepsSl2iEuI+r1dsno7HbIyZplcf\n ulbius/c4YNOEYLja+6BhCMwhGkcdbTrlzazkGsTNpz7L0jeZmPqHpCkLuh7nJY2WYwh\n 4Hm85KtEY266yd90PdhY39b6v96dB8rpLjm96TElrPAEef7LXCeSYeMQgaFERKIPyHUq\n rd5Q=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775298946; x=1775903746;\n h=content-transfer-encoding:mime-version:date:message-id:subject\n :references:in-reply-to:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=1bO120ElN5GMnWdl/iLo9s25UFJEb0/bZvzF/MWV+gs=;\n b=drTpGyR8Y0R8iQP3c0q9V4DyOMbpifymJa64hFaGEX3iutBkusceIB5oz44qUQqXFd\n G6aOP7k/ic5ugiDmWesnqpoJGlor8otRCuD24aS92yrmwsYp4yuMtm3cbUcJu5xjymZe\n mp1K9whfxSrPDvkGHLOCFRRPkfrU/pFAUlJQqOylREXxx13G4Y7Q74ZaXTzPFpOKmetR\n 1JY/lrMAUd5DRNvoLMUkZikMvDw6gnzmehixidGFD8r0kgtD1Ver0fsYvCQvwBS/DC2h\n 4Fvl+A6Kktu6txOj4jbwi2ggABkkiTciu3n+TIMYJHWlHsW+wllP1oxZxkFxxIeB0RSh\n C0Pw==","X-Gm-Message-State":"AOJu0YwiugPiqb5nD87M6Y7prid3i80YSzKO/kffEhhqLVRy0IFfc4Sm\n\tcIcEZhw/p9bgMro7WMU6iktWJeCzu0co5EE9dqhY3URUbRzsmUkTY8vKGib5iIQFf9DKpkpHcJ0\n\tSKs51pZJRGLBxNYsxVY5Jh27ZVvjDs3RVTwVQCyFHzEes1OpnyP9ok8E3lIZal1pRNZxm","X-Gm-Gg":"AeBDieum9LxRrcNgMXr7IndHHuyjrJjJXOymA1f0xBYH6+m1J8WEWRyHJMWQZ+eOV1j\n\tZfjLF0qRnoxTbd6YNGpoDga2t28c7gKpq5Bd7oomUsuNdHk/XQPDRpAniKyjJNllWmmA7m6OLh8\n\tj6ITEK+9XBV+J2hw8G5I2Gu3NYEY6JZLoZWG8ogHXTA52icoOUi3vPeOrSmBh45/SEY6ZPlDEXs\n\tPRxkRvsiWRlZyaMroPJe3NIwZn9usWoQraLCwnpzCoYE3juL7ip+1eA8Xpe3OaSynlS2N341imA\n\tpipLsssUzPo51/OLXq6tGO7w6nBbvFjuoTSKOBQ+bS+w8PwPCrCK22IaLurwsrgjLl2xtDE4Cee\n\tXJRtqQ/E3mAn0SpU=","X-Received":["by 2002:a17:90a:d2c7:b0:35c:cba:344f with SMTP id\n 98e67ed59e1d1-35de68414eemr5858995a91.13.1775298945796;\n Sat, 04 Apr 2026 03:35:45 -0700 (PDT)","by 2002:a17:90a:d2c7:b0:35c:cba:344f with SMTP id\n 98e67ed59e1d1-35de68414eemr5858970a91.13.1775298945252;\n Sat, 04 Apr 2026 03:35:45 -0700 (PDT)"],"From":"Manivannan Sadhasivam ","X-Google-Original-From":"Manivannan Sadhasivam ","To":"Jacky Chou ,\n Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= , Rob Herring ,\n Bjorn Helgaas , Joel Stanley ,\n Andrew Jeffery , Felix Gu ","Cc":"linux-aspeed@lists.ozlabs.org, linux-pci@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","In-Reply-To":"<20260324-aspeed-v1-1-354181624c00@gmail.com>","References":"<20260324-aspeed-v1-1-354181624c00@gmail.com>","Subject":"Re: [PATCH] PCI: aspeed: Fix IRQ domain leak on platform_get_irq()\n failure","Message-Id":"<177529894081.11406.7307362893690177391.b4-ty@b4>","Date":"Sat, 04 Apr 2026 16:05:40 +0530","X-Mailing-List":"linux-aspeed@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Mailer":"b4 0.15.0","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA0MDA5NiBTYWx0ZWRfX+sV/2oCIStbq\n OUcsBqUuHrOhMQaStub5NcFTJClhlMTlwkF8fV+AysOis8srAs3d5Jd7fwL2VbDAa30/eNVE9Ct\n E1JV62gRe3KYv4qGl131NGV7gaeu0+Dox/3eepfxAbxmCNrqS3VIcuug5x8qDxhQs02NB/stFkP\n g5XAJU0HxLqeYRoYdxtzVkMQCwd4k6wNLTep3FWiSRyARfPWC7icwQ7kjJ6fnTBYw6XVqFSU2J0\n OZLkMtUgx3h30h0GCK4eE/WyCjClsu3rsdmCXqrGQa1v3XrlY3WdJfSlIQuvV+yawpsxWVfgR9q\n wwldkmZVAlgKEco7/TxEIKWp0mtnjZ29C1vyp/KbZ+++QbZKwh0GHJb7W4G6xx2irRrG7tsQiZW\n kr8zbkbD5JLzSZvnwbzZKpk/7O1xDj3rHHdSihZqHj167JcRfKX1c04lqPIjFroTVDy8PQM65Vs\n Evt07eJfwZxszfck5OQ==","X-Proofpoint-GUID":"yxzgY5Gr8BWl-ghNh3ZJHCMgsjGNho9A","X-Authority-Analysis":"v=2.4 cv=MIptWcZl c=1 sm=1 tr=0 ts=69d0e982 cx=c_pps\n a=RP+M6JBNLl+fLTcSJhASfg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8\n a=xCZdhqmVAa86G4UcJK0A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22","X-Proofpoint-ORIG-GUID":"yxzgY5Gr8BWl-ghNh3ZJHCMgsjGNho9A","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-03_07,2026-04-03_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1011 malwarescore=0 suspectscore=0 lowpriorityscore=0\n priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0 bulkscore=0\n spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001\n definitions=main-2604040096","X-Spam-Status":"No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]