[{"id":3668754,"web_url":"http://patchwork.ozlabs.org/comment/3668754/","msgid":"<177440099590.2332534.9132007696467343522.robh@kernel.org>","list_archive_url":null,"date":"2026-03-25T01:09:56","subject":"Re: [PATCH v3 1/3] dt-bindings: mtd: refactor NAND bindings and add\n nand-controller-legacy.yaml","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, 24 Mar 2026 18:16:18 -0400, Frank Li wrote:\n> The modern NAND controller binding requires NAND chips to be described as\n> child nodes of the controller, for example:\n> \n> nand-controller {\n> ...\n> nand@0 {\n> /* raw NAND chip properties */\n> };\n> };\n> \n> However, many existing device trees place NAND chip properties directly\n> within the controller node because those controllers support only a single\n> chip. This layout is still widely used by older platforms and by other DT\n> consumers such as U-Boot. Migrating all existing users to the new layout\n> will take time.\n> \n> Several kernel drivers, such as ams-delta.c, davinci_nand.c and\n> fsmc_nand.c, still expect the legacy layout where raw NAND properties are\n> defined in the controller node.\n> \n> To support both layouts during the transition:\n> \n> - Extract NAND chip-related properties into separate schemas\n> (nand-property.yaml and raw-nand-property.yaml) from\n> nand-chip.yaml and raw-nand-chip.yaml.\n> - Introduce nand-controller-legacy.yaml to allow both the\n> legacy and modern layouts.\n> - Add a select condition in nand-controller.yaml to prevent\n> node name pattern matching for fsl,* NAND controllers.\n> \n> Keep compatibility with existing device trees while allowing gradual\n> migration to the modern binding structure.\n> \n> Signed-off-by: Frank Li \n> ---\n> change in v3\n> - use select: false\n> - s/under/within/\n> - s/property/properties/\n> \n> two problem left:\n> 1. about \"^nand@[a-f0-9]$\" in nand-controller-legacy.yaml\n> \n> allow dts to do mirgeration from legacy layout to modern layouts for different\n> boards, which use the same compatible string.\n> \n> 2. ref to mtd.yaml\n> \n> mtd.yaml force node name as flash@, nand@ ..., but here is parent node\n> name is nand-controller@. Only two properties, duplicate these should be\n> simple and clean enough now.\n> \n> change in v2\n> - none\n> \n> change dts layout break boot\n> https://lore.kernel.org/imx/177281063848.253518.12995342124719933118.b4-ty@nxp.com/T/#t\n> ---\n> .../devicetree/bindings/mtd/nand-chip.yaml | 46 +-----------\n> ...oller.yaml => nand-controller-legacy.yaml} | 46 +++++-------\n> .../bindings/mtd/nand-controller.yaml | 2 +\n> .../{nand-chip.yaml => nand-property.yaml} | 14 +---\n> .../bindings/mtd/raw-nand-chip.yaml | 74 +------------------\n> ...-nand-chip.yaml => raw-nand-property.yaml} | 15 +---\n> 6 files changed, 27 insertions(+), 170 deletions(-)\n> copy Documentation/devicetree/bindings/mtd/{nand-controller.yaml => nand-controller-legacy.yaml} (69%)\n> copy Documentation/devicetree/bindings/mtd/{nand-chip.yaml => nand-property.yaml} (89%)\n> copy Documentation/devicetree/bindings/mtd/{raw-nand-chip.yaml => raw-nand-property.yaml} (94%)\n> \n\nReviewed-by: Rob Herring (Arm) ","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=uhGaoR5X;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Ji+MW3K5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgTNQ1vf7z1y1G\n\tfor ; Wed, 25 Mar 2026 12:10:14 +1100 (AEDT)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w5Ckz-00000002RAk-0ZcN;\n\tWed, 25 Mar 2026 01:10:01 +0000","from sea.source.kernel.org ([172.234.252.31])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w5Ckw-00000002RA5-0vOx\n\tfor linux-mtd@lists.infradead.org;\n\tWed, 25 Mar 2026 01:09:59 +0000","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 931A443FDB;\n\tWed, 25 Mar 2026 01:09:57 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 43292C19424;\n\tWed, 25 Mar 2026 01:09:57 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=kYCsepnVuuyzAQnh4ugWgMxbE+XU6l4BNqBnmJpoWXY=; b=uhGaoR5XlYtj3k\n\tUE1ekAumjcp3jO8RxnYXcjWBxOiv74AawX7h7oUxchn4puc27/12QsBGMj/SuUxGryIiz2vTNPePQ\n\tT6sakY9F3IpgQa3TgDWe/55FU1nefFW6Zdj783TOGYkaGm9bHgY1ExykSgsERF31LOAL4h8XicZGT\n\t2iDE77dwbwengDvcNyemDb3EQzHbwfzMOFlAmdXyIpsV3hREStKf3XtEtmj4ZeIZIfmL7rYzntWji\n\tXwDwc0yioSMd4E0CPxePKEWNZEAKQX7D+6N2lLfRX2k2ouKct/gYESaAN/7Q5z1kxodXK/jD2h3xy\n\tzBCPTzOlHjEH7g0N50GQ==;","v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774400997;\n\tbh=YfBBgt1syU0ry/vvqRH6IoZ65DUjX8qoIovBPDPsdXE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ji+MW3K55lmJ/YNUuQrJr97TBLTEsc2U0T04+aUZB1uLqa8Dv6DO04oUZy0v1SOVZ\n\t p6/uPKBgh3Z3ibY09+mxnblC/vSpYadRvFQQ+gKed3LBTmtLdUf0WnY4E+2krHp9BV\n\t 6jiImP8ZVrdAMzv+/Wr2bnnrVrgxVF4NLER4UM5mwhnS8JxQe0w/beSVlIJgNDMaYh\n\t nygmULv9Bq66XM2OoCVcCvkSU9pZzHqkjxoplI9/7c1mmJT5jfPiYD9WVOcwylzzfN\n\t emwnYRAqUAZybDz2IwhZPhVrHliMLsmL76gZ+xLeIcOL1GAWGC/xfsMcOz81LAofcA\n\t tuj8G6mSX46qA=="],"Date":"Tue, 24 Mar 2026 20:09:56 -0500","From":"\"Rob Herring (Arm)\" ","To":"Frank Li ","Cc":"Krzysztof Kozlowski ,\n\tMiquel Raynal ,\n\tConor Dooley , imx@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-mtd@lists.infradead.org, Richard Weinberger ,\n\tVignesh Raghavendra ","Subject":"Re: [PATCH v3 1/3] dt-bindings: mtd: refactor NAND bindings and add\n nand-controller-legacy.yaml","Message-ID":"<177440099590.2332534.9132007696467343522.robh@kernel.org>","References":"<20260324221624.2424092-1-Frank.Li@nxp.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20260324221624.2424092-1-Frank.Li@nxp.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260324_180958_309740_736C275B ","X-CRM114-Status":"GOOD ( 20.50 )","X-Spam-Score":"-2.1 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: On Tue, 24 Mar 2026 18:16:18 -0400, Frank Li wrote: > The\n modern NAND controller binding requires NAND chips to be described as >\n child\n nodes of the controller, for example: > > nand-controller { > . [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [172.234.252.31 listed in sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [172.234.252.31 listed in\n sa-trusted.bondedsender.org]\n -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [172.234.252.31 listed in\n bl.score.senderscore.com]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3669122,"web_url":"http://patchwork.ozlabs.org/comment/3669122/","msgid":"<177444897541.837464.3426048157066587709.b4-ty@bootlin.com>","list_archive_url":null,"date":"2026-03-25T14:29:35","subject":"Re: [PATCH v3 1/3] dt-bindings: mtd: refactor NAND bindings and\n add nand-controller-legacy.yaml","submitter":{"id":73368,"url":"http://patchwork.ozlabs.org/api/people/73368/","name":"Miquel Raynal","email":"miquel.raynal@bootlin.com"},"content":"On Tue, 24 Mar 2026 18:16:18 -0400, Frank Li wrote:\n> The modern NAND controller binding requires NAND chips to be described as\n> child nodes of the controller, for example:\n> \n> nand-controller {\n> ...\n> nand@0 {\n> /* raw NAND chip properties */\n> };\n> };\n> \n> [...]\n\nApplied to nand/next, thanks!\n\n[1/3] dt-bindings: mtd: refactor NAND bindings and add nand-controller-legacy.yaml\n commit: 0ba8da2f318efc006ae5c080a4abfbabb5d110e2\n[2/3] dt-bindings: mtd: gpmi-nand: ref to nand-controller-legacy.yaml\n commit: 17de8a68ac9807adf551f7d2d980e26d1196e41a\n[3/3] dt-bindings: mtd: mxc-nand: add missing compatible string and ref to nand-controller-legacy.yaml\n commit: 3b2a422e23cf1998b85ccbcb90cabff01d17422c\n\nPatche(s) should be available on mtd/linux.git and will be\npart of the next PR (provided that no robot complains by then).\n\nKind regards,\nMiquèl","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=WrC88w5O;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256\n header.s=dkim header.b=O8rxUz9y;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgq753NFgz1y1K\n\tfor ; Thu, 26 Mar 2026 01:29:53 +1100 (AEDT)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w5PEw-00000003bbG-45dC;\n\tWed, 25 Mar 2026 14:29:46 +0000","from smtpout-04.galae.net ([185.171.202.116])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1w5PEs-00000003bWY-1yG4\n\tfor linux-mtd@lists.infradead.org;\n\tWed, 25 Mar 2026 14:29:46 +0000","from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233])\n\tby smtpout-04.galae.net (Postfix) with ESMTPS id 21C86C580B2;\n\tWed, 25 Mar 2026 14:30:06 +0000 (UTC)","from mail.galae.net (mail.galae.net [212.83.136.155])\n\tby smtpout-01.galae.net (Postfix) with ESMTPS id 5974D601E2;\n\tWed, 25 Mar 2026 14:29:38 +0000 (UTC)","from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon)\n with ESMTPSA id 97A3C10451A66;\n\tWed, 25 Mar 2026 15:29:35 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Date:Message-Id:Subject:\n\tReferences:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=INF3iQ4vvM6B1BQ+JtcT9JaA0ZM8uGvF1usFzddep9w=; b=WrC88w5OGuEYo/\n\tqQ3VEnzR1oEtvZWv7t80l6wP+ZcV/BIeqFwQqxSXK6RLEBdd6OnNpgNe4tcuoXJgj06Ekt5myt6Mo\n\tiS2ngS8iiFNTERKDAk0oOt5zs8Uxv3y/j8wC5ydQDYSd7xjv42FMsN52GUByEBx6ez6mYuKfmJ3BX\n\tVqgc2xPXkZfpBU/NffdOlbmOFT0qwsFQu9Ee+56WVkMJe8n5zAOkE4eW1ZMKHZaF9K6qUrz0Ay5gJ\n\tS5svyL+QQp4OIYbo4wbB04Qw/on5ygW5ZK3qNHLBB/KM7otp4IdSTxfx4Q6mmFtP5/1DJXSqZJJYZ\n\tYCLttsTaVv3x/olPVqyA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;\n\tt=1774448977; h=from:subject:date:message-id:to:cc:mime-version:content-type:\n\t content-transfer-encoding:in-reply-to:references;\n\tbh=RMKdRLPo5ZxYLv8j+Hc3AaldOSYVznoKCZwnCSBgffY=;\n\tb=O8rxUz9yHrILd9J72HXd3e+lz1mCEoFipYqmVDuoN2a/sdBJ7dGPkvZsGC55guTTFN4FDA\n\tQEFalJInpzSfswBj2waEDlURaIh6JExc9PzuXdYhJ9+FBmL38uGSHug2VP2bvHArPmRElB\n\tsFuLQr8pX/F3z8xAzReGtX4oC12Qa4ZXnOMU1ehKrN2sSjKdbcyv6xvGzmzuPtXWfkO1oD\n\tjr8kQqbNZFWPquKqGkDeIz7xOwdnlwOzC9rp8uBUCvmEioW5YiUeki+ZaUZ61vYOzOEjUl\n\tJQWhdvD956/sEgc66QHWyC4qzjo9oqp513XO/HCmwwg4vyoTyob+PjTIXxta1Q=="],"From":"Miquel Raynal ","To":"Richard Weinberger ,\n Vignesh Raghavendra , Rob Herring ,\n Krzysztof Kozlowski ,\n Conor Dooley , linux-mtd@lists.infradead.org,\n devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n Frank Li ","Cc":"imx@lists.linux.dev","In-Reply-To":"<20260324221624.2424092-1-Frank.Li@nxp.com>","References":"<20260324221624.2424092-1-Frank.Li@nxp.com>","Subject":"Re: [PATCH v3 1/3] dt-bindings: mtd: refactor NAND bindings and\n add nand-controller-legacy.yaml","Message-Id":"<177444897541.837464.3426048157066587709.b4-ty@bootlin.com>","Date":"Wed, 25 Mar 2026 15:29:35 +0100","MIME-Version":"1.0","X-Mailer":"b4 0.14.3","X-Last-TLS-Session-Version":"TLSv1.3","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260325_072942_649054_7B20055F ","X-CRM114-Status":"UNSURE ( 8.46 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.1 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: On Tue, 24 Mar 2026 18:16:18 -0400, Frank Li wrote: > The\n modern NAND controller binding requires NAND chips to be described as >\n child\n nodes of the controller, for example: > > nand-controller { > .. [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [185.171.202.116 listed in\n bl.score.senderscore.com]\n -0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]