[{"id":3668722,"web_url":"http://patchwork.ozlabs.org/comment/3668722/","msgid":"","list_archive_url":null,"date":"2026-03-24T22:10:50","subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","submitter":{"id":86188,"url":"http://patchwork.ozlabs.org/api/people/86188/","name":"Damien Le Moal","email":"dlemoal@kernel.org"},"content":"On 2026/03/24 14:16, Rosen Penev wrote:\n> Combine allocations into one by using a flexible array member.\n> \n> Signed-off-by: Rosen Penev \n> ---\n> drivers/ata/ahci_tegra.c | 15 ++++++---------\n> 1 file changed, 6 insertions(+), 9 deletions(-)\n> \n> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c\n> index 44584eed6374..5972fe04ff3f 100644\n> --- a/drivers/ata/ahci_tegra.c\n> +++ b/drivers/ata/ahci_tegra.c\n> @@ -175,8 +175,9 @@ struct tegra_ahci_priv {\n> \tstruct reset_control\t *sata_cold_rst;\n> \t/* Needs special handling, cannot use ahci_platform */\n> \tstruct clk\t\t *sata_clk;\n> -\tstruct regulator_bulk_data *supplies;\n> \tconst struct tegra_ahci_soc *soc;\n> +\n> +\tstruct regulator_bulk_data supplies[];\n\nI think this needs a __counted_by() annotation, but not sure if that is possible\ngiven that soc->num_supplies is not in this structure. Might need a copy of it.\n\n> };\n> \n> static void tegra_ahci_handle_quirks(struct ahci_host_priv *hpriv)\n> @@ -512,6 +513,7 @@ static const struct scsi_host_template ahci_platform_sht = {\n> \n> static int tegra_ahci_probe(struct platform_device *pdev)\n> {\n> +\tconst struct tegra_ahci_soc *soc;\n> \tstruct ahci_host_priv *hpriv;\n> \tstruct tegra_ahci_priv *tegra;\n> \tstruct resource *res;\n> @@ -521,14 +523,15 @@ static int tegra_ahci_probe(struct platform_device *pdev)\n> \tif (IS_ERR(hpriv))\n> \t\treturn PTR_ERR(hpriv);\n> \n> -\ttegra = devm_kzalloc(&pdev->dev, sizeof(*tegra), GFP_KERNEL);\n> +\tsoc = of_device_get_match_data(&pdev->dev);\n> +\ttegra = devm_kzalloc(&pdev->dev, struct_size(tegra, supplies, soc->num_supplies), GFP_KERNEL);\n> \tif (!tegra)\n> \t\treturn -ENOMEM;\n> \n> \thpriv->plat_data = tegra;\n> \n> \ttegra->pdev = pdev;\n> -\ttegra->soc = of_device_get_match_data(&pdev->dev);\n> +\ttegra->soc = soc;\n> \n> \ttegra->sata_regs = devm_platform_ioremap_resource(pdev, 1);\n> \tif (IS_ERR(tegra->sata_regs))\n> @@ -571,12 +574,6 @@ static int tegra_ahci_probe(struct platform_device *pdev)\n> \t\treturn PTR_ERR(tegra->sata_clk);\n> \t}\n> \n> -\ttegra->supplies = devm_kcalloc(&pdev->dev,\n> -\t\t\t\t tegra->soc->num_supplies,\n> -\t\t\t\t sizeof(*tegra->supplies), GFP_KERNEL);\n> -\tif (!tegra->supplies)\n> -\t\treturn -ENOMEM;\n> -\n> \tregulator_bulk_set_supply_names(tegra->supplies,\n> \t\t\t\t\ttegra->soc->supply_names,\n> \t\t\t\t\ttegra->soc->num_supplies);","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=uY1VaRdV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13165-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"uY1VaRdV\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgPRw1QLzz1xy1\n\tfor ; Wed, 25 Mar 2026 09:13:00 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id ABC7D303D0D9\n\tfor ; Tue, 24 Mar 2026 22:10:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 58F853C6603;\n\tTue, 24 Mar 2026 22:10:57 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ABBB3C13FF;\n\tTue, 24 Mar 2026 22:10:56 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 8C3D7C2BCB1;\n\tTue, 24 Mar 2026 22:10:56 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774390257; cv=none;\n b=DihWTBz7fDfLwRwqtcXFzlU261oiaiYWI1+EW7LjbMTksZioDYNB5mwn5CYBPNCtmAh/qJf8ev5sBkOSG3G4FQH90lOzsVxVE0Zgp5bwjzOZgDcvUHluo2ZiZYWjtAu7W7FnvIlL3RCRxy+t6QmNbUgSMRR/8BABbitt2S8+CYk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774390257; c=relaxed/simple;\n\tbh=+kehYrYV5udI79UZsWv7ehxJx9W8hKs0w0BfEAayIRI=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=q9f3Wb7FQPZ3yo0uFmqWG3UkMTTHRU5xmgdDoULSxjAWoS8ozQN5Yp2xtNnfM0jEBR3EuaNPkcuVVoFFh0MMKEdYLnbYrdtFhtOpuBuaH73KigARhBRQfhUWpJT1xNeDq/UKAhIZKg8o9Wa5K5jgmBcDNIk+7zYHiwRoBJvQa54=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=uY1VaRdV; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774390256;\n\tbh=+kehYrYV5udI79UZsWv7ehxJx9W8hKs0w0BfEAayIRI=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=uY1VaRdVZCIt15Gt+rKiGi/CFuAnyA5Lf61/KvONN48uuWE1zQEZ2QppektWO7Eux\n\t gEyZzFOMnxJHLbSSPtJrVZx0bH0vHGcJAybzOjhlVEPfgRpQTu/mMFOHhoGv2q/vzf\n\t Q9aPh2FK+R7Zy1iiVE+oGK5NCGpD/9JKF916hYCwwKHUQBJUinqTHfkrGPZdIABTdl\n\t 7C4qSY4ihvLMz7zyPUFMygQgP4amUJ0Cdo6YWgd84pWltL5hR0pc2yeEDFGYRhRK/n\n\t DkpvS6ZbkxgYCZPwWU7ddbVV+q/8SoS5RogVF60ebTRloGO7VEV1srDbqVIOL6DPKB\n\t jVxbTi29UQDCw==","Message-ID":"","Date":"Tue, 24 Mar 2026 15:10:50 -0700","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","To":"Rosen Penev , linux-ide@vger.kernel.org","Cc":"Niklas Cassel ,\n Thierry Reding ,\n Jonathan Hunter ,\n \"open list:TEGRA ARCHITECTURE SUPPORT\" ,\n open list ","References":"<20260324211629.26924-1-rosenp@gmail.com>","Content-Language":"en-US","From":"Damien Le Moal ","Organization":"Western Digital Research","In-Reply-To":"<20260324211629.26924-1-rosenp@gmail.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}},{"id":3668727,"web_url":"http://patchwork.ozlabs.org/comment/3668727/","msgid":"","list_archive_url":null,"date":"2026-03-24T22:51:22","subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/people/70304/","name":"Rosen Penev","email":"rosenp@gmail.com"},"content":"On Tue, Mar 24, 2026 at 3:10 PM Damien Le Moal wrote:\n>\n> On 2026/03/24 14:16, Rosen Penev wrote:\n> > Combine allocations into one by using a flexible array member.\n> >\n> > Signed-off-by: Rosen Penev \n> > ---\n> > drivers/ata/ahci_tegra.c | 15 ++++++---------\n> > 1 file changed, 6 insertions(+), 9 deletions(-)\n> >\n> > diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c\n> > index 44584eed6374..5972fe04ff3f 100644\n> > --- a/drivers/ata/ahci_tegra.c\n> > +++ b/drivers/ata/ahci_tegra.c\n> > @@ -175,8 +175,9 @@ struct tegra_ahci_priv {\n> > struct reset_control *sata_cold_rst;\n> > /* Needs special handling, cannot use ahci_platform */\n> > struct clk *sata_clk;\n> > - struct regulator_bulk_data *supplies;\n> > const struct tegra_ahci_soc *soc;\n> > +\n> > + struct regulator_bulk_data supplies[];\n>\n> I think this needs a __counted_by() annotation, but not sure if that is possible\n> given that soc->num_supplies is not in this structure. Might need a copy of it.\nIs it really worth it to make a copy?\n>\n> > };\n> >\n> > static void tegra_ahci_handle_quirks(struct ahci_host_priv *hpriv)\n> > @@ -512,6 +513,7 @@ static const struct scsi_host_template ahci_platform_sht = {\n> >\n> > static int tegra_ahci_probe(struct platform_device *pdev)\n> > {\n> > + const struct tegra_ahci_soc *soc;\n> > struct ahci_host_priv *hpriv;\n> > struct tegra_ahci_priv *tegra;\n> > struct resource *res;\n> > @@ -521,14 +523,15 @@ static int tegra_ahci_probe(struct platform_device *pdev)\n> > if (IS_ERR(hpriv))\n> > return PTR_ERR(hpriv);\n> >\n> > - tegra = devm_kzalloc(&pdev->dev, sizeof(*tegra), GFP_KERNEL);\n> > + soc = of_device_get_match_data(&pdev->dev);\n> > + tegra = devm_kzalloc(&pdev->dev, struct_size(tegra, supplies, soc->num_supplies), GFP_KERNEL);\n> > if (!tegra)\n> > return -ENOMEM;\n> >\n> > hpriv->plat_data = tegra;\n> >\n> > tegra->pdev = pdev;\n> > - tegra->soc = of_device_get_match_data(&pdev->dev);\n> > + tegra->soc = soc;\n> >\n> > tegra->sata_regs = devm_platform_ioremap_resource(pdev, 1);\n> > if (IS_ERR(tegra->sata_regs))\n> > @@ -571,12 +574,6 @@ static int tegra_ahci_probe(struct platform_device *pdev)\n> > return PTR_ERR(tegra->sata_clk);\n> > }\n> >\n> > - tegra->supplies = devm_kcalloc(&pdev->dev,\n> > - tegra->soc->num_supplies,\n> > - sizeof(*tegra->supplies), GFP_KERNEL);\n> > - if (!tegra->supplies)\n> > - return -ENOMEM;\n> > -\n> > regulator_bulk_set_supply_names(tegra->supplies,\n> > tegra->soc->supply_names,\n> > tegra->soc->num_supplies);\n>\n>\n> --\n> Damien Le Moal\n> Western Digital Research","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=CwFHLGZC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13166-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"CwFHLGZC\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.218.46","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgQJg4wVCz1xy1\n\tfor ; Wed, 25 Mar 2026 09:51:47 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 0A2F930576A9\n\tfor ; Tue, 24 Mar 2026 22:51:39 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2E13D3C5DDA;\n\tTue, 24 Mar 2026 22:51:38 +0000 (UTC)","from mail-ej1-f46.google.com (mail-ej1-f46.google.com\n [209.85.218.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F05323ABAA\n\tfor ; Tue, 24 Mar 2026 22:51:36 +0000 (UTC)","by mail-ej1-f46.google.com with SMTP id\n a640c23a62f3a-b979d16dd0cso875628866b.1\n for ;\n Tue, 24 Mar 2026 15:51:36 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774392698; cv=pass;\n b=cco6kolck3CZxpY7o6K8/KzV3dDkXqZIGAHtk3Ht8DhmOg2ZiKQjO8zWgRYHLhxAykaQoMDmca5zmIhzJD0RIhhvtcwiWdt9nrZr2LDAW8UFyR0n3vs8BO8bk/6WoYRuXeNJg1jUhM9gG8tWiyeu0O1srMJjnOvQ0sGc7YL38N4=","i=1; a=rsa-sha256; t=1774392695; cv=none;\n d=google.com; s=arc-20240605;\n b=TOC+CDNxB6xRAYWBUKqt64FMJlrAEHsH4/Wsl6FVcByEDKtUSWVebm2zjghvf1lWIR\n 2Www7zw7cCpBnl4jea5zsSJr4/4IcTjMyMr+f0V1fUn/G4wq+ZzQqe6UwL6PdaR95f2t\n 7aEea3blzfJ/94AKAS0O60fRfu2YkhXrtrHtFw6oopDMluJPQ+ezxjvqLBKoDzYqDtB2\n 71azEjTjT+TXhlPaEhzSI/w3FjRi7MKJ9P4stJaKRZihv53VJ4WIXohlYC6LLQ9dw2dD\n 3FP5Ac9qGA8NO2p8U1qYFPGpbMnUwoAzYG8+ff8FqxOhMBdW/BggjqDHZ2ROPQBT/1ms\n a8tA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774392698; c=relaxed/simple;\n\tbh=+qXP9sVKYUOKuJIDu7AMgVkUE6R3DEV9njuXFICjCso=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=LiwgYO2uuP0l0rrlD7JdyWnyqd7/OBLx++xoHfRsIq9hbVFxJcWULp32Ucp3aBqmWZH7mmcL8qSncS+rfAjHsBser44TEXgZGfR2znCMpa7I8QhBGilIWxa1yLniIrEpuWcEDq/V6TY3fXDcyLrI55wJXxaCn8udu+Ucakgu/Vo=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=WctkEVUbtVnkK6Q8WGc9tEDZcZ0w4yuEbEhi4SlKtQ8=;\n fh=bqbCqXOjbznW543dNw6xPwfojb9MXY2vqfJFyFLUhPM=;\n b=Cm6/c5nr0r330OKyavXQn4QaJkOujkGccDS1UKSy9YjPTmm/KyQSL+7IjGW2hckwOS\n qWHP48Mj85rRqMLpVY/MarSZvEmHiqJruiTr+Ugn/G7G6wwuB2yy3+i7QuyYtZGr8J0v\n yLCWIgccPN+qAKVD3JOjvcYPhJXC1VblHgPslAvGMTBOsqFVWMNNwad3u/fKFK+Oe0gf\n dhGCuh+/qcPUOlXUkWoEcp2Yi3bp8DL+7L+ZdAtAwfvRHcWUEZrtVSscnnfRYCLNuVR1\n whfbxpcc/kSwsXEm/PJrfQvKEJD6bKzME/qy7d4bn5tR1ciJZxVzx5lTPEqFO2CdnHI8\n RiaA==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=CwFHLGZC; arc=pass smtp.client-ip=209.85.218.46","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774392695; x=1774997495;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WctkEVUbtVnkK6Q8WGc9tEDZcZ0w4yuEbEhi4SlKtQ8=;\n b=CwFHLGZCkJ1e03UPuiX5krsGaPLFQL7sxz4MEAMJgj0iehiDXizYP8ozliqrsuNn/T\n 5guAt015LPCwQ9a2NVs3YloEX4mMEYor/XhcTXvOWZYJOPaDeDUydu71sri/uvlbv/cO\n Iq22vNQ/0ycpJwkmZdyMMb6Ss18k4vv41QXEDTcKxTlsSd+RRIW63vxAYbgcJfkKIR1Q\n Dzx3sa97fTCcRgEZhZD4/Y5jWJ0UcG3tWdqFz9NPPwGirVVvbf8im4A1EULwutNcRpdP\n mcEDSxHeq0Qnh+bxD79k0VIfqjceVhNHxCVXEr8DTkSIV8SrPa4kQX82UaQhhmQBudCV\n oMAw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774392695; x=1774997495;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=WctkEVUbtVnkK6Q8WGc9tEDZcZ0w4yuEbEhi4SlKtQ8=;\n b=PgbranHjRAjA3bqOQij9p1+YsKQR8MPkBtdGBiR5ou75SoZS93YK4yzuOn/xc0uubp\n Rh4F3vbrYriuyPmuS6KX6DmBGI1YZ0CLMe44DHZIamq2PCrJoMApWZEhyLxVmqHSpJIq\n t5gU+34uuivOtBeevyf+r26ZjYTd/eo0fwQ2Lo8d6NbvWCB1KxTNc9WTAyDF/8Hx9Z72\n F6k8P27w36Em26PqRuym8EDOS+Ez+gAl3e0SPb2pdLV/A9rWH43uo1hUdmwMVYkJuJri\n Xvat0Pc5NUnEPCMAssRdUOxpxtlVufiPom2WrYh5NNFcne3raZmr8TVBi1qtd2emSz1v\n d5/w==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXUOUBmYA9i+OCsp6hw5kmiO1tUsIiJqAXR90vGFQ+ER1qOnVLPeuiFOx8HgHiPd2kG3+ozx3e1bPGg4A==@vger.kernel.org","X-Gm-Message-State":"AOJu0Yw5Q3A1ZKq+kZ3gBFj9nCVA75uqExP5mfoutCKW4ylN+GM8fmZ0\n\tzDITX85nOUlPhAWde4TScPdBQvNe+Pk2+KHo+yHqBKzal78PwXB6B7RoQzOFw84L65oSApalf/j\n\tNqNpd4lVg2+AZp548qZKjE87N7SLLlzo=","X-Gm-Gg":"ATEYQzzlJZRDZwavB61N55Ip4/WhRx3+JpZlS84MT9S/gk/HWXtcXITzuWHXM8zoAMA\n\tPaSxGZGjhzcGlucxkW2jSrRqjV6EVaRvKPZSV96QYaZCpyAXGJrsX3x6m1B/7cl2wDlOMGeulu8\n\tY6jekFDFCi1nD/CH3vSAq4tJe7dYWdWnLjKanUu4xFaDJ4RffAco/HlQEePPKr2cME5XXz90nkE\n\t4/56M8NEzpa+ofr1oAM8s4ZwuFgmy/M+p781P/rf4Lrim6gLfR90gSNzvwUpg1PlhuTynp6dKu+\n\tWoTWX6qhff5UTHoqYOmhYyh5bGcO0mF0+uFcWd50Or+djx4gc2UuWnCqAnK2if+BTzAnVkj1h9a\n\trDsjdFg==","X-Received":"by 2002:a17:907:1b1a:b0:b94:858:5807 with SMTP id\n a640c23a62f3a-b9a3f1bfacdmr71915366b.25.1774392694712; Tue, 24 Mar 2026\n 15:51:34 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260324211629.26924-1-rosenp@gmail.com>\n ","In-Reply-To":"","From":"Rosen Penev ","Date":"Tue, 24 Mar 2026 15:51:22 -0700","X-Gm-Features":"AQROBzDG9HLcy6ZZFtAcMMsz4Ap-uzTwEmXmIP_QB0BxHWCJBnLwKSo3zzcgR9s","Message-ID":"\n ","Subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","To":"Damien Le Moal ","Cc":"linux-ide@vger.kernel.org, Niklas Cassel ,\n\tThierry Reding ,\n Jonathan Hunter ,\n\t\"open list:TEGRA ARCHITECTURE SUPPORT\" ,\n open list ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3668857,"web_url":"http://patchwork.ozlabs.org/comment/3668857/","msgid":"","list_archive_url":null,"date":"2026-03-25T07:30:56","subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","submitter":{"id":87751,"url":"http://patchwork.ozlabs.org/api/people/87751/","name":"Niklas Cassel","email":"cassel@kernel.org"},"content":"Hello Rosen,\n\nsubject is a bit misleading:\n\"remove kcalloc\"\nyou are removing devm_kcalloc(), so device managed.\n\n\nOn Tue, Mar 24, 2026 at 02:16:29PM -0700, Rosen Penev wrote:\n> Combine allocations into one by using a flexible array member.\n> \n> Signed-off-by: Rosen Penev \n> ---\n> drivers/ata/ahci_tegra.c | 15 ++++++---------\n> 1 file changed, 6 insertions(+), 9 deletions(-)\n> \n> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c\n> index 44584eed6374..5972fe04ff3f 100644\n> --- a/drivers/ata/ahci_tegra.c\n> +++ b/drivers/ata/ahci_tegra.c\n> @@ -175,8 +175,9 @@ struct tegra_ahci_priv {\n> \tstruct reset_control\t *sata_cold_rst;\n> \t/* Needs special handling, cannot use ahci_platform */\n> \tstruct clk\t\t *sata_clk;\n> -\tstruct regulator_bulk_data *supplies;\n> \tconst struct tegra_ahci_soc *soc;\n> +\n> +\tstruct regulator_bulk_data supplies[];\n\nPersonally I'm not a big fan of flexible array members, as there can be\nonly one. And if you use it you want to use counted_by().\n\nYes, there are two device managed allocations. But is that so bad?\n\nSince it is device managed, it will get freed on device removal anyway.\n\n\nKind regards,\nNiklas","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=s9M27qkL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13181-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"s9M27qkL\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgdsB4z4Kz1xy1\n\tfor ; Wed, 25 Mar 2026 18:32:14 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 4B71D300CFD1\n\tfor ; Wed, 25 Mar 2026 07:31:02 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D6567366542;\n\tWed, 25 Mar 2026 07:31:01 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D8E035294F;\n\tWed, 25 Mar 2026 07:31:01 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 2D85FC4CEF7;\n\tWed, 25 Mar 2026 07:30:58 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774423861; cv=none;\n b=PeS9Hsthxm28nOXfDoOKN7Qf3st7zTg5z/HAkCJvj6XU1jy27sl9R5oWdjdTV5wwYygZOvLl0hR4nlQWnUw9lrXBWnERrXyavHSj4ACQ6Oj4ShXSbxSNFCYzemdMDC1SveXorvNW2VJk23mtF8p1PEErtmcIvgF6NKmtFhqD1pE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774423861; c=relaxed/simple;\n\tbh=T+WQgv6CGi+A2a07WHGeBTAyLZMIg8BE4jhyIRJvFaQ=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=H3zd6+f7Nc1WfD9OZrbJZQLGInLaKp8HdYGGVqf5V5Bseu3HG48+HZGEJSwJhGC+puysFn1l+FbqoMVafcR3Fy3RwNERe9it4ITrprEy0Grv8LCSqtRwxuuy+Ea1muM1e4VBpJw12w7gIMjHNhhRW3Hi6RBz1cz6+Pd+kx73FEA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=s9M27qkL; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1774423860;\n\tbh=T+WQgv6CGi+A2a07WHGeBTAyLZMIg8BE4jhyIRJvFaQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=s9M27qkLmEGWvBvR/99BjIjP4EQ/GNcAWrKW7BuEV8n0Ooc5Lvi/yU6UhuTpUxipV\n\t KW4mNrQCY14i0iL/mhYBbBNr3C3rPc5S7RBe7/tX8HvdiiDGhX3YzrrG3M1u1uskZM\n\t H9IvEYOYdPeC9mAYsfWct6aDT68gVWHaO48gpLneyTCMPFDZsQrpcEsnSD6rzxETh/\n\t DGuj7Fit/+3VqysvE/afnxeKh0gJSfQLPEPWuAipoBwm3EEm2+xUprAxRLcjVP8B/D\n\t OPc9crQA70LAr2H9zYOWAQI6k3g/Lg950HPJ1x4TCkANKHqqiWu1wLbvxSdrpowUaa\n\t HriffsIDXsKrQ==","Date":"Wed, 25 Mar 2026 08:30:56 +0100","From":"Niklas Cassel ","To":"Rosen Penev ","Cc":"linux-ide@vger.kernel.org, Damien Le Moal ,\n\tThierry Reding ,\n\tJonathan Hunter ,\n\t\"open list:TEGRA ARCHITECTURE SUPPORT\" ,\n\topen list ","Subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","Message-ID":"","References":"<20260324211629.26924-1-rosenp@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260324211629.26924-1-rosenp@gmail.com>"}},{"id":3668955,"web_url":"http://patchwork.ozlabs.org/comment/3668955/","msgid":"<63d71f4c-97c0-4c2f-ac92-0a643fcdf75f@nvidia.com>","list_archive_url":null,"date":"2026-03-25T10:17:27","subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 25/03/2026 07:30, Niklas Cassel wrote:\n> Hello Rosen,\n> \n> subject is a bit misleading:\n> \"remove kcalloc\"\n> you are removing devm_kcalloc(), so device managed.\n> \n> \n> On Tue, Mar 24, 2026 at 02:16:29PM -0700, Rosen Penev wrote:\n>> Combine allocations into one by using a flexible array member.\n>>\n>> Signed-off-by: Rosen Penev \n>> ---\n>> drivers/ata/ahci_tegra.c | 15 ++++++---------\n>> 1 file changed, 6 insertions(+), 9 deletions(-)\n>>\n>> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c\n>> index 44584eed6374..5972fe04ff3f 100644\n>> --- a/drivers/ata/ahci_tegra.c\n>> +++ b/drivers/ata/ahci_tegra.c\n>> @@ -175,8 +175,9 @@ struct tegra_ahci_priv {\n>> \tstruct reset_control\t *sata_cold_rst;\n>> \t/* Needs special handling, cannot use ahci_platform */\n>> \tstruct clk\t\t *sata_clk;\n>> -\tstruct regulator_bulk_data *supplies;\n>> \tconst struct tegra_ahci_soc *soc;\n>> +\n>> +\tstruct regulator_bulk_data supplies[];\n> \n> Personally I'm not a big fan of flexible array members, as there can be\n> only one. And if you use it you want to use counted_by().\n> \n> Yes, there are two device managed allocations. But is that so bad?\n> \n> Since it is device managed, it will get freed on device removal anyway.\n\nFWIW I am not a big fan of this either. It is not an obvious bang for \nthe buck for me. The one downside I see is that it does leave the door \nopen for someone accidentally putting another variable after the \nflexible array member. Yes we should catch this in review, but there \nreally should be at least a comment saying this must be the final member \nof the struct.\n\nJon","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=l6hz2mOA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13197-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"l6hz2mOA\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.61.36","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgjfg6XB8z1xy1\n\tfor ; Wed, 25 Mar 2026 21:23:23 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id AF573315EB2D\n\tfor ; Wed, 25 Mar 2026 10:17:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7A9A23B47C8;\n\tWed, 25 Mar 2026 10:17:35 +0000 (UTC)","from DM1PR04CU001.outbound.protection.outlook.com\n (mail-centralusazon11010036.outbound.protection.outlook.com [52.101.61.36])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CD99C3B38B2;\n\tWed, 25 Mar 2026 10:17:33 +0000 (UTC)","from DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12)\n by CY5PR12MB6573.namprd12.prod.outlook.com (2603:10b6:930:43::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Wed, 25 Mar\n 2026 10:17:30 +0000","from DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391]) by DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391%6]) with mapi id 15.20.9769.004; Wed, 25 Mar 2026\n 10:17:30 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774433855; cv=fail;\n b=XwhtZPFBegkWr5bascihWu1WfkY5RYamBMsqikVX+L4NiasovoueockOhH5yH6CSJQrTPzO/ZFnxQj9jWJ4jfZHmmF632mi68/OSarTMX0XZUyTf0TmqZStzxFOL5/2QsMOTG4oaqRGwNBtxfT0bhtoJ5fVtFQkMSuFdFBVSvQI=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=gLVzmX0p7QdLa8PWgpvm6Uf+Za77Wy5GNFg+FLa0/BzWZdC5Y7zPginL3i3rGMXC9eMVVdFMf2r5A9xeXuCPv2XEdg5GPeY0a8N2ioy4XTPugrZvjTtZ4Mv1rNb7tLaiY0iwAe12OhG5apwCkqB4r/bQymTnVUEk1CK0IcDOXV0ulJAGr/PGMIno60GOSv1jGiRZn/kOVrUJ5Y9j2Yc+pBveF+gcp6CxzqL/V0VclsLFcG6G7xtflP0daOqqeG07i7rs6wJ0FJrEAUDWyh2t6rZPHWSnUK7mFDw9dUnmowVkbK7jmQVVIz16wOv/2StgbaIdODqDPUuCNJE7cB7NTA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774433855; c=relaxed/simple;\n\tbh=IbbaP7l4xdnMnlmPocIDYKv90S9eBdjokkLQ7kgefr0=;\n\th=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=HQhmVbEV5054wTn1n1Hwr23dFsdTbp7pwUdJ/wzxSk08onzEqoWOP/iUCsJGjQHmMVU6CMvtoCR7DhYegedWDkuW1KyWBfvM3spdus+9bHVKxTRCcBrawYSQNZY8qiYTCm0VDrzjJ/Vi8UbeFtqB7wA1z7FxE4BdE7b0QR0WbN4=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=+iknQAC1cW3rclfCh+9O/9zL9JQt+1JHvsmRULzOKMo=;\n b=JVCZRyt5fLrA3ADbdL7tVMSkU2j0Edpri2Ks11O+Osst8fmB4JOJtxqlnuUybuldZ45axDllCmEvuoxC8ZetkWSnIMPwWH6zM5Rv9Q7YPIMny0YkclCmgN83SI4VALmuLXOaKrQJh6C98otPOtdAQJfDcZUvY8GHbrgspNXtnA3yUdz3HaPNirnTov2+W59Le46WTfZNIj5V3nGW1VhJibmwoDaBbW7AAwVpVM+nEmqznRUwa38yKxP4aRD01qjYqGa3jMP7zi4zlb1BPTF503w0j6IC4wux0wPtamf9wRIwq3VaRR189QmgC9Ry9n/kDiwZjJyEP2unoyc5VgLFKA=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=l6hz2mOA; arc=fail smtp.client-ip=52.101.61.36","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=+iknQAC1cW3rclfCh+9O/9zL9JQt+1JHvsmRULzOKMo=;\n b=l6hz2mOA06DqpUpzEygkwdo3SV1q8DGOnoiYA0t15DInMgq7wDq/woBOrLTbA6lM7lZwmSPVoeeJNLNCFXqPhRgEX1kEzTKzgYZ33OtBGEMEuvqnRZpGGBmZiUxqM+rvV3ue/FKIJ16hfDyvNo/QI5Z6NO2UCyOewPcF8TDGTf9PwDXZhF8k0ypbKvxDsB/HCjLU0tjxijQ/E5NP0x9a2nLjnwrA9Cgd5x3I2uLZW1t6vKJEnfyUzqIngsSrsrThDWgiRpm2Uny2Ha4mR84A42Sgy/5/n+dJuZ24gzXlU1ycu7NhAO1LGaSnWr85QXqxHbFtZ65c1TDEITBi2vd/uA==","Message-ID":"<63d71f4c-97c0-4c2f-ac92-0a643fcdf75f@nvidia.com>","Date":"Wed, 25 Mar 2026 10:17:27 +0000","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","To":"Niklas Cassel , Rosen Penev ","Cc":"linux-ide@vger.kernel.org, Damien Le Moal ,\n Thierry Reding ,\n \"open list:TEGRA ARCHITECTURE SUPPORT\" ,\n open list ","References":"<20260324211629.26924-1-rosenp@gmail.com> ","From":"Jon Hunter ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"LO4P302CA0001.GBRP302.PROD.OUTLOOK.COM\n (2603:10a6:600:2c2::6) To DS2PR12MB9750.namprd12.prod.outlook.com\n (2603:10b6:8:2b0::12)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS2PR12MB9750:EE_|CY5PR12MB6573:EE_","X-MS-Office365-Filtering-Correlation-Id":"83e0e1bf-10ae-4a37-838b-08de8a57b929","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|376014|10070799003|366016|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n\tjy7T9GUTiGKi7HHLYeE11iPAd0CYLLD5fu4ziG1pF8NO2q8KrB9JYGt9oXcup9H1991e8tCkEU+Qf7beMJ02O8pwgcVvncWXksmw2p4yhBxJBNddF5C1iCfOiIbMCo1PvfDtxMePRjYSo1kNHJPvUE2FOJbWquvGb49kiIZe32ftZu+fEAEYUtH+19XbZMeGXR+Okcn8DDk7FjsMYP0Xjv9FtH1Yz5QhKrfEzd6EDQoxpfyNNoHiv1CsK5iP/ggtCB4ePtXXf1E5gVfbGWRyyICAOC4wk6kdPbGIlEAgFhSU2Nkarid+x01LwVR4ff2m4SiPjl+/K2BdoLCEVtMbkj0naJPxIdJsOcKv6MkPvUiFELNuQwjPEP3amh+I4SVrUwkRG5BqEyNjOEfUv3VZB0SqVDbVdVLCziWUgMB+tWQX8ArOEGpXzvSke4oTUQNNRea18FoWkJz0CZE1a4mTPfelc3xjoCHzQn6AaReBoPPNyoC0xD2qa0Wb/UsgMDxDWKLAIRtDvFJeoReo0MefgDiCUcQJKG/yo1XFdszAYtSWSewVyYoHlXcMUPjgE106i/2BcR8bxdIiOsgPscNGdrSjDAzpkJFpHo+1x8JxfpQhD95BDHXAjuaVSsX42UQX1PEFqK6gebAvhIOxCHZz7X0hvyPbrBXLxbykLzRKSv1D6lQnVBPvM6D82vGa3yaIjd7d2Q0fG6o0SuSp5rbTwHg49K/sY2OnnnkKMaJ05U8=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9750.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(10070799003)(366016)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?ij4OYxtEfZ1OkZwNufUQkf2bavYN?=\n\t=?utf-8?q?x4rldh0273HtlQhe9zYbrQDck7aq0fMqSeSrSURJfWJVLgI2xPUVxq6AVzrGHJgWb?=\n\t=?utf-8?q?y/Ike8OXWbZghIZica6pZtx58p6HptuwHHS7eido/krCpmYSJz6Tr/Cgi5m34gpQk?=\n\t=?utf-8?q?F2UJU7T+oYGT3Bw2bwDfsEzZfaYvxMZzkR/km+W4X/ccXqiBUMBtW4QylmjxPzIDn?=\n\t=?utf-8?q?L5176OEdfTV9ArhWqUuQAktgeqD575i2bqXRy74UORbkokyVVqjgibzaH/5T3VgNr?=\n\t=?utf-8?q?uvxn6em5qlYO9AAaGz/yJfq39Q6YAaC9WnoouQJuTmMRe1DYPkBEFeff9oIBYJCXK?=\n\t=?utf-8?q?jRulJljeN/mkwwkuGRHKN6bCxp0qXCzC8RfCRiAVe3h0I6QEKA98c6OvdnvmzV4bH?=\n\t=?utf-8?q?ILOuYQZVacxOoACJrFXRY3daPZweNTw25uiaWInmM4ynjEK1x+VZMc2wDpmE5W2+E?=\n\t=?utf-8?q?w7SeUflUW6QZrK+jFhrpoKpQl1gtjR+MOW580r8ZAOTNzkRFWbm/9Kib8GZCmTa2M?=\n\t=?utf-8?q?/BSy9XzmaP082LUtUnDTjW97xWFKE8vEZIEcm60YXxJJsy+gFrHfAEARoaLVBh+zj?=\n\t=?utf-8?q?Qpxc5XmX9NrTBLK7lk59P5HRVL/5q7EvmMA2cpkrdDeeopR9mK1NSiCtB12Rg4AHW?=\n\t=?utf-8?q?Ga6I5Afi50RUqU1+67Cm61sTX9UGj9hRqFXPRyUNlrexL/yijMmZ9m3QoJ6vbqfos?=\n\t=?utf-8?q?UgIIKq4vnytrpotZeOqWVAs1WKjpXTl875TeH2wxPDUlsyNeUj/F/GD5/6FdgG6iv?=\n\t=?utf-8?q?LLSBl3ULhHrLlTqCn4uKV30MNjIcYbnoDwGR5viod20OKCRMiEaiA9OCJ4l6puJIk?=\n\t=?utf-8?q?eNCMxV8uSI5G9Xus7SwhmEW2JpfG4US58FKVtABhjgc8075RNnfOyykMGu9NkfcCZ?=\n\t=?utf-8?q?sDrNqRb8Rozo6UIp+rvQqLDfo0x32W2EA7UcItUvs8hUfjv/jZlOYH6q+eMDZXZNj?=\n\t=?utf-8?q?mze5wniaXorWR6q2yXoC5spC8tgsLzG6AY2cZbd2zuKTUDshFscHwjCUNus7b+mpk?=\n\t=?utf-8?q?+8otmN9AbCF3vBiD5ljTCNRaxYJAmFndMicxLLk3iqWYinJXLYyYB0p8HxCUk1OZf?=\n\t=?utf-8?q?BMqhzaP/wp5sfdrV6vt3ER7cYRhK8HHHPoO0gooZiYlSp9ILTsIX8iVxwt+nl6gsH?=\n\t=?utf-8?q?jeCyE1s7b1H9dNu6LcQdxoLGPYaMSs1G0fWOL0PL6c2IRW3VBOCxpV8ccF4SaVmgi?=\n\t=?utf-8?q?tULe12wXDVBxqlOF99ykESEwWEgEN5+RWKCNprR1c30CHXlkpzPpoVcNlpiSFsU9E?=\n\t=?utf-8?q?hbeMvpFA2dT8bIY12mClafn/2B+FRWTR3wrUxFVNhNhxXGDxDjLyFJXAeTUBUYMRZ?=\n\t=?utf-8?q?PLDxugVKj4jr+7tzAt7eM/Ie1ScrxeQztpAfbn+8gHl7QOoe3Y6u/apAgiwcJGOv3?=\n\t=?utf-8?q?NfmsvOx4KP6CpFTSwo4Qx4K+z0Yy3jwlnEBdBf2ZcRMq/Etj86BCRjrNn3H/CBlLg?=\n\t=?utf-8?q?fc/2158w8pDuXaHGc1IhKUKK13pki64+W7cjBexI0S2DXAJ1urcPcy/HGZI54J+j5?=\n\t=?utf-8?q?yBCoyYwjEePugLuW/RDL1JOdBRVFPNokylVVgApzeKx5i8hH8CRHz9fmIqFa1YCLo?=\n\t=?utf-8?q?5WSmd8CfXn1cRyxqikRJMQcV+bpWrWG3934uP7ZZ6SJsgqaogvsq7OWe18RtMAcTV?=\n\t=?utf-8?q?sit+LyuYN+iSrCocSsr75Q8teHXkHyqPM0pobjbMuSdywdnYX/xAnER85guwHpEQF?=\n\t=?utf-8?q?4miaOOAVXQK1hI2eK?=","X-MS-Exchange-AntiSpam-MessageData-1":"dwm2dIs+ZFFnIQ==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 83e0e1bf-10ae-4a37-838b-08de8a57b929","X-MS-Exchange-CrossTenant-AuthSource":"DS2PR12MB9750.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"25 Mar 2026 10:17:30.7374\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n uw6UqPJxoIBnxFLzZ4O2sfe7qnwlUR1vn19nCQehN/tN7MjkTtRC1Ml5JmLpL1jo9KBAMew92yGVr9wyFm3hdQ==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY5PR12MB6573"}},{"id":3669393,"web_url":"http://patchwork.ozlabs.org/comment/3669393/","msgid":"","list_archive_url":null,"date":"2026-03-25T23:29:15","subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/people/70304/","name":"Rosen Penev","email":"rosenp@gmail.com"},"content":"On Wed, Mar 25, 2026 at 3:17 AM Jon Hunter wrote:\n>\n>\n> On 25/03/2026 07:30, Niklas Cassel wrote:\n> > Hello Rosen,\n> >\n> > subject is a bit misleading:\n> > \"remove kcalloc\"\n> > you are removing devm_kcalloc(), so device managed.\n> >\n> >\n> > On Tue, Mar 24, 2026 at 02:16:29PM -0700, Rosen Penev wrote:\n> >> Combine allocations into one by using a flexible array member.\n> >>\n> >> Signed-off-by: Rosen Penev \n> >> ---\n> >> drivers/ata/ahci_tegra.c | 15 ++++++---------\n> >> 1 file changed, 6 insertions(+), 9 deletions(-)\n> >>\n> >> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c\n> >> index 44584eed6374..5972fe04ff3f 100644\n> >> --- a/drivers/ata/ahci_tegra.c\n> >> +++ b/drivers/ata/ahci_tegra.c\n> >> @@ -175,8 +175,9 @@ struct tegra_ahci_priv {\n> >> struct reset_control *sata_cold_rst;\n> >> /* Needs special handling, cannot use ahci_platform */\n> >> struct clk *sata_clk;\n> >> - struct regulator_bulk_data *supplies;\n> >> const struct tegra_ahci_soc *soc;\n> >> +\n> >> + struct regulator_bulk_data supplies[];\n> >\n> > Personally I'm not a big fan of flexible array members, as there can be\n> > only one. And if you use it you want to use counted_by().\n> >\n> > Yes, there are two device managed allocations. But is that so bad?\n> >\n> > Since it is device managed, it will get freed on device removal anyway.\n>\n> FWIW I am not a big fan of this either. It is not an obvious bang for\n> the buck for me. The one downside I see is that it does leave the door\n> open for someone accidentally putting another variable after the\n> flexible array member. Yes we should catch this in review, but there\n> really should be at least a comment saying this must be the final member\n> of the struct.\nThat will eventually become a compile time error. Currently there are\na bunch of those cases that need to get fixed before that happens.\nHardening people are working on it.\n>\n> Jon\n>\n> --\n> nvpublic\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=GH6YqjaF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13260-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"GH6YqjaF\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.208.52","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fh38h03SRz1y1G\n\tfor ; Thu, 26 Mar 2026 10:32:04 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 7A74D3001FB7\n\tfor ; Wed, 25 Mar 2026 23:29:31 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8A2933988E4;\n\tWed, 25 Mar 2026 23:29:30 +0000 (UTC)","from mail-ed1-f52.google.com (mail-ed1-f52.google.com\n [209.85.208.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E95139099B\n\tfor ; Wed, 25 Mar 2026 23:29:28 +0000 (UTC)","by mail-ed1-f52.google.com with SMTP id\n 4fb4d7f45d1cf-6634bb959a2so459140a12.1\n for ;\n Wed, 25 Mar 2026 16:29:28 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774481370; cv=pass;\n b=PCO9aSrmAsAKSPcz5KxapoyfPbvqajUBPiB6l4ZggB6r2OPAKSvxqMWfBvqn36YlY4QGViWJ/48YOYccuoByAuTCAHra2qF5r+yP7kPnywW6eS58i5BWN14gAs7HLuGzEJZ6de/DlYPe4RbImFrpLCOfVNclbbvXqCdlolxj6rs=","i=1; a=rsa-sha256; t=1774481367; cv=none;\n d=google.com; s=arc-20240605;\n b=X5MT8jWWsWXi3mVsOnzgwAyOdee371jxZJZegP5g8F3MOLSKzcU92gNKSae8txuBoE\n VAYJBhD5VHLduk1Uv6W5JKHKsoTVf1D35cLkyDtye0WpYBthT4ITTSAEUsQRnLzkOcBi\n ocfAiXj6nIhgZCWmCZYSjjMnYoT09xderRocOnQkHkZeZLo/G6UDVZ41SHvBf7p9hi+T\n zV5Lq1PRMqKKfi5aE/cPhZGLfTIW74CacnZ14GLSHfYoYAMLn9GnHgYgxONL+mv9hrCe\n eaUIRqoPaFwnzTJ46z4Vgs8YJf0rtwS0+zVzzOBFb23W1fFmA45K0lXVbhUsTum+2uUX\n Udcg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774481370; c=relaxed/simple;\n\tbh=9PfOuH8Ct/5D7RdkrZwZ/TjP2xXwetK52YTBgVhbvFk=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=s/KvlLTRSFt95MraP7mWQXBrL8cV0FxtU1X9ZsOLjv2X+LXZvDcuHJy4wvuIA9EZ/8hUxhYOAxuaCgyKzAQ2ROhL1eoK18aM/2fR7xu7fPl53vO+WE08K1VPhMXgf5/Qj02L5IdXdFS0S9iTyxvSpaK1uX83tTXz4XGZXQurTco=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=CE1+v6tpKBUDw5Z0AisbXwa5/W6ogM5hGnxRKw1Lv10=;\n fh=KLd0H7+4iKQrIgtIW2qkcg4+qpFHKFWAWC42QJWvTWo=;\n b=laN4J4tksUKp6kPMsJ7rR/k/VvuodPgadJq9AFoIQyluM7vKphkjfpGQy/YawS+V3e\n 3ByjDwMmq67VdrLkQi9T5fB7sVz0zLAP+zcwzNIcIJBujGEvlmrDGy5OATHZ/QhlFdCQ\n VrHBiDSjtSUmtYsssXY9hckH66SSwLxFV29YZZiT82su7NphI4rIHbvgQYjGOCbTQPRJ\n NEwHHi71B3uhhxa3cRYdDjlWLDMwe87plNYVMnLtEIMCVR/5MrFV2N6dhWulkQob9dEX\n ftem/UAdbeeU1ZzfUnmgWA+Qru3Q8DYIiu99lPWvotlSHndFbmUfWvfD8x7GhueQoXjZ\n rMJw==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=GH6YqjaF; arc=pass smtp.client-ip=209.85.208.52","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1774481367; x=1775086167;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=CE1+v6tpKBUDw5Z0AisbXwa5/W6ogM5hGnxRKw1Lv10=;\n b=GH6YqjaFoP4jsE6Ea1HY70lAv8IM3YFTlETNh38noswH6+APU8mWczpNu0lIc2tYRP\n GE9cJGlmvX397OXsvHK5UzogrClYinJbimYeMUUxDRIddFuNnj/KKPG7wp5udezlhEAX\n cv+F9iyLPOfhFhY5qJiUPmQ6c+0KwN2H8aIyHKsp5Xp1PofysHzQkm8Pvh9nIzRVD8UA\n Yz6H/0Ok4h6+4llYbPd8z03kGBVzM7CriYRp1m/qpq9bqKD2ZlFiMUuh0NBnw4zce56i\n GunSPkS9vo3gObySEfh9OQWrZ/YntK0v9HEPUfGxn/y+pP6s4Dev7cwRzio8BJaX9Mdj\n Fw5Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774481367; x=1775086167;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=CE1+v6tpKBUDw5Z0AisbXwa5/W6ogM5hGnxRKw1Lv10=;\n b=FMlGTBEyEIAYv1Ad1ULfGIub9QGvy37+cWV1OxlKNOuQdiqxjaXEBxqmHRJzFOe0ZZ\n bmLXfFpIcbjXTz6LV4g+mHH3QILCpC7NueSEpJm4/yZxJ3WiAJXQOrMvU9Aoqqv/na/H\n FP/GVEb9LvSfe9L3gK/eOlFBwpUPOMQaA7moGoE3aetnssKpYDffYokIrUGVvpsL8WSl\n VhbXVfodvuwheqjSS1Ca3s32YMdM9sDc6Je5xhB4BpNgX1tROpin1UgsCZAuvBdtIOE1\n +3h4eIjYDgrK0VwHojz86dNGUwG6fcoPKWGiWMDkGoqyDL+7f+pdcUHb+k3PKwcbp3Bz\n eJuw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUMecV/ZWYZDhsGVw8/w74KIHiRZ5d093RHI7QqhxJOLqQmwpD50pO6inv6pq89Gzp3wAo2niNPKlEL2Q==@vger.kernel.org","X-Gm-Message-State":"AOJu0YyvjBJautn9mCkAsxWL5vjIObuFk6xldvQ3BTzQ2o5/NHnmy5Xu\n\ttMU/I+0H3TgKqU9vFiwQ/S8hOVFMihG0g+s1L3snuVzffbUL6FUUc7oF+D5476qt04syG5Czyla\n\t4VbRjIAfHMR1mkjqHhUHu72RcAmoiFQU=","X-Gm-Gg":"ATEYQzyNtj5FoYKhH5C6QRvOo8tmkm+MXnzM/ML/KyjEDy/LQo9juCVq79m8kLeHj/5\n\t3Gh9/H9XJK3p/L8cA+qsAwo7XafFCspq/Mb4nRAZn4/+/3XoJudyW7XaT0fAJWERIhq/RNX2B5A\n\tziv6OhMeExsPZL9VUlhnsFGPM03vCuUPYRT6B2kkJPYrE22W4EBuXQEe64Ox40gU5F96RnCqpH8\n\t99X4TVQIpHZ2FAAke9gkjRpFtvAHdxTS0v8hr9ED4/JdcU+z4LiB+2syU8S7AiK/QfMudGjjFAS\n\tz7uC1z1QD2+Y2fu8gIXcWo6aVMUWWHRIJx5GttnMBHb1XnjF/U/rZEh5SKAPsz3ayKqxqRkL4j7\n\trPcOdyQ==","X-Received":"by 2002:a17:907:1b21:b0:b98:5b2:77f7 with SMTP id\n a640c23a62f3a-b9a3f15dabfmr338827766b.12.1774481366307; Wed, 25 Mar 2026\n 16:29:26 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260324211629.26924-1-rosenp@gmail.com> \n <63d71f4c-97c0-4c2f-ac92-0a643fcdf75f@nvidia.com>","In-Reply-To":"<63d71f4c-97c0-4c2f-ac92-0a643fcdf75f@nvidia.com>","From":"Rosen Penev ","Date":"Wed, 25 Mar 2026 16:29:15 -0700","X-Gm-Features":"AQROBzARloAI-Ejm7HMIY4aVogCSDARNAJeQ6vsUaeQqP-i5QcBTlQ1inxF_Po0","Message-ID":"\n ","Subject":"Re: [PATCH] ata: ahci_tegra: remove kcalloc","To":"Jon Hunter ","Cc":"Niklas Cassel , linux-ide@vger.kernel.org,\n\tDamien Le Moal ,\n Thierry Reding ,\n\t\"open list:TEGRA ARCHITECTURE SUPPORT\" ,\n open list ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}}]