[{"id":3668935,"web_url":"http://patchwork.ozlabs.org/comment/3668935/","msgid":"","list_archive_url":null,"date":"2026-03-25T09:56:49","subject":"Re: [RFC PATCH v7 6/7] vmapple, gicv2m: add macOS compat quirk","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 24/3/26 21:48, Mohamed Mediouni wrote:\n> macOS expects bit 31 of MSI_TYPER to be set.\n> \n> Signed-off-by: Mohamed Mediouni \n> ---\n> hw/intc/arm_gicv2m.c | 5 +++++\n> hw/vmapple/vmapple.c | 1 +\n> 2 files changed, 6 insertions(+)\n\n\n> static void gicv2m_set_irq(void *opaque, int irq)\n> @@ -81,6 +82,9 @@ static uint64_t gicv2m_read(void *opaque, hwaddr offset,\n> case V2M_MSI_TYPER:\n> val = (s->base_spi + 32) << 16;\n> val |= s->num_spi;\n> + if (s->macos_compat) {\n> + val |= BIT(31);\n> + }\n> return val;\n> case V2M_MSI_IIDR:\n> /* We don't have any valid implementor so we leave that field as zero\n> @@ -173,6 +177,7 @@ static void gicv2m_init(Object *obj)\n> static const Property gicv2m_properties[] = {\n> DEFINE_PROP_UINT32(\"base-spi\", ARMGICv2mState, base_spi, 0),\n> DEFINE_PROP_UINT32(\"num-spi\", ARMGICv2mState, num_spi, 64),\n> + DEFINE_PROP_UINT32(\"macos-compat\", ARMGICv2mState, macos_compat, 0),\n\nDEFINE_PROP_BOOL(\"x-macos-compat\")?\n\n> };","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=vVqhjX9s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgj4z1wSHz1xy3\n\tfor ; Wed, 25 Mar 2026 20:57:39 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5Kyw-0002Wq-2A; Wed, 25 Mar 2026 05:56:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w5Kyt-0002WY-Pi\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 05:56:55 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w5Kys-00074B-Cr\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 05:56:55 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-486fba7ce4cso21703335e9.3\n for ; Wed, 25 Mar 2026 02:56:52 -0700 (PDT)","from [192.168.69.206] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48711693a08sm162176445e9.2.2026.03.25.02.56.49\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 25 Mar 2026 02:56:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774432611; x=1775037411; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=5g0B8H2F+sysjektrId4PyrhfUrsLAVnGGc5jrOOfys=;\n b=vVqhjX9sqo+zB3ahXyBtzKHuaXS7a5om35Hz6zbHvaxE+ZdBMqTdIMIFQJbXjas4FM\n TtCBZGifO4H3PBeUocdL5WfgBJJ0SS3EgiVhht0WLaLMQ5Vsct9h3zpWosjHtpMrLQ7K\n Ib3v2knyu+7fyUmejF9K1aRiKeQYFOWLj/yKAeqkQ7gw/5J7Z3RVl4On4m/Z2CuFLHfq\n Nw4tExAJAWkVL0AOGuO/ymrmWphTgxczI32zCSlY0zBnGX7xfA5Vjw75P8AamxaJuh/f\n +pnXoS82/Ss5o5jVG0P4uIwg/X3lXSXabjEseS/hinuPdaJQwiOuW91GionRuJRLq5lz\n h4eQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774432611; x=1775037411;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=5g0B8H2F+sysjektrId4PyrhfUrsLAVnGGc5jrOOfys=;\n b=lArJfZOU+M/SJn/UNU+jT1/+bd8ErEmWMetFtgImGSv5c95LufOByZixea3d09VTiv\n K4+BP77hHcX43x2tT3XyDZ6jiQ8E51LQX8W2h0eELeZDlZ9ad1HT78gVuiLU7xWriboL\n +TN6+KrOy/hAzCr/SChWwMvBT9bmOjsTob5ehz/+uILRHcpaSSfkcwMPLjiIDhPl06Qh\n 1XImBHCVXIltg+4gn6HbgZO5ZqlkdGqkgeiEcd2cl6uo0APX08xdHvU5Ph8kC7tHCk2U\n xeCJjqyx/sztinCwQVwaPUFivubeTjPmyM3lxlyjzWcqxzT+nahkDlx/v+EQS888rNdt\n zgMQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVuCrx2FK/wkd7eCyAwF6qKo96L0icpQu9FWLlb3o/ENsT1/jW9L21QQGxLen9PT9O6lyTt6LxSD/bn@nongnu.org","X-Gm-Message-State":"AOJu0YykvhQqu/sJvmxCBGls3JMqMq7YTzJJ2uErCLAmnSBGF8xUu4oS\n AD/25xVNNE5uyXUWivjNxrkR+pHQyNLhuACPNOnE625DQcEK7kiuvjTdNK2zgxRYCy0=","X-Gm-Gg":"ATEYQzyTVSvyHzo033sXge6raWn9uht3McVVIDHj159QiOvg9pAuyoF4eI9IhVEzu6g\n p6FOgpKpJzMAA93ZyD30RoBb1z7v7NnO7m+skzk0BoE4gu57VXiMG8nKtBucln376/ENWmnKGaS\n BOZjFXHrfPsfItlpT+WO2Y2+iay9ol8PzNAVywmm90GZyB9DiFhXt84dI3KipQ7iiEDcg3kOPqP\n MpDCol9Sj3IRhSzTbAkmAnr/Ss4ZCdZIORTOdUwAy+AJyd8ybzkMwC1cAA/ImLKpb2kqwf3i+hc\n QTqLxUuIJPNkR/KjhPpW/oURwRz5/WU7DXvg9EKrvZ4M8Q7wx6ULsc+aM5LqX21Bfu4vBJxqJTM\n ubHbEvlnxiz5Afx8hTYoTjxfW6UtQD0LQE9Rd9vxZNBfGTsceLcakqpEW+TUqgAu5MuxcOUMI69\n cTbNOIIABuqemNrci5UmH/m8zhnesUu5S91A5oBhjiajx8sxp5eXn8SoNOWTELN65jr6RrPCswE\n Ivs","X-Received":"by 2002:a05:600c:4f89:b0:487:1c2:6a79 with SMTP id\n 5b1f17b1804b1-48715fc39d3mr37961695e9.1.1774432610819;\n Wed, 25 Mar 2026 02:56:50 -0700 (PDT)","Message-ID":"","Date":"Wed, 25 Mar 2026 10:56:49 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH v7 6/7] vmapple, gicv2m: add macOS compat quirk","Content-Language":"en-US","To":"Mohamed Mediouni , qemu-devel@nongnu.org","Cc":"Akihiko Odaki , qemu-arm@nongnu.org,\n Peter Maydell , Paolo Bonzini\n , Phil Dennis-Jordan ,\n Peter Xu , Mads Ynddal ,\n Roman Bolshakov , Alexander Graf ","References":"<20260324204855.29759-1-mohamed@unpredictable.fr>\n <20260324204855.29759-7-mohamed@unpredictable.fr>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260324204855.29759-7-mohamed@unpredictable.fr>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]