[{"id":3669888,"web_url":"http://patchwork.ozlabs.org/comment/3669888/","msgid":"<0655c1a1-663e-43dc-bde6-4c0aca37cf9a@swupdate.org>","list_archive_url":null,"date":"2026-03-26T18:22:24","subject":"Re: [swupdate] [PATCH 1/1] build: fix no-crypto configuration link\n failure","submitter":{"id":86869,"url":"http://patchwork.ozlabs.org/api/people/86869/","name":"Stefano Babic","email":"stefano.babic@swupdate.org"},"content":"Hi James,\n\nOn 3/24/26 21:23, James Hilliard wrote:\n> When no crypto backend is selected, the crypto directory contributes\n> no objects, so this kbuild variant does not generate\n> crypto/built-in.o.\n> \n> The top-level build still linked that file unconditionally, causing\n> the final link to fail.\n> \n> Introduce a hidden SWUPDATE_CRYPTO helper selected by the Kconfig\n> options that actually populate crypto/, and only descend into the\n> crypto directory when that helper is enabled.\n> \n> Signed-off-by: James Hilliard \n> ---\n> Makefile | 3 ++-\n> crypto/Kconfig | 5 +++++\n> 2 files changed, 7 insertions(+), 1 deletion(-)\n> \n> diff --git a/Makefile b/Makefile\n> index aa9604aa..759fd191 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -369,7 +369,8 @@ include $(srctree)/Makefile.flags\n> # This allow a user to issue only 'make' to build a kernel including modules\n> # Defaults to vmlinux, but the arch makefile usually adds further targets\n> \n> -objs-y\t\t:= core handlers crypto bootloader suricatta\n> +objs-y\t\t:= core handlers bootloader suricatta\n> +objs-$(CONFIG_SWUPDATE_CRYPTO) += crypto\n> libs-y\t\t:= corelib mongoose parser fs containers\n> bindings-y\t:= bindings\n> tools-y\t\t:= tools\n> diff --git a/crypto/Kconfig b/crypto/Kconfig\n> index 1e2b4fe5..ee512456 100644\n> --- a/crypto/Kconfig\n> +++ b/crypto/Kconfig\n> @@ -27,9 +27,13 @@ menu \"Crypto libraries\"\n> \t\tdepends on HAVE_P11KIT\n> endmenu\n> \n> +config SWUPDATE_CRYPTO\n> +\tbool\n> +\n> config HASH_VERIFY\n> \tbool \"Allow to add sha256 hash to each image\"\n> \tdepends on SSL_IMPL_OPENSSL || SSL_IMPL_WOLFSSL || SSL_IMPL_MBEDTLS\n> +\tselect SWUPDATE_CRYPTO\n> \thelp\n> \t Allow to add a sha256 hash to an artifact.\n> \t This is automatically set in case of Signed Image\n> @@ -91,6 +95,7 @@ menu \"Encryption\"\n> config ENCRYPTED_IMAGES\n> \tbool \"Images can be encrypted with a symmetric key\"\n> \tdepends on SSL_IMPL_OPENSSL || SSL_IMPL_WOLFSSL || SSL_IMPL_MBEDTLS || PKCS11\n> +\tselect SWUPDATE_CRYPTO\n> comment \"Image encryption needs an SSL implementation\"\n> \tdepends on !SSL_IMPL_OPENSSL && !SSL_IMPL_WOLFSSL && !SSL_IMPL_MBEDTLS && !PKCS11\n> \n\nApplied to -master, thanks !\n\nBest regards,\nStefano Babic","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=googlegroups.com header.i=@googlegroups.com\n header.a=rsa-sha256 header.s=20251104 header.b=i7d0lzWc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com\n (client-ip=2a00:1450:4864:20::437; helo=mail-wr1-x437.google.com;\n envelope-from=swupdate+bncbd2zdgn6sekrbzhssxhamgqeymjttgy@googlegroups.com;\n receiver=patchwork.ozlabs.org)"],"Received":["from mail-wr1-x437.google.com (mail-wr1-x437.google.com\n [IPv6:2a00:1450:4864:20::437])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhXFD2R9Yz1yGD\n\tfor ; Fri, 27 Mar 2026 05:22:39 +1100 (AEDT)","by mail-wr1-x437.google.com with SMTP id\n ffacd0b85a97d-43b945c67fasf123493f8f.1\n for ;\n Thu, 26 Mar 2026 11:22:38 -0700 (PDT)","by 2002:a05:600c:4252:b0:485:3c80:a97b with SMTP id\n 5b1f17b1804b1-4871f1b8e91ls5949245e9.0.-pod-prod-09-eu; Thu, 26 Mar 2026\n 11:22:27 -0700 (PDT)","from mout.kundenserver.de (mout.kundenserver.de. [212.227.126.131])\n by gmr-mx.google.com with ESMTPS id\n 5b1f17b1804b1-48725d2a070si34015e9.0.2026.03.26.11.22.26\n for \n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 26 Mar 2026 11:22:26 -0700 (PDT)","from client.hidden.invalid by mrelayeu.kundenserver.de (mreue009\n [212.227.17.165]) with ESMTPSA (Nemesis) id 1Moewz-1vlpXM0BhZ-00a5uq; Thu, 26\n Mar 2026 19:22:25 +0100"],"ARC-Seal":["i=2; a=rsa-sha256; t=1774549351; cv=pass;\n d=google.com; s=arc-20240605;\n b=fyKna7kPnrO9QuLSDCv/Gh1coKTRAFmsEQZnltD5XfqJPzj7YILRbv6SBQId2hvT6e\n KyY9loRoopcrJpxjbTd59SFripXezLuPxUKn7KPOWEGqQdg9kQckvnW/r86TN7vKegn7\n iNl3Sx2scH+CWc/GEawkdYo/NrU+ZS7KCj2O8qgHKvfeXQmpO1T5rAxx7/3v19NHU83m\n hWLl/FzEnb/+z7/1sci6+8b/Fc3J+AQ5oG/4FtUo34NFdpzJwde933Jy/tW7T7kW8Od8\n XE06X1SxPWXTi5My16TvvwX3dcFmRE/VDv9DK1vkQbzr4N8zi1wLoJ91S/ibkXg/JLL5\n 6KZQ==","i=1; a=rsa-sha256; t=1774549346; cv=none;\n d=google.com; s=arc-20240605;\n b=CoXhtDx/Bffav4FUIKUusTDWYjp4vaLv2vjFiqNQqsoitGSj4P2RKzhm6kJYl8NBZt\n skKgi1VTj9hYPaTI/CFxCI+H0fgokl4jduhDoz5TWU2ZZ7+hPQSq8HWIs9D1dlaHlkpf\n WyMnAaDU3AFvM8xRpVuFE07WcS7wGiXuYayrKcim0J89zWyKJUhh6EGgHqk5kucRiW1m\n IQc1bfj1iqkCcSIEYEXRJaC0+7lTZldShQWoQQA8WZShSbYHGPd6QmwbQoqIcXpQ6s5i\n Wn4Z4Y+Cm58wyYF/cGpXT0JcUay9A3Qep2B+/ydcHQ/NtMk0EgDMo9hu0Zqye6HjEm9u\n n0ZA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :list-id:mailing-list:precedence:ui-outboundreport:in-reply-to:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:sender:dkim-signature;\n bh=2YBcclHKU1agXCjHxgasjwJ6BySzzZu+l4fjNVf2SDY=;\n fh=3LFaR+QP1bujPXI+x3mB6OWvhiD6bjoUAI0kCNyFWrA=;\n b=KeTycOkGiEuuTXEbCsI5PK6diOLG4W4OVIhBvE8Ldih/azHwY8xMhzUvKu0BYIRbeu\n QOOEhD/0EHcadfgyqWSlXUufnKBlJHNgKR2+JqsiXFFlG26hd8b4ytgOqjRzHwg1dF9S\n 8LxK/t5ktoNx5TxC8WpnBOAeGH36NdSi5YpOMS/jvr+zyGi496DzhgIhvWsFefk1+3A5\n 1XplhwOMGUdwozdA8EEHO3cX/YkmtPohv5RapBvlxyeiSNmkAPmixDNTpA1zB6aRXQwI\n 77fF3x33bSbItYHeL4y5Ew+fEv7NGCxQzIxsc4ahzxQ9Tr9qDYkL5bJpKJkkPEqq+ZqY\n 2miw==;\n darn=patchwork.ozlabs.org","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=ui-outboundreport:content-transfer-encoding:in-reply-to:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:dkim-signature;\n bh=7HWlanEihIxUxxIcseErEIiMI5rc5rekEA5cxDy4y1Q=;\n fh=BpvHpoAC4tpfwDL+MXFfOxrhBqN5GGjplsRZDG1o3iM=;\n b=F9/ECW+UUoGNp5EuXefCzKgJyzsYjsXvpOOs8lwhIBF5+4LAi68uwHfzjXhc0OkXq/\n ATqMBcBfZQcHF6roRthbVYwpZptvLrXP0L1vKC4l9nyG1ETUZ+UFvH7vcU6rdTiKmspD\n VEEt13mDYgMsNqUNEJ8IOvwrJPbIDv0xcBzwpq++MHzPLZUxm4V0yWzLgiuBQ81bdy9O\n YQ+91TcsOCBIiBRwJsFOXPwXqspajbc/z5tamXlg9zibY1nQbl+4BAqxWN2BcpdHFpBF\n ne/tzEQTEWbQzLgEkcp3A5pWSHEse7/k2WZEgLxObCteRhAdLLdpsfXIjdN5l5ziXwGZ\n ENZQ==;\n dara=google.com"],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=PNlADUOQ;\n spf=pass (google.com: domain of stefano.babic@swupdate.org designates\n 212.227.126.131 as permitted sender)\n smtp.mailfrom=stefano.babic@swupdate.org;\n dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=swupdate.org","i=1; gmr-mx.google.com;\n dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=PNlADUOQ;\n spf=pass (google.com: domain of stefano.babic@swupdate.org designates\n 212.227.126.131 as permitted sender)\n smtp.mailfrom=stefano.babic@swupdate.org;\n dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=swupdate.org"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=googlegroups.com; s=20251104; t=1774549351; x=1775154151;\n darn=patchwork.ozlabs.org;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :list-id:mailing-list:precedence:x-original-authentication-results\n :x-original-sender:ui-outboundreport:in-reply-to:from\n :content-language:references:cc:to:subject:user-agent:mime-version\n :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to;\n bh=2YBcclHKU1agXCjHxgasjwJ6BySzzZu+l4fjNVf2SDY=;\n b=i7d0lzWc9leEdcQOqFp34BzQXs50wI5MkaDXGICeCdLcsTbFSoRna75WixMcIxxhbI\n ZVJ7ZXTK+U4YySY3mEhPksRV0Yw2tdc4bJWXbFIYDEDFNzoMVjUvScLWGavJ7Cz1hKiR\n D8KMeSpr8RBEGFUSHEE+tu6/SGlpOaKi/xFGKAa458SEnVZIfIrka8uqjrIzorkDwUqh\n Le5nDSHpd5pNQdD/zyGxEuNI5T/Vfw+OYJlJEE0/odZ+rEhvoB5awZwzaKzqBjqp6EwA\n KvipYdTwUQYcHnYl/LYctUWqEbCP3KBugrYuN0xKKvW/UfM01x9f02/ZQb4LXfmedk8O\n uotQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774549351; x=1775154151;\n h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n :x-spam-checked-in-group:list-id:mailing-list:precedence\n :x-original-authentication-results:x-original-sender\n :ui-outboundreport:in-reply-to:from:content-language:references:cc\n :to:subject:user-agent:mime-version:date:message-id:x-beenthere\n :x-gm-message-state:sender:from:to:cc:subject:date:message-id\n :reply-to;\n bh=2YBcclHKU1agXCjHxgasjwJ6BySzzZu+l4fjNVf2SDY=;\n b=pw0ofWFk4t5MVV5KeV/VCf2U603GHs4/qrGvd+LvD41Q+712ds7vOgELu494ZHGVKB\n BAIq7tWfU7+lCTAmaYQ0HZVGhEK7O3WfwBJnK+f4+Cq9xMMsiMBYNJIat1XOV6mdSKXX\n mTKaa8cM+26xr0F/TZYKezx9MsD/djXmjbU4eEnecG6my0jSoo8ekqEZhtkFKRg0ed5S\n TAuBZgyh6jOGwzYpmAF1myOpx4Y7TadxgA73ZZhwhFJXsydOOjyHI8nXwStZnqLyMyyY\n +MjPR5l2LBBczjthYAlxLM8E9slGwXjBM1+qcg0xM7Xx+TrVdK54qkGzddnsD9Kmb4yb\n ZLeQ==","Sender":"swupdate@googlegroups.com","X-Forwarded-Encrypted":["i=2;\n AJvYcCUpPwyEKwLg/cDqqAq5d+MjlOCtcZuv4e0kD/e9uXCIHdvt7wqcmgVcdp/8jd+deDdjyUzzEcd8HA==@patchwork.ozlabs.org","i=2;\n AJvYcCVwrXE8XnA5nZiVrjSKU+DKb10MkW1vdLlsQ8KEdFEY1z951CzD80tqXHuSgugJREOfiQ0TMTTC4w==@googlegroups.com"],"X-Gm-Message-State":"AOJu0Yw8MbiE0kOtcszrNbF3+Q8tvr7XKfz+Wu2zOtOP/Kdae1yOweNG\n\txZER+FP4kzCT0kl7fAlH3QtE5qIs5zUKj6zFxpQpkXy684GQ5+xdyxZk","X-Received":["by 2002:a05:600c:5248:b0:487:1108:48b0 with SMTP id\n 5b1f17b1804b1-487160844ecmr78602955e9.4.1774549351146;\n Thu, 26 Mar 2026 11:22:31 -0700 (PDT)","by 2002:a05:600c:190e:b0:483:7903:c3b1 with SMTP id\n 5b1f17b1804b1-4871604c856mr126413345e9.20.1774549346944;\n Thu, 26 Mar 2026 11:22:26 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com;\n h=\"AYAyTiLTy8TfP/mv8qFnt4dP2+MSFMzqPAoymckQgr3sNJFOsQ==\"","Received-SPF":"pass (google.com: domain of stefano.babic@swupdate.org\n designates 212.227.126.131 as permitted sender) client-ip=212.227.126.131;","X-UI-Sender-Class":"55c96926-9e95-11ee-ae09-1f7a4046a0f6","Message-ID":"<0655c1a1-663e-43dc-bde6-4c0aca37cf9a@swupdate.org>","Date":"Thu, 26 Mar 2026 19:22:24 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [swupdate] [PATCH 1/1] build: fix no-crypto configuration link\n failure","To":"James Hilliard , swupdate@googlegroups.com","Cc":"Giulio Benetti ","References":"<20260324202358.977930-1-james.hilliard1@gmail.com>","Content-Language":"en-US","From":"Stefano Babic ","In-Reply-To":"<20260324202358.977930-1-james.hilliard1@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"; format=flowed","X-Provags-ID":"V03:K1:pv7DMiTNl9ywY3JtA8EOuj0CLC7uikAy5iQ7NHL+EMSqy1SLRwz\n eE3xcNDSXbqJcTYb5u7n51Z/GapOv64Q48HY4aDnNXBSARU8c+u58caOSLloDeKlVddhs2z\n um5UIKe4/m3DGcjFD1UoTz1o5up8Xh5GlEtclH6jXM+FasOQb5LFCck0OyNVej5VrvKkcaR\n HrGULmm1gbtZGjyqhoQjQ==","X-Spam-Flag":"NO","UI-OutboundReport":"notjunk:1;M01:P0:cNBZ1KjcAGU=;WW5FsxpCk1H+26OJNQY5k7J+ffC\n bBAf5QrXDHhrXnR+GRWHHUQzGllCOnqVQRyVzDJY2pMzGXfTrL7pbt0eiHx34t7HRO/P/cT64\n WWx9NIBvbEEjXtQYe0f59Nyuu4++/zWXdfkBGf+yis+QaktnaMEIcXv7LLlD48AQBa4gQO1zd\n 9Nnc4BTqCp7fcJaHS0MZxj3B3l214+HyXvL7vbXxMkzb1O4lZMeB+0PQ0f3jiYtSWnrAYXnHa\n 5tu6mphNkwjB1LsaefVcLG48XEMFyD6xxGhKGr8KPsUwNs8tJxG+gNtLdYFlcbRcFnJRLLZru\n sPMcb4VfnKsAbvcezPjaviStB0iA6agaAk+THBOA/57Fwo7gEpyaLfXnFb1VTqvw6kZ6q1lIj\n 3Cxh5I779cPGvkK3TClgMEuTjoECZlfeqFSXAW+JFB1mLAVDZB5IOFkf14pADQfefStkcmoi5\n 5pQUKCXhxS5PqekFMFP2XN0TJx33yBWVBV8/mHgQHURG89YpVqkYKKxM6NVHSZVsXq+9BNjfJ\n ISZRkvSxi5TcJfhVHMiVLoiv9pwCc2tepNd5m0A18dy5f2ly/5i7JOw9hJ41ncX3VgF7yjUms\n IOXq/am7P54ReQwMQ76ZkZ92tEP6U/tx0+79iZQ2Hz3cenzHVmDuQa+DnTnNYnZpIWegQVo5I\n 49avXILOPxFynhwKNFuDxUXsj7Ia7n68H2CQBfZ4HCkEXgc4q2MN3l0PczN5frvLKS8pa/F9M\n IqGJPSroFXfycOxUdnuRtALls7TeGJQhjiRmMnKbzF/U1n1on9/4T/PgwLwq2XgPZA3ZyXkf+\n MNjRKqZtuuceDi98tIAQaA+EZaFEw7nL18M5oTPsTB5OydlEE+qQlX0nTh8KMADIaUzC9+X8h\n pL9S3BxxeqOasr7CMIvjypGiLQ4mcsPXsxvnk7k6i49BIULnPXBSmCaIwJhb0epTUtfw8mOGH\n QuR2L1bpXLHwQCjAepoU2J6cdj1SiUT+Quk6Rd3dQ33UpH3xcmaEhbNeqZ7TQnl0Lk9Y2fPIN\n 5zpXM6pRbOPw3bjGsEG1lJ9ZRm4jbxXsRwvLILfASI3KePrlso52bL9YqbB4bT5NmpqDOiGWk\n GppXA5T6JyI6zQzAJZksnhcSbI490elDpcHsPNyJNZ/wmYnfUALGcGMKk48wVg00FTAzk1fdD\n BzX79JWwJB42xZPaB5wm1mA3yWsNsSk1sly4Krr1Hkq5YF8djmW7KWBtvkr5B9/gDrbrSv1cb\n 9x915UVX/KCcAhlVvUOWWnXm5JQLiCA/PKsSkwIHFlTuneaxeOd0zX+IKwrMiFRcmkXT0m/ff\n xZdcB1E78zdC+2HFfvbzn+aSGTFLnmxrK7AJ7v7M/jnPGcQNGRgtL3DO59DpDJBqGLXufB4J8\n r+0Epdv/n8z34KdSZCrjsWxho1udY6ye461sU5GuMAKjD7STUKRG+7GMpmc2QrefhIz8E7fAC\n vlA2LtqN+Lngk6p0EnuM+wXQ0a63oyBC+76JNmppgh0ZcXWwo7tbdn4nV/y7WPclfMkQ90/Y7\n Zr+jf9tJylZNqar1frbAE8gKfDNoO8FdFbZW53+32bQ+NOCv18+7KfpqQqW49G0/i28lxhQM0\n fZF16S0mB5x6tKg4w9YasBZCpbslom7WnkTV0Zox6Ff5V6PvkZU2kMS7eLcGavEfD33lqcSli\n jRSOqL4SgfNeFLVo5n3voZIZe8M0p2iUKnGxofpPdxS/Kwlojf6/YIv1WUu5E1knQSUEunYp5\n Zo4++FRyVEynNevFiYkpTuSvFsnKHjjmV0oZ/5M8Sg1hNTYmVA+X3C7HxUxmbsa8gUzrP9vt0\n LnldzHtspQdsvX+r+1/XkeHreaCogegXzbiCUlxLatBnj01H1qy+W4Y/OrAwuT6c/SlT8QmNA\n e0YeIsQL8xVvrOF9/curpmUcyo1XSpLNuR8mMUhYLAVB8rvafaEnjZt33fAR1CkTNu5ZSE53q\n SPdiBrcoQN4tYkNu3Mp+Y9d2L92E3QKQDS55I5cbANSGc26bKU","X-Original-Sender":"stefano.babic@swupdate.org","X-Original-Authentication-Results":"gmr-mx.google.com; dkim=pass\n header.i=@swupdate.org header.s=s1-ionos header.b=PNlADUOQ; spf=pass\n (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.131\n as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org;\n dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=swupdate.org","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n contact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n ","List-Help":",\n ","List-Archive":",\n ","List-Unsubscribe":"\n ,\n "}}]