[{"id":3669184,"web_url":"http://patchwork.ozlabs.org/comment/3669184/","msgid":"","list_archive_url":null,"date":"2026-03-25T16:18:02","subject":"Re: [RFC PATCH v1 01/17] vmstate: fixup the use of AUTO_ALLOC flag","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Tue, Mar 24, 2026 at 04:43:16PM -0300, Fabiano Rosas wrote:\n> Please add this fixup this somewhere\n> \n> Signed-off-by: Fabiano Rosas \n> ---\n> migration/savevm.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/migration/savevm.c b/migration/savevm.c\n> index 34223de818..db0721996c 100644\n> --- a/migration/savevm.c\n> +++ b/migration/savevm.c\n> @@ -869,7 +869,7 @@ static void vmstate_check(const VMStateDescription *vmsd)\n> if (field) {\n> while (field->name) {\n> if (field->flags & VMS_ARRAY_OF_POINTER) {\n> - if (VMS_ARRAY_OF_POINTER_AUTO_ALLOC) {\n> + if (field->flags & VMS_ARRAY_OF_POINTER_AUTO_ALLOC) {\n\nOops.. I'll squash this one, thanks a lot.\n\n> /*\n> * Size must be provided because dest QEMU needs that\n> * info to know what to allocate\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Nrn6TamS;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=lMm8Lt1r;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgsYB15Jwz1xy3\n\tfor ; Thu, 26 Mar 2026 03:19:08 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5Qvt-0007FZ-2I; Wed, 25 Mar 2026 12:18:13 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w5Qvq-0007EQ-Uw\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 12:18:11 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w5Qvo-0002VX-60\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 12:18:10 -0400","from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-633-G28FG5GGNCmkb8UAXVkMLQ-1; Wed, 25 Mar 2026 12:18:05 -0400","by mail-qk1-f197.google.com with SMTP id\n af79cd13be357-8cb52a9c0eeso28233485a.2\n for ; Wed, 25 Mar 2026 09:18:05 -0700 (PDT)","from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id\n af79cd13be357-8d00e39f050sm21287985a.1.2026.03.25.09.18.02\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 09:18:03 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774455486;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Uv4jitKEdDB1lTSeUCCPXMYKYQ4dmtfytmy7qvHYPcw=;\n b=Nrn6TamSfuAQT01VxWeorw1vf/hAPUQB4hWjriRQYlHUQ60ORKSDtrM6bUL3dIOku9CcUu\n 2cQIU3hbze6X/DEh/9MocedG2898BYXZsEri6k0fIeMdr79CHMh+Z6TLMuIkpyGZ4d5y8N\n Uu7amtMr8QiXioJ56KLIGilVvq+P0TA=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1774455484; x=1775060284; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=Uv4jitKEdDB1lTSeUCCPXMYKYQ4dmtfytmy7qvHYPcw=;\n b=lMm8Lt1r2lrDuH3Yjuefb4alKsjSw5mhX9ybrW05/rFy3sVivPsxt9dis8X7FakZty\n qxAfqKbcWb1p4b0LU+IMxcBEu+1UpE1IVLJL929JmAsM6zRVtvhYgJ440SVSzRTNV/Ei\n h3siuy7J/R53dNujKMzq2XDWfY+HMRPXUNk8CLOnpgB0p0kk8oPkNxyG1QgfjhEfz7Xt\n eLHsanq3Cr/utKBIpreqSJ18g+WL2bE29Jv2Mu2YLsrS/CqPqYftlBnspQl5K2vMzIb4\n hGJFj56EqzTPTYDAAP1stAc63rwXsLz487Tghmb9ttHioGvgZPuKt8egnM2Q1fdNOoWx\n MFqg=="],"X-MC-Unique":"G28FG5GGNCmkb8UAXVkMLQ-1","X-Mimecast-MFC-AGG-ID":"G28FG5GGNCmkb8UAXVkMLQ_1774455484","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774455484; x=1775060284;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Uv4jitKEdDB1lTSeUCCPXMYKYQ4dmtfytmy7qvHYPcw=;\n b=pKZRuTyeIsLVlt/dB3pLXHE5nT7gz1eNIs7LUWpNrbuydEdbUUQFN7tOf/1S4P9Q/N\n l+shL1C7AC7awNNJinfB++FwIxfbcQkUEO359ki/NzuxvDluQpvpNhYX9h4jsBB/Otse\n D16o9tDjwQ6oVU1PN688clcQSl1c5VPBJBCd1enUo95Fu7WxKBKTgdc0f5KnKacy7HgA\n JoHqQpvn2zovWxlAqcA123EF+ZL1LlZWXr2JKqlSQ04OPe16yALn91FvN0xW3wlH/heW\n IinVHArKk0DotZ8gTY4GpgG0miVVy5rK5IHsqGtfhHsSBt8/whCKzYG91dj4xWxe7uEO\n MhaA==","X-Gm-Message-State":"AOJu0YxPxkOLe9VbBfV/noWbdUUPtEHluKT3UGTG5PChVPNKAm98aBqS\n WkU5MoRy6Uj2e4ONiR+DIJHi5uEspBuafnF2ItJySNDPy2yLp4CMqregFs1UMQEph7QTPmxXDjG\n L8LZAxBlqv0I6NFY0saI2JXahDInK0TW4RT1b6Jeo1KyBxUqMjrJkAFgP","X-Gm-Gg":"ATEYQzxiB1qQGuEwClHkMTu5yJTbo/tNEC2ZCo/pzswGx963xcFCyYFm9ObgpJaCU2w\n 1c4s4SQQ9tHmJ9nBt663tEyhwfKf6nQ8Udzxf4aAL23h4LVNNFo180p/r9fkxf1eK5V6YPt0oUH\n 0kbHU/ueMqYijyy6vubuZXUiW0NCV3otT2Z6j1eUF0LurPob+bRBBDrV+mFmh4czZW9ckHFErJA\n Rh+OFM9x8YZPrx8dkj2Su8OipC5KJm2GOXwOevyTNPAC4sQ2sWSJif2hSFk3o2YsBYHcwY7bSyL\n oUfcrfzSNAnTkvpZj6XS37ppsA92M7o4nKtdNPG5FncBnio+mTy02pVArfkcfDJnNRbcmhm7we+\n aCQ/B1Nzm2RX1PQ==","X-Received":["by 2002:a05:620a:4481:b0:8cd:88c7:9f96 with SMTP id\n af79cd13be357-8d0010a02efmr601113685a.67.1774455484471;\n Wed, 25 Mar 2026 09:18:04 -0700 (PDT)","by 2002:a05:620a:4481:b0:8cd:88c7:9f96 with SMTP id\n af79cd13be357-8d0010a02efmr601107285a.67.1774455483876;\n Wed, 25 Mar 2026 09:18:03 -0700 (PDT)"],"Date":"Wed, 25 Mar 2026 12:18:02 -0400","From":"Peter Xu ","To":"Fabiano Rosas ","Cc":"qemu-devel@nongnu.org, Alexander Mikhalitsyn ,\n Juraj Marcin ","Subject":"Re: [RFC PATCH v1 01/17] vmstate: fixup the use of AUTO_ALLOC flag","Message-ID":"","References":"<20260324194333.30004-1-farosas@suse.de>\n <20260324194333.30004-2-farosas@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260324194333.30004-2-farosas@suse.de>","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]