[{"id":3668940,"web_url":"http://patchwork.ozlabs.org/comment/3668940/","msgid":"<2395a353-36a9-49ba-bb0c-824f308cc90d@linaro.org>","list_archive_url":null,"date":"2026-03-25T10:00:18","subject":"Re: [PATCH] hw/net/rocker: Avoid double-free of l2_flood.group_ids","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 24/3/26 20:35, Peter Maydell wrote:\n> In of_dpa_cmd_add_l2_flood(), we allocate memory for the\n> group->l2_flood.group_ids array, freeing any previous array.\n> However, in the error-exit path we free the group_ids memory but do\n> not clear the pointer to NULL. This means that if the guest causes\n> us to take the error-exit path and then later call the function\n> again, we will try again to free the memory we already freed.\n> \n> Fix this by clearing the group_ids pointer in the error exit\n> path, so we maintain the invariant of \"either it points at\n> allocated memory, or it is NULL\" (both being valid to g_free()).\n> \n> Cc: qemu-stable@nongnu.org\n> Fixes: dc488f88806 (\"rocker: add new rocker switch device\")\n> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3253\n> Signed-off-by: Peter Maydell \n> ---\n> hw/net/rocker/rocker_of_dpa.c | 1 +\n> 1 file changed, 1 insertion(+)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=gABk0Wma;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgj8g74Lnz1y1K\n\tfor ; Wed, 25 Mar 2026 21:00:51 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5L2M-0003K7-4z; Wed, 25 Mar 2026 06:00:30 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w5L2G-0003Ju-BB\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 06:00:24 -0400","from mail-wr1-x430.google.com ([2a00:1450:4864:20::430])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w5L2E-0008Gb-HV\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 06:00:24 -0400","by mail-wr1-x430.google.com with SMTP id\n ffacd0b85a97d-43b87970468so969918f8f.3\n for ; Wed, 25 Mar 2026 03:00:21 -0700 (PDT)","from [192.168.69.206] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43b881757c5sm8298695f8f.0.2026.03.25.03.00.19\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 25 Mar 2026 03:00:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774432820; x=1775037620; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=Cd3A85oz4s9edgO4FnKC9F33nkywbXUmrVHTOB18MO4=;\n b=gABk0WmaXKpO2D698Epvx+hWgwLBwlqHP01pBi7YRQlhoeLcZbEFhyoLwFbISrw78M\n 1quf8Y9cFy3+UG7R05OUplNK15BhQ5TOIzrbeJPfd0Z7veK+Bjt4Qaz1/RRTKkPi3oIW\n Dz9NQ1cKSjCGvdPToJnEcxc6yUxU6Fm7HRTihMWEMvrVAVaTlaZiKbd/5V26Cbyv+SNd\n 03lwRA1+s78kxVZm4SzNjfLIC6oTslyHPqT+GJWvo49nYsQkE+HYyWWJvmbG7g4lvac3\n yjO4pgfc/yDcR543On1eQ6TQfbJIHgPLuLhghlEmYqk/w8dKF3tdpe8motRVt/zThQJF\n pSHw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774432820; x=1775037620;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Cd3A85oz4s9edgO4FnKC9F33nkywbXUmrVHTOB18MO4=;\n b=MMJ6IEM5i5nn9yv7mUpBfRUTyVVQdQJKkiSy2S4JWR83R5EqRZkovDGdh7SFe7nuts\n Xxcs3ibUcE+aBELQQ9pbBe+2CMCFf8yNSmqqVkk7JCSrGmO/gMDDwXeNBRPY41zS8ZQ2\n RL+zqkqKkzxnMzmshTURXF6Y0rKw5CK/iNyb5Cai/gwVwgOc0+1zLhO8YV6XGZMHJiDt\n Rf/8jqn2C1aWHNcVuLoSXJvcB5JrVNBuCQw+sA4WCu6x2UTx+ZhmElJtarFVrobuu5iM\n xQZeeoP300O11s6Na9KS5wH/5dJ+2yuTfPOB7NWdiLBF02JL6AFnDrBBE0vH/vWpJ4w+\n 7N5Q==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVcBWfbWPNXYKwS6g1VkEo5op+8J8aKPeFHT6S3ZPC/hfdZBWNRN+y/WXpPsZn+fDJWHndHzs9rtxKg@nongnu.org","X-Gm-Message-State":"AOJu0Yw0+xaN7tg7IvLPBmuN/wsTXHRAZWobE4zf2f2MoNIDqei414a5\n r9lGW6i90FZA7tO/fqkNRNQ7c+Fz+JF9GfIokdA44DRBiMcULCsMQ7jjQgXujzPckhM=","X-Gm-Gg":"ATEYQzxUM4gz3l7S3XO6TdhImx/Z5Hz3bZbBBqtF0GqDjJEUxHoRSSFxp25pBsUUUxL\n AOFj2wzKfKG5+YlNAy35InGw90DOyLx3E7LepIwqff8Axk44oNLbTzcKJOtk/5MCqh5zffOjVBn\n RDt/YsiQKP2Cp+U2tY/ckaWUryoswa3SGe2ha5r/inukJTeECtesqD/EX0jwYZeB2GDbRu8ejQG\n +1jIt3ZFOQL0563fGFv+piK2Lca2P1v65pWte0uiobHzbB9ox+otrgYfvP1EPjbCzFXyDbYv0oi\n SIHLhaXspmp1VRyQLYGUgUACuEIztOZyt9mQhQ241as1zdttv0r2KFGb/6Qg4HUwVGE+aVA4x+q\n CSamsY8bQfxB3kxRgU09Nh5amRFask8J5ERjZeQ3/3f1Nj/QkwtK5WgQpKExKeTymyGVRSQP5ju\n lXqGsp6428aYpfrERzsmpewAP6tIBpmoubQG4YKU8CdFXU2AdxrJxmAVqzR/EWecFmP/FnUP3PE\n BAi","X-Received":"by 2002:a5d:584c:0:b0:439:beb9:5a96 with SMTP id\n ffacd0b85a97d-43b88a88a42mr4031553f8f.31.1774432820183;\n Wed, 25 Mar 2026 03:00:20 -0700 (PDT)","Message-ID":"<2395a353-36a9-49ba-bb0c-824f308cc90d@linaro.org>","Date":"Wed, 25 Mar 2026 11:00:18 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] hw/net/rocker: Avoid double-free of l2_flood.group_ids","Content-Language":"en-US","To":"Peter Maydell , qemu-devel@nongnu.org","Cc":"Jiri Pirko , Jason Wang ","References":"<20260324193530.375628-1-peter.maydell@linaro.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260324193530.375628-1-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::430;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3670463,"web_url":"http://patchwork.ozlabs.org/comment/3670463/","msgid":"","list_archive_url":null,"date":"2026-03-27T16:59:39","subject":"Re: [PATCH] hw/net/rocker: Avoid double-free of l2_flood.group_ids","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Wed, 25 Mar 2026 at 10:00, Philippe Mathieu-Daudé wrote:\n>\n> On 24/3/26 20:35, Peter Maydell wrote:\n> > In of_dpa_cmd_add_l2_flood(), we allocate memory for the\n> > group->l2_flood.group_ids array, freeing any previous array.\n> > However, in the error-exit path we free the group_ids memory but do\n> > not clear the pointer to NULL. This means that if the guest causes\n> > us to take the error-exit path and then later call the function\n> > again, we will try again to free the memory we already freed.\n> >\n> > Fix this by clearing the group_ids pointer in the error exit\n> > path, so we maintain the invariant of \"either it points at\n> > allocated memory, or it is NULL\" (both being valid to g_free()).\n> >\n> > Cc: qemu-stable@nongnu.org\n> > Fixes: dc488f88806 (\"rocker: add new rocker switch device\")\n> > Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3253\n> > Signed-off-by: Peter Maydell \n> > ---\n> > hw/net/rocker/rocker_of_dpa.c | 1 +\n> > 1 file changed, 1 insertion(+)\n>\n> Reviewed-by: Philippe Mathieu-Daudé \n\nThanks; I'll take this via target-arm.next unless anybody\nobjects, as I'm planning a pullreq for the next rc anyway.\n\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=WD0YWl1p;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fj6Mg4DSXz1yFr\n\tfor ; Sat, 28 Mar 2026 04:00:15 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w6AXO-0005Rz-2y; Fri, 27 Mar 2026 12:59:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1w6AXL-0005RZ-8l\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 12:59:55 -0400","from mail-yx1-xb135.google.com ([2607:f8b0:4864:20::b135])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1w6AXJ-000748-NK\n for qemu-devel@nongnu.org; Fri, 27 Mar 2026 12:59:55 -0400","by mail-yx1-xb135.google.com with SMTP id\n 956f58d0204a3-64e8ae85700so2601550d50.1\n for ; Fri, 27 Mar 2026 09:59:52 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1774630792; cv=none;\n d=google.com; s=arc-20240605;\n b=bs5N7CVElZlRJ8e/1kNFE7bVQQXEduFjOtLyc3qwBT8Kqw88eOfWh9I+8f04ycysGC\n hlictkcw2TwUEbyGjokNjfW8Is3PPC0uTHEquQOPshYhPGUk5SZSsuvEbz0tBiOVZe4M\n N1NVbQpTkvUtPdqTFoinwCdNTyKjpQYPO51KX2voYr2dIHfr+XVdtezeK877PTGTp6VC\n owkCIAONDJzd8q+cU8WDwkrs6GMBaW599au+yrt12NgJZu84cN57/Cx5P2rLuhmN8hkm\n zol0bibhvhkJNLliui3fUFiuiODuTznoYaufYmy6y/R6rNO3DG/chYbAKBeOSqNCnnyI\n CvpQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=riTbA31r3tXJJKrgG4WTjXlWs34t6fRrVnYqEfVWbrE=;\n fh=VCw0zYq36+ImszfhkRQ5b/3r7rdKhLLzDU6AyHknI5w=;\n b=Rvt9dq17uVAo5fcG2tRM+h9dt1/T+ASvtqZcaAWfLnuzSKhh2uYTK6jfihDHdS8KP3\n ESCQNAaNKJd9CXAxr70p0rUD6J17lm1B31H4VXdaVecVENRJwrATCB5K6TiR4+awQq5r\n FHz4sdKMr6IzdHl92SWjqoa0ESNk/GCUXCW1aoc+jIR5A1B8pxps8tAg1qNCwLjS63YV\n Jp1Px9uL3fEi0dwe/0q1ubQLI1aDCZ5IZ3hgy0NH/U4QLl+1TZOgOr1ND/01stOS5gPT\n IZRDowSOZp0fggTjqDLC9JF1hl6V1/1eb5NbXsXk1iYdWC8Wb2gAfMok4Wh67N88B4UM\n c4UQ==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774630792; x=1775235592; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=riTbA31r3tXJJKrgG4WTjXlWs34t6fRrVnYqEfVWbrE=;\n b=WD0YWl1p2ICfw3jr7u/T3SCQGOLz3Z9WIKtifsA0Z2IOzoLtL60OEcHcUuALxFfnJI\n GmxBEdOB/wQGNP+hCSgwvtPCoAlucbvlJnBPNfCpmdYEsxnRt4zOeZrTQTwBdiNf/udU\n weeG2jQtcINtqiuQ5IbRaWacQbrO/DHZBAWlSuJi/bg0+6pNJqRXTU8qMiabm0WOyt8n\n iKSs/iOhEK5PZC3zE3JttrFuxwVI3J45sHbO2NHKbB87KqDyGGWgDYMzOTCvmkFVbtAA\n DaQmfxDdN1TjYvSdA4hMyBoX8RW7oHjbZu/nAhLD6cQQE0BZEFskUQFSxEsBM1mXxGa/\n ckkQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774630792; x=1775235592;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=riTbA31r3tXJJKrgG4WTjXlWs34t6fRrVnYqEfVWbrE=;\n b=kaqUxEer6+VPJ16BEfyvTig2MsJsXDpZV5cYj+C03XJTUGd2/BrKUfH7kIrGaE4w9z\n XJSdBZGenKxTZcnqsKUlvt/3emjA9CthlxKuoRIuxYgejAJ4ggxH8PiNudwPxdMLK9Dr\n GedOsCk2DrzqbaPpvDuDgDOx8+3iKmJhZeTyhXqHY6HTazRiZdbqssM1CVlpnPkSfBxF\n 7QjgbXqCmFDtg+XIxGHwoJPQCM2DyCrqXRyh1tkfGR04vmpgWA01UbGtb26q2tLxd3AI\n jMQ6CnpfwDMTF1TSXUJl2Zy6YhJ/uyir1mMFBICFDp4uZYk2izJK6ugWj5HQGimWuoTp\n gX0Q==","X-Gm-Message-State":"AOJu0YzqTgXab2viqIY0D/IqdNu5NH5ttN1ySNwttkHnMa4pDVDnZ/uY\n 5KQM4CtW6TXavHL7eFQq8M15/oM5zZLntpRmzzz0XvTN0emtV0xSk/dG3mjoy1blXf9/JXo3bku\n twR5WHd66zpKbHzblBAHFQDadyMrs7Q8LMKG7dJvRvre6wHwDTa48kIg=","X-Gm-Gg":"ATEYQzz4rgHIO5oIWM7HIfK9XmnrGw1OlZk9UpNH4YTYO9KYdI8hWX3mdWpsNTNkUq1\n 8YhErOu1qT3yk1bLSpy195upPXfjwYDmh87JyKFwYVNDjJGtJ3Vw5qbT/r8B6YiV1Q2X6Z7PxSk\n v4Ty7vUtLdOEjsPXnmuRZBwYbARdytJb5t67NHzN/6nffG9AP8E5H6fNj8+8294J2jW17ggUv5X\n PyB22WZUFLzFcGXG3B62vOqnrXcG7M1DnxPRIkZnIC3gqE2pUAHmM4S8i+XGUrDulheR5bFu4CD\n Tdt88XmU+CY2KmoiNtFeYPPAedLeahMDvas/khUkNiHCv2I0vQGJQYx4EQ1OTDFUSf0=","X-Received":"by 2002:a05:690e:43d6:b0:64e:e90c:5692 with SMTP id\n 956f58d0204a3-64ff73f6ae8mr2741095d50.60.1774630791911; Fri, 27 Mar 2026\n 09:59:51 -0700 (PDT)","MIME-Version":"1.0","References":"<20260324193530.375628-1-peter.maydell@linaro.org>\n <2395a353-36a9-49ba-bb0c-824f308cc90d@linaro.org>","In-Reply-To":"<2395a353-36a9-49ba-bb0c-824f308cc90d@linaro.org>","From":"Peter Maydell ","Date":"Fri, 27 Mar 2026 16:59:39 +0000","X-Gm-Features":"AQROBzCN7MvFhRN4JPpgwYgSo2mz_JTOE2aqwPLki4NYHdxl4CKqGYj71p-qcII","Message-ID":"\n ","Subject":"Re: [PATCH] hw/net/rocker: Avoid double-free of l2_flood.group_ids","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Cc":"qemu-devel@nongnu.org, Jiri Pirko ,\n Jason Wang ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b135;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb135.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]