[{"id":3668699,"web_url":"http://patchwork.ozlabs.org/comment/3668699/","msgid":"<0debe6f9-581c-4093-ae4a-9025bf1a7760@nvidia.com>","list_archive_url":null,"date":"2026-03-24T21:04:37","subject":"Re: [PATCH 02/10] i2c: tegra: Replace dev_err() with dev_err_probe()\n in probe function","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 24/03/2026 18:26, Atharv Dubey wrote:\n> From: Enrico Zanda \n> \n> This simplifies the code while improving log.\n> \n> Signed-off-by: Enrico Zanda \n> Signed-off-by: Atharv Dubey \n> ---\n> drivers/i2c/busses/i2c-tegra.c | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c\n> index bec619b9af4e..51d15fca82fc 100644\n> --- a/drivers/i2c/busses/i2c-tegra.c\n> +++ b/drivers/i2c/busses/i2c-tegra.c\n> @@ -575,8 +575,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)\n> \tdma_buf = dma_alloc_coherent(i2c_dev->dma_dev, i2c_dev->dma_buf_size,\n> \t\t\t\t &dma_phys, GFP_KERNEL | __GFP_NOWARN);\n> \tif (!dma_buf) {\n> -\t\tdev_err(i2c_dev->dev, \"failed to allocate DMA buffer\\n\");\n> -\t\terr = -ENOMEM;\n> +\t\terr = dev_err_probe(i2c_dev->dev, -ENOMEM,\n> +\t\t\t\t \"failed to allocate DMA buffer\\n\");\n\nSo this will never be a probe defer, so why bother?\n\n> \t\tgoto err_out;\n> \t}\n> \n> @@ -588,8 +588,8 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)\n> err_out:\n> \ttegra_i2c_release_dma(i2c_dev);\n> \tif (err != -EPROBE_DEFER) {\n> -\t\tdev_err(i2c_dev->dev, \"cannot use DMA: %d\\n\", err);\n> -\t\tdev_err(i2c_dev->dev, \"falling back to PIO\\n\");\n> +\t\tdev_err_probe(i2c_dev->dev, err,\n> +\t\t\t \"cannot use DMA, falling back to PIO\\n\");\n\nThis is not right.\n\n> \t\treturn 0;\n> \t}\n> \n> @@ -1953,7 +1953,7 @@ static int tegra_i2c_init_clocks(struct tegra_i2c_dev *i2c_dev)\n> \n> \terr = clk_enable(i2c_dev->div_clk);\n> \tif (err) {\n> -\t\tdev_err(i2c_dev->dev, \"failed to enable div-clk: %d\\n\", err);\n> +\t\tdev_err_probe(i2c_dev->dev, err, \"failed to enable div-clk\\n\");\n\nWe have already got the clock and so I don't think that this is needed \neither.\n\n> \t\tgoto unprepare_clocks;\n> \t}\n> \n> @@ -1979,7 +1979,7 @@ static int tegra_i2c_init_hardware(struct tegra_i2c_dev *i2c_dev)\n> \n> \tret = pm_runtime_get_sync(i2c_dev->dev);\n> \tif (ret < 0)\n> -\t\tdev_err(i2c_dev->dev, \"runtime resume failed: %d\\n\", ret);\n> +\t\tdev_err_probe(i2c_dev->dev, ret, \"runtime resume failed\\n\");\n\nI don't think that this is needed either.\n\n> \telse\n> \t\tret = tegra_i2c_init(i2c_dev);\n> \n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=YL/N6p6w;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-16721-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"YL/N6p6w\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.52.22","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgMyv5H1xz1xy3\n\tfor ; Wed, 25 Mar 2026 08:06:15 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 58895305B36A\n\tfor ; Tue, 24 Mar 2026 21:06:07 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 04EC434F489;\n\tTue, 24 Mar 2026 21:06:07 +0000 (UTC)","from BL2PR02CU003.outbound.protection.outlook.com\n (mail-eastusazon11011022.outbound.protection.outlook.com [52.101.52.22])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 44627358375;\n\tTue, 24 Mar 2026 21:06:04 +0000 (UTC)","from DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12)\n by CY8PR12MB7241.namprd12.prod.outlook.com (2603:10b6:930:5a::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Tue, 24 Mar\n 2026 21:04:45 +0000","from DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391]) by DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391%6]) with mapi id 15.20.9745.019; Tue, 24 Mar 2026\n 21:04:45 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774386366; cv=fail;\n b=j2Lw0czVpx8D5O/8j7KwmC31iITWzztXEdYoTSeZOzCIT87/d1CQFFgFZ2pF8NT3xJheJsuTLpGiLty0ff3YxB/M7sXj8ZINtqZS/th59B/erYOnZzzSKdvdHzkF2OlzPKa3qUSD2No6htsenMHpuH/BPCAJzOuqxEiwSY0O18g=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=bhm1ggTMED5jEjbnCAo/LFzREnMRU9rSqyNqJuVYaaU+C3fhE1fRPE5E0kABrcNlOYQk7eX5CZiTarlj3V3bWmcc8XMz7a5UMbAnPQfBQXhmehlQ7GKghm+38flmmljHrjC9DpvCmuce2oOwcUgLAaChOYY3XFFdZmH1tICWmDQeHJDy0yLlWlzc/cr+6isOCodIb7O9wmrKoxzJgo642ki0yvBZ6YCoc+39Jk7wConvi13bkBpSzb0+x6g5HxB8KIZiAmDJCwJ/y2QG+GmPe0rZsxjzgw7m/5Q8sJUPECn+7yDbJqugx+9aaKOvTosQYqghQP3/GR4Qi+56eCnk8Q=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774386366; c=relaxed/simple;\n\tbh=qNCuCqhyKAcUF2j9qdQzm67cjer+EBimC1cVbaFNx60=;\n\th=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=J4D3fSNKGOvdc1kBvWzsXp2GnbCGeISVDObJ5LyvE2exi2tEMKNwrqDIKLA14aBCNX+/NK2xWv8dI0ERvdsEhyT3Uzp39E8RcdD5xhqJ06+8MVp1T/L/S9jusY0Cop4FD8T1UnTo4CnR+FigwNr+7PXAWxVoJPvmu0GFnU/lW2k=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=EnBSK7v97b5CLLrPgOyZBfAhZjXIFld1Q7LJunoIU8s=;\n b=tMKzeGxhT8tdpZvIyIV//BXv4afc4Xe55+c7gel/7wduKQXepIuDy3l3IEC25q2VVATKAmBzbkYezCmsRVdhoat17+A/ClUf1ccPd1I+zFRJFmfPpT1o/2sarNBkPXh26GqFJWAaFD0pjqRzzfosLz6FEx6jTUk4aBihLJ26gInPCs7QxmIiYkPHfJq7tUDs9yGcOGWlEvtJueT6lrNz5EA407b6GD422L4uMX1cIcdM9An+UZo8w5WjgjWBjPTsJRxyK0MnRUdzAEsAk0/l9xSIoDBmVcXInJqkNJy97K5u/kD2etqpQ822mgvR5M1YQqz+W/ks6ELhd/taBz6e+Q=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=YL/N6p6w; arc=fail smtp.client-ip=52.101.52.22","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=EnBSK7v97b5CLLrPgOyZBfAhZjXIFld1Q7LJunoIU8s=;\n b=YL/N6p6wWKxbIftX08QnCglYrw1RQLn/RAayREM7nebL61q06TDi8KyiCA+0O7NA4Sewe4Rcb2QLUxb6XI5tPx8W5pDhKyHTh9lbIogI11yfnq/727INT3PJKwULIGgRVDSEqwjI7POUzIzw1vAFr4tXh541/FrKW+8aqaxnZ0jql7b2KiakfeM9SQk3/vr0UlVbOJv0cwZpfubHWFrCqLgslqOJEGmTHZFAkuT8QUmJuKJUX3WiPEy35Nzt+jO7ckOsup+pifh/oTnvCf1loDtrCdfZt2tD2eTXevzXBM7ryIhS+rw2VPNBfNyxQoVjHB58/V2Gu7cJGJU9ffnW8Q==","Message-ID":"<0debe6f9-581c-4093-ae4a-9025bf1a7760@nvidia.com>","Date":"Tue, 24 Mar 2026 21:04:37 +0000","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 02/10] i2c: tegra: Replace dev_err() with dev_err_probe()\n in probe function","To":"Atharv Dubey , Till Harbaum ,\n Andi Shyti , Laxman Dewangan ,\n Dmitry Osipenko , Thierry Reding\n , Chen-Yu Tsai ,\n Jernej Skrabec ,\n Samuel Holland ,\n Pierre-Yves MORDRET ,\n Alain Volmat ,\n Maxime Coquelin ,\n Alexandre Torgue ,\n Patrice Chotard ,\n Orson Zhai , Baolin Wang\n , Chunyan Zhang ,\n Jean Delvare ","Cc":"linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,\n Enrico Zanda ","References":"<20260324-deverr-v1-0-7e591cce33a3@gmail.com>\n <20260324-deverr-v1-2-7e591cce33a3@gmail.com>","From":"Jon Hunter ","Content-Language":"en-US","In-Reply-To":"<20260324-deverr-v1-2-7e591cce33a3@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"PA7P264CA0483.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:102:3dc::17) To DS2PR12MB9750.namprd12.prod.outlook.com\n (2603:10b6:8:2b0::12)","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS2PR12MB9750:EE_|CY8PR12MB7241:EE_","X-MS-Office365-Filtering-Correlation-Id":"09dd5e14-14ed-435a-87dc-08de89e8f9e8","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n BCL:0;ARA:13230040|366016|1800799024|10070799003|376014|7416014|921020|7053199007|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n dCrRxOp1CMBX0KRuk/p+QxXqheZAL2wfrUNtxGG9J9c3VIR0CzDRPvKH2d9XECheJaMM4iAHvOwlyV6q2dSdM1iDclqAgCQW6wa74P1IlxHcborT703UfwoUVfLIE5I4YbEYe9Wdt7lHIPv+CzLMQLdiKZ50l+ZnL+gyCKLoeVdZ+csBLu7UyUyaJcz0Vyoda4tzjvdJ2tfGaVipKOkNEvsh7OPV8+BfuWn7KzoBbXxX4wHs8wvT8sc815szHHjN2EByEhhcEovr6QQyrapZn6VjmVTi2ds0aG+KsI487F573a+g86hhGKn/AtSWfcbWZL5kQOZOSM2ICokpkJ6I/GQmzRux2ASQub5wsDy2dYbN3YSkrPkfelxAUytkUTp+ROYxlQ85oWMRd0T52pcBVvjhvYDVaDxZijHacIFBc10+yx0H5SO0AdBJYYsuZkuHgryppDXuRjdCjdtCXesTWsdfb8bmuGcWU4UVKGRuKvj533MSAsp36mQpnaC0dMIw3b2EsBIKiS77rqOpdjCurv/+aDmiQnw/PKvS9vkrlFle/0O2BcjNX7dsyFRNJZLyNvoG/dtLWUDo43FnCssoBjZjH5QUOfgglDHJ9QWIO+9bx9lfeSBlb9dvgfrpLES0hfd5e9+RWbM7rG0Ba/ND7v7jgJbbTk7qcZua/adAFzF3TqEUc0sta/PgSFX5iecySJhjXFDHT1rb95nDNKAQDIpJqRcfVj+x+JnS6H9S8e0m5P2d07MyyqYBRlV91kTQQS1+j2undXX1T3f0tSkXdA==","X-Forefront-Antispam-Report":"\n CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9750.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(10070799003)(376014)(7416014)(921020)(7053199007)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?p4SfHvQc6PYGnJg7Px/i8QPf2OeD?=\n\t=?utf-8?q?syg/0XgpEeinv14kZgO8k9VT1wK/f7jtzHEVcChHqK/cSorHFbTufiYGP2jhTxYgO?=\n\t=?utf-8?q?qfrcV0BBZQi84WensBu1fPSWz+NCxP5EMpmx2+tWOHDVjNuUjMzPyqaJ/OPR+jIis?=\n\t=?utf-8?q?pWvzG89oYXWAVYgHWXkG+kVh/MHEYHC82nHOdY3IVdYXSSP2KOfht/APwDaSP8MOO?=\n\t=?utf-8?q?sX+qukuE1Y3yfzi+s9AWVYr+JJt6/Yydst5uENHNUdfyAFXUPmEYRvfUpPGHofe4U?=\n\t=?utf-8?q?V+4R7lFp/pU23njk8KVUQ9ey8J3yNdGnzwzcTcZljeefLOTUR6BXeSPIJvKKOy5DY?=\n\t=?utf-8?q?WVVPgefn+m8Lvjrg5Z6hhpVkaSAJILDIprwlh/xK56NARlhVGIUn6YDVwZ/o4Zv0l?=\n\t=?utf-8?q?F/0V7++oPuXUhGbT/SWToTud3UHFDKOyInOz40gIMrEU9Ui8vjSiC4GoSt9Ekb8f6?=\n\t=?utf-8?q?PkG3orzKsJYaGftWVmg/yHB5Xe7xRvwR0UoPFuwx4gvAhcD2DMM0PVP961lUWQ6g0?=\n\t=?utf-8?q?Q5ZCg4bfhu5FXHOFIWrCm4ZZYbKbRgs1LXhNNwpTpgZqQTGKfOVSNE9yAAIDXwIhh?=\n\t=?utf-8?q?BX13S6IainPUFLIzIeqy7K5cEd6BJ+hiCOugIhPfRC18qVg0zW0ToQN8c1E28ZKgZ?=\n\t=?utf-8?q?ylzaoeA7ueMvC67f9ZfE4no9c/obVEAogVLc7rx01sqyfyC8vpbqsBJac+GfMdP8p?=\n\t=?utf-8?q?CkksSyMIdBC458xvKJfztXtiF76ODBqZIaCRBiOU9trppplYl42iL2HdSdddRCZ+C?=\n\t=?utf-8?q?PbHg4dhAZ5qAdHgK3oLoWYIbJ3J3GJ6QhKI6wh5WwJagKMWh4D2BePXvVR3X2l/AY?=\n\t=?utf-8?q?KRArzDJzosis2F+mZ/QNuX4VAA2/46Mzdo7VCw+lh6P/5+oqjjoefbVSzN6rviTcl?=\n\t=?utf-8?q?Rxxcf9SpGOD3kcX/C01gxkE7PGmSMgP4tchiGjn6Zbazi3PzeLWejn3FtCDs87RLg?=\n\t=?utf-8?q?8s2pOMsiprt8qpp9FkFG85dCrJZ6AG5fUoxZytv0t3cYkrfm/Azkmgpw+KyTBWTAQ?=\n\t=?utf-8?q?SQuDXQQ+I0Tj7wBS92n9JQkDUOXqvbrj0lWq2vUYdTREDchsK3JJVcIJ/ve/n2ipV?=\n\t=?utf-8?q?en3qTrWUc0EWYob8tsLofj+UMuvbslLXx2f8ZEbGqiGZdtyEdrihS4YvvuhkgX832?=\n\t=?utf-8?q?0aNPp/cFHyQ/bMR3rikrEnc3k80GDZj3RykHX9YhPDJyBOpJ0TzGnsCVpuACqXG5E?=\n\t=?utf-8?q?MSITCs3gJ6ShOwDyJGImwwEDLTegkOdCiVXGMzAa6de/aPBQmMZhZLWgyKm99tRwq?=\n\t=?utf-8?q?ZA4u/tOgPt1fymV2UJU98uWLJyghwYI5pW5O4Pus7O4VvsZMee5rpg+BwVLnpHjLT?=\n\t=?utf-8?q?giQjJOdtBI5XYrzBfBRJALBM9MW5OsxA2LfEtOZUV31P/UaAmWM3BOrUgabGbQOJv?=\n\t=?utf-8?q?whIp8cU3xYAS3nbbhwB94sEpmF4lz38qRUTnO32TipsTrhRJ6b40YUmOoKdc9kyQ0?=\n\t=?utf-8?q?dKPcR9kS5V2JuUOFh7SUafhjQ7jxQIghCMpg5NWQ0hch0AvX/F+Ltl3JJ+KF2ptPi?=\n\t=?utf-8?q?lWEa19o7FFDQCdeV71iSy1XJwJnF5goISDyBfKDQheg0A72+LD4aCheWkeTh5BU6p?=\n\t=?utf-8?q?ZyhOTdnYjjchzhDtSWHdsZRVkL6skrsWZiVVLi1vamiRQVg4xf1r9we3+j5TnKBuu?=\n\t=?utf-8?q?jaRCuxXoUEWwWVmiX0Y6ozHnzsNpttJylz246T7ge7fgnTXjAkskx24hkx8Cb0QYi?=\n\t=?utf-8?q?s+LDI2Jr/oiN+kSeI?=","X-MS-Exchange-AntiSpam-MessageData-1":"2sXMbZGQWzeN8g==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 09dd5e14-14ed-435a-87dc-08de89e8f9e8","X-MS-Exchange-CrossTenant-AuthSource":"DS2PR12MB9750.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"24 Mar 2026 21:04:45.3532\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n yEhHCc9WDWTwX+Hr1PygNKIaYtDq60un0uUrZTKmP/+kVZfyyLVpqG/PRg8temI/BdJsCUyY85UiP8Tt0RsR0w==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY8PR12MB7241"}}]