[{"id":3668591,"web_url":"http://patchwork.ozlabs.org/comment/3668591/","msgid":"<CAMuHMdXX16=pih34yehj=3bJkg2H3ivGUj_34JDg31ABheLE5Q@mail.gmail.com>","list_archive_url":null,"date":"2026-03-24T17:06:22","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of\n align","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"CC gerg\n\nOn Tue, 24 Mar 2026 at 17:59, Ilpo Järvinen\n<ilpo.jarvinen@linux.intel.com> wrote:\n>\n> Aligning res->start by align inside pcibios_align_resource() is\n> unnecessary because caller of pcibios_align_resource() is\n> __find_resource_space() that aligns res->start with align before\n> calling pcibios_align_resource().\n>\n> Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> result in changing start either because 0x300 bits would have not\n> survived the earlier alignment if align was large enough to have an\n> impact.\n>\n> Thus, remove the duplicated aligning from pcibios_align_resource().\n>\n> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\n> ---\n>  arch/m68k/kernel/pcibios.c | 2 --\n>  1 file changed, 2 deletions(-)\n>\n> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> index 1415f6e4e5ce..7e286ee1976b 100644\n> --- a/arch/m68k/kernel/pcibios.c\n> +++ b/arch/m68k/kernel/pcibios.c\n> @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n>         if ((res->flags & IORESOURCE_IO) && (start & 0x300))\n>                 start = (start + 0x3ff) & ~0x3ff;\n>\n> -       start = (start + align - 1) & ~(align - 1);\n> -\n>         return start;\n>  }\n>\n> --\n> 2.39.5","headers":{"Return-Path":"\n <linux-pci+bounces-50941-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-50941-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.173","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgGpW1ptFz1y1g\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 04:13:39 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 56C5930FF4C1\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Mar 2026 17:06:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1A8D723C503;\n\tTue, 24 Mar 2026 17:06:43 +0000 (UTC)","from mail-vk1-f173.google.com (mail-vk1-f173.google.com\n [209.85.221.173])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B12C39E198\n\tfor <linux-pci@vger.kernel.org>; Tue, 24 Mar 2026 17:06:41 +0000 (UTC)","by mail-vk1-f173.google.com with SMTP id\n 71dfb90a1353d-5675d609621so4230739e0c.2\n        for <linux-pci@vger.kernel.org>; Tue, 24 Mar 2026 10:06:41 -0700 (PDT)","from mail-vk1-f178.google.com (mail-vk1-f178.google.com.\n [209.85.221.178])\n        by smtp.gmail.com with ESMTPSA id\n 71dfb90a1353d-56ce54d6b6asm14620086e0c.4.2026.03.24.10.06.35\n        for <linux-pci@vger.kernel.org>\n        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n        Tue, 24 Mar 2026 10:06:36 -0700 (PDT)","by mail-vk1-f178.google.com with SMTP id\n 71dfb90a1353d-56b6c7c8d00so3452524e0c.3\n        for <linux-pci@vger.kernel.org>; Tue, 24 Mar 2026 10:06:35 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774372003; cv=none;\n b=VmfZUP6MitAOlHqsAgE/+o/CwkgEzkG2/ZNIk1DqHgIqDjhDZ1vZNURyfDqu/h0XggYHJa2zqYmkg+ZflAnVO/6ATx2rTAc3uBX7/zHeFv7AVd0RAmOo3d0S/ynLt0Cr78IXjcfSlqyhh+7XOqUra4PtJKgpz0f2fZRAvTTiU+4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774372003; c=relaxed/simple;\n\tbh=3GEJwPfpmz1HAcFqPqDcCHr7DP7fs2OA9k1TBgcroIs=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=R+HJRkdt3bI/AUpJWJG/ekEXKDBFGc84zJvyNUJj2wk9oFOHpURsS3zltYiEkZRvV+em6czUHaZaghRX2AilrDW5oo/Zj9nWy/BEqtMYQws1NCOP2aEvOL8uEGZxvFhm3vRy6oGbQVFRDzJNFC+BaJzj3w4EB9odrdVes7SCBFI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org;\n spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.173","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1774372000; x=1774976800;\n        h=content-transfer-encoding:cc:to:subject:message-id:date:from\n         :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n         :to:cc:subject:date:message-id:reply-to;\n        bh=imA4hBFgRxEV6K6PxesH3aFI8Gk9es7sFYCGiASF9lc=;\n        b=MWSfw/KSkk79woHXsrdfK8b6+C6SEZTF4HEt2beWVBcRXAXwTtm7q8Bd0cV4yV9YGJ\n         v26b9Mq2m6F7Hex7U6119VZyWdQresiqqisIFE5QlB41Q6Ujz8NMzIW63s42CmgJeOdk\n         bMoGDhCegehpazV4BkakL/GPvySpLq3sd/Dj0GwhB3MFVozcSKdPBBWCG+yIFe1J8yRo\n         dS+LgS0CkWhzouir+El2Cpv1bnUyf/imS/j80neVWC+446YblawKUZXNEd8Ov/bdY666\n         Wq2HDKxA0nuE10CG9+GTqI86h8H4XwPbv7lC4Ds53uPEqyE+oPDeXAvQKT8YrRH1yn5m\n         EE+g==","X-Gm-Message-State":"AOJu0Ywl8E2raWgUWpVaZIDdkcYRzlCmdt2wtJol/DoU2ztmGVzcwSYU\n\t4ZyCu+1pH7HH/Ngk7TCurZZmxjxqbuao0W9+xqN5m0XtvRf28qTDf8dYOUerGYH2goc=","X-Gm-Gg":"ATEYQzzZAs2cZxQ7Q789FEJueABBLHrtYgV7Q4NNRM3RXD/7SyBbfFzVHpVBRj11Tc+\n\tud6BdUYTzL4tjlEwxhOMvjcFgHti7S4eXsfBYWhbfcO3qvMtzjJKxwSA2DBoPskcwoCendfRlx0\n\tZVU/6/PMhywRtroG3JbbvRJaTcze38KeWUv4+UdgV7rFpFReklNirkafvMhOmvCDt/QnR+cEaOI\n\tnTOOTGXrXMX5i3P2ls6YSIIP13GoXVSKhCZx2WvwdHHP6a6FfRg5qxFUZR/HzI3EsjSGkw0s9ks\n\ti08Q8tQVhu1VBr0+AguRTvg7QichL83sUxXODA6zL8Twpl7TeA69OX2c+w23W1uGbbGS6Ed59Ap\n\tVRWn2ZCD7imXMz4UhZKVECGQ5uYDX9JEGxdrpYM0ScPS7u6nrDs2+rxPi1pZayvk0RoTJW8XVuF\n\t76pVFauLRmfEuree2sFCYgHzN+qmwicU62nn/qXgkvlToeztsIaFzyIhwLERvY5pmY","X-Received":["by 2002:a05:6122:4899:b0:56b:7cf0:cf67 with SMTP id\n 71dfb90a1353d-56d2210575dmr398668e0c.15.1774372000430;\n        Tue, 24 Mar 2026 10:06:40 -0700 (PDT)","by 2002:a05:6122:1da4:b0:56b:5978:22f5 with SMTP id\n 71dfb90a1353d-56d220a8b85mr416671e0c.12.1774371994638; Tue, 24 Mar 2026\n 10:06:34 -0700 (PDT)"],"Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","In-Reply-To":"<20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","From":"Geert Uytterhoeven <geert@linux-m68k.org>","Date":"Tue, 24 Mar 2026 18:06:22 +0100","X-Gmail-Original-Message-ID":"\n <CAMuHMdXX16=pih34yehj=3bJkg2H3ivGUj_34JDg31ABheLE5Q@mail.gmail.com>","X-Gm-Features":"AQROBzA3vydAXwvxX7mNaSzU55R-3eBg9lznDuFtNbFYtRdYd66gsLQKONTytjo","Message-ID":"\n <CAMuHMdXX16=pih34yehj=3bJkg2H3ivGUj_34JDg31ABheLE5Q@mail.gmail.com>","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of\n align","To":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>","Cc":"linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,\n\tGuenter Roeck <linux@roeck-us.net>, linux-alpha@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org,\n\tlinux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,\n\tlinux-sh@vger.kernel.org, Russell King <linux@armlinux.org.uk>,\n\tThomas Bogendoerfer <tsbogend@alpha.franken.de>,\n\t\"James E.J. Bottomley\" <James.Bottomley@hansenpartnership.com>,\n Helge Deller <deller@gmx.de>,\n\tMichael Ellerman <mpe@ellerman.id.au>, Thomas Gleixner <tglx@kernel.org>,\n Ingo Molnar <mingo@redhat.com>,\n\tBorislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,\n\t\"H. Peter Anvin\" <hpa@zytor.com>, Chris Zankel <chris@zankel.net>,\n Max Filippov <jcmvbkbc@gmail.com>,\n\tMadhavan Srinivasan <maddy@linux.ibm.com>,\n Yoshinori Sato <ysato@users.sourceforge.jp>,\n\tRich Felker <dalias@libc.org>,\n John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,\n\tlinux-kernel@vger.kernel.org, Greg Ungerer <gerg@linux-m68k.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3668613,"web_url":"http://patchwork.ozlabs.org/comment/3668613/","msgid":"<5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>","list_archive_url":null,"date":"2026-03-24T17:43:06","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","submitter":{"id":4003,"url":"http://patchwork.ozlabs.org/api/people/4003/","name":"John Paul Adrian Glaubitz","email":"glaubitz@physik.fu-berlin.de"},"content":"Hi Ilpo,\n\nOn Tue, 2026-03-24 at 18:56 +0200, Ilpo Järvinen wrote:\n> Aligning res->start by align inside pcibios_align_resource() is\n> unnecessary because caller of pcibios_align_resource() is\n> __find_resource_space() that aligns res->start with align before\n> calling pcibios_align_resource().\n> \n> Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> result in changing start either because 0x300 bits would have not\n> survived the earlier alignment if align was large enough to have an\n> impact.\n> \n> Thus, remove the duplicated aligning from pcibios_align_resource().\n> \n> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\n> ---\n>  arch/m68k/kernel/pcibios.c | 2 --\n>  1 file changed, 2 deletions(-)\n> \n> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> index 1415f6e4e5ce..7e286ee1976b 100644\n> --- a/arch/m68k/kernel/pcibios.c\n> +++ b/arch/m68k/kernel/pcibios.c\n> @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n>  \tif ((res->flags & IORESOURCE_IO) && (start & 0x300))\n>  \t\tstart = (start + 0x3ff) & ~0x3ff;\n>  \n> -\tstart = (start + align - 1) & ~(align - 1);\n> -\n>  \treturn start;\n>  }\n> \n\nSorry if it's a stupid question, but what does \"am68k\" in the subject refer to?\n\nAdrian","headers":{"Return-Path":"\n <linux-pci+bounces-50944-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256\n header.s=fub01 header.b=D8SNo1uQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-50944-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=fu-berlin.de header.i=@fu-berlin.de\n header.b=\"D8SNo1uQ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=130.133.4.66","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=zedat.fu-berlin.de"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgHWK2nHzz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 04:45:33 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 33D043016D32\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Mar 2026 17:43:47 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 46D1D40824B;\n\tTue, 24 Mar 2026 17:43:24 +0000 (UTC)","from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de\n [130.133.4.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9927F408243;\n\tTue, 24 Mar 2026 17:43:20 +0000 (UTC)","from inpost2.zedat.fu-berlin.de ([130.133.4.69])\n          by outpost.zedat.fu-berlin.de (Exim 4.99)\n          with esmtps (TLS1.3)\n          tls TLS_AES_256_GCM_SHA384\n          (envelope-from <glaubitz@zedat.fu-berlin.de>)\n          id 1w55mW-000000048aG-0PwD; Tue, 24 Mar 2026 18:43:08 +0100","from p5dc55f29.dip0.t-ipconnect.de ([93.197.95.41]\n helo=suse-laptop.fritz.box)\n          by inpost2.zedat.fu-berlin.de (Exim 4.99)\n          with esmtpsa (TLS1.3)\n          tls TLS_AES_256_GCM_SHA384\n          (envelope-from <glaubitz@physik.fu-berlin.de>)\n          id 1w55mV-00000001qau-3Gph; Tue, 24 Mar 2026 18:43:07 +0100"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774374204; cv=none;\n b=jvc3kQMi+DcKo78HBIgJPeV8kMl0HvMisgDl2pJNZSoKy/r9BeekzGpMOf36AMqXSF4Y+hrMfvw6+HwCYHEJSir9tOyPGwkfQPu+NFaHLB45tlyHQyNGtu+LdcCP9YokvJ5UnJLYBCQ9HLNUIfaDIF7RVUgn4RhfRMOqTJUYlHw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774374204; c=relaxed/simple;\n\tbh=CNmUFp8JkVWBujLfh61agf5vcNlLITuFzj372hFmm5c=;\n\th=Message-ID:Subject:From:To:Date:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=j/NyNrylFfNeSsuy3KucAf7nBhnDcTmiOifndbTk43/T6KSsa+FWs98aP7oviSstKkNMgDNJ/JcyNIHj5sjpeIw/BWBc87FECZJUVKx8nsTsU9y78pbC7i246pR08u2to5xPehUiFARUnJzR+BmSxz9N2pH0b/gs04ImO6DHuUs=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de;\n spf=pass smtp.mailfrom=zedat.fu-berlin.de;\n dkim=pass (2048-bit key) header.d=fu-berlin.de header.i=@fu-berlin.de\n header.b=D8SNo1uQ; arc=none smtp.client-ip=130.133.4.66","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding:\n\tContent-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:From:\n\tReply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:In-Reply-To:\n\tReferences; bh=AP49Wml/Qr/wzH3y6BxqbwOt7JtkHcoMn8XiWeebrkI=; t=1774374200;\n\tx=1774979000; b=D8SNo1uQMsOa3NR3jAQLPTo8B8nkT3YKcrSYvXuGfS3r3fvdqP2LOT5nkSiDC\n\tRzqVvPjJOKl+BYKoUDufQQoqA5Qnu2N0y5kx19WrEa8rBbb0PBTwVLpXI/TGjJW0d+4tnhA8Tlxib\n\tyBfyKnQlv1OvjakwFcCONIH/j/EDAa5h2ya0KBEGgdM8RUyCktIIlBT5ygRozB6k5tkZp/BG3BKXx\n\tSJdaOfD37ZDNl35T8600JNJUabXBbMrqblYmjQNOmEv8jud4hUk+AOUuzdX+F81aaaEmjVm1IGxBN\n\tuxrpqJSnTJk0Dc+iLPRjbJ4UBcYn0VTSOma287OhRbs868datg==;","Message-ID":"\n <5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","From":"John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>","To":"Ilpo =?iso-8859-1?q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n  linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,\n Guenter Roeck\t <linux@roeck-us.net>, linux-alpha@vger.kernel.org,\n  linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org,\n  linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,\n  linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,\n  linux-sh@vger.kernel.org, Russell King <linux@armlinux.org.uk>,\n Geert Uytterhoeven <geert@linux-m68k.org>,\n Thomas Bogendoerfer <tsbogend@alpha.franken.de>,\n \"James E.J. Bottomley\" <James.Bottomley@HansenPartnership.com>,\n Helge Deller <deller@gmx.de>, Michael Ellerman\t <mpe@ellerman.id.au>,\n Thomas Gleixner <tglx@kernel.org>, Ingo Molnar\t <mingo@redhat.com>,\n Borislav Petkov <bp@alien8.de>, Dave Hansen\t <dave.hansen@linux.intel.com>,\n \"H. Peter Anvin\" <hpa@zytor.com>, Chris Zankel\t <chris@zankel.net>,\n Max Filippov <jcmvbkbc@gmail.com>,\n Madhavan Srinivasan\t <maddy@linux.ibm.com>,\n Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker\t <dalias@libc.org>,\n linux-kernel@vger.kernel.org","Date":"Tue, 24 Mar 2026 18:43:06 +0100","In-Reply-To":"<20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n\t <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.58.3 ","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","X-Original-Sender":"glaubitz@physik.fu-berlin.de","X-ZEDAT-Hint":"PO"}},{"id":3668621,"web_url":"http://patchwork.ozlabs.org/comment/3668621/","msgid":"<1c08efcd-25e8-6436-52ab-ac3d50dcf58f@linux.intel.com>","list_archive_url":null,"date":"2026-03-24T17:55:32","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Tue, 24 Mar 2026, John Paul Adrian Glaubitz wrote:\n\n> Hi Ilpo,\n> \n> On Tue, 2026-03-24 at 18:56 +0200, Ilpo Järvinen wrote:\n> > Aligning res->start by align inside pcibios_align_resource() is\n> > unnecessary because caller of pcibios_align_resource() is\n> > __find_resource_space() that aligns res->start with align before\n> > calling pcibios_align_resource().\n> > \n> > Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> > result in changing start either because 0x300 bits would have not\n> > survived the earlier alignment if align was large enough to have an\n> > impact.\n> > \n> > Thus, remove the duplicated aligning from pcibios_align_resource().\n> > \n> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\n> > ---\n> >  arch/m68k/kernel/pcibios.c | 2 --\n> >  1 file changed, 2 deletions(-)\n> > \n> > diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> > index 1415f6e4e5ce..7e286ee1976b 100644\n> > --- a/arch/m68k/kernel/pcibios.c\n> > +++ b/arch/m68k/kernel/pcibios.c\n> > @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n> >  \tif ((res->flags & IORESOURCE_IO) && (start & 0x300))\n> >  \t\tstart = (start + 0x3ff) & ~0x3ff;\n> >  \n> > -\tstart = (start + align - 1) & ~(align - 1);\n> > -\n> >  \treturn start;\n> >  }\n> > \n> \n> Sorry if it's a stupid question, but what does \"am68k\" in the subject refer to?\n\nThe extra \"a\" is a typo. I'm sorry about that.","headers":{"Return-Path":"\n <linux-pci+bounces-50945-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=YCQ9WpJE;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-50945-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"YCQ9WpJE\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.17","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgHll3fBhz1y1g\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 04:56:19 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id D6500301FCA5\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Mar 2026 17:56:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 307A23C8715;\n\tTue, 24 Mar 2026 17:56:16 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 47D913A1683;\n\tTue, 24 Mar 2026 17:56:13 +0000 (UTC)","from fmviesa010.fm.intel.com ([10.60.135.150])\n  by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Mar 2026 10:55:45 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.244.217])\n  by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Mar 2026 10:55:35 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774374976; cv=none;\n b=c7cbHsgfeIhhovVejV0H7b47h1FaIAUQkhyVhXN14YTNu28cmHb3rRYd1zwsLRwNV1bqEdlL7kmcewkZnrLfCPhulomfJVPUbtJNW9+kINdIXpdJ7RigDCqREwalHBHh1UFkBcHdlyKibfmF+ByK6FaXqiB+pHC614btocmshLE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774374976; c=relaxed/simple;\n\tbh=NL1mcB9ozeqOSsqCkkguLMRCIYPAgFUo0JaJzh10URc=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=eQK8uDYYOOG+oNgjW6JjFZrVr+qAOM+SK5GtZuIQFD/TZNeYzf37y8lXBcfRvFHA97OzyJqzN3roEFo23/mv154w/qCqiBLrCdDVaqesFZCG4Ns6QKE3BYDrFqWM5LCCVdxX1sT+7DLjoEaTjlnE7jcDbvt9iWSBaldH1fCYwY0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=YCQ9WpJE; arc=none smtp.client-ip=192.198.163.17","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n  t=1774374974; x=1805910974;\n  h=from:date:to:cc:subject:in-reply-to:message-id:\n   references:mime-version;\n  bh=NL1mcB9ozeqOSsqCkkguLMRCIYPAgFUo0JaJzh10URc=;\n  b=YCQ9WpJEIuOh2fMNmwvSVP2FFRjdMjXdvqGUCZ4i9oGUX2X24Hg53oIp\n   tdJ1rfQL8ZL8i9zKmj8XTH0M6Nroy7qZodrP32gmIEfBmtNeOmiLfP3r9\n   Ex1OvzFyEaYV0uh+DUYUzWcMEihhQn69o3EwL8L2mX9TpMoFoDUlQ5WSa\n   qoMbmuULpnZ4UqSxubwCj63JyW1lWPyyvmR9z+feNe2oBum+FJBMlUkRB\n   Rf5uhizGwKpgoo4/E4Xwn35ysDE7t3y4dm/DTp8Zqk/i84b0UrbhU1n+b\n   9koqJ1UVFZ+YVrpgGVHrvd0m5dDssLbHw95kDzTnSWJAWWj0MRhIBcVib\n   g==;","X-CSE-ConnectionGUID":["km9n6O3dReWAAI7LluP7OQ==","mUXuAQFLRnadhyMeGmty4g=="],"X-CSE-MsgGUID":["cO/M3LExSC2grBUM/0Soxw==","bujbx+8xS52CYl9LobjFjg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11739\"; a=\"75307419\"","E=Sophos;i=\"6.23,138,1770624000\";\n   d=\"scan'208\";a=\"75307419\"","E=Sophos;i=\"6.23,138,1770624000\";\n   d=\"scan'208\";a=\"220002724\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>","Date":"Tue, 24 Mar 2026 19:55:32 +0200 (EET)","To":"John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>","cc":"linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,\n    Guenter Roeck <linux@roeck-us.net>, linux-alpha@vger.kernel.org,\n    linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org,\n    linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,\n    linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,\n    linux-sh@vger.kernel.org, Russell King <linux@armlinux.org.uk>,\n    Geert Uytterhoeven <geert@linux-m68k.org>,\n    Thomas Bogendoerfer <tsbogend@alpha.franken.de>,\n    \"James E.J. Bottomley\" <James.Bottomley@HansenPartnership.com>,\n    Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,\n    Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,\n    Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,\n    \"H. Peter Anvin\" <hpa@zytor.com>, Chris Zankel <chris@zankel.net>,\n    Max Filippov <jcmvbkbc@gmail.com>,\n    Madhavan Srinivasan <maddy@linux.ibm.com>,\n    Yoshinori Sato <ysato@users.sourceforge.jp>,\n Rich Felker <dalias@libc.org>,\n    LKML <linux-kernel@vger.kernel.org>","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","In-Reply-To":"\n <5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>","Message-ID":"<1c08efcd-25e8-6436-52ab-ac3d50dcf58f@linux.intel.com>","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n  <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>\n <5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-641337346-1774374932=:1055\""}},{"id":3668644,"web_url":"http://patchwork.ozlabs.org/comment/3668644/","msgid":"<de9bf8fef8e311f37335507f0e715d113cd91bc5.camel@physik.fu-berlin.de>","list_archive_url":null,"date":"2026-03-24T18:36:27","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","submitter":{"id":4003,"url":"http://patchwork.ozlabs.org/api/people/4003/","name":"John Paul Adrian Glaubitz","email":"glaubitz@physik.fu-berlin.de"},"content":"On Tue, 2026-03-24 at 19:55 +0200, Ilpo Järvinen wrote:\n> On Tue, 24 Mar 2026, John Paul Adrian Glaubitz wrote:\n> \n> > Hi Ilpo,\n> > \n> > On Tue, 2026-03-24 at 18:56 +0200, Ilpo Järvinen wrote:\n> > > Aligning res->start by align inside pcibios_align_resource() is\n> > > unnecessary because caller of pcibios_align_resource() is\n> > > __find_resource_space() that aligns res->start with align before\n> > > calling pcibios_align_resource().\n> > > \n> > > Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> > > result in changing start either because 0x300 bits would have not\n> > > survived the earlier alignment if align was large enough to have an\n> > > impact.\n> > > \n> > > Thus, remove the duplicated aligning from pcibios_align_resource().\n> > > \n> > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\n> > > ---\n> > >  arch/m68k/kernel/pcibios.c | 2 --\n> > >  1 file changed, 2 deletions(-)\n> > > \n> > > diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> > > index 1415f6e4e5ce..7e286ee1976b 100644\n> > > --- a/arch/m68k/kernel/pcibios.c\n> > > +++ b/arch/m68k/kernel/pcibios.c\n> > > @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n> > >  \tif ((res->flags & IORESOURCE_IO) && (start & 0x300))\n> > >  \t\tstart = (start + 0x3ff) & ~0x3ff;\n> > >  \n> > > -\tstart = (start + align - 1) & ~(align - 1);\n> > > -\n> > >  \treturn start;\n> > >  }\n> > > \n> > \n> > Sorry if it's a stupid question, but what does \"am68k\" in the subject refer to?\n> \n> The extra \"a\" is a typo. I'm sorry about that.\n\nNo worries, I just thought I missed something obvious and felt stupid to ask ;-).\n\nAdrian","headers":{"Return-Path":"\n <linux-pci+bounces-50947-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256\n header.s=fub01 header.b=ROAR34qq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-50947-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=fu-berlin.de header.i=@fu-berlin.de\n header.b=\"ROAR34qq\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=130.133.4.66","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=zedat.fu-berlin.de"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgJfR3JV0z1yFq\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 25 Mar 2026 05:36:47 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 140D2301DD85\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 24 Mar 2026 18:36:44 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id DE385313E01;\n\tTue, 24 Mar 2026 18:36:40 +0000 (UTC)","from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de\n [130.133.4.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C1DE03502B8;\n\tTue, 24 Mar 2026 18:36:38 +0000 (UTC)","from inpost2.zedat.fu-berlin.de ([130.133.4.69])\n          by outpost.zedat.fu-berlin.de (Exim 4.99)\n          with esmtps (TLS1.3)\n          tls TLS_AES_256_GCM_SHA384\n          (envelope-from <glaubitz@zedat.fu-berlin.de>)\n          id 1w56c9-00000000BcZ-2HRb; Tue, 24 Mar 2026 19:36:29 +0100","from p5dc55f29.dip0.t-ipconnect.de ([93.197.95.41]\n helo=suse-laptop.fritz.box)\n          by inpost2.zedat.fu-berlin.de (Exim 4.99)\n          with esmtpsa (TLS1.3)\n          tls TLS_AES_256_GCM_SHA384\n          (envelope-from <glaubitz@physik.fu-berlin.de>)\n          id 1w56c9-00000001y8z-0w0E; Tue, 24 Mar 2026 19:36:29 +0100"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774377400; cv=none;\n b=OTtULeil9IspmJ8+Za1S6TgYjDju88XLPCxpBB6VpI6G777C30FxMrBgowZHEN5NPUqGuOjVCIEqV65H1uXTaSLcCgK3wLapL4GI86xVWmA/nCq2wNQu8NEynCoqi2QSvBeM1ATvt/+FhfQ2/GmVN426ZCBqU1KU65ibjao84Ak=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774377400; c=relaxed/simple;\n\tbh=CR5/H6jk/spqZtGbl3vbbrLXD63pd8iURB3okeroTcY=;\n\th=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=TGST2GRVCyCuUT6OeCmbcsVmHH/9/E8099P22QPIhmHYmZh/U3M3rKhfuN0kFDBm+fMYHZjNHetV4hi/oWYaV67a9FXIhneNoJq8O31G1pFNzgqpC+vyLwTPBzoXaxnVsZTt2fbiJjNDANwu2GQyqPefcwyO11QmNBPr6xArBWM=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de;\n spf=pass smtp.mailfrom=zedat.fu-berlin.de;\n dkim=pass (2048-bit key) header.d=fu-berlin.de header.i=@fu-berlin.de\n header.b=ROAR34qq; arc=none smtp.client-ip=130.133.4.66","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding:\n\tContent-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:From:\n\tReply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:In-Reply-To:\n\tReferences; bh=TMacGYMUcDU/ZfxMzZ5qB4lAQfMCgWI9xYNANb/3NJE=; t=1774377398;\n\tx=1774982198; b=ROAR34qq8LtotAQ+z4eU9DUiOLRXMu1qt6BEJUtvAGwBMkEua9GWWTE8Nq5o1\n\tDQDO8gj44BlzhvHxqcy4Fe9Qd7jEPAM+JDU70D9BbWuGLXDbviVa8lb3VBc2aG8Hu4Jd7ZS85o1RL\n\t3vfS+JSQbjGL3IHDDFj0aSeoBe/qBt/lroiAaKfTUeug6ULI9EX3O146goonePpahvPga5SASG6kY\n\teF3cOFQvyHiND9/QgwhG/QOJzIYDiRFC539PiJWx/m7F65i2JlBQAlBXLn6kfyEDffe8rvX2AL78p\n\tMiO0St9DBDptfiY+hHmBZdImb1jjrOvCQbqPST5EUo6SCXrjHw==;","Message-ID":"\n <de9bf8fef8e311f37335507f0e715d113cd91bc5.camel@physik.fu-berlin.de>","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","From":"John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>","To":"Ilpo =?iso-8859-1?q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>","Cc":"linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>, Guenter\n Roeck <linux@roeck-us.net>, linux-alpha@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, \tlinux-m68k@lists.linux-m68k.org,\n linux-mips@vger.kernel.org, \tlinux-parisc@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org, \tlinux-s390@vger.kernel.org,\n linux-sh@vger.kernel.org, Russell King\t <linux@armlinux.org.uk>, Geert\n Uytterhoeven <geert@linux-m68k.org>, Thomas Bogendoerfer\n <tsbogend@alpha.franken.de>, \"James E.J. Bottomley\"\n <James.Bottomley@HansenPartnership.com>,  Helge Deller\t <deller@gmx.de>,\n Michael Ellerman <mpe@ellerman.id.au>, Thomas Gleixner\t <tglx@kernel.org>,\n Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,  Dave\n Hansen <dave.hansen@linux.intel.com>, \"H. Peter Anvin\" <hpa@zytor.com>,\n Chris Zankel <chris@zankel.net>,  Max Filippov <jcmvbkbc@gmail.com>,\n Madhavan Srinivasan <maddy@linux.ibm.com>, Yoshinori Sato\t\n <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, LKML\t\n <linux-kernel@vger.kernel.org>","Date":"Tue, 24 Mar 2026 19:36:27 +0100","In-Reply-To":"<1c08efcd-25e8-6436-52ab-ac3d50dcf58f@linux.intel.com>","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n\t  <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>\n\t <5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>\n\t <1c08efcd-25e8-6436-52ab-ac3d50dcf58f@linux.intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.58.3 ","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","X-Original-Sender":"glaubitz@physik.fu-berlin.de","X-ZEDAT-Hint":"PO"}},{"id":3670039,"web_url":"http://patchwork.ozlabs.org/comment/3670039/","msgid":"<b89ac970-7990-4a12-9769-82efc945c950@linux-m68k.org>","list_archive_url":null,"date":"2026-03-27T02:55:55","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of\n align","submitter":{"id":70179,"url":"http://patchwork.ozlabs.org/api/people/70179/","name":"Greg Ungerer","email":"gerg@linux-m68k.org"},"content":"On 25/3/26 02:56, Ilpo Järvinen wrote:\n> Aligning res->start by align inside pcibios_align_resource() is\n> unnecessary because caller of pcibios_align_resource() is\n> __find_resource_space() that aligns res->start with align before\n> calling pcibios_align_resource().\n> \n> Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> result in changing start either because 0x300 bits would have not\n> survived the earlier alignment if align was large enough to have an\n> impact.\n> \n> Thus, remove the duplicated aligning from pcibios_align_resource().\n> \n> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\n\nLGTM.\n\nAcked-by: Greg Ungerer <gerg@linux-m68k.org>\n\n\n> ---\n>   arch/m68k/kernel/pcibios.c | 2 --\n>   1 file changed, 2 deletions(-)\n> \n> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> index 1415f6e4e5ce..7e286ee1976b 100644\n> --- a/arch/m68k/kernel/pcibios.c\n> +++ b/arch/m68k/kernel/pcibios.c\n> @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n>   \tif ((res->flags & IORESOURCE_IO) && (start & 0x300))\n>   \t\tstart = (start + 0x3ff) & ~0x3ff;\n>   \n> -\tstart = (start + align - 1) & ~(align - 1);\n> -\n>   \treturn start;\n>   }\n>","headers":{"Return-Path":"\n <linux-pci+bounces-51244-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-51244-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhlsH4dxnz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 14:06:11 +1100 (AEDT)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 8DA0E3028350\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 27 Mar 2026 02:56:08 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 902C433EAF9;\n\tFri, 27 Mar 2026 02:56:06 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 69A7333DEFE;\n\tFri, 27 Mar 2026 02:56:06 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 62989C116C6;\n\tFri, 27 Mar 2026 02:55:59 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1774580166; cv=none;\n b=PYppQGzQakaZvb5XWfx246yOneNOlAL8md37/l9d94+CyEK9+5RjMJgLO2TG/kMscSEuwHwpTrNXJDG4BbxN7ozcPVDHphHm24/SUQch9gisKh+j1DyKDV2Sq/t6faGQEsnbPlaX+xQhNP0aa171i0MMjMV26WScxxI0aSdMfZ8=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1774580166; c=relaxed/simple;\n\tbh=OXABB1eFjeN1oGH/SXFHZZT4FCIkSR1xm49zyhunO7w=;\n\th=Message-ID:Date:MIME-Version:Subject:To:References:From:\n\t In-Reply-To:Content-Type;\n b=mL6oPjZ6AV+g3fkAf9SZCzXneiKUUjWFVQz58U87NpDv7XBvPVHCKNOHPf/08i0XS8inf7tWC62+cJqUlB1RdL47O/nyrRqYb9pjCpWJ6kPVMguhXeqYD5nmaDsRpqDGV8+ooT/tcUHcSQbhPwczO7hsMW1ClEOCeLMuInIHzYE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201","Message-ID":"<b89ac970-7990-4a12-9769-82efc945c950@linux-m68k.org>","Date":"Fri, 27 Mar 2026 12:55:55 +1000","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of\n align","To":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,\n Guenter Roeck <linux@roeck-us.net>, linux-alpha@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org,\n linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,\n linux-sh@vger.kernel.org, Russell King <linux@armlinux.org.uk>,\n Geert Uytterhoeven <geert@linux-m68k.org>,\n Thomas Bogendoerfer <tsbogend@alpha.franken.de>,\n \"James E.J. Bottomley\" <James.Bottomley@HansenPartnership.com>,\n Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>,\n Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,\n Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,\n \"H. Peter Anvin\" <hpa@zytor.com>, Chris Zankel <chris@zankel.net>,\n Max Filippov <jcmvbkbc@gmail.com>, Madhavan Srinivasan <maddy@linux.ibm.com>,\n Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>,\n John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,\n linux-kernel@vger.kernel.org","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","Content-Language":"en-US","From":"Greg Ungerer <gerg@linux-m68k.org>","In-Reply-To":"<20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit"}}]