[{"id":3668589,"web_url":"http://patchwork.ozlabs.org/comment/3668589/","msgid":"","date":"2026-03-24T17:06:22","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of\n align","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"CC gerg\n\nOn Tue, 24 Mar 2026 at 17:59, Ilpo Järvinen\n wrote:\n>\n> Aligning res->start by align inside pcibios_align_resource() is\n> unnecessary because caller of pcibios_align_resource() is\n> __find_resource_space() that aligns res->start with align before\n> calling pcibios_align_resource().\n>\n> Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> result in changing start either because 0x300 bits would have not\n> survived the earlier alignment if align was large enough to have an\n> impact.\n>\n> Thus, remove the duplicated aligning from pcibios_align_resource().\n>\n> Signed-off-by: Ilpo Järvinen \n> ---\n> arch/m68k/kernel/pcibios.c | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> index 1415f6e4e5ce..7e286ee1976b 100644\n> --- a/arch/m68k/kernel/pcibios.c\n> +++ b/arch/m68k/kernel/pcibios.c\n> @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n> if ((res->flags & IORESOURCE_IO) && (start & 0x300))\n> start = (start + 0x3ff) & ~0x3ff;\n>\n> - start = (start + align - 1) & ~(align - 1);\n> -\n> return start;\n> }\n>\n> --\n> 2.39.5","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18737-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=209.85.214.174","lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=209.85.214.174; helo=mail-pl1-f174.google.com;\n envelope-from=geert.uytterhoeven@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgGnN5mXwz1y1g\n\tfor ; Wed, 25 Mar 2026 04:12:40 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fgGnM0Jmlz2ynn;\n\tWed, 25 Mar 2026 04:12:39 +1100 (AEDT)","from mail-pl1-f174.google.com (mail-pl1-f174.google.com\n [209.85.214.174])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fgGnK35gJz2yhZ\n\tfor ; Wed, 25 Mar 2026 04:12:36 +1100 (AEDT)","by mail-pl1-f174.google.com with SMTP id\n d9443c01a7336-2a8fba3f769so26268155ad.2\n for ;\n Tue, 24 Mar 2026 10:12:36 -0700 (PDT)","from mail-dl1-f42.google.com (mail-dl1-f42.google.com.\n [74.125.82.42])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b083516eacsm189097645ad.15.2026.03.24.10.12.33\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Tue, 24 Mar 2026 10:12:33 -0700 (PDT)","by mail-dl1-f42.google.com with SMTP id\n a92af1059eb24-128ebee22caso4566271c88.0\n for ;\n Tue, 24 Mar 2026 10:12:33 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774372358;\n\tcv=none;\n b=IeWzuew+LY+I77rxXl2oXPlx+itEk/YzP5i3TZipTrxYhfzWqdWi46NaW6WLn7zEDUU3Q9Yp77jIWPmN8UTTxnvEApMlLM6RqTrVni/lg+wumBLMt9o3N2j2E877z2+6g7D9eoi9/CK2WIN5QaKJccj1mJYQ+lkq28AynHeRgvaH4lilWSWWhtAelvTRdyz0eh7NNm1B3apOwE//smjx25yj3h0boZT9ErM17fF/xEEKvdHUCvqSffar5pfDewfuLCx66FUx+GiS2GM33MiwuIgCasskRWBMz4f0h5stGo+Ler1ZYSzbdT8VS5UHykh46X9Rm/SYqtkV2FqIdoyplQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774372358; c=relaxed/relaxed;\n\tbh=imA4hBFgRxEV6K6PxesH3aFI8Gk9es7sFYCGiASF9lc=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=PM/XmBfLF11XBWbmjYO6ty/MDZY3N1SoKGkN9fuIyg3mwo8rqbUUMH79ASXkUFNIq897s8LT/Jw8MzYC2PpomECpbYEEmlTCxSyRtc7hX8mdtSHH8DGi+KlQT7tGhdwcysVXwC3N7CinIu/KXXYNkukbc/VV/jvGkuxq5mW15TKz9upRxufQi+YSf8u+/9s0ux3Bwdb1miPwlTCkNjUb/e7f5ty/jBdlY6B+W5M6bmS4cdgYOPJsMNuffoJaJhi86+lSmPYdRrzilV4zULx/c2UKBMorzHn0WaeuCdFykFZGPeJwAb/AjfnEaam88/vE3LLXZ4fQj1lY7gfgX7s6Gg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org;\n spf=pass (client-ip=209.85.214.174; helo=mail-pl1-f174.google.com;\n envelope-from=geert.uytterhoeven@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774372354; x=1774977154;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=imA4hBFgRxEV6K6PxesH3aFI8Gk9es7sFYCGiASF9lc=;\n b=FlJTkpIcPSJbBV8y1QYC01ADYJ/FDuH78lfC2aDfJs3pP7PiekbX5N9Br05oimOyxh\n JLQq/YRyEz5uop9ex2aEFT2HGpGdwrcvUXQ1Dlm+JVFFlHEecQ857GsL9ymzmp8ccGt6\n SLpjk8YD6Ebk8ei49ZnDsa9LecRNIph6y7IZ7Q5skNZDaGzEwtOx7CVsGWFkXFqbyIog\n Aou0sZKbR1wOsw9QmlA8fK0CVAVe/TsG817HrqlZrrFKseYBJDvaux8yAaPyeLQ77J7r\n wR0Nl78UTcSiuGhDTGWoVkOiwLPmAe4X7OcGOU0otIybjq71NmUJizvCNaZcFtpUmwZG\n OO7w==","X-Forwarded-Encrypted":["i=1;\n AJvYcCU2HO0ugN7CzFfVc6GkCQ/IliBsdJ+kBwU9CTMqoFJqtQj8SKe8yJ8SqyFwiKsrm+aHmSfkQQzvwTjz/pw=@lists.ozlabs.org","i=1;\n AJvYcCVQ81y9Dv0RM3fQVeDaPcSndf/37dPvP8eMIGrCDMz3dT/V7+d7q2U/oatI0UNKA3RgtMl0vhafxFO7KYY=@lists.ozlabs.org"],"X-Gm-Message-State":"AOJu0YxEpUfgkBJGtp3Va7ROW6YrhEJEZp4WrRHOdngsG+6H4K+wBgNS\n\t792SJ3P/B72kaeuKfFzm/3ZEzIk8snMGk8aLYpXD4JGbM87qDC9DiFs5wGZwpDiXFAg=","X-Gm-Gg":"ATEYQzzPjQUZMeXdLky3HAjGpQNJgULZzPdzat6CAQa2AIJGTGnUXbpVTOPt390EIG5\n\tpVBm5WRRCN3w4PBYRmv1c8qBEiX5rplIckyUrW5Irqu4grjwGWOOlXL5s7ZB8Aqjl+KR+Ybwg2x\n\tc5+j+hUb5XQOHfXu30Y8n+13uDtRfBO+dakaihMS93xjLmiiY68PNk+tG/3RMoB8GinlQQTRHet\n\tlxRbEg7P+vWg9tU88ByA15Jb/3EJMLvgLsX2WhbviwDchTJfQinb8vwh9dYuPbxGnp301tQsDCC\n\tZEAj3nMvSVjZ6E0bVtqWTWWvb3vxD3zQFFUIeLRw2g2niPm9I2MmpFIMdsGnRspjh+Xs0g4H6Pp\n\tA4JA9DK8vdfZ6EoDhfmmP4y9L2NXh773OjLVpeCSKmN4q7Em/hKda599zRR4oh/e5+KpnUqJ1vQ\n\t8o2azDWY2yIhVC5YMcNQ4H/EB/VvxSoxP9xsN0EDfq0CucmIqdOJAnqm9tbFI=","X-Received":["by 2002:a17:902:ef11:b0:2b0:7225:d2c0 with SMTP id\n d9443c01a7336-2b0b0af56ccmr3921315ad.30.1774372353585;\n Tue, 24 Mar 2026 10:12:33 -0700 (PDT)","by 2002:a05:6122:1da4:b0:56b:5978:22f5 with SMTP id\n 71dfb90a1353d-56d220a8b85mr416671e0c.12.1774371994638; Tue, 24 Mar 2026\n 10:06:34 -0700 (PDT)"],"X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","In-Reply-To":"<20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","From":"Geert Uytterhoeven ","Date":"Tue, 24 Mar 2026 18:06:22 +0100","X-Gmail-Original-Message-ID":"\n ","X-Gm-Features":"AQROBzA3vydAXwvxX7mNaSzU55R-3eBg9lznDuFtNbFYtRdYd66gsLQKONTytjo","Message-ID":"\n ","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of\n align","To":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Cc":"linux-pci@vger.kernel.org, Bjorn Helgaas ,\n\tGuenter Roeck , linux-alpha@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org,\n\tlinux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,\n\tlinux-sh@vger.kernel.org, Russell King ,\n\tThomas Bogendoerfer ,\n\t\"James E.J. Bottomley\" ,\n Helge Deller ,\n\tMichael Ellerman , Thomas Gleixner ,\n Ingo Molnar ,\n\tBorislav Petkov , Dave Hansen ,\n\t\"H. Peter Anvin\" , Chris Zankel ,\n Max Filippov ,\n\tMadhavan Srinivasan ,\n Yoshinori Sato ,\n\tRich Felker ,\n John Paul Adrian Glaubitz ,\n\tlinux-kernel@vger.kernel.org, Greg Ungerer ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Spam-Status":"No, score=0.0 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN,\n\tFREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3668612,"web_url":"http://patchwork.ozlabs.org/comment/3668612/","msgid":"<5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>","date":"2026-03-24T17:43:06","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","submitter":{"id":4003,"url":"http://patchwork.ozlabs.org/api/people/4003/","name":"John Paul Adrian Glaubitz","email":"glaubitz@physik.fu-berlin.de"},"content":"Hi Ilpo,\n\nOn Tue, 2026-03-24 at 18:56 +0200, Ilpo Järvinen wrote:\n> Aligning res->start by align inside pcibios_align_resource() is\n> unnecessary because caller of pcibios_align_resource() is\n> __find_resource_space() that aligns res->start with align before\n> calling pcibios_align_resource().\n> \n> Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> result in changing start either because 0x300 bits would have not\n> survived the earlier alignment if align was large enough to have an\n> impact.\n> \n> Thus, remove the duplicated aligning from pcibios_align_resource().\n> \n> Signed-off-by: Ilpo Järvinen \n> ---\n> arch/m68k/kernel/pcibios.c | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> index 1415f6e4e5ce..7e286ee1976b 100644\n> --- a/arch/m68k/kernel/pcibios.c\n> +++ b/arch/m68k/kernel/pcibios.c\n> @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n> \tif ((res->flags & IORESOURCE_IO) && (start & 0x300))\n> \t\tstart = (start + 0x3ff) & ~0x3ff;\n> \n> -\tstart = (start + align - 1) & ~(align - 1);\n> -\n> \treturn start;\n> }\n> \n\nSorry if it's a stupid question, but what does \"am68k\" in the subject refer to?\n\nAdrian","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256\n header.s=fub01 header.b=YOgsvd8l;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18738-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org; arc=none smtp.remote-ip=130.133.4.66","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256\n header.s=fub01 header.b=YOgsvd8l;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=zedat.fu-berlin.de\n (client-ip=130.133.4.66; helo=outpost1.zedat.fu-berlin.de;\n envelope-from=glaubitz@zedat.fu-berlin.de; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgHT023xqz1y1g\n\tfor ; Wed, 25 Mar 2026 04:43:32 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fgHSt5htZz2ynn;\n\tWed, 25 Mar 2026 04:43:26 +1100 (AEDT)","from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de\n [130.133.4.66])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fgHSq1kPnz2xKh\n\tfor ; Wed, 25 Mar 2026 04:43:21 +1100 (AEDT)","from inpost2.zedat.fu-berlin.de ([130.133.4.69])\n by outpost.zedat.fu-berlin.de (Exim 4.99)\n with esmtps (TLS1.3)\n tls TLS_AES_256_GCM_SHA384\n (envelope-from )\n id 1w55mW-000000048aG-0PwD; Tue, 24 Mar 2026 18:43:08 +0100","from p5dc55f29.dip0.t-ipconnect.de ([93.197.95.41]\n helo=suse-laptop.fritz.box)\n by inpost2.zedat.fu-berlin.de (Exim 4.99)\n with esmtpsa (TLS1.3)\n tls TLS_AES_256_GCM_SHA384\n (envelope-from )\n id 1w55mV-00000001qau-3Gph; Tue, 24 Mar 2026 18:43:07 +0100"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774374206;\n\tcv=none;\n b=hlpmq3U34sGONA0z77dLeLogKeX9rKkezCD9DVEzu2vvl99Ll6iT4M3lM/OFQrFMiIhy9U940VL4Tz7ryyPB49hrCTvn+gBSZz3OydK/3vDueJovXYloo/XRe86UZvCbDqDDv+2J4nzikMby+nMb/pGZQYBjcxBt/jXFApUlr60SaFLLhImhLtyI0lEQOVPFiHMD4WEyp5FL/cBRHpAaQaG4I7zo6DeBoPpB00Fz09QWk1rGDY126PSHPXKMFzW63P29sj5azmRNMSet35XconU0Ydc8WGytl2oj00KZnFB9xYjtl7NdD84faYf3yFfEC0vDw2o9XWVlcnRMOdJOUA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774374206; c=relaxed/relaxed;\n\tbh=AP49Wml/Qr/wzH3y6BxqbwOt7JtkHcoMn8XiWeebrkI=;\n\th=Message-ID:Subject:From:To:Date:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=KkPvkdOK4zOrNOCQBw5PynJUVBvoQ7Sf9KMCGCBnB9k5VbmhStX+VvFqU/l2p7T9NDWkSWSuKSHq4J55CY5N8lLiDEJXLdZZFd0dEHttheFoIcYqzgLisqC7yOJyDlhsN932t6ALxj92wYL7MAT+lHC4X/9XSzzqsbqjPOa6V2LKkpFPtPw64SeaoCSkdQHGQlv88cZB3gdKPqs5kos5PHtpxqDRGVO/modZK+HYbeMH7w5PxQETZueNyayRLFcczSZyQkSN1ttKYYRIxM6C99ghMHa4g+xlGrfTcs64htAlCzckYO9UNMoyrWfj7XoHvoHwE7zN05nL0fzHKTQLpg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de;\n dkim=pass (2048-bit key;\n unprotected) header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256\n header.s=fub01 header.b=YOgsvd8l; dkim-atps=neutral;\n spf=pass (client-ip=130.133.4.66; helo=outpost1.zedat.fu-berlin.de;\n envelope-from=glaubitz@zedat.fu-berlin.de;\n receiver=lists.ozlabs.org) smtp.mailfrom=zedat.fu-berlin.de","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding:\n\tContent-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:From:\n\tReply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:In-Reply-To:\n\tReferences; bh=AP49Wml/Qr/wzH3y6BxqbwOt7JtkHcoMn8XiWeebrkI=; t=1774374203;\n\tx=1774979003; b=YOgsvd8lK8vSzcL/e3EAcPJZ0S/g4bZORGwHQY8NquyLRbADXeuWmuzMo3ffC\n\t350JTb6+2VSL9LFNBvXu3RJHr5LpB6jro+MGwtsBirXpZyZ248oXZT8Iq9Q6EvUkkIr12kkf5p0CH\n\tF/trQVPs+OnBbi7/TLM0xNbo7AyNkHc3FUQf8m9DtZt0bpA7mL7M3360WTgYmuL2P9z30VHqlDYb/\n\tPSUa0VQgt4eabxfEGRth0+ZvKnHV4OepAIIiS9Ie+G0UTDjN7eEZY9pXyh0UK8oCy/mxO6PgqdVYX\n\tKP2j5kuDqTs5Pltwdq/CiBGHLkK9mHBdaAQAjerqWFiuNX2w/g==;","Message-ID":"\n <5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","From":"John Paul Adrian Glaubitz ","To":"Ilpo =?iso-8859-1?q?J=E4rvinen?= ,\n linux-pci@vger.kernel.org, Bjorn Helgaas ,\n Guenter Roeck\t , linux-alpha@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org,\n linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,\n linux-sh@vger.kernel.org, Russell King ,\n Geert Uytterhoeven ,\n Thomas Bogendoerfer ,\n \"James E.J. Bottomley\" ,\n Helge Deller , Michael Ellerman\t ,\n Thomas Gleixner , Ingo Molnar\t ,\n Borislav Petkov , Dave Hansen\t ,\n \"H. Peter Anvin\" , Chris Zankel\t ,\n Max Filippov ,\n Madhavan Srinivasan\t ,\n Yoshinori Sato , Rich Felker\t ,\n linux-kernel@vger.kernel.org","Date":"Tue, 24 Mar 2026 18:43:06 +0100","In-Reply-To":"<20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n\t <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.58.3 ","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","X-Original-Sender":"glaubitz@physik.fu-berlin.de","X-Originating-IP":"93.197.95.41","X-ZEDAT-Hint":"PO","X-Spam-Status":"No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3668622,"web_url":"http://patchwork.ozlabs.org/comment/3668622/","msgid":"<1c08efcd-25e8-6436-52ab-ac3d50dcf58f@linux.intel.com>","date":"2026-03-24T17:55:32","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Tue, 24 Mar 2026, John Paul Adrian Glaubitz wrote:\n\n> Hi Ilpo,\n> \n> On Tue, 2026-03-24 at 18:56 +0200, Ilpo Järvinen wrote:\n> > Aligning res->start by align inside pcibios_align_resource() is\n> > unnecessary because caller of pcibios_align_resource() is\n> > __find_resource_space() that aligns res->start with align before\n> > calling pcibios_align_resource().\n> > \n> > Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> > result in changing start either because 0x300 bits would have not\n> > survived the earlier alignment if align was large enough to have an\n> > impact.\n> > \n> > Thus, remove the duplicated aligning from pcibios_align_resource().\n> > \n> > Signed-off-by: Ilpo Järvinen \n> > ---\n> > arch/m68k/kernel/pcibios.c | 2 --\n> > 1 file changed, 2 deletions(-)\n> > \n> > diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> > index 1415f6e4e5ce..7e286ee1976b 100644\n> > --- a/arch/m68k/kernel/pcibios.c\n> > +++ b/arch/m68k/kernel/pcibios.c\n> > @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n> > \tif ((res->flags & IORESOURCE_IO) && (start & 0x300))\n> > \t\tstart = (start + 0x3ff) & ~0x3ff;\n> > \n> > -\tstart = (start + align - 1) & ~(align - 1);\n> > -\n> > \treturn start;\n> > }\n> > \n> \n> Sorry if it's a stupid question, but what does \"am68k\" in the subject refer to?\n\nThe extra \"a\" is a typo. I'm sorry about that.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=VLJCkQkf;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18739-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=192.198.163.17","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=VLJCkQkf;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com\n (client-ip=192.198.163.17; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgHlp34Qgz1y1g\n\tfor ; Wed, 25 Mar 2026 04:56:21 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fgHlm3WqKz2ynn;\n\tWed, 25 Mar 2026 04:56:20 +1100 (AEDT)","from mgamail.intel.com (mgamail.intel.com [192.198.163.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fgHlj6sN3z2xVT\n\tfor ; Wed, 25 Mar 2026 04:56:16 +1100 (AEDT)","from fmviesa010.fm.intel.com ([10.60.135.150])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Mar 2026 10:55:45 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.244.217])\n by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Mar 2026 10:55:35 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774374980;\n\tcv=none;\n b=I5XJ4KpGbBrsulfNHLbHHvJDNDGQIG+rfuRNd1cUqoaaAIM7M1mfFiEmnXgMwqQjQuD22ljTuLneQuET3Ri2aecVHC3yn/OrwsHD9TyTYUh3AfdgV9rGkkHp1hRMGGJeJn4rK2TuS4sJdLQ/sXEL5IpjbJYGjn5qFug63CtUdXo0fCJso3HoFRo3h7gMkwWCtIACVa23pfwlmVjh1GAHpyMuBJaH9ULvd6svKegcIfBxT5x8yZQoRibfnpMiDdqPg3l0xhDw5ARbBy84ql0guGgZKDmnXpa2vHLLnCKVj4wSKscfbx1l9Maijif65PVt4a3BHBX1W8BgzdHqaRb6zg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774374980; c=relaxed/relaxed;\n\tbh=o4Skp0d0PaeQO+3Y+N+lz2SpTD1JG+jzc8wIlPQ0pik=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=KGN8eMGWiJIq2uDi+t8/jW+CM5gwzy4a6hoJSrb5v3Dow/M8YHQjzWLgDVvg4CnjlgfsytnKxYbyXRfoEBBy39LNyRz/WRL53cV85pauW5sLMQHf4fokCsSvfcJDrSbh6Psj0DJhV1Ra4NCKBNyCZvzC5wSgB2EV9Wxbi1bmoMLzaLHtmmHbpw5CvK7udOhS+Y1DUeuujxrrqqamXSbSRVqs4gfR0Ape2T2lw9hqe/1DQR2Xc0stwhVjrK0R6Grr6vRfYScPnFaATF2Js8jgU7HDkRza8y+zuxYz+lo5qxZYetOVccrYpnxAg5IXseZUXk2S9wYn6VUFns4ZTU+oHw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=VLJCkQkf; dkim-atps=neutral;\n spf=pass (client-ip=192.198.163.17; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1774374978; x=1805910978;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=NL1mcB9ozeqOSsqCkkguLMRCIYPAgFUo0JaJzh10URc=;\n b=VLJCkQkfa91tOKK4dmtRsr3i3IZLqjakUDrbgumh/0lMn9AxB8/3rEYr\n 3KE5TOevH/O1T9ZvSdL0LMwY7R9LvpjYJtu+LBv8NG0DENM8pfFJyWv6t\n XUKRr+EhOK+TJvbBFOoLl7zf4gJyla0+FsUBvZ8yqceUiaoz2gM9qVwcY\n 6daXTCBfZ9I/doHgckSLKNXx7fmzw5H3xOvPWCg5L0NHQ+OsKphZRIgSb\n M/p9RkXD/Bh4l1NFMFgBrpGEFQLmKYInm9C1uVCn/wuYnTpLx4LCK0Ga1\n 7eqmUCN4jPUDZOd4mSBkMzoKTCghJSBa2+0dMUn8mMYi881cTxad68fwL\n A==;","X-CSE-ConnectionGUID":["nkcW9dEeRjeVvn1jO+arGw==","mUXuAQFLRnadhyMeGmty4g=="],"X-CSE-MsgGUID":["qZdzIr4qR22IMzuFwxUgzA==","bujbx+8xS52CYl9LobjFjg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11739\"; a=\"75307434\"","E=Sophos;i=\"6.23,138,1770624000\";\n d=\"scan'208\";a=\"75307434\"","E=Sophos;i=\"6.23,138,1770624000\";\n d=\"scan'208\";a=\"220002724\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Tue, 24 Mar 2026 19:55:32 +0200 (EET)","To":"John Paul Adrian Glaubitz ","cc":"linux-pci@vger.kernel.org, Bjorn Helgaas ,\n Guenter Roeck , linux-alpha@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org,\n linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,\n linux-sh@vger.kernel.org, Russell King ,\n Geert Uytterhoeven ,\n Thomas Bogendoerfer ,\n \"James E.J. Bottomley\" ,\n Helge Deller , Michael Ellerman ,\n Thomas Gleixner , Ingo Molnar ,\n Borislav Petkov , Dave Hansen ,\n \"H. Peter Anvin\" , Chris Zankel ,\n Max Filippov ,\n Madhavan Srinivasan ,\n Yoshinori Sato ,\n Rich Felker ,\n LKML ","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","In-Reply-To":"\n <5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>","Message-ID":"<1c08efcd-25e8-6436-52ab-ac3d50dcf58f@linux.intel.com>","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>\n <5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-641337346-1774374932=:1055\"","X-Spam-Status":"No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3668643,"web_url":"http://patchwork.ozlabs.org/comment/3668643/","msgid":"","date":"2026-03-24T18:36:27","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","submitter":{"id":4003,"url":"http://patchwork.ozlabs.org/api/people/4003/","name":"John Paul Adrian Glaubitz","email":"glaubitz@physik.fu-berlin.de"},"content":"On Tue, 2026-03-24 at 19:55 +0200, Ilpo Järvinen wrote:\n> On Tue, 24 Mar 2026, John Paul Adrian Glaubitz wrote:\n> \n> > Hi Ilpo,\n> > \n> > On Tue, 2026-03-24 at 18:56 +0200, Ilpo Järvinen wrote:\n> > > Aligning res->start by align inside pcibios_align_resource() is\n> > > unnecessary because caller of pcibios_align_resource() is\n> > > __find_resource_space() that aligns res->start with align before\n> > > calling pcibios_align_resource().\n> > > \n> > > Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> > > result in changing start either because 0x300 bits would have not\n> > > survived the earlier alignment if align was large enough to have an\n> > > impact.\n> > > \n> > > Thus, remove the duplicated aligning from pcibios_align_resource().\n> > > \n> > > Signed-off-by: Ilpo Järvinen \n> > > ---\n> > > arch/m68k/kernel/pcibios.c | 2 --\n> > > 1 file changed, 2 deletions(-)\n> > > \n> > > diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> > > index 1415f6e4e5ce..7e286ee1976b 100644\n> > > --- a/arch/m68k/kernel/pcibios.c\n> > > +++ b/arch/m68k/kernel/pcibios.c\n> > > @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n> > > \tif ((res->flags & IORESOURCE_IO) && (start & 0x300))\n> > > \t\tstart = (start + 0x3ff) & ~0x3ff;\n> > > \n> > > -\tstart = (start + align - 1) & ~(align - 1);\n> > > -\n> > > \treturn start;\n> > > }\n> > > \n> > \n> > Sorry if it's a stupid question, but what does \"am68k\" in the subject refer to?\n> \n> The extra \"a\" is a typo. I'm sorry about that.\n\nNo worries, I just thought I missed something obvious and felt stupid to ask ;-).\n\nAdrian","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256\n header.s=fub01 header.b=MSUm3+Zo;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18740-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org; arc=none smtp.remote-ip=130.133.4.66","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256\n header.s=fub01 header.b=MSUm3+Zo;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=zedat.fu-berlin.de\n (client-ip=130.133.4.66; helo=outpost1.zedat.fu-berlin.de;\n envelope-from=glaubitz@zedat.fu-berlin.de; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgJfR2lR8z1y1G\n\tfor ; Wed, 25 Mar 2026 05:36:46 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fgJfP0gJyz2ynn;\n\tWed, 25 Mar 2026 05:36:45 +1100 (AEDT)","from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de\n [130.133.4.66])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fgJfM6HHVz2ynP\n\tfor ; Wed, 25 Mar 2026 05:36:43 +1100 (AEDT)","from inpost2.zedat.fu-berlin.de ([130.133.4.69])\n by outpost.zedat.fu-berlin.de (Exim 4.99)\n with esmtps (TLS1.3)\n tls TLS_AES_256_GCM_SHA384\n (envelope-from )\n id 1w56c9-00000000BcZ-2HRb; Tue, 24 Mar 2026 19:36:29 +0100","from p5dc55f29.dip0.t-ipconnect.de ([93.197.95.41]\n helo=suse-laptop.fritz.box)\n by inpost2.zedat.fu-berlin.de (Exim 4.99)\n with esmtpsa (TLS1.3)\n tls TLS_AES_256_GCM_SHA384\n (envelope-from )\n id 1w56c9-00000001y8z-0w0E; Tue, 24 Mar 2026 19:36:29 +0100"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774377404;\n\tcv=none;\n b=UTND35+cFlLUAOJ2E8vfnMBM04cLL/Va9xQQgPGbTGNfLm0fc5Ghu2y9ne0PbJacrBJVVowOKCwVjXO9h6cPOvX595X8GLyDa5Pah6qKoxO2vqmI6xeaSCBqhUy0DoEAJ62SzRTyGxmBE2cE8k0hdKiCdLcLRV2kI2g8RwJ028a4IOo/WhKvUb+juMAgslzqx996COJLjcGa4ZcNTFqQfCq74nZKB9o56pwvfejlb321jApCMGM8I4aGSBqvmjuF8Dijyw7n88unWn+jz8aBpopP1prdcvyxVrOspt9c6ZQnWVGVBhWhrqS/A3d5385RqH0LL87eyL63oTTnbECZnQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774377404; c=relaxed/relaxed;\n\tbh=TMacGYMUcDU/ZfxMzZ5qB4lAQfMCgWI9xYNANb/3NJE=;\n\th=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:\n\t Content-Type:MIME-Version;\n b=IYwb8LtbpTumGtIKgZd3xlFG9ywGixHAyua8sO5INZQ6DkQVfqVYWdixtoFmDGpHAexDL4T8RKPt8fMHolwb0DDqLcOmGGEjBgRdS4eDB82VFSBQuXRPep0Riye427+gUNIRXbuYerdJiOJG8JkiMi4j1mO7FZSyzdNt3WUyyBDnkuLni5zZQ/KQ7fI6s5ywjepkm46uGMy+CVGpTgVN3/o2Zqjh5AHsLsyjjUStQEhivod+FKMgEGx+xH+y/FypS82b4nZTYaeIZ4fRxkwjDp94yhYzHmbTupfVGDmG4GfKjtFL5mQjtXp1cYhXgqvqEvTmWfG2w3fjWH3J/6ocLQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de;\n dkim=pass (2048-bit key;\n unprotected) header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256\n header.s=fub01 header.b=MSUm3+Zo; dkim-atps=neutral;\n spf=pass (client-ip=130.133.4.66; helo=outpost1.zedat.fu-berlin.de;\n envelope-from=glaubitz@zedat.fu-berlin.de;\n receiver=lists.ozlabs.org) smtp.mailfrom=zedat.fu-berlin.de","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding:\n\tContent-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:From:\n\tReply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:In-Reply-To:\n\tReferences; bh=TMacGYMUcDU/ZfxMzZ5qB4lAQfMCgWI9xYNANb/3NJE=; t=1774377404;\n\tx=1774982204; b=MSUm3+ZoQTykJpwheR2FNJ18j275eUtz8Kxh2QQNkKBKOEFmDmhJOEUk4FOLi\n\trk7nEJX4Wv3O3so8txnqshnSFvUN4JTROsLC0Zj7ysSsZJLwPLMDkkH+FhEuvPgk9+/3wRj70Xobk\n\taq1kghprHhXpXVnMweP3Gcy+WtujcXDO3C+QWvUsbbUKUoYkLivNjxSdkFbne5li0pcxg6a8k3PNm\n\tLcQAJhUF4yqoCQQ9iVj0L4Dk95yhond0TsUMhV509JK+H3AWP30/SDoLz7A5xFM+Bv6xlPiuO0mV8\n\tf3IEG6BEz8YMU3ZoJSAZ1DwIYryV5o1IgtSJ76VxQukPDtuAtA==;","Message-ID":"\n ","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application\n of align","From":"John Paul Adrian Glaubitz ","To":"Ilpo =?iso-8859-1?q?J=E4rvinen?= ","Cc":"linux-pci@vger.kernel.org, Bjorn Helgaas , Guenter\n Roeck , linux-alpha@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, \tlinux-m68k@lists.linux-m68k.org,\n linux-mips@vger.kernel.org, \tlinux-parisc@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org, \tlinux-s390@vger.kernel.org,\n linux-sh@vger.kernel.org, Russell King\t , Geert\n Uytterhoeven , Thomas Bogendoerfer\n , \"James E.J. Bottomley\"\n , Helge Deller\t ,\n Michael Ellerman , Thomas Gleixner\t ,\n Ingo Molnar , Borislav Petkov , Dave\n Hansen , \"H. Peter Anvin\" ,\n Chris Zankel , Max Filippov ,\n Madhavan Srinivasan , Yoshinori Sato\t\n , Rich Felker , LKML\t\n ","Date":"Tue, 24 Mar 2026 19:36:27 +0100","In-Reply-To":"<1c08efcd-25e8-6436-52ab-ac3d50dcf58f@linux.intel.com>","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n\t <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>\n\t <5de97ed9556bfcc3b1f26bd71e09fa4016ae3ff8.camel@physik.fu-berlin.de>\n\t <1c08efcd-25e8-6436-52ab-ac3d50dcf58f@linux.intel.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.58.3 ","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","X-Original-Sender":"glaubitz@physik.fu-berlin.de","X-Originating-IP":"93.197.95.41","X-ZEDAT-Hint":"PO","X-Spam-Status":"No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3670037,"web_url":"http://patchwork.ozlabs.org/comment/3670037/","msgid":"","date":"2026-03-27T02:55:55","subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of\n align","submitter":{"id":70179,"url":"http://patchwork.ozlabs.org/api/people/70179/","name":"Greg Ungerer","email":"gerg@linux-m68k.org"},"content":"On 25/3/26 02:56, Ilpo Järvinen wrote:\n> Aligning res->start by align inside pcibios_align_resource() is\n> unnecessary because caller of pcibios_align_resource() is\n> __find_resource_space() that aligns res->start with align before\n> calling pcibios_align_resource().\n> \n> Aligning by align in case of IORESOURCE_IO && start & 0x300 cannot ever\n> result in changing start either because 0x300 bits would have not\n> survived the earlier alignment if align was large enough to have an\n> impact.\n> \n> Thus, remove the duplicated aligning from pcibios_align_resource().\n> \n> Signed-off-by: Ilpo Järvinen \n\nLGTM.\n\nAcked-by: Greg Ungerer \n\n\n> ---\n> arch/m68k/kernel/pcibios.c | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/arch/m68k/kernel/pcibios.c b/arch/m68k/kernel/pcibios.c\n> index 1415f6e4e5ce..7e286ee1976b 100644\n> --- a/arch/m68k/kernel/pcibios.c\n> +++ b/arch/m68k/kernel/pcibios.c\n> @@ -36,8 +36,6 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,\n> \tif ((res->flags & IORESOURCE_IO) && (start & 0x300))\n> \t\tstart = (start + 0x3ff) & ~0x3ff;\n> \n> -\tstart = (start + align - 1) & ~(align - 1);\n> -\n> \treturn start;\n> }\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-18868-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=srs0=nmqu=b3=linux-m68k.org=gerg@kernel.org;\n receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fhldm2m85z1yFp\n\tfor ; Fri, 27 Mar 2026 13:56:12 +1100 (AEDT)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fhldl1pNHz2yT0;\n\tFri, 27 Mar 2026 13:56:11 +1100 (AEDT)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fhldj5xcqz2xR4\n\tfor ; Fri, 27 Mar 2026 13:56:09 +1100 (AEDT)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 3B0DC60054;\n\tFri, 27 Mar 2026 02:56:06 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 62989C116C6;\n\tFri, 27 Mar 2026 02:55:59 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1774580171;\n\tcv=none;\n b=eoyZPAzY08nzJ8/XWFDFHPpAi+fIRd9VM4L2aifiyLvatDuxmUWZtrWIVKuVFKIouESyz3EmLxKk0FYiO0sKHWoEffrJA/MAZsFUccVBSomW6qah8fU5pICQilzFQgSfy0v6lCKSpXlYA/yb/XfNWxOGgVEXI4gnT8fGLrCO88hAlzfMqhnGQIaZdk/36L2JfMGzD55T9Q2fnPy2S91UAmJ/cwCDoPUe/dfawER0SlB0/2A3OwWdBSQAnKBGPgG94onBlIqdEYEdItmOfH5+51q682uTJCEC9nCY/XgEzWLf3kP6IsboUPO9iBWoxOUZQBLuDPQZ0zHOemNaS9KOzQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1774580171; c=relaxed/relaxed;\n\tbh=/x34Ij2kuXzsnJRKdh7n98HuULH2/zRsLD1v43nFDFY=;\n\th=Message-ID:Date:MIME-Version:Subject:To:References:From:\n\t In-Reply-To:Content-Type;\n b=hP7gJbf0zUG1n9j2YUzmRJAU5E2fAf1h+WKPJH15kOxfyII6D2FG5uLbTVaNVk+3KPBaaFj30/XnPNH1PsSW71B2Y2+uv8AnSDKI6uOMSgGtuHYlgYxJ9vvcgDDABTsY20mM+/+7XQ7Tg/rcQkvo/NIWcA7hOyTv9Z9gq5wncHmeSZbE//IXv8pyIk6/+bXbasQ95bhl34/Q1N/B8Dgcn6ilL71DePU8rSwu7LAvqFhp8ZoO+WpXQZ/04QMjQstyOg3LWOCBOywCal+pYNZ0nnzkubZ2RX9L0+1FoctDGYoXkKq2Ue95UvHR7afdcLcxr9h93SG18lpJ+g/3hVBXlw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=linux-m68k.org;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org;\n envelope-from=srs0=nmqu=b3=linux-m68k.org=gerg@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","Message-ID":"","Date":"Fri, 27 Mar 2026 12:55:55 +1000","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 05/10] am68k/PCI: Remove unnecessary second application of\n align","To":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, Bjorn Helgaas ,\n Guenter Roeck , linux-alpha@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org,\n linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,\n linux-sh@vger.kernel.org, Russell King ,\n Geert Uytterhoeven ,\n Thomas Bogendoerfer ,\n \"James E.J. Bottomley\" ,\n Helge Deller , Michael Ellerman ,\n Thomas Gleixner , Ingo Molnar ,\n Borislav Petkov , Dave Hansen ,\n \"H. Peter Anvin\" , Chris Zankel ,\n Max Filippov , Madhavan Srinivasan ,\n Yoshinori Sato , Rich Felker ,\n John Paul Adrian Glaubitz ,\n linux-kernel@vger.kernel.org","References":"<20260324165633.4583-1-ilpo.jarvinen@linux.intel.com>\n <20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","Content-Language":"en-US","From":"Greg Ungerer ","In-Reply-To":"<20260324165633.4583-6-ilpo.jarvinen@linux.intel.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=0.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]