[{"id":3669372,"web_url":"http://patchwork.ozlabs.org/comment/3669372/","msgid":"","list_archive_url":null,"date":"2026-03-25T22:53:02","subject":"Re: [PATCH] testsuite: only include some plugin tests when testing\n in build tree","submitter":{"id":24465,"url":"http://patchwork.ozlabs.org/api/people/24465/","name":"David Malcolm","email":"dmalcolm@redhat.com"},"content":"On Tue, 2026-03-24 at 17:41 +0100, Torbjörn SVENSSON wrote:\n> Ok for trunk?\n> \n> --\n> \n> As progress_notifications_plugin.cc requires topics/pass-events.h,\n> but\n> the header file is not included in the header files to install, the\n> test\n> case does not work when doing out of build tree testing.\n\nSorry about the breakage.\n\nMy intent was for this header file to be installed; can it be fixed\nthat way instead?\n\nDave\n\n> \n> gcc/testsuite/ChangeLog:\n> \n> \t* gcc.dg/plugin/plugin.exp: Only include\n> \tprogress_notifications_plugin.cc when testing in build tree.\n> \n> Signed-off-by: Torbjörn SVENSSON \n> ---\n>  gcc/testsuite/gcc.dg/plugin/plugin.exp | 9 ++++++++-\n>  1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/gcc/testsuite/gcc.dg/plugin/plugin.exp\n> b/gcc/testsuite/gcc.dg/plugin/plugin.exp\n> index deef8e8570c..994bfedd9ac 100644\n> --- a/gcc/testsuite/gcc.dg/plugin/plugin.exp\n> +++ b/gcc/testsuite/gcc.dg/plugin/plugin.exp\n> @@ -200,9 +200,16 @@ set plugin_test_list [list \\\n>  \t  cpython-plugin-test-PyList_Append.c \\\n>  \t  cpython-plugin-test-PyList_New.c \\\n>  \t  cpython-plugin-test-PyLong_FromLong.c } \\\n> -    { progress_notifications_plugin.cc } \\\n>  ]\n>  \n> +\n> +global TESTING_IN_BUILD_TREE\n> +\n> +if { [info exists TESTING_IN_BUILD_TREE] } {\n> +    lappend plugin_test_list \\\n> +\t{ progress_notifications_plugin.cc } \\\n> +}\n> +\n>  foreach plugin_test $plugin_test_list {\n>      # Replace each source file with its full-path name\n>      for {set i 0} {$i < [llength $plugin_test]} {incr i} {","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=N9OTmmww;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=N9OTmmww","sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","sourceware.org; spf=pass smtp.mailfrom=redhat.com","server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fh2KP053Gz1xy1\n\tfor ; Thu, 26 Mar 2026 09:54:32 +1100 (AEDT)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id B1B914B9DB7D\n\tfor ; Wed, 25 Mar 2026 22:54:30 +0000 (GMT)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id 31B2E4B9DB7D\n for ; Wed, 25 Mar 2026 22:53:07 +0000 (GMT)","from mail-qv1-f72.google.com (mail-qv1-f72.google.com\n [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-359-XmWgpstRNy-HZmi64zqXAA-1; Wed, 25 Mar 2026 18:53:05 -0400","by mail-qv1-f72.google.com with SMTP id\n 6a1803df08f44-8950562d351so15115206d6.3\n for ; Wed, 25 Mar 2026 15:53:05 -0700 (PDT)","from t14s.localdomain (c-73-38-242-98.hsd1.nh.comcast.net.\n [73.38.242.98]) by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-89cd5855269sm9386526d6.8.2026.03.25.15.53.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 Mar 2026 15:53:03 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org B1B914B9DB7D","OpenDKIM Filter v2.11.0 sourceware.org 31B2E4B9DB7D"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 31B2E4B9DB7D","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 31B2E4B9DB7D","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774479187; cv=none;\n b=htolxAATte8x27Iiq1pm3rB9ZmuR3qlZAcM66szxsp3tK8bgsCB8pMP8f7JMcdNbwPW6XqknPznOJwyuR6ij/1R1ITONZw8SQj1ZXBJhzLYPmUXAnNaac0nT31FIvzRV8vTGYLU2K+ZweXM7UfcgxMenmLYS3w1XtxLeKZ8LzZI=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1774479187; c=relaxed/simple;\n bh=RpncawXhlzAygboKwO0/2RC/mSlNf+m5aBHxXiJuBII=;\n h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version;\n b=ueypVjaGwVB3LdB+8Xo0dDpxJGA1miksc1P3aB1bAKH0KsM7Xqs5wwj6+FTq8wl4KUT1JtCfBFCVK+LewgRDuAnHD3a0cvv2XL5M2wRyK42O/ap907bRt9Nufvm3E88rUiU3jtZQPfgLChwRu+Z0/TAFizjmN0vHjmCSxXi3NDU=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1774479186;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RpncawXhlzAygboKwO0/2RC/mSlNf+m5aBHxXiJuBII=;\n b=N9OTmmwwC552g9J6Bhud/MU6Mb1wp9w9AM4NUPi1XXLseR77lLmN4zrWmrsWsnW0GKKGz8\n 1jk3BVuVeiRjCJKVPR5wn9F2957jIfYojU9ptPjjKclRgZrjHwpYnR3Z8vvq0mCU5a/3K9\n nZSc0uDC/0N603NJSEXj9A74AvgkVbI=","X-MC-Unique":"XmWgpstRNy-HZmi64zqXAA-1","X-Mimecast-MFC-AGG-ID":"XmWgpstRNy-HZmi64zqXAA_1774479185","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774479184; x=1775083984;\n h=mime-version:user-agent:content-transfer-encoding:references\n :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=4wpP2s5kfuA5S5uSkbTPjySG0UCr3/sm6Q/eRiylQ0k=;\n b=VubVw7bq55/bK9uvyIoaBvg0tNwfo/NW7EvGxUFzQ0X44i3bjWPZsegiQklz3m3MMB\n e8XCm43hPnkkHKSH34egF4Ugq3G+JvWQFEcWrxc1rU+J9loMjNE1RXJsp5SgYlNtC35k\n txohsYk62koPDqGZvC8HdKf+499mgTiBuiW6CsifK+lDA4Z0oEeRFhKWX6vGzuoKUUnO\n VgLZnn74hk/MzWo3x/TCBcrst/Za09NUiVOg2SBT/18tSiK1+/BNWEEZFsIMPWf9hAvr\n tq47pRRFNKjkl6B4aJ1uDQa7Z/GeFJ8FPdEzn7gmZpmClCkoaNw9zLELbGAW4juHy4so\n rTOQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVXSwtVVjev1bquTvnTmByjOtJ8MpMqvOsIjsKRlyVO+mlmm2OancCY1C9aulfe4ynJSlEKa+4Q+uM5zQ==@gcc.gnu.org","X-Gm-Message-State":"AOJu0YwQ+vueAGCniH0dTIWsVdbo8rToDipSPZzFo+GS37BCI9CMpTDz\n dvrVfTW6QbYnDrCAcOckRfqtV0hmLd6u5X7MyjBTW34mz8eOCBg7kltX36PxMZf6wEb9V4d2rek\n 4Cf4i3IedFw/M4/VPPtqkkgldT1NNWnTdDlOc57UEQZ1KBF7vB+C0Ui/tcv+5cMXLyyI=","X-Gm-Gg":"ATEYQzzUNQFgt89LKTGtV+siiWKwwyhRxA1CHbxkxWYuMwYGAmUoPIdon/ukhv5NXQD\n wUhZOynSFI4ea+Lv0GOWX8ku6NFzH+rRE4F71A0oLozA54pBZIh3SMD+np5zL/hLHOBvmqZ8Ilm\n ILR7ro4N8WcOCj+zp6NOEfsCirjhUSyyvfm1RjPDaNEhhD5xIlkaHL4vp3dNX/SWMfAcEyaKm0C\n bWmXus4enUrhnIFtEm/RH0wzvFUmcNK6SUdExREE1DHzdy9mewYKyWREPSYJHEBi7UvVwXGmGif\n uEaHD8gwTG65qHIjVUZhssA+E+nWQuWJAgOOXPT51bS4lvTtyhJkDtwVewuCFr9qtUTm095vgY8\n KrDUO/LY72QG2Ikm901VgiHYoB6eMt5pM+zGCz+jTa8MoXpPnv6awPz1vGMdq+w==","X-Received":["by 2002:a05:6214:110f:b0:89c:8681:36fa with SMTP id\n 6a1803df08f44-89cc4adc5e5mr63759296d6.32.1774479184397;\n Wed, 25 Mar 2026 15:53:04 -0700 (PDT)","by 2002:a05:6214:110f:b0:89c:8681:36fa with SMTP id\n 6a1803df08f44-89cc4adc5e5mr63759046d6.32.1774479183930;\n Wed, 25 Mar 2026 15:53:03 -0700 (PDT)"],"Message-ID":"","Subject":"Re: [PATCH] testsuite: only include some plugin tests when testing\n in build tree","From":"David Malcolm ","To":"=?iso-8859-1?q?Torbj=F6rn?= SVENSSON ,\n gcc-patches@gcc.gnu.org","Cc":"rguenther@suse.de","Date":"Wed, 25 Mar 2026 18:53:02 -0400","In-Reply-To":"<20260324164153.991098-1-torbjorn.svensson@foss.st.com>","References":"<20260324164153.991098-1-torbjorn.svensson@foss.st.com>","User-Agent":"Evolution 3.54.3 (3.54.3-1.fc41)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"OCP5w9eo0RZKezfTN3itUioMvhTpnM_lLrA_Bj6NeY0_1774479185","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]