[{"id":3668942,"web_url":"http://patchwork.ozlabs.org/comment/3668942/","msgid":"","list_archive_url":null,"date":"2026-03-25T10:01:33","subject":"Re: [PATCH 1/4] tests/functional/qemu_test: Silence warnings from\n pylint in tesseract.py","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 24/3/26 17:35, Thomas Huth wrote:\n> From: Thomas Huth \n> \n> Pylint complains:\n> \n> tesseract.py:1:0: C0114: Missing module docstring (missing-module-docstring)\n> tesseract.py:12:0: C0116: Missing function or method docstring (missing-function-docstring)\n> tesseract.py:15:11: W1510: 'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check)\n> tesseract.py:12:30: W0613: Unused argument 'tesseract_args' (unused-argument)\n> \n> Thus add the missing bits and remove the unused tesseract_args argument.\n> While we're at it, also add a SPDX identifier instead of the weird three\n> dots at the beginning of the file.\n\nI'm OK to remove the boilerplate if possible.\n\n> \n> Signed-off-by: Thomas Huth \n> ---\n> tests/functional/qemu_test/tesseract.py | 11 ++++++++---\n> 1 file changed, 8 insertions(+), 3 deletions(-)\n> \n> diff --git a/tests/functional/qemu_test/tesseract.py b/tests/functional/qemu_test/tesseract.py\n> index ede6c6501e2..1f955d32b76 100644\n> --- a/tests/functional/qemu_test/tesseract.py\n> +++ b/tests/functional/qemu_test/tesseract.py\n> @@ -1,19 +1,24 @@\n> -# ...\n> +# SPDX-License-Identifier: GPL-2.0-or-later\n> #\n> # Copyright (c) 2019 Philippe Mathieu-Daudé \n> #\n> # This work is licensed under the terms of the GNU GPL, version 2 or\n> # later. See the COPYING file in the top-level directory.\n> +'''\n> +Tesseract is an program for doing Optical Character Recognition (OCR),\n> +which can be used in the tests to extract text from screenshots.\n> +'''\n> \n> import logging\n> from subprocess import run\n> \n> \n> -def tesseract_ocr(image_path, tesseract_args=''):\n> +def tesseract_ocr(image_path):\n> + ''' Run the tesseract OCR to extract text from a screenshot '''\n> console_logger = logging.getLogger('console')\n> console_logger.debug(image_path)\n> proc = run(['tesseract', image_path, 'stdout'],\n> - capture_output=True, encoding='utf8')\n> + capture_output=True, encoding='utf8', check=False)\n> if proc.returncode:\n> return None\n> lines = []","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=vu3yvT0W;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fgj9v2242z1y1K\n\tfor ; Wed, 25 Mar 2026 21:01:55 +1100 (AEDT)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1w5L3a-0003r7-2N; Wed, 25 Mar 2026 06:01:46 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1w5L3V-0003qp-Rb\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 06:01:41 -0400","from mail-wr1-x436.google.com ([2a00:1450:4864:20::436])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1w5L3T-0000GU-9t\n for qemu-devel@nongnu.org; Wed, 25 Mar 2026 06:01:40 -0400","by mail-wr1-x436.google.com with SMTP id\n ffacd0b85a97d-43b4f48c47cso3479304f8f.0\n for ; Wed, 25 Mar 2026 03:01:38 -0700 (PDT)","from [192.168.69.206] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43b8567b2e2sm9756592f8f.33.2026.03.25.03.01.34\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 25 Mar 2026 03:01:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1774432897; x=1775037697; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=fjq4qaSm2IJyF4iuo1WIa15QF+BvbcTPQUswLNfIyqM=;\n b=vu3yvT0W6dXmeyK1RK0G/Y2+sd5R7CxNbKrRTveBBdSzMMqkEJVMsNY/1ftdV4BMPp\n ASIRbQAhhgF1MQw9bs5JSBLDKXD7VOpWThHQ2rZEFrrcyEZ94Hjp0Cu9Eb2c8kMGjJSg\n CkUfEXEYInvF6ic/bLBs/dryQUQ/t2IgoTLhgZN8OXzHuAaRgLvXlRYor8y/8PhoAumW\n ZoKzdhqPZJ8bf5roJWoG2ZWBKnr+ltGJ1NhfJyi39JCce13kQBMCTorNDkLzZxnGxSMg\n eetMhEk8LBeSFB27AQt9tMKxb+TokBn5zdlcZDrDa2Qpz8BixoUO467UDRVd09jFRqv/\n lmXQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1774432897; x=1775037697;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=fjq4qaSm2IJyF4iuo1WIa15QF+BvbcTPQUswLNfIyqM=;\n b=VRuPZcd6Goae7kUzw9reKZgZKfJCJ+h67alNivkAvc99j/M4HXVAksPyUcJHB8k8RW\n YtrFuDM1Fuzkxg+uXttaLaXqORsMBokUPyQMVkV0qnU3BUjVrABtyKn+0ZSCW4Qiltqb\n f2yqOGuDdlzAt2/Tfznp/hDkPswHj6tHS0UjPaqMMv7ED4TSUgCWEhOBPdZb3vYFAOKD\n WRGNop5L2AXHh8sN5hNDVP7HrDB4et7Qomu8cPNVEIOeng6wLL/+2W9/WtFuMsBAKjwM\n qzL2rbknQvyi6SPVUNPbAdSL+3G5nLSiPpU9e5HiyKOkbfz/QZN4sS0xiY1GBQ7Y0QKc\n JZow==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUyVvmj+xhOatxnfbL28W2S7Thn3SSbSumX3fl5FZskg0nYYhRkZs6O5pbVyW4FszTDHrfxsD+7oUPq@nongnu.org","X-Gm-Message-State":"AOJu0Yw9syMqIDffl5kyPjnfuL1VAhkJnq+i4tw5/IPC3df5n/3e2KHj\n ebkcxaxt47/EP7J5D5DnRwZG5+9x5a5p5gs85BgP4okdLC4GW/n8IxXEFeRJ1QdnNDQ=","X-Gm-Gg":"ATEYQzwZr5YnIs7KbBl70BS3aDH9aOpoQO0ct5iUkF3/VEzozjvgi1cDeues7fX64R1\n 74KchpE0BbZTANZNIzSJGHF0jsFPWWva62Ro+S7Xkr8rr8RYKc/eiuBlnUIVuaQ7eQ8bbgXzW74\n TXjpDbTD4aTVGL3Fs6PGIifLTKDd9Bz6hniUEAePZ0fc25PRjEF+ENT1moyMeHj4UpkQdVe2W0j\n th9L3G3rdOvAtwyZXrkNLb/bcj4bHkwnBwFT6tjhH7cezaMWft+QpM2WaWd9U8odn1BKKFJ3ebA\n F1IHxvT6QBvV0f5/CGPCM8D9y8bPzL1OOILSega6jLW+2ULNwpi/b/Q5x9B85Vkpojq+DzMv3bM\n nsZuIXhGYJdcU84zXUl0TvWO2HfEhTBiUYDYpsNlzd2B6Bsq2N2v9lUsWPvoeBJpy29n+uKOr2k\n /2WI1iZgQNjeoP8Yo/M3BjCYj7pG+Mck92WS60ONYuSjzKxMHBmh2MFLMyqatdScfQ7w==","X-Received":"by 2002:a5d:64c4:0:b0:43b:4469:d31b with SMTP id\n ffacd0b85a97d-43b889a49d4mr4104029f8f.15.1774432895323;\n Wed, 25 Mar 2026 03:01:35 -0700 (PDT)","Message-ID":"","Date":"Wed, 25 Mar 2026 11:01:33 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/4] tests/functional/qemu_test: Silence warnings from\n pylint in tesseract.py","Content-Language":"en-US","To":"Thomas Huth , qemu-devel@nongnu.org","Cc":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","References":"<20260324163543.55503-1-thuth@redhat.com>\n <20260324163543.55503-2-thuth@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260324163543.55503-2-thuth@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::436;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]